principles-disciple 1.24.0 → 1.25.0

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "principles-disciple",
   "name": "Principles Disciple",
   "description": "Evolutionary programming agent framework with strategic guardrails and reflection loops.",
-  "version": "1.24.0",
+  "version": "1.25.0",
   "skills": [
     "./skills"
   ],
@@ -76,8 +76,8 @@
     }
   },
   "buildFingerprint": {
-    "gitSha": "ebbaa40d6e3a",
-    "bundleMd5": "7c84860901894f7c049b54028d489ed4",
-    "builtAt": "2026-04-12T15:51:34.724Z"
+    "gitSha": "6c8a61389b46",
+    "bundleMd5": "2803099a748622cc50286ad4c55be551",
+    "builtAt": "2026-04-13T02:02:51.311Z"
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "principles-disciple",
-  "version": "1.24.0",
+  "version": "1.25.0",
   "description": "Native OpenClaw plugin for Principles Disciple",
   "type": "module",
   "main": "./dist/bundle.js",

package/scripts/diagnose-nocturnal.mjs

@@ -126,6 +126,9 @@ function main() {
         if (data.sessionId && data.lastActivityAt) validSessions++;
       } catch { /* corrupted, skip */ }
     }
+    if (validSessions === 0) {
+      return { status: 'warn', detail: `${files.length} session file(s) found but none are valid JSON — idle check will likely report idle immediately` };
+    }
     return `${files.length} session files, ${validSessions} valid with sessionId+lastActivityAt`;
   });
 
@@ -221,7 +224,7 @@ function main() {
     if (active.length > 0) {
       return { status: 'warn', detail: `${active.length} workflow(s) still active — may be in progress or stuck. IDs: ${active.map(w => w.workflow_id).join(', ')}` };
     }
-    return `${workflows.length} total: ${completed} completed, ${errored} errored, ${expired} expired`;
+    return `${workflows.length} total: ${completed.length} completed, ${errored.length} errored, ${expired.length} expired`;
   });
 
   // ─────────────────────────────────────────────────────────
@@ -318,10 +321,14 @@ function main() {
         fields[line.substring(0, colonIdx).trim()] = line.substring(colonIdx + 1).trim();
       }
     }
-    if (!fields.score || !fields.reason) {
-      return { status: 'warn', detail: 'Pain flag exists but is missing required fields (score, reason)' };
+    // Accept either the legacy contract (fields.score + fields.reason)
+    // or the current contract (active.source.score)
+    const legacy = fields.score && fields.reason;
+    const current = fields.active && fields.source && fields.score;
+    if (!legacy && !current) {
+      return { status: 'warn', detail: 'Pain flag exists but is missing required fields (need score + reason, or active.source.score)' };
     }
-    return `Pain flag active (score: ${fields.score}, source: ${fields.source || 'unknown'}, session: ${fields.session_id || 'none'})`;
+    return `Pain flag active (score: ${fields.score}, source: ${fields.source || fields.active?.source || 'unknown'}, session: ${fields.session_id || 'none'})`;
   });
 
   // ─────────────────────────────────────────────────────────

package/src/service/evolution-worker.ts

@@ -1003,6 +1003,7 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                             logger: api?.logger || logger,
                             // eslint-disable-next-line @typescript-eslint/no-non-null-assertion -- Reason: api is guaranteed non-null in this recovery path where runtimeAdapter is required
                             runtimeAdapter: new OpenClawTrinityRuntimeAdapter(api!),
+                            subagent: api?.runtime?.subagent,
                         });
                         try {
                             // Force-expire this specific workflow regardless of TTL
@@ -1596,6 +1597,7 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                         stateDir: wctx.stateDir,
                         logger: api.logger,
                         runtimeAdapter: new OpenClawTrinityRuntimeAdapter(api),
+                        subagent: api.runtime.subagent,
                     });
 
                     if (!isPollingTask) {
@@ -2096,6 +2098,7 @@ export const EvolutionWorkerService: ExtendedEvolutionWorkerService = {
                                 stateDir: wctx.stateDir,
                                 logger: api.logger,
                                 runtimeAdapter: new OpenClawTrinityRuntimeAdapter(api),
+                                subagent: api.runtime.subagent,
                             });
                             swept += await nocturnalMgr.sweepExpiredWorkflows(WORKFLOW_TTL_MS, subagentRuntime, agentSession);
                             nocturnalMgr.dispose();

package/src/service/nocturnal-runtime.ts

@@ -560,7 +560,8 @@ export function checkPreflight(
     stateDir: string,
     principleId?: string,
     trajectoryLastActivityAt?: number,
-    idleCheckOverride?: IdleCheckResult
+    idleCheckOverride?: IdleCheckResult,
+    skipGatesForManualTrigger?: boolean
 ): PreflightCheckResult {
     const idle = idleCheckOverride ?? checkWorkspaceIdle(workspaceDir, {}, trajectoryLastActivityAt);
     const cooldown = checkCooldown(stateDir, principleId);
@@ -571,16 +572,20 @@ export function checkPreflight(
         blockers.push(`Workspace not idle (active for ${idle.idleForMs}ms, threshold=${DEFAULT_IDLE_THRESHOLD_MS}ms)`);
     }
 
-    if (cooldown.globalCooldownActive) {
-        blockers.push(`Global cooldown active until ${cooldown.globalCooldownUntil}`);
-    }
+    if (!skipGatesForManualTrigger) {
+        if (cooldown.globalCooldownActive) {
+            blockers.push(`Global cooldown active until ${cooldown.globalCooldownUntil}`);
+        }
 
-    if (cooldown.principleCooldownActive) {
-        blockers.push(`Principle cooldown active until ${cooldown.principleCooldownUntil}`);
-    }
+        if (cooldown.principleCooldownActive) {
+            blockers.push(`Principle cooldown active until ${cooldown.principleCooldownUntil}`);
+        }
 
-    if (cooldown.quotaExhausted) {
-        blockers.push(`Quota exhausted (${DEFAULT_MAX_RUNS_PER_WINDOW} runs per ${DEFAULT_QUOTA_WINDOW_MS / 3600000}h window)`);
+        if (cooldown.quotaExhausted) {
+            blockers.push(`Quota exhausted (${DEFAULT_MAX_RUNS_PER_WINDOW} runs per ${DEFAULT_QUOTA_WINDOW_MS / 3600000}h window)`);
+        }
+    } else if (cooldown.globalCooldownActive || cooldown.principleCooldownActive || cooldown.quotaExhausted) {
+        // Log that gates are being bypassed for manual trigger
     }
 
     if (idle.abandonedSessionIds.length > 0 && idle.userActiveSessions === 0) {

package/src/service/nocturnal-service.ts

@@ -686,7 +686,8 @@ export function executeNocturnalReflection(
     stateDir,
     undefined, // principleId
     undefined, // trajectoryLastActivityAt
-    options.idleCheckOverride
+    options.idleCheckOverride,
+    !!options.idleCheckOverride // skip cooldown/quota gates for manual/test triggers
   );
   diagnostics.preflight = preflight;
 
@@ -920,11 +921,15 @@ export function executeNocturnalReflection(
   // -------------------------------------------------------------------------
   // Step 6: Arbiter validation
   // -------------------------------------------------------------------------
+  // #256: Use 0 for thinkingModelDeltaMin — Trinity chain (Dreamer→Philosopher→Scribe)
+  // already ensures quality. A delta of 0 is valid when both bad and better decisions
+  // show equally well-reasoned thinking (the Scribe's job is to contrast decisions,
+  // not to make one sound more "cognitive" than the other).
   const arbiterResult = parseAndValidateArtifact(rawJson, {
     expectedPrincipleId: selectedPrincipleId,
     expectedSessionId: selectedSessionId,
     qualityThresholds: {
-      thinkingModelDeltaMin: 0.01,
+      thinkingModelDeltaMin: 0,
       planningRatioGainMin: -0.5,
     },
   });
@@ -1153,7 +1158,8 @@ async function executeNocturnalReflectionWithAdapter(
     stateDir,
     undefined,
     undefined,
-    options.idleCheckOverride
+    options.idleCheckOverride,
+    !!options.idleCheckOverride // skip cooldown/quota gates for manual/test triggers
   );
   diagnostics.preflight = preflight;
 
@@ -1354,11 +1360,12 @@ async function executeNocturnalReflectionWithAdapter(
   }
 
   // Step 5: Arbiter validation
+  // #256: Use 0 for thinkingModelDeltaMin — Trinity chain already ensures quality
   const arbiterResult = parseAndValidateArtifact(rawJson, {
     expectedPrincipleId: selectedPrincipleId,
     expectedSessionId: selectedSessionId,
     qualityThresholds: {
-      thinkingModelDeltaMin: 0.01,
+      thinkingModelDeltaMin: 0,
       planningRatioGainMin: -0.5,
     },
   });

package/src/service/nocturnal-target-selector.ts

@@ -347,11 +347,13 @@ export class NocturnalTargetSelector {
     }
 
     // Step 2: Cooldown and quota check
+    // #256: Skip cooldown/quota for manual/test triggers (idleCheckOverride present)
+    const skipGates = !!this.idleCheckOverride;
     const cooldownResult = checkCooldown(this.stateDir);
     diagnostics.cooldownCheckPassed = !cooldownResult.globalCooldownActive;
     diagnostics.quotaCheckPassed = !cooldownResult.quotaExhausted;
 
-    if (cooldownResult.globalCooldownActive) {
+    if (!skipGates && cooldownResult.globalCooldownActive) {
       return {
         decision: 'skip',
         skipReason: 'global_cooldown_active',
@@ -359,7 +361,7 @@ export class NocturnalTargetSelector {
       };
     }
 
-    if (cooldownResult.quotaExhausted) {
+    if (!skipGates && cooldownResult.quotaExhausted) {
       return {
         decision: 'skip',
         skipReason: 'quota_exhausted',

package/src/service/subagent-workflow/nocturnal-workflow-manager.ts

@@ -41,6 +41,7 @@ import type { RecentPainContext } from '../evolution-worker.js';
 import * as fs from 'fs';
 import * as path from 'path';
 import { validateNocturnalSnapshotIngress } from '../../core/nocturnal-snapshot-contract.js';
+import { isSubagentRuntimeAvailable } from '../../utils/subagent-probe.js';
 
 // ─────────────────────────────────────────────────────────────────────────────
 // NocturnalResult Type Alias
@@ -65,6 +66,8 @@ export interface NocturnalWorkflowOptions {
     logger: PluginLogger;
     /** Trinity runtime adapter for subagent execution */
     runtimeAdapter: TrinityRuntimeAdapter;
+    /** Subagent runtime for availability probing (#254) */
+    subagent?: { run?: unknown };
 }
 
 // ─────────────────────────────────────────────────────────────────────────────
@@ -138,6 +141,7 @@ export class NocturnalWorkflowManager implements WorkflowManager {
     private readonly stateDir: string;
     private readonly logger: PluginLogger;
     private readonly runtimeAdapter: TrinityRuntimeAdapter;
+    private readonly subagent: { run?: unknown } | undefined;
     private readonly store: WorkflowStore;
 
     /** Tracks completion timestamps for idempotency */
@@ -156,6 +160,7 @@ export class NocturnalWorkflowManager implements WorkflowManager {
         this.stateDir = opts.stateDir;
         this.logger = opts.logger;
         this.runtimeAdapter = opts.runtimeAdapter;
+        this.subagent = opts.subagent;
         this.store = new WorkflowStore({ workspaceDir: opts.workspaceDir });
     }
 
@@ -172,8 +177,9 @@ export class NocturnalWorkflowManager implements WorkflowManager {
             metadata?: Record<string, unknown>;
         }
     ): Promise<WorkflowHandle> {
-        const runtimeAvailable = this.runtimeAdapter.isRuntimeAvailable();
-        if (!runtimeAvailable) {
+        // #254: Use isSubagentRuntimeAvailable instead of runtimeAdapter.isRuntimeAvailable()
+        // (which always returns true in OpenClawTrinityRuntimeAdapter)
+        if (!isSubagentRuntimeAvailable(this.subagent)) {
             this.logger.warn(`[PD:NocturnalWorkflow] Subagent runtime unavailable, skipping workflow`);
             throw new Error(`NocturnalWorkflowManager: subagent runtime unavailable`);
         }