principles-disciple 1.17.0 → 1.18.0

package/src/service/evolution-worker.ts

@@ -173,7 +173,7 @@ let timeoutId: NodeJS.Timeout | null = null;
  * Old queue items (without taskKind) are migrated to pain_diagnosis for compatibility.
  */
 export type QueueStatus = 'pending' | 'in_progress' | 'completed' | 'failed' | 'canceled';
-export type TaskResolution = 'marker_detected' | 'auto_completed_timeout' | 'failed_max_retries' | 'runtime_unavailable' | 'canceled' | 'late_marker_principle_created' | 'late_marker_no_principle' | 'stub_fallback';
+export type TaskResolution = 'marker_detected' | 'auto_completed_timeout' | 'failed_max_retries' | 'runtime_unavailable' | 'canceled' | 'late_marker_principle_created' | 'late_marker_no_principle' | 'stub_fallback' | 'skipped_thin_violation';
 
 /**
  * Recent pain context attached to sleep_reflection tasks.
@@ -1595,13 +1595,14 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                             const errorReason = lastEvent?.reason ?? 'unknown';
                             // #219: Include payload details for better diagnostics
                             let detailedError = `Workflow terminal_error: ${errorReason}`;
+                            let payload: unknown = {};
                             try {
-                                const payload = lastEvent?.payload ?? {};
-                                if (payload.skipReason) {
-                                    detailedError += ` (skipReason: ${payload.skipReason})`;
+                                payload = lastEvent?.payload ?? {};
+                                if ((payload as any).skipReason) {
+                                    detailedError += ` (skipReason: ${(payload as any).skipReason})`;
                                 }
-                                if (payload.failures && Array.isArray(payload.failures) && payload.failures.length > 0) {
-                                    detailedError += ` | failures: ${(payload.failures as string[]).slice(0, 3).join(', ')}`;
+                                if ((payload as any).failures && Array.isArray((payload as any).failures) && (payload as any).failures.length > 0) {
+                                    detailedError += ` | failures: ${((payload as any).failures as string[]).slice(0, 3).join(', ')}`;
                                 }
                             } catch { /* ignore parse errors */ }
                             sleepTask.lastError = detailedError;
@@ -1613,6 +1614,12 @@ async function processEvolutionQueue(wctx: WorkspaceContext, logger: PluginLogge
                                 sleepTask.completed_at = new Date().toISOString();
                                 sleepTask.resolution = 'stub_fallback';
                                 logger?.warn?.(`[PD:EvolutionWorker] sleep_reflection task ${sleepTask.id} background runtime unavailable, using stub fallback: ${errorReason}`);
+                            } else if ((payload as any).skipReason === 'no_violating_sessions') {
+                                // #244: No meaningful violations found (thin filter) → skip without failure
+                                sleepTask.status = 'completed';
+                                sleepTask.completed_at = new Date().toISOString();
+                                sleepTask.resolution = 'skipped_thin_violation';
+                                logger?.info?.(`[PD:EvolutionWorker] sleep_reflection task ${sleepTask.id} completed: no sessions with meaningful violations found`);
                             } else {
                                 sleepTask.status = 'failed';
                                 sleepTask.completed_at = new Date().toISOString();

package/src/service/nocturnal-target-selector.ts

@@ -302,7 +302,7 @@ export class NocturnalTargetSelector {
     this.recentPainContext = recentPainContext;
     this.opts = {
       minViolationDensity: restOptions.minViolationDensity ?? 0.1,
-      maxSessionCandidates: restOptions.maxSessionCandidates ?? 50,
+      maxSessionCandidates: restOptions.maxSessionCandidates ?? 300,
       idleThresholdMs: restOptions.idleThresholdMs ?? DEFAULT_IDLE_THRESHOLD_MS,
     };
   }
@@ -440,7 +440,14 @@ export class NocturnalTargetSelector {
     }
 
     // Compute violation signals for each session
-    const violatingSessions: ViolationSignal[] = recentSessions.map((session) => {
+    // #244: Filter out sessions that are too thin for meaningful reflection
+    // A session needs enough violation context (failures + pain + gates >= 2)
+    const MIN_VIOLATION_DEPTH = 2;
+    const richSessions = recentSessions.filter(
+      s => (s.failureCount ?? 0) + (s.painEventCount ?? 0) + (s.gateBlockCount ?? 0) >= MIN_VIOLATION_DEPTH
+    );
+
+    const violatingSessions: ViolationSignal[] = richSessions.map((session) => {
       const violationDensity = computeViolationDensity(session);
       const snapshot = this.extractor.getNocturnalSessionSnapshot(session.sessionId);
 

package/templates/langs/zh/skills/ai-sprint-orchestration/references/specs/nocturnal-trinity-quality-enhancement.json

@@ -0,0 +1,111 @@
+{
+  "id": "nocturnal-trinity-quality-enhancement",
+  "title": "Enhance nocturnal Trinity prompt quality",
+  "description": "Enhance nocturnal Trinity prompt quality — add Dreamer perspective diversity constraints and Scribe rejected-decision analysis",
+  "workspace": "/home/csuzngjh/code/principles",
+  "branch": "fix/bugs-231-228",
+  "requiresTaskContract": true,
+  "maxRoundsPerStage": 2,
+  "maxRuntimeMinutes": 60,
+  "stages": [
+    "investigate",
+    "implement-pass-1",
+    "verify"
+  ],
+  "taskContract": {
+    "goal": "Improve nocturnal Trinity output quality by adding perspective diversity to Dreamer and rejected-decision analysis to Scribe",
+    "inScope": [
+      "nocturnal-trinity.ts prompt modifications",
+      "nocturnal-trinity.test.ts assertion updates",
+      "nocturnal-arbiter.ts compatibility verification"
+    ],
+    "outOfScope": [
+      "Runtime or infrastructure changes",
+      "New file creation",
+      "Non-Trinity prompt changes"
+    ],
+    "validationCommands": [
+      "npx vitest run packages/openclaw-plugin/tests/core/nocturnal --reporter=verbose"
+    ],
+    "expectedArtifacts": [
+      "packages/openclaw-plugin/src/core/nocturnal-trinity.ts"
+    ]
+  },
+  "producer": {
+    "agent": "iflow",
+    "model": "glm-5",
+    "timeoutSeconds": 1800
+  },
+  "reviewerA": {
+    "agent": "iflow",
+    "model": "glm-4.7",
+    "timeoutSeconds": 1200,
+    "role": "code-quality",
+    "focus": "Verify prompt changes are minimal, backward-compatible, and don't break existing arbiter validation"
+  },
+  "reviewerB": {
+    "agent": "iflow",
+    "model": "glm-4.7",
+    "timeoutSeconds": 1200,
+    "role": "functional-correctness",
+    "focus": "Verify tests pass and the new prompt constraints produce structurally valid Trinity output"
+  },
+  "escalationReviewer": {
+    "agent": "iflow",
+    "model": "glm-5",
+    "timeoutSeconds": 1800
+  },
+  "stageGoals": {
+    "investigate": [
+      "Read nocturnal-trinity.ts lines 64-298 (all three prompts) and nocturnal-trinity.test.ts",
+      "Identify exact insertion points for Dreamer diversity section and Scribe analysis section",
+      "List all test assertions that reference prompt content",
+      "Report findings in producer.md"
+    ],
+    "implement-pass-1": [
+      "Apply Dreamer perspective diversity constraints to NOCTURNAL_DREAMER_PROMPT",
+      "Apply Scribe rejected-decision analysis to NOCTURNAL_SCRIBE_PROMPT",
+      "Update test assertions in nocturnal-trinity.test.ts if needed",
+      "Run nocturnal-trinity and nocturnal-arbiter tests to verify no breakage"
+    ],
+    "verify": [
+      "Run full nocturnal test suite: npx vitest run packages/openclaw-plugin/tests/core/nocturnal --reporter=verbose",
+      "Verify all tests pass with 0 failures",
+      "Confirm arbiter validation is unchanged",
+      "Confirm no new files were created"
+    ]
+  },
+  "stageCriteria": {
+    "investigate": {
+      "scoringDimensions": [
+        "completeness",
+        "accuracy"
+      ],
+      "dimensionThreshold": 3,
+      "requiredDeliverables": [
+        "producer.md"
+      ]
+    },
+    "implement-pass-1": {
+      "scoringDimensions": [
+        "correctness",
+        "completeness"
+      ],
+      "dimensionThreshold": 3,
+      "requiredDeliverables": [
+        "producer.md",
+        "reviewer-a.md",
+        "reviewer-b.md"
+      ]
+    },
+    "verify": {
+      "scoringDimensions": [
+        "correctness"
+      ],
+      "dimensionThreshold": 3,
+      "requiredDeliverables": [
+        "producer.md"
+      ]
+    }
+  }
+}

package/templates/langs/zh/skills/ai-sprint-orchestration/scripts/lib/task-specs.mjs

@@ -325,7 +325,7 @@ export function buildStageBrief(spec, stage, round, previousDecision, handoff =
     carryForward.trimEnd(),
     '',
     `## Constraints`,
-    ...spec.context.map((line) => `- ${line}`),
+    ...((spec.context ?? []).map((line) => `- ${line}`)),
     '',
     ...(spec.taskContract
       ? [

package/templates/langs/zh/skills/ai-sprint-orchestration/scripts/run.mjs

@@ -3413,7 +3413,7 @@ if (process.argv[1] === fileURLToPath(import.meta.url)) {
   main().catch((err) => {
     // main() is async and may throw. The try/catch inside main() handles
     // errors within its body, but rejections from the Promise itself land here.
-    console.error('Fatal error:', err.message);
+    console.error('Fatal error:', err.message, err.stack);
     process.exit(1);
   });
 }