principles-disciple 1.16.0 → 1.18.0

package/src/core/pain-context-extractor.ts

@@ -53,7 +53,7 @@ function getAgentsDir(): string {
 async function safeTail(filePath: string): Promise<string[]> {
   try {
     // Check existence and stats asynchronously
-    // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in try, catch has early return
+     
     let stat: fs.Stats;
     try {
       stat = await fsPromises.stat(filePath);
@@ -235,8 +235,8 @@ export async function extractRecentConversation(
 /**
  * Extracts failed tool call context with argument correlation.
  */
-/* eslint-disable @typescript-eslint/default-param-last */ // Reason: breaking API change - default param must precede required params for type inference compatibility
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: context extraction requires session + agent + tool + path - refactoring would break API
+  // Reason: breaking API change - default param must precede required params for type inference compatibility
+ 
 export async function extractFailedToolContext(
   sessionId: string,
   agentId = 'main',

package/src/core/pain.ts

@@ -3,6 +3,7 @@ import * as path from 'path';
 import { serializeKvLines, parseKvLines } from '../utils/io.js';
 import { resolvePdPath } from './paths.js';
 import { ConfigService } from './config-service.js';
+import { SystemLogger } from './system-logger.js';
 
 // =========================================================================
 // Pain Flag Contract (Single Source of Truth)
@@ -36,6 +37,13 @@ export interface PainFlagData {
   trigger_text_preview?: string;
 }
 
+export interface PainFlagContractResult {
+  status: 'missing' | 'valid' | 'invalid';
+  format: 'missing' | 'empty' | 'kv' | 'json' | 'invalid_json';
+  data: Record<string, string>;
+  missingFields: string[];
+}
+
 /**
  * Factory function — the ONLY way to construct pain flag data.
  *
@@ -58,16 +66,18 @@ export function buildPainFlag(input: {
   trace_id?: string;
   trigger_text_preview?: string;
 }): PainFlagData {
+  // Omit optional fields when not provided — prevents writing empty lines to disk
+  // which causes agent confusion (SKILL.md vs reality drift)
   return {
     source: input.source,
     score: input.score,
     time: input.time || new Date().toISOString(),
     reason: input.reason,
-    session_id: input.session_id || '',
-    agent_id: input.agent_id || '',
+    session_id: input.session_id ?? '',
+    agent_id: input.agent_id ?? '',
     is_risky: input.is_risky ? 'true' : 'false',
-    trace_id: input.trace_id || '',
-    trigger_text_preview: input.trigger_text_preview || '',
+    trace_id: input.trace_id ?? '',
+    trigger_text_preview: input.trigger_text_preview ?? '',
   };
 }
 
@@ -77,7 +87,9 @@ export function buildPainFlag(input: {
  */
 export function validatePainFlag(data: Record<string, string>): string[] {
   const missing: string[] = [];
-  const required = ['source', 'score', 'time', 'reason', 'session_id', 'agent_id'] as const;
+  // Only source/score/time/reason are truly required — session_id/agent_id
+  // may be empty in automated contexts (heartbeat, background workers)
+  const required = ['source', 'score', 'time', 'reason'] as const;
   for (const field of required) {
     if (!data[field] || data[field].trim() === '') {
       missing.push(field);
@@ -86,7 +98,6 @@ export function validatePainFlag(data: Record<string, string>): string[] {
   return missing;
 }
 
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: Score computation requires all 5 parameters - refactoring to options object would be breaking API change
 export function computePainScore(rc: number, isSpiral: boolean, missingTestCommand: boolean, softScore: number, projectDir?: string): number {
   let score = Math.max(0, softScore || 0);
   
@@ -146,26 +157,128 @@ export function writePainFlag(projectDir: string, painData: PainFlagData): void
   fs.writeFileSync(painFlagPath, serializeKvLines(painData), "utf-8");
 }
 
+/**
+ * Converts a JSON pain flag object to KV format.
+ */
+function convertJsonToKv(json: Record<string, unknown>): Record<string, string> {
+  const kvData: Record<string, string> = {};
+  const fieldMap: Record<string, string> = {
+    source: 'source',
+    score: 'score',
+    time: 'time',
+    timestamp: 'time',
+    reason: 'reason',
+    session_id: 'session_id',
+    sessionId: 'session_id',
+    agent_id: 'agent_id',
+    agentId: 'agent_id',
+    is_risky: 'is_risky',
+    isRisky: 'is_risky',
+    severity: 'severity',
+    painId: 'pain_id',
+  };
+  for (const [jsonKey, kvKey] of Object.entries(fieldMap)) {
+    if (json[jsonKey] !== undefined) {
+      kvData[kvKey] = String(json[jsonKey]);
+    }
+  }
+  for (const [key, value] of Object.entries(json)) {
+    if (fieldMap[key] === undefined && value !== undefined && value !== null) {
+      kvData[key] = String(value);
+    }
+  }
+  return kvData;
+}
+
+/**
+ * Reads and validates the pain flag file with auto-repair.
+ *
+ * - If file doesn't exist → returns {}
+ * - If file is JSON format (wrong) → converts to KV, logs warning, rewrites file
+ * - If file is KV format → validates required fields, logs warning if missing
+ * - If file has unknown fields → silently ignores them (forward-compatible)
+ */
 export function readPainFlagData(projectDir: string): Record<string, string> {
   const painFlagPath = resolvePdPath(projectDir, 'PAIN_FLAG');
   try {
     if (!fs.existsSync(painFlagPath)) {
       return {};
     }
-    const content = fs.readFileSync(painFlagPath, "utf-8");
-    return parseKvLines(content);
-  } catch (e) { // eslint-disable-line @typescript-eslint/no-unused-vars, no-unused-vars -- Reason: intentionally unused - returning empty object on error
+    const content = fs.readFileSync(painFlagPath, "utf-8").trim();
+    if (!content) {
+      return {};
+    }
+
+    // Detect JSON format (wrong — should be KV)
+    if (content.startsWith('{')) {
+      let json: Record<string, unknown>;
+      try {
+        json = JSON.parse(content);
+      } catch {
+        SystemLogger.log(projectDir, 'PAIN_FLAG_CORRUPT', 'Pain flag file contains invalid JSON');
+        return {};
+      }
+
+      // Auto-repair: convert JSON to KV format
+      const kvData = convertJsonToKv(json);
+
+      const repaired = serializeKvLines(kvData);
+      fs.writeFileSync(painFlagPath, repaired, 'utf-8');
+      SystemLogger.log(projectDir, 'PAIN_FLAG_AUTO_REPAIRED', `Auto-repaired pain flag from JSON to KV format (${Object.keys(json).length} fields)`);
+      return kvData;
+    }
+
+    // KV format — parse and validate
+    const data = parseKvLines(content);
+    const missing = validatePainFlag(data);
+    if (missing.length > 0) {
+      SystemLogger.log(projectDir, 'PAIN_FLAG_INCOMPLETE', `Pain flag missing required fields: ${missing.join(', ')}`);
+    }
+    return data;
+  } catch (e) {
+    SystemLogger.log(projectDir, 'PAIN_FLAG_READ_ERROR', `Failed to read pain flag: ${String(e)}`);
     return {};
   }
 }
 
+export function readPainFlagContract(projectDir: string): PainFlagContractResult {
+  const data = readPainFlagData(projectDir);
+
+  if (Object.keys(data).length === 0) {
+    const painFlagPath = resolvePdPath(projectDir, 'PAIN_FLAG');
+    if (!fs.existsSync(painFlagPath)) {
+      return { status: 'missing', format: 'missing', data: {}, missingFields: [] };
+    }
+
+    const raw = fs.readFileSync(painFlagPath, 'utf-8').trim();
+    if (!raw) {
+      return { status: 'missing', format: 'empty', data: {}, missingFields: [] };
+    }
+
+    return {
+      status: 'invalid',
+      format: raw.startsWith('{') ? 'invalid_json' : 'kv',
+      data: {},
+      missingFields: ['unparseable'],
+    };
+  }
+
+  const missing = validatePainFlag(data);
+  return {
+    status: missing.length > 0 ? 'invalid' : 'valid',
+    format: 'kv',
+    data,
+    missingFields: missing,
+  };
+}
+
 /**
  * Track principle value metrics when a pain signal is written.
  * This is observation-only — it does NOT affect the pain flag write flow.
  * If any principle matches the pain signal, its painPreventedCount is incremented.
  * Errors are silently ignored to avoid disrupting the pain pipeline.
  */
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: principle value tracking requires workspace + data + getters + updaters - refactoring would break API
+ 
 export function trackPrincipleValue(
   workspaceDir: string,
   painData: { reason?: string; source?: string; score?: string },
@@ -174,7 +287,7 @@ export function trackPrincipleValue(
     trigger: string;
     valueMetrics?: { painPreventedCount: number; lastPainPreventedAt?: string; calculatedAt: string };
   }[],
-  updatePrincipleMetrics: (_id: string, _metrics: { painPreventedCount: number; lastPainPreventedAt: string; calculatedAt: string }) => void, // eslint-disable-line no-unused-vars -- Reason: callback params required by interface, actual values accessed via principle.id and principle.valueMetrics
+  updatePrincipleMetrics: (_id: string, _metrics: { painPreventedCount: number; lastPainPreventedAt: string; calculatedAt: string }) => void,  
 ): void {
   try {
     const activePrinciples = getActivePrinciples();

package/src/core/path-resolver.ts

@@ -8,12 +8,12 @@ export interface PathResolverOptions {
     workspaceDir?: string;
     normalizeWorkspace?: boolean;
     logger?: {
-        /* eslint-disable no-unused-vars -- Reason: logger callback param names intentionally unused - callbacks only invoked for side effects */
+         
         debug?: (_msg: string) => void;
         info?: (_msg: string) => void;
         warn?: (_msg: string) => void;
         error?: (_msg: string) => void;
-        /* eslint-enable no-unused-vars */
+         
     };
 }
 
@@ -420,9 +420,9 @@ export function resolveWorkspaceDirFromApi(
     if (!api) return undefined;
 
     // 1. Official API: api.runtime.agent.resolveAgentWorkspaceDir
-    /* eslint-disable no-unused-vars -- Reason: type callback params cfg/id unused - actual values passed are api.config and agentId */
+     
     const officialAgent = (api.runtime as { agent?: { resolveAgentWorkspaceDir?: (cfg: unknown, id: string) => string } }).agent;
-    /* eslint-enable no-unused-vars */
+     
     if (officialAgent?.resolveAgentWorkspaceDir) {
         try {
             return officialAgent.resolveAgentWorkspaceDir(api.config, agentId ?? 'main');

package/src/core/pd-task-reconciler.ts

@@ -72,14 +72,14 @@ export interface ReconcileResult {
 export interface ReconcileOptions {
   dryRun?: boolean;
   workspaceDir: string;
-  /* eslint-disable no-unused-vars -- Reason: logger callback param names intentionally unused - callbacks only invoked for side effects */
+   
   logger?: { info?: (_: string) => void; warn?: (_: string) => void };
-  /* eslint-enable no-unused-vars */
+   
 }
 
-/* eslint-disable no-unused-vars -- Reason: logger callbacks have unused param names in type */
+ 
 async function readCronStore(logger?: { info?: (_: string) => void; warn?: (_: string) => void }): Promise<CronStoreFile> {
-/* eslint-enable no-unused-vars */
+ 
   if (!fs.existsSync(CRON_STORE_PATH)) {
     logger?.info?.(`[PD:Reconciler] cron/jobs.json not found, starting with empty store`);
     return { version: 1, jobs: [] };
@@ -143,7 +143,7 @@ function diff(declared: PDTaskSpec[], actual: CronJob[]): DiffAction[] {
 function buildCronJob(
   task: PDTaskSpec,
   nowMs: number,
-  // eslint-disable-next-line no-unused-vars -- logger callback param unused in type
+   
   logger?: { info?: (_: string) => void },
 ): CronJob {
   logger?.info?.(`[PD:Reconciler] Building cron job: ${task.name} (id=${task.id}, interval=${task.schedule.everyMs}ms)`);
@@ -158,7 +158,7 @@ function buildCronJob(
     wakeMode: 'now',
     payload: {
       kind: 'agentTurn',
-      // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: buildTaskPrompt is defined later in this file, called here for organizational reasons
+       
       message: buildTaskPrompt(task, logger),
       lightContext: task.execution.lightContext ?? true,
       timeoutSeconds: task.execution.timeoutSeconds ?? 120,
@@ -177,7 +177,7 @@ function buildCronJob(
   };
 }
 
-// eslint-disable-next-line no-unused-vars -- logger callback param unused in type
+ 
 function buildTaskPrompt(task: PDTaskSpec, logger?: { info?: (_: string) => void }): string {
   if (task.id === 'empathy-optimizer') {
     logger?.info?.(`[PD:Reconciler] Building empathy optimizer prompt`);
@@ -292,7 +292,7 @@ export async function reconcilePDTasks(
   });
 
   const cronStore = await readCronStore(logger);
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: healthCheck is defined later in this file, called here for organizational reasons
+   
   const healthUpdated = healthCheck(declared, cronStore, logger);
   const actions = diff(healthUpdated, cronStore.jobs);
 
@@ -369,9 +369,9 @@ export async function reconcilePDTasks(
 function healthCheck(
   tasks: PDTaskSpec[],
   cronStore: CronStoreFile,
-  /* eslint-disable no-unused-vars -- Reason: callback type signature parameters */
+   
   logger: { info?: (_msg: string) => void; warn?: (_msg: string) => void },
-  /* eslint-enable no-unused-vars */
+   
 ): PDTaskSpec[] {
   const jobByName = new Map(cronStore.jobs.map((j) => [j.name, j]));
 

package/src/core/pd-task-service.ts

@@ -35,7 +35,7 @@ export const PDTaskService: OpenClawPluginService = {
     }
   },
 
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars, no-unused-vars -- Reason: stop method required by service interface but no cleanup needed
+   
   stop(_ctx: OpenClawPluginServiceContext): void {
     /* intentionally empty - no cleanup required for this service */
   },

package/src/core/pd-task-store.ts

@@ -55,7 +55,7 @@ export function initTaskMeta(task: PDTaskSpec): PDTaskSpec {
   return task;
 }
 
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: sync meta update requires task + status + optional jobId + error - refactoring would break API
+ 
 export function updateSyncMeta(
   task: PDTaskSpec,
   status: 'ok' | 'error',

package/src/core/principle-internalization/deprecated-readiness.ts

@@ -63,7 +63,7 @@ export function assessDeprecatedReadiness(
       adherence.repeatedErrorReductionScore * 0.15,
   );
 
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all if/else branches
+   
   let status: DeprecatedReadinessStatus;
   if (blockingReasons.length === 0 && stableCoverageRatio === 1) {
     status = 'ready';

package/src/core/principle-training-state.ts

@@ -62,7 +62,7 @@ export function createDefaultPrincipleState(principleId: string): PrincipleTrain
 }
 
 export function loadStore(stateDir: string): PrincipleTrainingStore {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: ledgerTrainingStore is defined later in this file, called here for organizational reasons
+   
   return ledgerTrainingStore(stateDir);
 }
 
@@ -75,7 +75,7 @@ export function saveStore(stateDir: string, store: PrincipleTrainingStore): void
 }
 
 export async function loadStoreAsync(stateDir: string): Promise<PrincipleTrainingStore> {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: ledgerTrainingStore is defined later in this file, called here for organizational reasons
+   
   return ledgerTrainingStore(stateDir);
 }
 

package/src/core/principle-tree-ledger.ts

@@ -77,7 +77,7 @@ function isRecord(value: unknown): value is Record<string, unknown> {
   return typeof value === 'object' && value !== null && !Array.isArray(value);
 }
 
-/* eslint-disable @typescript-eslint/max-params -- Reason: Clamp function requires all parameters for safe numeric conversion */
+ 
 function clampFloat(value: unknown, min: number, max: number, fallback: number): number {
   if (typeof value !== 'number' || !Number.isFinite(value)) {
     return fallback;
@@ -85,7 +85,7 @@ function clampFloat(value: unknown, min: number, max: number, fallback: number):
   return Math.max(min, Math.min(max, value));
 }
 
-/* eslint-disable @typescript-eslint/max-params -- Reason: Clamp function requires all parameters for safe numeric conversion */
+ 
 function clampInt(value: unknown, min: number, max: number, fallback: number): number {
   if (typeof value !== 'number' || !Number.isFinite(value)) {
     return fallback;
@@ -315,9 +315,9 @@ function writeLedgerUnlocked(filePath: string, store: HybridLedgerStore): void {
   fs.writeFileSync(filePath, serializeLedger(store), 'utf-8');
 }
 
-/* eslint-disable no-unused-vars -- Reason: callback parameter used via closure in inner function */
+ 
 function mutateLedger<T>(stateDir: string, mutate: (store: HybridLedgerStore) => T): T {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: function is defined later but called in this helper for consistency
+   
   const filePath = getLedgerFilePath(stateDir);
   return withLock(filePath, () => {
     const store = readLedgerFromFile(filePath);
@@ -327,9 +327,9 @@ function mutateLedger<T>(stateDir: string, mutate: (store: HybridLedgerStore) =>
   });
 }
 
-/* eslint-disable no-unused-vars -- Reason: callback parameter used via closure in inner function */
+ 
 async function mutateLedgerAsync<T>(stateDir: string, mutate: (store: HybridLedgerStore) => Promise<T>): Promise<T> {
-  // eslint-disable-next-line @typescript-eslint/no-use-before-define -- Reason: function is defined later but called in this helper for consistency
+   
   const filePath = getLedgerFilePath(stateDir);
   return withLockAsync(filePath, async () => {
     const store = readLedgerFromFile(filePath);
@@ -363,7 +363,7 @@ export async function saveLedgerAsync(stateDir: string, store: HybridLedgerStore
 
 export function updateTrainingStore(
   stateDir: string,
-  /* eslint-disable no-unused-vars -- Reason: callback parameter is forwarded to mutateLedger callback */
+   
   mutate: (store: LegacyPrincipleTrainingStore) => void,
 ): void {
   mutateLedger(stateDir, (store) => {

package/src/core/promotion-gate.ts

@@ -70,7 +70,7 @@ export const DEFAULT_ALLOWED_MARGIN = 0.05;
  * Allowed worker profiles for Phase 7 shadow rollout.
  * Only bounded local workers eligible. local-reader first, local-editor deferred.
  */
-// eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars -- Reason: reserved for Phase 7 shadow rollout profile validation
+// eslint-disable-next-line @typescript-eslint/no-unused-vars -- Reason: reserved for Phase 7 shadow rollout profile validation
 const ALLOWED_ROLLOUT_PROFILES: readonly TrainableWorkerProfile[] = ['local-reader'];
 
 /**
@@ -233,7 +233,7 @@ function writeRegistry(stateDir: string, registry: PromotionRegistry): void {
  */
 function withPromotionRegistryLock<T>(
   stateDir: string,
-  // eslint-disable-next-line no-unused-vars -- Reason: callback parameter name is type documentation, actual value passed at call site
+   
   fn: (_registry: PromotionRegistry) => T
 ): T {
   const registryPath = getRegistryPath(stateDir);
@@ -318,7 +318,7 @@ export function evaluatePromotionGate(
 ): PromotionGateResult {
   const {
     checkpointId,
-    // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars -- Reason: reserved for Phase 7 profile-based targeting
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars -- Reason: reserved for Phase 7 profile-based targeting
     targetProfile: _targetProfile,
     baselineMetrics,
     minDelta = DEFAULT_MIN_DELTA,
@@ -388,9 +388,9 @@ export function evaluatePromotionGate(
   // PREFER real shadow evidence over eval verdict proxy
   // Shadow evidence comes from actual runtime routing decisions
   const shadowStats = computeShadowStats(stateDir, { checkpointId });
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in both if/else branches
+   
   let arbiterRejectRate: number;
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in both if/else branches
+   
   let arbiterRejectSource: 'shadow' | 'eval-proxy';
 
   if (shadowStats && shadowStats.isStatisticallySignificant) {
@@ -424,9 +424,9 @@ export function evaluatePromotionGate(
 
   // --- Check 6: Executability reject rate constraint ---
   // PREFER real shadow evidence: escalation rate + profile rejection rate
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in both if/else branches
+   
   let executabilityRejectRate: number;
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in both if/else branches
+   
   let executabilityRejectSource: 'shadow' | 'eval-proxy';
 
   if (shadowStats && shadowStats.isStatisticallySignificant) {
@@ -484,7 +484,7 @@ export function evaluatePromotionGate(
     qualityCheck.passed;
 
   // --- Suggest state based on checks ---
-  // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all branches
+   
   let suggestedState: PromotionState | undefined;
   if (allPassed) {
     suggestedState = 'candidate_only';
@@ -585,7 +585,7 @@ export function advancePromotion(
     // - rejected → candidate_only/shadow_ready: allowed via re-evaluation
     //   (new eval data may reverse a previous rejection)
     //
-    // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in all branches
+     
     let targetState: PromotionState;
     if (!gateResult.passes) {
       targetState = 'rejected';

package/src/core/replay-engine.ts

@@ -69,9 +69,9 @@ export interface ReplayReport {
 }
 
 export interface CandidateEvaluator {
-  /* eslint-disable no-unused-vars -- Reason: interface method params are type signatures */
+   
   evaluate(sample: unknown): { passed: boolean; reason?: string; decision: string };
-  /* eslint-enable no-unused-vars */
+   
 }
 
 export class ReplayEngine {
@@ -112,7 +112,7 @@ export class ReplayEngine {
     return samples;
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Public API method that delegates to evaluator, no instance state needed
+   
   runSingleSample(sample: ReplaySample, evaluator: CandidateEvaluator): ReplayResult {
     const evaluation = evaluator.evaluate(sample);
     return {
@@ -202,12 +202,12 @@ export class ReplayEngine {
       throw new Error(`Implementation ${implementation.id} does not export evaluate().`);
     }
 
-    /* eslint-disable no-unused-vars -- Reason: type-only parameters in type cast, not used at runtime */
+     
     const evaluate = moduleExports.evaluate as (
       _input: RuleHostInput,
       _helpers: RuleHostHelpers,
     ) => RuleHostResult;
-    /* eslint-enable no-unused-vars */
+     
 
     return {
       evaluate: (sample: unknown) => {
@@ -284,7 +284,7 @@ export class ReplayEngine {
     };
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private _selectToolCall(
     snapshot: NocturnalSessionSnapshot,
     classification: SampleClassification,
@@ -314,7 +314,7 @@ export class ReplayEngine {
     return byNewest[0] ?? null;
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private _matchGateBlock(
     gateBlocks: NocturnalGateBlock[],
     toolCall: NocturnalToolCall,
@@ -351,7 +351,7 @@ export class ReplayEngine {
     }
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private _estimateLineChanges(toolCall: NocturnalToolCall): number {
     if (toolCall.toolName === 'edit' || toolCall.toolName === 'write') {
       return 20;
@@ -359,7 +359,7 @@ export class ReplayEngine {
     return 0;
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private _inferBashRisk(toolCall: NocturnalToolCall): 'safe' | 'normal' | 'dangerous' | 'unknown' {
     if (toolCall.toolName !== 'bash' && toolCall.toolName !== 'run_shell_command') {
       return 'unknown';
@@ -371,7 +371,7 @@ export class ReplayEngine {
     return toolCall.outcome === 'success' ? 'safe' : 'normal';
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private _scoreEvaluation(
     sample: ReplaySample,
     result: RuleHostResult,
@@ -465,7 +465,7 @@ export class ReplayEngine {
     };
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private _determineDecision(
     pain: ClassificationSummary,
     success: ClassificationSummary,
@@ -495,7 +495,7 @@ export class ReplayEngine {
     });
   }
 
-  // eslint-disable-next-line @typescript-eslint/class-methods-use-this -- Reason: Private helper doesn't use instance state
+   
   private _deriveExpectedOutcome(
     record: NocturnalDatasetRecord,
   ): ReplaySample['expectedOutcome'] {

package/src/core/risk-calculator.ts

@@ -93,7 +93,7 @@ export function getTargetFileLineCount(absoluteFilePath: string): number | null
  * @param maxLines - Optional upper bound to prevent misconfiguration
  * @returns Maximum allowed lines (at least minLines, at most maxLines if provided)
  */
-// eslint-disable-next-line @typescript-eslint/max-params -- Reason: percentage threshold calculation requires all 4 params - refactoring would break API
+ 
 export function calculatePercentageThreshold(
     targetLineCount: number,
     percentage: number,

package/src/core/rule-host-types.ts

@@ -76,7 +76,7 @@ export interface LoadedImplementation {
   implId: string;
   ruleId: string;
   meta: RuleHostMeta;
-  /* eslint-disable no-unused-vars -- Reason: _input parameter name in interface type definition intentionally unused - actual implementation uses different param names */
+   
   evaluate: (_input: RuleHostInput) => RuleHostResult;
-  /* eslint-enable no-unused-vars */
+   
 }

package/src/core/rule-host.ts

@@ -36,9 +36,9 @@ import type {
 import type { Implementation } from '../types/principle-tree-schema.js';
 
 export interface RuleHostLogger {
-  /* eslint-disable no-unused-vars -- Reason: logger callback param name intentionally unused - callback only invoked for side effects */
+   
   warn?: (_message: string) => void;
-  /* eslint-enable no-unused-vars */
+   
 }
 
 export class RuleHost {
@@ -69,7 +69,7 @@ export class RuleHost {
       }
 
       // Merge decisions from all active implementations
-      // eslint-disable-next-line @typescript-eslint/init-declarations -- undefined is valid zero value, checked before use
+       
       let blocked: RuleHostResult | undefined;
       const approvals: RuleHostResult[] = [];
 
@@ -218,12 +218,12 @@ export class RuleHost {
 
       // Return a loaded implementation that wraps the compiled evaluate
       // with the actual helpers from the input at evaluation time
-      /* eslint-disable no-unused-vars -- Reason: type cast params intentionally unused - they're just type annotations, actual function uses different params */
+       
       const rawEvaluate = moduleExports.evaluate as (
         _input: RuleHostInput,
         _helpers: ReturnType<typeof createRuleHostHelpers>
       ) => RuleHostResult;
-      /* eslint-enable no-unused-vars */
+       
 
       return {
         implId: impl.id,

package/src/core/schema/db-types.ts

@@ -3,7 +3,7 @@
  * Kept separate to avoid circular dependencies between schema-definitions and migration-runner.
  */
 
-/* eslint-disable no-unused-vars -- Reason: interface method param names are part of type signature */
+ 
 
 /** Minimal interface for better-sqlite3 Database instances. */
 export interface Db {

package/src/core/schema/schema-definitions.ts

@@ -35,7 +35,7 @@ export interface Migration {
   name: string;
   /** Which database file this migration applies to */
   db: DbType;
-  /* eslint-disable no-unused-vars -- Reason: interface callback params are part of type signature */
+   
   /** Apply this migration */
   up: (_db: Db) => void;
   /** Revert this migration */