principles-disciple 1.14.0 → 1.16.0

package/tests/service/nocturnal-runtime-hardening.test.ts

@@ -0,0 +1,85 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import * as fs from 'fs';
+import * as os from 'os';
+import * as path from 'path';
+
+const { mockExecuteNocturnalReflectionAsync } = vi.hoisted(() => ({
+  mockExecuteNocturnalReflectionAsync: vi.fn(),
+}));
+
+vi.mock('../../src/service/nocturnal-service.js', () => ({
+  executeNocturnalReflectionAsync: mockExecuteNocturnalReflectionAsync,
+}));
+
+vi.mock('../../src/utils/subagent-probe.js', () => ({
+  isSubagentRuntimeAvailable: vi.fn(() => true),
+}));
+
+vi.mock('../../src/core/nocturnal-paths.js', () => ({
+  resolveNocturnalDir: vi.fn((workspaceDir: string) => path.join(workspaceDir, '.state', 'nocturnal', 'samples')),
+}));
+
+import { NocturnalWorkflowManager, nocturnalWorkflowSpec } from '../../src/service/subagent-workflow/nocturnal-workflow-manager.js';
+import { safeRmDir } from '../test-utils.js';
+
+describe('NocturnalWorkflowManager runtime hardening', () => {
+  let workspaceDir: string;
+  let stateDir: string;
+
+  beforeEach(() => {
+    vi.clearAllMocks();
+    workspaceDir = fs.mkdtempSync(path.join(os.tmpdir(), 'pd-nocturnal-wf-'));
+    stateDir = path.join(workspaceDir, '.state');
+    fs.mkdirSync(stateDir, { recursive: true });
+  });
+
+  afterEach(() => {
+    safeRmDir(workspaceDir);
+  });
+
+  it('marks workflow terminal_error when async pipeline throws a gateway-only runtime error', async () => {
+    mockExecuteNocturnalReflectionAsync.mockRejectedValue(
+      new Error('Plugin runtime subagent methods are only available during a gateway request.')
+    );
+
+    const manager = new NocturnalWorkflowManager({
+      workspaceDir,
+      stateDir,
+      logger: { info: vi.fn(), warn: vi.fn(), error: vi.fn(), debug: vi.fn() } as any,
+      runtimeAdapter: {} as any,
+    });
+
+    const handle = await manager.startWorkflow(nocturnalWorkflowSpec, {
+      parentSessionId: 'sleep_reflection:test',
+      taskInput: {},
+      metadata: {
+        snapshot: {
+          sessionId: 'session-1',
+          startedAt: '2026-04-10T00:00:00.000Z',
+          updatedAt: '2026-04-10T00:01:00.000Z',
+          assistantTurns: [],
+          userTurns: [],
+          toolCalls: [],
+          painEvents: [],
+          gateBlocks: [],
+          stats: {
+            totalAssistantTurns: 1,
+            totalToolCalls: 1,
+            totalPainEvents: 0,
+            totalGateBlocks: 0,
+            failureCount: 0,
+          },
+        },
+      },
+    });
+
+    await Promise.resolve();
+    await Promise.resolve();
+
+    const summary = await manager.getWorkflowDebugSummary(handle.workflowId);
+    expect(summary?.state).toBe('terminal_error');
+    expect(summary?.recentEvents.some((event) => event.eventType === 'nocturnal_failed')).toBe(true);
+
+    manager.dispose();
+  });
+});

package/ui/src/charts.tsx

@@ -861,6 +861,7 @@ interface LineChartProps {
   showDots?: boolean;
   showArea?: boolean;
   unit?: string;
+  emptyText?: string;
 }
 
 export function LineChart({
@@ -872,11 +873,13 @@ export function LineChart({
   showDots = true,
   showArea = true,
   unit = '',
+  emptyText = '',
 }: LineChartProps) {
   if (!data || data.length === 0) {
+    if (!emptyText) return null;
     return (
       <div style={{ height, display: 'flex', alignItems: 'center', justifyContent: 'center', color: 'var(--text-secondary)', fontSize: '0.85rem' }}>
-        暂无数据
+        {emptyText}
       </div>
     );
   }

package/ui/src/pages/ThinkingModelsPage.tsx

@@ -256,7 +256,7 @@ export function ThinkingModelsPage() {
         /* ── Has data: full dashboard ── */
         <>
           {/* Coverage Trend */}
-          {data.coverageTrend.length >= 1 && (
+          {data.coverageTrend.length >= 1 ? (
             <section className="panel" style={{ marginBottom: SPACE[4] }}>
               <h3 className="section-title">
                 {t('thinkingModels.coverageTrend')}
@@ -269,8 +269,14 @@ export function ThinkingModelsPage() {
                 showGrid
                 showDots
                 showArea
+                emptyText={t('common.noData')}
               />
             </section>
+          ) : (
+            <EmptyState
+              title={t('thinkingModels.emptyCoverageTrend')}
+              description={t('thinkingModels.emptyCoverageTrendDesc')}
+            />
           )}
 
           {/* Search + Sort + Filter */}
@@ -445,6 +451,7 @@ export function ThinkingModelsPage() {
                             showGrid={false}
                             showDots
                             showArea
+                            emptyText={t('common.noData')}
                           />
                         </article>
                       );
@@ -511,6 +518,7 @@ export function ThinkingModelsPage() {
                         showGrid
                         showDots
                         showArea
+                        emptyText={t('common.noData')}
                       />
                     </article>
                   ) : (