principles-disciple 1.127.0 → 1.129.0

package/tests/core/workflow-funnel-loader.test.ts

@@ -1,1028 +0,0 @@
-import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
-import * as fs from 'fs';
-import * as path from 'path';
-import * as os from 'os';
-import { WorkflowFunnelLoader, type WorkflowStage } from '../../src/core/workflow-funnel-loader.js';
-import { RuntimeSummaryService } from '../../src/service/runtime-summary-service.js';
-
-describe('WorkflowFunnelLoader', () => {
-  let tempDir: string;
-
-  beforeEach(() => {
-    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'wfl-test-'));
-  });
-
-  afterEach(() => {
-    fs.rmSync(tempDir, { recursive: true, force: true });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // ERR-01: YAML parse warnings surface in RuntimeSummaryService.metadata.warnings
-  // RuntimeSummaryService.getSummary() propagates loaderWarnings → metadata.warnings
-  // per D-08 contract (YAML parse failures surface in warnings, not console).
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('ERR-01: YAML parse warnings surface in metadata.warnings', () => {
-    it('should surface YAML parse warnings via RuntimeSummaryService.getSummary', () => {
-      // Create a malformed YAML file (tab instead of spaces causes parse warning in js-yaml)
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "test"
-    stages:
-      - name: "bad_indent"
-        eventType: "test_event"
-        eventCategory: "completed"
-        statsField: "evolution.test"
-        extra: [bad
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-
-      // Get funnels and warnings from loader
-      const funnels = loader.getAllFunnels();
-      const loaderWarnings = loader.getWarnings();
-
-      // ERR-01: getSummary with loaderWarnings propagates YAML parse failures to metadata.warnings
-      const summary = RuntimeSummaryService.getSummary(tempDir, { loaderWarnings });
-      expect(summary.metadata.warnings).toBeDefined();
-      expect(Array.isArray(summary.metadata.warnings)).toBe(true);
-      // loaderWarnings is non-empty when YAML is malformed — assert warnings array grew
-      expect(summary.metadata.warnings.length).toBeGreaterThan(0);
-    });
-
-    it('should NOT surface warnings when YAML is valid', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "valid_workflow"
-    stages:
-      - name: "stage_one"
-        eventType: "test_event"
-        eventCategory: "completed"
-        statsField: "evolution.test"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const summary = RuntimeSummaryService.getSummary(tempDir);
-
-      // With valid YAML, no config warnings should be present
-      const configWarnings = summary.metadata.warnings.filter(
-        (w: string) => w.toLowerCase().includes('yaml') || w.toLowerCase().includes('workflow') || w.toLowerCase().includes('config')
-      );
-      expect(configWarnings).toHaveLength(0);
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // ERR-02: degraded state on missing/malformed YAML
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('ERR-02: degraded state on missing/malformed YAML', () => {
-    it('should set dataQuality to partial when workflows.yaml is missing', () => {
-      // Ensure no workflows.yaml exists
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels = loader.getAllFunnels();
-
-      const summary = RuntimeSummaryService.getSummary(tempDir);
-
-      // ERR-02: degraded state on missing YAML
-      expect(summary.gfi.dataQuality).toBe('partial');
-      expect(summary.metadata.warnings).toBeDefined();
-      // Note: RuntimeSummaryService does not currently emit a specific warning for
-      // missing workflows.yaml — the degraded dataQuality is the primary signal.
-      // A future iteration may add a specific "missing workflows.yaml" warning.
-    });
-
-    it('should set dataQuality to partial when workflows.yaml is malformed', () => {
-      // Create a file that is valid YAML but wrong schema (missing required fields)
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: 123
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels = loader.getAllFunnels();
-
-      const summary = RuntimeSummaryService.getSummary(tempDir);
-
-      // Schema-invalid YAML: should degrade gracefully
-      expect(summary.gfi.dataQuality).toBe('partial');
-    });
-
-    it('should preserve empty funnels on missing file', () => {
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels = loader.getAllFunnels();
-      expect(funnels.size).toBe(0);
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // ERR-03: last-known-good preserved on invalid YAML replacement
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('ERR-03: last-known-good preserved on invalid YAML replacement', () => {
-    it('should preserve last valid config when new YAML is invalid', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-
-      // Write valid YAML first
-      const validYaml = `
-version: "1.0"
-funnels:
-  - workflowId: "preserved_workflow"
-    stages:
-      - name: "preserved_stage"
-        eventType: "preserved_event"
-        eventCategory: "completed"
-        statsField: "evolution.preserved"
-`;
-      fs.writeFileSync(yamlPath, validYaml, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-
-      // Verify initial valid state
-      const initialFunnels = loader.getAllFunnels();
-      expect(initialFunnels.get('preserved_workflow')).toHaveLength(1);
-      expect(initialFunnels.get('preserved_workflow')?.[0].name).toBe('preserved_stage');
-
-      // Replace with invalid YAML
-      fs.writeFileSync(yamlPath, 'INVALID: YAML: [', 'utf-8');
-
-      // Re-load
-      loader.load();
-
-      // ERR-03: last known-good should be preserved
-      const reloadedFunnels = loader.getAllFunnels();
-      expect(reloadedFunnels.get('preserved_workflow')).toHaveLength(1);
-      expect(reloadedFunnels.get('preserved_workflow')?.[0].name).toBe('preserved_stage');
-    });
-
-    it('should preserve last valid config when new YAML has wrong schema', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-
-      // Write valid YAML first
-      const validYaml = `
-version: "1.0"
-funnels:
-  - workflowId: "schema_preserved"
-    stages:
-      - name: "schema_stage"
-        eventType: "schema_event"
-        eventCategory: "blocked"
-        statsField: "evolution.schema"
-`;
-      fs.writeFileSync(yamlPath, validYaml, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      expect(loader.getStages('schema_preserved')).toHaveLength(1);
-
-      // Replace with schema-invalid YAML (no version, no funnels array)
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-notFunnels: "wrong"
-`, 'utf-8');
-
-      loader.load();
-
-      // Last valid preserved
-      expect(loader.getStages('schema_preserved')).toHaveLength(1);
-    });
-
-    it('should clear funnels only when file is missing, not on parse error', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-
-      // Write valid YAML
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "clear_test"
-    stages:
-      - name: "clear_stage"
-        eventType: "clear_event"
-        eventCategory: "created"
-        statsField: "evolution.clear"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      expect(loader.getStages('clear_test')).toHaveLength(1);
-
-      // File missing — this is the only case where funnels should clear
-      fs.rmSync(yamlPath);
-      loader.load();
-
-      expect(loader.getAllFunnels().size).toBe(0);
-
-      // Recreate with parse error
-      fs.writeFileSync(yamlPath, 'BROKEN: YAML', 'utf-8');
-      loader.load();
-
-      // Should NOT clear — last known-good (empty from missing) preserved
-      expect(loader.getAllFunnels().size).toBe(0);
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // PLAT-01: Windows rename/rewrite event sequence
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('PLAT-01: Windows rename/rewrite event sequence', () => {
-    it('should reload on change event', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "watch_change"
-    stages:
-      - name: "change_stage"
-        eventType: "change_event"
-        eventCategory: "completed"
-        statsField: "evolution.change"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      // Modify file (triggers 'change' on Windows)
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "watch_change"
-    stages:
-      - name: "change_stage_updated"
-        eventType: "change_event"
-        eventCategory: "completed"
-        statsField: "evolution.change"
-`, 'utf-8');
-
-      // Wait for debounce
-      return new Promise<void>((resolve) => {
-        setTimeout(() => {
-          const stages = loader.getStages('watch_change');
-          expect(stages[0].name).toBe('change_stage_updated');
-          loader.dispose();
-          resolve();
-        }, 200);
-      });
-    });
-
-    it('should reload on rename event', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "watch_rename"
-    stages:
-      - name: "rename_stage_original"
-        eventType: "rename_event"
-        eventCategory: "completed"
-        statsField: "evolution.rename"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      // Rename-style operation (some editors do rename+write on Windows)
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "watch_rename"
-    stages:
-      - name: "rename_stage_after"
-        eventType: "rename_event"
-        eventCategory: "completed"
-        statsField: "evolution.rename"
-`, 'utf-8');
-
-      return new Promise<void>((resolve) => {
-        setTimeout(() => {
-          const stages = loader.getStages('watch_rename');
-          expect(stages[0].name).toBe('rename_stage_after');
-          loader.dispose();
-          resolve();
-        }, 200);
-      });
-    });
-
-    it('should ignore other event types', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "ignore_test"
-    stages:
-      - name: "original"
-        eventType: "ignore_event"
-        eventCategory: "completed"
-        statsField: "evolution.ignore"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      // Spy on load to check it's NOT called for unknown event types
-      const loadSpy = vi.spyOn(loader, 'load');
-
-      // Trigger with unknown event type (simulate via direct callback if possible)
-      // Note: fs.watch doesn't emit 'change' or 'rename' on all platforms reliably
-      // This test verifies the guard in the watch handler
-      loadSpy.mockClear();
-
-      loader.dispose();
-
-      // If dispose works, the guard was respected
-      expect(true).toBe(true);
-    });
-
-    it('should have re-entry guard preventing double-watch', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels: []
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-
-      // First watch
-      loader.watch();
-      const firstHandle = (loader as any).watchHandle;
-
-      // Second watch — should be no-op (re-entry guard)
-      loader.watch();
-      const secondHandle = (loader as any).watchHandle;
-
-      expect(firstHandle).toBe(secondHandle);
-      loader.dispose();
-    });
-
-    it('should clean up watch handle on dispose', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels: []
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      expect((loader as any).watchHandle).toBeDefined();
-
-      loader.dispose();
-
-      expect((loader as any).watchHandle).toBeUndefined();
-    });
-
-    it('should set watchHandle to undefined after close', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels: []
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      const handle = (loader as any).watchHandle;
-      expect(handle).toBeDefined();
-
-      handle.close();
-      (loader as any).watchHandle = undefined;
-
-      expect((loader as any).watchHandle).toBeUndefined();
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // Core interface tests
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('core interface', () => {
-    it('should return deep-cloned funnels from getAllFunnels', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "clone_test"
-    stages:
-      - name: "stage_one"
-        eventType: "clone_event"
-        eventCategory: "completed"
-        statsField: "evolution.clone"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels1 = loader.getAllFunnels();
-      const stages1 = funnels1.get('clone_test')!;
-
-      // Mutate the returned array
-      stages1.push({ name: 'mutated', eventType: 'x', eventCategory: 'x', statsField: 'x' });
-
-      // Second call should not see mutation (deep clone)
-      const funnels2 = loader.getAllFunnels();
-      expect(funnels2.get('clone_test')).toHaveLength(1);
-    });
-
-    it('should return deep-cloned stages (not same object references)', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "ref_test"
-    stages:
-      - name: "ref_stage"
-        eventType: "ref_event"
-        eventCategory: "completed"
-        statsField: "evolution.ref"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels1 = loader.getAllFunnels();
-      const stage1 = funnels1.get('ref_test')![0];
-
-      // Mutate returned stage object
-      stage1.name = 'mutated_name';
-
-      // Second call should not see mutation
-      const funnels2 = loader.getAllFunnels();
-      expect(funnels2.get('ref_test')![0].name).toBe('ref_stage');
-    });
-
-    it('should return empty array for unknown workflowId', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels: []
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      expect(loader.getStages('nonexistent')).toEqual([]);
-    });
-
-    it('should return correct config path', () => {
-      const loader = new WorkflowFunnelLoader(tempDir);
-      expect(loader.getConfigPath()).toBe(path.join(tempDir, 'workflows.yaml'));
-    });
-
-    it('should skip funnel entries with missing workflowId', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - stages: []
-  - workflowId: "valid_id"
-    stages:
-      - name: "valid"
-        eventType: "e"
-        eventCategory: "c"
-        statsField: "f"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels = loader.getAllFunnels();
-
-      expect(funnels.get('valid_id')).toHaveLength(1);
-      expect(funnels.size).toBe(1);
-    });
-
-    it('should skip funnel entries with non-array stages', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "bad_stages"
-    stages: "not_an_array"
-  - workflowId: "good_stages"
-    stages:
-      - name: "good"
-        eventType: "e"
-        eventCategory: "c"
-        statsField: "f"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels = loader.getAllFunnels();
-
-      expect(funnels.get('bad_stages')).toBeUndefined();
-      expect(funnels.get('good_stages')).toHaveLength(1);
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // TEST-01: watch()/dispose() lifecycle — no FSWatcher leaks, re-entry guard
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('TEST-01: watch()/dispose() lifecycle', () => {
-    it('re-entry guard prevents double-watch (no FSWatcher leak)', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "leak-test"
-    stages:
-      - name: "s1"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-
-      // First watch — should create a handle
-      loader.watch();
-      const handle1 = (loader as any).watchHandle;
-      expect(handle1).toBeDefined();
-
-      // Second watch — re-entry guard should return early, same handle
-      loader.watch();
-      const handle2 = (loader as any).watchHandle;
-      expect(handle1).toBe(handle2); // Same object, no leak
-
-      loader.dispose();
-    });
-
-    it('dispose() closes FSWatcher and sets watchHandle to undefined', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels: []
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      const handle = (loader as any).watchHandle;
-      expect(handle).toBeDefined();
-
-      loader.dispose();
-
-      expect((loader as any).watchHandle).toBeUndefined();
-    });
-
-    it('dispose() is idempotent (safe to call twice)', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels: []
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      loader.dispose();
-      expect((loader as any).watchHandle).toBeUndefined();
-
-      // Second dispose — should not throw
-      loader.dispose();
-      expect((loader as any).watchHandle).toBeUndefined();
-    });
-
-    it('watch() returns early when config file does not exist', () => {
-      const loader = new WorkflowFunnelLoader(tempDir); // no file created
-      expect((loader as any).watchHandle).toBeUndefined();
-
-      loader.watch(); // should be no-op
-      expect((loader as any).watchHandle).toBeUndefined();
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // TEST-02: RuntimeSummaryService degraded state and warnings when funnels absent
-  // Complements ERR-02: ERR-02 tests loader-internal state, TEST-02 tests
-  // RuntimeSummaryService output signals (gfi.dataQuality + metadata.warnings)
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('TEST-02: RuntimeSummaryService degraded state when workflows.yaml missing', () => {
-    it('getSummary sets gfi.dataQuality to partial when workflows.yaml is absent', () => {
-      const loader = new WorkflowFunnelLoader(tempDir); // no workflows.yaml
-      const funnels = loader.getAllFunnels();
-      expect(funnels.size).toBe(0);
-
-      const summary = RuntimeSummaryService.getSummary(tempDir);
-
-      // TEST-02: degraded state signal when workflows.yaml is absent
-      expect(summary.gfi.dataQuality).toBe('partial'); // hardcoded in current impl
-    });
-
-    it('getSummary includes metadata.warnings when workflows.yaml is absent', () => {
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels = loader.getAllFunnels();
-
-      const summary = RuntimeSummaryService.getSummary(tempDir);
-
-      // TEST-02: warnings array must be present (even if empty in some configs)
-      expect(summary.metadata.warnings).toBeDefined();
-      expect(Array.isArray(summary.metadata.warnings)).toBe(true);
-    });
-
-    it('gfi.dataQuality is partial even when valid funnels are loaded', () => {
-      // The current RuntimeSummaryService hardcodes dataQuality = 'partial'
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "valid-funnel"
-    stages:
-      - name: "s1"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels = loader.getAllFunnels();
-      expect(funnels.size).toBe(1);
-
-      const summary = RuntimeSummaryService.getSummary(tempDir);
-
-      // gfi.dataQuality is hardcoded to 'partial' in current implementation
-      expect(summary.gfi.dataQuality).toBe('partial');
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // TEST-03: Windows watcher rename event handling — event-type filtering
-  // Verifies PLAT-01 event-type guard: only 'change' and 'rename' trigger reload
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('TEST-03: Windows watcher rename/change event handling', () => {
-    it('watcher filters eventType — only change and rename trigger reload', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "filter-test"
-    stages:
-      - name: "original"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      // Directly invoke the watch callback with different eventType values
-      // The watch callback is: (eventType) => { if (eventType !== 'change' && eventType !== 'rename') return; ... }
-      const watchCallback = (loader as any).watchHandle;
-
-      // Simulate unknown event type — loader state should NOT change
-      const unknownEventTypes = ['other', 'move', 'create', ''];
-      for (const evt of unknownEventTypes) {
-        // Directly call internal handler if possible — but fs.watch doesn't give public access
-        // Instead, verify the guard by checking the reload logic doesn't fire for unknown types
-        // This is implicitly tested by the fact that only 'change'/'rename' are in the guard
-        expect(evt === 'change' || evt === 'rename').toBe(false);
-      }
-
-      loader.dispose();
-    });
-
-    it('watcher triggers reload on change event', async () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "change-event"
-    stages:
-      - name: "v1"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      // Update file content
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "change-event"
-    stages:
-      - name: "v2"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      await new Promise<void>((resolve) => setTimeout(resolve, 200));
-
-      const stages = loader.getStages('change-event');
-      expect(stages[0].name).toBe('v2');
-
-      loader.dispose();
-    });
-
-    it('watcher triggers reload on rename event (Windows atomic-save)', async () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "rename-event"
-    stages:
-      - name: "before-rename"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      loader.watch();
-
-      // Simulate Windows atomic-save: write new content (triggers rename on some editors)
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "rename-event"
-    stages:
-      - name: "after-rename"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      await new Promise<void>((resolve) => setTimeout(resolve, 200));
-
-      const stages = loader.getStages('rename-event');
-      expect(stages[0].name).toBe('after-rename');
-
-      loader.dispose();
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // TEST-04: consumer mutation isolation — getAllFunnels() returns clones
-  // NOTE: Current implementation uses shallow clone (spread), NOT deep clone.
-  // Nested statsField property is still shared — test documents this limitation.
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('TEST-04: consumer mutation isolation', () => {
-    it('mutating returned Map does not corrupt internal loader state', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "isolation-test"
-    stages:
-      - name: "original-stage"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels1 = loader.getAllFunnels();
-
-      // Mutate the returned Map directly
-      (funnels1 as any).set('hacked', []);
-
-      // Internal state should be unaffected
-      expect(loader.getAllFunnels().has('hacked')).toBe(false);
-    });
-
-    it('mutating returned stage array does not corrupt loader state', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "array-mutation-test"
-    stages:
-      - name: "stage-a"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-      - name: "stage-b"
-        eventType: "e2"
-        eventCategory: "created"
-        statsField: "evolution.e2"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels1 = loader.getAllFunnels();
-      const stages1 = funnels1.get('array-mutation-test')!;
-
-      // Mutate the returned stages array
-      stages1.push({ name: 'injected', eventType: 'x', eventCategory: 'x', statsField: 'x' });
-
-      // Internal state — second call should not see injected stage
-      const funnels2 = loader.getAllFunnels();
-      expect(funnels2.get('array-mutation-test')).toHaveLength(2);
-    });
-
-    it('mutating returned stage object top-level properties does not corrupt loader', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "object-mutation-test"
-    stages:
-      - name: "immutable-name"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels1 = loader.getAllFunnels();
-      const stage1 = funnels1.get('object-mutation-test')![0];
-
-      // Mutate top-level properties
-      stage1.name = 'MUTATED';
-      stage1.eventType = 'MUTATED_TYPE';
-
-      // Second call should not see mutations
-      const funnels2 = loader.getAllFunnels();
-      expect(funnels2.get('object-mutation-test')![0].name).toBe('immutable-name');
-      expect(funnels2.get('object-mutation-test')![0].eventType).toBe('e1');
-    });
-
-    it('shallow clone limitation: nested statsField IS shared (not deep-cloned)', () => {
-      // This test documents the known shallow-clone limitation.
-      // getAllFunnels() does: v.map(stage => ({ ...stage }))
-      // This creates new stage objects but does NOT clone nested/child values.
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "nested-mutation-test"
-    stages:
-      - name: "n1"
-        eventType: "e1"
-        eventCategory: "completed"
-        statsField: "evolution.e1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnels1 = loader.getAllFunnels();
-      const stage1 = funnels1.get('nested-mutation-test')![0];
-
-      // The statsField is a string (primitive) so it's copied by value.
-      // But if it were an object, it would be shared.
-      // Verify top-level isolation first:
-      stage1.name = 'SHALLOW_MUTATED';
-      const funnels2 = loader.getAllFunnels();
-      expect(funnels2.get('nested-mutation-test')![0].name).toBe('n1'); // isolated
-
-      // Now demonstrate the limitation: statsField (a string primitive) is copied,
-      // but a hypothetical nested object would NOT be protected.
-      // Since statsField is a string, it IS safe in practice.
-      expect(typeof stage1.statsField).toBe('string');
-    });
-  });
-
-  // ─────────────────────────────────────────────────────────────────────────────
-  // POLICY-01: Funnel and stage policy fields
-  // Extended schema: timeoutMs, successCriteria, legacyDisabled, observability
-  // ─────────────────────────────────────────────────────────────────────────────
-  describe('POLICY-01: funnel and stage policy fields', () => {
-    it('should load funnel with policy fields', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "pd-runtime-v2-diagnosis"
-    policy:
-      timeoutMs: 600000
-      stageOrder: "strict"
-      legacyDisabled: false
-      observability:
-        enabled: true
-        emitEvents: ["stage_entered", "stage_exited"]
-        logLevel: "debug"
-    stages:
-      - name: "pain_detected"
-        eventType: "pain_detected"
-        eventCategory: "created"
-        statsField: "diagnostic.painDetected"
-      - name: "task_created"
-        eventType: "task_created"
-        eventCategory: "created"
-        statsField: "diagnostic.taskCreated"
-        timeoutMs: 300000
-        legacyDisabled: false
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnel = loader.getFunnel('pd-runtime-v2-diagnosis');
-
-      expect(funnel).toBeDefined();
-      expect(funnel!.policy).toBeDefined();
-      expect(funnel!.policy!.timeoutMs).toBe(600000);
-      expect(funnel!.policy!.stageOrder).toBe('strict');
-      expect(funnel!.policy!.legacyDisabled).toBe(false);
-      expect(funnel!.policy!.observability!.enabled).toBe(true);
-      expect(funnel!.policy!.observability!.emitEvents).toEqual(['stage_entered', 'stage_exited']);
-      expect(funnel!.policy!.observability!.logLevel).toBe('debug');
-    });
-
-    it('should load stage-level policy fields', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "policy-stage-test"
-    stages:
-      - name: "custom_stage"
-        eventType: "custom_event"
-        eventCategory: "completed"
-        statsField: "test.custom"
-        timeoutMs: 900000
-        successCriteria: "artifact.committed"
-        legacyDisabled: true
-        observability:
-          enabled: false
-          emitEvents: []
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const stages = loader.getStages('policy-stage-test');
-
-      expect(stages).toHaveLength(1);
-      expect(stages[0].timeoutMs).toBe(900000);
-      expect(stages[0].successCriteria).toBe('artifact.committed');
-      expect(stages[0].legacyDisabled).toBe(true);
-      expect(stages[0].observability!.enabled).toBe(false);
-    });
-
-    it('should return stages without policy fields (backward compatible)', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "backward_compat"
-    stages:
-      - name: "plain_stage"
-        eventType: "plain_event"
-        eventCategory: "completed"
-        statsField: "test.plain"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const stages = loader.getStages('backward_compat');
-
-      expect(stages).toHaveLength(1);
-      expect(stages[0].timeoutMs).toBeUndefined();
-      expect(stages[0].successCriteria).toBeUndefined();
-      expect(stages[0].legacyDisabled).toBeUndefined();
-      expect(stages[0].observability).toBeUndefined();
-    });
-
-    it('getAllFunnelsWithPolicy returns all funnels with policy', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "funnel_a"
-    policy:
-      timeoutMs: 600000
-    stages:
-      - name: "s1"
-        eventType: "e1"
-        eventCategory: "c"
-        statsField: "f.f1"
-  - workflowId: "funnel_b"
-    stages:
-      - name: "s2"
-        eventType: "e2"
-        eventCategory: "c"
-        statsField: "f.f2"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const all = loader.getAllFunnelsWithPolicy();
-
-      expect(all.get('funnel_a')!.policy!.timeoutMs).toBe(600000);
-      expect(all.get('funnel_b')!.policy).toBeUndefined();
-    });
-
-    it('getFunnel returns undefined for unknown workflowId', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels: []
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      expect(loader.getFunnel('nonexistent')).toBeUndefined();
-    });
-
-    it('getFunnel returns shallow clone (mutation isolation)', () => {
-      const yamlPath = path.join(tempDir, 'workflows.yaml');
-      fs.writeFileSync(yamlPath, `
-version: "1.0"
-funnels:
-  - workflowId: "mutation_test"
-    policy:
-      timeoutMs: 600000
-    stages:
-      - name: "stage_one"
-        eventType: "e1"
-        eventCategory: "c"
-        statsField: "f.f1"
-`, 'utf-8');
-
-      const loader = new WorkflowFunnelLoader(tempDir);
-      const funnel1 = loader.getFunnel('mutation_test')!;
-      funnel1.policy!.timeoutMs = 999;
-      funnel1.stages[0].name = 'MUTATED';
-
-      const funnel2 = loader.getFunnel('mutation_test')!;
-      expect(funnel2.policy!.timeoutMs).toBe(600000);
-      expect(funnel2.stages[0].name).toBe('stage_one');
-    });
-  });
-});