principles-disciple 1.11.0 → 1.13.0

package/src/core/pain-context-extractor.ts

@@ -19,7 +19,8 @@
  * - All errors caught silently — return empty string on failure
  */
 
-import * as fs from 'fs';
+import type * as fs from 'fs';
+import * as fsPromises from 'fs/promises';
 import * as path from 'path';
 import * as os from 'os';
 
@@ -46,27 +47,38 @@ function getAgentsDir(): string {
 }
 
 // =========================================================================
-// Safe File Reading
+// Safe File Reading (Async)
 // =========================================================================
 
-function safeTail(filePath: string): string[] {
+async function safeTail(filePath: string): Promise<string[]> {
   try {
-    if (!fs.existsSync(filePath)) return [];
-    const stat = fs.statSync(filePath);
+    // Check existence and stats asynchronously
+    // eslint-disable-next-line @typescript-eslint/init-declarations -- assigned in try, catch has early return
+    let stat: fs.Stats;
+    try {
+      stat = await fsPromises.stat(filePath);
+    } catch {
+      return []; // File doesn't exist or can't be accessed
+    }
     if (stat.size === 0) return [];
 
     const isTruncated = stat.size > TAIL_READ_SIZE;
     const readSize = Math.min(stat.size, TAIL_READ_SIZE);
     const buffer = Buffer.alloc(readSize);
-    const fd = fs.openSync(filePath, 'r');
+    
+    // Use async file read
+    const fileHandle = await fsPromises.open(filePath, 'r');
     try {
-      fs.readSync(fd, buffer, 0, readSize, stat.size - readSize);
+      await fileHandle.read(buffer, 0, readSize, stat.size - readSize);
+      await fileHandle.close();
       const content = buffer.toString('utf8');
       // Only strip first line if file was actually truncated (started mid-line)
       const validContent = isTruncated ? content.slice(content.indexOf('\n') + 1) : content;
       return validContent.split('\n').filter(l => l.trim().length > 0);
-    } finally {
-      fs.closeSync(fd);
+    } catch (err) {
+      // Ensure file handle is closed even on error
+      try { await fileHandle.close(); } catch { /* ignore close error */ }
+      throw err;
     }
   } catch (err) {
     console.debug(`[pain-context-extractor] safeTail failed: ${String(err)}`);
@@ -81,7 +93,7 @@ function safeTail(filePath: string): string[] {
 interface ParsedMessage {
   role: string;
   textParts: string[];
-  toolCalls: Array<{ id?: string; name?: string; arguments?: Record<string, unknown> }>;
+  toolCalls: { id?: string; name?: string; arguments?: Record<string, unknown> }[];
   toolCallId?: string;
   toolName?: string;
   details?: { exitCode?: number; isError?: boolean; aggregated?: string };
@@ -193,14 +205,14 @@ function extractTurn(msg: ParsedMessage): string | null {
  */
 export async function extractRecentConversation(
   sessionId: string,
-  agentId: string = 'main',
+  agentId = 'main',
   maxTurns: number = MAX_TURNS,
 ): Promise<string> {
   if (!sessionId || sessionId.length < 5 || !SAFE_ID_REGEX.test(sessionId)) return '';
   if (agentId && !SAFE_ID_REGEX.test(agentId)) return '';
   try {
     const jsonlPath = path.join(getAgentsDir(), agentId, 'sessions', `${sessionId}.jsonl`);
-    const lines = safeTail(jsonlPath);
+    const lines = await safeTail(jsonlPath);
     const messages = parseSafeMessages(lines);
     if (messages.length === 0) return '';
 
@@ -223,9 +235,11 @@ export async function extractRecentConversation(
 /**
  * Extracts failed tool call context with argument correlation.
  */
+/* eslint-disable @typescript-eslint/default-param-last */ // Reason: breaking API change - default param must precede required params for type inference compatibility
+// eslint-disable-next-line @typescript-eslint/max-params -- Reason: context extraction requires session + agent + tool + path - refactoring would break API
 export async function extractFailedToolContext(
   sessionId: string,
-  agentId: string = 'main',
+  agentId = 'main',
   toolName: string,
   filePath?: string,
 ): Promise<string> {
@@ -233,7 +247,7 @@ export async function extractFailedToolContext(
   if (agentId && !SAFE_ID_REGEX.test(agentId)) return '';
   try {
     const jsonlPath = path.join(getAgentsDir(), agentId, 'sessions', `${sessionId}.jsonl`);
-    const lines = safeTail(jsonlPath);
+    const lines = await safeTail(jsonlPath);
     const messages = parseSafeMessages(lines);
     if (messages.length === 0) return '';
 
@@ -266,7 +280,7 @@ export async function extractFailedToolContext(
         const isError = msg.details?.isError || (exitCode !== undefined && exitCode !== 0);
         if (!isError) continue;
 
-        const toolCallId = msg.toolCallId;
+        const {toolCallId} = msg;
         const correlated = toolCallId ? toolArgsById.get(toolCallId) : null;
         if (filePath && correlated && !correlated.fullArgs.includes(filePath)) continue;
 

package/src/core/pain.ts

@@ -86,6 +86,7 @@ export function validatePainFlag(data: Record<string, string>): string[] {
   return missing;
 }
 
+// eslint-disable-next-line @typescript-eslint/max-params -- Reason: Score computation requires all 5 parameters - refactoring to options object would be breaking API change
 export function computePainScore(rc: number, isSpiral: boolean, missingTestCommand: boolean, softScore: number, projectDir?: string): number {
   let score = Math.max(0, softScore || 0);
   
@@ -112,7 +113,7 @@ export function computePainScore(rc: number, isSpiral: boolean, missingTestComma
   return Math.min(100, score);
 }
 
-export function painSeverityLabel(painScore: number, isSpiral: boolean = false, projectDir?: string): string {
+export function painSeverityLabel(painScore: number, isSpiral = false, projectDir?: string): string {
   if (isSpiral) {
     return "critical";
   }
@@ -153,7 +154,7 @@ export function readPainFlagData(projectDir: string): Record<string, string> {
     }
     const content = fs.readFileSync(painFlagPath, "utf-8");
     return parseKvLines(content);
-  } catch (e) {
+  } catch (e) { // eslint-disable-line @typescript-eslint/no-unused-vars, no-unused-vars -- Reason: intentionally unused - returning empty object on error
     return {};
   }
 }
@@ -164,15 +165,16 @@ export function readPainFlagData(projectDir: string): Record<string, string> {
  * If any principle matches the pain signal, its painPreventedCount is incremented.
  * Errors are silently ignored to avoid disrupting the pain pipeline.
  */
+// eslint-disable-next-line @typescript-eslint/max-params -- Reason: principle value tracking requires workspace + data + getters + updaters - refactoring would break API
 export function trackPrincipleValue(
   workspaceDir: string,
   painData: { reason?: string; source?: string; score?: string },
-  getActivePrinciples: () => Array<{
+  getActivePrinciples: () => {
     id: string;
     trigger: string;
     valueMetrics?: { painPreventedCount: number; lastPainPreventedAt?: string; calculatedAt: string };
-  }>,
-  updatePrincipleMetrics: (id: string, metrics: { painPreventedCount: number; lastPainPreventedAt: string; calculatedAt: string }) => void,
+  }[],
+  updatePrincipleMetrics: (_id: string, _metrics: { painPreventedCount: number; lastPainPreventedAt: string; calculatedAt: string }) => void, // eslint-disable-line no-unused-vars -- Reason: callback params required by interface, actual values accessed via principle.id and principle.valueMetrics
 ): void {
   try {
     const activePrinciples = getActivePrinciples();

package/src/core/path-resolver.ts

@@ -8,10 +8,12 @@ export interface PathResolverOptions {
     workspaceDir?: string;
     normalizeWorkspace?: boolean;
     logger?: {
-        debug?: (msg: string) => void;
-        info?: (msg: string) => void;
-        warn?: (msg: string) => void;
-        error?: (msg: string) => void;
+        /* eslint-disable no-unused-vars -- Reason: logger callback param names intentionally unused - callbacks only invoked for side effects */
+        debug?: (_msg: string) => void;
+        info?: (_msg: string) => void;
+        warn?: (_msg: string) => void;
+        error?: (_msg: string) => void;
+        /* eslint-enable no-unused-vars */
     };
 }
 
@@ -96,7 +98,6 @@ function findConfigFile(): string | null {
     return null;
 }
 
-/* eslint-disable no-console */
 function loadConfigFromFile(): PDConfig | null {
     const configPath = findConfigFile();
     if (!configPath) {
@@ -113,7 +114,6 @@ function loadConfigFromFile(): PDConfig | null {
         return null;
     }
 }
-/* eslint-enable no-console */
 
 export class PathResolver {
     private static extensionRoot: string | null = null;
@@ -302,7 +302,6 @@ export class PathResolver {
             'PROFILE': workspacePath.join(workspace, '.principles', 'PROFILE.json'),
             'PRINCIPLES': workspacePath.join(workspace, '.principles', 'PRINCIPLES.md'),
             'THINKING_OS': workspacePath.join(workspace, '.principles', 'THINKING_OS.md'),
-            'KERNEL': workspacePath.join(workspace, '.principles', '00-kernel.md'),
             'DECISION_POLICY': workspacePath.join(workspace, '.principles', 'DECISION_POLICY.json'),
             'MODELS_DIR': workspacePath.join(workspace, '.principles', 'models'),
             'PLAN': workspacePath.join(workspace, 'PLAN.md'),
@@ -355,25 +354,25 @@ export class PathResolver {
         }
     }
 
-    static createFromHookContext(ctx: any): PathResolver {
+    static createFromHookContext(ctx: Record<string, unknown>): PathResolver {
         const resolver = new PathResolver();
-        
+
         if (ctx?.workspaceDir) {
-            let workspaceDir = ctx.workspaceDir;
-            
+            let workspaceDir = String(ctx.workspaceDir);
+
             if (resolver.normalizeWorkspace) {
                 workspaceDir = resolver.normalizePath(workspaceDir);
             }
-            
+
             resolver.workspaceDir = workspaceDir;
             resolver.initialized = true;
             resolver.log('info', `Created from hook context with workspace: ${workspaceDir}`);
         }
-        
+
         if (ctx?.stateDir) {
-            resolver.stateDir = ctx.stateDir;
+            resolver.stateDir = String(ctx.stateDir);
         }
-        
+
         return resolver;
     }
 }
@@ -421,7 +420,9 @@ export function resolveWorkspaceDirFromApi(
     if (!api) return undefined;
 
     // 1. Official API: api.runtime.agent.resolveAgentWorkspaceDir
+    /* eslint-disable no-unused-vars -- Reason: type callback params cfg/id unused - actual values passed are api.config and agentId */
     const officialAgent = (api.runtime as { agent?: { resolveAgentWorkspaceDir?: (cfg: unknown, id: string) => string } }).agent;
+    /* eslint-enable no-unused-vars */
     if (officialAgent?.resolveAgentWorkspaceDir) {
         try {
             return officialAgent.resolveAgentWorkspaceDir(api.config, agentId ?? 'main');

package/src/core/paths.ts

@@ -33,6 +33,7 @@ export const PD_DIRS = {
     NOCTURNAL_SAMPLES: posixJoin('.state', 'nocturnal', 'samples'),
     NOCTURNAL_MEMORY: posixJoin('.state', 'nocturnal', 'memory'),
     NOCTURNAL_EXPORTS: posixJoin('.state', 'exports', 'orpo'),
+    IMPL_CODE_DIR: posixJoin('.state', 'principles', 'implementations'),
 };
 
 /**
@@ -42,7 +43,6 @@ export const PD_FILES = {
     PROFILE: posixJoin(PD_DIRS.IDENTITY, 'PROFILE.json'),
     PRINCIPLES: posixJoin(PD_DIRS.IDENTITY, 'PRINCIPLES.md'),
     THINKING_OS: posixJoin(PD_DIRS.IDENTITY, 'THINKING_OS.md'),
-    KERNEL: posixJoin(PD_DIRS.IDENTITY, '00-kernel.md'),
     DECISION_POLICY: posixJoin(PD_DIRS.IDENTITY, 'DECISION_POLICY.json'),
     MODELS_DIR: PD_DIRS.MODELS,
 
@@ -65,6 +65,7 @@ export const PD_FILES = {
     NOCTURNAL_SAMPLES_DIR: PD_DIRS.NOCTURNAL_SAMPLES,
     NOCTURNAL_MEMORY_DIR: PD_DIRS.NOCTURNAL_MEMORY,
     NOCTURNAL_EXPORTS_DIR: PD_DIRS.NOCTURNAL_EXPORTS,
+    IMPL_CODE_DIR: PD_DIRS.IMPL_CODE_DIR,
 
     PLAN: 'PLAN.md',
     MEMORY_MD: 'MEMORY.md',