principles-disciple 1.106.0 → 1.108.0

package/openclaw.plugin.json

@@ -2,7 +2,7 @@
   "id": "principles-disciple",
   "name": "Principles Disciple",
   "description": "Evolutionary programming agent framework with strategic guardrails and reflection loops.",
-  "version": "1.106.0",
+  "version": "1.108.0",
   "activation": {
     "onCapabilities": [
       "hook"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "principles-disciple",
-  "version": "1.106.0",
+  "version": "1.108.0",
   "description": "Native OpenClaw plugin for Principles Disciple",
   "type": "module",
   "main": "./dist/bundle.js",
@@ -34,7 +34,7 @@
     "build:bundle": "node esbuild.config.js",
     "build:production": "node esbuild.config.js --production && node scripts/verify-build.mjs",
     "test": "vitest run",
-    "test:unit": "vitest run tests/core tests/service tests/hooks tests/commands tests/utils tests/scripts --exclude tests/commands/evolver.test.ts",
+    "test:unit": "vitest run --config vitest.unit.config.ts tests/core tests/service tests/hooks tests/commands tests/utils tests/scripts --exclude tests/commands/evolver.test.ts",
     "test:integration": "vitest run tests/integration/",
     "test:coverage": "vitest run --coverage",
     "test:all": "vitest run",

package/src/core/init.ts

@@ -225,7 +225,9 @@ export function ensureCorePrinciples(stateDir: string, logger: PluginLogger): bo
       addPrincipleToLedger(stateDir, ledgerPrinciple);
     }
 
-    logger.info(`[PD] Initialized ${CORE_THINKING_MODELS.length} core thinking models: T-01 through T-10`);
+    const firstId = CORE_THINKING_MODELS[0]?.id ?? 'T-01';
+    const lastId = CORE_THINKING_MODELS[CORE_THINKING_MODELS.length - 1]?.id ?? 'T-10';
+    logger.info(`[PD] Initialized ${CORE_THINKING_MODELS.length} core thinking models: ${firstId} through ${lastId}`);
     return true;
   } catch (err) {
     logger.error(`[PD] Failed to initialize core principles: ${String(err)}`);

package/src/core/workspace-dir-validation.ts

@@ -1,8 +1,8 @@
 /**
  * WorkspaceDir Validation Utilities
  *
- * This module only validates candidate workspace directories and delegates
- * actual resolution policy to workspace-dir-service.ts.
+ * This module only validates candidate workspace directories. Runtime hook
+ * resolution policy lives at the I/O boundary in utils/workspace-resolver.ts.
  */
 
 import * as os from 'os';
@@ -49,4 +49,4 @@ export function validateWorkspaceDir(dir: string | undefined): string | null {
   }
 
   return null;
-}
+}

package/tests/core-anti-growth.test.ts

@@ -25,10 +25,8 @@ describe('PRI-212 plugin core anti-growth guard', () => {
   const ZERO_IMPORT_CANDIDATES = [
     'trajectory-types.ts',
     'profile.ts',
-    'pain-signal.ts',
     'pd-task-types.ts',
     'evolution-types.ts',
-    'telemetry-event.ts',
     'empathy-types.ts',
     'correction-types.ts',
     'principle-injection.ts',
@@ -39,12 +37,10 @@ describe('PRI-212 plugin core anti-growth guard', () => {
   const PLUGIN_IO_FILES = [
     // Thin adapter candidates
     'local-worker-routing.ts',
-    'principle-tree-migration.ts',
     'principle-internalization/principle-lifecycle-service.ts',
     'principle-tree-ledger-adapter.ts',
     'principle-compiler/ledger-registrar.ts',
     'principle-compiler/code-validator.ts',
-    'principle-injector.ts',
     'pd-task-service.ts',
     'principle-internalization/lifecycle-read-model.ts',
     'principle-internalization/filesystem-lifecycle-datasource.ts',
@@ -65,14 +61,10 @@ describe('PRI-212 plugin core anti-growth guard', () => {
     'pain-diagnostic-gate.ts',
     'hygiene/tracker.ts',
     'schema/migrations/002-init-central.ts',
-    'workspace-dir-service.ts',
     'paths.ts',
     'schema/migrations/004-add-thinking-and-gfi.ts',
-    'evolution-hook.ts',
-    'storage-adapter.ts',
     'schema/migrations/003-init-workflow.ts',
     'workspace-dir-validation.ts',
-    'pain-signal-adapter.ts',
     'rule-implementation-runtime.ts',
     'detection-service.ts',
     'schema/migrations/index.ts',
@@ -89,10 +81,8 @@ describe('PRI-212 plugin core anti-growth guard', () => {
     'model-training-registry.ts',
     'focus-history.ts',
     'model-deployment-registry.ts',
-    'training-program.ts',
     'replay-engine.ts',
     'external-training-contract.ts',
-    'merge-gate-audit.ts',
     'shadow-observation-registry.ts',
     'control-ui-db.ts',
     'thinking-models.ts',
@@ -100,11 +90,9 @@ describe('PRI-212 plugin core anti-growth guard', () => {
     'correction-cue-learner.ts',
     'principle-compiler/compiler.ts',
     'pain.ts',
-    'pain-context-extractor.ts',
     'config.ts',
     'code-implementation-storage.ts',
     'observability.ts',
-    'file-storage-adapter.ts',
     'workflow-funnel-loader.ts',
     'dictionary.ts',
     'thinking-os-parser.ts',
@@ -116,7 +104,6 @@ describe('PRI-212 plugin core anti-growth guard', () => {
     'pd-task-store.ts',
     'evolution-migration.ts',
     'empathy-keyword-matcher.ts',
-    'pain-lifecycle.ts',
     'session-tracker.ts',
     'principle-tree-ledger.ts',
     'evolution-logger.ts',

package/tests/hooks/prompt-characterization.test.ts

@@ -136,16 +136,6 @@ vi.mock('../../src/core/focus-history.js', () => ({
   safeReadCurrentFocus: vi.fn().mockReturnValue({ content: '', recovered: false, validationErrors: [] }),
 }));
 
-vi.mock('../../src/service/subagent-workflow/index.js', () => ({
-  EmpathyObserverWorkflowManager: vi.fn(),
-  empathyObserverWorkflowSpec: {},
-  isExpectedSubagentError: vi.fn().mockReturnValue(false),
-}));
-
-vi.mock('../../src/utils/subagent-probe.js', () => ({
-  isSubagentRuntimeAvailable: vi.fn().mockReturnValue(false),
-}));
-
 vi.mock('../../src/core/local-worker-routing.js', () => ({
   classifyTask: vi.fn().mockReturnValue({
     decision: 'stay_main',
@@ -483,4 +473,4 @@ describe('Size guard: never exceeds 9000 chars', () => {
     await expect(handleBeforePromptBuild(makeMinimalEvent(), makeCtx({ trigger: 'user' })))
       .resolves.toBeDefined();
   });
-});
+});

package/tests/hooks/prompt-diet.test.ts

@@ -20,10 +20,12 @@ import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 beforeEach(() => {
   vi.clearAllMocks();
   process.env.PD_LEGACY_PROMPT_DIAGNOSTICIAN_ENABLED = 'true';
+  process.env.PD_EMPATHY_API_KEY_ENV = 'PD_TEST_DISABLED_EMPATHY_API_KEY';
 });
 
 afterEach(() => {
   process.env.PD_LEGACY_PROMPT_DIAGNOSTICIAN_ENABLED = '';
+  delete process.env.PD_EMPATHY_API_KEY_ENV;
 });
 
 const mockGetPendingDiagnosticianTasks = vi.fn<(stateDir: string) => unknown[]>();
@@ -123,16 +125,6 @@ vi.mock('../../src/core/focus-history.js', () => ({
   safeReadCurrentFocus: vi.fn().mockReturnValue({ content: '', recovered: false, validationErrors: [] }),
 }));
 
-vi.mock('../../src/service/subagent-workflow/index.js', () => ({
-  EmpathyObserverWorkflowManager: vi.fn(),
-  empathyObserverWorkflowSpec: {},
-  isExpectedSubagentError: vi.fn().mockReturnValue(false),
-}));
-
-vi.mock('../../src/utils/subagent-probe.js', () => ({
-  isSubagentRuntimeAvailable: vi.fn().mockReturnValue(false),
-}));
-
 vi.mock('../../src/core/local-worker-routing.js', () => ({
   classifyTask: vi.fn().mockReturnValue({
     decision: 'stay_main',
@@ -304,7 +296,7 @@ describe('PRI-291 Prompt Diet: MVP sections preserved', () => {
       resolve: (key: string) => `/fake/${key}`,
       trajectory: { recordSession: vi.fn(), recordUserTurn: vi.fn(), recordPainEvent: vi.fn() },
       config: { get: vi.fn().mockImplementation((k: string) => {
-        if (k === 'thresholds.pain_trigger') return 40;
+        if (k === 'thresholds.pain_trigger') return 100;
         if (k === 'severity_thresholds.high') return 70;
         if (k === 'language') return 'en';
         return undefined;

package/tests/hooks/prompt-size-guard.test.ts

@@ -118,16 +118,6 @@ vi.mock('../../src/core/focus-history.js', () => ({
   safeReadCurrentFocus: vi.fn().mockReturnValue({ content: '', recovered: false, validationErrors: [] }),
 }));
 
-vi.mock('../../src/service/subagent-workflow/index.js', () => ({
-  EmpathyObserverWorkflowManager: vi.fn(),
-  empathyObserverWorkflowSpec: {},
-  isExpectedSubagentError: vi.fn().mockReturnValue(false),
-}));
-
-vi.mock('../../src/utils/subagent-probe.js', () => ({
-  isSubagentRuntimeAvailable: vi.fn().mockReturnValue(false),
-}));
-
 vi.mock('../../src/core/local-worker-routing.js', () => ({
   classifyTask: vi.fn().mockReturnValue({
     decision: 'stay_main',

package/tests/hooks/runtime-v2-prompt-activation.test.ts

@@ -145,16 +145,6 @@ vi.mock('../../src/core/focus-history.js', () => ({
   safeReadCurrentFocus: vi.fn().mockReturnValue({ content: '', recovered: false, validationErrors: [] }),
 }));
 
-vi.mock('../../src/service/subagent-workflow/index.js', () => ({
-  EmpathyObserverWorkflowManager: vi.fn(),
-  empathyObserverWorkflowSpec: {},
-  isExpectedSubagentError: vi.fn().mockReturnValue(false),
-}));
-
-vi.mock('../../src/utils/subagent-probe.js', () => ({
-  isSubagentRuntimeAvailable: vi.fn().mockReturnValue(false),
-}));
-
 vi.mock('../../src/core/local-worker-routing.js', () => ({
   classifyTask: vi.fn().mockReturnValue({
     decision: 'stay_main',

package/tests/index.test.ts

@@ -89,7 +89,7 @@ describe('Command Registration', () => {
     expect(pdPain).toBeDefined();
 
     const ctx: PluginCommandContext = {
-      sessionId: 'session-123',
+      sessionId: '',
       sessionKey: 'sk-123',
       workspaceDir: '/mock/workspace',
       args: 'test pain reason',

package/tests/runtime-v2-discovery-guard.test.ts

@@ -17,7 +17,6 @@ describe('PRI-228: Runtime V2 discovery guard', () => {
   const guardedFiles = [
     { name: 'workspace-resolver.ts', path: path.join(PLUGIN_SRC, 'utils', 'workspace-resolver.ts') },
     { name: 'workspace-context.ts', path: path.join(PLUGIN_SRC, 'core', 'workspace-context.ts') },
-    { name: 'workspace-dir-service.ts', path: path.join(PLUGIN_SRC, 'core', 'workspace-dir-service.ts') },
     { name: 'path-resolver.ts', path: path.join(PLUGIN_SRC, 'core', 'path-resolver.ts') },
   ];
 
@@ -151,4 +150,4 @@ describe('PRI-228: Runtime V2 discovery guard', () => {
       expect(content).toContain('resolveWorkspaceDirForRuntimeV2(');
     });
   });
-});
+});

package/vitest.config.ts

@@ -19,7 +19,7 @@ import { defineConfig } from 'vitest/config';
 
 // Integration tests: use real SQLite database
 // These tests require better-sqlite3 to be compiled
-const integrationTests = [
+export const integrationTests = [
   // Core DB tests
   'tests/core/control-ui-db.test.ts',
   'tests/core/evolution-logger.test.ts',
@@ -31,7 +31,6 @@ const integrationTests = [
   'tests/service/keyword-optimization-service.test.ts',
   // Hook tests with DB dependencies
   'tests/hooks/subagent.test.ts',
-  'tests/hooks/gate-pipeline-integration.test.ts',
   'tests/hooks/gate-rule-host-pipeline.test.ts',
   // Script tests with DB
   'tests/scripts/validate-live-path.test.ts',
@@ -59,4 +58,4 @@ export default defineConfig({
       },
     },
   },
-});
+});

package/vitest.unit.config.ts

@@ -0,0 +1,12 @@
+import { defineConfig, mergeConfig } from 'vitest/config';
+import baseConfig, { integrationTests } from './vitest.config.js';
+
+export default mergeConfig(baseConfig, defineConfig({
+  test: {
+    exclude: [
+      '**/node_modules/**',
+      '**/dist/**',
+      ...integrationTests,
+    ],
+  },
+}));

package/src/core/evolution-hook.ts

@@ -1,74 +0,0 @@
-/**
- * EvolutionHook interface for the Evolution SDK.
- *
- * Provides a callback-based interface for observing evolution lifecycle
- * events: pain detection, principle creation, and principle promotion.
- *
- * Per D-03, this interface contains only the 3 core event methods.
- * Per D-04, consumers implement the interface directly (no EventEmitter).
- * Hooks not needed can use the provided noOpEvolutionHook and override
- * individual methods.
- */
-import type { PainSignal } from './pain-signal.js';
-
-// ---------------------------------------------------------------------------
-// Event Types
-// ---------------------------------------------------------------------------
-
-/** Event payload for principle creation lifecycle events. */
-export interface PrincipleCreatedEvent {
-  /** Unique principle identifier */
-  id: string;
-  /** Principle text ("When X, then Y.") */
-  text: string;
-  /** What triggered this principle's creation */
-  trigger: string;
-}
-
-/** Event payload for principle promotion lifecycle events. */
-export interface PrinciplePromotedEvent {
-  /** Unique principle identifier */
-  id: string;
-  /** Previous status tier */
-  from: string;
-  /** New status tier */
-  to: string;
-}
-
-// ---------------------------------------------------------------------------
-// EvolutionHook Interface
-// ---------------------------------------------------------------------------
-
-/**
- * Callback interface for observing evolution lifecycle events.
- *
- * Implement all 3 methods, or spread noOpEvolutionHook and override
- * only the methods you need:
- *
- * @example
- * ```ts
- * const myHook: EvolutionHook = {
- *   ...noOpEvolutionHook,
- *   onPainDetected(signal) { console.log(signal); },
- * };
- * ```
- */
-export interface EvolutionHook {
-  /** Called when a pain signal is detected and recorded. */
-  onPainDetected(signal: PainSignal): void;
-  /** Called when a new principle candidate is created. */
-  onPrincipleCreated(event: PrincipleCreatedEvent): void;
-  /** Called when a principle is promoted to a higher tier. */
-  onPrinciplePromoted(event: PrinciplePromotedEvent): void;
-}
-
-// ---------------------------------------------------------------------------
-// No-op Helper
-// ---------------------------------------------------------------------------
-
-/** No-op implementation -- consumers can spread and override individual methods. */
-export const noOpEvolutionHook: EvolutionHook = {
-  onPainDetected(_signal: PainSignal): void {},
-  onPrincipleCreated(_event: PrincipleCreatedEvent): void {},
-  onPrinciplePromoted(_event: PrinciplePromotedEvent): void {},
-};

package/src/core/file-storage-adapter.ts

@@ -1,203 +0,0 @@
-/**
- * FileStorageAdapter — file-backed implementation of StorageAdapter.
- *
- * Wraps principle-tree-ledger functions with the async StorageAdapter
- * contract. Uses withLockAsync for thread-safe mutateLedger with
- * retry with exponential backoff for lock acquisition (5 retries).
- * Write failures are logged via SystemLogger and re-thrown.
- *
- * Guarantees:
- * - Atomic writes via atomicWriteFileSync (temp + rename)
- * - Thread-safe concurrent access via file locks
- * - Consistent read-after-write visibility
- * - Write failures logged to SystemLogger and re-thrown
- */
-import * as fs from 'fs';
-import * as path from 'path';
-import type { StorageAdapter } from './storage-adapter.js';
-import type { HybridLedgerStore } from './principle-tree-ledger.js';
-import { TREE_NAMESPACE } from './principle-tree-ledger.js';
-import {
-  loadLedger as loadLedgerFromFile,
-  saveLedgerAsync,
-} from './principle-tree-ledger.js';
-import { withLockAsync, type LockOptions, LockAcquisitionError } from '../utils/file-lock.js';
-import { atomicWriteFileSync } from '../utils/io.js';
-import { SystemLogger } from './system-logger.js';
-
-// ---------------------------------------------------------------------------
-// Configuration
-// ---------------------------------------------------------------------------
-
-/** Maximum retries for lock acquisition in mutateLedger. */
-const MUTATE_RETRY_COUNT = 5;
-
-/** Base delay in ms for exponential backoff between retries. */
-const MUTATE_BACKOFF_BASE_MS = 50;
-
-/** Maximum backoff delay in ms. */
-const MUTATE_BACKOFF_MAX_MS = 500;
-
-const PRINCIPLE_TRAINING_FILE = 'principle_training_state.json';
-
-// ---------------------------------------------------------------------------
-// Internal helpers
-// ---------------------------------------------------------------------------
-
-/**
- * Serialize the hybrid ledger store to JSON.
- * Mirrors the unexported serializeLedger from principle-tree-ledger.ts.
- */
-function serializeStore(store: HybridLedgerStore): string {
-  return JSON.stringify(
-    {
-      ...store.trainingStore,
-      [TREE_NAMESPACE]: {
-        ...store.tree,
-        lastUpdated: new Date().toISOString(),
-      },
-    },
-    null,
-    2,
-  );
-}
-
-/** Ensure the parent directory exists before writing. */
-function ensureParentDir(filePath: string): void {
-  const dir = path.dirname(filePath);
-  if (!fs.existsSync(dir)) {
-    fs.mkdirSync(dir, { recursive: true });
-  }
-}
-
-// ---------------------------------------------------------------------------
-// FileStorageAdapter
-// ---------------------------------------------------------------------------
-
-/**
- * File-system backed storage adapter for the principle ledger.
- *
- * Delegates read/write operations to principle-tree-ledger while providing
- * the async StorageAdapter interface. The mutateLedger method uses
- * withLockAsync with exponential backoff retry for robust concurrent access.
- */
-export class FileStorageAdapter implements StorageAdapter {
-  private readonly stateDir: string;
-  private readonly workspaceDir: string | undefined;
-
-  constructor(stateDir: string, workspaceDir?: string) {
-    this.stateDir = stateDir;
-    this.workspaceDir = workspaceDir;
-  }
-
-  /** Resolve the ledger file path for this state directory. */
-  private get filePath(): string {
-    return path.join(this.stateDir, PRINCIPLE_TRAINING_FILE);
-  }
-
-  /**
-   * Load the current ledger state from the file system.
-   *
-   * Returns an empty store if no persisted state exists (first run).
-   * Uses the synchronous loadLedger from principle-tree-ledger which
-   * handles missing/corrupted files gracefully.
-   */
-  async loadLedger(): Promise<HybridLedgerStore> {
-    return loadLedgerFromFile(this.stateDir);
-  }
-
-  /**
-   * Persist the full ledger state atomically.
-   *
-   * Delegates to principle-tree-ledger's saveLedgerAsync which uses
-   * withLockAsync internally. Logs failures via SystemLogger.
-   */
-  async saveLedger(store: HybridLedgerStore): Promise<void> {
-    try {
-      await saveLedgerAsync(this.stateDir, store);
-    } catch (err) {
-      SystemLogger.log(
-        this.workspaceDir,
-        'STORAGE_WRITE_FAILED',
-        `FileStorageAdapter.saveLedger failed: ${String(err)}`,
-      );
-      throw err;
-    }
-  }
-
-  /**
-   * Perform a read-modify-write cycle with automatic locking and retry.
-   *
-   * Uses withLockAsync to acquire a file lock, reads the current store,
-   * applies the mutate function, then writes the modified store atomically.
-   * On lock acquisition failure, retries up to MUTATE_RETRY_COUNT (5) times
-   * with exponential backoff + jitter to reduce contention.
-   *
-   * Write failures are logged to SystemLogger and re-thrown so callers
-   * can decide how to handle persistence errors.
-   */
-  async mutateLedger<T>(mutate: (store: HybridLedgerStore) => T | Promise<T>): Promise<T> {
-    let lastError: Error | undefined;
-
-    for (let attempt = 0; attempt < MUTATE_RETRY_COUNT; attempt++) {
-      try {
-        const lockOptions: LockOptions = {
-          maxRetries: 3,
-          baseRetryDelayMs: 10,
-          maxRetryDelayMs: 200,
-          lockStaleMs: 10_000,
-        };
-
-        const ledgerPath = this.filePath;
-
-        return await withLockAsync(ledgerPath, async () => {
-          const store = loadLedgerFromFile(this.stateDir);
-          const result = await mutate(store);
-
-          // Write directly — we already hold the lock, so we must NOT
-          // call saveLedger/saveLedgerAsync (they try to acquire the same lock).
-          try {
-            ensureParentDir(ledgerPath);
-            atomicWriteFileSync(ledgerPath, serializeStore(store));
-          } catch (writeErr) {
-            SystemLogger.log(
-              this.workspaceDir,
-              'STORAGE_WRITE_FAILED',
-              `FileStorageAdapter.mutateLedger write failed: ${String(writeErr)}`,
-            );
-            throw writeErr;
-          }
-
-          return result;
-        }, lockOptions);
-      } catch (err) {
-        lastError = err as Error;
-
-        // Only retry on lock acquisition errors
-        if (err instanceof LockAcquisitionError && attempt < MUTATE_RETRY_COUNT - 1) {
-          const delay = Math.min(
-            MUTATE_BACKOFF_BASE_MS * Math.pow(2, attempt),
-            MUTATE_BACKOFF_MAX_MS,
-          );
-          // Add jitter (0-20%) to avoid thundering herd
-          const jitter = delay * 0.2 * Math.random();
-          const totalDelay = Math.floor(delay + jitter);
-
-          await new Promise((resolve) => setTimeout(resolve, totalDelay));
-          continue;
-        }
-
-        // Non-retryable error or exhausted retries
-        SystemLogger.log(
-          this.workspaceDir,
-          'STORAGE_MUTATE_FAILED',
-          `FileStorageAdapter.mutateLedger failed after ${attempt + 1} attempts: ${String(err)}`,
-        );
-        throw err;
-      }
-    }
-
-    // Should not reach here, but satisfy the type checker
-    throw lastError ?? new Error('FileStorageAdapter.mutateLedger: unexpected state');
-  }
-}