primitive-admin 1.2.0-alpha.4 → 1.2.0-alpha.5

package/dist/src/commands/databases.js

@@ -2,12 +2,9 @@ import { readFileSync, writeFileSync, appendFileSync, mkdirSync, existsSync, rea
 import * as path from "path";
 import { ApiClient } from "../lib/api-client.js";
 import { getCurrentAppId, resolveAppId } from "../lib/config.js";
-import { resolveCodegenSourceDir } from "../lib/codegen-shared/resolveCodegenSourceDir.js";
 import { resolveSyncDir } from "../lib/sync-paths.js";
 import { parseCsv, applyColumnMap, buildRows } from "../lib/csv.js";
 import { chunk, parseBatchSize } from "../lib/batch.js";
-import { generateDbTypes, } from "../lib/db-codegen/dbGenerator.js";
-import { generateDbSwiftTypes } from "../lib/swift-codegen/dbGenerator.js";
 import { success, error, info, warn, keyValue, result as printResult, formatTable, formatId, formatDate, json, } from "../lib/output.js";
 import { renderAggregateResult } from "../lib/aggregate-output.js";
 import { confirmPrompt } from "../lib/confirm-prompt.js";
@@ -53,49 +50,6 @@ function assertDataIdMatches(data, recordId, writtenId, commandPath) {
         : `Pass the record id as the argument, not inside --data: ${commandPath} ${dataId} --data ...`);
     process.exit(1);
 }
-/**
- * Validate that the named operation is an import-compatible, save-like
- * mutation before importing (issue #145, Codex finding (a)).
- *
- * The importer always builds `params: { modelName, id, data }`, and the batch
- * endpoint rejects undeclared params per item. So we require the op to be a
- * `mutation` whose declared `params` cover `modelName`, `id`, and `data`. This
- * surfaces a clear up-front error instead of letting every row fail
- * server-side. Exits non-zero on any mismatch.
- */
-async function validateImportOperation(client, appId, databaseId, operationName) {
-    let ops;
-    try {
-        ops = await client.listDatabaseOperations(appId, databaseId);
-    }
-    catch (err) {
-        error(`Could not list operations for this database: ${err?.message || err}`);
-        process.exit(1);
-        return;
-    }
-    const op = (ops || []).find((o) => o?.name === operationName);
-    if (!op) {
-        error(`Operation "${operationName}" not found — create a mutation op (e.g. ` +
-            `\`seed_save\`) on this database type first.`);
-        process.exit(1);
-        return;
-    }
-    if (op.type !== "mutation") {
-        error(`Operation "${operationName}" is a "${op.type}" op, not an import-compatible ` +
-            `mutation. CSV import needs a save-like mutation taking {modelName, id, data}.`);
-        process.exit(1);
-        return;
-    }
-    const params = op.params || {};
-    const missing = ["modelName", "id", "data"].filter((p) => !(p in params));
-    if (missing.length > 0) {
-        error(`Operation "${operationName}" is not import-compatible: its params are missing ` +
-            `${missing.join(", ")}. CSV import builds {modelName, id, data} per item, so the ` +
-            `op must declare those params (like \`seed_save\`).`);
-        process.exit(1);
-        return;
-    }
-}
 /**
  * The full `databases records bulk` precondition value space, audited in one
  * pass (issue #2437, Codex cycle 3). A precondition is field-equality only, so
@@ -1158,144 +1112,6 @@ database-type-config' and the 'database-type-configs' group for inspection:
             process.exit(1);
         }
     });
-    // ---- Operations subcommand group ----
-    const operations = databases
-        .command("operations")
-        .description("List and execute registered operations on a database");
-    // List operations
-    operations
-        .command("list")
-        .description("List registered operations available on a database")
-        .argument("<database-id>", "Database ID")
-        .option("--app <app-id>", "App ID")
-        .option("--json", "Output as JSON")
-        .action(async (databaseId, options) => {
-        const resolvedAppId = resolveAppId(undefined, options);
-        const client = new ApiClient();
-        try {
-            const result = await client.listDatabaseOperations(resolvedAppId, databaseId);
-            const list = Array.isArray(result) ? result : [];
-            if (options.json) {
-                json(wholeListEnvelope(list));
-                return;
-            }
-            if (list.length === 0) {
-                info("No operations found.");
-                return;
-            }
-            console.log(formatTable(list, [
-                { header: "NAME", key: "name" },
-                { header: "TYPE", key: "type" },
-                { header: "MODEL", key: "modelName" },
-                { header: "ACCESS", key: "access" },
-            ]));
-        }
-        catch (err) {
-            error(err.message);
-            process.exit(1);
-        }
-    });
-    // Execute operation
-    operations
-        .command("execute")
-        .description("Execute a registered operation on a database")
-        .argument("<database-id>", "Database ID")
-        .argument("<operation-name>", "Operation name")
-        .option("--params <json>", "Operation parameters as JSON")
-        .option("--limit <n>", "Max records to return (for queries)")
-        .option("--cursor <cursor>", "Pagination cursor")
-        .option("--app <app-id>", "App ID")
-        .option("--json", "Output as JSON")
-        .option("--timing", "Show server-side timing breakdown")
-        .action(async (databaseId, operationName, options) => {
-        const resolvedAppId = resolveAppId(undefined, options);
-        const client = new ApiClient();
-        let params;
-        if (options.params) {
-            try {
-                params = JSON.parse(options.params);
-            }
-            catch {
-                error("Invalid --params JSON.");
-                process.exit(1);
-                return;
-            }
-        }
-        const body = {};
-        if (params)
-            body.params = params;
-        if (options.limit)
-            body.limit = parseInt(options.limit, 10);
-        if (options.cursor)
-            body.cursor = options.cursor;
-        try {
-            const result = await client.executeDatabaseOperation(resolvedAppId, databaseId, operationName, body, { timing: !!options.timing });
-            if (options.json) {
-                json(result);
-                return;
-            }
-            // Smart display based on result shape. `executeDatabaseOperation()`
-            // has already normalized a query page to `{ items, hasMore,
-            // nextCursor? }` (#2440), so `items` is exactly "this result was a
-            // list" — the two branches cannot disagree about it.
-            if (Array.isArray(result.items)) {
-                if (result.items.length === 0) {
-                    info("No records found.");
-                }
-                else {
-                    const cols = Object.keys(result.items[0]).filter((k) => k !== "type");
-                    console.log(formatTable(result.items, cols.map((c) => ({
-                        header: c.toUpperCase(),
-                        key: c,
-                        format: (v) => {
-                            if (v === null || v === undefined)
-                                return "—";
-                            if (typeof v === "object") {
-                                const s = JSON.stringify(v);
-                                return s.length > 50 ? s.slice(0, 47) + "..." : s;
-                            }
-                            const s = String(v);
-                            return s.length > 50 ? s.slice(0, 47) + "..." : s;
-                        },
-                    }))));
-                }
-                // Gate on the cursor itself, the way `records query` does: `hasMore`
-                // without a cursor used to print the literal `undefined` (#2440).
-                if (result.nextCursor) {
-                    info(`More records available. Use --cursor ${result.nextCursor} to continue.`);
-                }
-            }
-            else if (result.count !== undefined) {
-                console.log(`Count: ${result.count}`);
-            }
-            else if (result.result !== undefined) {
-                // Aggregate result
-                json(result);
-            }
-            else if (result.results && Array.isArray(result.results)) {
-                // Batch/mutation results
-                success(`Operation executed (${result.results.length} result${result.results.length === 1 ? "" : "s"}).`);
-            }
-            else if (result.success !== undefined) {
-                success("Operation executed.");
-            }
-            else {
-                json(result);
-            }
-            // Display timing if present
-            if (result._timing) {
-                console.log("");
-                console.log("Timing:");
-                for (const [key, value] of Object.entries(result._timing)) {
-                    console.log(`  ${key}: ${value}ms`);
-                }
-            }
-        }
-        catch (err) {
-            error(err.message);
-            process.exit(1);
-        }
-    });
     // ---- Indexes subcommand group ----
     const indexes = databases
         .command("indexes")
@@ -1616,11 +1432,10 @@ database-type-config' and the 'database-type-configs' group for inspection:
     // ============================================
     databases
         .command("import-csv")
-        .description("Import rows from a CSV file into a database via a registered batch (bulk) save operation")
+        .description("Import rows from a CSV file into a database: one save per row through records/batch, best-effort (a row the database refuses is counted as failed and the rest are written)")
         .argument("<database-id>", "Database ID")
         .argument("<file>", "Path to the CSV file")
-        .requiredOption("--model <name>", "Model name passed in each item's params")
-        .option("--operation <op>", "Registered mutation operation to use (must be a {modelName,id,data} save-like op)", "seed_save")
+        .requiredOption("--model <name>", "Model every row is saved into")
         .option("--column-map <json>", 'Map CSV headers to field names, e.g. \'{"CSV Header":"fieldName"}\'')
         .option("--types <json>", 'Coerce fields by type, e.g. \'{"price":"number","active":"boolean"}\'')
         .option("--id-column <col>", "Use this CSV column for record ids (else a ULID is generated)")
@@ -1656,11 +1471,11 @@ database-type-config' and the 'database-type-configs' group for inspection:
                 return;
             }
         }
-        // The registered-batch (`executeBatch`) path rejects requests over
-        // 100000 items server-side; keep chunks under it.
+        // `records/batch` has no fixed server item cap — bound it with the same
+        // conservative client-side ceiling `databases import` uses.
         const parsedBatchSize = parseBatchSize(options.batchSize, {
-            max: 100000,
-            overMaxMessage: "--batch-size cannot exceed 100000 (the server's per-request cap).",
+            max: IMPORT_BATCH_SIZE_CEILING,
+            overMaxMessage: `--batch-size cannot exceed ${IMPORT_BATCH_SIZE_CEILING} (a conservative client-side limit for batch write requests).`,
         });
         if ("error" in parsedBatchSize) {
             error(parsedBatchSize.error);
@@ -1679,21 +1494,14 @@ database-type-config' and the 'database-type-configs' group for inspection:
             let rows = parseCsv(raw, options.delimiter);
             // 2. Apply column map.
             rows = applyColumnMap(rows, columnMap);
-            // 3. Coerce types, assign ids, shape into batch items.
+            // 3. Coerce types, assign ids, shape into records/batch saves.
             const { batch, rowCount } = buildRows(rows, {
                 modelName: options.model,
                 types,
                 idColumn: options.idColumn,
             });
             const chunks = chunk(batch, batchSize);
-            // 4. Validate the chosen op is an import-compatible save-like mutation
-            //    BEFORE writing (op-not-found / incompatible → clear up-front error
-            //    rather than per-row server-side failure). Skip the round-trip only
-            //    when there is genuinely nothing to import in a dry run.
-            if (!options.dryRun || rowCount > 0) {
-                await validateImportOperation(client, resolvedAppId, databaseId, options.operation);
-            }
-            // 5. Empty / headers-only CSV: no request, report 0/0.
+            // 4. Empty / headers-only CSV: no request, report 0/0.
             if (rowCount === 0) {
                 if (options.json) {
                     json({ imported: 0, failed: 0, rows: 0, batches: 0, errors: [], dryRun: !!options.dryRun });
@@ -1704,7 +1512,7 @@ database-type-config' and the 'database-type-configs' group for inspection:
                 }
                 return;
             }
-            // 6. Dry run: report counts, no writes.
+            // 5. Dry run: report counts, no writes.
             if (options.dryRun) {
                 if (options.json) {
                     json({ dryRun: true, rows: rowCount, batches: chunks.length, batchSize });
@@ -1717,32 +1525,60 @@ database-type-config' and the 'database-type-configs' group for inspection:
                 }
                 return;
             }
-            // 7. Import chunk by chunk; accumulate imported/failed + per-chunk errors.
+            // 6. Import chunk by chunk through records/batch, non-atomic (the
+            //    route's default): each row's outcome is its own, so a refused row
+            //    is counted failed and its siblings commit.
             let imported = 0;
             let failed = 0;
             const errors = [];
             let aborted = false;
             for (let i = 0; i < chunks.length; i++) {
                 const piece = chunks[i];
+                let chunkFailed = false;
                 try {
-                    const res = await client.executeBatch(resolvedAppId, databaseId, options.operation, piece);
-                    imported += res.imported ?? 0;
-                    failed += res.failed ?? 0;
+                    const res = await client.batchDatabaseRecords(resolvedAppId, databaseId, piece);
+                    const results = res?.results ?? [];
+                    let chunkImported = 0;
+                    let chunkRefused = 0;
+                    const firstErrors = [];
+                    for (let j = 0; j < piece.length; j++) {
+                        const r = results[j];
+                        if (r && r.success) {
+                            chunkImported++;
+                        }
+                        else {
+                            chunkRefused++;
+                            if (r?.error && firstErrors.length < 3)
+                                firstErrors.push(r.error);
+                        }
+                    }
+                    imported += chunkImported;
+                    failed += chunkRefused;
+                    if (chunkRefused > 0) {
+                        chunkFailed = true;
+                        errors.push({
+                            batch: i,
+                            error: `${chunkRefused} row(s) failed${firstErrors.length ? `: ${firstErrors.join("; ")}` : ""}`,
+                        });
+                    }
                     if (!options.json) {
-                        info(`Batch ${i + 1}/${chunks.length}: imported ${res.imported ?? 0}, failed ${res.failed ?? 0}`);
+                        info(`Batch ${i + 1}/${chunks.length}: imported ${chunkImported}, failed ${chunkRefused}`);
                     }
                 }
                 catch (err) {
+                    // A chunk-level failure (a 400 for a malformed op): the whole
+                    // chunk was refused, so every row in it counts as failed.
                     const msg = err?.message || String(err);
+                    chunkFailed = true;
                     errors.push({ batch: i, error: msg });
                     failed += piece.length;
                     if (!options.json) {
                         warn(`Batch ${i + 1}/${chunks.length} failed: ${msg}`);
                     }
-                    if (options.stopOnError) {
-                        aborted = true;
-                        break;
-                    }
+                }
+                if (chunkFailed && options.stopOnError) {
+                    aborted = true;
+                    break;
                 }
             }
             if (options.json) {
@@ -1760,7 +1596,7 @@ database-type-config' and the 'database-type-configs' group for inspection:
                     }
                 }
             }
-            // Non-zero exit if any chunk errored.
+            // Non-zero exit if any row or chunk failed.
             if (errors.length > 0) {
                 process.exit(1);
             }
@@ -1778,7 +1614,7 @@ database-type-config' and the 'database-type-configs' group for inspection:
         .description("Manage the TOML schema attached to a database type");
     schema
         .command("generate")
-        .description("Scaffold a starting TOML schema for <database-type> from existing operations + DO introspection, and insert it into the local database-type-configs/<type>.toml file.")
+        .description("Scaffold a starting TOML schema for <database-type> from the models and fields its databases hold, and append it to the local database-type-configs/<type>.toml file.")
         .argument("<database-type>", "Database type name")
         .option("-f, --force", "Overwrite an existing [models.*] block in the local file")
         .option("--json", "Output the generated TOML as JSON")
@@ -1817,10 +1653,10 @@ database-type-config' and the 'database-type-configs' group for inspection:
                 console.log(scaffoldedToml);
                 return;
             }
-            // 3. For each candidate, splice the scaffolded TOML at a stable
-            // anchor (before the first `[[operations]]` block, or at EOF). Per
-            // the plan-of-record, textual insertion is deliberate — smol-toml
-            // parse/stringify drops comments, so we splice as a raw string.
+            // 3. For each candidate, append the scaffolded TOML at the end of the
+            // file. Per the plan-of-record, textual insertion is deliberate —
+            // smol-toml parse/stringify drops comments, so we splice as a raw
+            // string.
             for (const targetPath of candidateFiles) {
                 const original = readFileSync(targetPath, "utf-8");
                 // Detect existing [models.*] block. If present, refuse unless --force.
@@ -1829,26 +1665,9 @@ database-type-config' and the 'database-type-configs' group for inspection:
                     error(`${targetPath} already has [models.*] blocks. Re-run with --force to overwrite.`);
                     process.exit(1);
                 }
-                // Strip existing [models.*] blocks if --force.
-                let cleaned = original;
-                if (hasModelsBlock && options.force) {
-                    cleaned = stripModelsBlocks(original);
-                }
-                // Splice: insert before the first [[operations]] block, otherwise
-                // at the end of file.
-                let merged;
-                const opsAnchor = cleaned.indexOf("\n[[operations]]");
-                if (opsAnchor >= 0) {
-                    merged =
-                        cleaned.slice(0, opsAnchor + 1) +
-                            scaffoldedToml +
-                            "\n" +
-                            cleaned.slice(opsAnchor + 1);
-                }
-                else {
-                    const sep = cleaned.endsWith("\n") ? "" : "\n";
-                    merged = cleaned + sep + scaffoldedToml + "\n";
-                }
+                const merged = spliceScaffoldedSchema(original, scaffoldedToml, {
+                    force: !!options.force,
+                });
                 writeFileSync(targetPath, merged);
                 success(`Inserted schema into ${targetPath}`);
             }
@@ -1859,137 +1678,18 @@ database-type-config' and the 'database-type-configs' group for inspection:
             process.exit(1);
         }
     });
-    // ============================================
-    // Codegen command (issue #814)
-    // ============================================
-    databases
-        .command("codegen")
-        .description("Generate record + operation types from the local database-type-configs/*.toml schema. TypeScript (default): a <type>.generated.ts per database type (record interfaces, per-op input-params interfaces, per-op result aliases, and a typed <type>Subscriptions factory when the type registers subscriptions). Swift (--lang swift): a <type>.generated.swift per database type (record structs, per-op params structs, per-op result typealiases, and a typed Subscriptions factory when the type registers subscriptions).\n\nFormatting: the emitted TypeScript is already formatted the way Prettier's DEFAULT config formats it, so a `codegen` -> `prettier --write` -> `codegen --check` pipeline stays green. If your project uses a NON-default Prettier config (a different printWidth, trailingComma, or quote style), Prettier will reformat the generated files and `--check` will then fail: add the generated directory to `.prettierignore` and commit the raw emission instead.")
-        .argument("[database-type]", "Generate for a single database type (defaults to every database-type-configs/*.toml found)")
-        .option("-o, --output <dir>", "Output directory for the generated files (defaults to <config-dir>/database-type-configs/generated/)")
-        .option("--lang <lang>", "Target language for the generated types: 'ts' (default) or 'swift'.", "ts")
-        .option("--check", "Exit non-zero if generated output is out of date (CI guard); does not write. Compares byte-for-byte, so the file on disk must match the emission exactly.")
-        .option("--json", "Output the result summary as JSON")
-        .action(async (databaseType, options) => {
-        try {
-            // 0. Validate --lang up front so an unknown value fails clearly rather
-            //    than silently defaulting to the TS emitter.
-            const lang = String(options.lang ?? "ts").toLowerCase();
-            if (lang !== "ts" && lang !== "swift") {
-                error(`Unknown --lang "${options.lang}". Use "ts" or "swift".`);
-                process.exit(1);
-            }
-            // 1. The single source database-type-configs/ directory: the
-            //    environment's, and only ever the environment's (#1510, #3154).
-            const dbTypesSourceDir = resolveCodegenSourceDir({
-                subdir: "database-type-configs",
-            });
-            // 2. Collect the source .toml files (one per database type), filtered
-            //    to a single type when an argument is given.
-            const inputs = [];
-            for (const fileName of readdirSync(dbTypesSourceDir)) {
-                if (!fileName.endsWith(".toml"))
-                    continue;
-                const typeName = fileName.slice(0, -".toml".length);
-                if (databaseType && typeName !== databaseType)
-                    continue;
-                const tomlPath = path.join(dbTypesSourceDir, fileName);
-                inputs.push({
-                    databaseType: typeName,
-                    tomlPath,
-                    tomlContent: readFileSync(tomlPath, "utf-8"),
-                });
-            }
-            if (inputs.length === 0) {
-                error(databaseType
-                    ? `No database-type-configs/${databaseType}.toml found under primitive/<env>/.`
-                    : "No database-type-configs/*.toml files found to generate from.");
-                process.exit(1);
-            }
-            // 3. Resolve the output directory. Default: a `generated/` subdir of
-            //    the first source dir (keeps generated output beside the schema).
-            const outputDir = options.output
-                ? path.resolve(options.output)
-                : path.join(path.dirname(inputs[0].tomlPath), "generated");
-            // 4. Run codegen (or --check) with the selected emitter. Both the TS
-            //    and Swift generators return the same WriteOrCheckResult shape, so
-            //    the reporting below is emitter-agnostic; only the emitter (and the
-            //    regenerate hint) differs. When a single database-type filter
-            //    argument is given, the input set is partial — flag it so stale
-            //    cleanup is scoped to that type and sibling types' generated files
-            //    are left intact.
-            const codegenResult = lang === "swift"
-                ? await generateDbSwiftTypes({
-                    inputs,
-                    outputDir,
-                    check: !!options.check,
-                    singleType: !!databaseType,
-                })
-                : await generateDbTypes({
-                    inputs,
-                    outputDir,
-                    check: !!options.check,
-                    singleType: !!databaseType,
-                });
-            if (options.check) {
-                if (codegenResult.mismatches.length > 0) {
-                    if (options.json) {
-                        json({ ok: false, mismatches: codegenResult.mismatches });
-                    }
-                    else {
-                        error(`Check failed: ${codegenResult.mismatches.length} file(s) out of date.`);
-                        for (const m of codegenResult.mismatches) {
-                            error(`  ${m.reason}: ${path.relative(process.cwd(), m.filePath)}`);
-                        }
-                        // Echo back the options that decide WHERE and WHAT was
-                        // checked, the way `workflows codegen` does (#2895). Suggesting
-                        // a bare `databases codegen` after a `--check -o <dir>` sent
-                        // people to regenerate into the default
-                        // <config-dir>/database-type-configs/generated/ instead of the
-                        // directory that is actually out of date, so the files stayed
-                        // stale and the next check failed the same way (#2911).
-                        const regenerate = ["primitive databases codegen"];
-                        if (databaseType)
-                            regenerate.push(databaseType);
-                        if (lang === "swift")
-                            regenerate.push("--lang swift");
-                        if (options.output)
-                            regenerate.push(`-o ${options.output}`);
-                        info(`Run \`${regenerate.join(" ")}\` to regenerate.`);
-                    }
-                    process.exit(1);
-                }
-                if (options.json) {
-                    json({ ok: true, checked: codegenResult.writtenFiles.length });
-                }
-                else {
-                    success(`Check passed: ${codegenResult.writtenFiles.length} file(s) up to date.`);
-                }
-                return;
-            }
-            if (options.json) {
-                json({
-                    written: codegenResult.writtenFiles,
-                    deleted: codegenResult.deletedFiles,
-                });
-                return;
-            }
-            success(`Generated ${codegenResult.writtenFiles.length} file(s)` +
-                (codegenResult.deletedFiles.length > 0
-                    ? `, deleted ${codegenResult.deletedFiles.length} stale file(s).`
-                    : "."));
-            for (const f of codegenResult.writtenFiles) {
-                keyValue("  wrote", path.relative(process.cwd(), f));
-            }
-            for (const f of codegenResult.deletedFiles) {
-                keyValue("  deleted", path.relative(process.cwd(), f));
-            }
-        }
-        catch (err) {
-            error(err.message);
-            process.exit(1);
-        }
-    });
+}
+/**
+ * Append a scaffolded `[models.*]` schema to a database type file's text,
+ * first stripping the file's existing `[models.*]` blocks when `force` is set.
+ * Appended at the end of the file: #3189 retired the `[[operations]]` blocks
+ * the scaffold used to be inserted ahead of.
+ */
+export function spliceScaffoldedSchema(original, scaffoldedToml, options = {}) {
+    const hasModelsBlock = /\n\[models\./.test("\n" + original);
+    const cleaned = hasModelsBlock && options.force ? stripModelsBlocks(original) : original;
+    const sep = cleaned.endsWith("\n") ? "" : "\n";
+    return cleaned + sep + scaffoldedToml + "\n";
 }
 /** Remove every existing `[models.*]` block from a TOML file body. */
 function stripModelsBlocks(text) {