premanmcp 1.0.3 → 1.0.4

package/bin/shared.js

@@ -482,16 +482,52 @@ export async function callBackendJson(
  * instead" reached a customer as `410 [object Object]` -- a remedy the response
  * carried and the screen never showed.
  */
+/**
+ * A readable reason for a backend failure, always as a string.
+ *
+ * FastAPI answers a rejected request with an object and a validation error with
+ * an array of them, and every caller interpolates what comes back into a line
+ * somebody reads. The nested cases used to be handed back as they arrived --
+ * `detail.message` being itself an object was returned as an object -- so the
+ * line printed "[object Object]", which is the exact failure this function
+ * exists to prevent, reintroduced one level further down.
+ */
 export function describeFailure(result, fallback = "backend error") {
-  const detail = result?.detail ?? result?.message ?? result?.raw;
-  if (typeof detail === "string" && detail) return detail;
-  if (Array.isArray(detail) && detail.length) {
-    return detail.map((item) => item?.msg || JSON.stringify(item)).join("; ");
+  return readDetail(result?.detail ?? result?.message ?? result?.raw) || fallback;
+}
+
+/** The first thing in `detail` a person could read, however deeply it is wrapped. */
+function readDetail(detail, depth = 0) {
+  if (typeof detail === "string") return detail.trim();
+  if (typeof detail === "number" || typeof detail === "boolean") return String(detail);
+  if (Array.isArray(detail)) {
+    return detail
+      .map((item) => readDetail(item, depth + 1))
+      .filter(Boolean)
+      .join("; ");
   }
   if (detail && typeof detail === "object") {
-    return detail.message || detail.error || detail.code || JSON.stringify(detail);
+    // Bounded, because these arrive from somewhere else and a structure that
+    // refers to itself must not take the CLI down on its way to a skip message.
+    if (depth < 3) {
+      for (const key of ["msg", "message", "detail", "error", "description", "code"]) {
+        const nested = readDetail(detail[key], depth + 1);
+        if (nested) return nested;
+      }
+    }
+    try {
+      const json = JSON.stringify(detail);
+      // An empty object describes nothing. Printing "{}" as the reason a push
+      // was skipped is the same unhelpfulness as "[object Object]" in nicer
+      // punctuation; the caller's fallback at least names the kind of failure.
+      return json === "{}" || json === "[]" ? "" : json;
+    } catch {
+      // Circular, or otherwise not describable. The caller's fallback is better
+      // than throwing from the thing that was explaining a failure.
+      return "";
+    }
   }
-  return fallback;
+  return "";
 }
 
 export function assertOk(result, action) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "premanmcp",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "PreMan CLI and stdio proxy for PreMan's hosted MCP server",
   "type": "module",
   "bin": {
@@ -15,7 +15,7 @@
     "test": "npm run build && npm run test:proxy",
     "test:proxy": "node --test scripts/smoke-proxy.mjs",
     "test:connect": "node scripts/smoke-connect.mjs",
-    "test:node": "node --test --test-timeout=90000 scripts/smoke-account.mjs scripts/smoke-cli-entrypoint.mjs scripts/smoke-launcher-config.mjs scripts/smoke-runner.mjs scripts/smoke-repo-config.mjs scripts/smoke-onboard.mjs scripts/smoke-onboard-opening.mjs scripts/smoke-local-detect.mjs scripts/smoke-prepush-hook.mjs scripts/smoke-cli-identity.mjs scripts/smoke-runner-heartbeat.mjs scripts/smoke-verify-prepush.mjs scripts/smoke-push-diff.mjs scripts/smoke-progress-reporter.mjs scripts/smoke-verify-plan.mjs scripts/smoke-install-desktop.mjs scripts/smoke-desktop-session.mjs scripts/smoke-api-tools.mjs scripts/smoke-tests-workbench.mjs scripts/smoke-bin-scope.mjs",
+    "test:node": "node --test --test-timeout=90000 scripts/smoke-account.mjs scripts/smoke-cli-entrypoint.mjs scripts/smoke-launcher-config.mjs scripts/smoke-runner.mjs scripts/smoke-repo-config.mjs scripts/smoke-onboard.mjs scripts/smoke-onboard-opening.mjs scripts/smoke-local-detect.mjs scripts/smoke-prepush-hook.mjs scripts/smoke-cli-identity.mjs scripts/smoke-runner-heartbeat.mjs scripts/smoke-verify-prepush.mjs scripts/smoke-push-diff.mjs scripts/smoke-progress-reporter.mjs scripts/smoke-verify-plan.mjs scripts/smoke-install-desktop.mjs scripts/smoke-desktop-session.mjs scripts/smoke-api-tools.mjs scripts/smoke-tests-workbench.mjs scripts/smoke-bin-scope.mjs scripts/smoke-shared-errors.mjs",
     "test:dmg": "node --test --test-timeout=300000 scripts/smoke-install-desktop-volume.mjs"
   },
   "devDependencies": {