premanmcp 0.16.0 → 0.16.2

package/bin/integrations.js

@@ -273,8 +273,12 @@ export async function githubCommand(args) {
 
   const url = started.install_url || started.url;
   if (!url) throw new Error("Backend returned no GitHub install URL.");
-  present(url, "install the PreMan GitHub App");
-  process.stdout.write("Pick the repositories PreMan may read.\n");
+  // Installing the App is our plumbing and choosing repositories is the
+  // decision, so the decision leads. Naming the save matters more than either:
+  // GitHub's picker reads as a confirmation screen, so people recognise their
+  // repository on it and close the tab without ever granting anything.
+  present(url, "choose the repositories PreMan may read");
+  process.stdout.write("Save the selection on GitHub — that is what connects them.\n");
 
   // The refresh answer is the diagnosis. A 409 means GitHub never called back;
   // a success carrying no repositories means the App is installed and sharing
@@ -366,14 +370,6 @@ export async function slackCommand(args) {
 // The guided run
 // ---------------------------------------------------------------------------
 
-/**
- * "yes" | "no" | "back" -- back only offered once there is somewhere to go.
- *
- * `--yes` takes each step's own default rather than answering yes to all of
- * them, so a step that should not ride in on a keypress can say so. Every step
- * that asks defaults to yes today; the desktop app, which used to be the
- * exception, no longer asks at all.
- */
 /**
  * Ask, once, before PreMan writes into an SDK repository or a docs site.
  *
@@ -387,8 +383,14 @@ export async function slackCommand(args) {
  * which is the whole reason this moved out of the delivery run.
  */
 async function offerReleaseTargets(args, checkout, { assumeYes }) {
+  // SILENT is a step that did not happen rather than one that was skipped: no
+  // heading, and no line in the summary either. A repository with no SDK and no
+  // docs site has nothing to decide here, and saying so is worse than saying
+  // nothing.
+  const SILENT = { state: "skipped", silent: true };
+
   const integrationId = checkout?.match?.integration_id;
-  if (!integrationId) return { state: "skipped" };
+  if (!integrationId) return SILENT;
 
   const token = resolveApiKey(args);
   const path = `/sdk/integrations/${integrationId}/distribution`;
@@ -399,18 +401,19 @@ async function offerReleaseTargets(args, checkout, { assumeYes }) {
     // Detection costs one root listing per repository in the installation. It
     // is the least important thing in this walk and never worth failing setup
     // over.
-    return { state: "skipped" };
+    return SILENT;
   }
 
+  const sdkRepo = detected?.sdk_repo || "";
+  const docsRepo = detected?.docs_repo || "";
+  if (!sdkRepo && !docsRepo) return SILENT;
+
+  banner("Releases");
   if (detected?.confirmed) {
     process.stdout.write(`${MARK.ok()} Release targets already answered.\n`);
     return;
   }
 
-  const sdkRepo = detected?.sdk_repo || "";
-  const docsRepo = detected?.docs_repo || "";
-  if (!sdkRepo && !docsRepo) return { state: "skipped" };
-
   const body = {};
   const decided = [];
   for (const [repo, field, flag, question] of [
@@ -474,6 +477,46 @@ async function askRelease(question, assumeYes) {
   return answer === "y" || answer === "yes";
 }
 
+/**
+ * Put PreMan on screen, signed in as the account this walk just used.
+ *
+ * Returns whether the app is actually up, because that is what decides the last
+ * line of the walk and nothing downstream can work it out.
+ */
+async function showDesktopSignedIn(openDesktopSignedIn, args, creds, stopOpening) {
+  // The same --dest the install honoured, or the launch would look for the app
+  // somewhere it was never copied to.
+  const destination = args.value("--dest", "/Applications");
+  const opened = await openDesktopSignedIn(creds, { destination });
+  stopOpening?.();
+  if (opened.state === "opened-signed-in") {
+    process.stdout.write("Opened PreMan, signed in as this account.\n");
+  } else if (opened.state === "not-installed") {
+    process.stdout.write(
+      `PreMan is not in ${destination} yet \u2014 open it once installed and sign in.\n`
+    );
+  } else {
+    // Either the session could not be handed over or this app is too old to take
+    // it up. Say so rather than let the customer wonder why they are looking at
+    // a login screen.
+    process.stdout.write("Opened PreMan \u2014 sign in with the account you just used.\n");
+  }
+  return opened.state !== "not-installed";
+}
+
+/** One step heading, in the one format the whole walk uses. */
+function banner(name) {
+  process.stdout.write(`\n── ${name} ──\n`);
+}
+
+/**
+ * "yes" | "no" | "back" -- back only offered once there is somewhere to go.
+ *
+ * `--yes` takes each step's own default rather than answering yes to all of
+ * them, so a step that should not ride in on a keypress can say so. Every step
+ * that asks defaults to yes today; the desktop app, which used to be the
+ * exception, no longer asks at all.
+ */
 async function askStep(question, { assumeYes, canGoBack, defaultYes = true }) {
   const fallback = defaultYes ? "yes" : "no";
   if (assumeYes) return fallback;
@@ -599,6 +642,22 @@ export async function onboardCommand(
         process.stdout.write(
           `${checkout.slug} is still not shared. Add it at ${INSTALLATIONS_URL}.\n`
         );
+        // Nothing was connected, so this step did not finish. Returning nothing
+        // marks it done, which is how the walk came to print a tick directly
+        // under a line saying the repository is not shared — and why somebody
+        // would then open the app expecting to find GitHub set up and find
+        // "Continue with GitHub" instead. The sibling branch below already
+        // reports this correctly; this one simply never did.
+        return { state: "skipped" };
+      },
+      onSkip: () => {
+        // The one question in this walk that decides whether a fix from this
+        // code can ever land anywhere. Declining it in silence is how the gap
+        // stays invisible until a fix task finishes and produces nothing.
+        process.stdout.write(
+          `${MARK.skip()} ${checkout.slug} stays disconnected — fixes here cannot open pull requests.\n`
+        );
+        process.stdout.write(`  Run '${cliInvocation()} github' here to change that.\n`);
       },
     });
   } else {
@@ -631,6 +690,10 @@ export async function onboardCommand(
   // inside a delivery run, on a screen most people never opened.
   steps.push({
     name: "Releases",
+    // Prints its own heading, and only once it knows there is a question. A
+    // walk that draws an empty section has told the customer something is
+    // missing when nothing is.
+    ownBanner: true,
     run: () => offerReleaseTargets(args, checkout, { assumeYes }),
   });
 
@@ -678,8 +741,21 @@ export async function onboardCommand(
   if (desktop?.state === "installed") {
     steps.push({
       name: "Desktop app",
-      run: () => {
+      // Nothing to download, which is the point of this branch. It is not a
+      // reason to stop at the sentence: the step exists to leave the customer
+      // looking at PreMan, so the one run with nothing to install was also the
+      // only run that opened nothing, and it closed by sending someone to a
+      // website instead of the app already sitting on their machine.
+      run: async () => {
         process.stdout.write(`${MARK.ok()} PreMan desktop app already installed.\n`);
+        const stopOpening = showOpeningDesktop();
+        try {
+          return {
+            appOpened: await showDesktopSignedIn(openDesktopSignedIn, args, creds, stopOpening),
+          };
+        } finally {
+          stopOpening();
+        }
       },
     });
   } else if (!desktop) {
@@ -707,26 +783,15 @@ export async function onboardCommand(
                 return installed;
               }
               stopOpening ??= showOpeningDesktop();
-              // The same --dest the install honoured, or the launch would look
-              // for the app somewhere it was never copied to.
-              const destination = args.value("--dest", "/Applications");
-              const opened = await openDesktopSignedIn(creds, { destination });
-              stopOpening();
-              if (opened.state === "opened-signed-in") {
-                process.stdout.write("Opened PreMan, signed in as this account.\n");
-              } else if (opened.state === "not-installed") {
-                process.stdout.write(
-                  `PreMan is not in ${destination} yet \u2014 open it once installed and sign in.\n`
-                );
-              } else {
-                // Either the session could not be handed over or this app is too
-                // old to take it up. Say so rather than let the customer wonder
-                // why they are looking at a login screen.
-                process.stdout.write("Opened PreMan \u2014 sign in with the account you just used.\n");
-              }
-              // Whether the app is on screen decides what the last line of the walk
-              // should say, and only this closure knows.
-              return { ...installed, appOpened: opened.state !== "not-installed" };
+              return {
+                ...installed,
+                appOpened: await showDesktopSignedIn(
+                  openDesktopSignedIn,
+                  args,
+                  creds,
+                  stopOpening
+                ),
+              };
             } finally {
               stopOpening?.();
             }
@@ -745,7 +810,7 @@ export async function onboardCommand(
   let i = 0;
   while (i < steps.length) {
     const step = steps[i];
-    process.stdout.write(`\n── ${step.name} ──\n`);
+    if (!step.ownBanner) banner(step.name);
 
     if (step.question) {
       // "back" goes to the last step that asked something, not simply to the
@@ -784,6 +849,13 @@ export async function onboardCommand(
       // at the end of a successful install: the install reports state "installed",
       // which is none of the three, so it printed as a failure with no detail.
       const reported = await step.run();
+      // A step that never announced itself does not belong in the summary
+      // either: a line reading "(skipped)" for work nobody was offered reads as
+      // something having gone wrong.
+      if (reported?.silent) {
+        i += 1;
+        continue;
+      }
       const state =
         { failed: "failed", skipped: "skipped", unsupported: "skipped" }[reported?.state] ||
         "done";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "premanmcp",
-  "version": "0.16.0",
+  "version": "0.16.2",
   "description": "Turn APIs into agent-callable MCP tools with auth, testing, and audit logs",
   "type": "module",
   "bin": {