premanmcp 0.12.0 → 0.13.0

package/bin/desktop.js

@@ -13,7 +13,16 @@
 
 import { spawn, spawnSync } from "node:child_process";
 import { createHash } from "node:crypto";
-import { chmodSync, existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import {
+  chmodSync,
+  existsSync,
+  mkdirSync,
+  mkdtempSync,
+  readFileSync,
+  readdirSync,
+  rmSync,
+  writeFileSync,
+} from "node:fs";
 import os from "node:os";
 import path from "node:path";
 
@@ -76,16 +85,36 @@ export function writeDesktopSession(creds) {
  *
  * The session is written before the app is launched so a cold start finds it on
  * first read, rather than racing a window that is already loading.
+ *
+ * Whether it was taken up is then waited for rather than assumed: the app
+ * deletes the file as it reads it, and an app too old to know about the file at
+ * all would otherwise be reported as signed in while the customer looks at a
+ * login screen. The file is left behind on timeout -- it expires on its own, and
+ * a slow first launch can still find it.
  */
-export function openDesktopSignedIn(creds, { destination = "/Applications" } = {}) {
+export async function openDesktopSignedIn(
+  creds,
+  { destination = "/Applications", waitMs = 12_000, sleep = defaultSleep } = {}
+) {
   if (!desktopAppInstalled(destination)) {
     return { state: "not-installed" };
   }
   const handoff = writeDesktopSession(creds);
   spawn("open", ["-a", "PreMan"], { stdio: "ignore", detached: true }).unref();
-  return { state: handoff.state === "written" ? "opened-signed-in" : "opened", handoff: handoff.state };
+  if (handoff.state !== "written") return { state: "opened", handoff: handoff.state };
+
+  const deadline = Date.now() + waitMs;
+  while (Date.now() < deadline) {
+    await sleep(500);
+    if (!existsSync(DESKTOP_SESSION_FILE)) {
+      return { state: "opened-signed-in", handoff: handoff.state };
+    }
+  }
+  return { state: "opened-not-adopted", handoff: handoff.state };
 }
 
+const defaultSleep = (ms) => new Promise((resolve) => setTimeout(resolve, ms));
+
 /**
  * Open a Playground session URL in PreMan.app on macOS when it is installed.
  * Windows/Linux (and Mac without the app) get the website URL printed instead.
@@ -212,6 +241,34 @@ function mountedVolume(hdiutilOutput) {
   return match[1].trim();
 }
 
+/**
+ * Attach the disk image somewhere we named, rather than wherever it landed.
+ *
+ * Asking for the mountpoint is what makes this unambiguous. Reading it back out
+ * of `hdiutil info` is not a substitute: that lists every image attached on the
+ * machine, so an unrelated volume -- an iOS restore image, someone else's dmg --
+ * could be searched for PreMan.app instead of the download.
+ */
+function attachDiskImage(dmgPath, mountPoint) {
+  mkdirSync(mountPoint, { recursive: true });
+  try {
+    run("hdiutil", ["attach", dmgPath, "-nobrowse", "-quiet", "-readonly", "-mountpoint", mountPoint]);
+    return mountPoint;
+  } catch {
+    // Images that refuse an explicit mountpoint still report where they went, so
+    // fall back to this attach's own output -- never to the global image list.
+    return mountedVolume(run("hdiutil", ["attach", dmgPath, "-nobrowse", "-readonly"]));
+  }
+}
+
+/** The bundle to copy out, found by name and then by extension. */
+function appInsideVolume(volume) {
+  const named = path.join(volume, APP_NAME);
+  if (existsSync(named)) return named;
+  const bundle = readdirSync(volume).find((entry) => entry.endsWith(".app"));
+  return bundle ? path.join(volume, bundle) : null;
+}
+
 export async function installDesktopCommand(commandArgs = []) {
   const args = makeArgs(commandArgs);
 
@@ -266,12 +323,11 @@ export async function installDesktopCommand(commandArgs = []) {
       process.stdout.write("  checksum unavailable for this release; skipping verification\n");
     }
 
-    const attach = run("hdiutil", ["attach", dmgPath, "-nobrowse", "-quiet", "-readonly"]);
-    mounted = mountedVolume(attach || run("hdiutil", ["info"]));
+    mounted = attachDiskImage(dmgPath, path.join(workDir, "mnt"));
 
-    const source = path.join(mounted, APP_NAME);
-    if (!existsSync(source)) {
-      throw new Error(`${APP_NAME} not found inside the disk image at ${mounted}`);
+    const source = appInsideVolume(mounted);
+    if (!source) {
+      throw new Error(`no application bundle found inside the disk image at ${mounted}`);
     }
     const target = path.join(destination, APP_NAME);
     if (existsSync(target)) rmSync(target, { recursive: true, force: true });

package/bin/integrations.js

@@ -379,7 +379,8 @@ export async function onboardCommand(
           process.stdout.write("Sign in there with the account you just used.\n");
           return;
         }
-        const opened = openDesktopSignedIn(creds);
+        process.stdout.write("Opening PreMan\u2026\n");
+        const opened = await openDesktopSignedIn(creds);
         if (opened.state === "opened-signed-in") {
           process.stdout.write("Opened PreMan, signed in as this account.\n");
         } else if (opened.state === "not-installed") {
@@ -387,25 +388,24 @@ export async function onboardCommand(
             "PreMan is not in /Applications yet \u2014 open it once installed and sign in.\n"
           );
         } else {
-          // The app is there but the session could not be handed over, so say so
-          // rather than let the customer wonder why they are at a login screen.
+          // Either the session could not be handed over or this app is too old to
+          // take it up. Say so rather than let the customer wonder why they are
+          // looking at a login screen.
           process.stdout.write("Opened PreMan \u2014 sign in with the account you just used.\n");
         }
       },
     },
-    { name: "GitHub", question: "Connect GitHub?", run: () => githubCommand(args) },
-    { name: "AWS logs", question: "Connect AWS?", run: () => awsCommand(args) },
-    { name: "Slack", question: "Connect Slack?", run: () => slackCommand(args) },
+    // GitHub, AWS and Slack are deliberately not here. Starting out is an account
+    // and the app; each integration is its own command for whenever it is wanted.
   ];
 
   // Outcome per step rather than three lists, so revisiting a step replaces its
   // result instead of recording it twice.
   const outcome = new Map();
 
-  // Indexed rather than for..of so "back" can move the cursor. Re-running a
-  // step is safe: every one of these is idempotent on the backend -- an AWS
-  // grant returns the existing link, and an App install that already happened
-  // is detected rather than duplicated.
+  // Indexed rather than for..of so "back" can move the cursor. Re-running a step
+  // is safe: an install that already happened overwrites the same bundle rather
+  // than duplicating it.
   let i = 0;
   while (i < steps.length) {
     const step = steps[i];
@@ -451,9 +451,8 @@ export async function onboardCommand(
 
 export const INTEGRATIONS_HELP = `
 Setup options:
-  preman onboard              Create or sign in to an account, install the
-                              PreMan app signed in, then GitHub, AWS and Slack,
-                              one prompt per step
+  preman onboard              Create or sign in to an account, then install the
+                              PreMan app and open it signed in
   preman aws                  Connect an AWS account and stream a log group
   preman github               Install the PreMan GitHub App
   preman slack                Add PreMan to a Slack workspace

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "premanmcp",
-  "version": "0.12.0",
+  "version": "0.13.0",
   "description": "Turn APIs into agent-callable MCP tools with auth, testing, and audit logs",
   "type": "module",
   "bin": {
@@ -13,9 +13,10 @@
     "dev": "tsx src/server.ts",
     "open-mcp-preview": "node scripts/emit-mcp-preview.mjs",
     "open-mcp-preview-in-cursor": "node scripts/open-cursor-preview.mjs",
-    "test": "npm run build && npm run test:connect && npm run test:node",
+    "test": "npm run build && npm run test:connect && npm run test:node && npm run test:dmg",
     "test:connect": "node scripts/smoke-connect.mjs",
-    "test:node": "node --test --test-timeout=90000 scripts/smoke-account.mjs scripts/smoke-cli-entrypoint.mjs scripts/smoke-launcher-config.mjs scripts/smoke-runner.mjs scripts/smoke-repo-config.mjs scripts/smoke-onboard.mjs scripts/smoke-local-detect.mjs scripts/smoke-prepush-hook.mjs scripts/smoke-cli-identity.mjs scripts/smoke-runner-heartbeat.mjs scripts/smoke-verify-prepush.mjs scripts/smoke-push-diff.mjs scripts/smoke-progress-reporter.mjs scripts/smoke-verify-plan.mjs scripts/smoke-install-desktop.mjs scripts/smoke-desktop-session.mjs scripts/smoke-api-tools.mjs scripts/smoke-tests-workbench.mjs scripts/smoke-bin-scope.mjs"
+    "test:node": "node --test --test-timeout=90000 scripts/smoke-account.mjs scripts/smoke-cli-entrypoint.mjs scripts/smoke-launcher-config.mjs scripts/smoke-runner.mjs scripts/smoke-repo-config.mjs scripts/smoke-onboard.mjs scripts/smoke-local-detect.mjs scripts/smoke-prepush-hook.mjs scripts/smoke-cli-identity.mjs scripts/smoke-runner-heartbeat.mjs scripts/smoke-verify-prepush.mjs scripts/smoke-push-diff.mjs scripts/smoke-progress-reporter.mjs scripts/smoke-verify-plan.mjs scripts/smoke-install-desktop.mjs scripts/smoke-desktop-session.mjs scripts/smoke-api-tools.mjs scripts/smoke-tests-workbench.mjs scripts/smoke-bin-scope.mjs",
+    "test:dmg": "node --test --test-timeout=300000 scripts/smoke-install-desktop-volume.mjs"
   },
   "dependencies": {
     "@modelcontextprotocol/ext-apps": "^0.1.0",