prebid.js 9.53.2 → 9.53.3

package/test/spec/activities/objectGuard_spec.js

@@ -1,4 +1,5 @@
 import {objectGuard, writeProtectRule} from '../../../libraries/objectGuard/objectGuard.js';
+import {redactRule} from '../../../src/activities/redactor.js';
 
 describe('objectGuard', () => {
   describe('read rule', () => {
@@ -13,7 +14,7 @@ describe('objectGuard', () => {
       }
     })
     it('can prevent top level read access', () => {
-      const {obj} = objectGuard([rule])({'foo': 1, 'other': 2});
+      const obj = objectGuard([rule])({'foo': 1, 'other': 2});
       expect(obj).to.eql({
         foo: 'repl1',
         other: 2
@@ -21,20 +22,27 @@ describe('objectGuard', () => {
     });
 
     it('does not choke if a guarded property is missing', () => {
-      const {obj} = objectGuard([rule])({});
+      const obj = objectGuard([rule])({});
       expect(obj.foo).to.not.exist;
     });
 
+    it('allows concurrent reads', () => {
+      const obj = {'foo': 'bar'};
+      const guarded = objectGuard([rule])(obj);
+      obj.foo = 'baz';
+      expect(guarded.foo).to.eql('replbaz');
+    })
+
     it('does not prevent access if applies returns false', () => {
       applies = false;
-      const {obj} = objectGuard([rule])({foo: 1});
+      const obj = objectGuard([rule])({foo: 1});
       expect(obj).to.eql({
         foo: 1
       });
     })
 
     it('can prevent nested property access', () => {
-      const {obj} = objectGuard([rule])({
+      const obj = objectGuard([rule])({
         other: 0,
         outer: {
           foo: 1,
@@ -60,6 +68,11 @@ describe('objectGuard', () => {
       })
     });
 
+    it('prevents nested property access when a parent property is protected', () => {
+      const guard = objectGuard([rule])({foo: {inner: 'value'}});
+      expect(guard.inner?.value).to.not.exist;
+    })
+
     it('does not call applies more than once', () => {
       JSON.stringify(objectGuard([rule])({
         foo: 0,
@@ -68,7 +81,7 @@ describe('objectGuard', () => {
             foo: 1
           }
         }
-      }).obj);
+      }));
       expect(rule.applies.callCount).to.equal(1);
     })
   });
@@ -84,35 +97,60 @@ describe('objectGuard', () => {
       });
     });
 
-    it('should undo top-level writes', () => {
+    it('does not mess up array reads', () => {
+      const guard = objectGuard([rule])({foo: [{bar: 'baz'}]});
+      expect(guard.foo).to.eql([{bar: 'baz'}]);
+    })
+
+    it('prevents array modification', () => {
+      const obj = {foo: ['value']};
+      const guard = objectGuard([rule])(obj);
+      guard.foo.pop();
+      guard.foo.push('test');
+      expect(obj.foo).to.eql(['value']);
+    })
+
+    it('allows array modification when not applicable', () => {
+      applies = false;
+      const obj = {foo: ['value']};
+      const guard = objectGuard([rule])(obj);
+      guard.foo.pop();
+      guard.foo.push('test');
+      expect(obj.foo).to.eql(['test']);
+    })
+
+    it('should prevent top-level writes', () => {
       const obj = {bar: {nested: 'val'}, other: 'val'};
       const guard = objectGuard([rule])(obj);
-      guard.obj.foo = 'denied';
-      guard.obj.bar.nested = 'denied';
-      guard.obj.bar.other = 'denied';
-      guard.obj.other = 'allowed';
-      guard.verify();
-      expect(obj).to.eql({bar: {nested: 'val'}, other: 'allowed'});
+      guard.foo = 'denied';
+      guard.bar.nested = 'denied';
+      guard.bar.other = 'denied';
+      guard.other = 'allowed';
+      expect(guard).to.eql({bar: {nested: 'val'}, other: 'allowed'});
     });
 
-    it('should undo top-level deletes', () => {
+    it('should not prevent no-op writes', () => {
+      const guard = objectGuard([rule])({foo: {some: 'value'}});
+      guard.foo = {some: 'value'};
+      sinon.assert.notCalled(rule.applies);
+    })
+
+    it('should prevent top-level deletes', () => {
       const obj = {foo: {nested: 'val'}, bar: 'val'};
       const guard = objectGuard([rule])(obj);
-      delete guard.obj.foo.nested;
-      delete guard.obj.bar;
-      guard.verify();
-      expect(obj).to.eql({foo: {nested: 'val'}, bar: 'val'});
+      delete guard.foo.nested;
+      delete guard.bar;
+      expect(guard).to.eql({foo: {nested: 'val'}, bar: 'val'});
     })
 
-    it('should undo nested writes', () => {
+    it('should prevent nested writes', () => {
       const obj = {outer: {inner: {bar: {nested: 'val'}, other: 'val'}}};
       const guard = objectGuard([rule])(obj);
-      guard.obj.outer.inner.bar.other = 'denied';
-      guard.obj.outer.inner.bar.nested = 'denied';
-      guard.obj.outer.inner.foo = 'denied';
-      guard.obj.outer.inner.other = 'allowed';
-      guard.verify();
-      expect(obj).to.eql({
+      guard.outer.inner.bar.other = 'denied';
+      guard.outer.inner.bar.nested = 'denied';
+      guard.outer.inner.foo = 'denied';
+      guard.outer.inner.other = 'allowed';
+      expect(guard).to.eql({
         outer: {
           inner: {
             bar: {
@@ -124,21 +162,107 @@ describe('objectGuard', () => {
       })
     });
 
-    it('should undo nested deletes', () => {
+    it('should prevent writes if upper levels are protected', () => {
+      const obj = {foo: {inner: {}}};
+      const guard = objectGuard([rule])(obj);
+      guard.foo.inner.prop = 'value';
+      expect(obj).to.eql({foo: {inner: {}}});
+    })
+
+    it('should prevent deletes if a higher level property is protected', () => {
+      const obj = {foo: {inner: {prop: 'value'}}};
+      const guard = objectGuard([rule])(obj);
+      delete guard.foo.inner.prop;
+      expect(obj).to.eql({foo: {inner: {prop: 'value'}}});
+    })
+
+    it('should clean up top-level writes that would result in inner properties changing', () => {
+      const guard = objectGuard([rule])({outer: {inner: {bar: 'baz'}}});
+      guard.outer = {inner: {bar: 'baz', foo: 'baz', prop: 'allowed'}};
+      expect(guard).to.eql({outer: {inner: {bar: 'baz', prop: 'allowed'}}});
+    })
+
+    it('should not prevent writes that are not protected', () => {
+      const obj = {};
+      const guard = objectGuard([rule])(obj);
+      guard.outer = {
+        test: 'value'
+      }
+      expect(obj.outer.test).to.eql('value');
+    })
+
+    it('should not choke on type mismatch: overwrite object with scalar', () => {
+      const obj = {outer: {inner: {}}};
+      const guard = objectGuard([rule])(obj);
+      guard.outer = null;
+      expect(obj).to.eql({outer: {inner: {}}});
+    });
+
+    it('should not choke on type mismatch: overwrite scalar with object', () => {
+      const obj = {outer: null};
+      const guard = objectGuard([rule])(obj);
+      guard.outer = {inner: {bar: 'denied', other: 'allowed'}};
+      expect(obj).to.eql({outer: {inner: {other: 'allowed'}}});
+    })
+
+    it('should prevent nested deletes', () => {
       const obj = {outer: {inner: {foo: {nested: 'val'}, bar: 'val'}}};
       const guard = objectGuard([rule])(obj);
-      delete guard.obj.outer.inner.foo.nested;
-      delete guard.obj.outer.inner.bar;
-      guard.verify();
-      expect(obj).to.eql({outer: {inner: {foo: {nested: 'val'}, bar: 'val'}}})
+      delete guard.outer.inner.foo.nested;
+      delete guard.outer.inner.bar;
+      expect(guard).to.eql({outer: {inner: {foo: {nested: 'val'}, bar: 'val'}}})
     });
 
+    it('should prevent higher level deletes that would result in inner properties changing', () => {
+      const guard = objectGuard([rule])({outer: {inner: {bar: 'baz'}}});
+      delete guard.outer.inner;
+      expect(guard).to.eql({outer: {inner: {bar: 'baz'}}});
+    })
+
     it('should work on null properties', () => {
       const obj = {foo: null};
       const guard = objectGuard([rule])(obj);
-      guard.obj.foo = 'denied';
-      guard.verify();
-      expect(obj).to.eql({foo: null});
+      guard.foo = 'denied';
+      expect(guard).to.eql({foo: null});
     });
   });
+  describe('multiple rules on the same path', () => {
+    it('should each be checked for redacts', () => {
+      const obj = objectGuard([
+        redactRule({
+          paths: ['foo'],
+          applies: () => true,
+          get(val) {
+            return '1' + val;
+          }
+        }),
+        redactRule({
+          paths: ['foo'],
+          applies: () => true,
+          get(val) {
+            return '2' + val;
+          }
+        })
+      ])({foo: 'bar'});
+      expect(obj.foo).to.eql('21bar');
+    });
+
+    it('can apply both redact and write protect', () => {
+      const obj = objectGuard([
+        redactRule({
+          paths: ['foo'],
+          applies: () => true,
+          get(val) {
+            return 'redact' + val;
+          },
+        }),
+        writeProtectRule({
+          paths: ['foo'],
+          applies: () => true,
+        })
+      ])({foo: 'bar'});
+      obj.foo = 'baz';
+      expect(obj.foo).to.eql('redactbar');
+    });
+  })
 });

package/test/spec/activities/ortbGuard_spec.js

@@ -45,7 +45,7 @@ describe('ortb2Guard', () => {
 
   function testPropertiesAreProtected(properties, allowed) {
     properties.forEach(prop => {
-      it(`should ${allowed ? 'keep' : 'undo'} additions to ${prop}`, () => {
+      it(`should ${allowed ? 'keep' : 'prevent'} additions to ${prop}`, () => {
         const orig = [{n: 'orig'}];
         const ortb2 = {};
         deepSetValue(ortb2, prop, deepClone(orig));
@@ -53,8 +53,7 @@ describe('ortb2Guard', () => {
         const mod = {};
         const insert = [{n: 'new'}];
         deepSetValue(mod, prop, insert);
-        mergeDeep(guard.obj, mod);
-        guard.verify();
+        mergeDeep(guard, mod);
         const actual = deepAccess(ortb2, prop);
         if (allowed) {
           expect(actual).to.eql(orig.concat(insert))
@@ -63,13 +62,12 @@ describe('ortb2Guard', () => {
         }
       });
 
-      it(`should ${allowed ? 'keep' : 'undo'} modifications to ${prop}`, () => {
+      it(`should ${allowed ? 'keep' : 'prevent'} modifications to ${prop}`, () => {
         const orig = [{n: 'orig'}];
         const ortb2 = {};
         deepSetValue(ortb2, prop, orig);
         const guard = ortb2Guard(ortb2, activityParams(MOD_TYPE, MOD_NAME));
-        deepSetValue(guard.obj, `${prop}.0.n`, 'new');
-        guard.verify();
+        deepSetValue(guard, `${prop}.0.n`, 'new');
         const actual = deepAccess(ortb2, prop);
         if (allowed) {
           expect(actual).to.eql([{n: 'new'}]);
@@ -102,19 +100,18 @@ describe('ortb2FragmentsGuard', () => {
     guardFragments = ortb2FragmentsGuardFactory(testGuard);
   });
 
-  it('should undo changes to global FPD', () => {
+  it('should prevent changes to global FPD', () => {
     const fragments = {
       global: {
         foo: {inner: 'val'}
       }
     }
     const guard = guardFragments(fragments);
-    guard.obj.global.foo = 'other';
-    guard.verify();
+    guard.global.foo = 'other';
     expect(fragments.global.foo).to.eql({inner: 'val'});
   });
 
-  it('should undo changes to bidder FPD', () => {
+  it('should prevent changes to bidder FPD', () => {
     const fragments = {
       bidder: {
         A: {
@@ -123,18 +120,16 @@ describe('ortb2FragmentsGuard', () => {
       }
     };
     const guard = guardFragments(fragments);
-    guard.obj.bidder.A.foo = 'denied';
-    guard.verify();
+    guard.bidder.A.foo = 'denied';
     expect(fragments.bidder.A).to.eql({foo: 'val'});
   });
 
-  it('should undo changes to bidder FPD that was not initially there', () => {
+  it('should prevent changes to bidder FPD that was not initially there', () => {
     const fragments = {
       bidder: {}
     };
     const guard = guardFragments(fragments);
-    guard.obj.bidder.A = {foo: 'denied', other: 'allowed'};
-    guard.verify();
+    guard.bidder.A = {foo: 'denied', other: 'allowed'};
     expect(fragments.bidder.A).to.eql({other: 'allowed'});
   });
 })

package/test/spec/modules/adagioAnalyticsAdapter_spec.js

@@ -4,6 +4,7 @@ import adagioAnalyticsAdapter, { _internal } from 'modules/adagioAnalyticsAdapte
 import { EVENTS } from 'src/constants.js';
 import { expect } from 'chai';
 import { server } from 'test/mocks/xhr.js';
+import { deepClone } from 'src/utils.js';
 
 let adapterManager = require('src/adapterManager').default;
 let events = require('src/events');
@@ -191,8 +192,10 @@ const BID_CACHED = Object.assign({}, BID_ADAGIO, {
   latestTargetedAuctionId: BID_ADAGIO.auctionId,
 });
 
+const PARAMS_PLCMT = 'placement_from_params';
 const PARAMS_ADG = {
   environment: 'desktop',
+  placement: PARAMS_PLCMT,
 };
 
 const ORTB_DATA = {
@@ -208,6 +211,13 @@ const ADG_RTD = {
   }
 };
 
+const ORTB2IMP_PLCMT = 'placement_from_ortb2imp';
+const ORTB2IMP_DATA_ADG = {
+  'adg_rtd': {
+    'placement': ORTB2IMP_PLCMT
+  }
+};
+
 const AUCTION_INIT_ANOTHER = {
   'auctionId': AUCTION_ID,
   'timestamp': 1519767010567,
@@ -228,6 +238,11 @@ const AUCTION_INIT_ANOTHER = {
         ]
       }
     },
+    'ortb2Imp': {
+      'ext': {
+        'data': ORTB2IMP_DATA_ADG
+      }
+    },
     'sizes': [[640, 480]],
     'bids': [ {
       'bidder': 'another',
@@ -250,14 +265,7 @@ const AUCTION_INIT_ANOTHER = {
         'publisherId': '1001'
       },
     }, ],
-    'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014',
-    'ortb2Imp': {
-      'ext': {
-        'data': {
-          'placement': 'pave_top',
-        }
-      }
-    },
+    'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014'
   }, {
     'code': '/19968336/footer-bid-tag-1',
     'mediaTypes': {
@@ -281,7 +289,9 @@ const AUCTION_INIT_ANOTHER = {
     'ortb2Imp': {
       'ext': {
         'data': {
-          'placement': 'pave_top',
+          'adg_rtd': {
+            'placement': 'footer'
+          }
         }
       }
     },
@@ -303,6 +313,11 @@ const AUCTION_INIT_ANOTHER = {
               'sizes': [[640, 480]]
             }
           },
+          'ortb2Imp': {
+            'ext': {
+              'data': ORTB2IMP_DATA_ADG
+            }
+          },
           'adUnitCode': '/19968336/header-bid-tag-1',
           'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014',
           'sizes': [[640, 480]],
@@ -363,6 +378,12 @@ const AUCTION_INIT_ANOTHER = {
             'sizes': [[640, 480]]
           }
         },
+
+        'ortb2Imp': {
+          'ext': {
+            'data': ORTB2IMP_DATA_ADG
+          }
+        },
         'adUnitCode': '/19968336/header-bid-tag-1',
         'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014',
         'sizes': [[640, 480]],
@@ -405,6 +426,11 @@ const AUCTION_INIT_ANOTHER = {
               'sizes': [[640, 480]]
             }
           },
+          'ortb2Imp': {
+            'ext': {
+              'data': ORTB2IMP_DATA_ADG
+            }
+          },
           'adUnitCode': '/19968336/header-bid-tag-1',
           'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014',
           'sizes': [[640, 480]],
@@ -453,7 +479,12 @@ const AUCTION_INIT_ANOTHER = {
         'bidderRequestId': '1be65d7958826a',
         'auctionId': AUCTION_ID,
         'src': 'client',
-        'bidRequestsCount': 1
+        'bidRequestsCount': 1,
+        'ortb2Imp': {
+          'ext': {
+            'data': ORTB2IMP_DATA_ADG
+          }
+        },
       }
       ],
       'timeout': 3000,
@@ -514,9 +545,7 @@ const AUCTION_INIT_CACHE = {
     'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014',
     'ortb2Imp': {
       'ext': {
-        'data': {
-          'placement': 'pave_top',
-        }
+        'data': ORTB2IMP_DATA_ADG
       }
     },
   }, {
@@ -539,13 +568,6 @@ const AUCTION_INIT_CACHE = {
       },
     } ],
     'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014',
-    'ortb2Imp': {
-      'ext': {
-        'data': {
-          'placement': 'pave_top',
-        }
-      }
-    },
   } ],
   'adUnitCodes': ['/19968336/header-bid-tag-1', '/19968336/footer-bid-tag-1'],
   'bidderRequests': [ {
@@ -562,6 +584,11 @@ const AUCTION_INIT_CACHE = {
           'sizes': [[640, 480]]
         }
       },
+      'ortb2Imp': {
+        'ext': {
+          'data': ORTB2IMP_DATA_ADG
+        }
+      },
       'adUnitCode': '/19968336/header-bid-tag-1',
       'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014',
       'sizes': [[640, 480]],
@@ -621,6 +648,11 @@ const AUCTION_INIT_CACHE = {
           'sizes': [[640, 480]]
         }
       },
+      'ortb2Imp': {
+        'ext': {
+          'data': ORTB2IMP_DATA_ADG
+        }
+      },
       'adUnitCode': '/19968336/header-bid-tag-1',
       'transactionId': 'ca4af27a-6d02-4f90-949d-d5541fa12014',
       'sizes': [[640, 480]],
@@ -818,7 +850,7 @@ describe('adagio analytics adapter', () => {
         expect(search.pv_id).to.equal('a68e6d70-213b-496c-be0a-c468ff387106');
         expect(search.url_dmn).to.equal(window.location.hostname);
         expect(search.pgtyp).to.equal('article');
-        expect(search.plcmt).to.equal('pave_top');
+        expect(search.plcmt).to.equal(ORTB2IMP_PLCMT);
         expect(search.mts).to.equal('ban');
         expect(search.ban_szs).to.equal('640x100,640x480');
         expect(search.bdrs).to.equal('adagio,another,anotherWithAlias,nobid');
@@ -869,6 +901,7 @@ describe('adagio analytics adapter', () => {
         expect(search.auct_id).to.equal(RTD_AUCTION_ID);
         expect(search.adu_code).to.equal('/19968336/header-bid-tag-1');
         expect(search.win_bdr).to.equal('another');
+        expect(search.plcmt).to.equal(ORTB2IMP_PLCMT);
         expect(search.win_mt).to.equal('ban');
         expect(search.win_ban_sz).to.equal('728x90');
         expect(search.win_net_cpm).to.equal('2.052');
@@ -877,6 +910,43 @@ describe('adagio analytics adapter', () => {
       }
     });
 
+    it('it fallback on the adUnit.params.placement value if adg_rtd.placement is not set', () => {
+      const mockAuctionInit = deepClone(MOCK.AUCTION_INIT.another);
+      for (const adUnit of mockAuctionInit.adUnits) {
+        delete adUnit.ortb2Imp?.ext?.data.adg_rtd;
+      }
+      for (const bidRequest of mockAuctionInit.bidderRequests) {
+        for (const bid of bidRequest.bids) {
+          delete bid.ortb2Imp?.ext?.data.adg_rtd;
+        }
+      }
+
+      events.emit(EVENTS.AUCTION_INIT, mockAuctionInit);
+      {
+        const { protocol, hostname, pathname, search } = utils.parseUrl(server.requests[0].url);
+        expect(protocol).to.equal('https');
+        expect(hostname).to.equal('c.4dex.io');
+        expect(pathname).to.equal('/pba.gif');
+        expect(search.v).to.equal('1');
+        expect(search.pbjsv).to.equal('$prebid.version$');
+        expect(search.s_id).to.equal(SESSION_ID);
+        expect(search.auct_id).to.equal(RTD_AUCTION_ID);
+        expect(search.adu_code).to.equal('/19968336/header-bid-tag-1');
+        expect(search.org_id).to.equal('1001');
+        expect(search.site).to.equal('test-com');
+        expect(search.pv_id).to.equal('a68e6d70-213b-496c-be0a-c468ff387106');
+        expect(search.url_dmn).to.equal(window.location.hostname);
+        expect(search.pgtyp).to.equal('article');
+        expect(search.plcmt).to.equal(PARAMS_PLCMT);
+        expect(search.mts).to.equal('ban');
+        expect(search.ban_szs).to.equal('640x100,640x480');
+        expect(search.bdrs).to.equal('adagio,another,anotherWithAlias,nobid');
+        expect(search.bdrs_code).to.equal('adagio,another,another,nobid');
+        expect(search.bdrs_timeout).to.not.exist;
+        expect(search.adg_mts).to.equal('ban');
+      }
+    });
+
     it('builds and sends auction data with a cached bid win', () => {
       events.emit(EVENTS.AUCTION_INIT, MOCK.AUCTION_INIT.bidcached);
       events.emit(EVENTS.AUCTION_INIT, MOCK.AUCTION_INIT.another);
@@ -903,7 +973,7 @@ describe('adagio analytics adapter', () => {
         expect(search.pv_id).to.equal('a68e6d70-213b-496c-be0a-c468ff387106');
         expect(search.url_dmn).to.equal(window.location.hostname);
         expect(search.pgtyp).to.equal('article');
-        expect(search.plcmt).to.equal('pave_top');
+        expect(search.plcmt).to.equal(ORTB2IMP_PLCMT);
         expect(search.mts).to.equal('ban');
         expect(search.ban_szs).to.equal('640x100,640x480');
         expect(search.bdrs).to.equal('adagio,another');
@@ -928,7 +998,7 @@ describe('adagio analytics adapter', () => {
         expect(search.pv_id).to.equal('a68e6d70-213b-496c-be0a-c468ff387106');
         expect(search.url_dmn).to.equal(window.location.hostname);
         expect(search.pgtyp).to.equal('article');
-        expect(search.plcmt).to.equal('pave_top');
+        expect(search.plcmt).to.be.undefined; // no placement set, no adagio bidder for this adUnit.
         expect(search.mts).to.equal('ban');
         expect(search.ban_szs).to.equal('640x480');
         expect(search.bdrs).to.equal('another');
@@ -951,7 +1021,7 @@ describe('adagio analytics adapter', () => {
         expect(search.pv_id).to.equal('a68e6d70-213b-496c-be0a-c468ff387106');
         expect(search.url_dmn).to.equal(window.location.hostname);
         expect(search.pgtyp).to.equal('article');
-        expect(search.plcmt).to.equal('pave_top');
+        expect(search.plcmt).to.equal(ORTB2IMP_PLCMT);
         expect(search.mts).to.equal('ban');
         expect(search.ban_szs).to.equal('640x100,640x480');
         expect(search.bdrs).to.equal('adagio,another,anotherWithAlias,nobid');

package/test/spec/modules/adagioRtdProvider_spec.js

@@ -507,7 +507,7 @@ describe('Adagio Rtd Provider', function () {
       expect(ortb2ImpExt.adunit_position).equal('');
     });
 
-    describe('update the ortb2Imp.ext.data.placement if not present', function() {
+    describe('set the ortb2Imp.ext.data.adg_rtd.placement', function() {
       const config = {
         name: SUBMODULE_NAME,
         params: {
@@ -516,50 +516,50 @@ describe('Adagio Rtd Provider', function () {
         }
       };
 
-      it('update the placement value with the adUnit.code value', function() {
+      it('set the adg_rtd.placement value from the adUnit[].bids adagio.params.placement value', function() {
+        const placement = 'placement-value';
+
         const configCopy = utils.deepClone(config);
-        configCopy.params.placementSource = PLACEMENT_SOURCES.ADUNITCODE;
 
         const bidRequest = utils.deepClone(bidReqConfig);
+        bidRequest.adUnits[0].bids[0].params.placement = placement;
 
         adagioRtdSubmodule.getBidRequestData(bidRequest, cb, configCopy);
         expect(bidRequest.adUnits[0]).to.have.property('ortb2Imp');
-        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.placement).to.equal('div-gpt-ad-1460505748561-0');
+        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.adg_rtd.placement).to.equal(placement);
       });
 
-      it('update the placement value with the gpid value', function() {
+      it('fallback on the adUnit.code value to set the adg_rtd.placement value', function() {
         const configCopy = utils.deepClone(config);
-        configCopy.params.placementSource = PLACEMENT_SOURCES.GPID;
+        configCopy.params.placementSource = PLACEMENT_SOURCES.ADUNITCODE;
 
         const bidRequest = utils.deepClone(bidReqConfig);
-        const gpid = '/19968336/header-bid-tag-0'
-        utils.deepSetValue(bidRequest.adUnits[0], 'ortb2Imp.ext.gpid', gpid)
 
         adagioRtdSubmodule.getBidRequestData(bidRequest, cb, configCopy);
         expect(bidRequest.adUnits[0]).to.have.property('ortb2Imp');
-        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.placement).to.equal(gpid);
+        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.adg_rtd.placement).to.equal('div-gpt-ad-1460505748561-0');
       });
 
-      it('update the placement value the legacy adUnit[].bids adagio.params.placement value', function() {
-        const placement = 'placement-value';
-
+      it('fallback on the the gpid value to set the adg_rtd.placement value ', function() {
         const configCopy = utils.deepClone(config);
+        configCopy.params.placementSource = PLACEMENT_SOURCES.GPID;
 
         const bidRequest = utils.deepClone(bidReqConfig);
-        bidRequest.adUnits[0].bids[0].params.placement = placement;
+        const gpid = '/19968336/header-bid-tag-0'
+        utils.deepSetValue(bidRequest.adUnits[0], 'ortb2Imp.ext.gpid', gpid)
 
         adagioRtdSubmodule.getBidRequestData(bidRequest, cb, configCopy);
         expect(bidRequest.adUnits[0]).to.have.property('ortb2Imp');
-        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.placement).to.equal(placement);
+        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.adg_rtd.placement).to.equal(gpid);
       });
 
-      it('it does not populate `ortb2Imp.ext.data.placement` if no fallback', function() {
+      it('it does not populate `ortb2Imp.ext.data.adg_rtd.placement` if no fallback', function() {
         const configCopy = utils.deepClone(config);
         const bidRequest = utils.deepClone(bidReqConfig);
 
         adagioRtdSubmodule.getBidRequestData(bidRequest, cb, configCopy);
         expect(bidRequest.adUnits[0]).to.have.property('ortb2Imp');
-        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.placement).to.not.exist;
+        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.adg_rtd.placement).to.not.exist;
       });
 
       it('ensure we create the `ortb2Imp` object if it does not exist', function() {
@@ -571,7 +571,7 @@ describe('Adagio Rtd Provider', function () {
 
         adagioRtdSubmodule.getBidRequestData(bidRequest, cb, configCopy);
         expect(bidRequest.adUnits[0]).to.have.property('ortb2Imp');
-        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.placement).to.equal('div-gpt-ad-1460505748561-0');
+        expect(bidRequest.adUnits[0].ortb2Imp.ext.data.adg_rtd.placement).to.equal('div-gpt-ad-1460505748561-0');
       });
     });
   });