prebid.js 9.53.1 → 9.53.2

package/test/spec/modules/userId_spec.js

@@ -8,7 +8,6 @@ import {
   init,
   PBJS_USER_ID_OPTOUT_NAME,
   startAuctionHook,
-  addUserIdsHook,
   requestDataDeletion,
   setStoredValue,
   setSubmoduleRegistry,
@@ -177,7 +176,6 @@ describe('User ID', function () {
     sandbox.restore();
     config.resetConfig();
     startAuction.getHooks({hook: startAuctionHook}).remove();
-    startAuction.getHooks({hook: addUserIdsHook}).remove();
   });
 
   after(() => {
@@ -281,12 +279,12 @@ describe('User ID', function () {
       coreStorage.setCookie('pubcid_alt', '', EXPIRED_COOKIE_DATE);
     });
 
-    it('Check same cookie behavior', function () {
-      let adUnits1 = [getAdUnitMock()];
-      let adUnits2 = [getAdUnitMock()];
-      let innerAdUnits1;
-      let innerAdUnits2;
+    function getGlobalEids() {
+      const ortb2Fragments = {global: {}};
+      return expectImmediateBidHook(sinon.stub(), {ortb2Fragments}).then(() => ortb2Fragments.global.user?.ext?.eids);
+    }
 
+    it('Check same cookie behavior', async function () {
       let pubcid = coreStorage.getCookie('pubcid');
       expect(pubcid).to.be.null; // there should be no cookie initially
 
@@ -294,36 +292,19 @@ describe('User ID', function () {
       setSubmoduleRegistry([sharedIdSystemSubmodule]);
 
       config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'cookie']));
-
-      return expectImmediateBidHook(config => {
-        innerAdUnits1 = config.adUnits
-      }, {adUnits: adUnits1}).then(() => {
-        pubcid = coreStorage.getCookie('pubcid'); // cookies is created after requestbidHook
-
-        innerAdUnits1.forEach(unit => {
-          unit.bids.forEach(bid => {
-            expect(bid).to.have.deep.nested.property('userId.pubcid');
-            expect(bid.userId.pubcid).to.equal(pubcid);
-            expect(bid.userIdAsEids[0]).to.deep.equal({
-              source: 'pubcid.org',
-              uids: [{id: pubcid, atype: 1}]
-            });
-          });
-        });
-
-        return expectImmediateBidHook(config => {
-          innerAdUnits2 = config.adUnits
-        }, {adUnits: adUnits2}).then(() => {
-          assert.deepEqual(innerAdUnits1, innerAdUnits2);
-        });
-      });
+      const eids1 = await getGlobalEids();
+      pubcid = coreStorage.getCookie('pubcid'); // cookies is created after requestbidHook
+      expect(eids1).to.eql([
+        {
+          source: 'pubcid.org',
+          uids: [{id: pubcid, atype: 1}]
+        }
+      ])
+      const eids2 = await getGlobalEids();
+      assert.deepEqual(eids1, eids2);
     });
 
-    it('Check different cookies', function () {
-      let adUnits1 = [getAdUnitMock()];
-      let adUnits2 = [getAdUnitMock()];
-      let innerAdUnits1;
-      let innerAdUnits2;
+    it('Check different cookies', async function () {
       let pubcid1;
       let pubcid2;
 
@@ -331,75 +312,41 @@ describe('User ID', function () {
       setSubmoduleRegistry([sharedIdSystemSubmodule]);
 
       config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'cookie']));
-      return expectImmediateBidHook((config) => {
-        innerAdUnits1 = config.adUnits
-      }, {adUnits: adUnits1}).then(() => {
-        pubcid1 = coreStorage.getCookie('pubcid'); // get first cookie
-        coreStorage.setCookie('pubcid', '', EXPIRED_COOKIE_DATE); // erase cookie
-
-        innerAdUnits1.forEach((unit) => {
-          unit.bids.forEach((bid) => {
-            expect(bid).to.have.deep.nested.property('userId.pubcid');
-            expect(bid.userId.pubcid).to.equal(pubcid1);
-            expect(bid.userIdAsEids[0]).to.deep.equal({
-              source: 'pubcid.org',
-              uids: [{id: pubcid1, atype: 1}]
-            });
-          });
-        });
 
-        init(config);
-        setSubmoduleRegistry([sharedIdSystemSubmodule]);
+      const eids1 = await getGlobalEids()
+      pubcid1 = coreStorage.getCookie('pubcid'); // get first cookie
+      coreStorage.setCookie('pubcid', '', EXPIRED_COOKIE_DATE); // erase cookie
+      expect(eids1).to.eql([{
+        source: 'pubcid.org',
+        uids: [{id: pubcid1, atype: 1}]
+      }])
 
-        config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'cookie']));
-        return expectImmediateBidHook((config) => {
-          innerAdUnits2 = config.adUnits
-        }, {adUnits: adUnits2}).then(() => {
-          pubcid2 = coreStorage.getCookie('pubcid'); // get second cookie
-
-          innerAdUnits2.forEach((unit) => {
-            unit.bids.forEach((bid) => {
-              expect(bid).to.have.deep.nested.property('userId.pubcid');
-              expect(bid.userId.pubcid).to.equal(pubcid2);
-              expect(bid.userIdAsEids[0]).to.deep.equal({
-                source: 'pubcid.org',
-                uids: [{id: pubcid2, atype: 1}]
-              });
-            });
-          });
+      init(config);
+      setSubmoduleRegistry([sharedIdSystemSubmodule]);
+      config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'cookie']));
 
-          expect(pubcid1).to.not.equal(pubcid2);
-        });
-      });
+      const eids2 = await getGlobalEids();
+      pubcid2 = coreStorage.getCookie('pubcid'); // get second cookie
+      expect(eids2).to.eql([{
+        source: 'pubcid.org',
+        uids: [{id: pubcid2, atype: 1}]
+      }])
+      expect(pubcid1).to.not.equal(pubcid2);
     });
 
-    it('Use existing cookie', function () {
-      let adUnits = [getAdUnitMock()];
-      let innerAdUnits;
-
+    it('Use existing cookie', async function () {
       init(config);
       setSubmoduleRegistry([sharedIdSystemSubmodule]);
 
       config.setConfig(getConfigMock(['pubCommonId', 'pubcid_alt', 'cookie']));
-      return expectImmediateBidHook((config) => {
-        innerAdUnits = config.adUnits
-      }, {adUnits}).then(() => {
-        innerAdUnits.forEach((unit) => {
-          unit.bids.forEach((bid) => {
-            expect(bid).to.have.deep.nested.property('userId.pubcid');
-            expect(bid.userId.pubcid).to.equal('altpubcid200000');
-            expect(bid.userIdAsEids[0]).to.deep.equal({
-              source: 'pubcid.org',
-              uids: [{id: 'altpubcid200000', atype: 1}]
-            });
-          });
-        });
-      });
+      const eids = await getGlobalEids();
+      expect(eids).to.eql([{
+        source: 'pubcid.org',
+        uids: [{id: 'altpubcid200000', atype: 1}]
+      }])
     });
 
-    it('Extend cookie', function () {
-      let adUnits = [getAdUnitMock()];
-      let innerAdUnits;
+    it('Extend cookie', async function () {
       let customConfig = getConfigMock(['pubCommonId', 'pubcid_alt', 'cookie']);
       customConfig = addConfig(customConfig, 'params', {extend: true});
 
@@ -407,25 +354,15 @@ describe('User ID', function () {
       setSubmoduleRegistry([sharedIdSystemSubmodule]);
 
       config.setConfig(customConfig);
-      return expectImmediateBidHook((config) => {
-        innerAdUnits = config.adUnits
-      }, {adUnits}).then(() => {
-        innerAdUnits.forEach((unit) => {
-          unit.bids.forEach((bid) => {
-            expect(bid).to.have.deep.nested.property('userId.pubcid');
-            expect(bid.userId.pubcid).to.equal('altpubcid200000');
-            expect(bid.userIdAsEids[0]).to.deep.equal({
-              source: 'pubcid.org',
-              uids: [{id: 'altpubcid200000', atype: 1}]
-            });
-          });
-        });
-      });
+      const fpd = {};
+      const eids = await getGlobalEids();
+      expect(eids).to.deep.equal([{
+        source: 'pubcid.org',
+        uids: [{id: 'altpubcid200000', atype: 1}]
+      }]);
     });
 
-    it('Disable auto create', function () {
-      let adUnits = [getAdUnitMock()];
-      let innerAdUnits;
+    it('Disable auto create', async function () {
       let customConfig = getConfigMock(['pubCommonId', 'pubcid', 'cookie']);
       customConfig = addConfig(customConfig, 'params', {create: false});
 
@@ -433,16 +370,8 @@ describe('User ID', function () {
       setSubmoduleRegistry([sharedIdSystemSubmodule]);
 
       config.setConfig(customConfig);
-      return expectImmediateBidHook((config) => {
-        innerAdUnits = config.adUnits
-      }, {adUnits}).then(() => {
-        innerAdUnits.forEach((unit) => {
-          unit.bids.forEach((bid) => {
-            expect(bid).to.not.have.deep.nested.property('userId.pubcid');
-            expect(bid).to.not.have.deep.nested.property('userIdAsEids');
-          });
-        });
-      });
+      const eids = await getGlobalEids();
+      expect(eids).to.not.exist;
     });
 
     describe('createEidsArray', () => {
@@ -1744,8 +1673,6 @@ describe('User ID', function () {
           // check ids were copied to bids
           adUnits.forEach(unit => {
             unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userId.mid');
-              expect(bid.userId.mid).to.equal('1234');
               expect(bid.userIdAsEids).to.not.exist;// "mid" is an un-known submodule for USER_IDS_CONFIG in eids.js
             });
           });
@@ -1840,70 +1767,39 @@ describe('User ID', function () {
       });
     });
 
-    describe('Start auction hook appends userId to bid objs in adapters', function () {
+    describe('Start auction hook appends userId to first party data', function () {
       let adUnits;
 
       beforeEach(function () {
         adUnits = [getAdUnitMock()];
       });
 
-      it('should include pub-provided eids in userIdAsEids', (done) => {
-        init(config);
-        setSubmoduleRegistry([createMockIdSubmodule('mockId', {id: {mockId: 'id'}}, null, {mockId: {source: 'mockid.com', atype: 1}})]);
-        config.setConfig({
-          userSync: {
-            userIds: [
-              {name: 'mockId'}
-            ]
-          }
-        });
-        startAuctionHook(({adUnits}) => {
-          adUnits[0].bids.forEach(bid => {
-            expect(bid.userIdAsEids.find(eid => eid.source === 'mockid.com')).to.exist;
-            const bidderEid = bid.userIdAsEids.find(eid => eid.bidder === 'pub-provided');
-            expect(bidderEid != null).to.eql(bid.bidder === 'sampleBidder');
-            expect(bid.userIdAsEids.find(eid => eid.id === 'pub-provided')).to.exist;
-          })
-          done();
-        }, {
-          adUnits,
-          ortb2Fragments: {
-            global: {
-              user: {ext: {eids: [{id: 'pub-provided'}]}}
-            },
-            bidder: {
-              sampleBidder: {
-                user: {ext: {eids: [{bidder: 'pub-provided'}]}}
-              }
-            }
-          }
+      function getGlobalEids() {
+        return new Promise((resolve) => {
+          startAuctionHook(function ({ortb2Fragments}) {
+            resolve(ortb2Fragments.global.user?.ext?.eids);
+          }, {ortb2Fragments: { global: {} }})
         })
-      })
+      }
 
-      it('test hook from pubcommonid cookie', function (done) {
+      it('test hook from pubcommonid cookie', async function () {
         coreStorage.setCookie('pubcid', 'testpubcid', (new Date(Date.now() + 100000).toUTCString()));
 
         init(config);
         setSubmoduleRegistry([sharedIdSystemSubmodule]);
         config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'cookie']));
-
-        startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userId.pubcid');
-              expect(bid.userId.pubcid).to.equal('testpubcid');
-              expect(bid.userIdAsEids[0]).to.deep.equal({
-                source: 'pubcid.org',
-                uids: [{id: 'testpubcid', atype: 1}]
-              });
-            });
-          });
+        try {
+          const eids = await getGlobalEids();
+          expect(eids).to.eql([{
+            source: 'pubcid.org',
+            uids: [{id: 'testpubcid', atype: 1}]
+          }])
+        } finally {
           coreStorage.setCookie('pubcid', '', EXPIRED_COOKIE_DATE);
-          done();
-        }, {adUnits});
+        }
       });
 
-      it('test hook from pubcommonid html5', function (done) {
+      it('test hook from pubcommonid html5', async function () {
         // simulate existing browser local storage values
         localStorage.setItem('pubcid', 'testpubcid');
         localStorage.setItem('pubcid_exp', new Date(Date.now() + 100000).toUTCString());
@@ -1912,24 +1808,19 @@ describe('User ID', function () {
         setSubmoduleRegistry([sharedIdSystemSubmodule]);
         config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'html5']));
 
-        startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userId.pubcid');
-              expect(bid.userId.pubcid).to.equal('testpubcid');
-              expect(bid.userIdAsEids[0]).to.deep.equal({
-                source: 'pubcid.org',
-                uids: [{id: 'testpubcid', atype: 1}]
-              });
-            });
-          });
+        try {
+          const eids = await getGlobalEids();
+          expect(eids).to.eql([{
+            source: 'pubcid.org',
+            uids: [{id: 'testpubcid', atype: 1}]
+          }]);
+        } finally {
           localStorage.removeItem('pubcid');
           localStorage.removeItem('pubcid_exp');
-          done();
-        }, {adUnits});
+        }
       });
 
-      it('test hook from pubcommonid cookie&html5', function (done) {
+      it('test hook from pubcommonid cookie&html5', async function () {
         const expiration = new Date(Date.now() + 100000).toUTCString();
         coreStorage.setCookie('pubcid', 'testpubcid', expiration);
         localStorage.setItem('pubcid', 'testpubcid');
@@ -1939,27 +1830,20 @@ describe('User ID', function () {
         setSubmoduleRegistry([sharedIdSystemSubmodule]);
         config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'cookie&html5']));
 
-        startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userId.pubcid');
-              expect(bid.userId.pubcid).to.equal('testpubcid');
-              expect(bid.userIdAsEids[0]).to.deep.equal({
-                source: 'pubcid.org',
-                uids: [{id: 'testpubcid', atype: 1}]
-              });
-            });
-          });
-
+        try {
+          const eids = await getGlobalEids();
+          expect(eids).to.eql([{
+            source: 'pubcid.org',
+            uids: [{id: 'testpubcid', atype: 1}]
+          }]);
+        } finally {
           coreStorage.setCookie('pubcid', '', EXPIRED_COOKIE_DATE);
           localStorage.removeItem('pubcid');
           localStorage.removeItem('pubcid_exp');
-
-          done();
-        }, {adUnits});
+        }
       });
 
-      it('test hook from pubcommonid cookie&html5, no cookie present', function (done) {
+      it('test hook from pubcommonid cookie&html5, no cookie present', async function () {
         localStorage.setItem('pubcid', 'testpubcid');
         localStorage.setItem('pubcid_exp', new Date(Date.now() + 100000).toUTCString());
 
@@ -1967,68 +1851,44 @@ describe('User ID', function () {
         setSubmoduleRegistry([sharedIdSystemSubmodule]);
         config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'cookie&html5']));
 
-        startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userId.pubcid');
-              expect(bid.userId.pubcid).to.equal('testpubcid');
-              expect(bid.userIdAsEids[0]).to.deep.equal({
-                source: 'pubcid.org',
-                uids: [{id: 'testpubcid', atype: 1}]
-              });
-            });
-          });
-
+        try {
+          const eids = await getGlobalEids();
+          expect(eids).to.eql([{
+            source: 'pubcid.org',
+            uids: [{id: 'testpubcid', atype: 1}]
+          }])
+        } finally {
           localStorage.removeItem('pubcid');
           localStorage.removeItem('pubcid_exp');
-
-          done();
-        }, {adUnits});
+        }
       });
 
-      it('test hook from pubcommonid cookie&html5, no local storage entry', function (done) {
+      it('test hook from pubcommonid cookie&html5, no local storage entry', async function () {
         coreStorage.setCookie('pubcid', 'testpubcid', (new Date(Date.now() + 100000).toUTCString()));
 
         init(config);
         setSubmoduleRegistry([sharedIdSystemSubmodule]);
         config.setConfig(getConfigMock(['pubCommonId', 'pubcid', 'cookie&html5']));
 
-        startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userId.pubcid');
-              expect(bid.userId.pubcid).to.equal('testpubcid');
-              expect(bid.userIdAsEids[0]).to.deep.equal({
-                source: 'pubcid.org',
-                uids: [{id: 'testpubcid', atype: 1}]
-              });
-            });
-          });
-
+        try {
+          const eids = await getGlobalEids();
+          expect(eids).to.eql([{
+            source: 'pubcid.org',
+            uids: [{id: 'testpubcid', atype: 1}]
+          }]);
+        } finally {
           coreStorage.setCookie('pubcid', '', EXPIRED_COOKIE_DATE);
-
-          done();
-        }, {adUnits});
+        }
       });
 
-      it('test hook from pubcommonid config value object', function (done) {
+      it('test hook from pubcommonid config value object', async function () {
         init(config);
         setSubmoduleRegistry([sharedIdSystemSubmodule]);
         config.setConfig(getConfigValueMock('pubCommonId', {'pubcidvalue': 'testpubcidvalue'}));
-
-        startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userId.pubcidvalue');
-              expect(bid.userId.pubcidvalue).to.equal('testpubcidvalue');
-              expect(bid.userIdAsEids).to.not.exist; // "pubcidvalue" is an un-known submodule for USER_IDS_CONFIG in eids.js
-            });
-          });
-          done();
-        }, {adUnits});
+        expect(await getGlobalEids()).to.not.exist; // "pubcidvalue" is an un-known submodule for USER_IDS_CONFIG in eids.js
       });
 
-      it('test hook from pubProvidedId config params', function (done) {
+      it('test hook from pubProvidedId config params', async function () {
         init(config);
         setSubmoduleRegistry([pubProvidedIdSubmodule]);
         config.setConfig({
@@ -2071,61 +1931,28 @@ describe('User ID', function () {
           }
         });
 
-        startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userId.pubProvidedId');
-              expect(bid.userId.pubProvidedId).to.deep.equal([{
-                source: 'example.com',
-                uids: [{
-                  id: 'value read from cookie or local storage',
-                  ext: {
-                    stype: 'ppuid'
-                  }
-                }]
-              }, {
-                source: 'id-partner.com',
-                uids: [{
-                  id: 'value read from cookie or local storage',
-                  ext: {
-                    stype: 'dmp'
-                  }
-                }]
-              }, {
-                source: 'provider.com',
-                uids: [{
-                  id: 'value read from cookie or local storage',
-                  ext: {
-                    stype: 'sha256email'
-                  }
-                }]
-              }]);
-
-              expect(bid.userIdAsEids[0]).to.deep.equal({
-                source: 'example.com',
-                uids: [{
-                  id: 'value read from cookie or local storage',
-                  ext: {
-                    stype: 'ppuid'
-                  }
-                }]
-              });
-              expect(bid.userIdAsEids[2]).to.deep.equal({
-                source: 'provider.com',
-                uids: [{
-                  id: 'value read from cookie or local storage',
-                  ext: {
-                    stype: 'sha256email'
-                  }
-                }]
-              });
-            });
-          });
-          done();
-        }, {adUnits});
+        const eids = await getGlobalEids();
+        expect(eids).to.deep.contain({
+          source: 'example.com',
+          uids: [{
+            id: 'value read from cookie or local storage',
+            ext: {
+              stype: 'ppuid'
+            }
+          }]
+        });
+        expect(eids).to.deep.contain({
+          source: 'provider.com',
+          uids: [{
+            id: 'value read from cookie or local storage',
+            ext: {
+              stype: 'sha256email'
+            }
+          }]
+        });
       });
 
-      it('should add new id system ', function (done) {
+      it('should add new id system ', async function () {
         coreStorage.setCookie('pubcid', 'testpubcid', (new Date(Date.now() + 5000).toUTCString()));
 
         init(config);
@@ -2153,23 +1980,16 @@ describe('User ID', function () {
           getId: function (config, consentData, storedId) {
             if (storedId) return {};
             return {id: {'MOCKID': '1234'}};
+          },
+          eids: {
+            mid: {
+              source: 'mockid'
+            }
           }
         });
 
-        startAuctionHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              // check PubCommonId id data was copied to bid
-              expect(bid).to.have.deep.nested.property('userId.pubcid');
-              // check MockId data was copied to bid
-              expect(bid).to.have.deep.nested.property('userId.mid');
-              expect(bid.userId.mid).to.equal('1234');
-            });
-          });
-          coreStorage.setCookie('pubcid', '', EXPIRED_COOKIE_DATE);
-          coreStorage.setCookie('MOCKID', '', EXPIRED_COOKIE_DATE);
-          done();
-        }, {adUnits});
+        const eids = await getGlobalEids();
+        expect(eids.find(eid => eid.source === 'mockid')).to.exist;
       });
 
       describe('activity controls', () => {
@@ -2188,6 +2008,11 @@ describe('User ID', function () {
             },
             getId: function () {
               return {id: `${name}Value`};
+            },
+            eids: {
+              [name]: {
+                source: name
+              }
             }
           }));
           mods.forEach(attachIdSystem);
@@ -2196,7 +2021,7 @@ describe('User ID', function () {
           isAllowed.restore();
         });
 
-        it('should check for enrichEids activity permissions', (done) => {
+        it('should check for enrichEids activity permissions', async () => {
           isAllowed.callsFake((activity, params) => {
             return !(activity === ACTIVITY_ENRICH_EIDS &&
               params[ACTIVITY_PARAM_COMPONENT_TYPE] === MODULE_TYPE_UID &&
@@ -2211,11 +2036,9 @@ describe('User ID', function () {
               }))
             }
           });
-          startAuctionHook((req) => {
-            const activeIds = req.adUnits.flatMap(au => au.bids).flatMap(bid => Object.keys(bid.userId));
-            expect(Array.from(new Set(activeIds))).to.have.members([MOCK_IDS[1]]);
-            done();
-          }, {adUnits})
+          const eids = await getGlobalEids();
+          const activeSources = eids.map(({source}) => source);
+          expect(Array.from(new Set(activeSources))).to.have.members([MOCK_IDS[1]]);
         });
       })
     });
@@ -2253,7 +2076,7 @@ describe('User ID', function () {
         init(config);
         setSubmoduleRegistry([sharedIdSystemSubmodule]);
         config.mergeConfig(customCfg);
-        return runBidsHook({}).then(() => {
+        return runBidsHook(sinon.stub(), {}).then(() => {
           expect(utils.triggerPixel.called).to.be.false;
           return endAuction();
         }).then(() => {
@@ -2528,62 +2351,6 @@ describe('User ID', function () {
         })
       })
     });
-
-    describe('submodules not added', () => {
-      const eid = {
-        source: 'example.com',
-        uids: [{id: '1234', atype: 3}]
-      };
-      let adUnits;
-      let startAuctionStub;
-      function saHook(fn, ...args) {
-        return startAuctionStub(...args);
-      }
-      beforeEach(() => {
-        adUnits = [{code: 'au1', bids: [{bidder: 'sampleBidder'}]}];
-        startAuctionStub = sinon.stub();
-        startAuction.before(saHook);
-        config.resetConfig();
-      });
-      afterEach(() => {
-        startAuction.getHooks({hook: saHook}).remove();
-      })
-
-      it('addUserIdsHook', function (done) {
-        addUserIdsHook(function () {
-          adUnits.forEach(unit => {
-            unit.bids.forEach(bid => {
-              expect(bid).to.have.deep.nested.property('userIdAsEids.0.source');
-              expect(bid).to.have.deep.nested.property('userIdAsEids.0.uids.0.id');
-              expect(bid.userIdAsEids[0].source).to.equal('example.com');
-              expect(bid.userIdAsEids[0].uids[0].id).to.equal('1234');
-            });
-          });
-          done();
-        }, {
-          adUnits,
-          ortb2Fragments: {
-            global: {user: {ext: {eids: [eid]}}},
-            bidder: {}
-          }
-        });
-      });
-
-      it('should add userIdAsEids and merge ortb2.user.ext.eids even if no User ID submodules', async () => {
-        init(config);
-        expect(startAuction.getHooks({hook: startAuctionHook}).length).equal(0);
-        expect(startAuction.getHooks({hook: addUserIdsHook}).length).equal(1);
-        addUserIdsHook(sinon.stub(), {
-          adUnits,
-          ortb2Fragments: {
-            global: {
-              user: {ext: {eids: [eid]}}
-            }
-          }
-        });
-        expect(adUnits[0].bids[0].userIdAsEids[0]).to.eql(eid);
-      });
-    });
   });
 
   describe('handles config with ESP configuration in user sync object', function() {
@@ -3184,12 +2951,6 @@ describe('User ID', function () {
       });
 
       return getGlobal().getUserIdsAsync().then(() => {
-        const adUnits = [{
-          bids: [
-            { bidder: 'bidderA' },
-            { bidder: 'bidderB' },
-          ]
-        }];
         const ortb2Fragments = {
           global: {
             user: {}
@@ -3203,13 +2964,7 @@ describe('User ID', function () {
             }
           }
         };
-        addIdData({ adUnits, ortb2Fragments });
-
-        adUnits[0].bids.forEach(({userId}) => {
-          const userIdModules = Object.keys(userId);
-          expect(userIdModules).to.include(ALLOWED_MODULE);
-          expect(userIdModules).to.not.include(UNALLOWED_MODULE);
-        });
+        addIdData({ ortb2Fragments });
 
         bidders.forEach((bidderName) => {
           const userIdModules = ortb2Fragments.bidder[bidderName].user.ext.eids.map(eid => eid.source);