prebid.js 8.6.0 → 8.8.0

package/modules/visxBidAdapter.js

@@ -3,6 +3,7 @@ import { registerBidder } from '../src/adapters/bidderFactory.js';
 import { config } from '../src/config.js';
 import { BANNER, VIDEO } from '../src/mediaTypes.js';
 import { INSTREAM as VIDEO_INSTREAM } from '../src/video.js';
+import {getStorageManager} from '../src/storageManager.js';
 const BIDDER_CODE = 'visx';
 const GVLID = 154;
 const BASE_URL = 'https://t.visx.net';
@@ -29,6 +30,7 @@ const LOG_ERROR_MESS = {
   videoMissing: 'Bid request videoType property is missing - '
 };
 const currencyWhiteList = ['EUR', 'USD', 'GBP', 'PLN'];
+export const storage = getStorageManager({bidderCode: BIDDER_CODE});
 export const spec = {
   code: BIDDER_CODE,
   gvlid: GVLID,
@@ -117,10 +119,13 @@ export const spec = {
         ...(payloadSchain && { schain: payloadSchain })
       }
     };
+
+    const vads = _getUserId();
     const user = {
       ext: {
         ...(payloadUserEids && { eids: payloadUserEids }),
-        ...(payload.gdpr_consent && { consent: payload.gdpr_consent })
+        ...(payload.gdpr_consent && { consent: payload.gdpr_consent }),
+        ...(vads && { vads })
       }
     };
     const regs = ('gdpr_applies' in payload) && {
@@ -382,4 +387,49 @@ function _isAdSlotExists(adUnitCode) {
   return false;
 }
 
+// Generate user id (25 chars) with NanoID
+// https://github.com/ai/nanoid/
+function _generateUserId() {
+  for (
+    var t = 'useandom-26T198340PX75pxJACKVERYMINDBUSHWOLF_GQZbfghjklqvwyzrict',
+      e = new Date().getTime() % 1073741824,
+      i = '',
+      o = 0;
+    o < 5;
+    o++
+  ) {
+    i += t[e % 64];
+    e = Math.floor(e / 64);
+  }
+  for (o = 20; o--;) i += t[(64 * Math.random()) | 0];
+  return i;
+}
+
+function _getUserId() {
+  const USER_ID_KEY = '__vads';
+  let vads;
+
+  if (storage.cookiesAreEnabled()) {
+    vads = storage.getCookie(USER_ID_KEY);
+  } else if (storage.localStorageIsEnabled()) {
+    vads = storage.getDataFromLocalStorage(USER_ID_KEY);
+  }
+
+  if (vads && vads.length) {
+    return vads;
+  }
+
+  vads = _generateUserId();
+  if (storage.cookiesAreEnabled()) {
+    const expires = new Date(Date.now() + 2592e6).toUTCString();
+    storage.setCookie(USER_ID_KEY, vads, expires);
+    return vads;
+  } else if (storage.localStorageIsEnabled()) {
+    storage.setDataInLocalStorage(USER_ID_KEY, vads);
+    return vads;
+  }
+
+  return null;
+}
+
 registerBidder(spec);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prebid.js",
-  "version": "8.6.0",
+  "version": "8.8.0",
   "description": "Header Bidding Management Library",
   "main": "src/prebid.js",
   "scripts": {
@@ -132,7 +132,7 @@
     "express": "^4.15.4",
     "fun-hooks": "^0.9.9",
     "just-clone": "^1.0.2",
-    "live-connect-js": "^5.0.0"
+    "live-connect-js": "^6.0.0"
   },
   "optionalDependencies": {
     "fsevents": "^2.3.2"

package/src/adloader.js

@@ -26,6 +26,7 @@ const _approvedLoadExternalJSList = [
   'airgrid',
   'clean.io',
   'a1Media',
+  'geoedge',
 ]
 
 /**

package/src/native.js

@@ -780,8 +780,8 @@ export function toLegacyResponse(ortbResponse, ortbRequest) {
   legacyResponse.impressionTrackers = [];
   let jsTrackers = [];
 
-  if (ortbRequest?.imptrackers) {
-    legacyResponse.impressionTrackers.push(...ortbRequest.imptrackers);
+  if (ortbResponse.imptrackers) {
+    legacyResponse.impressionTrackers.push(...ortbResponse.imptrackers);
   }
   for (const eventTracker of ortbResponse?.eventtrackers || []) {
     if (eventTracker.event === TRACKER_EVENTS.impression && eventTracker.method === TRACKER_METHODS.img) {

package/test/spec/modules/adagioBidAdapter_spec.js

@@ -697,6 +697,95 @@ describe('Adagio bid adapter', () => {
       });
     });
 
+    describe('with GPP', function() {
+      const bid01 = new BidRequestBuilder().withParams().build();
+
+      const regsGpp = 'regs_gpp_consent_string';
+      const regsApplicableSections = [2];
+
+      const ortb2Gpp = 'ortb2_gpp_consent_string';
+      const ortb2GppSid = [1];
+
+      context('When GPP in regs module', function() {
+        it('send gpp and gppSid to the server', function() {
+          const bidderRequest = new BidderRequestBuilder({
+            gppConsent: {
+              gppString: regsGpp,
+              applicableSections: regsApplicableSections,
+            }
+          }).build();
+
+          const requests = spec.buildRequests([bid01], bidderRequest);
+
+          expect(requests[0].data.regs.gpp).to.equal(regsGpp);
+          expect(requests[0].data.regs.gppSid).to.equal(regsApplicableSections);
+        });
+      });
+
+      context('When GPP partially defined in regs module', function() {
+        it('send gpp and gppSid coming from ortb2 to the server', function() {
+          const bidderRequest = new BidderRequestBuilder({
+            gppConsent: {
+              gppString: regsGpp,
+            },
+            ortb2: {
+              regs: {
+                gpp: ortb2Gpp,
+                gpp_sid: ortb2GppSid,
+              }
+            }
+          }).build();
+
+          const requests = spec.buildRequests([bid01], bidderRequest);
+
+          expect(requests[0].data.regs.gpp).to.equal(ortb2Gpp);
+          expect(requests[0].data.regs.gppSid).to.equal(ortb2GppSid);
+        });
+
+        it('send empty gpp and gppSid if no ortb2 fields to the server', function() {
+          const bidderRequest = new BidderRequestBuilder({
+            gppConsent: {
+              gppString: regsGpp,
+            }
+          }).build();
+
+          const requests = spec.buildRequests([bid01], bidderRequest);
+
+          expect(requests[0].data.regs.gpp).to.equal('');
+          expect(requests[0].data.regs.gppSid).to.be.empty;
+        });
+      });
+
+      context('When GPP defined in ortb2 module', function() {
+        it('send gpp and gppSid coming from ortb2 to the server', function() {
+          const bidderRequest = new BidderRequestBuilder({
+            ortb2: {
+              regs: {
+                gpp: ortb2Gpp,
+                gpp_sid: ortb2GppSid,
+              }
+            }
+          }).build();
+
+          const requests = spec.buildRequests([bid01], bidderRequest);
+
+          expect(requests[0].data.regs.gpp).to.equal(ortb2Gpp);
+          expect(requests[0].data.regs.gppSid).to.equal(ortb2GppSid);
+        });
+      });
+
+      context('When GPP not defined in any modules', function() {
+        it('send empty gpp and gppSid', function() {
+          const bidderRequest = new BidderRequestBuilder({}).build();
+
+          const requests = spec.buildRequests([bid01], bidderRequest);
+
+          expect(requests[0].data.regs.gpp).to.equal('');
+          expect(requests[0].data.regs.gppSid).to.be.empty;
+        });
+      });
+    });
+
     describe('with userID modules', function() {
       const userIdAsEids = [{
         'source': 'pubcid.org',

package/test/spec/modules/adgenerationBidAdapter_spec.js

@@ -184,12 +184,12 @@ describe('AdgenerationAdapter', function () {
       }
     };
     const data = {
-      banner: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=300x250%2C320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.1&imark=1&tp=https%3A%2F%2Fexample.com`,
-      bannerUSD: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=300x250%2C320x100&currency=USD&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.1&imark=1&tp=https%3A%2F%2Fexample.com`,
-      native: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=1x1&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.1&tp=https%3A%2F%2Fexample.com`,
-      bannerWithHyperId: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.1&imark=1&tp=https%3A%2F%2Fexample.com&hyper_id=novatiqId`,
-      bannerWithAdgextCriteoId: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.1&adgext_criteo_id=criteo-id-test-1234567890&imark=1&tp=https%3A%2F%2Fexample.com`,
-      bannerWithAdgextIds: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.1&adgext_id5_id=id5-id-test-1234567890&adgext_id5_id_link_type=2&adgext_imuid=i.KrAH6ZAZTJOnH5S4N2sogA&adgext_uid2=%5Bobject%20Object%5D&gpid=%2F1111%2Fhomepage%23300x250&uach=%7B%22source%22%3A2%2C%22platform%22%3A%7B%22brand%22%3A%22macOS%22%7D%2C%22browsers%22%3A%5B%7B%22brand%22%3A%22Chromium%22%2C%22version%22%3A%5B%22112%22%5D%7D%2C%7B%22brand%22%3A%22Google%20Chrome%22%2C%22version%22%3A%5B%22112%22%5D%7D%2C%7B%22brand%22%3A%22Not%3AA-Brand%22%2C%22version%22%3A%5B%2299%22%5D%7D%5D%2C%22mobile%22%3A0%7D&schain=%7B%22ver%22%3A%221.0%22%2C%22complete%22%3A1%2C%22nodes%22%3A%5B%7B%22asi%22%3A%22indirectseller.com%22%2C%22sid%22%3A%2200001%22%2C%22hp%22%3A1%7D%5D%7D&imark=1&tp=https%3A%2F%2Fexample.com`,
+      banner: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=300x250%2C320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.2&imark=1&tp=https%3A%2F%2Fexample.com`,
+      bannerUSD: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=300x250%2C320x100&currency=USD&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.2&imark=1&tp=https%3A%2F%2Fexample.com`,
+      native: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=1x1&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.2&tp=https%3A%2F%2Fexample.com`,
+      bannerWithHyperId: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.2&imark=1&tp=https%3A%2F%2Fexample.com&hyper_id=novatiqId`,
+      bannerWithAdgextCriteoId: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.2&adgext_criteo_id=criteo-id-test-1234567890&imark=1&tp=https%3A%2F%2Fexample.com`,
+      bannerWithAdgextIds: `posall=SSPLOC&id=58278&sdktype=0&hb=true&t=json3&sizes=320x100&currency=JPY&pbver=${prebid.version}&sdkname=prebidjs&adapterver=1.6.2&adgext_id5_id=id5-id-test-1234567890&adgext_id5_id_link_type=2&adgext_imuid=i.KrAH6ZAZTJOnH5S4N2sogA&adgext_uid2=AgAAAAVacu1uAxgAxH%2BHJ8%2BnWlS2H4uVqr6i%2BHBDCNREHD8WKsio%2Fx7D8xXFuq1cJycUU86yXfTH9Xe%2F4C8KkH%2B7UCiU7uQxhyD7Qxnv251pEs6K8oK%2BBPLYR%2B8BLY%2FsJKesa%2FkoKwx1FHgUzIBum582tSy2Oo%2B7C6wYUaaV4QcLr%2F4LPA%3D&gpid=%2F1111%2Fhomepage%23300x250&uach=%7B%22source%22%3A2%2C%22platform%22%3A%7B%22brand%22%3A%22macOS%22%7D%2C%22browsers%22%3A%5B%7B%22brand%22%3A%22Chromium%22%2C%22version%22%3A%5B%22112%22%5D%7D%2C%7B%22brand%22%3A%22Google%20Chrome%22%2C%22version%22%3A%5B%22112%22%5D%7D%2C%7B%22brand%22%3A%22Not%3AA-Brand%22%2C%22version%22%3A%5B%2299%22%5D%7D%5D%2C%22mobile%22%3A0%7D&schain=%7B%22ver%22%3A%221.0%22%2C%22complete%22%3A1%2C%22nodes%22%3A%5B%7B%22asi%22%3A%22indirectseller.com%22%2C%22sid%22%3A%2200001%22%2C%22hp%22%3A1%7D%5D%7D&imark=1&tp=https%3A%2F%2Fexample.com`,
     };
     it('sends bid request to ENDPOINT via GET', function () {
       const request = spec.buildRequests(bidRequests, bidderRequest)[0];

package/test/spec/modules/admaticBidAdapter_spec.js

@@ -28,6 +28,7 @@ describe('admaticBidAdapter', () => {
       'bidderRequestId': '22edbae2733bf6',
       'auctionId': '1d1a030790a475',
       'creativeId': 'er2ee',
+      'ortb2Imp': { 'ext': { 'instl': 1 } },
       'ortb2': { 'badv': ['admatic.com.tr'] }
     };
 
@@ -52,6 +53,7 @@ describe('admaticBidAdapter', () => {
           'networkId': 10433394,
           'host': 'layer.serve.admatic.com.tr'
         },
+        'ortb2Imp': { 'ext': { 'instl': 1 } },
         'ortb2': { 'badv': ['admatic.com.tr'] },
         'mediaTypes': {
           'banner': {
@@ -162,6 +164,7 @@ describe('admaticBidAdapter', () => {
           'networkId': 10433394,
           'host': 'layer.serve.admatic.com.tr'
         },
+        'ortb2Imp': { 'ext': { 'instl': 1 } },
         'ortb2': { 'badv': ['admatic.com.tr'] },
         'mediaTypes': {
           'banner': {
@@ -284,6 +287,7 @@ describe('admaticBidAdapter', () => {
               'sizes': [[300, 250], [728, 90]]
             }
           },
+          'ortb2Imp': { 'ext': { 'instl': 1 } },
           'ortb2': { 'badv': ['admatic.com.tr'] },
           getFloor: inputParams => {
             if (inputParams.mediaType === BANNER && inputParams.size[0] === 300 && inputParams.size[1] === 250) {
@@ -308,6 +312,7 @@ describe('admaticBidAdapter', () => {
           'networkId': 10433394,
           'host': 'layer.serve.admatic.com.tr'
         },
+        'ortb2Imp': { 'ext': { 'instl': 1 } },
         'ortb2': { 'badv': ['admatic.com.tr'] },
         'adUnitCode': 'adunit-code',
         'sizes': [[300, 250], [728, 90]],

package/test/spec/modules/adqueryIdSystem_spec.js

@@ -1,5 +1,6 @@
-import { adqueryIdSubmodule, storage } from 'modules/adqueryIdSystem.js';
-import { server } from 'test/mocks/xhr.js';
+import {adqueryIdSubmodule, storage} from 'modules/adqueryIdSystem.js';
+import {server} from 'test/mocks/xhr.js';
+import sinon from 'sinon';
 
 const config = {
   storage: {
@@ -18,7 +19,7 @@ describe('AdqueryIdSystem', function () {
     });
   });
 
-  describe('getId', function() {
+  describe('getId', function () {
     let getDataFromLocalStorageStub;
 
     beforeEach(function() {
@@ -29,7 +30,7 @@ describe('AdqueryIdSystem', function () {
       getDataFromLocalStorageStub.restore();
     });
 
-    it('gets a adqueryId', function() {
+    it('gets a adqueryId', function () {
       const config = {
         params: {}
       };
@@ -37,36 +38,24 @@ describe('AdqueryIdSystem', function () {
       const callback = adqueryIdSubmodule.getId(config).callback;
       callback(callbackSpy);
       const request = server.requests[0];
-      expect(request.url).to.eq(`https://bidder.adquery.io/prebid/qid`);
-      request.respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ qid: 'qid' }));
-      expect(callbackSpy.lastCall.lastArg).to.deep.equal({qid: 'qid'});
+      expect(request.url).to.contains(`https://bidder.adquery.io/prebid/qid?qid=`);
+      request.respond(200, {'Content-Type': 'application/json'}, JSON.stringify({qid: '6dd9eab7dfeab7df6dd9ea'}));
+      expect(callbackSpy.lastCall.lastArg).to.deep.equal('6dd9eab7dfeab7df6dd9ea');
     });
 
-    it('gets a cached adqueryId', function() {
-      const config = {
-        params: {}
-      };
-      getDataFromLocalStorageStub.withArgs('qid').returns('qid');
-
-      const callbackSpy = sinon.spy();
-      const callback = adqueryIdSubmodule.getId(config).callback;
-      callback(callbackSpy);
-      expect(callbackSpy.lastCall.lastArg).to.deep.equal({qid: 'qid'});
-    });
-
-    it('allows configurable id url', function() {
+    it('allows configurable id url', function () {
       const config = {
         params: {
-          url: 'https://bidder.adquery.io'
+          url: 'https://another_bidder.adquery.io/qid'
         }
       };
       const callbackSpy = sinon.spy();
       const callback = adqueryIdSubmodule.getId(config).callback;
       callback(callbackSpy);
       const request = server.requests[0];
-      expect(request.url).to.eq('https://bidder.adquery.io');
-      request.respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ qid: 'testqid' }));
-      expect(callbackSpy.lastCall.lastArg).to.deep.equal({qid: 'testqid'});
+      expect(request.url).to.contains('https://another_bidder.adquery.io');
+      request.respond(200, {'Content-Type': 'application/json'}, JSON.stringify({qid: 'testqid'}));
+      expect(callbackSpy.lastCall.lastArg).to.deep.equal('testqid');
     });
   });
 });

package/test/spec/modules/alkimiBidAdapter_spec.js

@@ -14,8 +14,7 @@ const REQUEST = {
   },
   'params': {
     bidFloor: 0.1,
-    token: 'e64782a4-8e68-4c38-965b-80ccf115d46f',
-    pos: 7
+    token: 'e64782a4-8e68-4c38-965b-80ccf115d46f'
   },
   'userIdAsEids': [{
     'source': 'criteo.com',
@@ -96,10 +95,6 @@ describe('alkimiBidAdapter', function () {
       delete bid.params.token
       expect(spec.isBidRequestValid(bid)).to.equal(false)
 
-      bid = Object.assign({}, REQUEST)
-      delete bid.params.bidFloor
-      expect(spec.isBidRequestValid(bid)).to.equal(false)
-
       bid = Object.assign({}, REQUEST)
       delete bid.params
       expect(spec.isBidRequestValid(bid)).to.equal(false)
@@ -109,7 +104,6 @@ describe('alkimiBidAdapter', function () {
   describe('buildRequests', function () {
     let bidRequests = [REQUEST]
     let requestData = {
-      auctionId: '123',
       refererInfo: {
         page: 'http://test.com/path.html'
       },
@@ -137,10 +131,10 @@ describe('alkimiBidAdapter', function () {
 
     it('sends bid request to ENDPOINT via POST', function () {
       expect(bidderRequest.method).to.equal('POST')
-      expect(bidderRequest.data.requestId).to.equal('123')
+      expect(bidderRequest.data.requestId).to.not.equal(undefined)
       expect(bidderRequest.data.referer).to.equal('http://test.com/path.html')
       expect(bidderRequest.data.schain).to.deep.contains({ ver: '1.0', complete: 1, nodes: [{ asi: 'alkimi-onboarding.com', sid: '00001', hp: 1 }] })
-      expect(bidderRequest.data.signRequest.bids).to.deep.contains({ token: 'e64782a4-8e68-4c38-965b-80ccf115d46f', pos: 7, bidFloor: 0.1, sizes: [{width: 300, height: 250}], playerSizes: [], impMediaTypes: ['Banner'], adUnitCode: 'bannerAdUnitCode' })
+      expect(bidderRequest.data.signRequest.bids).to.deep.contains({ token: 'e64782a4-8e68-4c38-965b-80ccf115d46f', bidFloor: 0.1, sizes: [{ width: 300, height: 250 }], playerSizes: [], impMediaTypes: ['Banner'], adUnitCode: 'bannerAdUnitCode', instl: undefined, exp: undefined, banner: { sizes: [[300, 250]] }, video: undefined })
       expect(bidderRequest.data.signRequest.randomUUID).to.equal(undefined)
       expect(bidderRequest.data.bidIds).to.deep.contains('456')
       expect(bidderRequest.data.signature).to.equal(undefined)