prebid.js 8.43.0 → 8.45.0

package/test/spec/native_spec.js

@@ -16,7 +16,7 @@ import {
   fireClickTrackers,
   setNativeResponseProperties,
 } from 'src/native.js';
-import CONSTANTS from 'src/constants.json';
+import { NATIVE_KEYS } from 'src/constants.js';
 import { stubAuctionIndex } from '../helpers/indexStub.js';
 import { convertOrtbRequestToProprietaryNative, fromOrtbNativeRequest } from '../../src/native.js';
 import {auctionManager} from '../../src/auctionManager.js';
@@ -199,9 +199,9 @@ describe('native.js', function () {
 
   it('gets native targeting keys', function () {
     const targeting = getNativeTargeting(bid);
-    expect(targeting[CONSTANTS.NATIVE_KEYS.title]).to.equal(bid.native.title);
-    expect(targeting[CONSTANTS.NATIVE_KEYS.body]).to.equal(bid.native.body);
-    expect(targeting[CONSTANTS.NATIVE_KEYS.clickUrl]).to.equal(
+    expect(targeting[NATIVE_KEYS.title]).to.equal(bid.native.title);
+    expect(targeting[NATIVE_KEYS.body]).to.equal(bid.native.body);
+    expect(targeting[NATIVE_KEYS.clickUrl]).to.equal(
       bid.native.clickUrl
     );
     expect(targeting.hb_native_foo).to.equal(bid.native.foo);
@@ -230,11 +230,11 @@ describe('native.js', function () {
     };
     const targeting = getNativeTargeting(bid, deps(adUnit));
 
-    expect(targeting[CONSTANTS.NATIVE_KEYS.title]).to.equal(bid.native.title);
-    expect(targeting[CONSTANTS.NATIVE_KEYS.body]).to.equal(
+    expect(targeting[NATIVE_KEYS.title]).to.equal(bid.native.title);
+    expect(targeting[NATIVE_KEYS.body]).to.equal(
       'hb_native_body:123'
     );
-    expect(targeting[CONSTANTS.NATIVE_KEYS.clickUrl]).to.equal(
+    expect(targeting[NATIVE_KEYS.clickUrl]).to.equal(
       'hb_native_linkurl:123'
     );
     expect(targeting.hb_native_foo).to.equal(bid.native.ext.foo);
@@ -244,9 +244,9 @@ describe('native.js', function () {
   it('sends placeholdes targetings with ortb native response', function () {
     const targeting = getNativeTargeting(completeNativeBid);
 
-    expect(targeting[CONSTANTS.NATIVE_KEYS.title]).to.equal('Native Creative');
-    expect(targeting[CONSTANTS.NATIVE_KEYS.body]).to.equal('Cool description great stuff');
-    expect(targeting[CONSTANTS.NATIVE_KEYS.clickUrl]).to.equal('https://www.link.example');
+    expect(targeting[NATIVE_KEYS.title]).to.equal('Native Creative');
+    expect(targeting[NATIVE_KEYS.body]).to.equal('Cool description great stuff');
+    expect(targeting[NATIVE_KEYS.clickUrl]).to.equal('https://www.link.example');
   });
 
   it('should only include native targeting keys with values', function () {
@@ -269,9 +269,9 @@ describe('native.js', function () {
     const targeting = getNativeTargeting(bidWithUndefinedFields, deps(adUnit));
 
     expect(Object.keys(targeting)).to.deep.equal([
-      CONSTANTS.NATIVE_KEYS.title,
-      CONSTANTS.NATIVE_KEYS.sponsoredBy,
-      CONSTANTS.NATIVE_KEYS.clickUrl,
+      NATIVE_KEYS.title,
+      NATIVE_KEYS.sponsoredBy,
+      NATIVE_KEYS.clickUrl,
       'hb_native_foo',
     ]);
   });
@@ -294,7 +294,7 @@ describe('native.js', function () {
     };
     const targeting = getNativeTargeting(bid, deps(adUnit));
 
-    expect(Object.keys(targeting)).to.deep.equal([CONSTANTS.NATIVE_KEYS.title]);
+    expect(Object.keys(targeting)).to.deep.equal([NATIVE_KEYS.title]);
   });
 
   it('should only include targeting if sendTargetingKeys not set to false', function () {
@@ -342,10 +342,10 @@ describe('native.js', function () {
     const targeting = getNativeTargeting(bid, deps(adUnit));
 
     expect(Object.keys(targeting)).to.deep.equal([
-      CONSTANTS.NATIVE_KEYS.title,
-      CONSTANTS.NATIVE_KEYS.body,
-      CONSTANTS.NATIVE_KEYS.image,
-      CONSTANTS.NATIVE_KEYS.clickUrl,
+      NATIVE_KEYS.title,
+      NATIVE_KEYS.body,
+      NATIVE_KEYS.image,
+      NATIVE_KEYS.clickUrl,
       'hb_native_foo',
     ]);
   });
@@ -353,7 +353,7 @@ describe('native.js', function () {
   it('should include rendererUrl in targeting', function () {
     const rendererUrl = 'https://www.renderer.com/';
     const targeting = getNativeTargeting({...bid, native: {...bid.native, rendererUrl: {url: rendererUrl}}}, deps({}));
-    expect(targeting[CONSTANTS.NATIVE_KEYS.rendererUrl]).to.eql(rendererUrl);
+    expect(targeting[NATIVE_KEYS.rendererUrl]).to.eql(rendererUrl);
   });
 
   it('fires impression trackers', function () {

package/test/spec/unit/adRendering_spec.js

@@ -7,7 +7,7 @@ import {
   handleNativeMessage,
   handleRender
 } from '../../../src/adRendering.js';
-import CONSTANTS from 'src/constants.json';
+import { AD_RENDER_FAILED_REASON, BID_STATUS, EVENTS } from 'src/constants.js';
 import {expect} from 'chai/index.mjs';
 import {config} from 'src/config.js';
 import {VIDEO} from '../../../src/mediaTypes.js';
@@ -65,7 +65,7 @@ describe('adRendering', () => {
     });
 
     function expectAdRenderFailedEvent(reason) {
-      sinon.assert.calledWith(events.emit, CONSTANTS.EVENTS.AD_RENDER_FAILED, sinon.match({adId, reason}));
+      sinon.assert.calledWith(events.emit, EVENTS.AD_RENDER_FAILED, sinon.match({ adId, reason }));
     }
 
     describe('doRender', () => {
@@ -103,7 +103,7 @@ describe('adRendering', () => {
 
         it('emits AD_RENDER_SUCCEDED', () => {
           doRender({renderFn, bidResponse});
-          sinon.assert.calledWith(events.emit, CONSTANTS.EVENTS.AD_RENDER_SUCCEEDED, sinon.match({
+          sinon.assert.calledWith(events.emit, EVENTS.AD_RENDER_SUCCEEDED, sinon.match({
             bid: bidResponse,
             adId: bidResponse.adId
           }));
@@ -114,7 +114,7 @@ describe('adRendering', () => {
         it('should emit AD_RENDER_FAILED on video bids', () => {
           bidResponse.mediaType = VIDEO;
           doRender({renderFn, bidResponse});
-          expectAdRenderFailedEvent(CONSTANTS.AD_RENDER_FAILED_REASON.PREVENT_WRITING_ON_MAIN_DOCUMENT)
+          expectAdRenderFailedEvent(AD_RENDER_FAILED_REASON.PREVENT_WRITING_ON_MAIN_DOCUMENT)
         });
       }
 
@@ -159,26 +159,26 @@ describe('adRendering', () => {
       describe('should emit AD_RENDER_FAILED', () => {
         it('when bidResponse is missing', () => {
           handleRender({adId});
-          expectAdRenderFailedEvent(CONSTANTS.AD_RENDER_FAILED_REASON.CANNOT_FIND_AD);
+          expectAdRenderFailedEvent(AD_RENDER_FAILED_REASON.CANNOT_FIND_AD);
           sinon.assert.notCalled(doRenderStub);
         });
         it('on exceptions', () => {
           doRenderStub.throws(new Error());
           handleRender({adId, bidResponse});
-          expectAdRenderFailedEvent(CONSTANTS.AD_RENDER_FAILED_REASON.EXCEPTION);
+          expectAdRenderFailedEvent(AD_RENDER_FAILED_REASON.EXCEPTION);
         });
       })
 
       describe('when bid was already rendered', () => {
         beforeEach(() => {
-          bidResponse.status = CONSTANTS.BID_STATUS.RENDERED;
+          bidResponse.status = BID_STATUS.RENDERED;
         });
         afterEach(() => {
           config.resetConfig();
         })
         it('should emit STALE_RENDER', () => {
           handleRender({adId, bidResponse});
-          sinon.assert.calledWith(events.emit, CONSTANTS.EVENTS.STALE_RENDER, bidResponse);
+          sinon.assert.calledWith(events.emit, EVENTS.STALE_RENDER, bidResponse);
           sinon.assert.called(doRenderStub);
         });
         it('should skip rendering if suppressStaleRender', () => {
@@ -190,7 +190,7 @@ describe('adRendering', () => {
 
       it('should mark bid as won and emit BID_WON', () => {
         handleRender({renderFn, bidResponse});
-        sinon.assert.calledWith(events.emit, CONSTANTS.EVENTS.BID_WON, bidResponse);
+        sinon.assert.calledWith(events.emit, EVENTS.BID_WON, bidResponse);
         sinon.assert.calledWith(auctionManager.addWinningBid, bidResponse);
       })
     })
@@ -201,17 +201,17 @@ describe('adRendering', () => {
     beforeEach(() => {
       sandbox.stub(events, 'emit');
       bid = {
-        status: CONSTANTS.BID_STATUS.RENDERED
+        status: BID_STATUS.RENDERED
       }
     });
     it('emits AD_RENDER_FAILED with given reason', () => {
-      handleCreativeEvent({event: CONSTANTS.EVENTS.AD_RENDER_FAILED, info: {reason: 'reason', message: 'message'}}, bid);
-      sinon.assert.calledWith(events.emit, CONSTANTS.EVENTS.AD_RENDER_FAILED, sinon.match({bid, reason: 'reason', message: 'message'}));
+      handleCreativeEvent({ event: EVENTS.AD_RENDER_FAILED, info: { reason: 'reason', message: 'message' } }, bid);
+      sinon.assert.calledWith(events.emit, EVENTS.AD_RENDER_FAILED, sinon.match({ bid, reason: 'reason', message: 'message' }));
     });
 
     it('emits AD_RENDER_SUCCEEDED', () => {
-      handleCreativeEvent({event: CONSTANTS.EVENTS.AD_RENDER_SUCCEEDED}, bid);
-      sinon.assert.calledWith(events.emit, CONSTANTS.EVENTS.AD_RENDER_SUCCEEDED, sinon.match({bid}));
+      handleCreativeEvent({ event: EVENTS.AD_RENDER_SUCCEEDED }, bid);
+      sinon.assert.calledWith(events.emit, EVENTS.AD_RENDER_SUCCEEDED, sinon.match({ bid }));
     });
 
     it('logs an error on other events', () => {

package/test/spec/unit/adUnits_spec.js

@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-import { adunitCounter } from 'src/adUnits.js';
+import * as adunitCounter from 'src/adUnits.js';
 
 describe('Adunit Counter', function () {
   const ADUNIT_ID_1 = 'test1';

package/test/spec/unit/core/adapterManager_spec.js

@@ -12,7 +12,7 @@ import {
   getServerTestingsAds,
   getBidRequests
 } from 'test/fixtures/fixtures.js';
-import CONSTANTS from 'src/constants.json';
+import { EVENTS, S2S } from 'src/constants.js';
 import * as utils from 'src/utils.js';
 import { config } from 'src/config.js';
 import { registerBidder } from 'src/adapters/bidderFactory.js';
@@ -24,11 +24,13 @@ import {auctionManager} from '../../../../src/auctionManager.js';
 import {GDPR_GVLIDS} from '../../../../src/consentHandler.js';
 import {MODULE_TYPE_ANALYTICS, MODULE_TYPE_BIDDER} from '../../../../src/activities/modules.js';
 import {ACTIVITY_FETCH_BIDS, ACTIVITY_REPORT_ANALYTICS} from '../../../../src/activities/activities.js';
+import {reset as resetAdUnitCounters} from '../../../../src/adUnits.js';
+import {deepClone} from 'src/utils.js';
 var events = require('../../../../src/events');
 
 const CONFIG = {
   enabled: true,
-  endpoint: CONSTANTS.S2S.DEFAULT_ENDPOINT,
+  endpoint: S2S.DEFAULT_ENDPOINT,
   timeout: 1000,
   maxBids: 1,
   adapter: 'prebidServer',
@@ -172,7 +174,7 @@ describe('adapterManager tests', function () {
       // function to count BID_REQUESTED events
       let cnt = 0;
       let count = () => cnt++;
-      events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
+      events.on(EVENTS.BID_REQUESTED, count);
       let bidRequests = [{
         'bidderCode': 'appnexus',
         'auctionId': '1863e370099523',
@@ -207,7 +209,7 @@ describe('adapterManager tests', function () {
       adapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
       expect(cnt).to.equal(1);
       sinon.assert.calledOnce(appnexusAdapterMock.callBids);
-      events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
+      events.off(EVENTS.BID_REQUESTED, count);
     });
 
     it('should give bidders access to bidder-specific config', function(done) {
@@ -390,7 +392,7 @@ describe('adapterManager tests', function () {
       });
 
       it('should NOT call onBidWon when the bid is S2S', () => {
-        bids[0].src = CONSTANTS.S2S.SRC
+        bids[0].src = S2S.SRC
         adapterManager.callBidWonBidder(bids[0].bidder, bids[0], adUnits);
         sinon.assert.notCalled(criteoSpec.onBidWon);
       })
@@ -407,7 +409,7 @@ describe('adapterManager tests', function () {
       });
 
       it('should NOT call onSetTargeting when bid is S2S', () => {
-        bids[0].src = CONSTANTS.S2S.SRC;
+        bids[0].src = S2S.SRC;
         adapterManager.callSetTargetingBidder(bids[0].bidder, bids[0], adUnits);
         sinon.assert.notCalled(criteoSpec.onSetTargeting);
       })
@@ -421,7 +423,7 @@ describe('adapterManager tests', function () {
         sinon.assert.called(criteoSpec.onBidViewable);
       });
       it('should NOT call onBidViewable when bid is S2S', () => {
-        bids[0].src = CONSTANTS.S2S.SRC;
+        bids[0].src = S2S.SRC;
         adapterManager.callBidViewableBidder(bids[0].bidder, bids[0]);
         sinon.assert.notCalled(criteoSpec.onBidViewable);
       })
@@ -649,11 +651,11 @@ describe('adapterManager tests', function () {
       beforeEach(function () {
         prebidServerAdapterMock.callBids.reset();
         cnt = 0;
-        events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
+        events.on(EVENTS.BID_REQUESTED, count);
       });
 
       afterEach(function () {
-        events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
+        events.off(EVENTS.BID_REQUESTED, count);
       });
 
       it('should fire for s2s requests', function () {
@@ -1037,11 +1039,11 @@ describe('adapterManager tests', function () {
       beforeEach(function () {
         prebidServerAdapterMock.callBids.reset();
         cnt = 0;
-        events.on(CONSTANTS.EVENTS.BID_REQUESTED, count);
+        events.on(EVENTS.BID_REQUESTED, count);
       });
 
       afterEach(function () {
-        events.off(CONSTANTS.EVENTS.BID_REQUESTED, count);
+        events.off(EVENTS.BID_REQUESTED, count);
       });
 
       it('should fire for s2s requests', function () {
@@ -1675,12 +1677,24 @@ describe('adapterManager tests', function () {
   describe('makeBidRequests', function () {
     let adUnits;
     beforeEach(function () {
+      resetAdUnitCounters();
       adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
         adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus', 'rubicon'], bid.bidder));
         return adUnit;
       })
     });
 
+    function makeBidRequests(au = adUnits) {
+      return adapterManager.makeBidRequests(
+        au,
+        Date.now(),
+        utils.getUniqueIdentifierStr(),
+        function callback() {
+        },
+        []
+      );
+    }
+
     if (FEATURES.NATIVE) {
       it('should add nativeParams to adUnits after BEFORE_REQUEST_BIDS', () => {
         function beforeReqBids(adUnits) {
@@ -1691,16 +1705,9 @@ describe('adapterManager tests', function () {
           })
         }
 
-        events.on(CONSTANTS.EVENTS.BEFORE_REQUEST_BIDS, beforeReqBids);
-        adapterManager.makeBidRequests(
-          adUnits,
-          Date.now(),
-          utils.getUniqueIdentifierStr(),
-          function callback() {
-          },
-          []
-        );
-        events.off(CONSTANTS.EVENTS.BEFORE_REQUEST_BIDS, beforeReqBids);
+        events.on(EVENTS.BEFORE_REQUEST_BIDS, beforeReqBids);
+        makeBidRequests();
+        events.off(EVENTS.BEFORE_REQUEST_BIDS, beforeReqBids);
         expect(adUnits.map((u) => u.nativeParams).some(i => i == null)).to.be.false;
       });
     }
@@ -1708,13 +1715,7 @@ describe('adapterManager tests', function () {
     it('should make separate bidder request objects for each bidder', () => {
       adUnits = [utils.deepClone(getAdUnits()[0])];
 
-      let bidRequests = adapterManager.makeBidRequests(
-        adUnits,
-        Date.now(),
-        utils.getUniqueIdentifierStr(),
-        function callback() {},
-        []
-      );
+      let bidRequests = makeBidRequests();
 
       let sizes1 = bidRequests[1].bids[0].sizes;
       let sizes2 = bidRequests[0].bids[0].sizes;
@@ -1725,6 +1726,70 @@ describe('adapterManager tests', function () {
       expect(sizes1).not.to.deep.equal(sizes2);
     });
 
+    it('should set and increment bidRequestsCounter', () => {
+      const [au1, au2] = adUnits;
+      makeBidRequests([au1, au2]).flatMap(br => br.bids).forEach(bid => {
+        expect(bid.bidRequestsCount).to.eql(1);
+      })
+      makeBidRequests([au1]);
+      makeBidRequests([au1, au2]).flatMap(br => br.bids).forEach(bid => {
+        expect(bid.bidRequestsCount).to.eql(bid.adUnitCode === au1.code ? 3 : 2);
+      });
+    })
+
+    describe('bidderRequestsCounter', () => {
+      it('should be set and incremented', () => {
+        const [au1, au2] = adUnits;
+        makeBidRequests([au1, au2]).flatMap(br => br.bids).forEach(bid => {
+          expect(bid.bidderRequestsCount).to.eql(1);
+        });
+        const au3 = {
+          ...au2,
+          bids: [
+            au2.bids[0]
+          ]
+        }
+        makeBidRequests([au3]);
+        const counts = Object.fromEntries(
+          makeBidRequests([au1, au2])
+            .map(br => [br.bidderCode, Object.fromEntries(br.bids.map(bid => [bid.adUnitCode, bid.bidderRequestsCount]))])
+        );
+        expect(counts).to.eql({
+          rubicon: {
+            [au2.code]: 2
+          },
+          appnexus: {
+            [au1.code]: 2,
+            [au2.code]: 3
+          },
+        });
+      });
+
+      it('should NOT be incremented for s2s bids', () => {
+        config.setConfig({
+          s2sConfig: {
+            enabled: true,
+            adapter: 'rubicon',
+            bidders: ['appnexus']
+          }
+        });
+        function expectBidderCounts(bidders) {
+          makeBidRequests().forEach(br => {
+            br.bids.forEach(bid => expect(bid.bidderRequestsCount).to.exist.and.eql(bidders[br.bidderCode]));
+          })
+        }
+        expectBidderCounts({
+          appnexus: 0,
+          rubicon: 1
+        });
+        config.resetConfig();
+        expectBidderCounts({
+          appnexus: 1,
+          rubicon: 2
+        })
+      })
+    });
+
     describe('and activity controls', () => {
       let redactOrtb2;
       let redactBidRequest;
@@ -1757,13 +1822,7 @@ describe('adapterManager tests', function () {
             componentType === MODULE_TYPE_BIDDER &&
             allowed.includes(componentName);
         });
-        let reqs = adapterManager.makeBidRequests(
-          adUnits,
-          Date.now(),
-          utils.getUniqueIdentifierStr(),
-          function callback() {},
-          []
-        );
+        let reqs = makeBidRequests();
         const bidders = Array.from(new Set(reqs.flatMap(br => br.bids).map(bid => bid.bidder)).keys());
         expect(bidders).to.have.members(allowed);
       });
@@ -1773,13 +1832,7 @@ describe('adapterManager tests', function () {
         adUnits = [
           {code: 'one', bids: [{bidder: 'mockBidder1'}]}
         ];
-        let reqs = adapterManager.makeBidRequests(
-          adUnits,
-          Date.now(),
-          utils.getUniqueIdentifierStr(),
-          function callback() {},
-          []
-        );
+        let reqs = makeBidRequests();
         sinon.assert.calledWith(redactBidRequest, reqs[0].bids[0]);
         sinon.assert.calledWith(redactOrtb2, reqs[0].ortb2);
       })
@@ -1812,13 +1865,7 @@ describe('adapterManager tests', function () {
             {code: 'two', bids: [{module: 'pbsBidAdapter', params: {configName: 'mock1'}}, {module: 'pbsBidAdapter', params: {configName: 'mock2'}}]}
           ]
           dep.isAllowed.callsFake(({componentType}) => componentType !== 'bidder');
-          let bidRequests = adapterManager.makeBidRequests(
-            adUnits,
-            Date.now(),
-            utils.getUniqueIdentifierStr(),
-            function callback() {},
-            []
-          );
+          let bidRequests = makeBidRequests();
           expect(new Set(bidRequests.map(br => br.uniquePbsTid)).size).to.equal(3);
         });
 
@@ -1835,14 +1882,7 @@ describe('adapterManager tests', function () {
             }
           ];
           dep.isAllowed.callsFake((_, {configName, componentName}) => !(componentName === 'pbsBidAdapter' && configName === 'mock1'));
-          let bidRequests = adapterManager.makeBidRequests(
-            adUnits,
-            Date.now(),
-            utils.getUniqueIdentifierStr(),
-            function callback() {
-            },
-            []
-          );
+          let bidRequests = makeBidRequests();
           expect(new Set(bidRequests.map(br => br.uniquePbsTid)).size).to.eql(2)
         });
       });
@@ -2075,11 +2115,11 @@ describe('adapterManager tests', function () {
         const ortb2Fragments = {};
         const req = {
           bidderCode: 'appnexus',
-          src: CONSTANTS.S2S.SRC,
+          src: S2S.SRC,
           adUnitsS2SCopy: adUnits,
           bids: [{
             bidder: 'appnexus',
-            src: CONSTANTS.S2S.SRC
+            src: S2S.SRC
           }]
         };
         adapterManager.callBids(adUnits, [req], sinon.stub(), sinon.stub(), {request: sinon.stub(), done: sinon.stub()}, 1000, sinon.stub(), ortb2Fragments);

package/test/spec/unit/core/bidderFactory_spec.js

@@ -5,7 +5,7 @@ import {expect} from 'chai';
 import {userSync} from 'src/userSync.js';
 import * as utils from 'src/utils.js';
 import {config} from 'src/config.js';
-import CONSTANTS from 'src/constants.json';
+import { EVENTS } from 'src/constants.js';
 import * as events from 'src/events.js';
 import {hook} from '../../../../src/hook.js';
 import {auctionManager} from '../../../../src/auctionManager.js';
@@ -552,7 +552,7 @@ describe('bidderFactory', () => {
 
         expect(ajaxStub.calledTwice).to.equal(true);
         expect(eventEmitterSpy.getCalls()
-          .filter(call => call.args[0] === CONSTANTS.EVENTS.BEFORE_BIDDER_HTTP)
+          .filter(call => call.args[0] === EVENTS.BEFORE_BIDDER_HTTP)
         ).to.length(2);
 
         eventEmitterSpy.restore();
@@ -863,7 +863,7 @@ describe('bidderFactory', () => {
         expect(callBidderErrorStub.firstCall.args[0]).to.equal(CODE);
         expect(callBidderErrorStub.firstCall.args[1]).to.equal(xhrErrorMock);
         expect(callBidderErrorStub.firstCall.args[2]).to.equal(MOCK_BIDS_REQUEST);
-        sinon.assert.calledWith(eventEmitterStub, CONSTANTS.EVENTS.BIDDER_ERROR, {
+        sinon.assert.calledWith(eventEmitterStub, EVENTS.BIDDER_ERROR, {
           error: xhrErrorMock,
           bidderRequest: MOCK_BIDS_REQUEST
         });
@@ -889,7 +889,7 @@ describe('bidderFactory', () => {
         expect(callBidderErrorStub.firstCall.args[0]).to.equal(CODE);
         expect(callBidderErrorStub.firstCall.args[1]).to.equal(xhrErrorMock);
         expect(callBidderErrorStub.firstCall.args[2]).to.equal(MOCK_BIDS_REQUEST);
-        sinon.assert.calledWith(eventEmitterStub, CONSTANTS.EVENTS.BIDDER_ERROR, {
+        sinon.assert.calledWith(eventEmitterStub, EVENTS.BIDDER_ERROR, {
           error: xhrErrorMock,
           bidderRequest: MOCK_BIDS_REQUEST
         });
@@ -915,7 +915,7 @@ describe('bidderFactory', () => {
         expect(callBidderErrorStub.firstCall.args[0]).to.equal(CODE);
         expect(callBidderErrorStub.firstCall.args[1]).to.equal(xhrErrorMock);
         expect(callBidderErrorStub.firstCall.args[2]).to.equal(MOCK_BIDS_REQUEST);
-        sinon.assert.calledWith(eventEmitterStub, CONSTANTS.EVENTS.BIDDER_ERROR, {
+        sinon.assert.calledWith(eventEmitterStub, EVENTS.BIDDER_ERROR, {
           error: xhrErrorMock,
           bidderRequest: MOCK_BIDS_REQUEST
         });
@@ -941,7 +941,7 @@ describe('bidderFactory', () => {
         expect(callBidderErrorStub.firstCall.args[0]).to.equal(CODE);
         expect(callBidderErrorStub.firstCall.args[1]).to.equal(xhrErrorMock);
         expect(callBidderErrorStub.firstCall.args[2]).to.equal(MOCK_BIDS_REQUEST);
-        sinon.assert.calledWith(eventEmitterStub, CONSTANTS.EVENTS.BIDDER_ERROR, {
+        sinon.assert.calledWith(eventEmitterStub, EVENTS.BIDDER_ERROR, {
           error: xhrErrorMock,
           bidderRequest: MOCK_BIDS_REQUEST
         });