prebid.js 8.4.0 → 8.5.0

package/test/spec/modules/sspBCBidAdapter_spec.js

@@ -38,7 +38,7 @@ describe('SSPBC adapter', function () {
       },
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     },
     {
@@ -60,7 +60,7 @@ describe('SSPBC adapter', function () {
       },
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '2',
+      bidId: bidderRequestId + '2',
       transactionId,
     }
     ];
@@ -83,7 +83,7 @@ describe('SSPBC adapter', function () {
       ],
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     };
     const bid_native = {
@@ -122,7 +122,7 @@ describe('SSPBC adapter', function () {
       ],
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     };
     const bid_video = {
@@ -144,7 +144,7 @@ describe('SSPBC adapter', function () {
       ],
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     };
     const bids_timeouted = [{
@@ -155,7 +155,7 @@ describe('SSPBC adapter', function () {
         siteId: '8816',
       }],
       auctionId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       timeout: 100,
     },
     {
@@ -166,7 +166,7 @@ describe('SSPBC adapter', function () {
         siteId: '8816',
       }],
       auctionId,
-      bidId: auctionId + '2',
+      bidId: bidderRequestId + '2',
       timeout: 100,
     }
     ];
@@ -198,7 +198,7 @@ describe('SSPBC adapter', function () {
       },
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     }];
     const bidRequest = {
@@ -293,7 +293,7 @@ describe('SSPBC adapter', function () {
     };
     const serverResponse = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
@@ -333,7 +333,7 @@ describe('SSPBC adapter', function () {
     };
     const serverResponseSingle = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
@@ -358,11 +358,11 @@ describe('SSPBC adapter', function () {
     };
     const serverResponseOneCode = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
-            'impid': 'bidid-' + auctionId + '1',
+            'impid': 'bidid-' + bidderRequestId + '1',
             'price': 1,
             'adid': 'lxHWkB7OnZeso3QiN1N4',
             'nurl': '',
@@ -385,11 +385,11 @@ describe('SSPBC adapter', function () {
     };
     const serverResponseVideo = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
-            'impid': 'bidid-' + auctionId + '1',
+            'impid': 'bidid-' + bidderRequestId + '1',
             'price': 1,
             'adid': 'lxHWkB7OnZeso3QiN1N4',
             'nurl': '',
@@ -413,11 +413,11 @@ describe('SSPBC adapter', function () {
     };
     const serverResponseNative = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
-            'impid': 'bidid-' + auctionId + '1',
+            'impid': 'bidid-' + bidderRequestId + '1',
             'price': 1,
             'adid': 'lxHWkB7OnZeso3QiN1N4',
             'nurl': '',
@@ -438,7 +438,7 @@ describe('SSPBC adapter', function () {
     };
     const emptyResponse = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
       }
     }
     return {
@@ -696,7 +696,7 @@ describe('SSPBC adapter', function () {
 
       let notificationPayload = spec.onBidWon(bid);
       expect(notificationPayload).to.have.property('event').that.equals('bidWon');
-      expect(notificationPayload).to.have.property('requestId').that.equals(bid.auctionId);
+      expect(notificationPayload).to.have.property('requestId').that.equals(bid.bidderRequestId);
       expect(notificationPayload).to.have.property('tagid').that.deep.equals([bid.adUnitCode]);
       expect(notificationPayload).to.have.property('siteId').that.is.an('array');
       expect(notificationPayload).to.have.property('slotId').that.is.an('array');
@@ -717,7 +717,6 @@ describe('SSPBC adapter', function () {
       let notificationPayload = spec.onTimeout(bids_timeouted);
 
       expect(notificationPayload).to.have.property('event').that.equals('timeout');
-      expect(notificationPayload).to.have.property('requestId').that.equals(bids_timeouted[0].auctionId);
       expect(notificationPayload).to.have.property('tagid').that.deep.equals([bids_timeouted[0].adUnitCode, bids_timeouted[1].adUnitCode]);
     });
   });

package/test/spec/modules/tripleliftBidAdapter_spec.js

@@ -1130,6 +1130,46 @@ describe('triplelift adapter', function () {
 
       expect(logErrorSpy.calledOnce).to.equal(true);
     });
+    it('should add ortb2 ext object if global fpd is available', function() {
+      const ortb2 = {
+        site: {
+          domain: 'page.example.com',
+          cat: ['IAB2'],
+          sectioncat: ['IAB2-2'],
+          pagecat: ['IAB2-2'],
+          page: 'https://page.example.com/here.html',
+        },
+        user: {
+          yob: 1985,
+          gender: 'm',
+          keywords: 'a,b',
+          data: [
+            {
+              name: 'dataprovider.com',
+              ext: { segtax: 4 },
+              segment: [{ id: '1' }]
+            }
+          ],
+          ext: {
+            data: {
+              registered: true,
+              interests: ['cars']
+            }
+          }
+        }
+      };
+
+      const request = tripleliftAdapterSpec.buildRequests(bidRequests, {...bidderRequest, ortb2});
+      const { data: payload } = request;
+      expect(payload.ext.ortb2).to.exist;
+      expect(payload.ext.ortb2.site).to.deep.equal({
+        domain: 'page.example.com',
+        cat: ['IAB2'],
+        sectioncat: ['IAB2-2'],
+        pagecat: ['IAB2-2'],
+        page: 'https://page.example.com/here.html',
+      });
+    });
     it('should send global config fpd if kvps are available', function() {
       const sens = null;
       const category = ['news', 'weather', 'hurricane'];

package/test/spec/modules/userId_spec.js

@@ -12,7 +12,7 @@ import {
   setSubmoduleRegistry,
   syncDelay,
 } from 'modules/userId/index.js';
-import {createEidsArray} from 'modules/userId/eids.js';
+import {createEidsArray, EID_CONFIG} from 'modules/userId/eids.js';
 import {config} from 'src/config.js';
 import * as utils from 'src/utils.js';
 import {getPrebidInternal} from 'src/utils.js';
@@ -86,7 +86,7 @@ describe('User ID', function () {
     }
   }
 
-  function createMockIdSubmodule(name, value, aliasName) {
+  function createMockIdSubmodule(name, value, aliasName, eids) {
     return {
       name,
       getId() {
@@ -95,7 +95,8 @@ describe('User ID', function () {
       decode(v) {
         return v;
       },
-      aliasName
+      aliasName,
+      eids
     }
   }
 
@@ -594,6 +595,50 @@ describe('User ID', function () {
       });
     });
 
+    describe('EID updateConfig', () => {
+      function mockSubmod(name, eids) {
+        return createMockIdSubmodule(name, null, null, eids);
+      }
+
+      it('does not choke if a submod does not provide an eids map', () => {
+        setSubmoduleRegistry([
+          mockSubmod('mock1'),
+          mockSubmod('mock2')
+        ]);
+        expect(EID_CONFIG.size).to.equal(0);
+      });
+
+      it('should merge together submodules\' eid configs', () => {
+        setSubmoduleRegistry([
+          mockSubmod('mock1', {mock1: {m: 1}}),
+          mockSubmod('mock2', {mock2: {m: 2}})
+        ]);
+        expect(EID_CONFIG.get('mock1')).to.eql({m: 1});
+        expect(EID_CONFIG.get('mock2')).to.eql({m: 2});
+      });
+
+      it('should respect idPriority', () => {
+        config.setConfig({
+          userSync: {
+            idPriority: {
+              m1: ['mod2', 'mod1'],
+              m2: ['mod1', 'mod2']
+            },
+            userIds: [
+              { name: 'mod1' },
+              { name: 'mod2' },
+            ]
+          }
+        });
+        setSubmoduleRegistry([
+          mockSubmod('mod1', {m1: {i: 1}, m2: {i: 2}}),
+          mockSubmod('mod2', {m1: {i: 3}, m2: {i: 4}})
+        ]);
+        expect(EID_CONFIG.get('m1')).to.eql({i: 3});
+        expect(EID_CONFIG.get('m2')).to.eql({i: 2});
+      });
+    })
+
     it('should set googletag ppid correctly', function () {
       let adUnits = [getAdUnitMock()];
       init(config);
@@ -626,7 +671,25 @@ describe('User ID', function () {
         // some of the ids are padded to have length >= 32 characters
         createMockIdSubmodule('mockId1Module', {id: {uid2: {id: 'uid2_value_7ac66c0f148de9519b8bd264312c4d64'}}}),
         createMockIdSubmodule('mockId2Module', {id: {pubcid: 'pubcid_value_7ac66c0f148de9519b8bd264312c4d64', lipb: {lipbid: 'lipbid_value_from_mockId2Module_7ac66c0f148de9519b8bd264312c4d64'}}}),
-        createMockIdSubmodule('mockId3Module', {id: {uid2: {id: 'uid2_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64'}, pubcid: 'pubcid_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64', lipb: {lipbid: 'lipbid_value_7ac66c0f148de9519b8bd264312c4d64'}, merkleId: {id: 'merkleId_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64'}}}),
+        createMockIdSubmodule('mockId3Module', {
+          id: {
+            uid2: {
+              id: 'uid2_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64'
+            },
+            pubcid: 'pubcid_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64',
+            lipb: {
+              lipbid: 'lipbid_value_7ac66c0f148de9519b8bd264312c4d64'
+            },
+            merkleId: {
+              id: 'merkleId_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64'
+            }
+          }
+        }, null, {
+          uid2: {
+            source: 'uidapi.com',
+            getValue(data) { return data.id }
+          }
+        }),
         createMockIdSubmodule('mockId4Module', {id: {merkleId: {id: 'merkleId_value_7ac66c0f148de9519b8bd264312c4d64'}}})
       ]);
 
@@ -717,6 +780,11 @@ describe('User ID', function () {
         },
         decode(d) {
           return d
+        },
+        eids: {
+          pubcid: {
+            source: 'pubcid.org',
+          }
         }
       }]);
       config.setConfig({
@@ -808,7 +876,25 @@ describe('User ID', function () {
         // some of the ids are padded to have length >= 32 characters
         createMockIdSubmodule('mockId1Module', {id: {uid2: {id: 'uid2_value_7ac66c0f148de9519b8bd264312c4d64'}}}),
         createMockIdSubmodule('mockId2Module', {id: {pubcid: 'pubcid_value_7ac66c0f148de9519b8bd264312c4d64', lipb: {lipbid: 'lipbid_value_from_mockId2Module_7ac66c0f148de9519b8bd264312c4d64'}}}),
-        createMockIdSubmodule('mockId3Module', {id: {uid2: {id: 'uid2_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64'}, pubcid: 'pubcid_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64', lipb: {lipbid: 'lipbid_value_7ac66c0f148de9519b8bd264312c4d64'}, merkleId: {id: 'merkleId_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64'}}}),
+        createMockIdSubmodule('mockId3Module', {
+          id: {
+            uid2: {
+              id: 'uid2_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64'
+            },
+            pubcid: 'pubcid_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64',
+            lipb: {
+              lipbid: 'lipbid_value_7ac66c0f148de9519b8bd264312c4d64'
+            },
+            merkleId: {
+              id: 'merkleId_value_from_mockId3Module_7ac66c0f148de9519b8bd264312c4d64'
+            }
+          }
+        }, null, {
+          uid2: {
+            source: 'uidapi.com',
+            getValue(data) { return data.id }
+          }
+        }),
         createMockIdSubmodule('mockId4Module', {id: {merkleId: {id: 'merkleId_value_7ac66c0f148de9519b8bd264312c4d64'}}})
       ]);
 
@@ -3259,8 +3345,31 @@ describe('User ID', function () {
         setSubmoduleRegistry([
           createMockIdSubmodule('mockId1Module', {id: {uid2: {id: 'uid2_value'}}}),
           createMockIdSubmodule('mockId2Module', {id: {pubcid: 'pubcid_value', lipb: {lipbid: 'lipbid_value_from_mockId2Module'}}}),
-          createMockIdSubmodule('mockId3Module', {id: {uid2: {id: 'uid2_value_from_mockId3Module'}, pubcid: 'pubcid_value_from_mockId3Module', lipb: {lipbid: 'lipbid_value'}, merkleId: {id: 'merkleId_value_from_mockId3Module'}}}),
-          createMockIdSubmodule('mockId4Module', {id: {merkleId: {id: 'merkleId_value'}}})
+          createMockIdSubmodule('mockId3Module', {id: {uid2: {id: 'uid2_value_from_mockId3Module'}, pubcid: 'pubcid_value_from_mockId3Module', lipb: {lipbid: 'lipbid_value'}, merkleId: {id: 'merkleId_value_from_mockId3Module'}}}, null, {
+            uid2: {
+              source: 'uidapi.com',
+              getValue(data) {
+                return data.id
+              }
+            },
+            pubcid: {
+              source: 'pubcid.org',
+            },
+            lipb: {
+              source: 'liveintent.com',
+              getValue(data) {
+                return data.lipbid
+              }
+            }
+          }),
+          createMockIdSubmodule('mockId4Module', {id: {merkleId: {id: 'merkleId_value'}}}, null, {
+            merkleId: {
+              source: 'merkleinc.com',
+              getValue(data) {
+                return data.id
+              }
+            }
+          })
         ]);
         config.setConfig({
           userSync: {

package/test/spec/modules/vrtcalBidAdapter_spec.js

@@ -29,7 +29,12 @@ describe('vrtcalBidAdapter', function () {
         'bidderRequestId': 'br0001',
         'auctionId': 'auction0001',
         'userIdAsEids': {},
-        timeout: 435
+        timeout: 435,
+
+        refererInfo: {
+          page: 'page'
+        }
+
       }
     ];
 
@@ -79,9 +84,12 @@ describe('vrtcalBidAdapter', function () {
     });
 
     it('pass 3rd party IDs with the request when present', function () {
-      bidRequests[0].userIdAsEids = createEidsArray({
-        tdid: 'TTD_ID_FROM_USER_ID_MODULE'
-      });
+      bidRequests[0].userIdAsEids = [
+        {
+          source: 'adserver.org',
+          uids: [{id: 'TTD_ID_FROM_USER_ID_MODULE', atype: 1, ext: {rtiPartner: 'TDID'}}]
+        }
+      ];
 
       request = spec.buildRequests(bidRequests);
       expect(request[0].data).to.include(JSON.stringify({ext: {consent: 'gdpr-consent-string', eids: [{source: 'adserver.org', uids: [{id: 'TTD_ID_FROM_USER_ID_MODULE', atype: 1, ext: {rtiPartner: 'TDID'}}]}]}}));