prebid.js 8.3.0 → 8.5.0

package/test/spec/modules/sspBCBidAdapter_spec.js

@@ -38,7 +38,7 @@ describe('SSPBC adapter', function () {
       },
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     },
     {
@@ -60,7 +60,7 @@ describe('SSPBC adapter', function () {
       },
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '2',
+      bidId: bidderRequestId + '2',
       transactionId,
     }
     ];
@@ -83,7 +83,7 @@ describe('SSPBC adapter', function () {
       ],
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     };
     const bid_native = {
@@ -122,7 +122,7 @@ describe('SSPBC adapter', function () {
       ],
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     };
     const bid_video = {
@@ -144,7 +144,7 @@ describe('SSPBC adapter', function () {
       ],
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     };
     const bids_timeouted = [{
@@ -155,7 +155,7 @@ describe('SSPBC adapter', function () {
         siteId: '8816',
       }],
       auctionId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       timeout: 100,
     },
     {
@@ -166,7 +166,7 @@ describe('SSPBC adapter', function () {
         siteId: '8816',
       }],
       auctionId,
-      bidId: auctionId + '2',
+      bidId: bidderRequestId + '2',
       timeout: 100,
     }
     ];
@@ -198,7 +198,7 @@ describe('SSPBC adapter', function () {
       },
       auctionId,
       bidderRequestId,
-      bidId: auctionId + '1',
+      bidId: bidderRequestId + '1',
       transactionId,
     }];
     const bidRequest = {
@@ -293,7 +293,7 @@ describe('SSPBC adapter', function () {
     };
     const serverResponse = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
@@ -333,7 +333,7 @@ describe('SSPBC adapter', function () {
     };
     const serverResponseSingle = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
@@ -358,11 +358,11 @@ describe('SSPBC adapter', function () {
     };
     const serverResponseOneCode = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
-            'impid': 'bidid-' + auctionId + '1',
+            'impid': 'bidid-' + bidderRequestId + '1',
             'price': 1,
             'adid': 'lxHWkB7OnZeso3QiN1N4',
             'nurl': '',
@@ -385,11 +385,11 @@ describe('SSPBC adapter', function () {
     };
     const serverResponseVideo = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
-            'impid': 'bidid-' + auctionId + '1',
+            'impid': 'bidid-' + bidderRequestId + '1',
             'price': 1,
             'adid': 'lxHWkB7OnZeso3QiN1N4',
             'nurl': '',
@@ -413,11 +413,11 @@ describe('SSPBC adapter', function () {
     };
     const serverResponseNative = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
         'seatbid': [{
           'bid': [{
             'id': '3347324c-6889-46d2-a800-ae78a5214c06',
-            'impid': 'bidid-' + auctionId + '1',
+            'impid': 'bidid-' + bidderRequestId + '1',
             'price': 1,
             'adid': 'lxHWkB7OnZeso3QiN1N4',
             'nurl': '',
@@ -438,7 +438,7 @@ describe('SSPBC adapter', function () {
     };
     const emptyResponse = {
       'body': {
-        'id': auctionId,
+        'id': bidderRequestId,
       }
     }
     return {
@@ -696,7 +696,7 @@ describe('SSPBC adapter', function () {
 
       let notificationPayload = spec.onBidWon(bid);
       expect(notificationPayload).to.have.property('event').that.equals('bidWon');
-      expect(notificationPayload).to.have.property('requestId').that.equals(bid.auctionId);
+      expect(notificationPayload).to.have.property('requestId').that.equals(bid.bidderRequestId);
       expect(notificationPayload).to.have.property('tagid').that.deep.equals([bid.adUnitCode]);
       expect(notificationPayload).to.have.property('siteId').that.is.an('array');
       expect(notificationPayload).to.have.property('slotId').that.is.an('array');
@@ -717,7 +717,6 @@ describe('SSPBC adapter', function () {
       let notificationPayload = spec.onTimeout(bids_timeouted);
 
       expect(notificationPayload).to.have.property('event').that.equals('timeout');
-      expect(notificationPayload).to.have.property('requestId').that.equals(bids_timeouted[0].auctionId);
       expect(notificationPayload).to.have.property('tagid').that.deep.equals([bids_timeouted[0].adUnitCode, bids_timeouted[1].adUnitCode]);
     });
   });

package/test/spec/modules/stroeerCoreBidAdapter_spec.js

@@ -3,6 +3,7 @@ import {spec} from 'modules/stroeerCoreBidAdapter.js';
 import * as utils from 'src/utils.js';
 import {BANNER, VIDEO} from '../../../src/mediaTypes.js';
 import {find} from 'src/polyfill.js';
+import sinon from 'sinon';
 
 describe('stroeerCore bid adapter', function () {
   let sandbox;
@@ -51,8 +52,6 @@ describe('stroeerCore bid adapter', function () {
     assert.notProperty(bidObject, 'ad');
   }
 
-  const AUCTION_ID = utils.getUniqueIdentifierStr();
-
   // Vendor user ids and associated data
   const userIds = Object.freeze({
     criteoId: 'criteo-user-id',
@@ -72,7 +71,6 @@ describe('stroeerCore bid adapter', function () {
   });
 
   const buildBidderRequest = () => ({
-    auctionId: AUCTION_ID,
     bidderRequestId: 'bidder-request-id-123',
     bidderCode: 'stroeerCore',
     timeout: 5000,
@@ -394,6 +392,10 @@ describe('stroeerCore bid adapter', function () {
         clock.tick(13500);
         const bidReq = buildBidderRequest();
 
+        const UUID = 'fb6a39e3-083f-424c-9046-f1095e15f3d5';
+
+        const generateUUIDStub = sinon.stub(utils, 'generateUUID').returns(UUID);
+
         const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq);
 
         const expectedTimeout = bidderRequest.timeout - (13500 - bidderRequest.auctionStart);
@@ -401,7 +403,7 @@ describe('stroeerCore bid adapter', function () {
         assert.equal(expectedTimeout, 1500);
 
         const expectedJsonPayload = {
-          'id': AUCTION_ID,
+          'id': UUID,
           'timeout': expectedTimeout,
           'ref': 'https://www.example.com/?search=monkey',
           'mpa': true,
@@ -429,8 +431,9 @@ describe('stroeerCore bid adapter', function () {
 
         // trim away fields with undefined
         const actualJsonPayload = JSON.parse(JSON.stringify(serverRequestInfo.data));
-
         assert.deepEqual(actualJsonPayload, expectedJsonPayload);
+
+        generateUUIDStub.restore();
       });
 
       describe('video bids', () => {

package/test/spec/modules/teadsBidAdapter_spec.js

@@ -108,21 +108,21 @@ describe('teadsBidAdapter', () => {
       }
     ];
 
-    let bidderResquestDefault = {
+    let bidderRequestDefault = {
       'auctionId': '1d1a030790a475',
       'bidderRequestId': '22edbae2733bf6',
       'timeout': 3000
     };
 
     it('should send bid request to ENDPOINT via POST', function() {
-      const request = spec.buildRequests(bidRequests, bidderResquestDefault);
+      const request = spec.buildRequests(bidRequests, bidderRequestDefault);
 
       expect(request.url).to.equal(ENDPOINT);
       expect(request.method).to.equal('POST');
     });
 
     it('should not send auctionId in bid request ', function() {
-      const request = spec.buildRequests(bidRequests, bidderResquestDefault);
+      const request = spec.buildRequests(bidRequests, bidderRequestDefault);
       const payload = JSON.parse(request.data);
 
       expect(payload.data[0].auctionId).to.not.exist
@@ -169,6 +169,55 @@ describe('teadsBidAdapter', () => {
       expect(payload.gdpr_iab.apiVersion).to.equal(2);
     });
 
+    it('should add videoPlcmt to payload', function () {
+      let bidRequestWithVideoPlcmt = Object.assign({}, bidRequests[0], {
+        mediaTypes: {
+          video: {
+            plcmt: 1
+          }
+        }
+      });
+
+      const request = spec.buildRequests([bidRequestWithVideoPlcmt], bidderRequestDefault);
+      const payload = JSON.parse(request.data);
+
+      expect(payload.data[0].videoPlcmt).to.exist;
+      expect(payload.data[0].videoPlcmt).to.equal(1);
+    });
+
+    it('should not add videoPlcmt to payload if empty', function () {
+      let bidRequestWithNullVideoPlcmt = Object.assign({}, bidRequests[0], {
+        mediaTypes: {
+          video: {
+            plcmt: null
+          }
+        }
+      });
+
+      let bidRequestWithEmptyVideoPlcmt = Object.assign({}, bidRequests[0], {
+        mediaTypes: {
+          video: {
+            plcmt: ''
+          }
+        }
+      });
+
+      const request1 = spec.buildRequests([bidRequestWithNullVideoPlcmt], bidderRequestDefault);
+      const request2 = spec.buildRequests([bidRequestWithEmptyVideoPlcmt], bidderRequestDefault);
+      const payload1 = JSON.parse(request1.data);
+      const payload2 = JSON.parse(request2.data);
+
+      expect(payload1.data[0].videoPlcmt).to.not.exist;
+      expect(payload2.data[0].videoPlcmt).to.not.exist;
+    });
+
+    it('should not add videoPlcmt to payload if it is not in bid request', function () {
+      const request = spec.buildRequests(bidRequests, bidderRequestDefault);
+      const payload = JSON.parse(request.data);
+
+      expect(payload.data[0].videoPlcmt).to.not.exist;
+    });
+
     it('should add referer info to payload', function () {
       const bidRequest = Object.assign({}, bidRequests[0])
       const bidderRequest = {
@@ -186,7 +235,7 @@ describe('teadsBidAdapter', () => {
     });
 
     it('should add networkBandwidth info to payload', function () {
-      const request = spec.buildRequests(bidRequests, bidderResquestDefault);
+      const request = spec.buildRequests(bidRequests, bidderRequestDefault);
       const payload = JSON.parse(request.data);
 
       const bandwidth = window.navigator && window.navigator.connection && window.navigator.connection.downlink;
@@ -201,7 +250,7 @@ describe('teadsBidAdapter', () => {
     });
 
     it('should add pageReferrer info to payload', function () {
-      const request = spec.buildRequests(bidRequests, bidderResquestDefault);
+      const request = spec.buildRequests(bidRequests, bidderRequestDefault);
       const payload = JSON.parse(request.data);
 
       expect(payload.pageReferrer).to.exist;
@@ -209,7 +258,7 @@ describe('teadsBidAdapter', () => {
     });
 
     it('should add timeToFirstByte info to payload', function () {
-      const request = spec.buildRequests(bidRequests, bidderResquestDefault);
+      const request = spec.buildRequests(bidRequests, bidderRequestDefault);
       const payload = JSON.parse(request.data);
       const performance = window.performance || window.webkitPerformance || window.msPerformance || window.mozPerformance;
 
@@ -410,7 +459,7 @@ describe('teadsBidAdapter', () => {
         }
       });
 
-      const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+      const request = spec.buildRequests([bidRequest], bidderRequestDefault);
       const payload = JSON.parse(request.data);
 
       expect(payload.schain).to.exist;
@@ -458,7 +507,7 @@ describe('teadsBidAdapter', () => {
         }
       });
 
-      const requestWithUserAgentClientHints = spec.buildRequests([bidRequest], bidderResquestDefault);
+      const requestWithUserAgentClientHints = spec.buildRequests([bidRequest], bidderRequestDefault);
       const payload = JSON.parse(requestWithUserAgentClientHints.data);
 
       expect(payload.userAgentClientHints).to.exist;
@@ -489,7 +538,7 @@ describe('teadsBidAdapter', () => {
       }
       );
 
-      const defaultRequest = spec.buildRequests(bidRequests, bidderResquestDefault);
+      const defaultRequest = spec.buildRequests(bidRequests, bidderRequestDefault);
       expect(JSON.parse(defaultRequest.data).userAgentClientHints).to.not.exist;
     });
 
@@ -566,7 +615,7 @@ describe('teadsBidAdapter', () => {
             userId: {} // no property -> assumption that the system is disabled
           };
 
-          const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+          const request = spec.buildRequests([bidRequest], bidderRequestDefault);
           const payload = JSON.parse(request.data);
 
           for (const userId in userIdModules) {
@@ -575,7 +624,7 @@ describe('teadsBidAdapter', () => {
         });
 
         it(`should not add param to payload if user id field is absent`, function () {
-          const request = spec.buildRequests([baseBidRequest], bidderResquestDefault);
+          const request = spec.buildRequests([baseBidRequest], bidderRequestDefault);
           const payload = JSON.parse(request.data);
 
           for (const userId in userIdModules) {
@@ -592,7 +641,7 @@ describe('teadsBidAdapter', () => {
             }
           };
 
-          const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+          const request = spec.buildRequests([bidRequest], bidderRequestDefault);
           const payload = JSON.parse(request.data);
 
           expect(payload).not.to.have.property('liveRampId');
@@ -612,7 +661,7 @@ describe('teadsBidAdapter', () => {
             userId: userIdObject
           };
 
-          const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+          const request = spec.buildRequests([bidRequest], bidderRequestDefault);
           const payload = JSON.parse(request.data);
 
           expect(payload['unifiedId2']).to.equal('unifiedId2-id');
@@ -641,7 +690,7 @@ describe('teadsBidAdapter', () => {
             }
           };
 
-          const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+          const request = spec.buildRequests([bidRequest], bidderRequestDefault);
           const payload = JSON.parse(request.data);
 
           expect(payload).not.to.have.property('firstPartyCookieTeadsId');
@@ -659,7 +708,7 @@ describe('teadsBidAdapter', () => {
             }
           };
 
-          const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+          const request = spec.buildRequests([bidRequest], bidderRequestDefault);
           const payload = JSON.parse(request.data);
 
           expect(payload).not.to.have.property('firstPartyCookieTeadsId');
@@ -677,7 +726,7 @@ describe('teadsBidAdapter', () => {
             }
           };
 
-          const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+          const request = spec.buildRequests([bidRequest], bidderRequestDefault);
 
           const payload = JSON.parse(request.data);
 
@@ -697,7 +746,7 @@ describe('teadsBidAdapter', () => {
             }
           };
 
-          const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+          const request = spec.buildRequests([bidRequest], bidderRequestDefault);
 
           const payload = JSON.parse(request.data);
 
@@ -750,7 +799,7 @@ describe('teadsBidAdapter', () => {
           };
         }
         );
-        const request = spec.buildRequests(updatedBidRequests, bidderResquestDefault);
+        const request = spec.buildRequests(updatedBidRequests, bidderRequestDefault);
         const payload = JSON.parse(request.data);
 
         expect(payload.data[0].gpid).to.equal('1111/home-left-0');
@@ -767,7 +816,7 @@ describe('teadsBidAdapter', () => {
           }
         }));
 
-        const request = spec.buildRequests(updatedBidRequests, bidderResquestDefault);
+        const request = spec.buildRequests(updatedBidRequests, bidderRequestDefault);
         const payload = JSON.parse(request.data);
 
         return payload.data.forEach(bid => {
@@ -784,7 +833,7 @@ describe('teadsBidAdapter', () => {
           }
         }));
 
-        const request = spec.buildRequests(updatedBidRequests, bidderResquestDefault);
+        const request = spec.buildRequests(updatedBidRequests, bidderRequestDefault);
         const payload = JSON.parse(request.data);
 
         return payload.data.forEach(bid => {
@@ -795,7 +844,7 @@ describe('teadsBidAdapter', () => {
 
     function checkMediaTypesSizes(mediaTypes, expectedSizes) {
       const bidRequestWithBannerSizes = Object.assign(bidRequests[0], mediaTypes);
-      const requestWithBannerSizes = spec.buildRequests([bidRequestWithBannerSizes], bidderResquestDefault);
+      const requestWithBannerSizes = spec.buildRequests([bidRequestWithBannerSizes], bidderRequestDefault);
       const payloadWithBannerSizes = JSON.parse(requestWithBannerSizes.data);
 
       return payloadWithBannerSizes.data.forEach(bid => {

package/test/spec/modules/topicsFpdModule_spec.js

@@ -372,11 +372,16 @@ describe('getCachedTopics()', () => {
     }
   ];
 
-  const evt = {
+  const evt_pm = {
     data: '{"segment":{"domain":"ads.pubmatic.com","topics":[{"configVersion":"chrome.1","modelVersion":"2206021246","taxonomyVersion":"1","topic":165,"version":"chrome.1:1:2206021246"}],"bidder":"pubmatic"},"date":1669743901858}',
     origin: 'https://ads.pubmatic.com'
   };
 
+  const evt_rh = {
+    data: '{"segment":{"domain":"topics.authorizedvault.com","topics":[{"configVersion":"chrome.1","modelVersion":"2206021246","taxonomyVersion":"1","topic":165,"version":"chrome.1:1:2206021246"}],"bidder":"rtbhouse"},"date":1669743901858}',
+    origin: 'https://topics.authorizedvault.com'
+  };
+
   let gdprDataHdlrStub;
   beforeEach(() => {
     gdprDataHdlrStub = sinon.stub(gdprDataHandler, 'getConsentData');
@@ -413,9 +418,10 @@ describe('getCachedTopics()', () => {
   it('should stored segments if receiveMessage event is triggerred with segment data', () => {
     return processFpd({}, {global: {}}, {data: Promise.resolve(mockData)})
       .then(({global}) => {
-        receiveMessage(evt);
+        receiveMessage(evt_pm);
+        receiveMessage(evt_rh);
         let segments = new Map(safeJSONParse(storage.getDataFromLocalStorage(topicStorageName)));
-        expect(segments.has('pubmatic')).to.equal(true);
+        expect(segments.has('pubmatic') || segments.has('rtbhouse')).to.equal(true);
       });
   });
 
@@ -424,7 +430,7 @@ describe('getCachedTopics()', () => {
     storage.setDataInLocalStorage(topicStorageName, storedSegments);
     return processFpd({}, {global: {}}, {data: Promise.resolve(mockData)})
       .then(({global}) => {
-        receiveMessage(evt);
+        receiveMessage(evt_pm);
         let segments = new Map(safeJSONParse(storage.getDataFromLocalStorage(topicStorageName)));
         expect(segments.get('pubmatic')[2206021246].segment.length).to.equal(1);
       });

package/test/spec/modules/tripleliftBidAdapter_spec.js

@@ -1130,6 +1130,46 @@ describe('triplelift adapter', function () {
 
       expect(logErrorSpy.calledOnce).to.equal(true);
     });
+    it('should add ortb2 ext object if global fpd is available', function() {
+      const ortb2 = {
+        site: {
+          domain: 'page.example.com',
+          cat: ['IAB2'],
+          sectioncat: ['IAB2-2'],
+          pagecat: ['IAB2-2'],
+          page: 'https://page.example.com/here.html',
+        },
+        user: {
+          yob: 1985,
+          gender: 'm',
+          keywords: 'a,b',
+          data: [
+            {
+              name: 'dataprovider.com',
+              ext: { segtax: 4 },
+              segment: [{ id: '1' }]
+            }
+          ],
+          ext: {
+            data: {
+              registered: true,
+              interests: ['cars']
+            }
+          }
+        }
+      };
+
+      const request = tripleliftAdapterSpec.buildRequests(bidRequests, {...bidderRequest, ortb2});
+      const { data: payload } = request;
+      expect(payload.ext.ortb2).to.exist;
+      expect(payload.ext.ortb2.site).to.deep.equal({
+        domain: 'page.example.com',
+        cat: ['IAB2'],
+        sectioncat: ['IAB2-2'],
+        pagecat: ['IAB2-2'],
+        page: 'https://page.example.com/here.html',
+      });
+    });
     it('should send global config fpd if kvps are available', function() {
       const sens = null;
       const category = ['news', 'weather', 'hurricane'];