prebid.js 8.2.0 → 8.4.0

package/test/spec/modules/33acrossIdSystem_spec.js

@@ -2,7 +2,7 @@ import { thirthyThreeAcrossIdSubmodule } from 'modules/33acrossIdSystem.js';
 import * as utils from 'src/utils.js';
 
 import { server } from 'test/mocks/xhr.js';
-import { uspDataHandler } from 'src/adapterManager.js';
+import { uspDataHandler, coppaDataHandler, gppDataHandler } from 'src/adapterManager.js';
 
 describe('33acrossIdSystem', () => {
   describe('name', () => {
@@ -67,41 +67,35 @@ describe('33acrossIdSystem', () => {
 
         expect(request.url).to.contain('gdpr=1');
       });
+    });
 
-      context('and the consent string is given', () => {
-        it('should call endpoint with the GDPR consent string', () => {
-          [
-            { consentString: '', expected: '' },
-            { consentString: undefined, expected: '' },
-            { consentString: 'foo', expected: 'foo' }
-          ].forEach(({ consentString, expected }, index) => {
-            const completeCallback = () => {};
-            const { callback } = thirthyThreeAcrossIdSubmodule.getId({
-              params: {
-                pid: '12345'
-              }
-            }, {
-              gdprApplies: true,
-              consentString
-            });
-
-            callback(completeCallback);
-
-            expect(server.requests[index].url).to.contain(`gdpr_consent=${expected}`);
-          });
+    context('when GDPR doesn\'t apply', () => {
+      it('should call endpoint with \'gdpr=0\'', () => {
+        const completeCallback = () => {};
+        const { callback } = thirthyThreeAcrossIdSubmodule.getId({
+          params: {
+            pid: '12345'
+          }
+        }, {
+          gdprApplies: false
         });
+
+        callback(completeCallback);
+
+        const [request] = server.requests;
+
+        expect(request.url).to.contain('gdpr=0');
       });
     });
 
-    context('when GDPR doesn\'t apply', () => {
-      it('should call endpoint with \'gdpr=0\' and no GDPR consent string parameter', () => {
+    context('when the GDPR consent string is given', () => {
+      it('should call endpoint with the GDPR consent string', () => {
         const completeCallback = () => {};
         const { callback } = thirthyThreeAcrossIdSubmodule.getId({
           params: {
             pid: '12345'
           }
         }, {
-          gdprApplies: false,
           consentString: 'foo'
         });
 
@@ -109,8 +103,7 @@ describe('33acrossIdSystem', () => {
 
         const [request] = server.requests;
 
-        expect(request.url).to.contain('gdpr=0');
-        expect(request.url).not.to.contain('gdpr_consent');
+        expect(request.url).to.contain('gdpr_consent=foo');
       });
     });
 
@@ -157,6 +150,108 @@ describe('33acrossIdSystem', () => {
       });
     });
 
+    context('when coppa is enabled', () => {
+      it('should call endpoint with an enabled coppa signal', () => {
+        const completeCallback = () => {};
+        const { callback } = thirthyThreeAcrossIdSubmodule.getId({
+          params: {
+            pid: '12345'
+          }
+        });
+
+        sinon.stub(coppaDataHandler, 'getCoppa').returns(true);
+
+        callback(completeCallback);
+
+        const [request] = server.requests;
+
+        expect(request.url).to.contain('coppa=1');
+
+        coppaDataHandler.getCoppa.restore();
+      });
+    });
+
+    context('when coppa is not enabled', () => {
+      it('should call endpoint with coppa signal not enabled', () => {
+        const completeCallback = () => {};
+        const { callback } = thirthyThreeAcrossIdSubmodule.getId({
+          params: {
+            pid: '12345'
+          }
+        });
+
+        sinon.stub(coppaDataHandler, 'getCoppa').returns(false);
+
+        callback(completeCallback);
+
+        const [request] = server.requests;
+
+        expect(request.url).to.contain('coppa=0');
+
+        coppaDataHandler.getCoppa.restore();
+      });
+    });
+
+    context('when a GPP consent string is given', () => {
+      beforeEach(() => {
+        sinon.stub(gppDataHandler, 'getConsentData');
+      });
+
+      afterEach(() => {
+        gppDataHandler.getConsentData.restore();
+      });
+
+      it('should call endpoint with the GPP consent string', () => {
+        [
+          { gppString: '', expected: '' },
+          { gppString: undefined, expected: '' },
+          { gppString: 'foo', expected: 'foo' },
+        ].forEach(({ gppString, expected }, index) => {
+          const completeCallback = () => {};
+          const { callback } = thirthyThreeAcrossIdSubmodule.getId({
+            params: {
+              pid: '12345'
+            }
+          });
+
+          gppDataHandler.getConsentData.onCall(index).returns({
+            gppString
+          });
+
+          callback(completeCallback);
+
+          expect(server.requests[index].url).to.contain(`gpp=${expected}`);
+        });
+      });
+
+      it('should call endpoint with the GPP applicable sections', () => {
+        const gppString = 'foo';
+
+        [
+          { applicableSections: [], expected: '' },
+          { applicableSections: undefined, expected: '' },
+          { applicableSections: ['1'], expected: '1' },
+          { applicableSections: ['1', '2'], expected: '1%2C2' },
+        ].forEach(({ applicableSections, expected }, index) => {
+          const completeCallback = () => {};
+          const { callback } = thirthyThreeAcrossIdSubmodule.getId({
+            params: {
+              pid: '12345'
+            }
+          });
+
+          gppDataHandler.getConsentData.onCall(index).returns({
+            gppString: 'foo',
+            applicableSections
+          });
+
+          callback(completeCallback);
+
+          expect(server.requests[index].url).to.contain(`gpp_sid=${expected}`);
+        });
+      });
+    });
+
     context('when the partner ID is not given', () => {
       it('should log an error', () => {
         const logErrorSpy = sinon.spy(utils, 'logError');

package/test/spec/modules/adagioBidAdapter_spec.js

@@ -256,7 +256,6 @@ describe('Adagio bid adapter', () => {
 
   describe('buildRequests()', function() {
     const expectedDataKeys = [
-      'id',
       'organizationId',
       'secure',
       'device',
@@ -269,7 +268,8 @@ describe('Adagio bid adapter', () => {
       'prebidVersion',
       'featuresVersion',
       'data',
-      'usIfr'
+      'usIfr',
+      'adgjs',
     ];
 
     it('groups requests by organizationId', function() {

package/test/spec/modules/adtelligentBidAdapter_spec.js

@@ -156,6 +156,10 @@ const displayBidderRequestWithConsents = {
     gdprApplies: true,
     consentString: 'test'
   },
+  gppConsent: {
+    gppString: 'abc12345234',
+    applicableSections: [7, 8]
+  },
   uspConsent: 'iHaveIt'
 };
 
@@ -364,6 +368,10 @@ describe('adtelligentBidAdapter', () => {
         expect(bidRequestWithPubSettingsData.GDPR).to.be.equal(1);
         expect(bidRequestWithPubSettingsData.GDPRConsent).to.be.equal(displayBidderRequestWithConsents.gdprConsent.consentString);
       });
+      it('sets GPP flags', () => {
+        expect(bidRequestWithPubSettingsData.GPP).to.be.equal(displayBidderRequestWithConsents.gppConsent.gppString);
+        expect(bidRequestWithPubSettingsData.GPPSid).to.be.equal('7,8');
+      });
       it('sets USP', () => {
         expect(bidRequestWithPubSettingsData.USP).to.be.equal(displayBidderRequestWithConsents.uspConsent);
       })

package/test/spec/modules/beopBidAdapter_spec.js

@@ -130,15 +130,15 @@ describe('BeOp Bid Adapter tests', () => {
       expect(payload.url).to.exist;
       // check that the protocol is added correctly
       expect(payload.url).to.equal('http://test.te');
-      expect(payload.psegs).to.not.exist;
     });
 
-    it('should call the endpoint with psegs data if any', function () {
+    it('should call the endpoint with psegs and bpsegs (stringified) data if any or [] if none', function () {
       let bidderRequest =
       {
         'ortb2': {
           'user': {
             'ext': {
+              'bpsegs': ['axed', 'axec', 1234],
               'data': {
                 'permutive': [1234, 5678, 910]
               }
@@ -154,6 +154,22 @@ describe('BeOp Bid Adapter tests', () => {
       expect(payload.psegs).to.include(5678);
       expect(payload.psegs).to.include(910);
       expect(payload.psegs).to.not.include(1);
+      expect(payload.bpsegs).to.exist;
+      expect(payload.bpsegs).to.include('axed');
+      expect(payload.bpsegs).to.include('axec');
+      expect(payload.bpsegs).to.include('1234');
+
+      let bidderRequest2 =
+      {
+        'ortb2': {}
+      };
+
+      const request2 = spec.buildRequests(bidRequests, bidderRequest2);
+      const payload2 = JSON.parse(request2.data);
+      expect(payload2.psegs).to.exist;
+      expect(payload2.psegs).to.be.empty;
+      expect(payload2.bpsegs).to.exist;
+      expect(payload2.bpsegs).to.be.empty;
     });
 
     it('should not prepend the protocol in page url if already present', function () {

package/test/spec/modules/brandmetricsRtdProvider_spec.js

@@ -1,5 +1,7 @@
 import * as brandmetricsRTD from '../../../modules/brandmetricsRtdProvider.js';
 import {config} from 'src/config.js';
+import * as events from '../../../src/events';
+import * as sinon from 'sinon';
 
 const VALID_CONFIG = {
   name: 'brandmetrics',
@@ -77,14 +79,16 @@ function mockSurveyLoaded(surveyConf) {
   });
 }
 
-function scriptTagExists(url) {
-  const tags = document.getElementsByTagName('script');
-  for (let i = 0; i < tags.length; i++) {
-    if (tags[i].src === url) {
-      return true;
+function mockCreativeInView(creativeInViewConf) {
+  const commands = window._brandmetrics || [];
+  commands.forEach(command => {
+    if (command.cmd === '_addeventlistener') {
+      const conf = command.val;
+      if (conf.event === 'creative_in_view') {
+        conf.handler(creativeInViewConf);
+      }
     }
-  }
-  return false;
+  })
 }
 
 describe('BrandmetricsRTD module', () => {
@@ -188,4 +192,62 @@ describe('getBidRequestData', () => {
       expect(bidderOrtb2[exp].user.ext.data.brandmetrics_survey).to.equal('mockMeasurementId')
     })
   });
+
+  describe('billable events', () => {
+    let sandbox;
+    let eventsEmitSpy;
+
+    before(() => {
+      sandbox = sinon.sandbox.create();
+      eventsEmitSpy = sandbox.spy(events, ['emit']);
+    });
+
+    beforeEach(() => {
+      eventsEmitSpy.resetHistory();
+    })
+
+    afterEach(() => {
+      sandbox.restore();
+    });
+
+    it('should emit billable event from prebid events', () => {
+      const expectedEvent = {
+        vendor: 'brandmetrics',
+        type: 'creative_in_view',
+        measurementId: 'mockMeasurementId',
+        auctionId: 'mockAuctionId',
+        transactionId: 'mockTransactionId'
+      };
+
+      mockCreativeInView({
+        mid: expectedEvent.measurementId,
+        source: {
+          type: 'pbj',
+          data: {
+            auctionId: expectedEvent.auctionId,
+            transactionId: expectedEvent.transactionId
+          },
+        }
+      });
+
+      expect(eventsEmitSpy.callCount).to.equal(1);
+
+      const event = eventsEmitSpy.getCalls()[0].args[1];
+      delete event['billingId'];
+
+      expect(event).to.deep.equal(expectedEvent);
+    });
+
+    it('should not emit billable event from non prebid- sources', () => {
+      mockCreativeInView({
+        mid: 'mockMeasurementId',
+        source: {
+          type: 'gpt',
+          data: {},
+        }
+      });
+
+      expect(eventsEmitSpy.callCount).to.equal(0);
+    });
+  });
 });

package/test/spec/modules/cadentApertureMXBidAdapter_spec.js

@@ -699,7 +699,7 @@ describe('cadent_aperture_mx Adapter', function () {
 
     it('should not throw an error when decoding an improperly encoded adm', function () {
       const badAdmServerResponse = utils.deepClone(serverResponse);
-      badAdmServerResponse.seatbid[0].bid[0].adm = '<script\\ src\\=\\\"https\\:\\/\\/nym1\\-ib\\.adnxs\\.com\\/ab\\?an_audit\\=0\\&referrer=https%3A%2F%2Fwww.emxdigital.com%3Ftest%3DhAiE3%VVl%26prebid%3D%25123%25\\&e\\=wqT_3QLPCfBDzwQAAAMA1gAFAQj2iaPtBRCdw\\-qeto72gkEYlNWN2smGoJhTKjYJzGJi83G9KkARzGJi83G9KkAZAAAAgD0KEkAhzGIJGwApESTIMQAAAGBmZu4_MMvWgAc4zApAzApIAlDo\\-YEUWNbsR2AAaIrFCnjOpQWAAQGKAQNVU0SSBQbwQJgB2AWgAVqoAQGwAQC4AQLAAQTIAQLQAQnYAQDgAQDwAQCKAjp1ZignYScsIDI4OTEwMSwgMTU3MTM0MTU1OCk7ARwscicsIDQxOTc1MDE2Nh4A9DQBkgLhAiE3VVlCWndpQmpwOEpFT2o1Z1JRWUFDRFc3RWN3QURnQVFBUkl6QXBReTlhQUIxZ0FZTHdFYUFCd0NuZ0FnQUZFaUFFQWtBRUFtQUVBb0FFQnFBRURzQUVBdVFGS1I2cF9jYjBxUU1FQlNrZXFmM0c5S2tESkFaR1JfRy1UVnRNXzJRRUFBQUFBQUFEd1AtQUJBUFVCQUFBQUFJQUNBSWdDcVlMWEJaQUNBWmdDQUtBQ0FLZ0NBTFVDQUFBQUFMMENBQUFBQU9BQ0FPZ0NBUGdDQUlBREFaZ0RBYWdEZ1k2ZkNib0RDVTVaVFRJNk5ESTRNdUFEOHhQNEE0NnV2Z3lJQkFDUUJBQ1lCQUd5QkFvSXFZTFhCUkNPcnI0TXdRUUFBQUFBQUFBQUFNa0VBQUFBBXgMQURSQgkJLEF3Q0ZBMkFRQThRUQ0SYEFBQVBnRUFJZ0Z1aUUumgKJASE2eElrelE2ZQGgMXV4SElBUW9BREU5Q3RlamNMMHFRRG9KVGxsTk1qbzBNamd5UVBNVFMRWAxQQV9VEQwMQUFBVx0MAFkdDABhHQwAYw0MAaXwi2VBQS7YAqwD4AK30UbqAlxodHRwczovL3d3dy5jZWxlYnV6ei5jb20vZy90YXlsb3Itc3dpZnQtZGVidXRzLXJlZC1oYWlyLWluLXN1Z2FybGFuZC12aWRlby8_YmlkZHJfZGVidWc9dHJ1ZfICEwoPQ1VTVE9NX01PREVMX0lEEgDyAhoKFkNVU1RPERY8TEVBRl9OQU1FEgDyAh4KGjYdAPQqAUFTVF9NT0RJRklFRBIAgAMAiAMBkAMAmAMUoAMBqgMAwAOsAsgDANgDlCHgAwDoAwD4AwOABACSBAkvb3BlbnJ0YjKYBACiBA8xNDQuMTIxLjIzMy4yMzeoBIkWsgQMCAAQABgAIAAwADgAuAQAwAQAyASxgoIB0gQOMTM1NiNOWU0yOjQyODLaBAIIAeAEAPAE6PmBFPoEEgkAAAAAZqdHQBEAAAAgWpRewIgFAZgFAKAF____________AaoFFjQ5MTgxNTcxMzQxNTU2NTI2OTQ5ZTHABQDJBQAAAAAAAPA_0gUJCQAAAAAAAAAA2AUB4AUB8AXW7gr6BQQIABAAkAYAmAYAuAYAwQYAAAAAAADwP8gGANAGwgTaBhYKEAAAAAAAAAAAAAAABQpQEAAYAOAGAfIGAggAgAcBiAcAoAcB\\&s\\=630dbbd55f593c7bfd9e7bccc4dbaa28203daaed\\&pp\\=\\$\\{EMX_MACRO\\}\\\"\\>\\<\\/script\\>';
+      badAdmServerResponse.seatbid[0].bid[0].adm = '<script\\ src\\=\\\"https\\:\\/\\/nym1\\-ib\\.adnxs\\.com\\/ab\\?an_audit\\=0\\&referrer=https%3A%2F%2Fwww.cadent.tv%3Ftest%3DhAiE3%VVl%26prebid%3D%25123%25\\&e\\=wqT_3QLPCfBDzwQAAAMA1gAFAQj2iaPtBRCdw\\-qeto72gkEYlNWN2smGoJhTKjYJzGJi83G9KkARzGJi83G9KkAZAAAAgD0KEkAhzGIJGwApESTIMQAAAGBmZu4_MMvWgAc4zApAzApIAlDo\\-YEUWNbsR2AAaIrFCnjOpQWAAQGKAQNVU0SSBQbwQJgB2AWgAVqoAQGwAQC4AQLAAQTIAQLQAQnYAQDgAQDwAQCKAjp1ZignYScsIDI4OTEwMSwgMTU3MTM0MTU1OCk7ARwscicsIDQxOTc1MDE2Nh4A9DQBkgLhAiE3VVlCWndpQmpwOEpFT2o1Z1JRWUFDRFc3RWN3QURnQVFBUkl6QXBReTlhQUIxZ0FZTHdFYUFCd0NuZ0FnQUZFaUFFQWtBRUFtQUVBb0FFQnFBRURzQUVBdVFGS1I2cF9jYjBxUU1FQlNrZXFmM0c5S2tESkFaR1JfRy1UVnRNXzJRRUFBQUFBQUFEd1AtQUJBUFVCQUFBQUFJQUNBSWdDcVlMWEJaQUNBWmdDQUtBQ0FLZ0NBTFVDQUFBQUFMMENBQUFBQU9BQ0FPZ0NBUGdDQUlBREFaZ0RBYWdEZ1k2ZkNib0RDVTVaVFRJNk5ESTRNdUFEOHhQNEE0NnV2Z3lJQkFDUUJBQ1lCQUd5QkFvSXFZTFhCUkNPcnI0TXdRUUFBQUFBQUFBQUFNa0VBQUFBBXgMQURSQgkJLEF3Q0ZBMkFRQThRUQ0SYEFBQVBnRUFJZ0Z1aUUumgKJASE2eElrelE2ZQGgMXV4SElBUW9BREU5Q3RlamNMMHFRRG9KVGxsTk1qbzBNamd5UVBNVFMRWAxQQV9VEQwMQUFBVx0MAFkdDABhHQwAYw0MAaXwi2VBQS7YAqwD4AK30UbqAlxodHRwczovL3d3dy5jZWxlYnV6ei5jb20vZy90YXlsb3Itc3dpZnQtZGVidXRzLXJlZC1oYWlyLWluLXN1Z2FybGFuZC12aWRlby8_YmlkZHJfZGVidWc9dHJ1ZfICEwoPQ1VTVE9NX01PREVMX0lEEgDyAhoKFkNVU1RPERY8TEVBRl9OQU1FEgDyAh4KGjYdAPQqAUFTVF9NT0RJRklFRBIAgAMAiAMBkAMAmAMUoAMBqgMAwAOsAsgDANgDlCHgAwDoAwD4AwOABACSBAkvb3BlbnJ0YjKYBACiBA8xNDQuMTIxLjIzMy4yMzeoBIkWsgQMCAAQABgAIAAwADgAuAQAwAQAyASxgoIB0gQOMTM1NiNOWU0yOjQyODLaBAIIAeAEAPAE6PmBFPoEEgkAAAAAZqdHQBEAAAAgWpRewIgFAZgFAKAF____________AaoFFjQ5MTgxNTcxMzQxNTU2NTI2OTQ5ZTHABQDJBQAAAAAAAPA_0gUJCQAAAAAAAAAA2AUB4AUB8AXW7gr6BQQIABAAkAYAmAYAuAYAwQYAAAAAAADwP8gGANAGwgTaBhYKEAAAAAAAAAAAAAAABQpQEAAYAOAGAfIGAggAgAcBiAcAoAcB\\&s\\=630dbbd55f593c7bfd9e7bccc4dbaa28203daaed\\&pp\\=\\$\\{EMX_MACRO\\}\\\"\\>\\<\\/script\\>';
       badAdmServerResponse.seatbid[1].bid[0].adm = '%3F%%3Dcadent%3C3prebid';
 
       assert.doesNotThrow(() => spec.interpretResponse({

package/test/spec/modules/gdprEnforcement_spec.js

@@ -11,7 +11,7 @@ import {
   reportAnalyticsRule,
   setEnforcementConfig,
   STRICT_STORAGE_ENFORCEMENT,
-  syncUserRule,
+  syncUserRule, ufpdRule,
   validateRules
 } from 'modules/gdprEnforcement.js';
 import {config} from 'src/config.js';
@@ -462,6 +462,46 @@ describe('gdpr enforcement', function () {
     });
   });
 
+  describe('transmitUfpdRule', () => {
+    it('should allow when purpose 3 consent is given', () => {
+      setEnforcementConfig({
+        gdpr: {
+          rules: [{
+            purpose: 'personalizedAds',
+            enforcePurpose: true,
+            enforceVendor: true,
+          }]
+        }
+      });
+      Object.assign(gvlids, {
+        mockBidder: 123
+      });
+      const consent = setupConsentData();
+      consent.vendorData.purpose.consents[4] = true;
+      consent.vendorData.vendor.consents[123] = true;
+      expectAllow(true, ufpdRule(activityParams(MODULE_TYPE_BIDDER, 'mockBidder')));
+    });
+
+    it('should return deny when purpose 4 consent is withheld', () => {
+      setEnforcementConfig({
+        gdpr: {
+          rules: [{
+            purpose: 'personalizedAds',
+            enforcePurpose: true,
+            enforceVendor: true,
+          }]
+        }
+      });
+      Object.assign(gvlids, {
+        mockBidder: 123
+      });
+      const consent = setupConsentData();
+      consent.vendorData.purpose.consents[4] = true;
+      consent.vendorData.vendor.consents[123] = false;
+      expectAllow(false, ufpdRule(activityParams(MODULE_TYPE_BIDDER, 'mockBidder')))
+    });
+  });
+
   describe('validateRules', function () {
     const createGdprRule = (purposeName = 'storage', enforcePurpose = true, enforceVendor = true, vendorExceptions = [], softVendorExceptions = []) => ({
       purpose: purposeName,
@@ -599,7 +639,8 @@ describe('gdpr enforcement', function () {
       Object.entries({
         'storage': 1,
         'basicAds': 2,
-        'measurement': 7
+        'measurement': 7,
+        'personalizedAds': 4,
       }).forEach(([purpose, purposeNo]) => {
         describe(`for purpose ${purpose}`, () => {
           const rule = createGdprRule(purpose);

package/test/spec/modules/gridBidAdapter_spec.js

@@ -2,6 +2,7 @@ import { expect } from 'chai';
 import { spec, resetUserSync, getSyncUrl, storage } from 'modules/gridBidAdapter.js';
 import { newBidder } from 'src/adapters/bidderFactory.js';
 import { config } from 'src/config.js';
+import {ENDPOINT_DOMAIN, ENDPOINT_PROTOCOL} from '../../../modules/adpartnerBidAdapter';
 
 describe('TheMediaGrid Adapter', function () {
   const adapter = newBidder(spec);
@@ -1465,6 +1466,47 @@ describe('TheMediaGrid Adapter', function () {
     });
   });
 
+  describe('onDataDeletionRequest', function() {
+    let ajaxStub;
+    beforeEach(function() {
+      ajaxStub = sinon.stub(spec, 'ajaxCall');
+    });
+
+    it('should send right request on onDataDeletionRequest call', function() {
+      spec.onDataDeletionRequest([{
+        bids: [
+          {
+            bidder: 'grid',
+            params: {
+              uid: 1
+            }
+          },
+          {
+            bidder: 'grid',
+            params: {
+              uid: 2
+            }
+          },
+          {
+            bidder: 'another',
+            params: {
+              uid: 3
+            }
+          },
+          {
+            bidder: 'gridNM',
+            params: {
+              uid: 4
+            }
+          }
+        ],
+      }]);
+      expect(ajaxStub.calledOnce).to.equal(true);
+      expect(ajaxStub.firstCall.args[0]).to.equal('https://media.grid.bidswitch.net/uspapi_delete');
+      expect(ajaxStub.firstCall.args[2]).to.equal('{"uids":[1,2,4]}');
+    });
+  });
+
   describe('user sync', function () {
     const syncUrl = getSyncUrl();
 

package/test/spec/modules/holidBidAdapter_spec.js

@@ -2,11 +2,14 @@ import { expect } from 'chai'
 import { spec } from 'modules/holidBidAdapter.js'
 
 describe('holidBidAdapterTests', () => {
+  const bidderRequest = {
+    bidderRequestId: 'test-id'
+  }
+
   const bidRequestData = {
     bidder: 'holid',
     adUnitCode: 'test-div',
     bidId: 'bid-id',
-    auctionId: 'test-id',
     params: { adUnitID: '12345' },
     mediaTypes: { banner: {} },
     sizes: [[300, 250]],
@@ -48,18 +51,26 @@ describe('holidBidAdapterTests', () => {
 
   describe('buildRequests', () => {
     const bid = JSON.parse(JSON.stringify(bidRequestData))
-    const request = spec.buildRequests([bid], bid)
+    const request = spec.buildRequests([bid], bidderRequest)
     const payload = JSON.parse(request[0].data)
 
+    it('should include id in request', () => {
+      expect(payload.id).to.equal('test-id')
+    })
+
     it('should include ext in imp', () => {
-      expect(payload.imp[0].ext).to.exist
       expect(payload.imp[0].ext).to.deep.equal({
         prebid: { storedrequest: { id: '12345' } },
       })
     })
 
+    it('should include ext in request', () => {
+      expect(payload.ext).to.deep.equal({
+        prebid: { storedrequest: { id: '12345' } },
+      })
+    })
+
     it('should include banner format in imp', () => {
-      expect(payload.imp[0].banner).to.exist
       expect(payload.imp[0].banner).to.deep.equal({
         format: [{ w: 300, h: 250 }],
       })
@@ -146,6 +157,10 @@ describe('holidBidAdapterTests', () => {
       }
       const uspConsent = 'mkjvbiniwot4827obfoy8sdg8203gb'
       const expectedUserSyncs = [
+        {
+          type: 'image',
+          url: 'https://track.adform.net/Serving/TrackPoint/?pm=2992097&lid=132720821',
+        },
         {
           type: 'iframe',
           url: 'https://null.holid.io/sync.html?bidders=%5B%22test%20seat%201%22%2C%22test%20seat%202%22%5D&gdpr=1&gdpr_consent=dkj49Sjmfjuj34as:12jaf90123hufabidfy9u23brfpoig&usp_consent=mkjvbiniwot4827obfoy8sdg8203gb&type=iframe',
@@ -162,7 +177,7 @@ describe('holidBidAdapterTests', () => {
       expect(userSyncs).to.deep.equal(expectedUserSyncs)
     })
 
-    it('should return empty user syncs when responsetimemillis is not defined', () => {
+    it('should return base user syncs when responsetimemillis is not defined', () => {
       const optionsType = {
         iframeEnabled: true,
         pixelEnabled: true,
@@ -179,7 +194,12 @@ describe('holidBidAdapterTests', () => {
         consentString: 'dkj49Sjmfjuj34as:12jaf90123hufabidfy9u23brfpoig',
       }
       const uspConsent = 'mkjvbiniwot4827obfoy8sdg8203gb'
-      const expectedUserSyncs = []
+      const expectedUserSyncs = [
+        {
+          type: 'image',
+          url: 'https://track.adform.net/Serving/TrackPoint/?pm=2992097&lid=132720821',
+        }
+      ]
 
       const userSyncs = spec.getUserSyncs(
         optionsType,