prebid.js 8.0.0 → 8.1.0

package/test/spec/modules/sharethroughBidAdapter_spec.js

@@ -706,6 +706,81 @@ describe('sharethrough adapter spec', function () {
           expect(bannerBid.vastXml).to.equal('vastTag');
         });
       });
+
+      describe('meta object', () => {
+        beforeEach(() => {
+          request = spec.buildRequests(bidRequests, bidderRequest)[0];
+          response = {
+            body: {
+              seatbid: [{
+                bid: [{
+                  id: '123',
+                  impid: 'bidId1',
+                  w: 300,
+                  h: 250,
+                  price: 42,
+                  crid: 'creative',
+                  dealid: 'deal',
+                  adomain: ['domain.com'],
+                  adm: 'markup',
+                }],
+              }],
+            },
+          };
+        });
+
+        it('should have null optional fields when the response\'s optional seatbid[].bid[].ext field is empty', () => {
+          const bid = spec.interpretResponse(response, request)[0];
+
+          expect(bid.meta.networkId).to.be.null;
+          expect(bid.meta.networkName).to.be.null;
+          expect(bid.meta.agencyId).to.be.null;
+          expect(bid.meta.agencyName).to.be.null;
+          expect(bid.meta.advertiserId).to.be.null;
+          expect(bid.meta.advertiserName).to.be.null;
+          expect(bid.meta.brandId).to.be.null;
+          expect(bid.meta.brandName).to.be.null;
+          expect(bid.meta.demandSource).to.be.null;
+          expect(bid.meta.dchain).to.be.null;
+          expect(bid.meta.primaryCatId).to.be.null;
+          expect(bid.meta.secondaryCatIds).to.be.null;
+          expect(bid.meta.mediaType).to.be.null;
+        });
+
+        it('should have populated fields when the response\'s optional seatbid[].bid[].ext fields are filled', () => {
+          response.body.seatbid[0].bid[0].ext = {
+            networkId: 'my network id',
+            networkName: 'my network name',
+            agencyId: 'my agency id',
+            agencyName: 'my agency name',
+            advertiserId: 'my advertiser id',
+            advertiserName: 'my advertiser name',
+            brandId: 'my brand id',
+            brandName: 'my brand name',
+            demandSource: 'my demand source',
+            dchain: { 'my key': 'my value' },
+            primaryCatId: 'my primary cat id',
+            secondaryCatIds: ['my', 'secondary', 'cat', 'ids'],
+            mediaType: 'my media type',
+          };
+
+          const bid = spec.interpretResponse(response, request)[0];
+
+          expect(bid.meta.networkId).to.equal('my network id');
+          expect(bid.meta.networkName).to.equal('my network name');
+          expect(bid.meta.agencyId).to.equal('my agency id');
+          expect(bid.meta.agencyName).to.equal('my agency name');
+          expect(bid.meta.advertiserId).to.equal('my advertiser id');
+          expect(bid.meta.advertiserName).to.equal('my advertiser name');
+          expect(bid.meta.brandId).to.equal('my brand id');
+          expect(bid.meta.brandName).to.equal('my brand name');
+          expect(bid.meta.demandSource).to.equal('my demand source');
+          expect(bid.meta.dchain).to.deep.equal({ 'my key': 'my value' });
+          expect(bid.meta.primaryCatId).to.equal('my primary cat id');
+          expect(bid.meta.secondaryCatIds).to.deep.equal(['my', 'secondary', 'cat', 'ids']);
+          expect(bid.meta.mediaType).to.equal('my media type');
+        });
+      });
     });
 
     describe('getUserSyncs', function () {

package/test/spec/modules/sonobiBidAdapter_spec.js

@@ -193,7 +193,7 @@ describe('SonobiBidAdapter', function () {
       });
 
       describe('outstream', () => {
-        it('should return false if there is no param sizes', () => {
+        it('should return false if there is no playerSize', () => {
           const bid = {
             'bidder': 'sonobi',
             'adUnitCode': 'adunit-code',
@@ -203,7 +203,6 @@ describe('SonobiBidAdapter', function () {
             'mediaTypes': {
               video: {
                 context: 'outstream',
-                playerSize: [300, 250]
               }
             },
             'bidId': '30b31c1838de1e',
@@ -213,7 +212,7 @@ describe('SonobiBidAdapter', function () {
           expect(spec.isBidRequestValid(bid)).to.equal(false);
         });
 
-        it('should return true if there is param sizes', () => {
+        it('should return true if there is playerSize', () => {
           const bid = {
             'bidder': 'sonobi',
             'adUnitCode': 'adunit-code',
@@ -224,7 +223,8 @@ describe('SonobiBidAdapter', function () {
             },
             'mediaTypes': {
               video: {
-                context: 'outstream'
+                context: 'outstream',
+                playerSize: [640, 480]
               }
             },
             'bidId': '30b31c1838de1e',
@@ -294,7 +294,7 @@ describe('SonobiBidAdapter', function () {
       },
       mediaTypes: {
         video: {
-          sizes: [[300, 250], [300, 600]],
+          playerSize: [640, 480],
           context: 'outstream'
         }
       }
@@ -339,7 +339,7 @@ describe('SonobiBidAdapter', function () {
     }];
 
     let keyMakerData = {
-      '30b31c1838de1f': '1a2b3c4d5e6f1a2b3c4d|300x250,300x600|f=1.25,gpid=/123123/gpt_publisher/adunit-code-1,c=v,',
+      '30b31c1838de1f': '1a2b3c4d5e6f1a2b3c4d|640x480|f=1.25,gpid=/123123/gpt_publisher/adunit-code-1,c=v,',
       '30b31c1838de1d': '1a2b3c4d5e6f1a2b3c4e|300x250,300x600|f=0.42,gpid=/123123/gpt_publisher/adunit-code-3,c=d,',
       '/7780971/sparks_prebid_LB|30b31c1838de1e': '300x250,300x600|gpid=/7780971/sparks_prebid_LB,c=d,',
     };
@@ -635,12 +635,12 @@ describe('SonobiBidAdapter', function () {
           bidder: 'sonobi',
           mediaTypes: {
             video: {
-              context: 'outstream'
+              context: 'outstream',
+              playerSize: [640, 480]
             }
           },
           params: {
-            placement_id: '92e95368e86639dbd86d',
-            sizes: [[640, 480]]
+            placement_id: '92e95368e86639dbd86d'
           }
         }
       ]
@@ -658,7 +658,7 @@ describe('SonobiBidAdapter', function () {
             'sbi_adomain': 'sonobi.com'
           },
           '30b31c1838de1e': {
-            'sbi_size': '300x250',
+            'sbi_size': '640x480',
             'sbi_apoc': 'remnant',
             'sbi_aid': '30292e432662bd5f86d90774b944b038',
             'sbi_mouse': 1.25,
@@ -668,7 +668,7 @@ describe('SonobiBidAdapter', function () {
 
           },
           '/7780971/sparks_prebid_LB_OUTSTREAM|30b31c1838de1g': {
-            'sbi_size': '300x600',
+            'sbi_size': '640x480',
             'sbi_apoc': 'remnant',
             'sbi_crid': '1234abcd',
             'sbi_aid': '30292e432662bd5f86d90774b944b038',
@@ -720,8 +720,8 @@ describe('SonobiBidAdapter', function () {
       {
         'requestId': '30b31c1838de1e',
         'cpm': 1.25,
-        'width': 300,
-        'height': 250,
+        'width': 640,
+        'height': 480,
         'vastUrl': 'https://mco-1-apex.go.sonobi.com/vast.xml?vid=30292e432662bd5f86d90774b944b038&ref=https%3A%2F%2Flocalhost%2F',
         'ttl': 500,
         'creativeId': '30292e432662bd5f86d90774b944b038',
@@ -737,8 +737,8 @@ describe('SonobiBidAdapter', function () {
       {
         'requestId': '30b31c1838de1g',
         'cpm': 1.07,
-        'width': 300,
-        'height': 600,
+        'width': 640,
+        'height': 480,
         'ad': `<script type="text/javascript" src="https://mco-1-apex.go.sonobi.com/sbi.js?aid=30292e432662bd5f86d90774b944b038&as=null&ref=https%3A%2F%2Flocalhost%2F"></script>`,
         'ttl': 500,
         'creativeId': '1234abcd',