prebid.js 7.53.0 → 8.0.0

package/test/spec/modules/big-richmediaBidAdapter_spec.js

@@ -131,16 +131,6 @@ describe('bigRichMediaAdapterTests', function () {
   });
 
   describe('interpretResponse', function () {
-    let bfStub;
-
-    before(function() {
-      bfStub = sinon.stub(bidderFactory, 'getIabSubCategory');
-    });
-
-    after(function() {
-      bfStub.restore();
-    });
-
     const response = {
       'version': '3.0.0',
       'tags': [

package/test/spec/modules/bluebillywigBidAdapter_spec.js

@@ -1,10 +1,8 @@
-import { expect } from 'chai';
-import { spec } from 'modules/bluebillywigBidAdapter.js';
-import * as bidderFactory from 'src/adapters/bidderFactory.js';
-import { auctionManager } from 'src/auctionManager.js';
-import { deepClone, deepAccess } from 'src/utils.js';
-import { config } from 'src/config.js';
-import { VIDEO } from 'src/mediaTypes.js';
+import {expect} from 'chai';
+import {spec} from 'modules/bluebillywigBidAdapter.js';
+import {deepAccess, deepClone} from 'src/utils.js';
+import {config} from 'src/config.js';
+import {VIDEO} from 'src/mediaTypes.js';
 
 const BB_CONSTANTS = {
   BIDDER_CODE: 'bluebillywig',
@@ -254,7 +252,11 @@ describe('BlueBillywigAdapter', () => {
     const baseValidBidRequests = [baseValidBid];
 
     const validBidderRequest = {
-      auctionId: '12abc345-67d8-9012-e345-6f78901a2b34',
+      ortb2: {
+        source: {
+          tid: '12abc345-67d8-9012-e345-6f78901a2b34',
+        }
+      },
       auctionStart: 1585918458868,
       bidderCode: BB_CONSTANTS.BIDDER_CODE,
       bidderRequestId: '1a2345b67c8d9e0',
@@ -293,9 +295,9 @@ describe('BlueBillywigAdapter', () => {
       const request = spec.buildRequests(baseValidBidRequests, validBidderRequest);
       const payload = JSON.parse(request.data);
 
-      expect(payload.id).to.equal(validBidderRequest.auctionId);
+      expect(payload.id).to.exist;
       expect(payload.source).to.be.an('object');
-      expect(payload.source.tid).to.equal(validBidderRequest.auctionId);
+      expect(payload.source.tid).to.equal(validBidderRequest.ortb2.source.tid);
       expect(payload.tmax).to.equal(BB_CONSTANTS.DEFAULT_TIMEOUT);
       expect(payload.imp).to.be.an('array');
       expect(payload.test).to.be.a('number');

package/test/spec/modules/browsiBidAdapter_spec.js

@@ -64,7 +64,11 @@ describe('browsi Bid Adapter Test', function () {
           'sizes': [640, 480],
           'bidId': '12345678',
           'requestId': '1234567-3456-4562-7689-98765434A',
-          'transactionId': '1234567-3456-4562-7689-98765434B',
+          ortb2Imp: {
+            ext: {
+              tid: '1234567-3456-4562-7689-98765434B',
+            }
+          },
           'schain': {},
           'mediaTypes': {video: {playerSize: [640, 480]}}
         }
@@ -112,7 +116,7 @@ describe('browsi Bid Adapter Test', function () {
           video: {playerSize: [640, 480]},
           aUCode: inputRequest.adUnitCode,
           aID: inputRequest.auctionId,
-          tID: inputRequest.transactionId,
+          tID: inputRequest.ortb2Imp.ext.tid,
           schain: inputRequest.schain,
           params: inputRequest.params
         }
@@ -157,7 +161,6 @@ describe('browsi Bid Adapter Test', function () {
       const actualBidResponse = bidResponses[0];
       const expectedBidResponse = {
         requestId: bidRequest.data.bidId,
-        bidderCode: 'browsi',
         bidId: 'bidId1',
         width: 300,
         height: 250,

package/test/spec/modules/{emx_digitalBidAdapter_spec.js → cadentApertureMXBidAdapter_spec.js}

@@ -1,9 +1,9 @@
 import { expect } from 'chai';
-import { spec } from 'modules/emx_digitalBidAdapter.js';
+import { spec } from 'modules/cadentApertureMXBidAdapter.js';
 import * as utils from 'src/utils.js';
 import { newBidder } from 'src/adapters/bidderFactory.js';
 
-describe('emx_digital Adapter', function () {
+describe('cadent_aperture_mx Adapter', function () {
   describe('callBids', function () {
     const adapter = newBidder(spec);
     it('exists and is a function', function () {
@@ -14,7 +14,7 @@ describe('emx_digital Adapter', function () {
   describe('isBidRequestValid', function () {
     describe('banner request validity', function () {
       let bid = {
-        'bidder': 'emx_digital',
+        'bidder': 'cadent_aperture_mx',
         'params': {
           'tagid': '25251'
         },
@@ -33,7 +33,7 @@ describe('emx_digital Adapter', function () {
         'auctionId': '1d1a01234a475'
       };
       let badBid = {
-        'bidder': 'emx_digital',
+        'bidder': 'cadent_aperture_mx',
         'params': {
           'tagid': '25251'
         },
@@ -95,7 +95,7 @@ describe('emx_digital Adapter', function () {
 
     describe('video request validity', function () {
       let bid = {
-        'bidder': 'emx_digital',
+        'bidder': 'cadent_aperture_mx',
         'params': {
           'tagid': '25251',
           'video': {}
@@ -116,7 +116,7 @@ describe('emx_digital Adapter', function () {
         'auctionId': '1d1a01234a475'
       };
       let noInstreamBid = {
-        'bidder': 'emx_digital',
+        'bidder': 'cadent_aperture_mx',
         'params': {
           'tagid': '25251',
           'video': {
@@ -139,7 +139,7 @@ describe('emx_digital Adapter', function () {
       };
 
       let outstreamBid = {
-        'bidder': 'emx_digital',
+        'bidder': 'cadent_aperture_mx',
         'params': {
           'tagid': '25251',
           'video': {}
@@ -168,7 +168,7 @@ describe('emx_digital Adapter', function () {
 
       it('should contain tagid param', function () {
         expect(spec.isBidRequestValid({
-          bidder: 'emx_digital',
+          bidder: 'cadent_aperture_mx',
           params: {},
           mediaTypes: {
             banner: {
@@ -177,7 +177,7 @@ describe('emx_digital Adapter', function () {
           }
         })).to.equal(false);
         expect(spec.isBidRequestValid({
-          bidder: 'emx_digital',
+          bidder: 'cadent_aperture_mx',
           params: {
             tagid: ''
           },
@@ -188,7 +188,7 @@ describe('emx_digital Adapter', function () {
           }
         })).to.equal(false);
         expect(spec.isBidRequestValid({
-          bidder: 'emx_digital',
+          bidder: 'cadent_aperture_mx',
           params: {
             tagid: '123'
           },
@@ -204,7 +204,7 @@ describe('emx_digital Adapter', function () {
 
   describe('buildRequests', function () {
     let bidderRequest = {
-      'bidderCode': 'emx_digital',
+      'bidderCode': 'cadent_aperture_mx',
       'auctionId': 'e19f1eff-8b27-42a6-888d-9674e5a6130c',
       'bidderRequestId': '22edbae3120bf6',
       'timeout': 1500,
@@ -216,7 +216,7 @@ describe('emx_digital Adapter', function () {
         'ref': 'https://referrer.com'
       },
       'bids': [{
-        'bidder': 'emx_digital',
+        'bidder': 'cadent_aperture_mx',
         'params': {
           'tagid': '25251'
         },
@@ -464,7 +464,7 @@ describe('emx_digital Adapter', function () {
 
   describe('interpretResponse', function () {
     let bid = {
-      'bidder': 'emx_digital',
+      'bidder': 'cadent_aperture_mx',
       'params': {
         'tagid': '25251',
         'video': {}
@@ -488,7 +488,7 @@ describe('emx_digital Adapter', function () {
     const bid_outstream = {
       'bidderRequest': {
         'bids': [{
-          'bidder': 'emx_digital',
+          'bidder': 'cadent_aperture_mx',
           'params': {
             'tagid': '25251',
             'video': {}
@@ -508,7 +508,7 @@ describe('emx_digital Adapter', function () {
           'bidderRequestId': '22edbae3120bf6',
           'auctionId': '1d1a01234a475'
         }, {
-          'bidder': 'emx_digital',
+          'bidder': 'cadent_aperture_mx',
           'params': {
             'tagid': '25252',
             'video': {}
@@ -700,7 +700,7 @@ describe('emx_digital Adapter', function () {
     it('should not throw an error when decoding an improperly encoded adm', function () {
       const badAdmServerResponse = utils.deepClone(serverResponse);
       badAdmServerResponse.seatbid[0].bid[0].adm = '<script\\ src\\=\\\"https\\:\\/\\/nym1\\-ib\\.adnxs\\.com\\/ab\\?an_audit\\=0\\&referrer=https%3A%2F%2Fwww.emxdigital.com%3Ftest%3DhAiE3%VVl%26prebid%3D%25123%25\\&e\\=wqT_3QLPCfBDzwQAAAMA1gAFAQj2iaPtBRCdw\\-qeto72gkEYlNWN2smGoJhTKjYJzGJi83G9KkARzGJi83G9KkAZAAAAgD0KEkAhzGIJGwApESTIMQAAAGBmZu4_MMvWgAc4zApAzApIAlDo\\-YEUWNbsR2AAaIrFCnjOpQWAAQGKAQNVU0SSBQbwQJgB2AWgAVqoAQGwAQC4AQLAAQTIAQLQAQnYAQDgAQDwAQCKAjp1ZignYScsIDI4OTEwMSwgMTU3MTM0MTU1OCk7ARwscicsIDQxOTc1MDE2Nh4A9DQBkgLhAiE3VVlCWndpQmpwOEpFT2o1Z1JRWUFDRFc3RWN3QURnQVFBUkl6QXBReTlhQUIxZ0FZTHdFYUFCd0NuZ0FnQUZFaUFFQWtBRUFtQUVBb0FFQnFBRURzQUVBdVFGS1I2cF9jYjBxUU1FQlNrZXFmM0c5S2tESkFaR1JfRy1UVnRNXzJRRUFBQUFBQUFEd1AtQUJBUFVCQUFBQUFJQUNBSWdDcVlMWEJaQUNBWmdDQUtBQ0FLZ0NBTFVDQUFBQUFMMENBQUFBQU9BQ0FPZ0NBUGdDQUlBREFaZ0RBYWdEZ1k2ZkNib0RDVTVaVFRJNk5ESTRNdUFEOHhQNEE0NnV2Z3lJQkFDUUJBQ1lCQUd5QkFvSXFZTFhCUkNPcnI0TXdRUUFBQUFBQUFBQUFNa0VBQUFBBXgMQURSQgkJLEF3Q0ZBMkFRQThRUQ0SYEFBQVBnRUFJZ0Z1aUUumgKJASE2eElrelE2ZQGgMXV4SElBUW9BREU5Q3RlamNMMHFRRG9KVGxsTk1qbzBNamd5UVBNVFMRWAxQQV9VEQwMQUFBVx0MAFkdDABhHQwAYw0MAaXwi2VBQS7YAqwD4AK30UbqAlxodHRwczovL3d3dy5jZWxlYnV6ei5jb20vZy90YXlsb3Itc3dpZnQtZGVidXRzLXJlZC1oYWlyLWluLXN1Z2FybGFuZC12aWRlby8_YmlkZHJfZGVidWc9dHJ1ZfICEwoPQ1VTVE9NX01PREVMX0lEEgDyAhoKFkNVU1RPERY8TEVBRl9OQU1FEgDyAh4KGjYdAPQqAUFTVF9NT0RJRklFRBIAgAMAiAMBkAMAmAMUoAMBqgMAwAOsAsgDANgDlCHgAwDoAwD4AwOABACSBAkvb3BlbnJ0YjKYBACiBA8xNDQuMTIxLjIzMy4yMzeoBIkWsgQMCAAQABgAIAAwADgAuAQAwAQAyASxgoIB0gQOMTM1NiNOWU0yOjQyODLaBAIIAeAEAPAE6PmBFPoEEgkAAAAAZqdHQBEAAAAgWpRewIgFAZgFAKAF____________AaoFFjQ5MTgxNTcxMzQxNTU2NTI2OTQ5ZTHABQDJBQAAAAAAAPA_0gUJCQAAAAAAAAAA2AUB4AUB8AXW7gr6BQQIABAAkAYAmAYAuAYAwQYAAAAAAADwP8gGANAGwgTaBhYKEAAAAAAAAAAAAAAABQpQEAAYAOAGAfIGAggAgAcBiAcAoAcB\\&s\\=630dbbd55f593c7bfd9e7bccc4dbaa28203daaed\\&pp\\=\\$\\{EMX_MACRO\\}\\\"\\>\\<\\/script\\>';
-      badAdmServerResponse.seatbid[1].bid[0].adm = '%3F%%3Demx%3C3prebid';
+      badAdmServerResponse.seatbid[1].bid[0].adm = '%3F%%3Dcadent%3C3prebid';
 
       assert.doesNotThrow(() => spec.interpretResponse({
         body: badAdmServerResponse

package/test/spec/modules/ccxBidAdapter_spec.js

@@ -81,7 +81,7 @@ describe('ccxAdapter', function () {
     });
 
     it('Valid bid request - default', function () {
-      let response = spec.buildRequests(bids, {bids});
+      let response = spec.buildRequests(bids, {bids, bidderRequestId: 'id'});
       expect(response).to.be.not.empty;
       expect(response.data).to.be.not.empty;
 

package/test/spec/modules/cleanmedianetBidAdapter_spec.js

@@ -310,7 +310,7 @@ describe('CleanmedianetAdapter', () => {
       response = spec.buildRequests([bidRequest], bidRequest)[0];
       expect(response.method).to.equal('POST');
       expect(response.url).to.match(new RegExp(`^https://bidder\\.cleanmediaads\\.com/r/${supplyPartnerId}/bidr\\?rformat=open_rtb&reqformat=rtb_json&bidder=prebid$`, 'g'));
-      expect(response.data.id).to.equal(bidRequest.auctionId);
+      expect(response.data.id).to.equal(bidRequest.bidId);
       const bidRequestWithEndpoint = utils.deepClone(bidRequest);
       bidRequestWithEndpoint.params.rtbEndpoint = 'https://bidder.cleanmediaads.com/a12';
       response = spec.buildRequests([bidRequestWithEndpoint], bidRequest)[0];
@@ -330,7 +330,7 @@ describe('CleanmedianetAdapter', () => {
       expect(response.data.site.page).to.equal('http://www.test.com/page.html');
       expect(response.data.site.ref).to.equal('http://referrer.com');
       expect(response.data.imp.length).to.equal(1);
-      expect(response.data.imp[0].id).to.equal(bidRequest.transactionId);
+      expect(response.data.imp[0].id).to.equal(bidRequest.bidId);
       expect(response.data.imp[0].instl).to.equal(0);
       expect(response.data.imp[0].tagid).to.equal(bidRequest.adUnitCode);
       expect(response.data.imp[0].bidfloor).to.equal(0);

package/test/spec/modules/codefuelBidAdapter_spec.js

@@ -1,6 +1,7 @@
 import {expect} from 'chai';
 import {spec} from 'modules/codefuelBidAdapter.js';
 import {config} from 'src/config.js';
+import * as utils from 'src/utils.js';
 import {server} from 'test/mocks/xhr';
 
 const USER_AGENT = 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/92.0.4515.159 Safari/537.36';
@@ -9,6 +10,13 @@ const setUADefault = () => { window.navigator.__defineGetter__('userAgent', func
 const setUAMock = () => { window.navigator.__defineGetter__('userAgent', function () { return USER_AGENT }) };
 
 describe('Codefuel Adapter', function () {
+  let sandbox;
+  beforeEach(() => {
+    sandbox = sinon.sandbox.create();
+  });
+  afterEach(() => {
+    sandbox.restore();
+  })
   describe('Bid request and response', function () {
     const commonBidRequest = {
       bidder: 'codefuel',
@@ -137,6 +145,7 @@ describe('Codefuel Adapter', function () {
 
       const commonBidderRequest = {
         timeout: 500,
+        bidderRequestId: 'mock-uuid',
         auctionId: '12043683-3254-4f74-8934-f941b085579e',
         refererInfo: {
           page: 'https://example.com/',
@@ -157,7 +166,7 @@ describe('Codefuel Adapter', function () {
             devicetype: 2,
             ua: 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) HeadlessChrome/92.0.4515.159 Safari/537.36'
           },
-          id: '12043683-3254-4f74-8934-f941b085579e',
+          id: 'mock-uuid',
           imp: [
             {
               banner: {

package/test/spec/modules/colossussspBidAdapter_spec.js

@@ -19,12 +19,12 @@ describe('ColossussspAdapter', function () {
     },
     ortb2Imp: {
       ext: {
+        tid: '3bb2f6da-87a6-4029-aeb0-bfe951372e62',
         data: {
           pbadslot: '/19968336/prebid_cache_video_adunit'
         }
       }
     },
-    transactionId: '3bb2f6da-87a6-4029-aeb0-bfe951372e62',
     schain: {
       ver: '1.0',
       complete: 1,

package/test/spec/modules/concertBidAdapter_spec.js

@@ -48,7 +48,11 @@ describe('ConcertAdapter', function () {
         },
         adUnitCode: 'desktop_leaderboard_variable',
         bidId: 'foo',
-        transactionId: '',
+        ortb2Imp: {
+          ext: {
+            tid: ''
+          }
+        },
         sizes: [[1030, 590]]
       }
     ];

package/test/spec/modules/conversantBidAdapter_spec.js

@@ -256,6 +256,11 @@ describe('Conversant adapter tests', function() {
     const bidderRequest = {
       refererInfo: {
         page: page
+      },
+      ortb2: {
+        source: {
+          tid: 'tid000'
+        }
       }
     };
     const request = spec.buildRequests(bidRequests, bidderRequest);
@@ -263,8 +268,8 @@ describe('Conversant adapter tests', function() {
     expect(request.url).to.equal('https://web.hb.ad.cpe.dotomi.com/cvx/client/hb/ortb/25');
     const payload = request.data;
 
-    expect(payload).to.have.property('id', 'req000');
-    expect(payload.source).to.have.property('tid', 'req000');
+    expect(payload).to.have.property('id');
+    expect(payload.source).to.have.property('tid', 'tid000');
     expect(payload).to.have.property('at', 1);
     expect(payload).to.have.property('imp');
     expect(payload.imp).to.be.an('array').with.lengthOf(8);

package/test/spec/modules/criteoBidAdapter_spec.js

@@ -604,13 +604,67 @@ describe('The Criteo bidding adapter', function () {
       config.resetConfig();
     });
 
+    it('should properly build a request using random uuid as auction id', function () {
+      const generateUUIDStub = sinon.stub(utils, 'generateUUID');
+      generateUUIDStub.returns('def');
+      const bidderRequest = {
+      };
+      const bidRequests = [
+        {
+          bidder: 'criteo',
+          adUnitCode: 'bid-123',
+          transactionId: 'transaction-123',
+          mediaTypes: {
+            banner: {
+              sizes: [[728, 90]]
+            }
+          },
+          params: {}
+        },
+      ];
+      const request = spec.buildRequests(bidRequests, bidderRequest);
+      const ortbRequest = request.data;
+      expect(ortbRequest.id).to.equal('def');
+      generateUUIDStub.restore();
+    });
+
+    it('should properly transmit source.tid if available', function () {
+      const bidderRequest = {
+        ortb2: {
+          source: {
+            tid: 'abc'
+          }
+        }
+      };
+      const bidRequests = [
+        {
+          bidder: 'criteo',
+          adUnitCode: 'bid-123',
+          transactionId: 'transaction-123',
+          mediaTypes: {
+            banner: {
+              sizes: [[728, 90]]
+            }
+          },
+          params: {}
+        },
+      ];
+      const request = spec.buildRequests(bidRequests, bidderRequest);
+      const ortbRequest = request.data;
+      expect(ortbRequest.source.tid).to.equal('abc');
+    });
+
     it('should properly build a request if refererInfo is not provided', function () {
       const bidderRequest = {};
       const bidRequests = [
         {
           bidder: 'criteo',
           adUnitCode: 'bid-123',
-          transactionId: 'transaction-123',
+          ortb2Imp: {
+            ext: {
+              tid: 'transaction-123',
+            },
+          },
           mediaTypes: {
             banner: {
               sizes: [[728, 90]]
@@ -629,7 +683,11 @@ describe('The Criteo bidding adapter', function () {
         {
           bidder: 'criteo',
           adUnitCode: 'bid-123',
-          transactionId: 'transaction-123',
+          ortb2Imp: {
+            ext: {
+              tid: 'transaction-123',
+            },
+          },
           mediaTypes: {
             banner: {
               sizes: [[728, 90]]
@@ -842,7 +900,11 @@ describe('The Criteo bidding adapter', function () {
         {
           bidder: 'criteo',
           adUnitCode: 'bid-123',
-          transactionId: 'transaction-123',
+          ortb2Imp: {
+            ext: {
+              tid: 'transaction-123',
+            },
+          },
           mediaTypes: {
             banner: {
               sizes: [[300, 250], [728, 90]]
@@ -881,7 +943,11 @@ describe('The Criteo bidding adapter', function () {
         {
           bidder: 'criteo',
           adUnitCode: 'bid-123',
-          transactionId: 'transaction-123',
+          ortb2Imp: {
+            ext: {
+              tid: 'transaction-123',
+            },
+          },
           mediaTypes: {
             banner: {
               sizes: [[728, 90]]
@@ -894,7 +960,11 @@ describe('The Criteo bidding adapter', function () {
         {
           bidder: 'criteo',
           adUnitCode: 'bid-234',
-          transactionId: 'transaction-234',
+          ortb2Imp: {
+            ext: {
+              tid: 'transaction-234',
+            },
+          },
           mediaTypes: {
             banner: {
               sizes: [[300, 250], [728, 90]]
@@ -1063,7 +1133,7 @@ describe('The Criteo bidding adapter', function () {
     });
 
     it('should properly build a request with bcat field', function () {
-      const bcat = [ 'IAB1', 'IAB2' ];
+      const bcat = ['IAB1', 'IAB2'];
       const bidRequests = [
         {
           bidder: 'criteo',
@@ -1091,7 +1161,7 @@ describe('The Criteo bidding adapter', function () {
     });
 
     it('should properly build a request with badv field', function () {
-      const badv = [ 'ford.com' ];
+      const badv = ['ford.com'];
       const bidRequests = [
         {
           bidder: 'criteo',
@@ -1119,7 +1189,7 @@ describe('The Criteo bidding adapter', function () {
     });
 
     it('should properly build a request with bapp field', function () {
-      const bapp = [ 'com.foo.mygame' ];
+      const bapp = ['com.foo.mygame'];
       const bidRequests = [
         {
           bidder: 'criteo',

package/test/spec/modules/currency_spec.js

@@ -366,15 +366,15 @@ describe('currency', function () {
       expect(innerBid.cpm).to.equal(1);
     });
 
-    it('should result in NO_BID when currency support is not enabled and fromCurrency is not USD', function () {
+    it('should reject bid when currency support is not enabled and fromCurrency is not USD', function () {
       setConfig({});
 
       var bid = makeBid({ 'cpm': 1, 'currency': 'GBP' });
-      var innerBid;
+      let bidAdded = false;
       addBidResponseHook(function(adCodeId, bid) {
-        innerBid = bid;
+        bidAdded = true;
       }, 'elementId', bid, reject);
-      expect(innerBid.status).to.equal('rejected');
+      expect(bidAdded).to.be.false;
       expect(reject.calledOnce).to.be.true;
     });
 
@@ -390,7 +390,7 @@ describe('currency', function () {
       expect(bid).to.equal(innerBid);
     });
 
-    it('should result in NO_BID when fromCurrency is not supported in file', function () {
+    it('should reject bid when fromCurrency is not supported in file', function () {
       // RESET to request currency file
       setConfig({ 'adServerCurrency': undefined });
 
@@ -398,24 +398,24 @@ describe('currency', function () {
       setConfig({ 'adServerCurrency': 'JPY' });
       fakeCurrencyFileServer.respond();
       var bid = makeBid({ 'cpm': 1, 'currency': 'ABC' });
-      var innerBid;
+      let bidAdded = false;
       addBidResponseHook(function(adCodeId, bid) {
-        innerBid = bid;
+        bidAdded = true;
       }, 'elementId', bid, reject);
-      expect(innerBid.status).to.equal('rejected');
+      expect(bidAdded).to.be.false;
       expect(reject.calledOnce).to.be.true;
     });
 
-    it('should result in NO_BID when adServerCurrency is not supported in file', function () {
+    it('should reject bid when adServerCurrency is not supported in file', function () {
       fakeCurrencyFileServer.respondWith(JSON.stringify(getCurrencyRates()));
       setConfig({ 'adServerCurrency': 'ABC' });
       fakeCurrencyFileServer.respond();
       var bid = makeBid({ 'cpm': 1, 'currency': 'GBP' });
-      var innerBid;
+      let bidAdded = false;
       addBidResponseHook(function(adCodeId, bid) {
-        innerBid = bid;
+        bidAdded = true;
       }, 'elementId', bid, reject);
-      expect(innerBid.status).to.equal('rejected');
+      expect(bidAdded).to.be.false;
       expect(reject.calledOnce).to.be.true;
     });
 

package/test/spec/modules/datawrkzBidAdapter_spec.js

@@ -462,7 +462,6 @@ describe('datawrkzAdapterTests', function () {
       expect(result[0].ad).to.equal(decodeURIComponent(serverResponse.body.seatbid[0].bid[0].adm + '<img src="' + serverResponse.body.seatbid[0].bid[0].nurl + '" height="0px" width="0px">'));
       expect(result[0].creativeId).to.equal('1');
       expect(result[0].bidderCode).to.equal(request.bidRequest.bidder);
-      expect(result[0].transactionId).to.equal(request.bidRequest.transactionId);
       expect(result[0].mediaType).to.equal('banner');
     });
 
@@ -540,7 +539,6 @@ describe('datawrkzAdapterTests', function () {
       expect(result[0].native.desc).to.equal('Test body');
       expect(result[0].creativeId).to.equal('1');
       expect(result[0].bidderCode).to.equal(request.bidRequest.bidder);
-      expect(result[0].transactionId).to.equal(request.bidRequest.transactionId);
       expect(result[0].mediaType).to.equal('native');
     });
 
@@ -610,7 +608,6 @@ describe('datawrkzAdapterTests', function () {
       expect(result[0].adserverTargeting.hb_protocol).to.equal('3');
       expect(result[0].creativeId).to.equal('1');
       expect(result[0].bidderCode).to.equal(request.bidRequest.bidder);
-      expect(result[0].transactionId).to.equal(request.bidRequest.transactionId);
       expect(result[0].mediaType).to.equal('video');
     });
 
@@ -649,7 +646,6 @@ describe('datawrkzAdapterTests', function () {
       expect(result[0].renderer).to.exist;
       expect(result[0].creativeId).to.equal('1');
       expect(result[0].bidderCode).to.equal(request.bidRequest.bidder);
-      expect(result[0].transactionId).to.equal(request.bidRequest.transactionId);
       expect(result[0].mediaType).to.equal('video');
     });
   });

package/test/spec/modules/dianomiBidAdapter_spec.js

@@ -162,7 +162,7 @@ describe('Dianomi adapter', () => {
         },
       ];
       let request = JSON.parse(
-        spec.buildRequests(validBidRequests, { refererInfo: { page: 'page' }, auctionId: 'tid' }).data
+        spec.buildRequests(validBidRequests, {refererInfo: {page: 'page'}, ortb2: {source: {tid: 'tid'}}}).data
       );
 
       assert.equal(request.source.tid, 'tid');