prebid.js 7.51.0 → 7.52.0

package/test/spec/modules/undertoneBidAdapter_spec.js

@@ -41,7 +41,9 @@ const videoBidReq = [{
   },
   mediaTypes: {video: {
     context: 'outstream',
-    playerSize: [640, 480]
+    playerSize: [640, 480],
+    placement: 1,
+    plcmt: 1
   }},
   sizes: [[300, 250], [300, 600]],
   bidId: '263be71e91dd9d',
@@ -184,6 +186,31 @@ const bidderReqCcpaAndGdpr = {
   uspConsent: 'NY12'
 };
 
+const bidderReqGpp = {
+  refererInfo: {
+    topmostLocation: 'http://prebid.org/dev-docs/bidder-adaptor.html'
+  },
+  gppConsent: {
+    gppString: 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN',
+    applicableSections: [7]
+  }
+};
+
+const bidderReqFullGppCcpaGdpr = {
+  refererInfo: {
+    topmostLocation: 'http://prebid.org/dev-docs/bidder-adaptor.html'
+  },
+  gppConsent: {
+    gppString: 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN',
+    applicableSections: [7]
+  },
+  gdprConsent: {
+    gdprApplies: true,
+    consentString: 'gdprConsent'
+  },
+  uspConsent: '1YNN'
+};
+
 const validBidRes = {
   ad: '<div>Hello</div>',
   publisherId: 12345,
@@ -381,6 +408,31 @@ describe('Undertone Adapter', () => {
       expect(request.url).to.equal(REQ_URL);
       expect(request.method).to.equal('POST');
     });
+    it(`should have gppConsent fields`, function () {
+      const request = spec.buildRequests(bidReq, bidderReqGpp);
+      const domainStart = bidderReq.refererInfo.topmostLocation.indexOf('//');
+      const domainEnd = bidderReq.refererInfo.topmostLocation.indexOf('/', domainStart + 2);
+      const domain = bidderReq.refererInfo.topmostLocation.substring(domainStart + 2, domainEnd);
+      const gppStr = bidderReqGpp.gppConsent.gppString;
+      const gppSid = bidderReqGpp.gppConsent.applicableSections;
+      const REQ_URL = `${URL}?pid=${bidReq[0].params.publisherId}&domain=${domain}&gpp=${gppStr}&gpp_sid=${gppSid}`;
+      expect(request.url).to.equal(REQ_URL);
+      expect(request.method).to.equal('POST');
+    });
+    it(`should have gpp, ccpa and gdpr fields`, function () {
+      const request = spec.buildRequests(bidReq, bidderReqFullGppCcpaGdpr);
+      const domainStart = bidderReq.refererInfo.topmostLocation.indexOf('//');
+      const domainEnd = bidderReq.refererInfo.topmostLocation.indexOf('/', domainStart + 2);
+      const domain = bidderReq.refererInfo.topmostLocation.substring(domainStart + 2, domainEnd);
+      const gppStr = bidderReqFullGppCcpaGdpr.gppConsent.gppString;
+      const gppSid = bidderReqFullGppCcpaGdpr.gppConsent.applicableSections;
+      const ccpa = bidderReqFullGppCcpaGdpr.uspConsent;
+      const gdpr = bidderReqFullGppCcpaGdpr.gdprConsent.gdprApplies ? 1 : 0;
+      const gdprStr = bidderReqFullGppCcpaGdpr.gdprConsent.consentString;
+      const REQ_URL = `${URL}?pid=${bidReq[0].params.publisherId}&domain=${domain}&gdpr=${gdpr}&gdprstr=${gdprStr}&ccpa=${ccpa}&gpp=${gppStr}&gpp_sid=${gppSid}`;
+      expect(request.url).to.equal(REQ_URL);
+      expect(request.method).to.equal('POST');
+    });
     it('should have all relevant fields', function () {
       const request = spec.buildRequests(bidReq, bidderReq);
       const bid1 = JSON.parse(request.data)['x-ut-hb-params'][0];
@@ -409,10 +461,14 @@ describe('Undertone Adapter', () => {
       expect(bidVideo.video.playbackMethod).to.equal(2);
       expect(bidVideo.video.maxDuration).to.equal(30);
       expect(bidVideo.video.skippable).to.equal(true);
+      expect(bidVideo.video.placement).to.equal(1);
+      expect(bidVideo.video.plcmt).to.equal(1);
 
       expect(bidVideo2.video.skippable).to.equal(null);
       expect(bidVideo2.video.maxDuration).to.equal(null);
       expect(bidVideo2.video.playbackMethod).to.equal(null);
+      expect(bidVideo2.video.placement).to.equal(null);
+      expect(bidVideo2.video.plcmt).to.equal(null);
     });
     it('should send all userIds data to server', function () {
       const request = spec.buildRequests(bidReqUserIds, bidderReq);

package/test/spec/modules/userId_spec.js

@@ -1,25 +1,25 @@
 import {
   attachIdSystem,
   auctionDelay,
-  coreStorage,
+  coreStorage, dep,
+  findRootDomain,
   init,
+  PBJS_USER_ID_OPTOUT_NAME,
   requestBidsHook,
+  requestDataDeletion,
   setStoredConsentData,
   setStoredValue,
   setSubmoduleRegistry,
   syncDelay,
-  PBJS_USER_ID_OPTOUT_NAME,
-  findRootDomain, requestDataDeletion,
 } from 'modules/userId/index.js';
 import {createEidsArray} from 'modules/userId/eids.js';
 import {config} from 'src/config.js';
 import * as utils from 'src/utils.js';
+import {getPrebidInternal} from 'src/utils.js';
 import * as events from 'src/events.js';
 import CONSTANTS from 'src/constants.json';
 import {getGlobal} from 'src/prebidGlobal.js';
-import {
-  resetConsentData,
-} from 'modules/consentManagement.js';
+import {resetConsentData, } from 'modules/consentManagement.js';
 import {server} from 'test/mocks/xhr.js';
 import {find} from 'src/polyfill.js';
 import {unifiedIdSubmodule} from 'modules/unifiedIdSystem.js';
@@ -27,7 +27,10 @@ import {britepoolIdSubmodule} from 'modules/britepoolIdSystem.js';
 import {id5IdSubmodule} from 'modules/id5IdSystem.js';
 import {identityLinkSubmodule} from 'modules/identityLinkIdSystem.js';
 import {dmdIdSubmodule} from 'modules/dmdIdSystem.js';
-import {liveIntentIdSubmodule, setEventFiredFlag as liveIntentIdSubmoduleDoNotFireEvent} from 'modules/liveIntentIdSystem.js';
+import {
+  liveIntentIdSubmodule,
+  setEventFiredFlag as liveIntentIdSubmoduleDoNotFireEvent
+} from 'modules/liveIntentIdSystem.js';
 import {merkleIdSubmodule} from 'modules/merkleIdSystem.js';
 import {netIdSubmodule} from 'modules/netIdSystem.js';
 import {intentIqIdSubmodule} from 'modules/intentIqIdSystem.js';
@@ -39,7 +42,6 @@ import {criteoIdSubmodule} from 'modules/criteoIdSystem.js';
 import {mwOpenLinkIdSubModule} from 'modules/mwOpenLinkIdSystem.js';
 import {tapadIdSubmodule} from 'modules/tapadIdSystem.js';
 import {tncidSubModule} from 'modules/tncIdSystem.js';
-import {getPrebidInternal} from 'src/utils.js';
 import {uid2IdSubmodule} from 'modules/uid2IdSystem.js';
 import {admixerIdSubmodule} from 'modules/admixerIdSystem.js';
 import {deepintentDpesSubmodule} from 'modules/deepintentDpesIdSystem.js';
@@ -55,6 +57,8 @@ import {getPPID} from '../../../src/adserver.js';
 import {uninstall as uninstallGdprEnforcement} from 'modules/gdprEnforcement.js';
 import {GDPR_GVLIDS} from '../../../src/consentHandler.js';
 import {MODULE_TYPE_UID} from '../../../src/activities/modules.js';
+import {ACTIVITY_ENRICH_EIDS} from '../../../src/activities/activities.js';
+import {ACTIVITY_PARAM_COMPONENT_NAME, ACTIVITY_PARAM_COMPONENT_TYPE} from '../../../src/activities/params.js';
 
 let assert = require('chai').assert;
 let expect = require('chai').expect;
@@ -188,8 +192,7 @@ describe('User ID', function () {
       mockGpt.disable();
       mockGpt.enable();
       coreStorage.setCookie('pubcid', '', EXPIRED_COOKIE_DATE);
-      coreStorage.setCookie('pubcid_alt', 'altpubcid200000', (new Date(Date.now() + 5000).toUTCString()));
-      let origSK = coreStorage.setCookie.bind(coreStorage);
+      coreStorage.setCookie('pubcid_alt', 'altpubcid200000', (new Date(Date.now() + 20000).toUTCString()));
       sinon.spy(coreStorage, 'setCookie');
       sinon.stub(utils, 'logWarn');
     });
@@ -320,10 +323,6 @@ describe('User ID', function () {
             });
           });
         });
-        // Because the consent cookie doesn't exist yet, we'll have 2 setCookie calls:
-        // 1) for the consent cookie
-        // 2) from the getId() call that results in a new call to store the results
-        expect(coreStorage.setCookie.callCount).to.equal(2);
       });
     });
 
@@ -350,7 +349,6 @@ describe('User ID', function () {
             });
           });
         });
-        expect(coreStorage.setCookie.callCount).to.equal(2);
       });
     });
 
@@ -2506,6 +2504,53 @@ describe('User ID', function () {
           done();
         }, {adUnits});
       });
+
+      describe('activity controls', () => {
+        let isAllowed;
+        const MOCK_IDS = ['mockId1', 'mockId2']
+        beforeEach(() => {
+          isAllowed = sinon.stub(dep, 'isAllowed');
+          init(config);
+          setSubmoduleRegistry([]);
+          const mods = MOCK_IDS.map((name) => ({
+            name,
+            decode: function (value) {
+              return {
+                [name]: value
+              };
+            },
+            getId: function () {
+              return {id: `${name}Value`};
+            }
+          }));
+          mods.forEach(attachIdSystem);
+        });
+        afterEach(() => {
+          isAllowed.restore();
+        });
+
+        it('should check for enrichEids activity permissions', (done) => {
+          isAllowed.callsFake((activity, params) => {
+            return !(activity === ACTIVITY_ENRICH_EIDS &&
+              params[ACTIVITY_PARAM_COMPONENT_TYPE] === MODULE_TYPE_UID &&
+              params[ACTIVITY_PARAM_COMPONENT_NAME] === MOCK_IDS[0])
+          })
+
+          config.setConfig({
+            userSync: {
+              syncDelay: 0,
+              userIds: MOCK_IDS.map(name => ({
+                name, storage: {name, type: 'cookie'}
+              }))
+            }
+          });
+          requestBidsHook((req) => {
+            const activeIds = req.adUnits.flatMap(au => au.bids).flatMap(bid => Object.keys(bid.userId));
+            expect(Array.from(new Set(activeIds))).to.have.members([MOCK_IDS[1]]);
+            done();
+          }, {adUnits})
+        });
+      })
     });
 
     describe('callbacks at the end of auction', function () {
@@ -2591,15 +2636,21 @@ describe('User ID', function () {
     });
 
     describe('Set cookie behavior', function () {
-      let coreStorageSpy;
+      let cookie, cookieStub;
+
       beforeEach(function () {
-        coreStorageSpy = sinon.spy(coreStorage, 'setCookie');
         setSubmoduleRegistry([sharedIdSystemSubmodule]);
         init(config);
+        cookie = document.cookie;
+        cookieStub = sinon.stub(document, 'cookie');
+        cookieStub.get(() => cookie);
+        cookieStub.set((val) => cookie = val);
       });
+
       afterEach(function () {
-        coreStorageSpy.restore();
+        cookieStub.restore();
       });
+
       it('should allow submodules to override the domain', function () {
         const submodule = {
           submodule: {
@@ -2608,26 +2659,34 @@ describe('User ID', function () {
             }
           },
           config: {
+            name: 'mockId',
             storage: {
               type: 'cookie'
             }
+          },
+          storageMgr: {
+            setCookie: sinon.stub()
           }
         }
         setStoredValue(submodule, 'bar');
-        expect(coreStorage.setCookie.getCall(0).args[4]).to.equal('foo.com');
+        expect(submodule.storageMgr.setCookie.getCall(0).args[4]).to.equal('foo.com');
       });
 
-      it('should pass null for domain if submodule does not override the domain', function () {
+      it('should pass no domain if submodule does not override the domain', function () {
         const submodule = {
           submodule: {},
           config: {
+            name: 'mockId',
             storage: {
               type: 'cookie'
             }
+          },
+          storageMgr: {
+            setCookie: sinon.stub()
           }
         }
         setStoredValue(submodule, 'bar');
-        expect(coreStorage.setCookie.getCall(0).args[4]).to.equal(null);
+        expect(submodule.storageMgr.setCookie.getCall(0).args[4]).to.equal(null);
       });
     });
 

package/test/spec/modules/yahoosspBidAdapter_spec.js

@@ -89,11 +89,16 @@ let generateBidderRequest = (bidRequestArray, adUnitCode, ortb2 = {}) => {
       numIframes: 0,
       stack: ['https://publisher-test.com'],
     },
+    uspConsent: '1-Y-',
     gdprConsent: {
       consentString: 'BOtmiBKOtmiBKABABAENAFAAAAACeAAA',
       vendorData: {},
       gdprApplies: true
     },
+    gppConsent: {
+      gppString: 'DBACNYA~CPXxRfAPXxRfAAfKABENB-CgAAAAAAAAAAYgAAAAAAAA~1YNN',
+      applicableSections: [1, 2, 3]
+    },
     start: new Date().getTime(),
     timeout: 1000,
     ortb2
@@ -177,11 +182,6 @@ const generateResponseMock = (admPayloadType, vastVersion, videoContext) => {
 
 // Unit tests
 describe('YahooSSP Bid Adapter:', () => {
-  it('PLACEHOLDER TO PASS GULP', () => {
-    const obj = {};
-    expect(obj).to.be.an('object');
-  });
-
   describe('Validate basic properties', () => {
     it('should define the correct bidder code', () => {
       expect(spec.code).to.equal('yahoossp')
@@ -193,40 +193,38 @@ describe('YahooSSP Bid Adapter:', () => {
   });
 
   describe('getUserSyncs()', () => {
-    const IMAGE_PIXEL_URL = 'http://image-pixel.com/foo/bar?1234&baz=true';
-    const IFRAME_ONE_URL = 'http://image-iframe.com/foo/bar?1234&baz=true';
+    const IMAGE_PIXEL_URL = 'http://image-pixel.com/foo/bar?1234&baz=true&gdpr=foo&gdpr_consent=bar';
+    const IFRAME_ONE_URL = 'http://image-iframe.com/foo/bar?1234&baz=true&us_privacy=hello&gpp=goodbye';
     const IFRAME_TWO_URL = 'http://image-iframe-two.com/foo/bar?1234&baz=true';
-
-    let serverResponses = [];
-    beforeEach(() => {
-      serverResponses[0] = {
-        body: {
-          ext: {
-            pixels: `<script>document.write('<iframe src="${IFRAME_ONE_URL}"></iframe>` +
-                    `<img src="${IMAGE_PIXEL_URL}"></iframe>` +
-                    `<iframe src="${IFRAME_TWO_URL}"></iframe>');</script>`
-          }
+    const SERVER_RESPONSES = [{
+      body: {
+        ext: {
+          pixels: `<script>document.write('<iframe src="${IFRAME_ONE_URL}"></iframe>` +
+                  `<img src="${IMAGE_PIXEL_URL}"></iframe>` +
+                  `<iframe src="${IFRAME_TWO_URL}"></iframe>');</script>`
         }
       }
-    });
-
-    after(() => {
-      serverResponses = undefined;
-    });
+    }];
+    const bidderRequest = generateBuildRequestMock({}).bidderRequest;
 
     it('for only iframe enabled syncs', () => {
       let syncOptions = {
         iframeEnabled: true,
         pixelEnabled: false
       };
-      let pixelsObjects = spec.getUserSyncs(syncOptions, serverResponses);
-      expect(pixelsObjects.length).to.equal(2);
-      expect(pixelsObjects).to.deep.equal(
-        [
-          {type: 'iframe', 'url': IFRAME_ONE_URL},
-          {type: 'iframe', 'url': IFRAME_TWO_URL}
-        ]
-      )
+      let pixelObjects = spec.getUserSyncs(
+        syncOptions,
+        SERVER_RESPONSES,
+        bidderRequest.gdprConsent,
+        bidderRequest.uspConsent,
+        bidderRequest.gppConsent
+      );
+      expect(pixelObjects.length).to.equal(2);
+
+      pixelObjects.forEach(pixelObject => {
+        expect(pixelObject).to.have.all.keys('type', 'url');
+        expect(pixelObject.type).to.equal('iframe');
+      });
     });
 
     it('for only pixel enabled syncs', () => {
@@ -234,13 +232,16 @@ describe('YahooSSP Bid Adapter:', () => {
         iframeEnabled: false,
         pixelEnabled: true
       };
-      let pixelsObjects = spec.getUserSyncs(syncOptions, serverResponses);
-      expect(pixelsObjects.length).to.equal(1);
-      expect(pixelsObjects).to.deep.equal(
-        [
-          {type: 'image', 'url': IMAGE_PIXEL_URL}
-        ]
-      )
+      let pixelObjects = spec.getUserSyncs(
+        syncOptions,
+        SERVER_RESPONSES,
+        bidderRequest.gdprConsent,
+        bidderRequest.uspConsent,
+        bidderRequest.gppConsent
+      );
+      expect(pixelObjects.length).to.equal(1);
+      expect(pixelObjects[0]).to.have.all.keys('type', 'url');
+      expect(pixelObjects[0].type).to.equal('image');
     });
 
     it('for both pixel and iframe enabled syncs', () => {
@@ -248,15 +249,56 @@ describe('YahooSSP Bid Adapter:', () => {
         iframeEnabled: true,
         pixelEnabled: true
       };
-      let pixelsObjects = spec.getUserSyncs(syncOptions, serverResponses);
-      expect(pixelsObjects.length).to.equal(3);
-      expect(pixelsObjects).to.deep.equal(
-        [
-          {type: 'iframe', 'url': IFRAME_ONE_URL},
-          {type: 'image', 'url': IMAGE_PIXEL_URL},
-          {type: 'iframe', 'url': IFRAME_TWO_URL}
-        ]
-      )
+      let pixelObjects = spec.getUserSyncs(
+        syncOptions,
+        SERVER_RESPONSES,
+        bidderRequest.gdprConsent,
+        bidderRequest.uspConsent,
+        bidderRequest.gppConsent
+      );
+      expect(pixelObjects.length).to.equal(3);
+      let iframeCount = 0;
+      let imageCount = 0;
+      pixelObjects.forEach(pixelObject => {
+        if (pixelObject.type == 'iframe') {
+          iframeCount++;
+        } else if (pixelObject.type == 'image') {
+          imageCount++;
+        }
+      });
+      expect(iframeCount).to.equal(2);
+      expect(imageCount).to.equal(1);
+    });
+
+    describe('user consent parameters are updated', () => {
+      let syncOptions = {
+        iframeEnabled: true,
+        pixelEnabled: true
+      };
+      let pixelObjects = spec.getUserSyncs(
+        syncOptions,
+        SERVER_RESPONSES,
+        bidderRequest.gdprConsent,
+        bidderRequest.uspConsent,
+        bidderRequest.gppConsent
+      );
+      pixelObjects.forEach(pixelObject => {
+        let url = pixelObject.url;
+        let urlParams = new URL(url).searchParams;
+        const expectedParams = {
+          'baz': 'true',
+          'gdpr_consent': bidderRequest.gdprConsent.consentString,
+          'gdpr': bidderRequest.gdprConsent.gdprApplies ? '1' : '0',
+          'us_privacy': bidderRequest.uspConsent,
+          'gpp': bidderRequest.gppConsent.gppString,
+          'gpp_sid': Array.isArray(bidderRequest.gppConsent.applicableSections) ? bidderRequest.gppConsent.applicableSections.join(',') : ''
+        }
+        for (const [key, value] of Object.entries(expectedParams)) {
+          it(`Updates the ${key} consent param in user sync URL ${url}`, () => {
+            expect(urlParams.get(key)).to.equal(value);
+          });
+        };
+      });
     });
   });
 
@@ -749,7 +791,15 @@ describe('YahooSSP Bid Adapter:', () => {
       expect(options.withCredentials).to.be.false;
     });
 
-    it('adds the ortb2 gpp consent info to the request', function () {
+    it('set the GPP consent data from the data within the bid request', function () {
+      const { validBidRequests, bidderRequest } = generateBuildRequestMock({});
+      let clonedBidderRequest = {...bidderRequest};
+      const data = spec.buildRequests(validBidRequests, clonedBidderRequest)[0].data;
+      expect(data.regs.ext.gpp).to.equal(bidderRequest.gppConsent.gppString);
+      expect(data.regs.ext.gpp_sid).to.eql(bidderRequest.gppConsent.applicableSections);
+    });
+
+    it('overrides the GPP consent data using data from the ortb2 config object', function () {
       const { validBidRequests, bidderRequest } = generateBuildRequestMock({});
       const ortb2 = {
         regs: {
@@ -759,8 +809,8 @@ describe('YahooSSP Bid Adapter:', () => {
       };
       let clonedBidderRequest = {...bidderRequest, ortb2};
       const data = spec.buildRequests(validBidRequests, clonedBidderRequest)[0].data;
-      expect(data.regs.ext.gpp).to.equal('somegppstring');
-      expect(data.regs.ext.gpp_sid).to.eql([6, 7]);
+      expect(data.regs.ext.gpp).to.equal(ortb2.regs.gpp);
+      expect(data.regs.ext.gpp_sid).to.eql(ortb2.regs.gpp_sid);
     });
   });
 
@@ -930,8 +980,10 @@ describe('YahooSSP Bid Adapter:', () => {
 
       expect(data.regs).to.deep.equal({
         ext: {
-          'us_privacy': '',
-          gdpr: 1
+          'us_privacy': bidderRequest.uspConsent,
+          gdpr: 1,
+          gpp: bidderRequest.gppConsent.gppString,
+          gpp_sid: bidderRequest.gppConsent.applicableSections
         }
       });
 

package/test/spec/modules/zeta_global_sspBidAdapter_spec.js

@@ -137,6 +137,8 @@ describe('Zeta Ssp Bid Adapter', function () {
         mimes: ['video/mp4'],
         minduration: 5,
         maxduration: 30,
+        placement: 2,
+        plcmt: 1,
         protocols: [2, 3]
       }
     },
@@ -326,6 +328,8 @@ describe('Zeta Ssp Bid Adapter', function () {
     expect(payload.imp[0].video.mimes).to.eql(videoRequest[0].mediaTypes.video.mimes);
     expect(payload.imp[0].video.w).to.eql(720);
     expect(payload.imp[0].video.h).to.eql(340);
+    expect(payload.imp[0].video.placement).to.eql(videoRequest[0].mediaTypes.video.placement);
+    expect(payload.imp[0].video.plcmt).to.eql(videoRequest[0].mediaTypes.video.plcmt);
 
     expect(payload.imp[0].banner).to.be.undefined;
   });