prebid.js 7.48.0 → 7.49.0

package/test/spec/modules/yieldlabBidAdapter_spec.js

@@ -191,6 +191,7 @@ const NATIVE_RESPONSE = Object.assign({}, RESPONSE, {
           url: 'https://localhost:8080/yl-logo100x100.jpg',
           w: 100,
           h: 100,
+          type: 3,
         },
       },
       {
@@ -557,7 +558,6 @@ describe('yieldlabBidAdapter', () => {
 
     it('should add adUrl and native assets when type is Native', () => {
       const result = spec.interpretResponse({body: [NATIVE_RESPONSE]}, {validBidRequests: [NATIVE_REQUEST()], queryParams: REQPARAMS});
-
       expect(result[0].requestId).to.equal('2d925f27f5079f');
       expect(result[0].cpm).to.equal(0.01);
       expect(result[0].mediaType).to.equal('native');
@@ -569,6 +569,13 @@ describe('yieldlabBidAdapter', () => {
       expect(result[0].native.image.height).to.equal(100);
       expect(result[0].native.clickUrl).to.equal('https://www.yieldlab.de');
       expect(result[0].native.impressionTrackers.length).to.equal(3);
+      expect(result[0].native.assets.length).to.equal(3);
+      const titleAsset = result[0].native.assets.find(asset => 'title' in asset);
+      const imageAsset = result[0].native.assets.find(asset => 'img' in asset);
+      const bodyAsset = result[0].native.assets.find(asset => 'data' in asset);
+      expect(titleAsset).to.exist.and.to.have.nested.property('id', 1)
+      expect(imageAsset).to.exist.and.to.have.nested.property('id', 2)
+      expect(bodyAsset).to.exist.and.to.have.nested.property('id', 3)
     });
 
     it('should add adUrl and default native assets when type is Native', () => {

package/test/spec/unit/core/bidderFactory_spec.js

@@ -1,24 +1,24 @@
 import {
+  addComponentAuction,
+  isValid,
   newBidder,
-  registerBidder,
   preloadBidderMappingFile,
-  storage,
-  isValid,
-  addComponentAuction
+  registerBidder,
+  storage
 } from 'src/adapters/bidderFactory.js';
 import adapterManager from 'src/adapterManager.js';
 import * as ajax from 'src/ajax.js';
-import { expect } from 'chai';
-import { userSync } from 'src/userSync.js'
+import {expect} from 'chai';
+import {userSync} from 'src/userSync.js';
 import * as utils from 'src/utils.js';
-import { config } from 'src/config.js';
-import { server } from 'test/mocks/xhr.js';
+import {config} from 'src/config.js';
+import {server} from 'test/mocks/xhr.js';
 import CONSTANTS from 'src/constants.json';
 import * as events from 'src/events.js';
 import {hook} from '../../../../src/hook.js';
 import {auctionManager} from '../../../../src/auctionManager.js';
 import {stubAuctionIndex} from '../../../helpers/indexStub.js';
-import { bidderSettings } from '../../../../src/bidderSettings.js';
+import {bidderSettings} from '../../../../src/bidderSettings.js';
 import {decorateAdUnitsWithNativeParams} from '../../../../src/native.js';
 
 const CODE = 'sampleBidder';

package/test/spec/unit/pbjs_api_spec.js

@@ -2501,7 +2501,6 @@ describe('Unit: Prebid Module', function () {
         }];
         let adUnitCodes = ['adUnit-code'];
         let auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: function() {}, cbTimeout: timeout});
-
         adUnits[0]['mediaTypes'] = { native: {} };
         adUnitCodes = ['adUnit-code'];
         let auction1 = auctionModule.newAuction({adUnits, adUnitCodes, callback: function() {}, cbTimeout: timeout});
@@ -3546,4 +3545,63 @@ describe('Unit: Prebid Module', function () {
       expect(bids[0].adId).to.equal('adid-1');
     });
   });
+
+  describe('deferred billing', function () {
+    const sandbox = sinon.createSandbox();
+
+    let adUnits = [
+      {
+        code: 'adUnit-code-1',
+        mediaTypes: { banner: { sizes: [[300, 250], [300, 600]] } },
+        transactionId: '1234567890',
+        bids: [
+          { bidder: 'pubmatic', params: {placementId: '10433394'}, adUnitCode: 'adUnit-code-1' }
+        ]
+      },
+      {
+        code: 'adUnit-code-2',
+        deferBilling: true,
+        mediaTypes: { banner: { sizes: [[300, 250], [300, 600]] } },
+        transactionId: '0987654321',
+        bids: [
+          { bidder: 'pubmatic', params: {placementId: '10433394'}, adUnitCode: 'adUnit-code-2' }
+        ]
+      }
+    ];
+
+    let winningBid1 = { adapterCode: 'pubmatic', bidder: 'pubmatic', params: {placementId: '10433394'}, adUnitCode: 'adUnit-code-1', transactionId: '1234567890', adId: 'abcdefg' }
+    let winningBid2 = { adapterCode: 'pubmatic', bidder: 'pubmatic', params: {placementId: '10433394'}, adUnitCode: 'adUnit-code-2', transactionId: '0987654321' }
+    let adUnitCodes = ['adUnit-code-1', 'adUnit-code-2'];
+    let auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: function() {}, cbTimeout: 2000});
+
+    beforeEach(function () {
+      sandbox.spy(adapterManager, 'callBidWonBidder');
+      sandbox.spy(adapterManager, 'callBidBillableBidder');
+      sandbox.stub(auctionManager, 'getBidsReceived').returns([winningBid1]);
+    });
+
+    afterEach(function () {
+      sandbox.resetHistory();
+      sandbox.restore();
+    });
+
+    it('should by default invoke callBidWonBidder and callBidBillableBidder', function () {
+      auction.addWinningBid(winningBid1);
+      sinon.assert.calledOnce(adapterManager.callBidWonBidder);
+      sinon.assert.calledOnce(adapterManager.callBidBillableBidder);
+    });
+
+    it('should only invoke callBidWonBidder and NOT callBidBillableBidder if deferBilling is present and true within the winning adUnit object', function () {
+      auction.addWinningBid(winningBid2);
+      sinon.assert.calledOnce(adapterManager.callBidWonBidder);
+      sinon.assert.notCalled(adapterManager.callBidBillableBidder);
+    });
+
+    it('should invoke callBidBillableBidder when pbjs.triggerBilling is invoked', function () {
+      $$PREBID_GLOBAL$$.triggerBilling(winningBid1);
+      sinon.assert.calledOnce(auctionManager.getBidsReceived);
+      sinon.assert.notCalled(adapterManager.callBidWonBidder);
+      sinon.assert.calledOnce(adapterManager.callBidBillableBidder);
+    });
+  });
 });

package/test/spec/unit/utils/cpm_spec.js

@@ -1,11 +1,14 @@
 import {adjustCpm} from '../../../../src/utils/cpm.js';
+import {ScopedSettings} from '../../../../src/bidderSettings.js';
+import {expect} from 'chai/index.js';
 
 describe('adjustCpm', () => {
   const bidderCode = 'mockBidder';
   let adjustmentFn, bs, index;
   beforeEach(() => {
     bs = {
-      get: sinon.stub()
+      get: sinon.stub(),
+      getOwn: sinon.stub()
     }
     index = {
       getBidRequest: sinon.stub()
@@ -62,3 +65,55 @@ describe('adjustCpm', () => {
     });
   })
 });
+
+describe('adjustAlternateBids', () => {
+  let bs;
+  afterEach(() => {
+    bs = null;
+  });
+
+  function runAdjustment(cpm, bidderCode, adapterCode) {
+    return adjustCpm(cpm, {bidderCode, adapterCode}, null, {bs: new ScopedSettings(() => bs)});
+  }
+
+  it('should fall back to the adapter adjustment fn when adjustAlternateBids is true', () => {
+    bs = {
+      adapter: {
+        adjustAlternateBids: true,
+        bidCpmAdjustment: function (cpm) {
+          return cpm * 2;
+        }
+      },
+      bidder: {}
+    };
+    expect(runAdjustment(1, 'bidder', 'adapter')).to.eql(2);
+  });
+
+  it('should NOT fall back to the adapter adjustment fn when adjustAlternateBids is not true', () => {
+    bs = {
+      adapter: {
+        bidCpmAdjustment(cpm) {
+          return cpm * 2
+        }
+      }
+    }
+    expect(runAdjustment(1, 'bidder', 'adapter')).to.eql(1);
+  });
+
+  it('should prioritize bidder adjustment fn', () => {
+    bs = {
+      adapter: {
+        adjustAlternateBids: true,
+        bidCpmAdjustment(cpm) {
+          return cpm * 2
+        }
+      },
+      bidder: {
+        bidCpmAdjustment(cpm) {
+          return cpm * 3
+        }
+      }
+    }
+    expect(runAdjustment(1, 'bidder', 'adapter')).to.eql(3);
+  });
+});