prebid.js 7.46.0 → 7.48.0

package/modules/relevantdigitalBidAdapter.js

@@ -0,0 +1,198 @@
+import {registerBidder} from '../src/adapters/bidderFactory.js';
+import {ortbConverter} from '../libraries/ortbConverter/converter.js'
+import {BANNER, NATIVE, VIDEO} from '../src/mediaTypes.js';
+import {config} from '../src/config.js';
+import {pbsExtensions} from '../libraries/pbsExtensions/pbsExtensions.js'
+import {deepSetValue, isEmpty, deepClone, shuffle, triggerPixel, deepAccess} from '../src/utils.js';
+
+const BIDDER_CODE = 'relevantdigital';
+
+/** Global settings per bidder-code for this adapter (which might be > 1 if using aliasing) */
+let configByBidder = {};
+
+/** Used by the tests */
+export const resetBidderConfigs = () => {
+  configByBidder = {};
+};
+
+/** Settings ber bidder-code. checkParams === true means that it can optionally be set in bid-params   */
+const FIELDS = [
+  { name: 'pbsHost', checkParams: true, required: true },
+  { name: 'accountId', checkParams: true, required: true },
+  { name: 'pbsBufferMs', checkParams: false, required: false, default: 250 },
+  { name: 'useSourceBidderCode', checkParams: false, required: false, default: false },
+];
+
+const SYNC_HTML = 'https://cdn.relevant-digital.com/resources/load-cookie.html';
+const MAX_SYNC_COUNT = 10; // Max server-side bidder to sync at once via the iframe
+
+/** Get settings for a bidder-code via config and, if needed, bid parameters */
+const getBidderConfig = (bids) => {
+  const { bidder } = bids[0];
+  const cfg = configByBidder[bidder] || {
+    ...Object.fromEntries(FIELDS.filter((f) => 'default' in f).map((f) => [f.name, f.default])),
+    syncedBidders: {}, // To keep track of S2S-bidders we already (started to) synced
+  };
+  if (cfg.complete) {
+    return cfg; // Most common case, we already have the settings we need (and we won't re-read them)
+  }
+  configByBidder[bidder] = cfg;
+  const bidderConfiguration = config.getConfig(bidder) || {};
+
+  // Read settings set by setConfig({ [bidder]: { ... }}) and if not available - from bid params
+  FIELDS.forEach(({ name, checkParams }) => {
+    cfg[name] = bidderConfiguration[name] || cfg[name];
+    if (!cfg[name] && checkParams) {
+      bids.forEach((bid) => {
+        cfg[name] = cfg[name] || bid.params?.[name];
+      });
+    }
+  });
+  cfg.complete = FIELDS.every((field) => !field.required || cfg[field.name]);
+  if (cfg.complete) {
+    cfg.pbsHost = cfg.pbsHost.trim().replace('http://', 'https://');
+    if (cfg.pbsHost.indexOf('https://') < 0) {
+      cfg.pbsHost = `https://${cfg.pbsHost}`;
+    }
+  }
+  return cfg;
+}
+
+const converter = ortbConverter({
+  context: {
+    netRevenue: true,
+    ttl: 300
+  },
+  processors: pbsExtensions,
+  imp(buildImp, bidRequest, context) {
+    // Set stored request id from placementId
+    const imp = buildImp(bidRequest, context);
+    const { placementId } = bidRequest.params;
+    deepSetValue(imp, 'ext.prebid.storedrequest.id', placementId);
+    delete imp.ext.prebid.bidder;
+    return imp;
+  },
+  overrides: {
+    bidResponse: {
+      bidderCode(orig, bidResponse, bid, { bidRequest }) {
+        const { bidder, params = {} } = bidRequest || {};
+        let useSourceBidderCode = configByBidder[bidder]?.useSourceBidderCode;
+        if ('useSourceBidderCode' in params) {
+          useSourceBidderCode = params.useSourceBidderCode;
+        }
+        // Only use the orignal function when useSourceBidderCode is true, else our own bidder code will be used
+        if (useSourceBidderCode) {
+          orig.apply(this, [...arguments].slice(1));
+        }
+      },
+    },
+  }
+});
+
+export const spec = {
+  code: BIDDER_CODE,
+  gvlid: 1100,
+  supportedMediaTypes: [BANNER, VIDEO, NATIVE],
+
+  /** We need both params.placementId + a complete configuration (pbsHost + accountId) to continue **/
+  isBidRequestValid: (bid) => bid.params?.placementId && getBidderConfig([bid]).complete,
+
+  /** Trigger impression-pixel */
+  onBidWon: ({pbsWurl}) => pbsWurl && triggerPixel(pbsWurl),
+
+  /** Build BidRequest for PBS */
+  buildRequests(bidRequests, bidderRequest) {
+    const { bidder } = bidRequests[0];
+    const cfg = getBidderConfig(bidRequests);
+    const data = converter.toORTB({bidRequests, bidderRequest});
+
+    /** Set tmax, in general this will be timeout - pbsBufferMs */
+    const pbjsTimeout = bidderRequest.timeout || 1000;
+    data.tmax = Math.min(Math.max(pbjsTimeout - cfg.pbsBufferMs, cfg.pbsBufferMs), pbjsTimeout);
+
+    delete data.ext?.prebid?.aliases; // We don't need/want to send aliases to PBS
+    deepSetValue(data, 'ext.relevant', {
+      ...data.ext?.relevant,
+      adapter: true, // For internal analytics
+    });
+    deepSetValue(data, 'ext.prebid.storedrequest.id', cfg.accountId);
+    data.ext.prebid.passthrough = {
+      ...data.ext.prebid.passthrough,
+      relevant: { bidder }, // to find config for the right bidder-code in interpretResponse / getUserSyncs
+    };
+    return [{
+      method: 'POST',
+      url: `${cfg.pbsHost}/openrtb2/auction`,
+      data
+    }];
+  },
+
+  /** Read BidResponse from PBS and make necessary adjustments to not make it appear to come from unknown bidders */
+  interpretResponse(response, request) {
+    const resp = deepClone(response.body);
+    const { bidder } = request.data.ext.prebid.passthrough.relevant;
+
+    // Modify response times / errors for actual PBS bidders into a single value
+    const MODIFIERS = {
+      responsetimemillis: (values) => Math.max(...values),
+      errors: (values) => [].concat(...values),
+    };
+    Object.entries(MODIFIERS).forEach(([field, combineFn]) => {
+      const obj = resp.ext?.[field];
+      if (!isEmpty(obj)) {
+        resp.ext[field] = {[bidder]: combineFn(Object.values(obj))};
+      }
+    });
+
+    const bids = converter.fromORTB({response: resp, request: request.data}).bids;
+    return bids;
+  },
+
+  /** Do syncing, but avoid running the sync > 1 time for S2S bidders */
+  getUserSyncs(syncOptions, serverResponses, gdprConsent, uspConsent) {
+    if (!syncOptions.iframeEnabled && !syncOptions.pixelEnabled) {
+      return [];
+    }
+    const syncs = [];
+    serverResponses.forEach(({ body }) => {
+      const { pbsHost, syncedBidders } = configByBidder[body.ext.prebid.passthrough.relevant.bidder] || {};
+      if (!pbsHost) {
+        return;
+      }
+      const { gdprApplies, consentString } = gdprConsent || {};
+      let bidders = Object.keys(body.ext?.responsetimemillis || {});
+      bidders = bidders.reduce((acc, curr) => {
+        if (!syncedBidders[curr]) {
+          acc.push(curr);
+          syncedBidders[curr] = true;
+        }
+        return acc;
+      }, []);
+      bidders = shuffle(bidders).slice(0, MAX_SYNC_COUNT); // Shuffle to not always leave out the same bidders
+      if (!bidders.length) {
+        return; // All bidders already synced
+      }
+      if (syncOptions.iframeEnabled) {
+        const params = {
+          endpoint: `${pbsHost}/cookie_sync`,
+          max_sync_count: bidders.length,
+          gdpr: gdprApplies ? 1 : 0,
+          gdpr_consent: consentString,
+          us_privacy: uspConsent,
+          bidders: bidders.join(','),
+        };
+        const qs = Object.entries(params)
+          .filter(([k, v]) => ![null, undefined, ''].includes(v))
+          .map(([k, v]) => `${k}=${encodeURIComponent(v.toString())}`)
+          .join('&');
+        syncs.push({ type: 'iframe', url: `${SYNC_HTML}?${qs}` });
+      } else { // Else, try to pixel-sync (for future-compatibility)
+        const pixels = deepAccess(body, `ext.relevant.sync`, []).filter(({ type }) => type === 'redirect');
+        syncs.push(...pixels.map(({ url }) => ({ type: 'image', url })));
+      }
+    });
+    return syncs;
+  },
+};
+
+registerBidder(spec);

package/modules/relevantdigitalBidAdapter.md

@@ -0,0 +1,117 @@
+# Overview
+
+```
+Module Name:  Relevant Digital Bid Adapter
+Module Type:  Bidder Adapter
+Maintainer: support@relevant-digital.com
+```
+
+# Description
+
+This adapter is used for integration with providers using the **[Relevant Yield](https://www.relevant-digital.com/relevantyield)** platform. The provider will supply the necessary **pbsHost** and **accountId** settings along with the **placementId** bid parameters per ad unit.
+
+# Example setup using pbjs.setConfig()
+This is the recommended method to set the global configuration parameters.
+```javascript
+pbjs.setConfig({
+  relevantdigital: {
+    pbsHost: 'pbs-example.relevant-digital.com',
+    accountId: '6204e5fa70e3ad10821b84ff',
+  },
+});
+
+var adUnits = [
+  {
+    code: 'test-div',
+    mediaTypes: { banner: { sizes: [[300, 250], [320, 320]] }},
+    bids: [
+      {
+        bidder: 'relevantdigital',
+        params: {
+          placementId: '6204e83a077c5825441b8508_620f9e8e4fe67c1f87cd30ed',
+        }
+      }
+   ],
+  }
+];
+```
+# Example setup using only bid params
+This method to set the global configuration parameters (like **pbsHost**) in **params** could simplify integration of a provider for some publishers. Setting different global config-parameters on different bids is not supported in general*, as the first settings found will be used and any subsequent global settings will be ignored.
+
+  * _The exception is `useSourceBidderCode` which can be overriden individually per ad unit._ 
+```javascript
+var adUnits = [
+  {
+    code: 'test-div',
+    mediaTypes: { banner: { sizes: [[300, 250], [320, 320]] }},
+    bids: [
+      {
+        bidder: 'relevantdigital',
+        params: {
+          placementId: '6204e83a077c5825441b8508_620f9e8e4fe67c1f87cd30ed',
+          pbsHost: 'pbs-example.relevant-digital.com',
+          accountId: '6204e5fa70e3ad10821b84ff',
+        }
+      }
+   ],
+  }
+];
+```
+
+# Example setup with multiple providers
+**Notice:** Placements below are _not_ live test placements  
+```javascript
+
+pbjs.aliasBidder('relevantdigital', 'providerA');
+pbjs.aliasBidder('relevantdigital', 'providerB');
+
+pbjs.setConfig({
+  providerA: {
+    pbsHost: 'pbs-example-a.relevant-digital.com',
+    accountId: '620533ae7f5bbe1691bbb815',
+  },
+  providerB: {
+    pbsHost: 'pbs-example-b.relevant-digital.com',
+    accountId: '990533ae7f5bbe1691bbb815',
+  },  
+});
+
+var adUnits = [
+  {
+    code: 'test-div',
+    mediaTypes: { banner: { sizes: [[300, 250], [320, 320]] }},
+    bids: [
+      {
+        bidder: 'providerA',
+        params: {
+          placementId: '610525862d7517bfd4bbb81e_620523b7d1dbed6b0fbbb817',
+        }
+      },
+      {
+        bidder: 'providerB',
+        params: {
+          placementId: '990525862d7517bfd4bbb81e_770523b7d1dbed6b0fbbb817',
+        }
+      },      
+   ],
+  }
+];
+```
+
+# Bid Parameters
+
+| Name          | Scope    | Description                                             | Example                    | Type         |
+|---------------|----------|---------------------------------------------------------|----------------------------|--------------|
+| `placementId`       | required | The placement id.  | `'6204e83a077c5825441b8508_620f9e8e4fe67c1f87cd30ed'`      | `String`     |
+| `pbsHost` | required if not set in config | Host name of the server. | `'pbs-example.relevant-digital.com'`                | `String`     |
+| `accountId`        | required if not set in config | The account id.  | `'6204e5fa70e3ad10821b84ff'`               | `String`      |
+| `useSourceBidderCode`        | optional | Set to `true` in order to use the bidder code of the actual server-side bidder in bid responses. You **MUST** also use `allowAlternateBidderCodes: true` in `bidderSettings` if you enabled this - as otherwise the bids will be rejected.| `true`               | `Boolean`      |
+
+# Config Parameters
+
+| Name          | Scope    | Description                                             | Example                    | Type         |
+|---------------|----------|---------------------------------------------------------|----------------------------|--------------|
+| `pbsHost` | required if not set in bid parameters | Host name of the server. | `'pbs-example.relevant-digital.com'`                | `String`     |
+| `accountId`        | required if not set in bid parameters | The account id.  | `'6204e5fa70e3ad10821b84ff'`               | `String`      |
+| `pbsBufferMs` | optional | How much less in *milliseconds* the server's internal timeout should be compared to the normal Prebid timeout. Default is *250*. To be increased in cases of frequent timeouts. | `250`                | `Integer`     |
+| `useSourceBidderCode`        | optional | Set to `true` in order to use the bidder code of the actual server-side bidder in bid responses. You **MUST** also use `allowAlternateBidderCodes: true` in `bidderSettings` if you enabled this - as otherwise the bids will be rejected.| `true`               | `Boolean`      |

package/modules/rtbhouseBidAdapter.js

@@ -85,15 +85,12 @@ export const spec = {
     }
 
     const ortb2Params = bidderRequest?.ortb2 || {};
-    if (ortb2Params.site) {
-      mergeDeep(request, { site: ortb2Params.site });
-    }
-    if (ortb2Params.user) {
-      mergeDeep(request, { user: ortb2Params.user });
-    }
-    if (ortb2Params.device) {
-      mergeDeep(request, { device: ortb2Params.device });
-    }
+    ['site', 'user', 'device', 'bcat', 'badv'].forEach(entry => {
+      const ortb2Param = ortb2Params[entry];
+      if (ortb2Param) {
+        mergeDeep(request, { [entry]: ortb2Param });
+      }
+    });
 
     let computedEndpointUrl = ENDPOINT_URL;
 
@@ -479,7 +476,7 @@ function interpretNativeBid(serverBid) {
 function interpretNativeAd(adm) {
   const native = JSON.parse(adm).native;
   const result = {
-    clickUrl: encodeURIComponent(native.link.url),
+    clickUrl: encodeURI(native.link.url),
     impressionTrackers: native.imptrackers
   };
   native.assets.forEach(asset => {
@@ -489,14 +486,14 @@ function interpretNativeAd(adm) {
         break;
       case OPENRTB.NATIVE.ASSET_ID.IMAGE:
         result.image = {
-          url: encodeURIComponent(asset.img.url),
+          url: encodeURI(asset.img.url),
           width: asset.img.w,
           height: asset.img.h
         };
         break;
       case OPENRTB.NATIVE.ASSET_ID.ICON:
         result.icon = {
-          url: encodeURIComponent(asset.img.url),
+          url: encodeURI(asset.img.url),
           width: asset.img.w,
           height: asset.img.h
         };

package/modules/sovrnBidAdapter.js

@@ -173,6 +173,10 @@ export const spec = {
       if (bidderRequest.uspConsent) {
         deepSetValue(sovrnBidReq, 'regs.ext.us_privacy', bidderRequest.uspConsent);
       }
+      if (bidderRequest.gppConsent) {
+        deepSetValue(sovrnBidReq, 'regs.gpp', bidderRequest.gppConsent.gppString);
+        deepSetValue(sovrnBidReq, 'regs.gpp_sid', bidderRequest.gppConsent.applicableSections);
+      }
 
       if (eids) {
         deepSetValue(sovrnBidReq, 'user.ext.eids', eids)

package/modules/stvBidAdapter.js

@@ -1,7 +1,6 @@
-import { deepAccess } from '../src/utils.js';
-import { config } from '../src/config.js';
-import { registerBidder } from '../src/adapters/bidderFactory.js';
-import { BANNER, VIDEO } from '../src/mediaTypes.js';
+import {deepAccess} from '../src/utils.js';
+import {registerBidder} from '../src/adapters/bidderFactory.js';
+import {BANNER, VIDEO} from '../src/mediaTypes.js';
 import {includes} from '../src/polyfill.js';
 
 const BIDDER_CODE = 'stv';
@@ -128,7 +127,7 @@ export const spec = {
         dealId: dealId,
         currency: currency,
         netRevenue: netRevenue,
-        ttl: config.getConfig('_bidderTimeout'),
+        ttl: 60,
         meta: {
           advertiserDomains: response.adomain || []
         }

package/modules/tripleliftBidAdapter.js

@@ -9,7 +9,7 @@ const BIDDER_CODE = 'triplelift';
 const STR_ENDPOINT = 'https://tlx.3lift.com/header/auction?';
 const BANNER_TIME_TO_LIVE = 300;
 const VIDEO_TIME_TO_LIVE = 3600;
-let gdprApplies = true;
+let gdprApplies = null;
 let consentString = null;
 export const storage = getStorageManager({bidderCode: BIDDER_CODE});
 
@@ -40,8 +40,12 @@ export const tripleliftAdapterSpec = {
     if (bidderRequest && bidderRequest.gdprConsent) {
       if (typeof bidderRequest.gdprConsent.gdprApplies !== 'undefined') {
         gdprApplies = bidderRequest.gdprConsent.gdprApplies;
-        tlCall = tryAppendQueryString(tlCall, 'gdpr', gdprApplies.toString());
+      } else {
+        gdprApplies = true;
       }
+
+      tlCall = tryAppendQueryString(tlCall, 'gdpr', gdprApplies.toString());
+
       if (typeof bidderRequest.gdprConsent.consentString !== 'undefined') {
         consentString = bidderRequest.gdprConsent.consentString;
         tlCall = tryAppendQueryString(tlCall, 'cmp_cs', consentString);
@@ -87,7 +91,7 @@ export const tripleliftAdapterSpec = {
       syncEndpoint = tryAppendQueryString(syncEndpoint, 'src', 'prebid');
     }
 
-    if (consentString !== null) {
+    if (consentString !== null || gdprApplies) {
       syncEndpoint = tryAppendQueryString(syncEndpoint, 'gdpr', gdprApplies);
       syncEndpoint = tryAppendQueryString(syncEndpoint, 'cmp_cs', consentString);
     }
@@ -130,8 +134,15 @@ function _buildPostBody(bidRequests, bidderRequest) {
     }
 
     if (!isEmpty(bidRequest.ortb2Imp)) {
+      // legacy method for extracting ortb2Imp.ext
       imp.fpd = _getAdUnitFpd(bidRequest.ortb2Imp);
+
+      // preferred method for extracting ortb2Imp.ext
+      if (!isEmpty(bidRequest.ortb2Imp.ext)) {
+        imp.ext = { ...bidRequest.ortb2Imp.ext };
+      }
     }
+
     return imp;
   });
 

package/modules/ttdBidAdapter.js

@@ -185,7 +185,7 @@ function getImpression(bidRequest) {
   if (mediaTypesBanner) {
     mediaTypes[BANNER] = banner(bidRequest);
   }
-  if (mediaTypesVideo) {
+  if (FEATURES.VIDEO && mediaTypesVideo) {
     mediaTypes[VIDEO] = video(bidRequest);
   }
 
@@ -248,79 +248,81 @@ function banner(bid) {
 }
 
 function video(bid) {
-  let minduration = utils.deepAccess(bid, 'mediaTypes.video.minduration');
-  const maxduration = utils.deepAccess(bid, 'mediaTypes.video.maxduration');
-  const playerSize = utils.deepAccess(bid, 'mediaTypes.video.playerSize');
-  const api = utils.deepAccess(bid, 'mediaTypes.video.api');
-  const mimes = utils.deepAccess(bid, 'mediaTypes.video.mimes');
-  const placement = utils.deepAccess(bid, 'mediaTypes.video.placement');
-  const plcmt = utils.deepAccess(bid, 'mediaTypes.video.plcmt');
-  const protocols = utils.deepAccess(bid, 'mediaTypes.video.protocols');
-  const playbackmethod = utils.deepAccess(bid, 'mediaTypes.video.playbackmethod');
-  const pos = utils.deepAccess(bid, 'mediaTypes.video.pos');
-  const startdelay = utils.deepAccess(bid, 'mediaTypes.video.startdelay');
-  const skip = utils.deepAccess(bid, 'mediaTypes.video.skip');
-  const skipmin = utils.deepAccess(bid, 'mediaTypes.video.skipmin');
-  const skipafter = utils.deepAccess(bid, 'mediaTypes.video.skipafter');
-  const minbitrate = utils.deepAccess(bid, 'mediaTypes.video.minbitrate');
-  const maxbitrate = utils.deepAccess(bid, 'mediaTypes.video.maxbitrate');
-
-  if (!minduration || !utils.isInteger(minduration)) {
-    minduration = 0;
-  }
-  let video = {
-    minduration: minduration,
-    maxduration: maxduration,
-    api: api,
-    mimes: mimes,
-    placement: placement,
-    protocols: protocols
-  };
+  if (FEATURES.VIDEO) {
+    let minduration = utils.deepAccess(bid, 'mediaTypes.video.minduration');
+    const maxduration = utils.deepAccess(bid, 'mediaTypes.video.maxduration');
+    const playerSize = utils.deepAccess(bid, 'mediaTypes.video.playerSize');
+    const api = utils.deepAccess(bid, 'mediaTypes.video.api');
+    const mimes = utils.deepAccess(bid, 'mediaTypes.video.mimes');
+    const placement = utils.deepAccess(bid, 'mediaTypes.video.placement');
+    const plcmt = utils.deepAccess(bid, 'mediaTypes.video.plcmt');
+    const protocols = utils.deepAccess(bid, 'mediaTypes.video.protocols');
+    const playbackmethod = utils.deepAccess(bid, 'mediaTypes.video.playbackmethod');
+    const pos = utils.deepAccess(bid, 'mediaTypes.video.pos');
+    const startdelay = utils.deepAccess(bid, 'mediaTypes.video.startdelay');
+    const skip = utils.deepAccess(bid, 'mediaTypes.video.skip');
+    const skipmin = utils.deepAccess(bid, 'mediaTypes.video.skipmin');
+    const skipafter = utils.deepAccess(bid, 'mediaTypes.video.skipafter');
+    const minbitrate = utils.deepAccess(bid, 'mediaTypes.video.minbitrate');
+    const maxbitrate = utils.deepAccess(bid, 'mediaTypes.video.maxbitrate');
+
+    if (!minduration || !utils.isInteger(minduration)) {
+      minduration = 0;
+    }
+    let video = {
+      minduration: minduration,
+      maxduration: maxduration,
+      api: api,
+      mimes: mimes,
+      placement: placement,
+      protocols: protocols
+    };
 
-  if (typeof playerSize !== 'undefined') {
-    if (utils.isArray(playerSize[0])) {
-      video.w = parseInt(playerSize[0][0]);
-      video.h = parseInt(playerSize[0][1]);
-    } else if (utils.isNumber(playerSize[0])) {
-      video.w = parseInt(playerSize[0]);
-      video.h = parseInt(playerSize[1]);
+    if (typeof playerSize !== 'undefined') {
+      if (utils.isArray(playerSize[0])) {
+        video.w = parseInt(playerSize[0][0]);
+        video.h = parseInt(playerSize[0][1]);
+      } else if (utils.isNumber(playerSize[0])) {
+        video.w = parseInt(playerSize[0]);
+        video.h = parseInt(playerSize[1]);
+      }
     }
-  }
 
-  if (playbackmethod) {
-    video.playbackmethod = playbackmethod;
-  }
-  if (plcmt) {
-    video.plcmt = plcmt;
-  }
-  if (pos) {
-    video.pos = pos;
-  }
-  if (startdelay && utils.isInteger(startdelay)) {
-    video.startdelay = startdelay;
-  }
-  if (skip && (skip === 0 || skip === 1)) {
-    video.skip = skip;
-  }
-  if (skipmin && utils.isInteger(skipmin)) {
-    video.skipmin = skipmin;
-  }
-  if (skipafter && utils.isInteger(skipafter)) {
-    video.skipafter = skipafter;
-  }
-  if (minbitrate && utils.isInteger(minbitrate)) {
-    video.minbitrate = minbitrate;
-  }
-  if (maxbitrate && utils.isInteger(maxbitrate)) {
-    video.maxbitrate = maxbitrate;
-  }
+    if (playbackmethod) {
+      video.playbackmethod = playbackmethod;
+    }
+    if (plcmt) {
+      video.plcmt = plcmt;
+    }
+    if (pos) {
+      video.pos = pos;
+    }
+    if (startdelay && utils.isInteger(startdelay)) {
+      video.startdelay = startdelay;
+    }
+    if (skip && (skip === 0 || skip === 1)) {
+      video.skip = skip;
+    }
+    if (skipmin && utils.isInteger(skipmin)) {
+      video.skipmin = skipmin;
+    }
+    if (skipafter && utils.isInteger(skipafter)) {
+      video.skipafter = skipafter;
+    }
+    if (minbitrate && utils.isInteger(minbitrate)) {
+      video.minbitrate = minbitrate;
+    }
+    if (maxbitrate && utils.isInteger(maxbitrate)) {
+      video.maxbitrate = maxbitrate;
+    }
 
-  const battr = utils.deepAccess(bid, 'ortb2Imp.battr');
-  if (battr) {
-    video.battr = battr;
-  }
+    const battr = utils.deepAccess(bid, 'ortb2Imp.battr');
+    if (battr) {
+      video.battr = battr;
+    }
 
-  return video;
+    return video;
+  }
 }
 
 export const spec = {
@@ -379,7 +381,7 @@ export const spec = {
       return false;
     }
 
-    if (mediaTypesVideo) {
+    if (FEATURES.VIDEO && mediaTypesVideo) {
       if (!mediaTypesVideo.maxduration || !utils.isInteger(mediaTypesVideo.maxduration)) {
         utils.logWarn(BIDDER_CODE + ': mediaTypes.video.maxduration must be set to the maximum video ad duration in seconds');
         return false;
@@ -506,7 +508,7 @@ export const spec = {
               mediaType: BANNER
             }
           );
-        } else if (bid.ext.mediatype === MEDIA_TYPE.VIDEO) {
+        } else if (FEATURES.VIDEO && bid.ext.mediatype === MEDIA_TYPE.VIDEO) {
           Object.assign(
             bidResponse,
             {

package/modules/underdogmediaBidAdapter.js

@@ -1,21 +1,18 @@
 import {
-  logMessage,
+  deepAccess,
   flatten,
-  parseSizesInput,
+  getWindowSelf,
+  getWindowTop,
   isGptPubadsDefined,
   isSlotMatchingAdUnitCode,
   logInfo,
+  logMessage,
   logWarn,
-  getWindowSelf,
-  getWindowTop,
-  deepAccess
+  parseSizesInput
 } from '../src/utils.js';
-import {
-  config
-} from '../src/config.js';
-import {
-  registerBidder
-} from '../src/adapters/bidderFactory.js';
+import {config} from '../src/config.js';
+import {registerBidder} from '../src/adapters/bidderFactory.js';
+
 const BIDDER_CODE = 'underdogmedia';
 const UDM_ADAPTER_VERSION = '7.30V';
 const UDM_VENDOR_ID = '159';
@@ -377,7 +374,7 @@ function makeNotification(bid, mid, bidParam) {
   url += `;version=${UDM_ADAPTER_VERSION}`;
   url += ';cb=' + Math.random();
   url += ';qqq=' + (1 / bid.cpm);
-  url += ';hbt=' + config.getConfig('_bidderTimeout');
+  url += ';hbt=' + config.getConfig('bidderTimeout');
   url += ';style=adapter';
   url += ';vis=' + encodeURIComponent(document.visibilityState);
 

package/modules/userId/index.js

@@ -1085,7 +1085,7 @@ module('userId', attachIdSystem);
 
 export function setOrtbUserExtEids(ortbRequest, bidderRequest, context) {
   const eids = deepAccess(context, 'bidRequests.0.userIdAsEids');
-  if (eids) {
+  if (eids && Object.keys(eids).length > 0) {
     deepSetValue(ortbRequest, 'user.ext.eids', eids);
   }
 }