prebid.js 7.45.0 → 7.47.0

package/test/spec/modules/axonixBidAdapter_spec.js

@@ -286,26 +286,6 @@ describe('AxonixBidAdapter', function () {
     });
   });
 
-  describe.skip('buildRequests: can handle native ad requests', function () {
-    it('creates ServerRequests pointing to the correct region and endpoint if it changes', function () {
-      // loop:
-      //   set supply id
-      //   set region/endpoint in ssp config
-      //   call buildRequests, validate request (url, method, supply id)
-      expect.fail('Not implemented');
-    });
-
-    it('creates ServerRequests pointing to default endpoint if missing', function () {
-      // no endpoint in config means default value openrtb.axonix.com
-      expect.fail('Not implemented');
-    });
-
-    it('creates ServerRequests pointing to default region if missing', function () {
-      // no region in config means default value us-east-1
-      expect.fail('Not implemented');
-    });
-  });
-
   describe('interpretResponse', function () {
     it('considers corner cases', function() {
       expect(spec.interpretResponse(null)).to.be.an('array').that.is.empty;
@@ -331,13 +311,6 @@ describe('AxonixBidAdapter', function () {
       expect(response).to.be.an('array').that.is.not.empty;
       expect(response[0]).to.equal(VIDEO_RESPONSE.body[0]);
     });
-
-    it.skip('parses 1 native responses', function () {
-      // passing 1 valid native in a response generates an array with 1 correct prebid response
-      // examine mediaType:native, native element
-      // check nativeBidIsValid from {@link file://./../../../src/native.js}
-      expect.fail('Not implemented');
-    });
   });
 
   describe('onBidWon', function () {

package/test/spec/modules/big-richmediaBidAdapter_spec.js

@@ -92,40 +92,42 @@ describe('bigRichMediaAdapterTests', function () {
       expect(payload.tags[0].sizes).to.have.lengthOf(3);
     });
 
-    it('should build video bid request', function() {
-      const bidRequest = deepClone(bidRequests[0]);
-      bidRequest.params = {
-        placementId: '1234235',
-        video: {
-          skippable: true,
-          playback_method: ['auto_play_sound_off', 'auto_play_sound_unknown'],
-          context: 'outstream',
-          format: 'sticky-top'
-        }
-      };
-      bidRequest.mediaTypes = {
-        video: {
-          playerSize: [640, 480],
-          context: 'outstream',
-          mimes: ['video/mp4'],
-          skip: 0,
-          minduration: 5,
-          api: [1, 5, 6],
-          playbackmethod: [2, 4]
-        }
-      };
+    if (FEATURES.VIDEO) {
+      it('should build video bid request', function() {
+        const bidRequest = deepClone(bidRequests[0]);
+        bidRequest.params = {
+          placementId: '1234235',
+          video: {
+            skippable: true,
+            playback_method: ['auto_play_sound_off', 'auto_play_sound_unknown'],
+            context: 'outstream',
+            format: 'sticky-top'
+          }
+        };
+        bidRequest.mediaTypes = {
+          video: {
+            playerSize: [640, 480],
+            context: 'outstream',
+            mimes: ['video/mp4'],
+            skip: 0,
+            minduration: 5,
+            api: [1, 5, 6],
+            playbackmethod: [2, 4]
+          }
+        };
 
-      const request = spec.buildRequests([bidRequest]);
-      const payload = JSON.parse(request.data);
+        const request = spec.buildRequests([bidRequest]);
+        const payload = JSON.parse(request.data);
 
-      expect(payload.tags[0].video).to.deep.equal({
-        minduration: 5,
-        playback_method: 2,
-        skippable: true,
-        context: 4
+        expect(payload.tags[0].video).to.deep.equal({
+          minduration: 5,
+          playback_method: 2,
+          skippable: true,
+          context: 4
+        });
+        expect(payload.tags[0].video_frameworks).to.deep.equal([1, 4])
       });
-      expect(payload.tags[0].video_frameworks).to.deep.equal([1, 4])
-    });
+    }
   });
 
   describe('interpretResponse', function () {
@@ -227,42 +229,44 @@ describe('bigRichMediaAdapterTests', function () {
       expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0]));
     });
 
-    it('handles outstream video responses', function () {
-      const response = {
-        'tags': [{
-          'uuid': '84ab500420319d',
-          'ads': [{
-            'ad_type': 'video',
-            'cpm': 0.500000,
-            'notify_url': 'imptracker.com',
-            'rtb': {
-              'video': {
-                'content': '<!-- VAST Creative -->'
-              }
-            },
-            'javascriptTrackers': '<script type=\'text/javascript\' async=\'true\' src=\'https://cdn.adnxs.com/v/s/152/trk.js#v;vk=appnexus.com-omid;tv=native1-18h;dom_id=%native_dom_id%;st=0;d=1x1;vc=iab;vid_ccr=1;tag_id=13232354;cb=https%3A%2F%2Fams1-ib.adnxs.com%2Fvevent%3Freferrer%3Dhttps253A%252F%252Ftestpages-pmahe.tp.adnxs.net%252F01_basic_single%26e%3DwqT_3QLNB6DNAwAAAwDWAAUBCLfl_-MFEMStk8u3lPTjRxih88aF0fq_2QsqNgkAAAECCCRAEQEHEAAAJEAZEQkAIREJACkRCQAxEQmoMOLRpwY47UhA7UhIAlCDy74uWJzxW2AAaM26dXjzjwWAAQGKAQNVU0SSAQEG8FCYAQGgAQGoAQGwAQC4AQHAAQTIAQLQAQDYAQDgAQDwAQCKAjt1ZignYScsIDI1Mjk4ODUsIDE1NTE4ODkwNzkpO3VmKCdyJywgOTc0OTQ0MDM2HgDwjZIC8QEha0RXaXBnajgtTHdLRUlQTHZpNFlBQ0NjOFZzd0FEZ0FRQVJJN1VoUTR0R25CbGdBWU1rR2FBQndMSGlrTDRBQlVvZ0JwQy1RQVFHWUFRR2dBUUdvQVFPd0FRQzVBZk90YXFRQUFDUkF3UUh6cldxa0FBQWtRTWtCbWo4dDA1ZU84VF9aQVFBQUEBAyRQQV80QUVBOVFFAQ4sQW1BSUFvQUlBdFFJBRAAdg0IeHdBSUF5QUlBNEFJQTZBSUEtQUlBZ0FNQm1BTUJxQVAFzIh1Z01KUVUxVE1UbzBNekl3NEFPVENBLi6aAmEhUXcxdGNRagUoEfQkblBGYklBUW9BRAl8AEEBqAREbzJEABRRSk1JU1EBGwRBQQGsAFURDAxBQUFXHQzwWNgCAOACrZhI6gIzaHR0cDovL3Rlc3RwYWdlcy1wbWFoZS50cC5hZG54cy5uZXQvMDFfYmFzaWNfc2luZ2xl8gITCg9DVVNUT01fTU9ERUxfSUQSAPICGgoWMhYAPExFQUZfTkFNRRIA8gIeCho2HQAIQVNUAT7wnElGSUVEEgCAAwCIAwGQAwCYAxegAwGqAwDAA-CoAcgDANgD8ao-4AMA6AMA-AMBgAQAkgQNL3V0L3YzL3ByZWJpZJgEAKIECjEwLjIuMTIuMzioBIqpB7IEDggAEAEYACAAKAAwADgCuAQAwAQAyAQA0gQOOTMyNSNBTVMxOjQzMjDaBAIIAeAEAfAEg8u-LogFAZgFAKAF______8BAxgBwAUAyQUABQEU8D_SBQkJBQt8AAAA2AUB4AUB8AWZ9CH6BQQIABAAkAYBmAYAuAYAwQYBITAAAPA_yAYA2gYWChAAOgEAGBAAGADgBgw.%26s%3D971dce9d49b6bee447c8a58774fb30b40fe98171;ts=1551889079;cet=0;cecb=\'></script>'
+    if (FEATURES.VIDEO) {
+      it('handles outstream video responses', function () {
+        const response = {
+          'tags': [{
+            'uuid': '84ab500420319d',
+            'ads': [{
+              'ad_type': 'video',
+              'cpm': 0.500000,
+              'notify_url': 'imptracker.com',
+              'rtb': {
+                'video': {
+                  'content': '<!-- VAST Creative -->'
+                }
+              },
+              'javascriptTrackers': '<script type=\'text/javascript\' async=\'true\' src=\'https://cdn.adnxs.com/v/s/152/trk.js#v;vk=appnexus.com-omid;tv=native1-18h;dom_id=%native_dom_id%;st=0;d=1x1;vc=iab;vid_ccr=1;tag_id=13232354;cb=https%3A%2F%2Fams1-ib.adnxs.com%2Fvevent%3Freferrer%3Dhttps253A%252F%252Ftestpages-pmahe.tp.adnxs.net%252F01_basic_single%26e%3DwqT_3QLNB6DNAwAAAwDWAAUBCLfl_-MFEMStk8u3lPTjRxih88aF0fq_2QsqNgkAAAECCCRAEQEHEAAAJEAZEQkAIREJACkRCQAxEQmoMOLRpwY47UhA7UhIAlCDy74uWJzxW2AAaM26dXjzjwWAAQGKAQNVU0SSAQEG8FCYAQGgAQGoAQGwAQC4AQHAAQTIAQLQAQDYAQDgAQDwAQCKAjt1ZignYScsIDI1Mjk4ODUsIDE1NTE4ODkwNzkpO3VmKCdyJywgOTc0OTQ0MDM2HgDwjZIC8QEha0RXaXBnajgtTHdLRUlQTHZpNFlBQ0NjOFZzd0FEZ0FRQVJJN1VoUTR0R25CbGdBWU1rR2FBQndMSGlrTDRBQlVvZ0JwQy1RQVFHWUFRR2dBUUdvQVFPd0FRQzVBZk90YXFRQUFDUkF3UUh6cldxa0FBQWtRTWtCbWo4dDA1ZU84VF9aQVFBQUEBAyRQQV80QUVBOVFFAQ4sQW1BSUFvQUlBdFFJBRAAdg0IeHdBSUF5QUlBNEFJQTZBSUEtQUlBZ0FNQm1BTUJxQVAFzIh1Z01KUVUxVE1UbzBNekl3NEFPVENBLi6aAmEhUXcxdGNRagUoEfQkblBGYklBUW9BRAl8AEEBqAREbzJEABRRSk1JU1EBGwRBQQGsAFURDAxBQUFXHQzwWNgCAOACrZhI6gIzaHR0cDovL3Rlc3RwYWdlcy1wbWFoZS50cC5hZG54cy5uZXQvMDFfYmFzaWNfc2luZ2xl8gITCg9DVVNUT01fTU9ERUxfSUQSAPICGgoWMhYAPExFQUZfTkFNRRIA8gIeCho2HQAIQVNUAT7wnElGSUVEEgCAAwCIAwGQAwCYAxegAwGqAwDAA-CoAcgDANgD8ao-4AMA6AMA-AMBgAQAkgQNL3V0L3YzL3ByZWJpZJgEAKIECjEwLjIuMTIuMzioBIqpB7IEDggAEAEYACAAKAAwADgCuAQAwAQAyAQA0gQOOTMyNSNBTVMxOjQzMjDaBAIIAeAEAfAEg8u-LogFAZgFAKAF______8BAxgBwAUAyQUABQEU8D_SBQkJBQt8AAAA2AUB4AUB8AWZ9CH6BQQIABAAkAYBmAYAuAYAwQYBITAAAPA_yAYA2gYWChAAOgEAGBAAGADgBgw.%26s%3D971dce9d49b6bee447c8a58774fb30b40fe98171;ts=1551889079;cet=0;cecb=\'></script>'
+            }]
           }]
-        }]
-      };
-      const bidderRequest = {
-        bids: [{
-          bidId: '84ab500420319d',
-          adUnitCode: 'code',
-          mediaTypes: {
-            video: {
-              context: 'outstream'
+        };
+        const bidderRequest = {
+          bids: [{
+            bidId: '84ab500420319d',
+            adUnitCode: 'code',
+            mediaTypes: {
+              video: {
+                context: 'outstream'
+              }
             }
-          }
-        }]
-      }
+          }]
+        }
 
-      const result = spec.interpretResponse({ body: response }, {bidderRequest});
-      expect(result[0]).not.to.have.property('vastXml');
-      expect(result[0]).not.to.have.property('vastUrl');
-      expect(result[0]).to.have.property('width', 1);
-      expect(result[0]).to.have.property('height', 1);
-      expect(result[0]).to.have.property('mediaType', 'banner');
-    });
+        const result = spec.interpretResponse({ body: response }, {bidderRequest});
+        expect(result[0]).not.to.have.property('vastXml');
+        expect(result[0]).not.to.have.property('vastUrl');
+        expect(result[0]).to.have.property('width', 1);
+        expect(result[0]).to.have.property('height', 1);
+        expect(result[0]).to.have.property('mediaType', 'banner');
+      });
+    }
   });
 
   describe('getUserSyncs', function() {

package/test/spec/modules/conversantBidAdapter_spec.js

@@ -263,6 +263,7 @@ describe('Conversant adapter tests', function() {
     const payload = request.data;
 
     expect(payload).to.have.property('id', 'req000');
+    expect(payload.source).to.have.property('tid', 'req000');
     expect(payload).to.have.property('at', 1);
     expect(payload).to.have.property('imp');
     expect(payload.imp).to.be.an('array').with.lengthOf(8);

package/test/spec/modules/criteoBidAdapter_spec.js

@@ -883,6 +883,38 @@ describe('The Criteo bidding adapter', function () {
       expect(request.data.user.uspIab).to.equal('1YNY');
     });
 
+    it('should properly build a request with device sua field', function () {
+      const sua = {}
+      const bidRequests = [
+        {
+          bidder: 'criteo',
+          adUnitCode: 'bid-123',
+          transactionId: 'transaction-123',
+          mediaTypes: {
+            banner: {
+              sizes: [[728, 90]]
+            }
+          },
+          params: {
+            zoneId: 123,
+          },
+        },
+      ];
+      const bidderRequest = {
+        timeout: 3000,
+        uspConsent: '1YNY',
+        ortb2: {
+          device: {
+            sua: sua
+          }
+        }
+      };
+
+      const request = spec.buildRequests(bidRequests, bidderRequest);
+      expect(request.data.user.ext.sua).to.not.be.null;
+      expect(request.data.user.ext.sua).to.equal(sua);
+    });
+
     it('should properly build a request with gpp consent field', function () {
       const bidRequests = [
         {
@@ -1475,7 +1507,7 @@ describe('The Criteo bidding adapter', function () {
             creativecode: 'test-crId',
             width: 728,
             height: 90,
-            dealCode: 'myDealCode',
+            deal: 'myDealCode',
             adomain: ['criteo.com'],
           }],
         },

package/test/spec/modules/criteoIdSystem_spec.js

@@ -1,5 +1,6 @@
 import { criteoIdSubmodule, storage } from 'modules/criteoIdSystem.js';
 import * as utils from 'src/utils.js';
+import { gdprDataHandler, uspDataHandler, gppDataHandler } from '../../../src/adapterManager.js';
 import { server } from '../../mocks/xhr';
 
 const pastDateString = new Date(0).toString()
@@ -17,6 +18,9 @@ describe('CriteoId module', function () {
   let timeStampStub;
   let parseUrlStub;
   let triggerPixelStub;
+  let gdprConsentDataStub;
+  let uspConsentDataStub;
+  let gppConsentDataStub;
 
   beforeEach(function (done) {
     getCookieStub = sinon.stub(storage, 'getCookie');
@@ -27,6 +31,9 @@ describe('CriteoId module', function () {
     timeStampStub = sinon.stub(utils, 'timestamp').returns(nowTimestamp);
     parseUrlStub = sinon.stub(utils, 'parseUrl').returns({ protocol: 'https', hostname: 'testdev.com' })
     triggerPixelStub = sinon.stub(utils, 'triggerPixel');
+    gdprConsentDataStub = sinon.stub(gdprDataHandler, 'getConsentData');
+    uspConsentDataStub = sinon.stub(uspDataHandler, 'getConsentData');
+    gppConsentDataStub = sinon.stub(gppDataHandler, 'getConsentData');
     done();
   });
 
@@ -39,6 +46,9 @@ describe('CriteoId module', function () {
     timeStampStub.restore();
     triggerPixelStub.restore();
     parseUrlStub.restore();
+    gdprConsentDataStub.restore();
+    uspConsentDataStub.restore();
+    gppConsentDataStub.restore();
   });
 
   const storageTestCases = [
@@ -136,11 +146,11 @@ describe('CriteoId module', function () {
   }));
 
   const gdprConsentTestCases = [
-    { consentData: { gdprApplies: true, consentString: 'expectedConsentString' }, expected: 'expectedConsentString' },
-    { consentData: { gdprApplies: false, consentString: 'expectedConsentString' }, expected: undefined },
-    { consentData: { gdprApplies: true, consentString: undefined }, expected: undefined },
-    { consentData: { gdprApplies: 'oui', consentString: 'expectedConsentString' }, expected: undefined },
-    { consentData: undefined, expected: undefined }
+    { consentData: { gdprApplies: true, consentString: 'expectedConsentString' }, expectedGdprConsent: 'expectedConsentString', expectedGdpr: '1' },
+    { consentData: { gdprApplies: false, consentString: 'expectedConsentString' }, expectedGdprConsent: 'expectedConsentString', expectedGdpr: '0' },
+    { consentData: { gdprApplies: true, consentString: undefined }, expectedGdprConsent: undefined, expectedGdpr: '1' },
+    { consentData: { gdprApplies: 'oui', consentString: 'expectedConsentString' }, expectedGdprConsent: 'expectedConsentString', expectedGdpr: '0' },
+    { consentData: undefined, expectedGdprConsent: undefined, expectedGdpr: undefined }
   ];
 
   it('should call sync pixels if request by backend', function () {
@@ -225,14 +235,94 @@ describe('CriteoId module', function () {
 
   gdprConsentTestCases.forEach(testCase => it('should call user sync url with the gdprConsent', function () {
     let callBackSpy = sinon.spy();
-    let result = criteoIdSubmodule.getId(undefined, testCase.consentData);
+
+    gdprConsentDataStub.returns(testCase.consentData);
+
+    let result = criteoIdSubmodule.getId(undefined);
+    result.callback(callBackSpy);
+
+    let request = server.requests[0];
+
+    if (testCase.expectedGdprConsent) {
+      expect(request.url).to.have.string(`gdprString=${testCase.expectedGdprConsent}`);
+    } else {
+      expect(request.url).to.not.have.string('gdprString=');
+    }
+
+    if (testCase.expectedGdpr) {
+      expect(request.url).to.have.string(`gdpr=${testCase.expectedGdpr}`);
+    } else {
+      expect(request.url).to.not.have.string('gdpr=');
+    }
+
+    request.respond(
+      200,
+      { 'Content-Type': 'application/json' },
+      JSON.stringify({})
+    );
+
+    expect(callBackSpy.calledOnce).to.be.true;
+  }));
+
+  [undefined, 'abc'].forEach(usPrivacy => it('should call user sync url with the us privacy string', function () {
+    let callBackSpy = sinon.spy();
+
+    uspConsentDataStub.returns(usPrivacy);
+
+    let result = criteoIdSubmodule.getId(undefined);
     result.callback(callBackSpy);
 
     let request = server.requests[0];
-    if (testCase.expected) {
-      expect(request.url).to.have.string(`gdprString=${testCase.expected}`);
+
+    if (usPrivacy) {
+      expect(request.url).to.have.string(`us_privacy=${usPrivacy}`);
+    } else {
+      expect(request.url).to.not.have.string('us_privacy=');
+    }
+
+    request.respond(
+      200,
+      { 'Content-Type': 'application/json' },
+      JSON.stringify({})
+    );
+
+    expect(callBackSpy.calledOnce).to.be.true;
+  }));
+
+  [
+    {
+      consentData: {
+        gppString: 'abc',
+        applicableSections: [1]
+      },
+      expectedGpp: 'abc',
+      expectedGppSid: '1'
+    },
+    {
+      consentData: undefined,
+      expectedGpp: undefined,
+      expectedGppSid: undefined
+    }
+  ].forEach(testCase => it('should call user sync url with the gpp string', function () {
+    let callBackSpy = sinon.spy();
+
+    gppConsentDataStub.returns(testCase.consentData);
+
+    let result = criteoIdSubmodule.getId(undefined);
+    result.callback(callBackSpy);
+
+    let request = server.requests[0];
+
+    if (testCase.expectedGpp) {
+      expect(request.url).to.have.string(`gpp=${testCase.expectedGpp}`);
+    } else {
+      expect(request.url).to.not.have.string('gpp=');
+    }
+
+    if (testCase.expectedGppSid) {
+      expect(request.url).to.have.string(`gpp_sid=${testCase.expectedGppSid}`);
     } else {
-      expect(request.url).to.not.have.string('gdprString');
+      expect(request.url).to.not.have.string('gpp_sid=');
     }
 
     request.respond(