prebid.js 7.44.0 → 7.46.0

package/test/spec/modules/openxOrtbBidAdapter_spec.js

@@ -300,6 +300,18 @@ describe('OpenxRtbAdapter', function () {
     });
 
     context('common requests checks', function() {
+      it('should be able to handle multiformat requests', () => {
+        const multiformat = utils.deepClone(bidRequestsWithMediaTypes[0]);
+        multiformat.mediaTypes.video = {
+          context: 'outstream',
+          playerSize: [640, 480]
+        }
+        const requests = spec.buildRequests([multiformat], mockBidderRequest);
+        const outgoingFormats = requests.flatMap(rq => rq.data.imp.flatMap(imp => ['banner', 'video'].filter(k => imp[k] != null)));
+        const expected = FEATURES.VIDEO ? ['banner', 'video'] : ['banner']
+        expect(outgoingFormats).to.have.members(expected);
+      })
+
       it('should send bid request to openx url via POST', function () {
         const request = spec.buildRequests(bidRequestsWithMediaTypes, mockBidderRequest);
         expect(request[0].url).to.equal(REQUEST_URL);
@@ -1084,45 +1096,6 @@ describe('OpenxRtbAdapter', function () {
         });
       });
     }
-
-    it.skip('should send ad unit ids when any are defined', function () {
-      const bidRequestsWithUnitIds = [{
-        bidder: 'openx',
-        params: {
-          delDomain: 'test-del-domain'
-        },
-        adUnitCode: 'adunit-code',
-        mediaTypes: {
-          banner: {
-            sizes: [[300, 250], [300, 600]]
-          }
-        },
-        bidId: 'test-bid-id-1',
-        bidderRequestId: 'test-bid-request-1',
-        auctionId: 'test-auction-1',
-        transactionId: 'test-transaction-id-1'
-      }, {
-        bidder: 'openx',
-        params: {
-          unit: '22',
-          delDomain: 'test-del-domain'
-        },
-        adUnitCode: 'adunit-code',
-        mediaTypes: {
-          banner: {
-            sizes: [[728, 90]]
-          }
-        },
-        bidId: 'test-bid-id-2',
-        bidderRequestId: 'test-bid-request-2',
-        auctionId: 'test-auction-2',
-        transactionId: 'test-transaction-id-2'
-      }];
-      mockBidderRequest.bids = bidRequestsWithUnitIds;
-      const request = spec.buildRequests(bidRequestsWithUnitIds, mockBidderRequest);
-      expect(request[0].data.imp[1].tagid).to.equal(bidRequestsWithUnitIds[1].params.unit);
-      expect(request[0].data.imp[1].ext.divid).to.equal(bidRequestsWithUnitIds[1].params.adUnitCode);
-    });
   });
 
   describe('interpretResponse()', function () {

package/test/spec/modules/pairIdSystem_spec.js

@@ -0,0 +1,68 @@
+import { storage, pairIdSubmodule } from 'modules/pairIdSystem.js';
+import * as utils from 'src/utils.js';
+
+describe('pairId', function () {
+  let sandbox;
+  let logErrorStub;
+
+  beforeEach(() => {
+    sandbox = sinon.sandbox.create();
+    logErrorStub = sandbox.stub(utils, 'logError');
+  });
+  afterEach(() => {
+    sandbox.restore();
+  });
+
+  it('should log an error if no ID is found when getId', function() {
+    pairIdSubmodule.getId({ params: {} });
+    expect(logErrorStub.calledOnce).to.be.true;
+  });
+
+  it('should read pairId from local storage if exists', function() {
+    let pairIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3'];
+    sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('pairId').returns(btoa(JSON.stringify(pairIds)));
+
+    let id = pairIdSubmodule.getId({ params: {} });
+    expect(id).to.be.deep.equal({id: pairIds});
+  });
+
+  it('should read pairId from cookie if exists', function() {
+    let pairIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6'];
+    sandbox.stub(storage, 'getCookie').withArgs('pairId').returns(btoa(JSON.stringify(pairIds)));
+
+    let id = pairIdSubmodule.getId({ params: {} });
+    expect(id).to.be.deep.equal({id: pairIds});
+  });
+
+  it('should read pairId from default liveramp envelope local storage key if configured', function() {
+    let pairIds = ['test-pair-id1', 'test-pair-id2', 'test-pair-id3'];
+    sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('_lr_pairId').returns(btoa(JSON.stringify({'envelope': pairIds})));
+    let id = pairIdSubmodule.getId({
+      params: {
+        liveramp: {}
+      }})
+    expect(id).to.be.deep.equal({id: pairIds})
+  })
+
+  it('should read pairId from default liveramp envelope cookie entry if configured', function() {
+    let pairIds = ['test-pair-id4', 'test-pair-id5', 'test-pair-id6'];
+    sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('_lr_pairId').returns(btoa(JSON.stringify({'envelope': pairIds})));
+    let id = pairIdSubmodule.getId({
+      params: {
+        liveramp: {}
+      }})
+    expect(id).to.be.deep.equal({id: pairIds})
+  })
+
+  it('should read pairId from specified liveramp envelope cookie entry if configured with storageKey', function() {
+    let pairIds = ['test-pair-id7', 'test-pair-id8', 'test-pair-id9'];
+    sandbox.stub(storage, 'getDataFromLocalStorage').withArgs('lr_pairId_custom').returns(btoa(JSON.stringify({'envelope': pairIds})));
+    let id = pairIdSubmodule.getId({
+      params: {
+        liveramp: {
+          storageKey: 'lr_pairId_custom'
+        }
+      }})
+    expect(id).to.be.deep.equal({id: pairIds})
+  })
+});

package/test/spec/modules/pubCommonId_spec.js

@@ -233,23 +233,6 @@ describe('Publisher Common ID', function () {
         });
       });
     });
-
-    it.skip('disable auto create', function() {
-      setConfig({
-        create: false
-      });
-
-      const config = getPubcidConfig();
-      expect(config.create).to.be.false;
-      expect(config.typeEnabled).to.equal('html5');
-
-      let adUnits = getAdUnits();
-      let innerAdUnits;
-      requestBidHook((config) => { innerAdUnits = config.adUnits }, {adUnits});
-
-      const pubcid = localStorage.getItem(ID_NAME);
-      expect(pubcid).to.be.null;
-    });
   });
 
   describe('Invoking requestBid', function () {