prebid.js 7.40.0 → 7.41.0

package/test/spec/modules/conversantBidAdapter_spec.js

@@ -389,6 +389,14 @@ describe('Conversant adapter tests', function() {
     expect(payload.device).to.have.property('ua', navigator.userAgent);
 
     expect(payload).to.not.have.property('user'); // there should be no user by default
+    expect(payload).to.not.have.property('tmax'); // there should be no user by default
+  });
+
+  it('Verify timeout', () => {
+    const bidderRequest = { timeout: 9999 };
+    const request = spec.buildRequests(bidRequests, bidderRequest);
+    const payload = request.data;
+    expect(payload.tmax).equals(bidderRequest.timeout);
   });
 
   it('Verify first party data', () => {

package/test/spec/modules/dfpAdServerVideo_spec.js

@@ -1,7 +1,7 @@
 import { expect } from 'chai';
 
 import parse from 'url-parse';
-import { buildDfpVideoUrl, buildAdpodVideoUrl } from 'modules/dfpAdServerVideo.js';
+import {buildDfpVideoUrl, buildAdpodVideoUrl, dep} from 'modules/dfpAdServerVideo.js';
 import adUnit from 'test/fixtures/video/adUnit.json';
 import * as utils from 'src/utils.js';
 import { config } from 'src/config.js';
@@ -13,6 +13,7 @@ import { server } from 'test/mocks/xhr.js';
 import * as adServer from 'src/adserver.js';
 import {deepClone} from 'src/utils.js';
 import {hook} from '../../../src/hook.js';
+import {getRefererInfo} from '../../../src/refererDetection.js';
 
 const bid = {
   videoCacheKey: 'abc',
@@ -27,6 +28,40 @@ describe('The DFP video support module', function () {
     hook.ready();
   });
 
+  let sandbox;
+
+  beforeEach(() => {
+    sandbox = sinon.sandbox.create();
+  });
+
+  afterEach(() => {
+    sandbox.restore();
+  });
+
+  Object.entries({
+    params: {
+      params: {
+        'iu': 'my/adUnit'
+      }
+    },
+    url: {
+      url: 'https://some-example-url.com'
+    }
+  }).forEach(([t, options]) => {
+    describe(`when using ${t}`, () => {
+      it('should use page location as default for description_url', () => {
+        sandbox.stub(dep, 'ri').callsFake(() => ({page: 'example.com'}));
+
+        const url = parse(buildDfpVideoUrl(Object.assign({
+          adUnit: adUnit,
+          bid: bid,
+        }, options)));
+        const prm = utils.parseQS(url.query);
+        expect(prm.description_url).to.eql('example.com');
+      })
+    })
+  })
+
   it('should make a legal request URL when given the required params', function () {
     const url = parse(buildDfpVideoUrl({
       adUnit: adUnit,
@@ -63,9 +98,6 @@ describe('The DFP video support module', function () {
     }));
 
     expect(url.host).to.equal('video.adserver.example');
-
-    const queryObject = utils.parseQS(url.query);
-    expect(queryObject.description_url).to.equal('vastUrl.example');
   });
 
   it('requires a params object or url', function () {

package/test/spec/modules/freewheel-sspBidAdapter_spec.js

@@ -1,8 +1,10 @@
 import { expect } from 'chai';
 import { spec } from 'modules/freewheel-sspBidAdapter.js';
 import { newBidder } from 'src/adapters/bidderFactory.js';
+import { createEidsArray } from 'modules/userId/eids.js';
 
 const ENDPOINT = '//ads.stickyadstv.com/www/delivery/swfIndex.php';
+const PREBID_VERSION = '$prebid.version$';
 
 describe('freewheelSSP BidAdapter Test', () => {
   const adapter = newBidder(spec);
@@ -131,6 +133,22 @@ describe('freewheelSSP BidAdapter Test', () => {
       expect(payload._fw_bidfloorcur).to.deep.equal('USD');
     });
 
+    it('should pass 3rd party IDs with the request when present', function () {
+      const bidRequest = bidRequests[0];
+      bidRequest.userIdAsEids = createEidsArray({
+        tdid: 'TTD_ID_FROM_USER_ID_MODULE',
+        admixerId: 'admixerId_FROM_USER_ID_MODULE',
+        adtelligentId: 'adtelligentId_FROM_USER_ID_MODULE'
+      });
+      const request = spec.buildRequests(bidRequests);
+      const payload = request[0].data;
+      expect(payload._fw_prebid_3p_UID).to.deep.equal(JSON.stringify([
+        {source: 'adserver.org', uids: [{id: 'TTD_ID_FROM_USER_ID_MODULE', atype: 1, ext: {rtiPartner: 'TDID'}}]},
+        {source: 'admixer.net', uids: [{id: 'admixerId_FROM_USER_ID_MODULE', atype: 3}]},
+        {source: 'adtelligent.com', uids: [{id: 'adtelligentId_FROM_USER_ID_MODULE', atype: 3}]},
+      ]));
+    });
+
     it('should return empty bidFloorCurrency when bidfloor <= 0', () => {
       const bidRequest = bidRequests[0];
       bidRequest.getFloor = () => ({ currency: 'USD', floor: -1 });
@@ -149,6 +167,7 @@ describe('freewheelSSP BidAdapter Test', () => {
       expect(payload.componentId).to.equal('prebid');
       expect(payload.componentSubId).to.equal('mustang');
       expect(payload.playerSize).to.equal('300x600');
+      expect(payload.pbjs_version).to.equal(PREBID_VERSION);
     });
 
     it('should return a properly formatted request with schain defined', function () {

package/test/spec/modules/gridBidAdapter_spec.js

@@ -575,6 +575,30 @@ describe('TheMediaGrid Adapter', function () {
       expect(payload.regs.ext).to.have.property('us_privacy', '1YNN');
     });
 
+    it('should add gpp information to the request via bidderRequest.gppConsent', function () {
+      let consentString = 'abc1234';
+      const gppBidderRequest = Object.assign({gppConsent: {gppString: consentString, applicableSections: [8]}}, bidderRequest);
+
+      const [request] = spec.buildRequests(bidRequests, gppBidderRequest);
+      const payload = JSON.parse(request.data);
+
+      expect(payload.regs).to.exist;
+      expect(payload.regs.gpp).to.equal(consentString);
+      expect(payload.regs.gpp_sid).to.deep.equal([8]);
+    });
+
+    it('should add gpp information to the request via bidderRequest.ortb2.regs.gpp', function () {
+      let consentString = 'abc1234';
+      const gppBidderRequest = Object.assign({ortb2: {regs: {gpp: consentString, gpp_sid: [8]}}}, bidderRequest);
+
+      const [request] = spec.buildRequests(bidRequests, gppBidderRequest);
+      const payload = JSON.parse(request.data);
+
+      expect(payload.regs).to.exist;
+      expect(payload.regs.gpp).to.equal(consentString);
+      expect(payload.regs.gpp_sid).to.deep.equal([8]);
+    });
+
     it('if userId is present payload must have user.ext param with right keys', function () {
       const eids = [
         {

package/test/spec/modules/ixBidAdapter_spec.js

@@ -3469,7 +3469,7 @@ describe('IndexexchangeAdapter', function () {
       expect(requestWithConsent.regs.ext.us_privacy).to.equal('1YYN');
     });
 
-    it('should contain `consented_providers_settings.consented_providers` & consent on user.ext when both are provided', function () {
+    it('should contain `consented_providers_settings.addtl_consent` & consent on user.ext when both are provided', function () {
       const options = {
         gdprConsent: {
           consentString: '3huaa11=qu3198ae',
@@ -3479,11 +3479,11 @@ describe('IndexexchangeAdapter', function () {
 
       const validBidWithConsent = spec.buildRequests(DEFAULT_BANNER_VALID_BID, options);
       const requestWithConsent = extractPayload(validBidWithConsent[0]);
-      expect(requestWithConsent.user.ext.consented_providers_settings.consented_providers).to.equal('1~1.35.41.101');
+      expect(requestWithConsent.user.ext.consented_providers_settings.addtl_consent).to.equal('1~1.35.41.101');
       expect(requestWithConsent.user.ext.consent).to.equal('3huaa11=qu3198ae');
     });
 
-    it('should not contain `consented_providers_settings.consented_providers` on user.ext when consent is not provided', function () {
+    it('should not contain `consented_providers_settings.addtl_consent` on user.ext when consent is not provided', function () {
       const options = {
         gdprConsent: {
           addtlConsent: '1~1.35.41.101',
@@ -3492,7 +3492,7 @@ describe('IndexexchangeAdapter', function () {
 
       const validBidWithConsent = spec.buildRequests(DEFAULT_BANNER_VALID_BID, options);
       const requestWithConsent = extractPayload(validBidWithConsent[0]);
-      expect(utils.deepAccess(requestWithConsent, 'user.ext.consented_providers_settings')).to.not.exist;
+      expect(utils.deepAccess(requestWithConsent, 'user.ext.consented_providers_settings.addtl_consent')).to.not.exist;
       expect(utils.deepAccess(requestWithConsent, 'user.ext.consent')).to.not.exist;
     });
 

package/test/spec/modules/nobidBidAdapter_spec.js

@@ -14,6 +14,38 @@ describe('Nobid Adapter', function () {
     });
   });
 
+  describe('buildRequestsWithFloor', function () {
+    const SITE_ID = 2;
+    const REFERER = 'https://www.examplereferer.com';
+    let bidRequests = [
+      {
+        'bidder': 'nobid',
+        'params': {
+          'siteId': SITE_ID
+        },
+        'getFloor': () => { return { currency: 'USD', floor: 1.00 } },
+        'adUnitCode': 'adunit-code',
+        'sizes': [[300, 250]],
+        'bidId': '30b31c1838de1e',
+        'bidderRequestId': '22edbae2733bf6',
+        'auctionId': '1d1a030790a475'
+      }
+    ];
+
+    let bidderRequest = {
+      refererInfo: {page: REFERER}
+    }
+
+    it('should FLoor = 1', function () {
+      spec.buildRequests(bidRequests, bidderRequest);
+      const request = spec.buildRequests(bidRequests, bidderRequest);
+      /* eslint-disable no-console */
+      console.log('request.data:', request.data);
+      const payload = JSON.parse(request.data);
+      expect(payload.a[0].floor).to.equal(1);
+    });
+  });
+
   describe('isBidRequestValid', function () {
     let bid = {
       'bidder': 'nobid',

package/test/spec/modules/permutiveRtdProvider_spec.js

@@ -196,12 +196,67 @@ describe('permutiveRtdProvider', function () {
       setBidderRtb(bidderConfig, moduleConfig, segmentsData)
 
       acBidders.forEach(bidder => {
-        expect(bidderConfig[bidder].user.data).to.deep.include.members([{
-          name: 'permutive.com',
-          segment: expectedTargetingData
-        }])
+        const customCohorts = segmentsData[bidder] || []
+        expect(bidderConfig[bidder].user.data).to.deep.include.members([
+          {
+            name: 'permutive.com',
+            segment: expectedTargetingData,
+          },
+          // Should have custom cohorts specific for that bidder
+          {
+            name: 'permutive',
+            segment: customCohorts.map(seg => {
+              return { id: seg }
+            }),
+          },
+        ])
       })
     })
+
+    it('should override existing ortb2.user.data reserved by permutive RTD', function () {
+      const reservedPermutiveStandardName = 'permutive.com'
+      const reservedPermutiveCustomCohortName = 'permutive'
+
+      const moduleConfig = getConfig()
+      const acBidders = moduleConfig.params.acBidders
+      const segmentsData = transformedTargeting()
+
+      const sampleOrtbConfig = {
+        user: {
+          data: [
+            {
+              name: reservedPermutiveCustomCohortName,
+              segment: [{ id: 'remove-me' }, { id: 'remove-me-also' }]
+            },
+            {
+              name: reservedPermutiveStandardName,
+              segment: [{ id: 'remove-me-also-also' }, { id: 'remove-me-also-also-also' }]
+            }
+          ]
+        }
+      }
+
+      const bidderConfig = Object.fromEntries(acBidders.map(bidder => [bidder, sampleOrtbConfig]))
+
+      setBidderRtb(bidderConfig, moduleConfig, segmentsData)
+
+      acBidders.forEach(bidder => {
+        const customCohorts = segmentsData[bidder] || []
+
+        expect(bidderConfig[bidder].user.data).to.not.deep.include.members([...sampleOrtbConfig.user.data])
+        expect(bidderConfig[bidder].user.data).to.deep.include.members([
+          {
+            name: reservedPermutiveCustomCohortName,
+            segment: customCohorts.map(id => ({ id })),
+          },
+          {
+            name: reservedPermutiveStandardName,
+            segment: segmentsData.ac.map(id => ({ id })),
+          },
+        ])
+      })
+    })
+
     it('should include ortb2 user data transformation for IAB audience taxonomy', function() {
       const moduleConfig = getConfig()
       const bidderConfig = {}
@@ -647,6 +702,7 @@ function transformedTargeting (data = getTargetingData()) {
   return {
     ac: [...data._pcrprs, ...data._ppam, ...data._psegs.filter(seg => seg >= 1000000)],
     appnexus: data._papns,
+    ix: data._pindexs,
     rubicon: data._prubicons,
     gam: data._pdfps,
     ssp: data._pssps,
@@ -660,6 +716,7 @@ function getTargetingData () {
     _papns: ['appnexus1', 'appnexus2'],
     _psegs: ['1234', '1000001', '1000002'],
     _ppam: ['ppam1', 'ppam2'],
+    _pindexs: ['pindex1', 'pindex2'],
     _pcrprs: ['pcrprs1', 'pcrprs2', 'dup'],
     _pssps: { ssps: ['xyz', 'abc', 'dup'], cohorts: ['123', 'abc'] }
   }

package/test/spec/modules/pubwiseBidAdapter_spec.js

@@ -2,7 +2,7 @@
 
 import {expect} from 'chai';
 import {spec} from 'modules/pubwiseBidAdapter.js';
-import {_checkMediaType} from 'modules/pubwiseBidAdapter.js'; // this is exported only for testing so maintaining the JS convention of _ to indicate the intent
+import {_checkVideoPlacement, _checkMediaType} from 'modules/pubwiseBidAdapter.js'; // this is exported only for testing so maintaining the JS convention of _ to indicate the intent
 import {_parseAdSlot} from 'modules/pubwiseBidAdapter.js'; // this is exported only for testing so maintaining the JS convention of _ to indicate the intent
 import * as utils from 'src/utils.js';
 
@@ -486,6 +486,28 @@ const samplePBBidObjects = [
 ];
 
 describe('PubWiseAdapter', function () {
+  describe('Handles Params Properly', function () {
+    it('properly sets the default endpoint', function () {
+      const referenceEndpoint = 'https://bid.pubwise.io/prebid';
+      let endpointBidRequest = utils.deepClone(sampleValidBidRequests);
+      // endpointBidRequest.forEach((bidRequest) => {
+      //   bidRequest.params.endpoint_url = newEndpoint;
+      // });
+      let result = spec.buildRequests(endpointBidRequest, {auctionId: 'placeholder'});
+      expect(result.url).to.equal(referenceEndpoint);
+    });
+
+    it('allows endpoint to be reset', function () {
+      const newEndpoint = 'http://www.pubwise.io/endpointtest';
+      let endpointBidRequest = utils.deepClone(sampleValidBidRequests);
+      endpointBidRequest.forEach((bidRequest) => {
+        bidRequest.params.endpoint_url = newEndpoint;
+      });
+      let result = spec.buildRequests(endpointBidRequest, {auctionId: 'placeholder'});
+      expect(result.url).to.equal(newEndpoint);
+    });
+  });
+
   describe('Properly Validates Bids', function () {
     it('valid bid', function () {
       let validBid = {
@@ -555,14 +577,14 @@ describe('PubWiseAdapter', function () {
     it('identifies native adm type', function() {
       let adm = '{"ver":"1.2","assets":[{"title":{"text":"PubWise Test"}},{"img":{"type":3,"url":"http://www.pubwise.io"}},{"img":{"type":1,"url":"http://www.pubwise.io"}},{"data":{"type":2,"value":"PubWise Test Desc"}},{"data":{"type":1,"value":"PubWise.io"}}],"link":{"url":""}}';
       let newBid = {mediaType: 'unknown'};
-      _checkMediaType(adm, newBid);
+      _checkMediaType({adm}, newBid);
       expect(newBid.mediaType).to.equal('native', adm + ' Is a Native adm');
     });
 
     it('identifies banner adm type', function() {
       let adm = '<div style="box-sizing: border-box;width:298px;height:248px;border: 1px solid rgba(0,0,0,.25);border-radius:10px;">↵	<h3 style="margin-top:80px;text-align: center;">PubWise Test Bid</h3>↵</div>';
       let newBid = {mediaType: 'unknown'};
-      _checkMediaType(adm, newBid);
+      _checkMediaType({adm}, newBid);
       expect(newBid.mediaType).to.equal('banner', adm + ' Is a Banner adm');
     });
   });
@@ -582,4 +604,292 @@ describe('PubWiseAdapter', function () {
       expect(pbResponse).to.deep.equal(samplePBBidObjects);
     });
   });
+
+  describe('Video Testing', function () {
+    /**
+     * Video Testing
+     */
+
+    const videoBidRequests =
+    [
+      {
+        code: 'video1',
+        mediaTypes: {
+          video: {
+            playerSize: [640, 480],
+            context: 'instream'
+          }
+        },
+        bidder: 'pwbid',
+        bidId: '22bddb28db77d',
+        adUnitCode: 'Div1',
+        params: {
+          siteId: 'xxxxxx',
+          video: {
+            mimes: ['video/mp4', 'video/x-flv'],
+            skippable: true,
+            minduration: 5,
+            maxduration: 30,
+            startdelay: 5,
+            playbackmethod: [1, 3],
+            api: [1, 2],
+            protocols: [2, 3],
+            battr: [13, 14],
+            linearity: 1,
+            placement: 2,
+            minbitrate: 10,
+            maxbitrate: 10
+          }
+        }
+      }
+    ];
+
+    let newvideoRequests = [{
+      'bidder': 'pwbid',
+      'params': {
+        'siteId': 'xxxxx',
+        'video': {
+          'mimes': ['video/mp4'],
+          'skippable': true,
+          'protocols': [1, 2, 5],
+          'linearity': 1
+        }
+      },
+      'mediaTypes': {
+        'video': {
+          'playerSize': [
+            [640, 480]
+          ],
+          'protocols': [1, 2, 5],
+          'context': 'instream',
+          'mimes': ['video/flv'],
+          'skippable': false,
+          'skip': 1,
+          'linearity': 2
+        }
+      },
+      'adUnitCode': 'video1',
+      'transactionId': '803e3750-0bbe-4ffe-a548-b6eca15087bf',
+      'sizes': [
+        [640, 480]
+      ],
+      'bidId': '2c95df014cfe97',
+      'bidderRequestId': '1fe59391566442',
+      'auctionId': '3a4118ef-fb96-4416-b0b0-3cfc1cebc142',
+      'src': 'client',
+      'bidRequestsCount': 1,
+      'bidderRequestsCount': 1,
+      'bidderWinsCount': 0
+    }];
+
+    let newvideoBidResponses = {
+      'body': {
+        'id': '1621441141473',
+        'cur': 'USD',
+        'customdata': 'openrtb1',
+        'ext': {
+          'buyid': 'myBuyId'
+        },
+        'seatbid': [{
+          'bid': [{
+            'id': '2c95df014cfe97',
+            'impid': '2c95df014cfe97',
+            'price': 4.2,
+            'cid': 'test1',
+            'crid': 'test2',
+            'adm': "<VAST version='3.0'><Ad id='601364'><InLine><AdSystem>Acudeo Compatible</AdSystem><AdTitle>VAST 2.0 Instream Test 1</AdTitle><Description>VAST 2.0 Instream Test 1</Description><Creatives><Creative AdID='601364'><Linear skipoffset='20%'><TrackingEvents><Tracking event='close'><![CDATA[https://pwtracking.com/linear/close]]></Tracking><Tracking event='skip'><![CDATA[https://pwtracking.com/linear/skip]]></Tracking><MediaFiles><MediaFile delivery='progressive' type='video/mp4' bitrate='500' width='400' height='300' scalable='true' maintainAspectRatio='true'><![CDATA[https://localhost/pubwise.mp4]]></MediaFile></MediaFiles></Linear></Creative></Creatives></InLine></Ad></VAST>",
+            'w': 0,
+            'h': 0
+          }],
+          'ext': {
+            'buyid': 'myBuyId'
+          }
+        }]
+      },
+      'headers': {}
+    };
+
+    let videoBidResponse = {
+      'body': {
+        'id': '93D3BAD6-E2E2-49FB-9D89-920B1761C865',
+        'seatbid': [{
+          'bid': [{
+            'id': '74858439-49D7-4169-BA5D-44A046315B2F',
+            'impid': '22bddb28db77d',
+            'price': 1.3,
+            'adm': '<VAST version="3.0"><Ad id="601364"><!--not real sample--></Ad></VAST>',
+            'h': 250,
+            'w': 300,
+            'ext': {
+              'deal_channel': 6
+            }
+          }]
+        }]
+      }
+    };
+
+    it('Request params check for video ad', function () {
+      let request = spec.buildRequests(videoBidRequests, {
+        auctionId: 'new-auction-id'
+      });
+      let data = request.data;
+      expect(data.imp[0].video).to.exist;
+      expect(data.imp[0].tagid).to.equal('Div1');
+      expect(data.imp[0]['video']['mimes']).to.exist.and.to.be.an('array');
+      expect(data.imp[0]['video']['mimes'][0]).to.equal(videoBidRequests[0].params.video['mimes'][0]);
+      expect(data.imp[0]['video']['mimes'][1]).to.equal(videoBidRequests[0].params.video['mimes'][1]);
+      expect(data.imp[0]['video']['minduration']).to.equal(videoBidRequests[0].params.video['minduration']);
+      expect(data.imp[0]['video']['maxduration']).to.equal(videoBidRequests[0].params.video['maxduration']);
+      expect(data.imp[0]['video']['startdelay']).to.equal(videoBidRequests[0].params.video['startdelay']);
+
+      expect(data.imp[0]['video']['playbackmethod']).to.exist.and.to.be.an('array');
+      expect(data.imp[0]['video']['playbackmethod'][0]).to.equal(videoBidRequests[0].params.video['playbackmethod'][0]);
+      expect(data.imp[0]['video']['playbackmethod'][1]).to.equal(videoBidRequests[0].params.video['playbackmethod'][1]);
+
+      expect(data.imp[0]['video']['api']).to.exist.and.to.be.an('array');
+      expect(data.imp[0]['video']['api'][0]).to.equal(videoBidRequests[0].params.video['api'][0]);
+      expect(data.imp[0]['video']['api'][1]).to.equal(videoBidRequests[0].params.video['api'][1]);
+
+      expect(data.imp[0]['video']['protocols']).to.exist.and.to.be.an('array');
+      expect(data.imp[0]['video']['protocols'][0]).to.equal(videoBidRequests[0].params.video['protocols'][0]);
+      expect(data.imp[0]['video']['protocols'][1]).to.equal(videoBidRequests[0].params.video['protocols'][1]);
+
+      expect(data.imp[0]['video']['battr']).to.exist.and.to.be.an('array');
+      expect(data.imp[0]['video']['battr'][0]).to.equal(videoBidRequests[0].params.video['battr'][0]);
+      expect(data.imp[0]['video']['battr'][1]).to.equal(videoBidRequests[0].params.video['battr'][1]);
+
+      expect(data.imp[0]['video']['linearity']).to.equal(videoBidRequests[0].params.video['linearity']);
+      expect(data.imp[0]['video']['placement']).to.equal(videoBidRequests[0].params.video['placement']);
+      expect(data.imp[0]['video']['minbitrate']).to.equal(videoBidRequests[0].params.video['minbitrate']);
+      expect(data.imp[0]['video']['maxbitrate']).to.equal(videoBidRequests[0].params.video['maxbitrate']);
+
+      expect(data.imp[0]['video']['w']).to.equal(videoBidRequests[0].mediaTypes.video.playerSize[0]);
+      expect(data.imp[0]['video']['h']).to.equal(videoBidRequests[0].mediaTypes.video.playerSize[1]);
+    });
+
+    it('should assign mediaType even if bid.ext.mediaType does not exists', function() {
+      let newrequest = spec.buildRequests(newvideoRequests, {
+        auctionId: 'new-auction-id'
+      });
+      let newresponse = spec.interpretResponse(newvideoBidResponses, newrequest);
+      expect(newresponse[0].mediaType).to.equal('video');
+    });
+
+    it('should not assign renderer if bid is video and request is for instream', function() {
+      let request = spec.buildRequests(videoBidRequests, {
+        auctionId: 'new-auction-id'
+      });
+      let response = spec.interpretResponse(videoBidResponse, request);
+      expect(response[0].renderer).to.not.exist;
+    });
+
+    it('should process instream and outstream', function() {
+      let validOutstreamRequest =
+      {
+        code: 'video1',
+        mediaTypes: {
+          video: {
+            playerSize: [640, 480],
+            context: 'outstream'
+          }
+        },
+        bidder: 'pwbid',
+        bidId: '47acc48ad47af5',
+        requestId: '0fb4905b-1234-4152-86be-c6f6d259ba99',
+        bidderRequestId: '1c56ad30b9b8ca8',
+        transactionId: '92489f71-1bf2-49a0-adf9-000cea934729',
+        params: {
+          siteId: 'xxxxx',
+          adSlot: 'Div1', // ad_id or tagid
+          video: {
+            mimes: ['video/mp4', 'video/x-flv'],
+            skippable: true,
+            minduration: 5,
+            maxduration: 30
+          }
+        }
+      };
+
+      let outstreamBidRequest =
+      [
+        validOutstreamRequest
+      ];
+
+      let validInstreamRequest = {
+        code: 'video1',
+        mediaTypes: {
+          video: {
+            playerSize: [640, 480],
+            context: 'instream'
+          }
+        },
+        bidder: 'pwbid',
+        bidId: '47acc48ad47af5',
+        requestId: '0fb4905b-1234-4152-86be-c6f6d259ba99',
+        bidderRequestId: '1c56ad30b9b8ca8',
+        transactionId: '92489f71-1bf2-49a0-adf9-000cea934729',
+        params: {
+          siteId: 'xxxxx',
+          adSlot: 'Div1', // ad_id or tagid
+          video: {
+            mimes: ['video/mp4', 'video/x-flv'],
+            skippable: true,
+            minduration: 5,
+            maxduration: 30
+          }
+        }
+      };
+
+      let instreamBidRequest =
+      [
+        validInstreamRequest
+      ];
+
+      let outstreamRequest = spec.isBidRequestValid(validOutstreamRequest);
+      expect(outstreamRequest).to.equal(false);
+
+      let instreamRequest = spec.isBidRequestValid(validInstreamRequest);
+      expect(instreamRequest).to.equal(true);
+    });
+
+    describe('Checking for Video.Placement property', function() {
+      let sandbox, utilsMock;
+      const adUnit = 'DivCheckPlacement';
+      const msg_placement_missing = 'PubWise: Video.Placement param missing for DivCheckPlacement';
+      let videoData = {
+        battr: [6, 7],
+        skipafter: 15,
+        maxduration: 50,
+        context: 'instream',
+        playerSize: [640, 480],
+        skip: 0,
+        connectiontype: [1, 2, 6],
+        skipmin: 10,
+        minduration: 10,
+        mimes: ['video/mp4', 'video/x-flv'],
+      }
+      beforeEach(() => {
+        utilsMock = sinon.mock(utils);
+        sandbox = sinon.sandbox.create();
+        sandbox.spy(utils, 'logWarn');
+      });
+
+      afterEach(() => {
+        utilsMock.restore();
+        sandbox.restore();
+      })
+
+      it('should log Video.Placement param missing', function() {
+        _checkVideoPlacement(videoData, adUnit);
+        // when failing this gives an odd message about "AssertError: expected logWarn to be called with arguments" it means the specific message expected
+        sinon.assert.calledWith(utils.logWarn, msg_placement_missing);
+      })
+      it('shoud not log Video.Placement param missing', function() {
+        videoData['placement'] = 1;
+        _checkVideoPlacement(videoData, adUnit);
+        sinon.assert.neverCalledWith(utils.logWarn, msg_placement_missing);
+      })
+    });
+    // end video testing
+  });
 });