prebid.js 7.4.0 → 7.7.0

package/test/spec/modules/gdprEnforcement_spec.js

@@ -1,21 +1,21 @@
 import {
   deviceAccessHook,
-  enableAnalyticsHook,
-  enforcementRules,
-  getGvlid,
-  internal,
+  setEnforcementConfig,
+  userSyncHook,
+  userIdHook,
   makeBidRequestsHook,
+  validateRules,
+  enforcementRules,
   purpose1Rule,
   purpose2Rule,
-  setEnforcementConfig,
-  userIdHook,
-  userSyncHook,
-  validateRules
+  enableAnalyticsHook,
+  getGvlid,
+  internal
 } from 'modules/gdprEnforcement.js';
-import {config} from 'src/config.js';
-import adapterManager, {gdprDataHandler} from 'src/adapterManager.js';
+import { config } from 'src/config.js';
+import adapterManager, { gdprDataHandler } from 'src/adapterManager.js';
 import * as utils from 'src/utils.js';
-import {validateStorageEnforcement} from 'src/storageManager.js';
+import { validateStorageEnforcement } from 'src/storageManager.js';
 import * as events from 'src/events.js';
 
 describe('gdpr enforcement', function () {
@@ -98,9 +98,9 @@ describe('gdpr enforcement', function () {
   };
 
   after(function () {
-    validateStorageEnforcement.getHooks({hook: deviceAccessHook}).remove();
+    validateStorageEnforcement.getHooks({ hook: deviceAccessHook }).remove();
     $$PREBID_GLOBAL$$.requestBids.getHooks().remove();
-    adapterManager.makeBidRequests.getHooks({hook: makeBidRequestsHook}).remove();
+    adapterManager.makeBidRequests.getHooks({ hook: makeBidRequestsHook }).remove();
   })
 
   describe('deviceAccessHook', function () {
@@ -149,7 +149,7 @@ describe('gdpr enforcement', function () {
         hasEnforcementHook: true,
         valid: false
       }
-      sinon.assert.calledWith(nextFnSpy, undefined, undefined, undefined, result);
+      sinon.assert.calledWith(nextFnSpy, undefined, undefined, result);
     });
 
     it('should only check for consent for vendor exceptions when enforcePurpose and enforceVendor are false', function () {
@@ -199,53 +199,6 @@ describe('gdpr enforcement', function () {
       expect(logWarnSpy.callCount).to.equal(1);
     });
 
-    it('should allow device access when enforce vendor but module is vendorless ', function () {
-      adapterManagerStub.withArgs('pubCommonId').returns(getBidderSpec(1));
-      setEnforcementConfig({
-        gdpr: {
-          rules: [{
-            purpose: 'storage',
-            enforcePurpose: true,
-            enforceVendor: true,
-          }]
-        }
-      });
-      let consentData = {}
-      consentData.vendorData = staticConfig.consentData.getTCData;
-      consentData.gdprApplies = true;
-      consentData.apiVersion = 2;
-      gdprDataHandlerStub.returns(consentData);
-
-      deviceAccessHook(nextFnSpy, 1, 'pubCommonId', 'fpid-module');
-      expect(logWarnSpy.callCount).to.equal(0);
-    });
-
-    it('should not allow device access if enforce vendor, module is vendorless, but there is no consent for purpose 1', function () {
-      adapterManagerStub.withArgs('pubCommonId').returns(getBidderSpec(1));
-      setEnforcementConfig({
-        gdpr: {
-          rules: [{
-            purpose: 'storage',
-            enforcePurpose: true,
-            enforceVendor: true,
-          }]
-        }
-      });
-
-      let consentData = {}
-      // set consent for purpose 1 to false
-      const newConsentData = utils.deepClone(staticConfig);
-      newConsentData.consentData.getTCData.purpose.consents['1'] = false;
-      consentData.vendorData = newConsentData.consentData.getTCData;
-      consentData.apiVersion = 2;
-      consentData.gdprApplies = true;
-
-      gdprDataHandlerStub.returns(consentData);
-
-      deviceAccessHook(nextFnSpy, 1, 'pubCommonId', 'fpid-module');
-      expect(logWarnSpy.callCount).to.equal(1);
-    });
-
     it('should allow device access when gdprApplies is false and hasDeviceAccess flag is true', function () {
       adapterManagerStub.withArgs('appnexus').returns(getBidderSpec(1));
       setEnforcementConfig({
@@ -270,10 +223,10 @@ describe('gdpr enforcement', function () {
         hasEnforcementHook: true,
         valid: true
       }
-      sinon.assert.calledWith(nextFnSpy, 1, 'appnexus', undefined, result);
+      sinon.assert.calledWith(nextFnSpy, 1, 'appnexus', result);
     });
 
-    it('should use gvlMapping set by publisher', function () {
+    it('should use gvlMapping set by publisher', function() {
       config.setConfig({
         'gvlMapping': {
           'appnexus': 4
@@ -301,11 +254,11 @@ describe('gdpr enforcement', function () {
         hasEnforcementHook: true,
         valid: true
       }
-      sinon.assert.calledWith(nextFnSpy, 4, 'appnexus', undefined, result);
+      sinon.assert.calledWith(nextFnSpy, 4, 'appnexus', result);
       config.resetConfig();
     });
 
-    it('should use gvl id of alias and not of parent', function () {
+    it('should use gvl id of alias and not of parent', function() {
       let curBidderStub = sinon.stub(config, 'getCurrentBidder');
       curBidderStub.returns('appnexus-alias');
       adapterManager.aliasBidAdapter('appnexus', 'appnexus-alias');
@@ -336,7 +289,7 @@ describe('gdpr enforcement', function () {
         hasEnforcementHook: true,
         valid: true
       }
-      sinon.assert.calledWith(nextFnSpy, 4, 'appnexus', undefined, result);
+      sinon.assert.calledWith(nextFnSpy, 4, 'appnexus', result);
       config.resetConfig();
       curBidderStub.restore();
     });
@@ -517,7 +470,7 @@ describe('gdpr enforcement', function () {
       const args = nextFnSpy.getCalls()[0].args;
       expect(args[1].hasValidated).to.be.true;
       expect(nextFnSpy.calledOnce).to.equal(true);
-      sinon.assert.calledWith(nextFnSpy, submodules, {...consentData, hasValidated: true});
+      sinon.assert.calledWith(nextFnSpy, submodules, { ...consentData, hasValidated: true });
     });
 
     it('should allow userId module if gdpr not in scope', function () {
@@ -571,7 +524,7 @@ describe('gdpr enforcement', function () {
           name: 'sampleUserId'
         }
       }]
-      sinon.assert.calledWith(nextFnSpy, expectedSubmodules, {...consentData, hasValidated: true});
+      sinon.assert.calledWith(nextFnSpy, expectedSubmodules, { ...consentData, hasValidated: true });
     });
   });
 
@@ -630,17 +583,17 @@ describe('gdpr enforcement', function () {
       gdprDataHandlerStub.returns(consentData);
       adapterManagerStub.withArgs('bidder_1').returns({
         getSpec: function () {
-          return {'gvlid': 4}
+          return { 'gvlid': 4 }
         }
       });
       adapterManagerStub.withArgs('bidder_2').returns({
         getSpec: function () {
-          return {'gvlid': 5}
+          return { 'gvlid': 5 }
         }
       });
       adapterManagerStub.withArgs('bidder_3').returns({
         getSpec: function () {
-          return {'gvlid': undefined}
+          return { 'gvlid': undefined }
         }
       });
       makeBidRequestsHook(nextFnSpy, MOCK_AD_UNITS, []);
@@ -651,20 +604,20 @@ describe('gdpr enforcement', function () {
         code: 'ad-unit-1',
         mediaTypes: {},
         bids: [
-          sinon.match({bidder: 'bidder_1'}),
-          sinon.match({bidder: 'bidder_2'})
+          sinon.match({ bidder: 'bidder_1' }),
+          sinon.match({ bidder: 'bidder_2' })
         ]
       }, {
         code: 'ad-unit-2',
         mediaTypes: {},
         bids: [
-          sinon.match({bidder: 'bidder_2'}),
-          sinon.match({bidder: 'bidder_3'}) // should be allowed even though it's doesn't have a gvlId because liTransparency is established.
+          sinon.match({ bidder: 'bidder_2' }),
+          sinon.match({ bidder: 'bidder_3' }) // should be allowed even though it's doesn't have a gvlId because liTransparency is established.
         ]
       }], []);
     });
 
-    it('should block bidder which does not have consent and allow bidder which has consent (liTransparency is NOT established)', function () {
+    it('should block bidder which does not have consent and allow bidder which has consent (liTransparency is NOT established)', function() {
       setEnforcementConfig({
         gdpr: {
           rules: [{
@@ -688,17 +641,17 @@ describe('gdpr enforcement', function () {
       gdprDataHandlerStub.returns(consentData);
       adapterManagerStub.withArgs('bidder_1').returns({
         getSpec: function () {
-          return {'gvlid': 4}
+          return { 'gvlid': 4 }
         }
       });
       adapterManagerStub.withArgs('bidder_2').returns({
         getSpec: function () {
-          return {'gvlid': 5}
+          return { 'gvlid': 5 }
         }
       });
       adapterManagerStub.withArgs('bidder_3').returns({
         getSpec: function () {
-          return {'gvlid': undefined}
+          return { 'gvlid': undefined }
         }
       });
 
@@ -710,13 +663,13 @@ describe('gdpr enforcement', function () {
         code: 'ad-unit-1',
         mediaTypes: {},
         bids: [
-          sinon.match({bidder: 'bidder_1'}), // 'bidder_2' is not present because it doesn't have vendorConsent
+          sinon.match({ bidder: 'bidder_1' }), // 'bidder_2' is not present because it doesn't have vendorConsent
         ]
       }, {
         code: 'ad-unit-2',
         mediaTypes: {},
         bids: [
-          sinon.match({bidder: 'bidder_3'}), // 'bidder_3' is allowed despite gvlId being undefined because it's part of vendorExceptions
+          sinon.match({ bidder: 'bidder_3' }), // 'bidder_3' is allowed despite gvlId being undefined because it's part of vendorExceptions
         ]
       }], []);
 
@@ -774,12 +727,12 @@ describe('gdpr enforcement', function () {
       nextFnSpy = sandbox.spy();
     });
 
-    afterEach(function () {
+    afterEach(function() {
       config.resetConfig();
       sandbox.restore();
     });
 
-    it('should block analytics adapter which does not have consent and allow the one(s) which have consent', function () {
+    it('should block analytics adapter which does not have consent and allow the one(s) which have consent', function() {
       setEnforcementConfig({
         gdpr: {
           rules: [{
@@ -797,9 +750,9 @@ describe('gdpr enforcement', function () {
       consentData.gdprApplies = true;
 
       gdprDataHandlerStub.returns(consentData);
-      adapterManagerStub.withArgs('analyticsAdapter_A').returns({gvlid: 3});
-      adapterManagerStub.withArgs('analyticsAdapter_B').returns({gvlid: 5});
-      adapterManagerStub.withArgs('analyticsAdapter_C').returns({gvlid: 1});
+      adapterManagerStub.withArgs('analyticsAdapter_A').returns({ gvlid: 3 });
+      adapterManagerStub.withArgs('analyticsAdapter_B').returns({ gvlid: 5 });
+      adapterManagerStub.withArgs('analyticsAdapter_C').returns({ gvlid: 1 });
 
       enableAnalyticsHook(nextFnSpy, MOCK_ANALYTICS_ADAPTER_CONFIG);
 
@@ -1072,7 +1025,7 @@ describe('gdpr enforcement', function () {
       expect(purpose2Rule).to.deep.equal(purpose2RuleDefinedInConfig);
     });
 
-    it('should use the "rules" defined in config if a definition found', function () {
+    it('should use the "rules" defined in config if a definition found', function() {
       const rules = [{
         purpose: 'storage',
         enforcePurpose: false,
@@ -1082,23 +1035,23 @@ describe('gdpr enforcement', function () {
         enforcePurpose: false,
         enforceVendor: false
       }]
-      setEnforcementConfig({gdpr: {rules}});
+      setEnforcementConfig({gdpr: { rules }});
 
       expect(enforcementRules).to.deep.equal(rules);
     });
   });
 
-  describe('TCF2FinalResults', function () {
+  describe('TCF2FinalResults', function() {
     let sandbox;
-    beforeEach(function () {
+    beforeEach(function() {
       sandbox = sinon.createSandbox();
       sandbox.spy(events, 'emit');
     });
-    afterEach(function () {
+    afterEach(function() {
       config.resetConfig();
       sandbox.restore();
     });
-    it('should emit TCF2 enforcement data on auction end', function () {
+    it('should emit TCF2 enforcement data on auction end', function() {
       const rules = [{
         purpose: 'storage',
         enforcePurpose: false,
@@ -1108,7 +1061,7 @@ describe('gdpr enforcement', function () {
         enforcePurpose: false,
         enforceVendor: false
       }]
-      setEnforcementConfig({gdpr: {rules}});
+      setEnforcementConfig({gdpr: { rules }});
 
       events.emit('auctionEnd', {})
 
@@ -1117,28 +1070,28 @@ describe('gdpr enforcement', function () {
     })
   });
 
-  describe('getGvlid', function () {
+  describe('getGvlid', function() {
     let sandbox;
     let getGvlidForBidAdapterStub;
     let getGvlidForUserIdModuleStub;
     let getGvlidForAnalyticsAdapterStub;
-    beforeEach(function () {
+    beforeEach(function() {
       sandbox = sinon.createSandbox();
       getGvlidForBidAdapterStub = sandbox.stub(internal, 'getGvlidForBidAdapter');
       getGvlidForUserIdModuleStub = sandbox.stub(internal, 'getGvlidForUserIdModule');
       getGvlidForAnalyticsAdapterStub = sandbox.stub(internal, 'getGvlidForAnalyticsAdapter');
     });
-    afterEach(function () {
+    afterEach(function() {
       sandbox.restore();
       config.resetConfig();
     });
 
-    it('should return "null" if called without passing any argument', function () {
+    it('should return "null" if called without passing any argument', function() {
       const gvlid = getGvlid();
       expect(gvlid).to.equal(null);
     });
 
-    it('should return "null" if GVL ID is not defined for any of these modules: Bid adapter, UserId submodule and Analytics adapter', function () {
+    it('should return "null" if GVL ID is not defined for any of these modules: Bid adapter, UserId submodule and Analytics adapter', function() {
       getGvlidForBidAdapterStub.withArgs('moduleA').returns(null);
       getGvlidForUserIdModuleStub.withArgs('moduleA').returns(null);
       getGvlidForAnalyticsAdapterStub.withArgs('moduleA').returns(null);
@@ -1147,7 +1100,7 @@ describe('gdpr enforcement', function () {
       expect(gvlid).to.equal(null);
     });
 
-    it('should return the GVL ID from gvlMapping if it is defined in setConfig', function () {
+    it('should return the GVL ID from gvlMapping if it is defined in setConfig', function() {
       config.setConfig({
         gvlMapping: {
           moduleA: 1
@@ -1161,7 +1114,7 @@ describe('gdpr enforcement', function () {
       expect(gvlid).to.equal(1);
     });
 
-    it('should return the GVL ID by calling getGvlidForBidAdapter -> getGvlidForUserIdModule -> getGvlidForAnalyticsAdapter in sequence', function () {
+    it('should return the GVL ID by calling getGvlidForBidAdapter -> getGvlidForUserIdModule -> getGvlidForAnalyticsAdapter in sequence', function() {
       getGvlidForBidAdapterStub.withArgs('moduleA').returns(null);
       getGvlidForUserIdModuleStub.withArgs('moduleA').returns(null);
       getGvlidForAnalyticsAdapterStub.withArgs('moduleA').returns(7);

package/test/spec/modules/gridNMBidAdapter_spec.js

@@ -226,6 +226,38 @@ describe('TheMediaGridNM Adapter', function () {
       }
     ];
 
+    it('if content and segment is present in jwTargeting, payload must have right params', function () {
+      const jsContent = {id: 'test_jw_content_id'};
+      const jsSegments = ['test_seg_1', 'test_seg_2'];
+      const bidRequestsWithJwTargeting = bidRequests.map((bid) => {
+        return Object.assign({
+          rtd: {
+            jwplayer: {
+              targeting: {
+                segments: jsSegments,
+                content: jsContent
+              }
+            }
+          }
+        }, bid);
+      });
+      const requests = spec.buildRequests(bidRequestsWithJwTargeting, bidderRequest);
+      requests.forEach((req, i) => {
+        const payload = req.data;
+        expect(req).to.have.property('data');
+        expect(payload).to.have.property('user');
+        expect(payload.user.data).to.deep.equal([{
+          name: 'iow_labs_pub_data',
+          segment: [
+            {name: 'jwpseg', value: jsSegments[0]},
+            {name: 'jwpseg', value: jsSegments[1]}
+          ]
+        }]);
+        expect(payload).to.have.property('site');
+        expect(payload.site.content).to.deep.equal(jsContent);
+      });
+    });
+
     it('should attach valid params to the tag', function () {
       const requests = spec.buildRequests(bidRequests, bidderRequest);
       const requestsSizes = ['300x250,300x600', '728x90'];

package/test/spec/modules/hadronIdSystem_spec.js

@@ -22,7 +22,7 @@ describe('HadronIdSystem', function () {
       const callback = hadronIdSubmodule.getId(config).callback;
       callback(callbackSpy);
       const request = server.requests[0];
-      expect(request.url).to.eq(`https://id.hadron.ad.gt/api/v1/pbhid`);
+      expect(request.url).to.eq(`https://id.hadron.ad.gt/api/v1/pbhid?partner_id=0&_it=prebid`);
       request.respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ hadronId: 'testHadronId1' }));
       expect(callbackSpy.lastCall.lastArg).to.deep.equal({hadronId: 'testHadronId1'});
     });
@@ -49,7 +49,7 @@ describe('HadronIdSystem', function () {
       const callback = hadronIdSubmodule.getId(config).callback;
       callback(callbackSpy);
       const request = server.requests[0];
-      expect(request.url).to.eq('https://hadronid.publync.com');
+      expect(request.url).to.eq('https://hadronid.publync.com?partner_id=0&_it=prebid');
       request.respond(200, { 'Content-Type': 'application/json' }, JSON.stringify({ hadronId: 'testHadronId1' }));
       expect(callbackSpy.lastCall.lastArg).to.deep.equal({hadronId: 'testHadronId1'});
     });

package/test/spec/modules/idxIdSystem_spec.js

@@ -94,8 +94,8 @@ describe('IDx ID System', () => {
       adUnits = [getAdUnitMock()];
       init(config);
       setSubmoduleRegistry([idxIdSubmodule]);
-      config.setConfig(getConfigMock());
       getCookieStub.withArgs(IDX_COOKIE_NAME).returns(IDX_COOKIE_STORED);
+      config.setConfig(getConfigMock());
     });
 
     afterEach(() => {

package/test/spec/modules/imRtdProvider_spec.js

@@ -50,7 +50,6 @@ describe('imRtdProvider', function () {
 
   describe('getBidderFunction', function () {
     const assumedBidder = [
-      'ix',
       'pubmatic',
       'fluct'
     ];