prebid.js 7.35.0 → 7.36.0

package/modules/aidemBidAdapter.js

@@ -1,4 +1,4 @@
-import {_each, contains, deepAccess, deepSetValue, getDNT, isBoolean, isStr, logError, logInfo} from '../src/utils.js';
+import {_each, contains, deepAccess, deepSetValue, getDNT, isBoolean, isStr, isNumber, logError, logInfo} from '../src/utils.js';
 import {config} from '../src/config.js';
 import {BANNER, VIDEO} from '../src/mediaTypes.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
@@ -21,6 +21,8 @@ export const ERROR_CODES = {
   SITE_ID_INVALID_VALUE: 4,
   MEDIA_TYPE_NOT_SUPPORTED: 5,
   PUBLISHER_ID_INVALID_VALUE: 6,
+  INVALID_RATELIMIT: 7,
+  PLACEMENT_ID_INVALID_VALUE: 8,
 };
 
 const endpoints = {
@@ -30,29 +32,29 @@ const endpoints = {
     timeout: `${BASE_URL}/notice/timeout`,
     error: `${BASE_URL}/notice/error`,
   }
-}
+};
 
 export function setEndPoints(env = null, path = '', mediaType = BANNER) {
   switch (env) {
     case 'local':
-      endpoints.request = mediaType === BANNER ? `${LOCAL_BASE_URL}${path}/bid/request` : `${LOCAL_BASE_URL}${path}/bid/videorequest`
-      endpoints.notice.win = `${LOCAL_BASE_URL}${path}/notice/win`
-      endpoints.notice.error = `${LOCAL_BASE_URL}${path}/notice/error`
-      endpoints.notice.timeout = `${LOCAL_BASE_URL}${path}/notice/timeout`
+      endpoints.request = mediaType === BANNER ? `${LOCAL_BASE_URL}${path}/bid/request` : `${LOCAL_BASE_URL}${path}/bid/videorequest`;
+      endpoints.notice.win = `${LOCAL_BASE_URL}${path}/notice/win`;
+      endpoints.notice.error = `${LOCAL_BASE_URL}${path}/notice/error`;
+      endpoints.notice.timeout = `${LOCAL_BASE_URL}${path}/notice/timeout`;
       break;
     case 'main':
-      endpoints.request = mediaType === BANNER ? `${BASE_URL}${path}/bid/request` : `${BASE_URL}${path}/bid/videorequest`
-      endpoints.notice.win = `${BASE_URL}${path}/notice/win`
-      endpoints.notice.error = `${BASE_URL}${path}/notice/error`
-      endpoints.notice.timeout = `${BASE_URL}${path}/notice/timeout`
+      endpoints.request = mediaType === BANNER ? `${BASE_URL}${path}/bid/request` : `${BASE_URL}${path}/bid/videorequest`;
+      endpoints.notice.win = `${BASE_URL}${path}/notice/win`;
+      endpoints.notice.error = `${BASE_URL}${path}/notice/error`;
+      endpoints.notice.timeout = `${BASE_URL}${path}/notice/timeout`;
       break;
   }
-  return endpoints
+  return endpoints;
 }
 
 config.getConfig('aidem', function (config) {
-  if (config.aidem.env) { setEndPoints(config.aidem.env, config.aidem.path, config.aidem.mediaType) }
-})
+  if (config.aidem.env) { setEndPoints(config.aidem.env, config.aidem.path, config.aidem.mediaType); }
+});
 
 // AIDEM Custom FN
 function recur(obj) {
@@ -121,8 +123,8 @@ function getDevice() {
 
 function getRegs() {
   let regs = {};
-  const consentManagement = config.getConfig('consentManagement')
-  const coppa = config.getConfig('coppa')
+  const consentManagement = config.getConfig('consentManagement');
+  const coppa = config.getConfig('coppa');
   if (consentManagement && !!(consentManagement.gdpr)) {
     deepSetValue(regs, 'gdpr_applies', !!consentManagement.gdpr);
   } else {
@@ -145,11 +147,15 @@ function getRegs() {
 }
 
 function getPageUrl(bidderRequest) {
-  return bidderRequest?.refererInfo?.page
+  return bidderRequest?.refererInfo?.page;
 }
 
 function buildWinNotice(bid) {
+  const params = bid.params[0];
   return {
+    publisherId: params.publisherId,
+    siteId: params.siteId,
+    placementId: params.placementId,
     burl: deepAccess(bid, 'meta.burl'),
     cpm: bid.cpm,
     currency: bid.currency,
@@ -161,7 +167,7 @@ function buildWinNotice(bid) {
     ttl: bid.ttl,
     requestTimestamp: bid.requestTimestamp,
     responseTimestamp: bid.responseTimestamp,
-  }
+  };
 }
 
 function buildErrorNotice(prebidErrorResponse) {
@@ -171,29 +177,29 @@ function buildErrorNotice(prebidErrorResponse) {
     auctionId: prebidErrorResponse.auctionId,
     bidderRequestId: prebidErrorResponse.bidderRequestId,
     metrics: {}
-  }
+  };
 }
 
 function hasValidFloor(obj) {
-  if (!obj) return false
-  const hasValue = !isNaN(Number(obj.value))
-  const hasCurrency = contains(AVAILABLE_CURRENCIES, obj.currency)
-  return hasValue && hasCurrency
+  if (!obj) return false;
+  const hasValue = !isNaN(Number(obj.value));
+  const hasCurrency = contains(AVAILABLE_CURRENCIES, obj.currency);
+  return hasValue && hasCurrency;
 }
 
 function getMediaType(bidRequest) {
-  if ((bidRequest.mediaTypes && bidRequest.mediaTypes.hasOwnProperty('video')) || bidRequest.params.hasOwnProperty('video')) { return VIDEO }
-  return BANNER
+  if ((bidRequest.mediaTypes && bidRequest.mediaTypes.hasOwnProperty('video')) || bidRequest.params.hasOwnProperty('video')) { return VIDEO; }
+  return BANNER;
 }
 
 function getPrebidRequestFields(bidderRequest, bidRequests) {
-  const payload = {}
+  const payload = {};
   // Base Payload Data
   deepSetValue(payload, 'id', bidderRequest.auctionId);
   // Impressions
-  setPrebidImpressionObject(bidRequests, payload)
+  setPrebidImpressionObject(bidRequests, payload);
   // Device
-  deepSetValue(payload, 'device', getDevice())
+  deepSetValue(payload, 'device', getDevice());
   // Timeout
   deepSetValue(payload, 'tmax', bidderRequest.timeout);
   // Currency
@@ -203,13 +209,13 @@ function getPrebidRequestFields(bidderRequest, bidRequests) {
   // Privacy Regs
   deepSetValue(payload, 'regs', getRegs());
   // Site
-  setPrebidSiteObject(bidderRequest, payload)
+  setPrebidSiteObject(bidderRequest, payload);
   // Environment
-  setPrebidRequestEnvironment(payload)
+  setPrebidRequestEnvironment(payload);
   // AT auction type
   deepSetValue(payload, 'at', 1);
 
-  return payload
+  return payload;
 }
 
 function setPrebidImpressionObject(bidRequests, payload) {
@@ -220,24 +226,24 @@ function setPrebidImpressionObject(bidRequests, payload) {
     deepSetValue(impressionObject, 'id', bidRequest.bidId);
     // Transaction id
     deepSetValue(impressionObject, 'tid', deepAccess(bidRequest, 'transactionId'));
-    // Placement id
+    // placement id
     deepSetValue(impressionObject, 'tagid', deepAccess(bidRequest, 'params.placementId', null));
     // Publisher id
     deepSetValue(payload, 'site.publisher.id', deepAccess(bidRequest, 'params.publisherId'));
     // Site id
     deepSetValue(payload, 'site.id', deepAccess(bidRequest, 'params.siteId'));
-    const mediaType = getMediaType(bidRequest)
+    const mediaType = getMediaType(bidRequest);
     switch (mediaType) {
       case 'banner':
-        setPrebidImpressionObjectBanner(bidRequest, impressionObject)
+        setPrebidImpressionObjectBanner(bidRequest, impressionObject);
         break;
       case 'video':
-        setPrebidImpressionObjectVideo(bidRequest, impressionObject)
+        setPrebidImpressionObjectVideo(bidRequest, impressionObject);
         break;
     }
 
     // Floor (optional)
-    setPrebidImpressionObjectFloor(bidRequest, impressionObject)
+    setPrebidImpressionObjectFloor(bidRequest, impressionObject);
 
     impressionObject.imp_ext = {};
 
@@ -272,10 +278,10 @@ function setPrebidRequestEnvironment(payload) {
 }
 
 function setPrebidImpressionObjectFloor(bidRequest, impressionObject) {
-  const floor = deepAccess(bidRequest, 'params.floor')
+  const floor = deepAccess(bidRequest, 'params.floor');
   if (hasValidFloor(floor)) {
-    deepSetValue(impressionObject, 'floor.value', floor.value)
-    deepSetValue(impressionObject, 'floor.currency', floor.currency)
+    deepSetValue(impressionObject, 'floor.value', floor.value);
+    deepSetValue(impressionObject, 'floor.currency', floor.currency);
   }
 }
 
@@ -322,7 +328,7 @@ function getPrebidResponseBidObject(openRTBResponseBidObject) {
   deepSetValue(prebidResponseBidObject, 'currency', openRTBResponseBidObject.cur ? openRTBResponseBidObject.cur.toUpperCase() : DEFAULT_CURRENCY);
   deepSetValue(prebidResponseBidObject, 'width', openRTBResponseBidObject.w);
   deepSetValue(prebidResponseBidObject, 'height', openRTBResponseBidObject.h);
-  deepSetValue(prebidResponseBidObject, 'dealId', openRTBResponseBidObject.dealid)
+  deepSetValue(prebidResponseBidObject, 'dealId', openRTBResponseBidObject.dealid);
   deepSetValue(prebidResponseBidObject, 'netRevenue', true);
   deepSetValue(prebidResponseBidObject, 'ttl', 60000);
 
@@ -335,13 +341,13 @@ function getPrebidResponseBidObject(openRTBResponseBidObject) {
     deepSetValue(prebidResponseBidObject, 'mediaType', BANNER);
     deepSetValue(prebidResponseBidObject, 'ad', openRTBResponseBidObject.adm);
   }
-  setPrebidResponseBidObjectMeta(prebidResponseBidObject, openRTBResponseBidObject)
-  return prebidResponseBidObject
+  setPrebidResponseBidObjectMeta(prebidResponseBidObject, openRTBResponseBidObject);
+  return prebidResponseBidObject;
 }
 
 function setPrebidResponseBidObjectMeta(prebidResponseBidObject, openRTBResponseBidObject) {
   logInfo('AIDEM Bid Adapter meta', openRTBResponseBidObject);
-  deepSetValue(prebidResponseBidObject, 'meta.advertiserDomains', openRTBResponseBidObject.adomain);
+  deepSetValue(prebidResponseBidObject, 'meta.advertiserDomains', deepAccess(openRTBResponseBidObject, 'meta.advertiserDomains'));
   if (openRTBResponseBidObject.cat && Array.isArray(openRTBResponseBidObject.cat)) {
     const primaryCatId = openRTBResponseBidObject.cat.shift();
     deepSetValue(prebidResponseBidObject, 'meta.primaryCatId', primaryCatId);
@@ -357,28 +363,28 @@ function setPrebidResponseBidObjectMeta(prebidResponseBidObject, openRTBResponse
 }
 
 function hasValidMediaType(bidRequest) {
-  const supported = hasBannerMediaType(bidRequest) || hasVideoMediaType(bidRequest)
+  const supported = hasBannerMediaType(bidRequest) || hasVideoMediaType(bidRequest);
   if (!supported) {
     logError('AIDEM Bid Adapter: media type not supported', { bidder: BIDDER_CODE, code: ERROR_CODES.MEDIA_TYPE_NOT_SUPPORTED });
   }
-  return supported
+  return supported;
 }
 
 function hasBannerMediaType(bidRequest) {
-  return !!deepAccess(bidRequest, 'mediaTypes.banner')
+  return !!deepAccess(bidRequest, 'mediaTypes.banner');
 }
 
 function hasVideoMediaType(bidRequest) {
-  return !!deepAccess(bidRequest, 'mediaTypes.video')
+  return !!deepAccess(bidRequest, 'mediaTypes.video');
 }
 
 function hasValidBannerMediaType(bidRequest) {
-  const sizes = deepAccess(bidRequest, 'mediaTypes.banner.sizes')
+  const sizes = deepAccess(bidRequest, 'mediaTypes.banner.sizes');
   if (!sizes) {
     logError('AIDEM Bid Adapter: media type sizes missing', { bidder: BIDDER_CODE, code: ERROR_CODES.PROPERTY_NOT_INCLUDED });
     return false;
   }
-  return true
+  return true;
 }
 
 function hasValidVideoMediaType(bidRequest) {
@@ -387,23 +393,38 @@ function hasValidVideoMediaType(bidRequest) {
     logError('AIDEM Bid Adapter: media type playerSize missing', { bidder: BIDDER_CODE, code: ERROR_CODES.PROPERTY_NOT_INCLUDED });
     return false;
   }
-  return true
+  return true;
 }
 
 function hasValidVideoParameters(bidRequest) {
-  let valid = true
+  let valid = true;
   const adUnitsParameters = deepAccess(bidRequest, 'mediaTypes.video');
   const bidderParameter = deepAccess(bidRequest, 'params.video');
   for (let property of REQUIRED_VIDEO_PARAMS) {
-    const hasAdUnitParameter = adUnitsParameters.hasOwnProperty(property)
-    const hasBidderParameter = bidderParameter && bidderParameter.hasOwnProperty(property)
+    const hasAdUnitParameter = adUnitsParameters.hasOwnProperty(property);
+    const hasBidderParameter = bidderParameter && bidderParameter.hasOwnProperty(property);
     if (!hasAdUnitParameter && !hasBidderParameter) {
       logError(`AIDEM Bid Adapter: ${property} is not included in either the adunit or params level`, { bidder: BIDDER_CODE, code: ERROR_CODES.PROPERTY_NOT_INCLUDED });
-      valid = false
+      valid = false;
     }
   }
 
-  return valid
+  return valid;
+}
+
+function passesRateLimit(bidRequest) {
+  const rateLimit = deepAccess(bidRequest, 'params.rateLimit', 1);
+  if (!isNumber(rateLimit) || rateLimit > 1 || rateLimit < 0) {
+    logError('AIDEM Bid Adapter: invalid rateLimit (must be a number between 0 and 1)', { bidder: BIDDER_CODE, code: ERROR_CODES.INVALID_RATELIMIT });
+    return false;
+  }
+  if (rateLimit !== 1) {
+    const randomRateValue = Math.random();
+    if (randomRateValue > rateLimit) {
+      return false;
+    }
+  }
+  return true;
 }
 
 function hasValidParameters(bidRequest) {
@@ -421,7 +442,7 @@ function hasValidParameters(bidRequest) {
     return false;
   }
 
-  return true
+  return true;
 }
 
 export const spec = {
@@ -431,28 +452,32 @@ export const spec = {
     logInfo('bid: ', bidRequest);
 
     // check if request has valid mediaTypes
-    if (!hasValidMediaType(bidRequest)) return false
+    if (!hasValidMediaType(bidRequest)) return false;
 
     // check if request has valid media type parameters at adUnit level
     if (hasBannerMediaType(bidRequest) && !hasValidBannerMediaType(bidRequest)) {
-      return false
+      return false;
     }
 
     if (hasVideoMediaType(bidRequest) && !hasValidVideoMediaType(bidRequest)) {
-      return false
+      return false;
     }
 
     if (hasVideoMediaType(bidRequest) && !hasValidVideoParameters(bidRequest)) {
-      return false
+      return false;
     }
 
-    return hasValidParameters(bidRequest)
+    if (!hasValidParameters(bidRequest)) {
+      return false;
+    }
+
+    return passesRateLimit(bidRequest);
   },
 
   buildRequests: function(validBidRequests, bidderRequest) {
     logInfo('validBidRequests: ', validBidRequests);
     logInfo('bidderRequest: ', bidderRequest);
-    const prebidRequest = getPrebidRequestFields(bidderRequest, validBidRequests)
+    const prebidRequest = getPrebidRequestFields(bidderRequest, validBidRequests);
     const payloadString = JSON.stringify(prebidRequest);
 
     return {
@@ -474,7 +499,7 @@ export const spec = {
         return;
       }
       logInfo('CPM OK');
-      const bid = getPrebidResponseBidObject(bidObject)
+      const bid = getPrebidResponseBidObject(bidObject);
       bids.push(bid);
     });
     return bids;
@@ -483,14 +508,14 @@ export const spec = {
   onBidWon: function(bid) {
     // Bidder specific code
     logInfo('onBidWon bid: ', bid);
-    const notice = buildWinNotice(bid)
+    const notice = buildWinNotice(bid);
     ajax(endpoints.notice.win, null, JSON.stringify(notice), { method: 'POST', withCredentials: true });
   },
 
   onBidderError: function({ bidderRequest }) {
     // Bidder specific code
-    const notice = buildErrorNotice(bidderRequest)
+    const notice = buildErrorNotice(bidderRequest);
     ajax(endpoints.notice.error, null, JSON.stringify(notice), { method: 'POST', withCredentials: true });
   },
-}
+};
 registerBidder(spec);

package/modules/aidemBidAdapter.md

@@ -14,11 +14,12 @@ This module is GDPR and CCPA compliant, and no 3rd party userIds are allowed.
 
 
 ## Global Bid Params
-| Name          | Scope    | Description         | Example       | Type     |
-|---------------|----------|---------------------|---------------|----------|
-| `siteId`      | required | Unique site ID      | `'ABCDEF'`    | `String` |
-| `publisherId` | required | Unique publisher ID | `'ABCDEF'`    | `String` |
-| `placementId` | optional | Unique publisher tag ID | `'ABCDEF'`    | `String` |
+| Name          | Scope    | Description             | Example    | Type     |
+|---------------|----------|-------------------------|------------|----------|
+| `siteId`      | required | Unique site ID          | `'ABCDEF'` | `String` |
+| `publisherId` | required | Unique publisher ID     | `'ABCDEF'` | `String` |
+| `placementId` | optional | Unique publisher tag ID | `'ABCDEF'` | `String` |
+| `rateLimit`   | optional | Limit the volume sent to AIDEM. Must be between 0 and 1 | `0.6`      | `Number`   |
 
 
 ### Banner Bid Params
@@ -67,7 +68,8 @@ var adUnits = [{
     bids: [{
           bidder: 'aidem',
           params: {
-            siteId: 'prebid-test-site',
+            siteId: 'prebid-test-siteId',
+            publisherId: 'prebid-test-publisherId',
           },
     }]
 }];
@@ -90,7 +92,8 @@ var adUnits = [{
     bids: [{
           bidder: 'aidem',
           params: {
-            siteId: 'prebid-test-site',
+            siteId: 'prebid-test-siteId',
+            publisherId: 'prebid-test-publisherId',
           },
     }]
 }];

package/modules/ajaBidAdapter.js

@@ -1,4 +1,4 @@
-import { getBidIdParameter, tryAppendQueryString, createTrackPixelHtml, logError, logWarn } from '../src/utils.js';
+import { getBidIdParameter, tryAppendQueryString, createTrackPixelHtml, logError, logWarn, deepAccess } from '../src/utils.js';
 import { Renderer } from '../src/Renderer.js';
 import { registerBidder } from '../src/adapters/bidderFactory.js';
 import { VIDEO, BANNER, NATIVE } from '../src/mediaTypes.js';
@@ -64,6 +64,11 @@ export const spec = {
         }))
       }
 
+      const sua = deepAccess(bidRequest, 'ortb2.device.sua');
+      if (sua) {
+        queryString = tryAppendQueryString(queryString, 'sua', JSON.stringify(sua));
+      }
+
       bidRequests.push({
         method: 'GET',
         url: URL,

package/modules/amxIdSystem.md

@@ -1,6 +1,6 @@
-# AMX RTB ID
+# AMX ID
 
-For help adding this module, please contact [prebid@amxrtb.com](prebid@amxrtb.com).
+For help adding this module, please contact [info@amxdt.net](info@amxdt.net).
 
 ### Prebid Configuration
 
@@ -41,11 +41,3 @@ The following settings are available for the `storage` property in the `userSync
 | name                  | Required | String       | Where the ID will be stored                                                      | `"amxId"` |
 | type                  | Required | String       | This must be `"html5"`                                                           | `"html5"` |
 | expires               | Required | Number <= 30 | number of days until the stored ID expires. **Must be less than or equal to 30** | `14`      |
-
-### Params
-
-The following options are available in the `params` property in `userSync.userIds[]`:
-
-| Param under `params` | Scope    | Type   | Description                                                               | Example          |
-| -------------------- | -------- | ------ | ------------------------------------------------------------------------- | ---------------- |
-| tagId                | Optional | String | Your AMX tagId (optional)                                                 | `cHJlYmlkLm9yZw` |

package/modules/aolBidAdapter.js

@@ -35,7 +35,7 @@ const SUPPORTED_USER_ID_SOURCES = [
   'adserver.org',
   'adtelligent.com',
   'akamai.com',
-  'amxrtb.com',
+  'amxdt.net',
   'audigent.com',
   'britepool.com',
   'criteo.com',

package/modules/appnexusBidAdapter.js

@@ -44,7 +44,7 @@ const URL_SIMPLE = 'https://ib.adnxs-simple.com/ut/v3/prebid';
 const VIDEO_TARGETING = ['id', 'minduration', 'maxduration',
   'skippable', 'playback_method', 'frameworks', 'context', 'skipoffset'];
 const VIDEO_RTB_TARGETING = ['minduration', 'maxduration', 'skip', 'skipafter', 'playbackmethod', 'api', 'startdelay'];
-const USER_PARAMS = ['age', 'externalUid', 'segments', 'gender', 'dnt', 'language'];
+const USER_PARAMS = ['age', 'externalUid', 'external_uid', 'segments', 'gender', 'dnt', 'language'];
 const APP_DEVICE_PARAMS = ['geo', 'device_id']; // appid is collected separately
 const DEBUG_PARAMS = ['enabled', 'dongle', 'member_id', 'debug_timeout'];
 const DEBUG_QUERY_PARAM_MAP = {
@@ -120,7 +120,9 @@ export const spec = {
    * @return boolean True if this is a valid bid, and false otherwise.
    */
   isBidRequestValid: function (bid) {
-    return !!(bid.params.placementId || (bid.params.member && bid.params.invCode));
+    return !!(
+      (bid.params.placementId || bid.params.placement_id) ||
+      (bid.params.member && (bid.params.invCode || bid.params.inv_code)));
   },
 
   /**
@@ -343,20 +345,18 @@ export const spec = {
 
     if (bidRequests[0].userId) {
       let eids = [];
-
-      addUserId(eids, deepAccess(bidRequests[0], `userId.criteoId`), 'criteo.com', null);
-      addUserId(eids, deepAccess(bidRequests[0], `userId.netId`), 'netid.de', null);
-      addUserId(eids, deepAccess(bidRequests[0], `userId.idl_env`), 'liveramp.com', null);
-      addUserId(eids, deepAccess(bidRequests[0], `userId.tdid`), 'adserver.org', 'TDID');
-      addUserId(eids, deepAccess(bidRequests[0], `userId.uid2.id`), 'uidapi.com', 'UID2');
-      if (bidRequests[0].userId.pubProvidedId) {
-        bidRequests[0].userId.pubProvidedId.forEach(ppId => {
-          ppId.uids.forEach(uid => {
-            eids.push({ source: ppId.source, id: uid.id });
-          });
+      bidRequests[0].userIdAsEids.forEach(eid => {
+        if (!eid || !eid.uids || eid.uids.length < 1) { return; }
+        eid.uids.forEach(uid => {
+          let tmp = {'source': eid.source, 'id': uid.id};
+          if (eid.source == 'adserver.org') {
+            tmp.rti_partner = 'TDID';
+          } else if (eid.source == 'uidapi.com') {
+            tmp.rti_partner = 'UID2';
+          }
+          eids.push(tmp);
         });
-      }
-
+      });
       if (eids.length) {
         payload.eids = eids;
       }
@@ -484,9 +484,6 @@ export const spec = {
     }, params);
 
     if (isOpenRtb) {
-      params.use_pmt_rule = (typeof params.usePaymentRule === 'boolean') ? params.usePaymentRule : false;
-      if (params.usePaymentRule) { delete params.usePaymentRule; }
-
       if (isPopulatedArray(params.keywords)) {
         params.keywords.forEach(deleteValues);
       }
@@ -498,6 +495,9 @@ export const spec = {
           delete params[paramKey];
         }
       });
+
+      params.use_pmt_rule = (typeof params.use_payment_rule === 'boolean') ? params.use_payment_rule : false;
+      if (params.use_payment_rule) { delete params.use_payment_rule; }
     }
 
     return params;
@@ -771,17 +771,25 @@ function newBid(serverBid, rtbBid, bidderRequest) {
 
 function bidToTag(bid) {
   const tag = {};
+  Object.keys(bid.params).forEach(paramKey => {
+    let convertedKey = convertCamelToUnderscore(paramKey);
+    if (convertedKey !== paramKey) {
+      bid.params[convertedKey] = bid.params[paramKey];
+      delete bid.params[paramKey];
+    }
+  });
   tag.sizes = transformSizes(bid.sizes);
   tag.primary_size = tag.sizes[0];
   tag.ad_types = [];
   tag.uuid = bid.bidId;
-  if (bid.params.placementId) {
-    tag.id = parseInt(bid.params.placementId, 10);
+  if (bid.params.placement_id) {
+    tag.id = parseInt(bid.params.placement_id, 10);
   } else {
-    tag.code = bid.params.invCode;
+    tag.code = bid.params.inv_code;
   }
-  tag.allow_smaller_sizes = bid.params.allowSmallerSizes || false;
-  tag.use_pmt_rule = bid.params.usePaymentRule || false;
+  tag.allow_smaller_sizes = bid.params.allow_smaller_sizes || false;
+  tag.use_pmt_rule = (typeof bid.params.use_payment_rule === 'boolean') ? bid.params.use_payment_rule
+    : (typeof bid.params.use_pmt_rule === 'boolean') ? bid.params.use_pmt_rule : false;
   tag.prebid = true;
   tag.disable_psa = true;
   let bidFloor = getBidFloor(bid);
@@ -798,26 +806,26 @@ function bidToTag(bid) {
       tag.position = (mediaTypePos === 3) ? 2 : mediaTypePos;
     }
   }
-  if (bid.params.trafficSourceCode) {
-    tag.traffic_source_code = bid.params.trafficSourceCode;
+  if (bid.params.traffic_source_code) {
+    tag.traffic_source_code = bid.params.traffic_source_code;
   }
-  if (bid.params.privateSizes) {
-    tag.private_sizes = transformSizes(bid.params.privateSizes);
+  if (bid.params.private_sizes) {
+    tag.private_sizes = transformSizes(bid.params.private_sizes);
   }
-  if (bid.params.supplyType) {
-    tag.supply_type = bid.params.supplyType;
+  if (bid.params.supply_type) {
+    tag.supply_type = bid.params.supply_type;
   }
-  if (bid.params.pubClick) {
-    tag.pubclick = bid.params.pubClick;
+  if (bid.params.pub_click) {
+    tag.pubclick = bid.params.pub_click;
   }
-  if (bid.params.extInvCode) {
-    tag.ext_inv_code = bid.params.extInvCode;
+  if (bid.params.ext_inv_code) {
+    tag.ext_inv_code = bid.params.ext_inv_code;
   }
-  if (bid.params.publisherId) {
-    tag.publisher_id = parseInt(bid.params.publisherId, 10);
+  if (bid.params.publisher_id) {
+    tag.publisher_id = parseInt(bid.params.publisher_id, 10);
   }
-  if (bid.params.externalImpId) {
-    tag.external_imp_id = bid.params.externalImpId;
+  if (bid.params.external_imp_id) {
+    tag.external_imp_id = bid.params.external_imp_id;
   }
 
   let ortb2ImpKwStr = deepAccess(bid, 'ortb2Imp.ext.data.keywords');
@@ -1218,17 +1226,6 @@ function parseMediaType(rtbBid) {
   }
 }
 
-function addUserId(eids, id, source, rti) {
-  if (id) {
-    if (rti) {
-      eids.push({ source, id, rti_partner: rti });
-    } else {
-      eids.push({ source, id });
-    }
-  }
-  return eids;
-}
-
 function getBidFloor(bid) {
   if (!isFn(bid.getFloor)) {
     return (bid.params.reserve) ? bid.params.reserve : null;

package/modules/brightcomBidAdapter.js

@@ -9,6 +9,7 @@ const URL = 'https://brightcombid.marphezis.com/hb';
 export const spec = {
   code: BIDDER_CODE,
   supportedMediaTypes: [BANNER],
+  gvlid: 883,
   isBidRequestValid,
   buildRequests,
   interpretResponse,