prebid.js 7.34.0 → 7.35.0

package/test/spec/modules/nexx360BidAdapter_spec.js

@@ -372,7 +372,6 @@ describe('Nexx360 bid adapter tests', function () {
         }
       };
       const output = spec.interpretResponse(response);
-      expect(output[0].bidderCode).to.be.eql('nexx360');
       expect(output[0].adUrl).to.be.eql(response.body.seatbid[0].bid[0].adUrl);
       expect(output[0].mediaType).to.be.eql(response.body.seatbid[0].bid[0].type);
       expect(output[0].currency).to.be.eql(response.body.cur);
@@ -411,7 +410,6 @@ describe('Nexx360 bid adapter tests', function () {
         }
       };
       const output = spec.interpretResponse(response);
-      expect(output[0].bidderCode).to.be.eql('nexx360');
       expect(output[0].vastXml).to.be.eql(response.body.seatbid[0].bid[0].vastXml);
       expect(output[0].mediaType).to.be.eql('video');
       expect(output[0].currency).to.be.eql(response.body.cur);
@@ -454,7 +452,6 @@ describe('Nexx360 bid adapter tests', function () {
         }
       };
       const output = spec.interpretResponse(response);
-      expect(output[0].bidderCode).to.be.eql('nexx360');
       expect(output[0].adUrl).to.be.eql(response.body.seatbid[0].bid[0].adUrl);
       expect(output[0].mediaType).to.be.eql(response.body.seatbid[0].bid[0].type);
       expect(output[0].currency).to.be.eql(response.body.cur);
@@ -490,7 +487,6 @@ describe('Nexx360 bid adapter tests', function () {
         }
       };
       const output = spec.interpretResponse(response);
-      expect(output[0].bidderCode).to.be.eql('nexx360');
       expect(output[0].vastXml).to.be.eql(response.body.seatbid[0].bid[0].vastXml);
       expect(output[0].mediaType).to.be.eql('video');
       expect(output[0].currency).to.be.eql(response.body.cur);

package/test/spec/modules/onetagBidAdapter_spec.js

@@ -266,6 +266,27 @@ describe('onetag', function () {
       expect(payload.gdprConsent.consentString).to.exist.and.to.equal(consentString);
       expect(payload.gdprConsent.consentRequired).to.exist.and.to.be.true;
     });
+    it('Should send GPP consent data', function () {
+      let consentString = 'consentString';
+      let applicableSections = [1, 2, 3];
+      let bidderRequest = {
+        'bidderCode': 'onetag',
+        'auctionId': '1d1a030790a475',
+        'bidderRequestId': '22edbae2733bf6',
+        'timeout': 3000,
+        'gppConsent': {
+          gppString: consentString,
+          applicableSections: applicableSections
+        }
+      };
+      let serverRequest = spec.buildRequests([bannerBid], bidderRequest);
+      const payload = JSON.parse(serverRequest.data);
+
+      expect(payload).to.exist;
+      expect(payload.gppConsent).to.exist;
+      expect(payload.gppConsent.consentString).to.exist.and.to.equal(consentString);
+      expect(payload.gppConsent.applicableSections).to.have.same.members(applicableSections);
+    });
     it('Should send us privacy string', function () {
       let consentString = 'us_foo';
       let bidderRequest = {
@@ -375,6 +396,28 @@ describe('onetag', function () {
       expect(syncs[0].url).to.include(sync_endpoint);
       expect(syncs[0].url).to.not.match(/(?:[?&](?:gdpr_consent=([^&]*)|gdpr=([^&]*)))+$/);
     });
+    it('Must pass gpp consent string when gppConsent object is available', function () {
+      const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, {}, {}, {
+        gppString: 'foo'
+      });
+      expect(syncs[0].type).to.equal('iframe');
+      expect(syncs[0].url).to.include(sync_endpoint);
+      expect(syncs[0].url).to.match(/(?:[?&](?:gpp_consent=foo([^&]*)))+$/);
+    });
+    it('Must pass no gpp params when consentString is null', function () {
+      const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, {}, {}, {
+        gppString: null
+      });
+      expect(syncs[0].type).to.equal('iframe');
+      expect(syncs[0].url).to.include(sync_endpoint);
+      expect(syncs[0].url).to.not.match(/(?:[?&](?:gpp_consent=([^&]*)))+$/);
+    });
+    it('Must pass no gpp params when consentString is empty', function () {
+      const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, {}, {}, {});
+      expect(syncs[0].type).to.equal('iframe');
+      expect(syncs[0].url).to.include(sync_endpoint);
+      expect(syncs[0].url).to.not.match(/(?:[?&](?:gpp_consent=([^&]*)))+$/);
+    });
     it('Should send us privacy string', function () {
       let usConsentString = 'us_foo';
       const syncs = spec.getUserSyncs({ iframeEnabled: true }, {}, {}, usConsentString);

package/test/spec/modules/outbrainBidAdapter_spec.js

@@ -1,7 +1,7 @@
-import {expect} from 'chai';
-import {spec} from 'modules/outbrainBidAdapter.js';
-import {config} from 'src/config.js';
-import {server} from 'test/mocks/xhr';
+import { expect } from 'chai';
+import { spec } from 'modules/outbrainBidAdapter.js';
+import { config } from 'src/config.js';
+import { server } from 'test/mocks/xhr';
 import { createEidsArray } from 'modules/userId/eids.js';
 
 describe('Outbrain Adapter', function () {
@@ -45,6 +45,26 @@ describe('Outbrain Adapter', function () {
       ]
     }
 
+    const videoBidRequestParams = {
+      mediaTypes: {
+        video: {
+          playerSize: [[640, 480]],
+          mimes: ['video/mp4'],
+          protocols: [1, 2, 3, 4, 5, 6, 7, 8],
+          playbackmethod: [1],
+          skip: 1,
+          api: [2],
+          minbitrate: 1000,
+          maxbitrate: 3000,
+          minduration: 3,
+          maxduration: 10,
+          startdelay: 2,
+          placement: 4,
+          linearity: 1
+        }
+      }
+    }
+
     describe('isBidRequestValid', function () {
       before(() => {
         config.setConfig({
@@ -93,6 +113,34 @@ describe('Outbrain Adapter', function () {
         }
         expect(spec.isBidRequestValid(bid)).to.equal(true)
       })
+      it('should succeed when bid contains video', function () {
+        const bid = {
+          bidder: 'outbrain',
+          params: {
+            publisher: {
+              id: 'publisher-id',
+            }
+          },
+          ...videoBidRequestParams,
+        }
+        expect(spec.isBidRequestValid(bid)).to.equal(true)
+      })
+      it('should fail when bid contains insufficient video information', function () {
+        const bid = {
+          bidder: 'outbrain',
+          params: {
+            publisher: {
+              id: 'publisher-id',
+            }
+          },
+          mediaTypes: {
+            video: {
+              context: 'outstream'
+            }
+          },
+        }
+        expect(spec.isBidRequestValid(bid)).to.equal(false)
+      })
       it('should fail if publisher id is not set', function () {
         const bid = {
           bidder: 'outbrain',
@@ -298,6 +346,61 @@ describe('Outbrain Adapter', function () {
         expect(res.data).to.deep.equal(JSON.stringify(expectedData))
       })
 
+      it('should build video request', function () {
+        const bidRequest = {
+          ...commonBidRequest,
+          ...videoBidRequestParams,
+        }
+        const expectedData = {
+          site: {
+            page: 'https://example.com/',
+            publisher: {
+              id: 'publisher-id'
+            }
+          },
+          device: {
+            ua: navigator.userAgent
+          },
+          source: {
+            fd: 1
+          },
+          cur: [
+            'USD'
+          ],
+          imp: [
+            {
+              id: '1',
+              video: {
+                w: 640,
+                h: 480,
+                protocols: [1, 2, 3, 4, 5, 6, 7, 8],
+                playbackmethod: [1],
+                mimes: ['video/mp4'],
+                skip: 1,
+                api: [2],
+                minbitrate: 1000,
+                maxbitrate: 3000,
+                minduration: 3,
+                maxduration: 10,
+                startdelay: 2,
+                placement: 4,
+                linearity: 1
+              }
+            }
+          ],
+          ext: {
+            prebid: {
+              channel: {
+                name: 'pbjs', version: '$prebid.version$'
+              }
+            }
+          }
+        }
+        const res = spec.buildRequests([bidRequest], commonBidderRequest)
+        expect(res.url).to.equal('https://bidder-url.com')
+        expect(res.data).to.deep.equal(JSON.stringify(expectedData))
+      })
+
       it('should pass optional parameters in request', function () {
         const bidRequest = {
           ...commonBidRequest,
@@ -390,7 +493,7 @@ describe('Outbrain Adapter', function () {
           ...commonBidRequest,
           ...nativeBidRequestParams,
         }
-        config.setConfig({coppa: true})
+        config.setConfig({ coppa: true })
 
         const res = spec.buildRequests([bidRequest], commonBidderRequest)
         const resData = JSON.parse(res.data)
@@ -412,7 +515,7 @@ describe('Outbrain Adapter', function () {
         let res = spec.buildRequests([bidRequest], commonBidderRequest);
         const resData = JSON.parse(res.data)
         expect(resData.user.ext.eids).to.deep.equal([
-          {source: 'liveramp.com', uids: [{id: 'id-value', atype: 3}]}
+          { source: 'liveramp.com', uids: [{ id: 'id-value', atype: 3 }] }
         ]);
       });
 
@@ -421,7 +524,7 @@ describe('Outbrain Adapter', function () {
           ...commonBidRequest,
           ...nativeBidRequestParams,
         }
-        bidRequest.getFloor = function() {
+        bidRequest.getFloor = function () {
           return {
             currency: 'USD',
             floor: 1.23,
@@ -619,6 +722,67 @@ describe('Outbrain Adapter', function () {
         const res = spec.interpretResponse(serverResponse, request)
         expect(res).to.deep.equal(expectedRes)
       });
+
+      it('should interpret video response', function () {
+        const serverResponse = {
+          body: {
+            id: '123',
+            seatbid: [
+              {
+                bid: [
+                  {
+                    id: '111',
+                    impid: '1',
+                    price: 1.1,
+                    adm: '\u003cVAST version="3.0"\u003e\u003cAd\u003e\u003cInLine\u003e\u003cAdSystem\u003ezemanta\u003c/AdSystem\u003e\u003cAdTitle\u003e1\u003c/AdTitle\u003e\u003cImpression\u003ehttp://win.com\u003c/Impression\u003e\u003cImpression\u003ehttp://example.com/imptracker\u003c/Impression\u003e\u003cCreatives\u003e\u003cCreative\u003e\u003cLinear\u003e\u003cDuration\u003e00:00:25\u003c/Duration\u003e\u003cTrackingEvents\u003e\u003cTracking event="start"\u003ehttp://example.com/start\u003c/Tracking\u003e\u003cTracking event="progress" offset="00:00:03"\u003ehttp://example.com/p3s\u003c/Tracking\u003e\u003c/TrackingEvents\u003e\u003cVideoClicks\u003e\u003cClickThrough\u003ehttp://link.com\u003c/ClickThrough\u003e\u003c/VideoClicks\u003e\u003cMediaFiles\u003e\u003cMediaFile delivery="progressive" type="video/mp4" bitrate="700" width="640" height="360"\u003ehttps://example.com/123_360p.mp4\u003c/MediaFile\u003e\u003c/MediaFiles\u003e\u003c/Linear\u003e\u003c/Creative\u003e\u003c/Creatives\u003e\u003c/InLine\u003e\u003c/Ad\u003e\u003c/VAST\u003e',
+                    adid: '100',
+                    cid: '5',
+                    crid: '29998660',
+                    cat: ['cat-1'],
+                    adomain: [
+                      'example.com'
+                    ],
+                    nurl: 'http://example.com/win/${AUCTION_PRICE}'
+                  }
+                ],
+                seat: '100',
+                group: 1
+              }
+            ],
+            bidid: '456',
+            cur: 'USD'
+          }
+        }
+        const request = {
+          bids: [
+            {
+              ...commonBidRequest,
+              ...videoBidRequestParams
+            }
+          ]
+        }
+        const expectedRes = [
+          {
+            requestId: request.bids[0].bidId,
+            cpm: 1.1,
+            creativeId: '29998660',
+            ttl: 360,
+            netRevenue: false,
+            currency: 'USD',
+            mediaType: 'video',
+            nurl: 'http://example.com/win/${AUCTION_PRICE}',
+            vastXml: '<VAST version=\"3.0\"><Ad><InLine><AdSystem>zemanta</AdSystem><AdTitle>1</AdTitle><Impression>http://win.com</Impression><Impression>http://example.com/imptracker</Impression><Creatives><Creative><Linear><Duration>00:00:25</Duration><TrackingEvents><Tracking event=\"start\">http://example.com/start</Tracking><Tracking event=\"progress\" offset=\"00:00:03\">http://example.com/p3s</Tracking></TrackingEvents><VideoClicks><ClickThrough>http://link.com</ClickThrough></VideoClicks><MediaFiles><MediaFile delivery=\"progressive\" type=\"video/mp4\" bitrate=\"700\" width=\"640\" height=\"360\">https://example.com/123_360p.mp4</MediaFile></MediaFiles></Linear></Creative></Creatives></InLine></Ad></VAST>',
+            meta: {
+              'advertiserDomains': [
+                'example.com'
+              ]
+            },
+          }
+        ]
+
+        const res = spec.interpretResponse(serverResponse, request)
+        expect(res).to.deep.equal(expectedRes)
+      });
     })
   })
 
@@ -637,41 +801,41 @@ describe('Outbrain Adapter', function () {
     })
 
     it('should return user sync if pixel enabled with outbrain config', function () {
-      const ret = spec.getUserSyncs({pixelEnabled: true})
-      expect(ret).to.deep.equal([{type: 'image', url: usersyncUrl}])
+      const ret = spec.getUserSyncs({ pixelEnabled: true })
+      expect(ret).to.deep.equal([{ type: 'image', url: usersyncUrl }])
     })
 
     it('should not return user sync if pixel disabled', function () {
-      const ret = spec.getUserSyncs({pixelEnabled: false})
+      const ret = spec.getUserSyncs({ pixelEnabled: false })
       expect(ret).to.be.an('array').that.is.empty
     })
 
     it('should not return user sync if url is not set', function () {
       config.resetConfig()
-      const ret = spec.getUserSyncs({pixelEnabled: true})
+      const ret = spec.getUserSyncs({ pixelEnabled: true })
       expect(ret).to.be.an('array').that.is.empty
     })
 
-    it('should pass GDPR consent', function() {
-      expect(spec.getUserSyncs({ pixelEnabled: true }, {}, {gdprApplies: true, consentString: 'foo'}, undefined)).to.deep.equal([{
+    it('should pass GDPR consent', function () {
+      expect(spec.getUserSyncs({ pixelEnabled: true }, {}, { gdprApplies: true, consentString: 'foo' }, undefined)).to.deep.equal([{
         type: 'image', url: `${usersyncUrl}?gdpr=1&gdpr_consent=foo`
       }]);
-      expect(spec.getUserSyncs({ pixelEnabled: true }, {}, {gdprApplies: false, consentString: 'foo'}, undefined)).to.deep.equal([{
+      expect(spec.getUserSyncs({ pixelEnabled: true }, {}, { gdprApplies: false, consentString: 'foo' }, undefined)).to.deep.equal([{
         type: 'image', url: `${usersyncUrl}?gdpr=0&gdpr_consent=foo`
       }]);
-      expect(spec.getUserSyncs({ pixelEnabled: true }, {}, {gdprApplies: true, consentString: undefined}, undefined)).to.deep.equal([{
+      expect(spec.getUserSyncs({ pixelEnabled: true }, {}, { gdprApplies: true, consentString: undefined }, undefined)).to.deep.equal([{
         type: 'image', url: `${usersyncUrl}?gdpr=1&gdpr_consent=`
       }]);
     });
 
-    it('should pass US consent', function() {
+    it('should pass US consent', function () {
       expect(spec.getUserSyncs({ pixelEnabled: true }, {}, undefined, '1NYN')).to.deep.equal([{
         type: 'image', url: `${usersyncUrl}?us_privacy=1NYN`
       }]);
     });
 
-    it('should pass GDPR and US consent', function() {
-      expect(spec.getUserSyncs({ pixelEnabled: true }, {}, {gdprApplies: true, consentString: 'foo'}, '1NYN')).to.deep.equal([{
+    it('should pass GDPR and US consent', function () {
+      expect(spec.getUserSyncs({ pixelEnabled: true }, {}, { gdprApplies: true, consentString: 'foo' }, '1NYN')).to.deep.equal([{
         type: 'image', url: `${usersyncUrl}?gdpr=1&gdpr_consent=foo&us_privacy=1NYN`
       }]);
     });

package/test/spec/modules/pulsepointBidAdapter_spec.js

@@ -2,7 +2,6 @@
 import {expect} from 'chai';
 import {spec} from 'modules/pulsepointBidAdapter.js';
 import {deepClone} from 'src/utils.js';
-import { config } from 'src/config.js';
 
 describe('PulsePoint Adapter Tests', function () {
   const slotConfigs = [{
@@ -225,6 +224,8 @@ describe('PulsePoint Adapter Tests', function () {
     expect(ortbRequest.imp[1].banner).to.not.equal(null);
     expect(ortbRequest.imp[1].banner.w).to.equal(728);
     expect(ortbRequest.imp[1].banner.h).to.equal(90);
+    // tmax
+    expect(ortbRequest.tmax).to.equal(500);
   });
 
   it('Verify parse response', function () {
@@ -918,4 +919,13 @@ describe('PulsePoint Adapter Tests', function () {
       }
     });
   });
+
+  it('Verify bid request timeouts', function () {
+    const mkRequest = (bidderRequest) => spec.buildRequests(slotConfigs, bidderRequest).data;
+    // assert default is used when no bidderRequest.timeout value is available
+    expect(mkRequest(bidderRequest).tmax).to.equal(500)
+
+    // assert bidderRequest value is used when available
+    expect(mkRequest(Object.assign({}, { timeout: 6000 }, bidderRequest)).tmax).to.equal(6000)
+  });
 });

package/test/spec/modules/smartadserverBidAdapter_spec.js

@@ -1,4 +1,5 @@
 import { expect } from 'chai';
+import { BANNER, VIDEO } from 'src/mediaTypes.js';
 import { config } from 'src/config.js';
 import { spec } from 'modules/smartadserverBidAdapter.js';
 
@@ -394,7 +395,6 @@ describe('Smart bid adapter tests', function () {
     afterEach(function () {
       config.setConfig({ ortb2: undefined });
       config.resetConfig();
-      $$PREBID_GLOBAL$$.requestBids.removeAll();
     });
 
     it('Verify build request with GDPR', function () {
@@ -443,10 +443,33 @@ describe('Smart bid adapter tests', function () {
     });
   });
 
+  describe('GPP', function () {
+    it('should be added to payload when gppConsent available in bidder request', function () {
+      const options = {
+        gppConsent: {
+          gppString: 'some-gpp-string',
+          applicableSections: [3, 5]
+        }
+      };
+      const request = spec.buildRequests(DEFAULT_PARAMS_WO_OPTIONAL, options);
+      const payload = JSON.parse(request[0].data);
+
+      expect(payload).to.have.property('gpp').and.to.equal(options.gppConsent.gppString);
+      expect(payload).to.have.property('gpp_sid').and.to.be.an('array');
+      expect(payload.gpp_sid).to.have.lengthOf(2).and.to.deep.equal(options.gppConsent.applicableSections);
+    });
+
+    it('should be undefined on payload when gppConsent unavailable in bidder request', function () {
+      const request = spec.buildRequests(DEFAULT_PARAMS_WO_OPTIONAL, {});
+      const payload = JSON.parse(request[0].data);
+
+      expect(payload.gpp).to.be.undefined;
+    });
+  });
+
   describe('ccpa/us privacy tests', function () {
     afterEach(function () {
       config.resetConfig();
-      $$PREBID_GLOBAL$$.requestBids.removeAll();
     });
 
     it('Verify build request with us privacy', function () {
@@ -475,7 +498,6 @@ describe('Smart bid adapter tests', function () {
   describe('Instream video tests', function () {
     afterEach(function () {
       config.resetConfig();
-      $$PREBID_GLOBAL$$.requestBids.removeAll();
     });
 
     const INSTREAM_DEFAULT_PARAMS = [{
@@ -746,7 +768,6 @@ describe('Smart bid adapter tests', function () {
   describe('Outstream video tests', function () {
     afterEach(function () {
       config.resetConfig();
-      $$PREBID_GLOBAL$$.requestBids.removeAll();
     });
 
     const OUTSTREAM_DEFAULT_PARAMS = [{
@@ -1055,6 +1076,17 @@ describe('Smart bid adapter tests', function () {
   });
 
   describe('Floors module', function () {
+    const getFloor = (bid) => {
+      switch (bid.mediaType) {
+        case BANNER:
+          return { currency: 'USD', floor: 1.93 };
+        case VIDEO:
+          return { currency: 'USD', floor: 2.72 };
+        default:
+          return {};
+      }
+    };
+
     it('should include floor from bid params', function() {
       const bidRequest = JSON.parse((spec.buildRequests(DEFAULT_PARAMS))[0].data);
       expect(bidRequest.bidfloor).to.deep.equal(DEFAULT_PARAMS[0].params.bidfloor);
@@ -1094,12 +1126,91 @@ describe('Smart bid adapter tests', function () {
       const floor = spec.getBidFloor(bidRequest, null);
       expect(floor).to.deep.equal(0);
     });
+
+    it('should take floor from bidder params over ad unit', function() {
+      const bidRequest = [{
+        mediaTypes: {
+          banner: {
+            sizes: [[300, 250]]
+          }
+        },
+        getFloor,
+        params: { siteId: 1234, pageId: 678, formatId: 73, bidfloor: 1.25 }
+      }];
+
+      const request = spec.buildRequests(bidRequest);
+      const requestContent = JSON.parse(request[0].data);
+
+      expect(requestContent).to.have.property('bidfloor').and.to.equal(1.25);
+    });
+
+    it('should take floor from banner ad unit', function() {
+      const bidRequest = [{
+        mediaTypes: {
+          banner: {
+            sizes: [[300, 250], [300, 600]]
+          }
+        },
+        getFloor,
+        params: { siteId: 1234, pageId: 678, formatId: 73 }
+      }];
+
+      const request = spec.buildRequests(bidRequest);
+      const requestContent = JSON.parse(request[0].data);
+
+      expect(requestContent).to.have.property('bidfloor').and.to.equal(1.93);
+    });
+
+    it('should take floor from video ad unit', function() {
+      const bidRequest = [{
+        mediaTypes: {
+          video: {
+            context: 'outstream',
+            playerSize: [[640, 480]]
+          }
+        },
+        getFloor,
+        params: { siteId: 1234, pageId: 678, formatId: 73 }
+      }];
+
+      const request = spec.buildRequests(bidRequest);
+      const requestContent = JSON.parse(request[0].data);
+
+      expect(requestContent).to.have.property('bidfloor').and.to.equal(2.72);
+    });
+
+    it('should take floor from multiple media type ad unit', function() {
+      const bidRequest = [{
+        mediaTypes: {
+          banner: {
+            sizes: [[300, 600]]
+          },
+          video: {
+            context: 'outstream',
+            playerSize: [[640, 480]]
+          }
+        },
+        getFloor,
+        params: { siteId: 1234, pageId: 678, formatId: 73 }
+      }];
+
+      const requests = spec.buildRequests(bidRequest);
+      expect(requests).to.have.lengthOf(2);
+
+      const requestContents = requests.map(r => JSON.parse(r.data));
+      const videoRequest = requestContents.filter(r => r.videoData)[0];
+      expect(videoRequest).to.not.equal(null).and.to.not.be.undefined;
+      expect(videoRequest).to.have.property('bidfloor').and.to.equal(2.72);
+
+      const bannerRequest = requestContents.filter(r => !r.videoData)[0];
+      expect(bannerRequest).to.not.equal(null).and.to.not.be.undefined;
+      expect(bannerRequest).to.have.property('bidfloor').and.to.equal(1.93);
+    });
   });
 
   describe('Verify bid requests with multiple mediaTypes', function () {
     afterEach(function () {
       config.resetConfig();
-      $$PREBID_GLOBAL$$.requestBids.removeAll();
     });
 
     var DEFAULT_PARAMS_MULTIPLE_MEDIA_TYPES = [{