prebid.js 7.33.0 → 7.34.0

package/test/spec/modules/prebidServerBidAdapter_spec.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-trailing-spaces */
 import {expect} from 'chai';
 import {
   PrebidServer as Adapter,
@@ -1505,6 +1506,28 @@ describe('S2S Adapter', function () {
       });
     });
 
+    it('site should not be present when app is present', function () {
+      const _config = {
+        s2sConfig: CONFIG,
+        app: { bundle: 'com.test.app' },
+        site: {
+          publisher: {
+            id: '1234',
+            domain: 'test.com'
+          },
+          content: {
+            language: 'en'
+          }
+        }
+      };
+
+      config.setConfig(_config);
+      adapter.callBids(REQUEST, BID_REQUESTS, addBidResponse, done, ajax);
+      const requestBid = JSON.parse(server.requests[0].requestBody);
+      expect(requestBid.site).to.not.exist;
+      expect(requestBid.app).to.exist.and.to.be.a('object');
+    });
+
     it('adds appnexus aliases to request', function () {
       config.setConfig({ s2sConfig: CONFIG });
 
@@ -1703,6 +1726,121 @@ describe('S2S Adapter', function () {
       }]);
     });
 
+    describe('filterSettings', function () {
+      const getRequestBid = userSync => {
+        let cookieSyncConfig = utils.deepClone(CONFIG);
+        const s2sBidRequest = utils.deepClone(REQUEST);
+        cookieSyncConfig.syncEndpoint = { p1Consent: 'https://prebid.adnxs.com/pbs/v1/cookie_sync' };
+        s2sBidRequest.s2sConfig = cookieSyncConfig;
+  
+        config.setConfig({ userSync, s2sConfig: cookieSyncConfig });
+  
+        let bidRequest = utils.deepClone(BID_REQUESTS);
+        adapter.callBids(s2sBidRequest, bidRequest, addBidResponse, done, ajax);
+        return JSON.parse(server.requests[0].requestBody);
+      }
+
+      it('correctly adds filterSettings to the cookie_sync request if userSync.filterSettings is present in the config and only the all key is present in userSync.filterSettings', function () {
+        const userSync = {
+          filterSettings: {
+            all: {
+              bidders: ['appnexus', 'rubicon', 'pubmatic'],
+              filter: 'exclude'
+            }
+          }
+        };
+        const requestBid = getRequestBid(userSync);
+
+        expect(requestBid.filterSettings).to.deep.equal({
+          'image': {
+            'bidders': ['appnexus', 'rubicon', 'pubmatic'],
+            'filter': 'exclude'
+          },
+          'iframe': {
+            'bidders': ['appnexus', 'rubicon', 'pubmatic'],
+            'filter': 'exclude'
+          }
+        });
+      });
+  
+      it('correctly adds filterSettings to the cookie_sync request if userSync.filterSettings is present in the config and only the iframe key is present in userSync.filterSettings', function () {
+        const userSync = {
+          filterSettings: {
+            iframe: {
+              bidders: ['rubicon', 'pubmatic'],
+              filter: 'include'
+            }
+          }
+        };
+        const requestBid = getRequestBid(userSync);
+
+        expect(requestBid.filterSettings).to.deep.equal({
+          'image': {
+            'bidders': '*',
+            'filter': 'include'
+          },
+          'iframe': {
+            'bidders': ['rubicon', 'pubmatic'],
+            'filter': 'include'
+          }
+        });
+      });
+
+      it('correctly adds filterSettings to the cookie_sync request if userSync.filterSettings is present in the config and the image and iframe keys are both present in userSync.filterSettings', function () {
+        const userSync = {
+          filterSettings: {
+            image: {
+              bidders: ['triplelift', 'appnexus'],
+              filter: 'include'
+            },
+            iframe: {
+              bidders: ['pulsepoint', 'triplelift', 'appnexus', 'rubicon'],
+              filter: 'exclude'
+            }
+          }
+        };
+        const requestBid = getRequestBid(userSync);
+
+        expect(requestBid.filterSettings).to.deep.equal({
+          'image': {
+            'bidders': ['triplelift', 'appnexus'],
+            'filter': 'include'
+          },
+          'iframe': {
+            'bidders': ['pulsepoint', 'triplelift', 'appnexus', 'rubicon'],
+            'filter': 'exclude'
+          }
+        });
+      });
+
+      it('correctly adds filterSettings to the cookie_sync request if userSync.filterSettings is present in the config and the all and iframe keys are both present in userSync.filterSettings', function () {
+        const userSync = {
+          filterSettings: {
+            all: {
+              bidders: ['triplelift', 'appnexus'],
+              filter: 'include'
+            },
+            iframe: {
+              bidders: ['pulsepoint', 'triplelift', 'appnexus', 'rubicon'],
+              filter: 'exclude'
+            }
+          }
+        };
+        const requestBid = getRequestBid(userSync);
+
+        expect(requestBid.filterSettings).to.deep.equal({
+          'image': {
+            'bidders': ['triplelift', 'appnexus'],
+            'filter': 'include'
+          },
+          'iframe': {
+            'bidders': ['pulsepoint', 'triplelift', 'appnexus', 'rubicon'],
+            'filter': 'exclude'
+          }
+        });
+      });
+    });
+
     it('adds limit to the cookie_sync request if userSyncLimit is greater than 0', function () {
       let cookieSyncConfig = utils.deepClone(CONFIG);
       cookieSyncConfig.syncEndpoint = { p1Consent: 'https://prebid.adnxs.com/pbs/v1/cookie_sync' };

package/test/spec/modules/seedingAllianceAdapter_spec.js

@@ -38,7 +38,7 @@ describe('SeedingAlliance adapter', function () {
     });
 
     it('should have default request structure', function () {
-      let keys = 'site,device,cur,imp,user,regs'.split(',');
+      let keys = 'site,cur,imp,regs'.split(',');
       let validBidRequests = [{
         bidId: 'bidId',
         params: {}
@@ -60,14 +60,17 @@ describe('SeedingAlliance adapter', function () {
       assert.equal(request.id, validBidRequests[0].auctionId);
     });
 
-    it('Verify the device', function () {
+    it('Verify the site url', function () {
+      let siteUrl = 'https://www.yourdomain.tld/your-directory/';
       let validBidRequests = [{
         bidId: 'bidId',
-        params: {}
+        params: {
+          url: siteUrl
+        }
       }];
       let request = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data);
 
-      assert.equal(request.device.ua, navigator.userAgent);
+      assert.equal(request.site.page, siteUrl);
     });
 
     it('Verify native asset ids', function () {
@@ -109,7 +112,7 @@ describe('SeedingAlliance adapter', function () {
   });
 
   describe('interpretResponse', function () {
-    const goodResponse = {
+    const goodNativeResponse = {
       body: {
         cur: 'EUR',
         id: '4b516b80-886e-4ec0-82ae-9209e6d625fb',
@@ -136,51 +139,91 @@ describe('SeedingAlliance adapter', function () {
         ]
       }
     };
+
+    const goodBannerResponse = {
+      body: {
+        cur: 'EUR',
+        id: 'b4516b80-886e-4ec0-82ae-9209e6d625fb',
+        seatbid: [
+          {
+          	seat: 'seedingAlliance',
+          	bid: [{
+              adm: '<iframe src="https://domain.tld/cds/delivery?wp=0.90"></iframe>',
+              impid: 1,
+              price: 0.90,
+              h: 250,
+              w: 300
+            }]
+          }
+        ]
+      }
+    };
+
     const badResponse = { body: {
       cur: 'EUR',
       id: '4b516b80-886e-4ec0-82ae-9209e6d625fb',
       seatbid: []
     }};
 
-    const bidRequest = {
+    const bidNativeRequest = {
       data: {},
-      bids: [{ bidId: 'bidId1' }]
+      bidRequests: [{bidId: 'bidId1', nativeParams: {title: {required: true, len: 800}}}]
+    };
+
+    const bidBannerRequest = {
+      data: {},
+      bidRequests: [{bidId: 'bidId1', sizes: [300, 250]}]
     };
 
     it('should return null if body is missing or empty', function () {
-      const result = spec.interpretResponse(badResponse, bidRequest);
+      const result = spec.interpretResponse(badResponse, bidNativeRequest);
       assert.equal(result.length, 0);
 
       delete badResponse.body
 
-      const result1 = spec.interpretResponse(badResponse, bidRequest);
+      const result1 = spec.interpretResponse(badResponse, bidNativeRequest);
       assert.equal(result.length, 0);
     });
 
     it('should return the correct params', function () {
-      const result = spec.interpretResponse(goodResponse, bidRequest);
-      const bid = goodResponse.body.seatbid[0].bid[0];
-
-      assert.deepEqual(result[0].currency, goodResponse.body.cur);
-      assert.deepEqual(result[0].requestId, bidRequest.bids[0].bidId);
-      assert.deepEqual(result[0].cpm, bid.price);
-      assert.deepEqual(result[0].creativeId, bid.crid);
-      assert.deepEqual(result[0].mediaType, 'native');
-      assert.deepEqual(result[0].bidderCode, 'seedingAlliance');
+      const resultNative = spec.interpretResponse(goodNativeResponse, bidNativeRequest);
+      const bidNative = goodNativeResponse.body.seatbid[0].bid[0];
+
+      assert.deepEqual(resultNative[0].bidderCode, 'seedingAlliance');
+      assert.deepEqual(resultNative[0].currency, goodNativeResponse.body.cur);
+      assert.deepEqual(resultNative[0].requestId, bidNativeRequest.bidRequests[0].bidId);
+      assert.deepEqual(resultNative[0].cpm, bidNative.price);
+      assert.deepEqual(resultNative[0].creativeId, bidNative.crid);
+      assert.deepEqual(resultNative[0].mediaType, 'native');
+
+      const resultBanner = spec.interpretResponse(goodBannerResponse, bidBannerRequest);
+
+      assert.deepEqual(resultBanner[0].bidderCode, 'seedingAlliance');
+      assert.deepEqual(resultBanner[0].mediaType, 'banner');
+      assert.deepEqual(resultBanner[0].width, bidBannerRequest.bidRequests[0].sizes[0]);
+      assert.deepEqual(resultBanner[0].height, bidBannerRequest.bidRequests[0].sizes[1]);
     });
 
-    it('should return the correct tracking links', function () {
-      const result = spec.interpretResponse(goodResponse, bidRequest);
-      const bid = goodResponse.body.seatbid[0].bid[0];
+    it('should return the correct native tracking links', function () {
+      const result = spec.interpretResponse(goodNativeResponse, bidNativeRequest);
+      const bid = goodNativeResponse.body.seatbid[0].bid[0];
       const regExpPrice = new RegExp('price=' + bid.price);
 
       result[0].native.clickTrackers.forEach(function (clickTracker) {
-        	assert.ok(clickTracker.search(regExpPrice) > -1);
+        assert.ok(clickTracker.search(regExpPrice) > -1);
       });
 
       result[0].native.impressionTrackers.forEach(function (impTracker) {
-        	assert.ok(impTracker.search(regExpPrice) > -1);
+        assert.ok(impTracker.search(regExpPrice) > -1);
       });
     });
+
+    it('should return the correct banner content', function () {
+      const result = spec.interpretResponse(goodBannerResponse, bidBannerRequest);
+      const bid = goodBannerResponse.body.seatbid[0].bid[0];
+      const regExpContent = new RegExp('<iframe.+?' + bid.price + '.+?</iframe>');
+
+      assert.ok(result[0].ad.search(regExpContent) > -1);
+    });
   });
 });

package/test/spec/modules/tripleliftBidAdapter_spec.js

@@ -1168,6 +1168,19 @@ describe('triplelift adapter', function () {
         }
       })
     });
+    it('should add gpp consent data to bid request object if gpp data exists', function() {
+      bidderRequest.ortb2 = {
+        regs: {
+          'gpp': 'BOJ/P2HOJ/P2HABABMAAAAAZ+A==',
+          'gpp_sid': [7]
+        }
+      }
+      const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
+      expect(request.data.regs).to.deep.equal({
+        'gpp': 'BOJ/P2HOJ/P2HABABMAAAAAZ+A==',
+        'gpp_sid': [7]
+      })
+    });
   });
 
   describe('interpretResponse', function () {

package/test/spec/ortbConverter/default_processors_spec.js

@@ -0,0 +1,23 @@
+import {onlyOneClientSection} from '../../../libraries/ortbConverter/processors/default.js';
+
+describe('onlyOneClientSection', () => {
+  [
+    [['app'], 'app'],
+    [['site'], 'site'],
+    [['dooh'], 'dooh'],
+    [['app', 'site'], 'app'],
+    [['dooh', 'app', 'site'], 'dooh'],
+    [['dooh', 'site'], 'dooh']
+  ].forEach(([sections, winner]) => {
+    it(`should leave only ${winner} in request when it contains ${sections.join(', ')}`, () => {
+      const req = Object.fromEntries(sections.map(s => [s, {foo: 'bar'}]));
+      onlyOneClientSection(req);
+      expect(Object.keys(req)).to.eql([winner]);
+    })
+  });
+  it('should not choke if none of the sections are in the request', () => {
+    const req = {};
+    onlyOneClientSection(req);
+    expect(req).to.eql({});
+  });
+});