prebid.js 7.26.0 → 7.28.0

package/test/spec/modules/vidazooBidAdapter_spec.js

@@ -1,4 +1,4 @@
-import {expect} from 'chai';
+import { expect } from 'chai';
 import {
   spec as adapter,
   SUPPORTED_ID_SYSTEMS,
@@ -15,8 +15,9 @@ import {
   getVidazooSessionId,
 } from 'modules/vidazooBidAdapter.js';
 import * as utils from 'src/utils.js';
-import {version} from 'package.json';
-import {useFakeTimers} from 'sinon';
+import { version } from 'package.json';
+import { useFakeTimers } from 'sinon';
+import { BANNER, VIDEO } from '../../../src/mediaTypes';
 
 const SUB_DOMAIN = 'openrtb';
 
@@ -38,9 +39,47 @@ const BID = {
   'sizes': [[300, 250], [300, 600]],
   'bidderRequestId': '1fdb5ff1b6eaa7',
   'requestId': 'b0777d85-d061-450e-9bc7-260dd54bbb7a',
-  'schain': 'a0819c69-005b-41ed-af06-1be1e0aefefc'
+  'schain': 'a0819c69-005b-41ed-af06-1be1e0aefefc',
+  'mediaTypes': [BANNER],
+  'ortb2Imp': {
+    'ext': {
+      'gpid': '1234567890'
+    }
+  }
 };
 
+const VIDEO_BID = {
+  'bidId': '2d52001cabd527',
+  'adUnitCode': '63550ad1ff6642d368cba59dh5884270560',
+  'bidderRequestId': '12a8ae9ada9c13',
+  'transactionId': '56e184c6-bde9-497b-b9b9-cf47a61381ee',
+  'schain': 'a0819c69-005b-41ed-af06-1be1e0aefefc',
+  'params': {
+    'subDomain': SUB_DOMAIN,
+    'cId': '635509f7ff6642d368cb9837',
+    'pId': '59ac17c192832d0011283fe3',
+    'bidFloor': 0.1
+  },
+  'sizes': [[545, 307]],
+  'mediaTypes': {
+    'video': {
+      'playerSize': [[545, 307]],
+      'context': 'instream',
+      'mimes': [
+        'video/mp4',
+        'application/javascript'
+      ],
+      'protocols': [2, 3, 5, 6],
+      'maxduration': 60,
+      'minduration': 0,
+      'startdelay': 0,
+      'linearity': 1,
+      'api': [2],
+      'placement': 1
+    }
+  }
+}
+
 const BIDDER_REQUEST = {
   'gdprConsent': {
     'consentString': 'consent_string',
@@ -50,7 +89,13 @@ const BIDDER_REQUEST = {
   'refererInfo': {
     'page': 'https://www.greatsite.com',
     'ref': 'https://www.somereferrer.com'
-  }
+  },
+  'ortb2': {
+    'site': {
+      'cat': ['IAB2'],
+      'pagecat': ['IAB2-2']
+    }
+  },
 };
 
 const SERVER_RESPONSE = {
@@ -75,6 +120,23 @@ const SERVER_RESPONSE = {
   }
 };
 
+const VIDEO_SERVER_RESPONSE = {
+  body: {
+    'cid': '635509f7ff6642d368cb9837',
+    'results': [{
+      'ad': '<VAST version=\"3.0\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\"></VAST>',
+      'advertiserDomains': ['vidazoo.com'],
+      'exp': 60,
+      'width': 545,
+      'height': 307,
+      'mediaType': 'video',
+      'creativeId': '12610997325162499419',
+      'price': 2,
+      'cookies': []
+    }]
+  }
+}
+
 const REQUEST = {
   data: {
     width: 300,
@@ -85,7 +147,7 @@ const REQUEST = {
 
 function getTopWindowQueryParams() {
   try {
-    const parsedUrl = utils.parseUrl(window.top.document.URL, {decodeSearchAsString: true});
+    const parsedUrl = utils.parseUrl(window.top.document.URL, { decodeSearchAsString: true });
     return parsedUrl.search;
   } catch (e) {
     return '';
@@ -113,6 +175,11 @@ describe('VidazooBidAdapter', function () {
     it('exists and is a string', function () {
       expect(adapter.code).to.exist.and.to.be.a('string');
     });
+
+    it('exists and contains media types', function () {
+      expect(adapter.supportedMediaTypes).to.exist.and.to.be.an('array').with.length(2);
+      expect(adapter.supportedMediaTypes).to.contain.members([BANNER, VIDEO]);
+    });
   });
 
   describe('validate bid requests', function () {
@@ -150,14 +217,67 @@ describe('VidazooBidAdapter', function () {
     before(function () {
       $$PREBID_GLOBAL$$.bidderSettings = {
         vidazoo: {
-          storageAllowed: true
+          storageAllowed: true,
         }
       };
       sandbox = sinon.sandbox.create();
       sandbox.stub(Date, 'now').returns(1000);
     });
 
-    it('should build request for each size', function () {
+    it('should build video request', function () {
+      const hashUrl = hashCode(BIDDER_REQUEST.refererInfo.page);
+      const requests = adapter.buildRequests([VIDEO_BID], BIDDER_REQUEST);
+      expect(requests).to.have.length(1);
+      expect(requests[0]).to.deep.equal({
+        method: 'POST',
+        url: `${createDomain(SUB_DOMAIN)}/prebid/multi/635509f7ff6642d368cb9837`,
+        data: {
+          adUnitCode: '63550ad1ff6642d368cba59dh5884270560',
+          bidFloor: 0.1,
+          bidId: '2d52001cabd527',
+          bidderVersion: adapter.version,
+          cat: ['IAB2'],
+          pagecat: ['IAB2-2'],
+          cb: 1000,
+          dealId: 1,
+          gdpr: 1,
+          gdprConsent: 'consent_string',
+          usPrivacy: 'consent_string',
+          gpid: '',
+          prebidVersion: version,
+          ptrace: '1000',
+          publisherId: '59ac17c192832d0011283fe3',
+          url: 'https%3A%2F%2Fwww.greatsite.com',
+          referrer: 'https://www.somereferrer.com',
+          res: `${window.top.screen.width}x${window.top.screen.height}`,
+          schain: VIDEO_BID.schain,
+          sessionId: '',
+          sizes: ['545x307'],
+          uniqueDealId: `${hashUrl}_${Date.now().toString()}`,
+          uqs: getTopWindowQueryParams(),
+          isStorageAllowed: true,
+          mediaTypes: {
+            video: {
+              api: [2],
+              context: 'instream',
+              linearity: 1,
+              maxduration: 60,
+              mimes: [
+                'video/mp4',
+                'application/javascript'
+              ],
+              minduration: 0,
+              placement: 1,
+              playerSize: [[545, 307]],
+              protocols: [2, 3, 5, 6],
+              startdelay: 0
+            }
+          }
+        }
+      });
+    });
+
+    it('should build banner request for each size', function () {
       const hashUrl = hashCode(BIDDER_REQUEST.refererInfo.page);
       const requests = adapter.buildRequests([BID], BIDDER_REQUEST);
       expect(requests).to.have.length(1);
@@ -176,7 +296,7 @@ describe('VidazooBidAdapter', function () {
           bidId: '2d52001cabd527',
           adUnitCode: 'div-gpt-ad-12345-0',
           publisherId: '59ac17c192832d0011283fe3',
-          dealId: 1,
+          dealId: 2,
           sessionId: '',
           uniqueDealId: `${hashUrl}_${Date.now().toString()}`,
           bidderVersion: adapter.version,
@@ -184,9 +304,14 @@ describe('VidazooBidAdapter', function () {
           schain: BID.schain,
           ptrace: '1000',
           res: `${window.top.screen.width}x${window.top.screen.height}`,
+          mediaTypes: [BANNER],
           uqs: getTopWindowQueryParams(),
           'ext.param1': 'loremipsum',
           'ext.param2': 'dolorsitamet',
+          isStorageAllowed: true,
+          gpid: '1234567890',
+          cat: ['IAB2'],
+          pagecat: ['IAB2-2']
         }
       });
     });
@@ -196,9 +321,10 @@ describe('VidazooBidAdapter', function () {
       sandbox.restore();
     });
   });
+
   describe('getUserSyncs', function () {
     it('should have valid user sync with iframeEnabled', function () {
-      const result = adapter.getUserSyncs({iframeEnabled: true}, [SERVER_RESPONSE]);
+      const result = adapter.getUserSyncs({ iframeEnabled: true }, [SERVER_RESPONSE]);
 
       expect(result).to.deep.equal([{
         type: 'iframe',
@@ -207,7 +333,7 @@ describe('VidazooBidAdapter', function () {
     });
 
     it('should have valid user sync with cid on response', function () {
-      const result = adapter.getUserSyncs({iframeEnabled: true}, [SERVER_RESPONSE]);
+      const result = adapter.getUserSyncs({ iframeEnabled: true }, [SERVER_RESPONSE]);
       expect(result).to.deep.equal([{
         type: 'iframe',
         url: 'https://sync.cootlogix.com/api/sync/iframe/?cid=testcid123&gdpr=0&gdpr_consent=&us_privacy='
@@ -215,7 +341,7 @@ describe('VidazooBidAdapter', function () {
     });
 
     it('should have valid user sync with pixelEnabled', function () {
-      const result = adapter.getUserSyncs({pixelEnabled: true}, [SERVER_RESPONSE]);
+      const result = adapter.getUserSyncs({ pixelEnabled: true }, [SERVER_RESPONSE]);
 
       expect(result).to.deep.equal([{
         'url': 'https://sync.cootlogix.com/api/sync/image/?cid=testcid123&gdpr=0&gdpr_consent=&us_privacy=',
@@ -231,16 +357,16 @@ describe('VidazooBidAdapter', function () {
     });
 
     it('should return empty array when there is no ad', function () {
-      const responses = adapter.interpretResponse({price: 1, ad: ''});
+      const responses = adapter.interpretResponse({ price: 1, ad: '' });
       expect(responses).to.be.empty;
     });
 
     it('should return empty array when there is no price', function () {
-      const responses = adapter.interpretResponse({price: null, ad: 'great ad'});
+      const responses = adapter.interpretResponse({ price: null, ad: 'great ad' });
       expect(responses).to.be.empty;
     });
 
-    it('should return an array of interpreted responses', function () {
+    it('should return an array of interpreted banner responses', function () {
       const responses = adapter.interpretResponse(SERVER_RESPONSE, REQUEST);
       expect(responses).to.have.length(1);
       expect(responses[0]).to.deep.equal({
@@ -259,6 +385,26 @@ describe('VidazooBidAdapter', function () {
       });
     });
 
+    it('should return an array of interpreted video responses', function () {
+      const responses = adapter.interpretResponse(VIDEO_SERVER_RESPONSE, REQUEST);
+      expect(responses).to.have.length(1);
+      expect(responses[0]).to.deep.equal({
+        requestId: '2d52001cabd527',
+        cpm: 2,
+        width: 545,
+        height: 307,
+        mediaType: 'video',
+        creativeId: '12610997325162499419',
+        currency: 'USD',
+        netRevenue: true,
+        ttl: 60,
+        vastXml: '<VAST version=\"3.0\" xmlns:xs=\"http://www.w3.org/2001/XMLSchema\"></VAST>',
+        meta: {
+          advertiserDomains: ['vidazoo.com']
+        }
+      });
+    });
+
     it('should take default TTL', function () {
       const serverResponse = utils.deepClone(SERVER_RESPONSE);
       delete serverResponse.body.results[0].exp;
@@ -276,11 +422,11 @@ describe('VidazooBidAdapter', function () {
       const userId = (function () {
         switch (idSystemProvider) {
           case 'lipb':
-            return {lipbid: id};
+            return { lipbid: id };
           case 'parrableId':
-            return {eid: id};
+            return { eid: id };
           case 'id5id':
-            return {uid: id};
+            return { uid: id };
           default:
             return id;
         }
@@ -299,18 +445,18 @@ describe('VidazooBidAdapter', function () {
 
   describe('alternate param names extractors', function () {
     it('should return undefined when param not supported', function () {
-      const cid = extractCID({'c_id': '1'});
-      const pid = extractPID({'p_id': '1'});
-      const subDomain = extractSubDomain({'sub_domain': 'prebid'});
+      const cid = extractCID({ 'c_id': '1' });
+      const pid = extractPID({ 'p_id': '1' });
+      const subDomain = extractSubDomain({ 'sub_domain': 'prebid' });
       expect(cid).to.be.undefined;
       expect(pid).to.be.undefined;
       expect(subDomain).to.be.undefined;
     });
 
     it('should return value when param supported', function () {
-      const cid = extractCID({'cID': '1'});
-      const pid = extractPID({'Pid': '2'});
-      const subDomain = extractSubDomain({'subDOMAIN': 'prebid'});
+      const cid = extractCID({ 'cID': '1' });
+      const pid = extractPID({ 'Pid': '2' });
+      const subDomain = extractSubDomain({ 'subDOMAIN': 'prebid' });
       expect(cid).to.be.equal('1');
       expect(pid).to.be.equal('2');
       expect(subDomain).to.be.equal('prebid');
@@ -423,7 +569,7 @@ describe('VidazooBidAdapter', function () {
         now
       });
       setStorageItem('myKey', 2020);
-      const {value, created} = getStorageItem('myKey');
+      const { value, created } = getStorageItem('myKey');
       expect(created).to.be.equal(now);
       expect(value).to.be.equal(2020);
       expect(typeof value).to.be.equal('number');
@@ -439,8 +585,8 @@ describe('VidazooBidAdapter', function () {
     });
 
     it('should parse JSON value', function () {
-      const data = JSON.stringify({event: 'send'});
-      const {event} = tryParseJSON(data);
+      const data = JSON.stringify({ event: 'send' });
+      const { event } = tryParseJSON(data);
       expect(event).to.be.equal('send');
     });
 

package/test/spec/modules/yandexBidAdapter_spec.js

@@ -1,15 +1,14 @@
-import {assert, expect} from 'chai';
-import {spec} from 'modules/yandexBidAdapter.js';
-import {parseUrl} from 'src/utils.js';
-import {BANNER} from '../../../src/mediaTypes';
+import { assert, expect } from 'chai';
+import { spec } from 'modules/yandexBidAdapter.js';
+import { parseUrl } from 'src/utils.js';
+import { BANNER } from '../../../src/mediaTypes';
 
 describe('Yandex adapter', function () {
   function getBidConfig() {
     return {
       bidder: 'yandex',
       params: {
-        pageId: 123,
-        impId: 1,
+        placementId: '123-1',
       },
     };
   }
@@ -32,7 +31,7 @@ describe('Yandex adapter', function () {
 
   describe('isBidRequestValid', function () {
     it('should return true when required params found', function () {
-      const bid = getBidConfig();
+      const bid = getBidRequest();
       assert(spec.isBidRequestValid(bid));
     });
 
@@ -40,18 +39,28 @@ describe('Yandex adapter', function () {
       expect(spec.isBidRequestValid({})).to.be.false;
     });
 
-    it('should return false when required params.pageId are not passed', function () {
+    it('should return false when required params.placementId are not passed', function () {
+      const bid = getBidConfig();
+      delete bid.params.placementId;
+
+      expect(spec.isBidRequestValid(bid)).to.be.false;
+    });
+
+    it('should return false when required params.placementId are not valid', function () {
       const bid = getBidConfig();
-      delete bid.params.pageId;
+      bid.params.placementId = '123';
 
-      expect(spec.isBidRequestValid(bid)).to.be.false
+      expect(spec.isBidRequestValid(bid)).to.be.false;
     });
 
-    it('should return false when required params.impId are not passed', function () {
+    it('should return true when passed deprecated placement config', function () {
       const bid = getBidConfig();
-      delete bid.params.impId;
+      delete bid.params.placementId;
+
+      bid.params.pageId = 123;
+      bid.params.impId = 1;
 
-      expect(spec.isBidRequestValid(bid)).to.be.false
+      expect(spec.isBidRequestValid(bid));
     });
   });
 

package/test/spec/modules/yieldlabBidAdapter_spec.js

@@ -658,36 +658,65 @@ describe('yieldlabBidAdapter', () => {
   });
 
   describe('getBidFloor', function () {
-    let bidRequest, getFloor;
-
-    it('should add valid bid floor', () => {
-      getFloor = () => {
-        return {
-          currency: 'EUR',
-          floor: 1.33
-        };
-      };
+    let bidRequest, bidRequest2, currency, floor;
+    const getFloor = () => {
+      return {
+        currency: currency,
+        floor: floor
+      }
+    }
+
+    it('should add valid bid floor in the format floor={adslotId}:{floorPriceInCents}[, ...]', () => {
+      bidRequest = Object.assign(DEFAULT_REQUEST(), {
+        getFloor: () => {
+          return {
+            currency: 'EUR',
+            floor: 1.33
+          }
+        }});
+      bidRequest2 = Object.assign(DEFAULT_REQUEST(), {
+        params: {
+          adslotId: 2222
+        },
+        getFloor: () => {
+          return {
+            currency: 'EUR',
+            floor: 2.99
+          }
+        }
+      });
+      const result = spec.buildRequests([bidRequest, bidRequest2], REQPARAMS)
+      expect(result).to.have.nested.property('queryParams.floor', '1111:133,2222:299')
+    });
+
+    it('should round the floor price up', () => {
+      currency = 'EUR';
+      floor = 0.745;
       bidRequest = Object.assign(DEFAULT_REQUEST(), {getFloor})
       const result = spec.buildRequests([bidRequest], REQPARAMS)
-      expect(result).to.have.nested.property('queryParams.floor', 1.33)
+      expect(result).to.have.nested.property('queryParams.floor', '1111:75')
     });
 
-    it('should not add empty bid floor', () => {
-      getFloor = () => {
-        return {};
-      };
+    it('should round the floor price down', () => {
+      currency = 'EUR';
+      floor = 0.034;
       bidRequest = Object.assign(DEFAULT_REQUEST(), {getFloor})
       const result = spec.buildRequests([bidRequest], REQPARAMS)
+      expect(result).to.have.nested.property('queryParams.floor', '1111:3')
+    });
+
+    it('should not add empty bid floor', () => {
+      bidRequest = Object.assign(DEFAULT_REQUEST(), {
+        getFloor: () => {
+          return {};
+        }})
+      const result = spec.buildRequests([bidRequest], REQPARAMS)
       expect(result).not.to.have.nested.property('queryParams.floor')
     });
 
     it('should not add bid floor when currency is not matching', () => {
-      getFloor = (currency, mediaType, size) => {
-        return {
-          currency: 'USD',
-          floor: 1.33
-        };
-      };
+      currency = 'USD';
+      floor = 1.33;
       bidRequest = Object.assign(DEFAULT_REQUEST(), {getFloor})
       const result = spec.buildRequests([bidRequest], REQPARAMS)
       expect(result).not.to.have.nested.property('queryParams.floor')

package/test/spec/modules/yieldliftBidAdapter_spec.js

@@ -229,7 +229,7 @@ describe('YieldLift', function () {
         expect(bids[index]).to.have.property('ad', RESPONSE.body.seatbid[0].bid[index].adm);
         expect(bids[index]).to.have.property('creativeId', RESPONSE.body.seatbid[0].bid[index].crid);
         expect(bids[index].meta).to.have.property('advertiserDomains', RESPONSE.body.seatbid[0].bid[index].advertiserDomains);
-        expect(bids[index]).to.have.property('ttl', 30);
+        expect(bids[index]).to.have.property('ttl', 300);
         expect(bids[index]).to.have.property('netRevenue', true);
       }
     });

package/test/spec/modules/yieldoneAnalyticsAdapter_spec.js

@@ -1,6 +1,7 @@
 import yieldoneAnalytics from 'modules/yieldoneAnalyticsAdapter.js';
 import { targeting } from 'src/targeting.js';
 import { expect } from 'chai';
+import _ from 'lodash';
 let events = require('src/events');
 let adapterManager = require('src/adapterManager').default;
 let constants = require('src/constants.json');
@@ -225,7 +226,9 @@ describe('Yieldone Prebid Analytic', function () {
         pubId: initOptions.pubId,
         page: {url: testReferrer},
         wrapper_version: '$prebid.version$',
-        events: expectedEvents
+        events: sinon.match(evs => {
+          return !expectedEvents.some((expectedEvent) => evs.find(ev => _.isEqual(ev, expectedEvent)) === -1)
+        })
       };
 
       const preparedWinnerParams = Object.assign({adServerTargeting: fakeTargeting}, winner);
@@ -262,7 +265,7 @@ describe('Yieldone Prebid Analytic', function () {
 
       events.emit(constants.EVENTS.AUCTION_END, auctionEnd);
 
-      expect(yieldoneAnalytics.eventsStorage[auctionId]).to.deep.equal(expectedResult);
+      sinon.assert.match(yieldoneAnalytics.eventsStorage[auctionId], expectedResult);
 
       delete yieldoneAnalytics.eventsStorage[auctionId];