prebid.js 7.26.0 → 7.27.0

package/test/spec/modules/seedtagBidAdapter_spec.js

@@ -25,11 +25,11 @@ function getSlotConfigs(mediaTypes, params) {
   };
 }
 
-function createVideoSlotConfig(mediaType) {
+function createInStreamSlotConfig(mediaType) {
   return getSlotConfigs(mediaType, {
     publisherId: PUBLISHER_ID,
     adUnitId: ADUNIT_ID,
-    placement: 'video',
+    placement: 'inStream',
   });
 }
 
@@ -48,13 +48,7 @@ describe('Seedtag Adapter', function () {
               }
             );
           };
-          const placements = [
-            'banner',
-            'video',
-            'inImage',
-            'inScreen',
-            'inArticle',
-          ];
+          const placements = ['inBanner', 'inImage', 'inScreen', 'inArticle'];
           placements.forEach((placement) => {
             it('should be ' + placement, function () {
               const isBidRequestValid = spec.isBidRequestValid(
@@ -67,39 +61,41 @@ describe('Seedtag Adapter', function () {
       });
       describe('when video slot has all mandatory params', function () {
         it('should return true, when video context is instream', function () {
-          const slotConfig = getSlotConfigs(
-            {
-              video: {
-                context: 'instream',
-                playerSize: [[600, 200]],
-              },
+          const slotConfig = createInStreamSlotConfig({
+            video: {
+              context: 'instream',
+              playerSize: [[600, 200]],
             },
-            {
-              publisherId: PUBLISHER_ID,
-              adUnitId: ADUNIT_ID,
-              placement: 'video',
-            }
-          );
+          });
           const isBidRequestValid = spec.isBidRequestValid(slotConfig);
           expect(isBidRequestValid).to.equal(true);
         });
-
-        it('should return true, when video context is outstream', function () {
+        it('should return true, when video context is instream, but placement is not inStream', function () {
           const slotConfig = getSlotConfigs(
             {
               video: {
-                context: 'outstream',
+                context: 'instream',
                 playerSize: [[600, 200]],
               },
             },
             {
               publisherId: PUBLISHER_ID,
               adUnitId: ADUNIT_ID,
-              placement: 'video',
+              placement: 'inBanner',
             }
           );
           const isBidRequestValid = spec.isBidRequestValid(slotConfig);
-          expect(isBidRequestValid).to.equal(true);
+          expect(isBidRequestValid).to.equal(false);
+        });
+        it('should return false, when video context is outstream', function () {
+          const slotConfig = createInStreamSlotConfig({
+            video: {
+              context: 'outstream',
+              playerSize: [[600, 200]],
+            },
+          });
+          const isBidRequestValid = spec.isBidRequestValid(slotConfig);
+          expect(isBidRequestValid).to.equal(false);
         });
       });
     });
@@ -112,7 +108,7 @@ describe('Seedtag Adapter', function () {
           const isBidRequestValid = spec.isBidRequestValid(
             createSlotConfig({
               adUnitId: ADUNIT_ID,
-              placement: 'banner',
+              placement: 'inBanner',
             })
           );
           expect(isBidRequestValid).to.equal(false);
@@ -121,7 +117,7 @@ describe('Seedtag Adapter', function () {
           const isBidRequestValid = spec.isBidRequestValid(
             createSlotConfig({
               publisherId: PUBLISHER_ID,
-              placement: 'banner',
+              placement: 'inBanner',
             })
           );
           expect(isBidRequestValid).to.equal(false);
@@ -146,47 +142,41 @@ describe('Seedtag Adapter', function () {
           expect(isBidRequestValid).to.equal(false);
         });
       });
+
       describe('when video mediaType object is not correct', function () {
-        function createVideoSlotconfig(mediaType) {
-          return getSlotConfigs(mediaType, {
-            publisherId: PUBLISHER_ID,
-            adUnitId: ADUNIT_ID,
-            placement: 'video',
-          });
-        }
         it('is a void object', function () {
           const isBidRequestValid = spec.isBidRequestValid(
-            createVideoSlotConfig({ video: {} })
+            createInStreamSlotConfig({ video: {} })
           );
           expect(isBidRequestValid).to.equal(false);
         });
         it('does not have playerSize.', function () {
           const isBidRequestValid = spec.isBidRequestValid(
-            createVideoSlotConfig({ video: { context: 'instream' } })
+            createInStreamSlotConfig({ video: { context: 'instream' } })
           );
           expect(isBidRequestValid).to.equal(false);
         });
         it('is outstream ', function () {
           const isBidRequestValid = spec.isBidRequestValid(
-            createVideoSlotConfig({
+            createInStreamSlotConfig({
               video: {
                 context: 'outstream',
                 playerSize: [[600, 200]],
               },
             })
           );
-          expect(isBidRequestValid).to.equal(true);
+          expect(isBidRequestValid).to.equal(false);
         });
         describe('order does not matter', function () {
           it('when video is not the first slot', function () {
             const isBidRequestValid = spec.isBidRequestValid(
-              createVideoSlotConfig({ banner: {}, video: {} })
+              createInStreamSlotConfig({ banner: {}, video: {} })
             );
             expect(isBidRequestValid).to.equal(false);
           });
           it('when video is the first slot', function () {
             const isBidRequestValid = spec.isBidRequestValid(
-              createVideoSlotConfig({ video: {}, banner: {} })
+              createInStreamSlotConfig({ video: {}, banner: {} })
             );
             expect(isBidRequestValid).to.equal(false);
           });
@@ -200,21 +190,27 @@ describe('Seedtag Adapter', function () {
       refererInfo: { page: 'referer' },
       timeout: 1000,
     };
-    const mandatoryParams = {
+    const mandatoryDisplayParams = {
       publisherId: PUBLISHER_ID,
       adUnitId: ADUNIT_ID,
-      placement: 'banner',
+      placement: 'inBanner',
+    };
+    const mandatoryVideoParams = {
+      publisherId: PUBLISHER_ID,
+      adUnitId: ADUNIT_ID,
+      placement: 'inStream',
     };
-    const inStreamParams = Object.assign({}, mandatoryParams, {
-      video: {
-        mimes: 'mp4',
-      },
-    });
     const validBidRequests = [
-      getSlotConfigs({ banner: {} }, mandatoryParams),
+      getSlotConfigs({ banner: {} }, mandatoryDisplayParams),
       getSlotConfigs(
-        { video: { context: 'instream', playerSize: [[300, 200]] } },
-        inStreamParams
+        {
+          video: {
+            context: 'instream',
+            playerSize: [[300, 200]],
+            mimes: ['video/mp4'],
+          },
+        },
+        mandatoryVideoParams
       ),
     ];
     it('Url params should be correct ', function () {
@@ -239,26 +235,6 @@ describe('Seedtag Adapter', function () {
       expect(data.bidRequests[0].adUnitCode).to.equal('adunit-code');
     });
 
-    describe('adPosition param', function () {
-      it('should sended when publisher set adPosition param', function () {
-        const params = Object.assign({}, mandatoryParams, {
-          adPosition: 1,
-        });
-        const validBidRequests = [getSlotConfigs({ banner: {} }, params)];
-        const request = spec.buildRequests(validBidRequests, bidderRequest);
-        const data = JSON.parse(request.data);
-        expect(data.bidRequests[0].adPosition).to.equal(1);
-      });
-      it('should not sended when publisher has not set adPosition param', function () {
-        const validBidRequests = [
-          getSlotConfigs({ banner: {} }, mandatoryParams),
-        ];
-        const request = spec.buildRequests(validBidRequests, bidderRequest);
-        const data = JSON.parse(request.data);
-        expect(data.bidRequests[0].adPosition).to.equal(undefined);
-      });
-    });
-
     describe('GDPR params', function () {
       describe('when there arent consent management platform', function () {
         it('cmp should be false', function () {
@@ -310,10 +286,7 @@ describe('Seedtag Adapter', function () {
 
           bidderRequest['uspConsent'] = uspConsent;
 
-          const request = spec.buildRequests(
-            validBidRequests,
-            bidderRequest
-          );
+          const request = spec.buildRequests(validBidRequests, bidderRequest);
           const payload = JSON.parse(request.data);
 
           expect(payload.uspConsent).to.not.exist;
@@ -347,7 +320,7 @@ describe('Seedtag Adapter', function () {
         );
         expect(videoBid.supplyTypes[0]).to.equal('video');
         expect(videoBid.adUnitId).to.equal('000000');
-        expect(videoBid.videoParams.mimes).to.equal('mp4');
+        expect(videoBid.videoParams.mimes).to.eql(['video/mp4']);
         expect(videoBid.videoParams.w).to.equal(300);
         expect(videoBid.videoParams.h).to.equal(200);
         expect(videoBid.sizes[0][0]).to.equal(300);
@@ -360,27 +333,27 @@ describe('Seedtag Adapter', function () {
 
     describe('COPPA param', function () {
       it('should add COPPA param to payload when prebid config has parameter COPPA equal to true', function () {
-        config.setConfig({ coppa: true })
+        config.setConfig({ coppa: true });
 
         const request = spec.buildRequests(validBidRequests, bidderRequest);
         const data = JSON.parse(request.data);
         expect(data.coppa).to.equal(true);
-      })
+      });
 
       it('should not add COPPA param to payload when prebid config has parameter COPPA equal to false', function () {
-        config.setConfig({ coppa: false })
+        config.setConfig({ coppa: false });
 
         const request = spec.buildRequests(validBidRequests, bidderRequest);
         const data = JSON.parse(request.data);
         expect(data.coppa).to.be.undefined;
-      })
+      });
 
       it('should not add COPPA param to payload when prebid config has not parameter COPPA', function () {
         const request = spec.buildRequests(validBidRequests, bidderRequest);
         const data = JSON.parse(request.data);
         expect(data.coppa).to.be.undefined;
-      })
-    })
+      });
+    });
     describe('schain param', function () {
       it('should add schain to payload when exposed on validBidRequest', function () {
         // https://github.com/prebid/Prebid.js/blob/master/modules/schain.md#sample-code-for-passing-the-schain-object
@@ -560,11 +533,11 @@ describe('Seedtag Adapter', function () {
       const timeoutUrl = getTimeoutUrl(timeoutData);
       expect(timeoutUrl).to.equal(
         'https://s.seedtag.com/se/hb/timeout?publisherToken=' +
-        params.publisherId +
-        '&adUnitId=' +
-        params.adUnitId +
-        '&timeout=' +
-        timeout
+          params.publisherId +
+          '&adUnitId=' +
+          params.adUnitId +
+          '&timeout=' +
+          timeout
       );
     });
 
@@ -576,11 +549,11 @@ describe('Seedtag Adapter', function () {
       expect(
         utils.triggerPixel.calledWith(
           'https://s.seedtag.com/se/hb/timeout?publisherToken=' +
-          params.publisherId +
-          '&adUnitId=' +
-          params.adUnitId +
-          '&timeout=' +
-          timeout
+            params.publisherId +
+            '&adUnitId=' +
+            params.adUnitId +
+            '&timeout=' +
+            timeout
         )
       ).to.equal(true);
     });

package/test/spec/modules/sigmoidAnalyticsAdapter_spec.js

@@ -1,5 +1,7 @@
 import sigmoidAnalytic from 'modules/sigmoidAnalyticsAdapter.js';
-import { expect } from 'chai';
+import {expect} from 'chai';
+import {expectEvents} from '../../helpers/analytics.js';
+
 let events = require('src/events');
 let adapterManager = require('src/adapterManager').default;
 let constants = require('src/constants.json');
@@ -32,13 +34,7 @@ describe('sigmoid Prebid Analytic', function () {
         }
       });
 
-      events.emit(constants.EVENTS.AUCTION_INIT, {});
-      events.emit(constants.EVENTS.AUCTION_END, {});
-      events.emit(constants.EVENTS.BID_REQUESTED, {});
-      events.emit(constants.EVENTS.BID_RESPONSE, {});
-      events.emit(constants.EVENTS.BID_WON, {});
-
-      sinon.assert.callCount(sigmoidAnalytic.track, 8);
+      expectEvents().to.beTrackedBy(sigmoidAnalytic.track);
     });
   });
   describe('build utm tag data', function () {

package/test/spec/modules/sovrnAnalyticsAdapter_spec.js

@@ -1,8 +1,10 @@
 import sovrnAnalyticsAdapter from '../../../modules/sovrnAnalyticsAdapter.js';
-import { expect } from 'chai';
+import {expect} from 'chai';
 import {config} from 'src/config.js';
 import adaptermanager from 'src/adapterManager.js';
-import { server } from 'test/mocks/xhr.js';
+import {server} from 'test/mocks/xhr.js';
+import {expectEvents, fireEvents} from '../../helpers/analytics.js';
+
 var assert = require('assert');
 
 let events = require('src/events');
@@ -195,15 +197,7 @@ describe('Sovrn Analytics Adapter', function () {
           sovrnId: 123
         }
       });
-
-      events.emit(constants.EVENTS.AUCTION_INIT, {});
-      events.emit(constants.EVENTS.AUCTION_END, {});
-      events.emit(constants.EVENTS.BID_REQUESTED, {});
-      events.emit(constants.EVENTS.BID_RESPONSE, {});
-      events.emit(constants.EVENTS.BID_WON, {});
-
-      // 5 SovrnAnalytics events + 1 Clean.io event
-      sinon.assert.callCount(sovrnAnalyticsAdapter.track, 6);
+      expectEvents().to.beTrackedBy(sovrnAnalyticsAdapter.track);
     });
 
     it('should catch no events if no affiliate id', function () {
@@ -212,13 +206,7 @@ describe('Sovrn Analytics Adapter', function () {
         options: {
         }
       });
-
-      events.emit(constants.EVENTS.AUCTION_INIT, {});
-      events.emit(constants.EVENTS.AUCTION_END, {});
-      events.emit(constants.EVENTS.BID_REQUESTED, {});
-      events.emit(constants.EVENTS.BID_RESPONSE, {});
-      events.emit(constants.EVENTS.BID_WON, {});
-
+      fireEvents();
       sinon.assert.callCount(sovrnAnalyticsAdapter.track, 0);
     });
   });

package/test/spec/modules/tripleliftBidAdapter_spec.js

@@ -979,19 +979,12 @@ describe('triplelift adapter', function () {
       expect(url).to.match(new RegExp('(?:' + prebid.version + ')'))
       expect(url).to.match(/(?:referrer)/);
     });
-    it('should prioritize topmostLocation for referrer', function () {
-      bidderRequest.refererInfo.topmostLocation = 'https://topmostlocation.com?foo=bar'
+    it('should use refererInfo.page for referrer', function () {
+      bidderRequest.refererInfo.page = 'https://topmostlocation.com?foo=bar'
       const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
       const url = request.url;
       expect(url).to.match(/(\?|&)referrer=https%3A%2F%2Ftopmostlocation.com%3Ffoo%3Dbar/);
-      delete bidderRequest.refererInfo.topmostLocation
-    });
-    it('should fall back to page for referrer if topmostLocation is unavailable', function () {
-      bidderRequest.refererInfo.topmostLocation = null
-      const request = tripleliftAdapterSpec.buildRequests(bidRequests, bidderRequest);
-      const url = request.url;
-      expect(url).to.match(/(\?|&)referrer=https%3A%2F%2Fexamplereferer.com/);
-      delete bidderRequest.refererInfo.topmostLocation
+      delete bidderRequest.refererInfo.page
     });
     it('should return us_privacy param when CCPA info is available', function() {
       bidderRequest.uspConsent = '1YYY';

package/test/spec/modules/ttdBidAdapter_spec.js

@@ -400,6 +400,20 @@ describe('ttdBidAdapter', function () {
       expect(requestBody.regs.coppa).to.equal(1);
     });
 
+    it('adds gpp consent info to the request', function () {
+      const ortb2 = {
+        regs: {
+          gpp: 'somegppstring',
+          gpp_sid: [6, 7]
+        }
+      };
+      let clonedBidderRequest = {...deepClone(baseBidderRequest), ortb2};
+      const requestBody = testBuildRequests(baseBannerBidRequests, clonedBidderRequest).data;
+      config.resetConfig();
+      expect(requestBody.regs.gpp).to.equal('somegppstring');
+      expect(requestBody.regs.gpp_sid).to.eql([6, 7]);
+    });
+
     it('adds schain info to the request', function () {
       const schain = {
         'ver': '1.0',

package/test/spec/modules/vidazooBidAdapter_spec.js

@@ -1,4 +1,4 @@
-import {expect} from 'chai';
+import { expect } from 'chai';
 import {
   spec as adapter,
   SUPPORTED_ID_SYSTEMS,
@@ -15,8 +15,8 @@ import {
   getVidazooSessionId,
 } from 'modules/vidazooBidAdapter.js';
 import * as utils from 'src/utils.js';
-import {version} from 'package.json';
-import {useFakeTimers} from 'sinon';
+import { version } from 'package.json';
+import { useFakeTimers } from 'sinon';
 
 const SUB_DOMAIN = 'openrtb';
 
@@ -38,7 +38,12 @@ const BID = {
   'sizes': [[300, 250], [300, 600]],
   'bidderRequestId': '1fdb5ff1b6eaa7',
   'requestId': 'b0777d85-d061-450e-9bc7-260dd54bbb7a',
-  'schain': 'a0819c69-005b-41ed-af06-1be1e0aefefc'
+  'schain': 'a0819c69-005b-41ed-af06-1be1e0aefefc',
+  'ortb2Imp': {
+    'ext': {
+      'gpid': '1234567890'
+    }
+  }
 };
 
 const BIDDER_REQUEST = {
@@ -50,7 +55,13 @@ const BIDDER_REQUEST = {
   'refererInfo': {
     'page': 'https://www.greatsite.com',
     'ref': 'https://www.somereferrer.com'
-  }
+  },
+  'ortb2': {
+    'site': {
+      'cat': ['IAB2'],
+      'pagecat': ['IAB2-2']
+    }
+  },
 };
 
 const SERVER_RESPONSE = {
@@ -85,7 +96,7 @@ const REQUEST = {
 
 function getTopWindowQueryParams() {
   try {
-    const parsedUrl = utils.parseUrl(window.top.document.URL, {decodeSearchAsString: true});
+    const parsedUrl = utils.parseUrl(window.top.document.URL, { decodeSearchAsString: true });
     return parsedUrl.search;
   } catch (e) {
     return '';
@@ -150,7 +161,7 @@ describe('VidazooBidAdapter', function () {
     before(function () {
       $$PREBID_GLOBAL$$.bidderSettings = {
         vidazoo: {
-          storageAllowed: true
+          storageAllowed: true,
         }
       };
       sandbox = sinon.sandbox.create();
@@ -187,6 +198,10 @@ describe('VidazooBidAdapter', function () {
           uqs: getTopWindowQueryParams(),
           'ext.param1': 'loremipsum',
           'ext.param2': 'dolorsitamet',
+          isStorageAllowed: true,
+          gpid: '1234567890',
+          cat: ['IAB2'],
+          pagecat: ['IAB2-2']
         }
       });
     });
@@ -198,7 +213,7 @@ describe('VidazooBidAdapter', function () {
   });
   describe('getUserSyncs', function () {
     it('should have valid user sync with iframeEnabled', function () {
-      const result = adapter.getUserSyncs({iframeEnabled: true}, [SERVER_RESPONSE]);
+      const result = adapter.getUserSyncs({ iframeEnabled: true }, [SERVER_RESPONSE]);
 
       expect(result).to.deep.equal([{
         type: 'iframe',
@@ -207,7 +222,7 @@ describe('VidazooBidAdapter', function () {
     });
 
     it('should have valid user sync with cid on response', function () {
-      const result = adapter.getUserSyncs({iframeEnabled: true}, [SERVER_RESPONSE]);
+      const result = adapter.getUserSyncs({ iframeEnabled: true }, [SERVER_RESPONSE]);
       expect(result).to.deep.equal([{
         type: 'iframe',
         url: 'https://sync.cootlogix.com/api/sync/iframe/?cid=testcid123&gdpr=0&gdpr_consent=&us_privacy='
@@ -215,7 +230,7 @@ describe('VidazooBidAdapter', function () {
     });
 
     it('should have valid user sync with pixelEnabled', function () {
-      const result = adapter.getUserSyncs({pixelEnabled: true}, [SERVER_RESPONSE]);
+      const result = adapter.getUserSyncs({ pixelEnabled: true }, [SERVER_RESPONSE]);
 
       expect(result).to.deep.equal([{
         'url': 'https://sync.cootlogix.com/api/sync/image/?cid=testcid123&gdpr=0&gdpr_consent=&us_privacy=',
@@ -231,12 +246,12 @@ describe('VidazooBidAdapter', function () {
     });
 
     it('should return empty array when there is no ad', function () {
-      const responses = adapter.interpretResponse({price: 1, ad: ''});
+      const responses = adapter.interpretResponse({ price: 1, ad: '' });
       expect(responses).to.be.empty;
     });
 
     it('should return empty array when there is no price', function () {
-      const responses = adapter.interpretResponse({price: null, ad: 'great ad'});
+      const responses = adapter.interpretResponse({ price: null, ad: 'great ad' });
       expect(responses).to.be.empty;
     });
 
@@ -276,11 +291,11 @@ describe('VidazooBidAdapter', function () {
       const userId = (function () {
         switch (idSystemProvider) {
           case 'lipb':
-            return {lipbid: id};
+            return { lipbid: id };
           case 'parrableId':
-            return {eid: id};
+            return { eid: id };
           case 'id5id':
-            return {uid: id};
+            return { uid: id };
           default:
             return id;
         }
@@ -299,18 +314,18 @@ describe('VidazooBidAdapter', function () {
 
   describe('alternate param names extractors', function () {
     it('should return undefined when param not supported', function () {
-      const cid = extractCID({'c_id': '1'});
-      const pid = extractPID({'p_id': '1'});
-      const subDomain = extractSubDomain({'sub_domain': 'prebid'});
+      const cid = extractCID({ 'c_id': '1' });
+      const pid = extractPID({ 'p_id': '1' });
+      const subDomain = extractSubDomain({ 'sub_domain': 'prebid' });
       expect(cid).to.be.undefined;
       expect(pid).to.be.undefined;
       expect(subDomain).to.be.undefined;
     });
 
     it('should return value when param supported', function () {
-      const cid = extractCID({'cID': '1'});
-      const pid = extractPID({'Pid': '2'});
-      const subDomain = extractSubDomain({'subDOMAIN': 'prebid'});
+      const cid = extractCID({ 'cID': '1' });
+      const pid = extractPID({ 'Pid': '2' });
+      const subDomain = extractSubDomain({ 'subDOMAIN': 'prebid' });
       expect(cid).to.be.equal('1');
       expect(pid).to.be.equal('2');
       expect(subDomain).to.be.equal('prebid');
@@ -423,7 +438,7 @@ describe('VidazooBidAdapter', function () {
         now
       });
       setStorageItem('myKey', 2020);
-      const {value, created} = getStorageItem('myKey');
+      const { value, created } = getStorageItem('myKey');
       expect(created).to.be.equal(now);
       expect(value).to.be.equal(2020);
       expect(typeof value).to.be.equal('number');
@@ -439,8 +454,8 @@ describe('VidazooBidAdapter', function () {
     });
 
     it('should parse JSON value', function () {
-      const data = JSON.stringify({event: 'send'});
-      const {event} = tryParseJSON(data);
+      const data = JSON.stringify({ event: 'send' });
+      const { event } = tryParseJSON(data);
       expect(event).to.be.equal('send');
     });
 

package/test/spec/modules/yandexBidAdapter_spec.js

@@ -1,15 +1,14 @@
-import {assert, expect} from 'chai';
-import {spec} from 'modules/yandexBidAdapter.js';
-import {parseUrl} from 'src/utils.js';
-import {BANNER} from '../../../src/mediaTypes';
+import { assert, expect } from 'chai';
+import { spec } from 'modules/yandexBidAdapter.js';
+import { parseUrl } from 'src/utils.js';
+import { BANNER } from '../../../src/mediaTypes';
 
 describe('Yandex adapter', function () {
   function getBidConfig() {
     return {
       bidder: 'yandex',
       params: {
-        pageId: 123,
-        impId: 1,
+        placementId: '123-1',
       },
     };
   }
@@ -32,7 +31,7 @@ describe('Yandex adapter', function () {
 
   describe('isBidRequestValid', function () {
     it('should return true when required params found', function () {
-      const bid = getBidConfig();
+      const bid = getBidRequest();
       assert(spec.isBidRequestValid(bid));
     });
 
@@ -40,18 +39,28 @@ describe('Yandex adapter', function () {
       expect(spec.isBidRequestValid({})).to.be.false;
     });
 
-    it('should return false when required params.pageId are not passed', function () {
+    it('should return false when required params.placementId are not passed', function () {
+      const bid = getBidConfig();
+      delete bid.params.placementId;
+
+      expect(spec.isBidRequestValid(bid)).to.be.false;
+    });
+
+    it('should return false when required params.placementId are not valid', function () {
       const bid = getBidConfig();
-      delete bid.params.pageId;
+      bid.params.placementId = '123';
 
-      expect(spec.isBidRequestValid(bid)).to.be.false
+      expect(spec.isBidRequestValid(bid)).to.be.false;
     });
 
-    it('should return false when required params.impId are not passed', function () {
+    it('should return true when passed deprecated placement config', function () {
       const bid = getBidConfig();
-      delete bid.params.impId;
+      delete bid.params.placementId;
+
+      bid.params.pageId = 123;
+      bid.params.impId = 1;
 
-      expect(spec.isBidRequestValid(bid)).to.be.false
+      expect(spec.isBidRequestValid(bid));
     });
   });