prebid.js 7.20.0 → 7.22.0

package/test/spec/modules/eids_spec.js

@@ -444,11 +444,15 @@ describe('eids array generation for known sub-modules', function() {
 
   describe('ftrackId', () => {
     it('should return the correct EID schema', () => {
+      // This is the schema returned from the ftrack decode() method
       expect(createEidsArray({
         ftrackId: {
-          DeviceID: ['aaa', 'bbb'],
-          SingleDeviceID: ['ccc', 'ddd'],
-          HHID: ['eee', 'fff']
+          uid: 'test-device-id',
+          ext: {
+            DeviceID: 'test-device-id',
+            SingleDeviceID: 'test-single-device-id',
+            HHID: 'test-household-id'
+          }
         },
         foo: {
           bar: 'baz'
@@ -458,11 +462,11 @@ describe('eids array generation for known sub-modules', function() {
         }
       })).to.deep.equal([{
         atype: 1,
-        id: 'aaa|bbb',
+        id: 'test-device-id',
         ext: {
-          DeviceID: 'aaa|bbb',
-          SingleDeviceID: 'ccc|ddd',
-          HHID: 'eee|fff'
+          DeviceID: 'test-device-id',
+          SingleDeviceID: 'test-single-device-id',
+          HHID: 'test-household-id'
         }
       }]);
     });

package/test/spec/modules/freewheel-sspBidAdapter_spec.js

@@ -483,6 +483,23 @@ describe('freewheelSSP BidAdapter Test', () => {
         'bidId': '2',
         'bidderRequestId': '3',
         'auctionId': '4',
+      },
+      {
+        'bidder': 'freewheelssp',
+        'params': {
+          'zoneId': '277225',
+          'format': 'test'
+        },
+        'adUnitCode': 'adunit-code',
+        'mediaTypes': {
+          'video': {
+            'playerSize': [300, 600],
+          }
+        },
+        'sizes': [[300, 400]],
+        'bidId': '2',
+        'bidderRequestId': '3',
+        'auctionId': '4',
       }
     ];
 
@@ -510,7 +527,8 @@ describe('freewheelSSP BidAdapter Test', () => {
     '   </Creatives>' +
     '   <Extensions>' +
     '     <Extension type=\'StickyPricing\'><Price currency="EUR">0.2000</Price></Extension>' +
-    '    </Extensions>' +
+    '     <Extension type=\'StickyBrand\'><Domain><![CDATA[minotaur.com]]></Domain><Sector><![CDATA[BEAUTY & HYGIENE]]></Sector><Advertiser><![CDATA[James Bond Trademarks]]></Advertiser><Brand><![CDATA[007 Seven]]></Brand></Extension>' +
+    '   </Extensions>' +
     '  </InLine>' +
     ' </Ad>' +
     '</VAST>';
@@ -536,12 +554,15 @@ describe('freewheelSSP BidAdapter Test', () => {
           bannerId: '12345',
           vastXml: response,
           mediaType: 'video',
-          ad: ad
+          ad: ad,
+          meta: {
+            advertiserDomains: 'minotaur.com'
+          }
         }
       ];
 
       let result = spec.interpretResponse(response, request[0]);
-      expect(result[0].meta.advertiserDomains).to.deep.equal([]);
+      expect(result[0].meta.advertiserDomains).to.deep.equal(['minotaur.com']);
       expect(result[0].dealId).to.equal('NRJ-PRO-00008');
       expect(result[0].campaignId).to.equal('SMF-WOW-55555');
       expect(result[0].bannerId).to.equal('12345');
@@ -570,7 +591,7 @@ describe('freewheelSSP BidAdapter Test', () => {
       ];
 
       let result = spec.interpretResponse(response, request[0]);
-      expect(result[0].meta.advertiserDomains).to.deep.equal([]);
+      expect(result[0].meta.advertiserDomains).to.deep.equal(['minotaur.com']);
       expect(result[0].dealId).to.equal('NRJ-PRO-00008');
       expect(result[0].campaignId).to.equal('SMF-WOW-55555');
       expect(result[0].bannerId).to.equal('12345');

package/test/spec/modules/ftrackIdSystem_spec.js

@@ -275,10 +275,55 @@ describe('FTRACK ID System', () => {
 
   describe(`decode() method`, () => {
     it(`should respond with an object with the key 'ftrackId'`, () => {
-      expect(ftrackIdSubmodule.decode('value', configMock)).to.deep.equal({
+      const MOCK_VALUE_STRINGS = {
+          HHID: 'household_test_id',
+          DeviceID: 'device_test_id',
+          SingleDeviceID: 'single_device_test_id'
+        },
+        MOCK_VALUE_ARRAYS = {
+          HHID: ['household_test_id', 'a', 'b'],
+          DeviceID: ['device_test_id', 'c', 'd'],
+          SingleDeviceID: ['single_device_test_id', 'e', 'f']
+        },
+        MOCK_VALUE_BOTH = {
+          foo: ['foo', 'a', 'b'],
+          bar: 'bar',
+          baz: ['baz', 'baz', 'baz']
+        };
+
+      // strings are just passed through
+      expect(ftrackIdSubmodule.decode(MOCK_VALUE_STRINGS, configMock)).to.deep.equal({
+        ftrackId: {
+          ext: {
+            HHID: 'household_test_id',
+            DeviceID: 'device_test_id',
+            SingleDeviceID: 'single_device_test_id'
+          },
+          uid: 'device_test_id',
+        },
+      });
+
+      // arrays are converted to strings
+      expect(ftrackIdSubmodule.decode(MOCK_VALUE_ARRAYS, configMock)).to.deep.equal({
         ftrackId: {
-          ext: { 0: 'v', 1: 'a', 2: 'l', 3: 'u', 4: 'e' },
-          uid: undefined,
+          ext: {
+            HHID: 'household_test_id|a|b',
+            DeviceID: 'device_test_id|c|d',
+            SingleDeviceID: 'single_device_test_id|e|f'
+          },
+          uid: 'device_test_id|c|d',
+        },
+      });
+
+      // mix of both but uid should be empty string because DeviceId is not defined
+      expect(ftrackIdSubmodule.decode(MOCK_VALUE_BOTH, configMock)).to.deep.equal({
+        ftrackId: {
+          ext: {
+            foo: 'foo|a|b',
+            bar: 'bar',
+            baz: 'baz|baz|baz'
+          },
+          uid: '',
         },
       });
     });
@@ -309,56 +354,40 @@ describe('FTRACK ID System', () => {
   });
 
   describe('pbjs "get id" methods', () => {
-    // The full set of ftrack IDs to test against
-    let expectedIds = {
-      HHID: ['household_test_id'],
-      DeviceID: ['device_test_id'],
-      SingleDeviceID: ['single_device_test_id']
-    };
-    // The full config mock
-    let userSyncConfigMock = {
-      userSync: {
-        auctionDelay: 10,
-        userIds: [{
-          name: 'ftrack',
-          value: {
-            ftrackId: expectedIds
-          }
-        }]
-      }
-    };
-    // The full eids response
-    let expectedEids = [{
-      id: 'device_test_id',
-      atype: 1,
-      ext: {
-        HHID: expectedIds.HHID.join('|'),
-        DeviceID: expectedIds.DeviceID.join('|'),
-        SingleDeviceID: expectedIds.SingleDeviceID.join('|')
-      }
-    }];
-
     beforeEach(() => {
       init(config);
       setSubmoduleRegistry([ftrackIdSubmodule]);
     });
 
-    afterEach(() => {
-      // Reset expectedIds to the default values because some tests overwrite them
-      expectedIds = {
-        HHID: ['household_test_id'],
-        DeviceID: ['device_test_id'],
-        SingleDeviceID: ['single_device_test_id']
-      };
-    });
-
     describe('pbjs.getUserIdsAsync()', () => {
-      it('should return the IDs in the correct schema', () => {
-        config.setConfig(userSyncConfigMock);
+      it('should return the IDs in the correct schema - flat schema', () => {
+        config.setConfig({
+          userSync: {
+            auctionDelay: 10,
+            userIds: [{
+              name: 'ftrack',
+              value: {
+                ftrackId: {
+                  uid: 'device_test_id',
+                  ext: {
+                    HHID: 'household_test_id',
+                    DeviceID: 'device_test_id',
+                    SingleDeviceID: 'single_device_test_id'
+                  }
+                }
+              }
+            }]
+          }
+        });
 
         getGlobal().getUserIdsAsync().then(ids => {
           expect(ids).to.deep.equal({
-            ftrackId: expectedIds
+            uid: 'device_test_id',
+            ftrackId: {
+              HHID: 'household_test_id',
+              DeviceID: 'device_test_id',
+              SingleDeviceID: 'single_device_test_id'
+            }
           });
         });
       });
@@ -366,73 +395,154 @@ describe('FTRACK ID System', () => {
 
     describe('pbjs.getUserIds()', () => {
       it('should return the IDs in the correct schema', () => {
-        config.setConfig(userSyncConfigMock);
+        config.setConfig({
+          userSync: {
+            auctionDelay: 10,
+            userIds: [{
+              name: 'ftrack',
+              value: {
+                ftrackId: {
+                  uid: 'device_test_id',
+                  ext: {
+                    HHID: 'household_test_id',
+                    DeviceID: 'device_test_id',
+                    SingleDeviceID: 'single_device_test_id'
+                  }
+                }
+              }
+            }]
+          }
+        });
 
         expect(getGlobal().getUserIds()).to.deep.equal({
-          'ftrackId': expectedIds
+          ftrackId: {
+            uid: 'device_test_id',
+            ext: {
+              HHID: 'household_test_id',
+              DeviceID: 'device_test_id',
+              SingleDeviceID: 'single_device_test_id'
+            }
+          }
         });
       });
     });
 
     describe('pbjs.getUserIdsAsEids()', () => {
-      it('should return the correct EIDs schema', () => {
-        let userSyncConfig = Object.assign({}, userSyncConfigMock);
-
-        config.setConfig(userSyncConfig);
+      it('should return the correct EIDs schema ', () => {
+        // Pass all three IDs
+        config.setConfig({
+          userSync: {
+            auctionDelay: 10,
+            userIds: [{
+              name: 'ftrack',
+              value: {
+                ftrackId: {
+                  uid: 'device_test_id',
+                  ext: {
+                    HHID: 'household_test_id',
+                    DeviceID: 'device_test_id',
+                    SingleDeviceID: 'single_device_test_id'
+                  }
+                }
+              }
+            }]
+          }
+        });
 
-        expect(getGlobal().getUserIdsAsEids()).to.deep.equal(expectedEids);
+        expect(getGlobal().getUserIdsAsEids()).to.deep.equal([{
+          id: 'device_test_id',
+          atype: 1,
+          ext: {
+            HHID: 'household_test_id',
+            DeviceID: 'device_test_id',
+            SingleDeviceID: 'single_device_test_id'
+          }
+        }]);
       });
 
       describe('by ID type:', () => {
         it('- DeviceID', () => {
-          let userSyncConfig = Object.assign({}, userSyncConfigMock);
-
-          userSyncConfig.userSync.userIds[0].value.ftrackId = {
-            DeviceID: ['device_test_id']
-          };
-
-          let expectedEidsClone = expectedEids.slice();
-          expectedEidsClone[0].ext = {
-            DeviceID: expectedIds.DeviceID.join('|')
-          };
-
-          config.setConfig(userSyncConfig);
+          // Pass DeviceID only
+          config.setConfig({
+            userSync: {
+              auctionDelay: 10,
+              userIds: [{
+                name: 'ftrack',
+                value: {
+                  ftrackId: {
+                    uid: 'device_test_id',
+                    ext: {
+                      DeviceID: 'device_test_id',
+                    }
+                  }
+                }
+              }]
+            }
+          });
 
-          expect(getGlobal().getUserIdsAsEids()).to.deep.equal(expectedEidsClone);
+          expect(getGlobal().getUserIdsAsEids()).to.deep.equal([{
+            id: 'device_test_id',
+            atype: 1,
+            ext: {
+              DeviceID: 'device_test_id'
+            }
+          }]);
         });
 
         it('- HHID', () => {
-          let userSyncConfig = Object.assign({}, userSyncConfigMock);
-          userSyncConfig.userSync.userIds[0].value.ftrackId = {
-            HHID: ['household_test_id']
-          };
-
-          let expectedEidsClone = expectedEids.slice();
-          expectedEidsClone[0].id = '';
-          expectedEidsClone[0].ext = {
-            HHID: expectedIds.HHID.join('|')
-          };
-
-          config.setConfig(userSyncConfig);
+          // Pass HHID only
+          config.setConfig({
+            userSync: {
+              auctionDelay: 10,
+              userIds: [{
+                name: 'ftrack',
+                value: {
+                  ftrackId: {
+                    uid: '',
+                    ext: {
+                      HHID: 'household_test_id'
+                    }
+                  }
+                }
+              }]
+            }
+          });
 
-          expect(getGlobal().getUserIdsAsEids()).to.deep.equal(expectedEidsClone);
+          expect(getGlobal().getUserIdsAsEids()).to.deep.equal([{
+            id: '',
+            atype: 1,
+            ext: {
+              HHID: 'household_test_id'
+            }
+          }]);
         });
 
         it('- SingleDeviceID', () => {
-          let userSyncConfig = Object.assign({}, userSyncConfigMock);
-          userSyncConfig.userSync.userIds[0].value.ftrackId = {
-            SingleDeviceID: ['single_device_test_id']
-          };
-
-          let expectedEidsClone = expectedEids.slice();
-          expectedEidsClone[0].id = '';
-          expectedEidsClone[0].ext = {
-            SingleDeviceID: expectedIds.SingleDeviceID.join('|')
-          };
-
-          config.setConfig(userSyncConfig);
+          // Pass SingleDeviceID only
+          config.setConfig({
+            userSync: {
+              auctionDelay: 10,
+              userIds: [{
+                name: 'ftrack',
+                value: {
+                  ftrackId: {
+                    uid: '',
+                    ext: {
+                      SingleDeviceID: 'single_device_test_id'
+                    }
+                  }
+                }
+              }]
+            }
+          });
 
-          expect(getGlobal().getUserIdsAsEids()).to.deep.equal(expectedEidsClone);
+          expect(getGlobal().getUserIdsAsEids()).to.deep.equal([{
+            id: '',
+            atype: 1,
+            ext: {
+              SingleDeviceID: 'single_device_test_id'
+            }
+          }]);
         });
       });
     });

package/test/spec/modules/iasRtdProvider_spec.js

@@ -54,6 +54,59 @@ describe('iasRtdProvider is a RTD provider that', function () {
       const value = iasSubModule.init(config);
       expect(value).to.equal(true);
     });
+    it('returns true with the pubId, keyMappings and adUnitPath params', function () {
+      const config = {
+        name: 'ias',
+        waitForIt: true,
+        params: {
+          pubId: '123456',
+          keyMappings: {
+            'id': 'ias_id'
+          },
+          adUnitPath: {'one-div-id': '/012345/ad/unit/path'}
+        }
+      };
+      const value = iasSubModule.init(config);
+      expect(value).to.equal(true);
+    });
+    it('returns true with the pubId and adUnitPath params with multiple keys', function () {
+      const config = {
+        name: 'ias',
+        waitForIt: true,
+        params: {
+          pubId: '123456',
+          keyMappings: {
+            'id': 'ias_id'
+          },
+          adUnitPath: {
+            'one-div-id': '/012345/ad/unit/path',
+            'another-div-id': '/012345/ad/unit/path',
+            'third-div-id': '/012345/another/ad/unit/path'
+          }
+        }
+      };
+      const value = iasSubModule.init(config);
+      expect(value).to.equal(true);
+    });
+    it('returns true with the pubId and adUnitPath params with empty values', function () {
+      const config = {
+        name: 'ias',
+        waitForIt: true,
+        params: {
+          pubId: '123456',
+          keyMappings: {
+            'id': 'ias_id'
+          },
+          adUnitPath: {
+            'one-div-id': '/012345/ad/unit/path',
+            'another-div-id': '',
+            'third-div-id': ''
+          }
+        }
+      };
+      const value = iasSubModule.init(config);
+      expect(value).to.equal(true);
+    });
   });
   describe('has a method `getBidRequestData` that', function () {
     it('exists', function () {
@@ -138,7 +191,10 @@ const config = {
     keyMappings: {
       'id': 'ias_id'
     },
-    pageUrl: 'https://integralads.com/test'
+    pageUrl: 'https://integralads.com/test',
+    adUnitPath: {
+      'one-div-id': '/012345/ad/unit/path'
+    }
   }
 };
 

package/test/spec/modules/ixBidAdapter_spec.js

@@ -1870,6 +1870,18 @@ describe('IndexexchangeAdapter', function () {
         expect(impression.banner.format[0].ext.fl).to.equal('x');
       });
 
+      it('banner multi size impression should have bidFloor both in imp and format ext obejcts', function () {
+        const bid = utils.deepClone(DEFAULT_BANNER_VALID_BID[0]);
+        bid.params.bidFloor = 50;
+        bid.params.bidFloorCur = 'USD';
+        const requestBidFloor = spec.buildRequests([bid], {})[0];
+        const impression = JSON.parse(requestBidFloor.data.r).imp[0];
+
+        expect(impression.bidfloor).to.equal(bid.params.bidFloor);
+        expect(impression.bidfloorcur).to.equal(bid.params.bidFloorCur);
+        expect(impression.banner.format[0].ext.bidfloor).to.equal(50);
+      });
+
       it('missing sizes impressions should contain floors from priceFloors module ', function () {
         const bid = utils.deepClone(ONE_BANNER[0]);
         bid.mediaTypes.banner.sizes.push([500, 400])