prebid.js 7.18.0 → 7.19.0

package/test/spec/modules/prebidServerBidAdapter_spec.js

@@ -607,15 +607,14 @@ describe('S2S Adapter', function () {
       resetSyncedStatus();
     });
 
-    it('should set id to auction ID and source.tid to tid', function () {
+    it('should set id and source.tid to auction ID', function () {
       config.setConfig({ s2sConfig: CONFIG });
 
       adapter.callBids(OUTSTREAM_VIDEO_REQUEST, BID_REQUESTS, addBidResponse, done, ajax);
 
       const requestBid = JSON.parse(server.requests[0].requestBody);
-      expect(requestBid.id).to.equal('173afb6d132ba3');
-      expect(requestBid.source).to.be.an('object');
-      expect(requestBid.source.tid).to.equal('437fbbf5-33f5-487a-8e16-a7112903cfe5');
+      expect(requestBid.id).to.equal(BID_REQUESTS[0].auctionId);
+      expect(requestBid.source.tid).to.equal(BID_REQUESTS[0].auctionId);
     });
 
     it('should block request if config did not define p1Consent URL in endpoint object config', function () {
@@ -3481,5 +3480,161 @@ describe('S2S Adapter', function () {
       const parsedRequestBody = JSON.parse(server.requests[1].requestBody);
       expect(parsedRequestBody.cur).to.deep.equal(['JPY']);
     });
+
+    it('should correctly set the floorMin key when multiple bids with various bidfloors exist', function () {
+      const s2sConfig = Object.assign({}, CONFIG, {
+        extPrebid: {
+          floors: {
+            enabled: true
+          }
+        },
+        bidders: ['b1', 'b2']
+      });
+
+      const bidderRequests = [
+        {
+          ...BID_REQUESTS[0],
+          bidderCode: 'b1',
+          bids: [{
+            bidder: 'b1',
+            bidId: 1,
+            getFloor: () => ({
+              currency: 'US',
+              floor: 1.23
+            })
+          }]
+        },
+        {
+          ...BID_REQUESTS[0],
+          bidderCode: 'b2',
+          bids: [{
+            bidder: 'b2',
+            bidId: 2,
+            getFloor: () => ({
+              currency: 'EUR',
+              floor: 3.21
+            })
+          }],
+        }
+      ];
+
+      const adUnits = [
+        {
+          code: 'au1',
+          transactionId: 't1',
+          mediaTypes: {
+            banner: {sizes: [1, 1]}
+          },
+          bids: [{bidder: 'b1', bid_id: 1}]
+        },
+        {
+          code: 'au2',
+          transactionId: 't2',
+          bids: [{bidder: 'b2', bid_id: 2}],
+          mediaTypes: {
+            banner: {sizes: [1, 1]}
+          }
+        }
+      ];
+
+      const _config = {
+        s2sConfig: s2sConfig,
+      };
+
+      const s2sBidRequest = utils.deepClone(REQUEST);
+      s2sBidRequest.s2sConfig = s2sConfig;
+      s2sBidRequest.ad_units = adUnits;
+      config.setConfig(_config);
+
+      adapter.callBids(s2sBidRequest, bidderRequests, addBidResponse, done, ajax);
+      const requestBid = JSON.parse(server.requests[0].requestBody);
+      expect(requestBid.imp[0].bidfloor).to.equal(1.23);
+      expect(requestBid.imp[1].bidfloor).to.equal(3.21);
+
+      // first imp floorCur should be set
+      expect(requestBid.ext.prebid.floors).to.deep.equal({ enabled: true, floorMin: 1.23, floorMinCur: 'US' });
+    });
+
+    it('should correctly set the floorMin key when multiple bids with various bidfloors exist and ortb2Imp contains the lowest floorMin', function () {
+      const s2sConfig = Object.assign({}, CONFIG, {
+        extPrebid: {
+          floors: {
+            enabled: true
+          }
+        },
+        bidders: ['b1', 'b2']
+      });
+
+      const bidderRequests = [
+        {
+          ...BID_REQUESTS[0],
+          bidderCode: 'b1',
+          bids: [{
+            bidder: 'b1',
+            bidId: 1,
+            getFloor: () => ({
+              currency: 'CUR',
+              floor: 1.23
+            })
+          }]
+        },
+        {
+          ...BID_REQUESTS[0],
+          bidderCode: 'b2',
+          bids: [{
+            bidder: 'b2',
+            bidId: 2,
+            getFloor: () => ({
+              currency: 'CUR',
+              floor: 3.21
+            })
+          }],
+        }
+      ];
+
+      const adUnits = [
+        {
+          code: 'au1',
+          transactionId: 't1',
+          mediaTypes: {
+            banner: {sizes: [1, 1]}
+          },
+          bids: [{bidder: 'b1', bid_id: 1}]
+        },
+        {
+          code: 'au2',
+          transactionId: 't2',
+          bids: [{bidder: 'b2', bid_id: 2}],
+          mediaTypes: {
+            banner: {sizes: [1, 1]}
+          },
+          ortb2Imp: {
+            ext: {
+              prebid: {
+                floors: {
+                  floorMin: 1
+                }
+              }
+            }
+          }
+        }
+      ];
+
+      const _config = {
+        s2sConfig: s2sConfig,
+      };
+
+      const s2sBidRequest = utils.deepClone(REQUEST);
+      s2sBidRequest.s2sConfig = s2sConfig;
+      s2sBidRequest.ad_units = adUnits;
+      config.setConfig(_config);
+
+      adapter.callBids(s2sBidRequest, bidderRequests, addBidResponse, done, ajax);
+      const requestBid = JSON.parse(server.requests[0].requestBody);
+      expect(requestBid.imp[0].bidfloor).to.equal(1.23);
+      expect(requestBid.imp[1].bidfloor).to.equal(3.21);
+
+      expect(requestBid.ext.prebid.floors).to.deep.equal({ enabled: true, floorMin: 1, floorMinCur: 'CUR' });
+    });
   });
 });

package/test/spec/modules/seedtagBidAdapter_spec.js

@@ -361,28 +361,25 @@ describe('Seedtag Adapter', function () {
       it('should add schain to payload when exposed on validBidRequest', function () {
         // https://github.com/prebid/Prebid.js/blob/master/modules/schain.md#sample-code-for-passing-the-schain-object
         const schain = {
-          validation: 'strict',
-          config: {
-            ver: '1.0',
-            complete: 1,
-            nodes: [
-              {
-                asi: 'indirectseller.com',
-                sid: '00001',
-                hp: 1,
-              },
+          ver: '1.0',
+          complete: 1,
+          nodes: [
+            {
+              asi: 'indirectseller.com',
+              sid: '00001',
+              hp: 1,
+            },
 
-              {
-                asi: 'indirectseller-2.com',
-                sid: '00002',
-                hp: 1,
-              },
-            ],
-          },
+            {
+              asi: 'indirectseller-2.com',
+              sid: '00002',
+              hp: 1,
+            },
+          ],
         };
 
         // duplicate
-        const bidRequests = JSON.parse(JSON.stringify(validBidRequests))
+        const bidRequests = JSON.parse(JSON.stringify(validBidRequests));
         bidRequests[0].schain = schain;
 
         const request = spec.buildRequests(bidRequests, bidderRequest);

package/test/spec/modules/sharethroughBidAdapter_spec.js

@@ -172,6 +172,7 @@ describe('sharethrough adapter spec', function () {
         refererInfo: {
           ref: 'https://referer.com',
         },
+        auctionId: 'auction-id'
       };
     });
 
@@ -233,7 +234,7 @@ describe('sharethrough adapter spec', function () {
             expect(openRtbReq.device.ua).to.equal(navigator.userAgent);
             expect(openRtbReq.regs.coppa).to.equal(1);
 
-            expect(openRtbReq.source.tid).to.equal(bidRequests[0].transactionId);
+            expect(openRtbReq.source.tid).to.equal(bidderRequest.auctionId);
             expect(openRtbReq.source.ext.version).not.to.be.undefined;
             expect(openRtbReq.source.ext.str).not.to.be.undefined;
             expect(openRtbReq.source.ext.schain).to.deep.equal(bidRequests[0].schain);

package/test/spec/modules/taboolaBidAdapter_spec.js

@@ -449,7 +449,7 @@ describe('Taboola Adapter', function () {
           cpm: bid.price,
           creativeId: bid.crid,
           ttl: 60,
-          netRevenue: false,
+          netRevenue: true,
           currency: serverResponse.body.cur,
           mediaType: 'banner',
           ad: bid.adm,
@@ -475,7 +475,7 @@ describe('Taboola Adapter', function () {
           cpm: bid.price,
           creativeId: bid.crid,
           ttl: 125,
-          netRevenue: false,
+          netRevenue: true,
           currency: serverResponse.body.cur,
           mediaType: 'banner',
           ad: bid.adm,

package/test/spec/modules/ttdBidAdapter_spec.js

@@ -272,10 +272,10 @@ describe('ttdBidAdapter', function () {
       expect(requestBody.imp[0].ext.gpid).to.equal(gpid);
     });
 
-    it('sends transaction id in source.tid', function () {
+    it('sends auction id in source.tid', function () {
       const requestBody = testBuildRequests(baseBannerBidRequests, baseBidderRequest).data;
       expect(requestBody.source).to.be.not.null;
-      expect(requestBody.source.tid).to.equal('1111474f-58b1-4368-b812-84f8c937a099');
+      expect(requestBody.source.tid).to.equal(baseBidderRequest.auctionId);
     });
 
     it('includes the ad size in the bid request', function () {
@@ -557,7 +557,7 @@ describe('ttdBidAdapter', function () {
       const requestBody = testBuildRequests(baseBannerMultipleBidRequests, baseBidderRequest).data;
       expect(requestBody.imp.length).to.equal(2);
       expect(requestBody.source).to.be.not.null;
-      expect(requestBody.source.tid).to.equal('1111474f-58b1-4368-b812-84f8c937a099');
+      expect(requestBody.source.tid).to.equal(baseBidderRequest.auctionId);
       expect(requestBody.imp[0].ext).to.be.not.null;
       expect(requestBody.imp[0].ext.tid).to.equal('8651474f-58b1-4368-b812-84f8c937a099');
       expect(requestBody.imp[1].ext).to.be.not.null;

package/test/spec/modules/vuukleBidAdapter_spec.js

@@ -1,5 +1,6 @@
 import { expect } from 'chai';
 import { spec } from 'modules/vuukleBidAdapter.js';
+import { config } from '../../../src/config.js';
 
 describe('vuukleBidAdapterTests', function() {
   let bidRequestData = {
@@ -34,6 +35,13 @@ describe('vuukleBidAdapterTests', function() {
     expect(req_data.bidId).to.equal('testbid');
   });
 
+  it('validate_generated_params_tmax', function() {
+    request = spec.buildRequests(bidRequestData.bids, {timeout: 1234});
+    let req_data = request[0].data;
+
+    expect(req_data.tmax).to.equal(1234);
+  });
+
   it('validate_response_params', function() {
     let serverResponse = {
       body: {
@@ -58,4 +66,83 @@ describe('vuukleBidAdapterTests', function() {
     expect(bid.creativeId).to.equal('12345');
     expect(bid.meta.advertiserDomains).to.deep.equal(['example.com']);
   });
+
+  describe('consent handling', function() {
+    const bidderRequest = {
+      gdprConsent: {
+        consentString: 'COvFyGBOvFyGBAbAAAENAPCAAOAAAAAAAAAAAEEUACCKAAA.IFoEUQQgAIQwgIwQABAEAAAAOIAACAIAAAAQAIAgEAACEAAAAAgAQBAAAAAAAGBAAgAAAAAAAFAAECAAAgAAQARAEQAAAAAJAAIAAgAAAYQEAAAQmAgBC3ZAYzUw',
+        gdprApplies: 1,
+        vendorData: {
+          vendor: {
+            consents: {
+              1004: 1
+            }
+          }
+        }
+      }
+    }
+
+    it('must handle consent 1/1', function() {
+      request = spec.buildRequests(bidRequestData.bids, bidderRequest);
+      let req_data = request[0].data;
+
+      expect(req_data.gdpr).to.equal(1);
+      expect(req_data.consentGiven).to.equal(1);
+      expect(req_data.consent).to.equal('COvFyGBOvFyGBAbAAAENAPCAAOAAAAAAAAAAAEEUACCKAAA.IFoEUQQgAIQwgIwQABAEAAAAOIAACAIAAAAQAIAgEAACEAAAAAgAQBAAAAAAAGBAAgAAAAAAAFAAECAAAgAAQARAEQAAAAAJAAIAAgAAAYQEAAAQmAgBC3ZAYzUw');
+    })
+
+    it('must handle consent 0/1', function() {
+      bidderRequest.gdprConsent.gdprApplies = 0;
+      request = spec.buildRequests(bidRequestData.bids, bidderRequest);
+      let req_data = request[0].data;
+
+      expect(req_data.gdpr).to.equal(0);
+      expect(req_data.consentGiven).to.equal(1);
+    })
+
+    it('must handle consent 0/0', function() {
+      bidderRequest.gdprConsent.gdprApplies = 0;
+      bidderRequest.gdprConsent.vendorData = undefined;
+      request = spec.buildRequests(bidRequestData.bids, bidderRequest);
+      let req_data = request[0].data;
+
+      expect(req_data.gdpr).to.equal(0);
+      expect(req_data.consentGiven).to.equal(0);
+    })
+
+    it('must handle consent undef', function() {
+      request = spec.buildRequests(bidRequestData.bids, {});
+      let req_data = request[0].data;
+
+      expect(req_data.gdpr).to.equal(0);
+      expect(req_data.consentGiven).to.equal(0);
+    })
+  })
+
+  it('must handle usp consent', function() {
+    request = spec.buildRequests(bidRequestData.bids, {uspConsent: '1YNN'});
+    let req_data = request[0].data;
+
+    expect(req_data.uspConsent).to.equal('1YNN');
+  })
+
+  it('must handle undefined usp consent', function() {
+    request = spec.buildRequests(bidRequestData.bids, {});
+    let req_data = request[0].data;
+
+    expect(req_data.uspConsent).to.equal(undefined);
+  })
+
+  it('must handle coppa flag', function() {
+    sinon.stub(config, 'getConfig')
+      .withArgs('coppa')
+      .returns(true);
+
+    request = spec.buildRequests(bidRequestData.bids);
+    let req_data = request[0].data;
+
+    expect(req_data.coppa).to.equal(1);
+
+    config.getConfig.restore();
+  })
 });

package/test/spec/modules/yahoosspBidAdapter_spec.js

@@ -847,7 +847,9 @@ describe('YahooSSP Bid Adapter:', () => {
       expect(data.device).to.deep.equal({
         dnt: 0,
         ua: navigator.userAgent,
-        ip: undefined
+        ip: undefined,
+        w: window.screen.width,
+        h: window.screen.height
       });
 
       expect(data.regs).to.deep.equal({

package/test/spec/modules/yandexBidAdapter_spec.js

@@ -64,7 +64,9 @@ describe('Yandex adapter', function () {
 
     const bidderRequest = {
       refererInfo: {
-        domain: 'yandex.ru'
+        domain: 'ya.ru',
+        ref: 'https://ya.ru/',
+        page: 'https://ya.ru/',
       },
       gdprConsent
     };
@@ -72,7 +74,7 @@ describe('Yandex adapter', function () {
     it('creates a valid banner request', function () {
       const bannerRequest = getBidRequest();
       bannerRequest.getFloor = () => ({
-        currency: 'USD',
+        currency: 'EUR',
         // floor: 0.5
       });
 
@@ -89,11 +91,11 @@ describe('Yandex adapter', function () {
       const parsedRequestUrl = parseUrl(url);
       const { search: query } = parsedRequestUrl
 
-      expect(parsedRequestUrl.hostname).to.equal('bs-metadsp.yandex.ru');
+      expect(parsedRequestUrl.hostname).to.equal('bs.yandex.ru');
       expect(parsedRequestUrl.pathname).to.equal('/metadsp/123');
 
       expect(query['imp-id']).to.equal('1');
-      expect(query['target-ref']).to.equal('yandex.ru');
+      expect(query['target-ref']).to.equal('ya.ru');
       expect(query['ssp-id']).to.equal('10500');
 
       expect(query['gdpr']).to.equal('1');
@@ -101,7 +103,8 @@ describe('Yandex adapter', function () {
 
       expect(request.data).to.exist;
       expect(data.site).to.not.equal(null);
-      expect(data.site.page).to.equal('yandex.ru');
+      expect(data.site.page_url).to.equal('https://ya.ru/');
+      expect(data.site.ref_url).to.equal('https://ya.ru/');
 
       // expect(data.device).to.not.equal(null);
       // expect(data.device.w).to.equal(window.innerWidth);

package/test/spec/native_spec.js

@@ -190,6 +190,11 @@ describe('native.js', function () {
     expect(targeting.hb_native_foo).to.equal(bid.native.foo);
   });
 
+  it('can get targeting from null native keys', () => {
+    const targeting = getNativeTargeting({...bid, native: {...bid.native, displayUrl: null}});
+    expect(targeting.hb_native_displayurl).to.not.be.ok;
+  })
+
   it('sends placeholders for configured assets', function () {
     const adUnit = {
       transactionId: 'au',

package/test/spec/unit/pbjs_api_spec.js

@@ -1841,6 +1841,50 @@ describe('Unit: Prebid Module', function () {
           .and.to.match(/[a-f0-9\-]{36}/i);
       });
 
+      describe('transactionId', () => {
+        let adUnit;
+        beforeEach(() => {
+          adUnit = {
+            code: 'adUnit',
+            mediaTypes: {
+              banner: {
+                sizes: [300, 250]
+              }
+            },
+            bids: [
+              {
+                bidder: 'mock-bidder',
+              }
+            ]
+          };
+        });
+        it('should be set to ortb2Imp.ext.tid, if specified', () => {
+          $$PREBID_GLOBAL$$.requestBids({
+            adUnits: [
+              {...adUnit, ortb2Imp: {ext: {tid: 'custom-tid'}}}
+            ]
+          });
+          sinon.assert.match(auctionArgs.adUnits[0], {
+            transactionId: 'custom-tid',
+            ortb2Imp: {
+              ext: {
+                tid: 'custom-tid'
+              }
+            }
+          })
+        });
+        it('should be copied to ortb2Imp.ext.tid, if not specified', () => {
+          $$PREBID_GLOBAL$$.requestBids({
+            adUnits: [
+              adUnit
+            ]
+          });
+          const tid = auctionArgs.adUnits[0].transactionId;
+          expect(tid).to.exist;
+          expect(auctionArgs.adUnits[0].ortb2Imp.ext.tid).to.eql(tid);
+        });
+      });
+
       it('should always set ortb2.ext.tid same as transactionId in adUnits', function () {
         $$PREBID_GLOBAL$$.requestBids({
           adUnits: [