prebid.js 7.14.0 → 7.16.0

package/test/spec/modules/stroeerCoreBidAdapter_spec.js

@@ -21,9 +21,8 @@ describe('stroeerCore bid adapter', function () {
     sandbox.restore();
   });
 
-  function assertStandardFieldsOnBid(bidObject, bidId, ad, width, height, cpm) {
+  function assertStandardFieldsBid(bidObject, bidId, width, height, cpm) {
     assert.propertyVal(bidObject, 'requestId', bidId);
-    assert.propertyVal(bidObject, 'ad', ad);
     assert.propertyVal(bidObject, 'width', width);
     assert.propertyVal(bidObject, 'height', height);
     assert.propertyVal(bidObject, 'cpm', cpm);
@@ -32,6 +31,26 @@ describe('stroeerCore bid adapter', function () {
     assert.propertyVal(bidObject, 'creativeId', '');
   }
 
+  function assertStandardFieldsOnBannerBid(bidObject, bidId, ad, width, height, cpm) {
+    assertStandardFieldsBid(bidObject, bidId, width, height, cpm);
+    assertBannerAdMarkup(bidObject, ad);
+  }
+
+  function assertStandardFieldsOnVideoBid(bidObject, bidId, vastXml, width, height, cpm) {
+    assertStandardFieldsBid(bidObject, bidId, width, height, cpm);
+    assertVideoVastXml(bidObject, vastXml);
+  }
+
+  function assertBannerAdMarkup(bidObject, ad) {
+    assert.propertyVal(bidObject, 'ad', ad);
+    assert.notProperty(bidObject, 'vastXml');
+  }
+
+  function assertVideoVastXml(bidObject, vastXml) {
+    assert.propertyVal(bidObject, 'vastXml', vastXml);
+    assert.notProperty(bidObject, 'ad');
+  }
+
   const AUCTION_ID = utils.getUniqueIdentifierStr();
 
   // Vendor user ids and associated data
@@ -91,16 +110,6 @@ describe('stroeerCore bid adapter', function () {
     }],
   });
 
-  const buildBidderRequestPreVersion3 = () => {
-    const request = buildBidderRequest();
-    request.bids.forEach((bid) => {
-      bid.sizes = bid.mediaTypes.banner.sizes;
-      delete bid.mediaTypes;
-      bid.mediaType = 'banner';
-    });
-    return request;
-  };
-
   const buildBidderResponse = () => ({
     'bids': [{
       'bidId': 'bid1', 'cpm': 4.0, 'width': 300, 'height': 600, 'ad': '<div>tag1</div>', 'tracking': {'brandId': 123}
@@ -109,10 +118,16 @@ describe('stroeerCore bid adapter', function () {
     }]
   });
 
+  const buildBidderResponseWithVideo = () => ({
+    'bids': [{
+      'bidId': 'bid1', 'cpm': 4.0, 'width': 800, 'height': 250, 'vastXml': '<vast>video</vast>'
+    }]
+  });
+
   const createWindow = (href, params = {}) => {
     let {parent, top, frameElement, placementElements = []} = params;
 
-    const protocol = (href.indexOf('https') === 0) ? 'https:' : 'http:';
+    const protocol = href.startsWith('https') ? 'https:' : 'http:';
     const win = {
       frameElement,
       parent,
@@ -187,8 +202,12 @@ describe('stroeerCore bid adapter', function () {
     return {topWin, midWin, win};
   }
 
-  it('should only support BANNER mediaType', function () {
-    assert.deepEqual(spec.supportedMediaTypes, [BANNER]);
+  it('should support BANNER and VIDEO mediaType', function () {
+    assert.deepEqual(spec.supportedMediaTypes, [BANNER, VIDEO]);
+  });
+
+  it('should have GDPR vendor list id (gvlid) set on the spec', function () {
+    assert.equal(spec.gvlid, 136);
   });
 
   describe('bid validation entry point', () => {
@@ -211,16 +230,86 @@ describe('stroeerCore bid adapter', function () {
       assert.isFalse(spec.isBidRequestValid(bidRequest));
     });
 
-    it('should exclude non-banner bids', () => {
+    it('should allow instream video bids', () => {
+      delete bidRequest.mediaTypes.banner;
+      bidRequest.mediaTypes.video = {
+        playerSize: [640, 480],
+        context: 'instream'
+      };
+
+      assert.isTrue(spec.isBidRequestValid(bidRequest));
+    });
+
+    it('should allow outstream video bids', () => {
       delete bidRequest.mediaTypes.banner;
       bidRequest.mediaTypes.video = {
-        playerSize: [640, 480]
+        playerSize: [640, 480],
+        context: 'outstream'
+      };
+
+      assert.isTrue(spec.isBidRequestValid(bidRequest));
+    });
+
+    it('should allow multi-format bid that has banner and instream video', () => {
+      assert.isTrue('banner' in bidRequest.mediaTypes);
+
+      // Allowed because instream video component of the bid will be ignored in buildRequest()
+      bidRequest.mediaTypes.video = {
+        playerSize: [640, 480],
+        context: 'instream'
+      };
+
+      assert.isTrue(spec.isBidRequestValid(bidRequest))
+    });
+
+    it('should exclude multi-format bid that has no format of interest', () => {
+      bidRequest.mediaTypes = {
+        video: {
+          playerSize: [640, 480],
+          context: 'adpod'
+        },
+        native: {
+          image: {
+            required: true,
+            sizes: [150, 50]
+          },
+          title: {
+            required: true,
+            len: 80
+          },
+          sponsoredBy: {
+            required: true
+          },
+          clickUrl: {
+            required: true
+          },
+          privacyLink: {
+            required: false
+          },
+          body: {
+            required: true
+          },
+          icon: {
+            required: true,
+            sizes: [50, 50]
+          }
+        }
       };
 
       assert.isFalse(spec.isBidRequestValid(bidRequest));
     });
 
-    it('should exclude non-banner, pre-version 3 bids', () => {
+    it('should exclude video bids without context', () => {
+      delete bidRequest.mediaTypes.banner;
+      bidRequest.mediaTypes.video = {
+        playerSize: [640, 480],
+        context: undefined
+      };
+
+      assert.isFalse(spec.isBidRequestValid(bidRequest));
+    });
+
+    it('should exclude video, pre-version 3 bids', () => {
       delete bidRequest.mediaTypes;
       bidRequest.mediaType = VIDEO;
       assert.isFalse(spec.isBidRequestValid(bidRequest));
@@ -253,9 +342,13 @@ describe('stroeerCore bid adapter', function () {
 
       describe('should use custom url if provided', () => {
         const samples = [{
-          protocol: 'http:', params: {sid: 'ODA=', host: 'other.com', port: '234', path: '/xyz'}, expected: 'https://other.com:234/xyz'
+          protocol: 'http:',
+          params: {sid: 'ODA=', host: 'other.com', port: '234', path: '/xyz'},
+          expected: 'https://other.com:234/xyz'
         }, {
-          protocol: 'https:', params: {sid: 'ODA=', host: 'other.com', port: '234', path: '/xyz'}, expected: 'https://other.com:234/xyz'
+          protocol: 'https:',
+          params: {sid: 'ODA=', host: 'other.com', port: '234', path: '/xyz'},
+          expected: 'https://other.com:234/xyz'
         }, {
           protocol: 'https:',
           params: {sid: 'ODA=', host: 'other.com', port: '234', securePort: '871', path: '/xyz'},
@@ -315,9 +408,19 @@ describe('stroeerCore bid adapter', function () {
           'ssl': false,
           'url': 'https://www.example.com/monkey/index.html',
           'bids': [{
-            'sid': 'NDA=', 'bid': 'bid1', 'siz': [[300, 600], [160, 60]], 'viz': true
+            'sid': 'NDA=',
+            'bid': 'bid1',
+            'viz': true,
+            'ban': {
+              'siz': [[300, 600], [160, 60]]
+            }
           }, {
-            'sid': 'ODA=', 'bid': 'bid2', 'siz': [[728, 90]], 'viz': true
+            'sid': 'ODA=',
+            'bid': 'bid2',
+            'viz': true,
+            'ban': {
+              'siz': [[728, 90]]
+            }
           }],
           'user': {
             'euids': userIds
@@ -330,13 +433,182 @@ describe('stroeerCore bid adapter', function () {
         assert.deepEqual(actualJsonPayload, expectedJsonPayload);
       });
 
-      it('should handle banner sizes for pre version 3', () => {
-        // Version 3 changes the way how banner sizes are accessed.
-        // We can support backwards compatibility with version 2.x
-        const bidReq = buildBidderRequestPreVersion3();
-        const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq);
-        assert.deepEqual(serverRequestInfo.data.bids[0].siz, [[300, 600], [160, 60]]);
-        assert.deepEqual(serverRequestInfo.data.bids[1].siz, [[728, 90]]);
+      describe('video bids', () => {
+        it('should be able to build instream video bid', () => {
+          bidderRequest.bids = [{
+            bidId: 'bid1',
+            bidder: 'stroeerCore',
+            adUnitCode: 'div-1',
+            mediaTypes: {
+              video: {
+                context: 'instream',
+                playerSize: [640, 480],
+                mimes: ['video/mp4', 'video/quicktime']
+              }
+            },
+            params: {
+              sid: 'NDA='
+            },
+            userId: userIds
+          }];
+
+          const expectedBids = [{
+            'sid': 'NDA=',
+            'bid': 'bid1',
+            'viz': true,
+            'vid': {
+              'ctx': 'instream',
+              'siz': [640, 480],
+              'mim': ['video/mp4', 'video/quicktime']
+            }
+          }];
+
+          const serverRequestInfo = spec.buildRequests(bidderRequest.bids, bidderRequest);
+
+          const bids = JSON.parse(JSON.stringify(serverRequestInfo.data.bids));
+          assert.deepEqual(bids, expectedBids);
+        });
+      });
+
+      describe('multi-formats', () => {
+        it(`should create a request for video and banner`, () => {
+          const videoBid = {
+            bidId: 'bid3',
+            bidder: 'stroeerCore',
+            adUnitCode: 'div-1',
+            mediaTypes: {
+              video: {
+                context: 'instream',
+                playerSize: [640, 480],
+                mimes: ['video/mp4', 'video/quicktime'],
+              }
+            },
+            params: {
+              sid: 'ODA=',
+            },
+            userId: userIds
+          }
+
+          const bannerBid1 = {
+            bidId: 'bid8',
+            bidder: 'stroeerCore',
+            adUnitCode: 'div-2',
+            mediaTypes: {
+              banner: {
+                sizes: [[300, 600], [160, 60]],
+              }
+            },
+            params: {
+              sid: 'NDA=',
+            },
+            userId: userIds
+          }
+
+          const bannerBid2 = {
+            bidId: 'bid12',
+            bidder: 'stroeerCore',
+            adUnitCode: 'div-3',
+            mediaTypes: {
+              banner: {
+                sizes: [[100, 200], [300, 500]],
+              }
+            },
+            params: {
+              sid: 'ABC=',
+            },
+            userId: userIds
+          }
+
+          bidderRequest.bids = [bannerBid1, videoBid, bannerBid2];
+
+          const expectedBannerBids = [
+            {
+              'sid': 'NDA=',
+              'bid': 'bid8',
+              'viz': true,
+              'ban': {
+                'siz': [[300, 600], [160, 60]]
+              }
+            },
+            {
+              'sid': 'ABC=',
+              'bid': 'bid12',
+              'ban': {
+                'siz': [[100, 200], [300, 500]]
+              },
+              'viz': undefined
+            }
+          ];
+
+          const expectedVideoBids = [
+            {
+              'sid': 'ODA=',
+              'bid': 'bid3',
+              'viz': true,
+              'vid': {
+                'ctx': 'instream',
+                'siz': [640, 480],
+                'mim': ['video/mp4', 'video/quicktime']
+              }
+            }
+          ];
+
+          const serverRequestInfo = spec.buildRequests(bidderRequest.bids, bidderRequest);
+
+          assert.deepEqual(serverRequestInfo.data.bids, [...expectedBannerBids, ...expectedVideoBids]);
+        });
+
+        it('should split multi-format bid', function() {
+          const multiFormatBid = {
+            bidId: 'bid3',
+            bidder: 'stroeerCore',
+            adUnitCode: 'div-1',
+            mediaTypes: {
+              video: {
+                context: 'instream',
+                playerSize: [640, 480],
+                mimes: ['video/mp4', 'video/quicktime'],
+              },
+              banner: {
+                sizes: [[100, 200], [300, 500]],
+              }
+            },
+            params: {
+              sid: 'ODA=',
+            },
+            userId: userIds
+          }
+
+          bidderRequest.bids = [multiFormatBid];
+
+          const serverRequestInfo = spec.buildRequests(bidderRequest.bids, bidderRequest);
+
+          const expectedBannerBids = [
+            {
+              'sid': 'ODA=',
+              'bid': 'bid3',
+              'viz': true,
+              'ban': {
+                'siz': [[100, 200], [300, 500]]
+              }
+            }
+          ];
+
+          const expectedVideoBids = [
+            {
+              'sid': 'ODA=',
+              'bid': 'bid3',
+              'viz': true,
+              'vid': {
+                'ctx': 'instream',
+                'siz': [640, 480],
+                'mim': ['video/mp4', 'video/quicktime']
+              }
+            }
+          ];
+
+          assert.deepEqual(serverRequestInfo.data.bids, [...expectedBannerBids, ...expectedVideoBids]);
+        });
       });
 
       describe('optional fields', () => {
@@ -364,7 +636,10 @@ describe('stroeerCore bid adapter', function () {
           }
         });
 
-        const gdprSamples = [{consentString: 'RG9ua2V5IEtvbmc=', gdprApplies: true}, {consentString: 'UGluZyBQb25n', gdprApplies: false}];
+        const gdprSamples = [{consentString: 'RG9ua2V5IEtvbmc=', gdprApplies: true}, {
+          consentString: 'UGluZyBQb25n',
+          gdprApplies: false
+        }];
         gdprSamples.forEach((sample) => {
           it(`should add GDPR info ${JSON.stringify(sample)} when provided`, () => {
             const bidReq = buildBidderRequest();
@@ -424,7 +699,6 @@ describe('stroeerCore bid adapter', function () {
           bidReq.bids.forEach(bid => bid.schain = schain);
 
           const serverRequestInfo = spec.buildRequests(bidReq.bids, bidReq);
-
           assert.deepEqual(serverRequestInfo.data.schain, schain);
         });
       });
@@ -449,8 +723,8 @@ describe('stroeerCore bid adapter', function () {
       const bidderResponse = buildBidderResponse();
 
       const result = spec.interpretResponse({body: bidderResponse});
-      assertStandardFieldsOnBid(result[0], 'bid1', '<div>tag1</div>', 300, 600, 4);
-      assertStandardFieldsOnBid(result[1], 'bid2', '<div>tag2</div>', 728, 90, 7.3);
+      assertStandardFieldsOnBannerBid(result[0], 'bid1', '<div>tag1</div>', 300, 600, 4);
+      assertStandardFieldsOnBannerBid(result[1], 'bid2', '<div>tag2</div>', 728, 90, 7.3);
     });
 
     it('should return empty array, when response contains no bids', () => {
@@ -458,6 +732,13 @@ describe('stroeerCore bid adapter', function () {
       assert.deepStrictEqual(result, []);
     });
 
+    it('should interpret a video response', () => {
+      const bidderResponse = buildBidderResponseWithVideo();
+      const bidResponses = spec.interpretResponse({body: bidderResponse});
+      let videoBidResponse = bidResponses[0];
+      assertStandardFieldsOnVideoBid(videoBidResponse, 'bid1', '<vast>video</vast>', 800, 250, 4);
+    })
+
     it('should add data to meta object', () => {
       const response = buildBidderResponse();
       response.bids[0] = Object.assign(response.bids[0], {adomain: ['website.org', 'domain.com']});
@@ -470,6 +751,7 @@ describe('stroeerCore bid adapter', function () {
 
   describe('get user syncs entry point', () => {
     let win;
+
     beforeEach(() => {
       win = setupSingleWindow(sandbox);
 

package/test/spec/modules/teadsBidAdapter_spec.js

@@ -470,35 +470,89 @@ describe('teadsBidAdapter', () => {
         'deviceWidth': 1680
       };
 
-      describe('Unified ID v2', function () {
-        it('should not add unifiedId2 param to payload if uid2 system is not enabled', function () {
+      const userIdModules = {
+        unifiedId2: {uid2: {id: 'unifiedId2-id'}},
+        liveRampId: {idl_env: 'liveRampId-id'},
+        lotamePanoramaId: {lotamePanoramaId: 'lotamePanoramaId-id'},
+        id5Id: {id5id: {uid: 'id5Id-id'}},
+        criteoId: {criteoId: 'criteoId-id'},
+        yahooConnectId: {connectId: 'yahooConnectId-id'},
+        quantcastId: {quantcastId: 'quantcastId-id'},
+        epsilonPublisherLinkId: {publinkId: 'epsilonPublisherLinkId-id'},
+        publisherFirstPartyViewerId: {pubcid: 'publisherFirstPartyViewerId-id'},
+        merkleId: {merkleId: {id: 'merkleId-id'}},
+        kinessoId: {kpuid: 'kinessoId-id'}
+      };
+
+      describe('User Id Modules', function () {
+        it(`should not add param to payload if user id system is not enabled`, function () {
           const bidRequest = {
             ...baseBidRequest,
-            userId: {} // no "uid2" property -> assumption that the Unified ID v2 system is disabled
+            userId: {} // no property -> assumption that the system is disabled
           };
 
           const request = spec.buildRequests([bidRequest], bidderResquestDefault);
           const payload = JSON.parse(request.data);
 
-          expect(payload).not.to.have.property('unifiedId2');
+          for (const userId in userIdModules) {
+            expect(payload, userId).not.to.have.property(userId);
+          }
+        });
+
+        it(`should not add param to payload if user id field is absent`, function () {
+          const request = spec.buildRequests([baseBidRequest], bidderResquestDefault);
+          const payload = JSON.parse(request.data);
+
+          for (const userId in userIdModules) {
+            expect(payload, userId).not.to.have.property(userId);
+          }
         });
 
-        it('should add unifiedId2 param to payload if uid2 system is enabled', function () {
+        it(`should not add param to payload if user id is enabled but there is no value`, function () {
           const bidRequest = {
             ...baseBidRequest,
             userId: {
-              uid2: {
-                id: 'my-unified-id-2'
-              }
+              idl_env: '',
+              pubcid: 'publisherFirstPartyViewerId-id'
             }
           };
 
           const request = spec.buildRequests([bidRequest], bidderResquestDefault);
           const payload = JSON.parse(request.data);
 
-          expect(payload.unifiedId2).to.equal('my-unified-id-2');
-        })
-      });
+          expect(payload).not.to.have.property('liveRampId');
+          expect(payload['publisherFirstPartyViewerId']).to.equal('publisherFirstPartyViewerId-id');
+        });
+
+        it(`should add userId param to payload for each enabled user id system`, function () {
+          let userIdObject = {};
+          for (const userId in userIdModules) {
+            userIdObject = {
+              ...userIdObject,
+              ...userIdModules[userId]
+            }
+          }
+          const bidRequest = {
+            ...baseBidRequest,
+            userId: userIdObject
+          };
+
+          const request = spec.buildRequests([bidRequest], bidderResquestDefault);
+          const payload = JSON.parse(request.data);
+
+          expect(payload['unifiedId2']).to.equal('unifiedId2-id');
+          expect(payload['liveRampId']).to.equal('liveRampId-id');
+          expect(payload['lotamePanoramaId']).to.equal('lotamePanoramaId-id');
+          expect(payload['id5Id']).to.equal('id5Id-id');
+          expect(payload['criteoId']).to.equal('criteoId-id');
+          expect(payload['yahooConnectId']).to.equal('yahooConnectId-id');
+          expect(payload['quantcastId']).to.equal('quantcastId-id');
+          expect(payload['epsilonPublisherLinkId']).to.equal('epsilonPublisherLinkId-id');
+          expect(payload['publisherFirstPartyViewerId']).to.equal('publisherFirstPartyViewerId-id');
+          expect(payload['merkleId']).to.equal('merkleId-id');
+          expect(payload['kinessoId']).to.equal('kinessoId-id');
+        });
+      })
 
       describe('First-party cookie Teads ID', function () {
         it('should not add firstPartyCookieTeadsId param to payload if cookies are not enabled', function () {

package/test/spec/modules/ucfunnelBidAdapter_spec.js

@@ -5,7 +5,11 @@ const URL = 'https://hb.aralego.com/header';
 const BIDDER_CODE = 'ucfunnel';
 
 const bidderRequest = {
-  uspConsent: '1YNN'
+  uspConsent: '1YNN',
+  refererInfo: {
+    domain: 'example.com',
+    page: 'http://example.com/index.html'
+  }
 };
 
 const userId = {
@@ -28,6 +32,11 @@ const validBannerBidReq = {
   sizes: [[300, 250]],
   bidId: '263be71e91dd9d',
   auctionId: '9ad1fa8d-2297-4660-a018-b39945054746',
+  ortb2Imp: {
+    ext: {
+      gpid: '/1111/homepage#div-leftnav'
+    }
+  },
   userId: userId,
   'schain': {
     'ver': '1.0',
@@ -151,6 +160,11 @@ describe('ucfunnel Adapter', function () {
       expect(request[0].bidRequest).to.equal(validBannerBidReq);
     });
 
+    it('should set gpid if configured', function () {
+      const data = request[0].data;
+      expect(data.gpid).to.equal('/1111/homepage#div-leftnav');
+    });
+
     it('should attach request data', function () {
       const data = request[0].data;
       const [ width, height ] = validBannerBidReq.sizes[0];
@@ -166,7 +180,7 @@ describe('ucfunnel Adapter', function () {
       const width = 640;
       const height = 480;
       validBannerBidReq.sizes = [[ width, height ]];
-      const requests = spec.buildRequests([ validBannerBidReq ]);
+      const requests = spec.buildRequests([ validBannerBidReq ], bidderRequest);
       const data = requests[0].data;
       expect(data.w).to.equal(width);
       expect(data.h).to.equal(height);
@@ -180,7 +194,7 @@ describe('ucfunnel Adapter', function () {
           floor: 2.02
         }
       };
-      const requests = spec.buildRequests([ bid ]);
+      const requests = spec.buildRequests([ bid ], bidderRequest);
       const data = requests[0].data;
       expect(data.fp).to.equal(2.02);
     });
@@ -188,7 +202,7 @@ describe('ucfunnel Adapter', function () {
     it('should set bidfloor if configured', function() {
       let bid = Object.assign({}, validBannerBidReq);
       bid.params.bidfloor = 2.01;
-      const requests = spec.buildRequests([ bid ]);
+      const requests = spec.buildRequests([ bid ], bidderRequest);
       const data = requests[0].data;
       expect(data.fp).to.equal(2.01);
     });
@@ -202,7 +216,7 @@ describe('ucfunnel Adapter', function () {
         }
       };
       bid.params.bidfloor = 2.01;
-      const requests = spec.buildRequests([ bid ]);
+      const requests = spec.buildRequests([ bid ], bidderRequest);
       const data = requests[0].data;
       expect(data.fp).to.equal(2.01);
     });
@@ -210,7 +224,7 @@ describe('ucfunnel Adapter', function () {
 
   describe('interpretResponse', function () {
     describe('should support banner', function () {
-      const request = spec.buildRequests([ validBannerBidReq ]);
+      const request = spec.buildRequests([ validBannerBidReq ], bidderRequest);
       const result = spec.interpretResponse({body: validBannerBidRes}, request[0]);
       it('should build bid array for banner', function () {
         expect(result.length).to.equal(1);
@@ -229,7 +243,7 @@ describe('ucfunnel Adapter', function () {
     });
 
     describe('handle banner no ad', function () {
-      const request = spec.buildRequests([ validBannerBidReq ]);
+      const request = spec.buildRequests([ validBannerBidReq ], bidderRequest);
       const result = spec.interpretResponse({body: invalidBannerBidRes}, request[0]);
       it('should build bid array for banner', function () {
         expect(result.length).to.equal(1);
@@ -247,7 +261,7 @@ describe('ucfunnel Adapter', function () {
     });
 
     describe('handle banner cpm under bidfloor', function () {
-      const request = spec.buildRequests([ validBannerBidReq ]);
+      const request = spec.buildRequests([ validBannerBidReq ], bidderRequest);
       const result = spec.interpretResponse({body: invalidBannerBidRes}, request[0]);
       it('should build bid array for banner', function () {
         expect(result.length).to.equal(1);
@@ -265,7 +279,7 @@ describe('ucfunnel Adapter', function () {
     });
 
     describe('should support video', function () {
-      const request = spec.buildRequests([ validVideoBidReq ]);
+      const request = spec.buildRequests([ validVideoBidReq ], bidderRequest);
       const result = spec.interpretResponse({body: validVideoBidRes}, request[0]);
       it('should build bid array', function () {
         expect(result.length).to.equal(1);
@@ -285,7 +299,7 @@ describe('ucfunnel Adapter', function () {
     });
 
     describe('should support native', function () {
-      const request = spec.buildRequests([ validNativeBidReq ]);
+      const request = spec.buildRequests([ validNativeBidReq ], bidderRequest);
       const result = spec.interpretResponse({body: validNativeBidRes}, request[0]);
       it('should build bid array', function () {
         expect(result.length).to.equal(1);

package/test/spec/native_spec.js

@@ -877,6 +877,17 @@ describe('validate native', function () {
     });
   });
 
+  ['bogusKey', 'clickUrl', 'privacyLink'].forEach(nativeKey => {
+    it(`should not generate an empty asset for key ${nativeKey}`, () => {
+      const ortbReq = toOrtbNativeRequest({
+        [nativeKey]: {
+          required: true
+        }
+      });
+      expect(ortbReq.assets.length).to.equal(0);
+    });
+  })
+
   it('should convert from ortb to old-style native request', () => {
     const openRTBRequest = {
       'ver': '1.2',