prebid.js 6.8.0 → 6.12.0

package/test/spec/auctionmanager_spec.js

@@ -3,7 +3,9 @@ import {
   auctionCallbacks,
   AUCTION_COMPLETED,
   adjustBids,
-  getMediaTypeGranularity, addBidResponse,
+  getMediaTypeGranularity,
+  getPriceByGranularity,
+  addBidResponse
 } from 'src/auction.js';
 import CONSTANTS from 'src/constants.json';
 import * as auctionModule from 'src/auction.js';
@@ -14,10 +16,12 @@ import * as store from 'src/videoCache.js';
 import * as ajaxLib from 'src/ajax.js';
 import find from 'core-js-pure/features/array/find.js';
 import { server } from 'test/mocks/xhr.js';
-import {expect} from 'chai';
 import {hook} from '../../src/hook.js';
-import 'src/debugging.js'
-import {synchronizePromise} from '../helpers/syncPromise.js'; // some of these tests require debugging hooks to be loaded
+import {auctionManager} from '../../src/auctionManager.js';
+import 'src/debugging.js' // some tests look for debugging side effects
+import {AuctionIndex} from '../../src/auctionIndex.js';
+import {expect} from 'chai';
+import {synchronizePromise} from '../helpers/syncPromise.js';
 
 var assert = require('assert');
 
@@ -49,6 +53,7 @@ function mockBid(opts) {
     'height': 250,
     'bidderCode': bidderCode || BIDDER_CODE,
     'requestId': utils.getUniqueIdentifierStr(),
+    'transactionId': (opts && opts.transactionId) || ADUNIT_CODE,
     'creativeId': 'id',
     'currency': 'USD',
     'netRevenue': true,
@@ -79,7 +84,7 @@ function mockBidRequest(bid, opts) {
 
   return {
     'bidderCode': bidderCode || bid.bidderCode,
-    'auctionId': '20882439e3238c',
+    'auctionId': opts && opts.auctionId,
     'bidderRequestId': requestId,
     'bids': [
       {
@@ -88,10 +93,11 @@ function mockBidRequest(bid, opts) {
           'placementId': 'id'
         },
         'adUnitCode': adUnitCode || ADUNIT_CODE,
+        'transactionId': bid.transactionId,
         'sizes': [[300, 250], [300, 600]],
         'bidId': bid.requestId,
         'bidderRequestId': requestId,
-        'auctionId': '20882439e3238c',
+        'auctionId': opts && opts.auctionId,
         'mediaTypes': mediaType
       }
     ],
@@ -128,10 +134,10 @@ function mockAjaxBuilder() {
 }
 
 describe('auctionmanager.js', function () {
-  let promiseSandbox;
+  let indexAuctions, indexStub, promiseSandbox;
 
   before(() => {
-    // hooks are global and their side effects depend on what has been loaded... not ideal for unit tests
+    // hooks are global and their side effects depend on what has been loaded
     [
       auctionModule.addBidResponse,
       auctionModule.addBidderRequests,
@@ -141,13 +147,17 @@ describe('auctionmanager.js', function () {
   });
 
   beforeEach(() => {
+    indexAuctions = [];
+    indexStub = sinon.stub(auctionManager, 'index');
+    indexStub.get(() => new AuctionIndex(() => indexAuctions));
     promiseSandbox = sinon.createSandbox();
     synchronizePromise(promiseSandbox);
   });
 
   afterEach(() => {
+    indexStub.restore();
     promiseSandbox.restore();
-  })
+  });
 
   describe('getKeyValueTargetingPairs', function () {
     const DEFAULT_BID = {
@@ -672,14 +682,14 @@ describe('auctionmanager.js', function () {
     });
   });
 
-  describe('addBidResponse', function () {
+  describe('addBidResponse #1', function () {
     let createAuctionStub;
     let adUnits;
     let adUnitCodes;
     let spec;
     let auction;
     let ajaxStub;
-    let bids = TEST_BIDS;
+    let bids;
     let makeRequestsStub;
 
     before(function () {
@@ -691,19 +701,20 @@ describe('auctionmanager.js', function () {
     });
 
     describe('when auction timeout is 3000', function () {
-      before(function () {
-        ajaxStub = sinon.stub(ajaxLib, 'ajaxBuilder').callsFake(mockAjaxBuilder);
-        makeRequestsStub.returns(TEST_BID_REQS);
-      });
       beforeEach(function () {
+        ajaxStub = sinon.stub(ajaxLib, 'ajaxBuilder').callsFake(mockAjaxBuilder);
         adUnits = [{
           code: ADUNIT_CODE,
+          transactionId: ADUNIT_CODE,
           bids: [
             {bidder: BIDDER_CODE, params: {placementId: 'id'}},
           ]
         }];
         adUnitCodes = [ADUNIT_CODE];
         auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: function() {}, cbTimeout: 3000});
+        bids = TEST_BIDS.slice();
+        makeRequestsStub.returns(bids.map(b => mockBidRequest(b, {auctionId: auction.getAuctionId()})));
+        indexAuctions = [auction];
         createAuctionStub = sinon.stub(auctionModule, 'newAuction');
         createAuctionStub.returns(auction);
 
@@ -712,11 +723,8 @@ describe('auctionmanager.js', function () {
       });
 
       afterEach(function () {
-        auctionModule.newAuction.restore();
-      });
-
-      after(function () {
         ajaxStub.restore();
+        auctionModule.newAuction.restore();
       });
 
       function checkPbDg(cpm, expected, msg) {
@@ -764,9 +772,7 @@ describe('auctionmanager.js', function () {
           url: 'renderer.js',
           render: (bid) => bid
         };
-        let bidRequests = [Object.assign({}, TEST_BID_REQS[0])];
-        bidRequests[0].bids[0] = Object.assign({ renderer }, bidRequests[0].bids[0]);
-        makeRequestsStub.returns(bidRequests);
+        Object.assign(adUnits[0], {renderer});
 
         let bids1 = Object.assign({},
           bids[0],
@@ -787,9 +793,7 @@ describe('auctionmanager.js', function () {
           backupOnly: true,
           render: (bid) => bid
         };
-        let bidRequests = [Object.assign({}, TEST_BID_REQS[0])];
-        bidRequests[0].bids[0] = Object.assign({ renderer }, bidRequests[0].bids[0]);
-        makeRequestsStub.returns(bidRequests);
+        Object.assign(adUnits[0], {renderer});
 
         let bids1 = Object.assign({},
           bids[0],
@@ -871,17 +875,19 @@ describe('auctionmanager.js', function () {
           url: 'renderer.js',
           render: (bid) => bid
         };
-
+        Object.assign(adUnits[0], {renderer});
         // make sure that if the renderer is only on the second ad unit, prebid
         // still correctly uses it
         let bid = mockBid();
-        let bidRequests = [mockBidRequest(bid)];
+        let bidRequests = [mockBidRequest(bid, {auctionId: auction.getAuctionId()})];
 
         bidRequests[0].bids[1] = Object.assign({
-          renderer,
           bidId: utils.getUniqueIdentifierStr()
         }, bidRequests[0].bids[0]);
-        bidRequests[0].bids[0].adUnitCode = ADUNIT_CODE1;
+        Object.assign(bidRequests[0].bids[0], {
+          adUnitCode: ADUNIT_CODE1,
+          transactionId: ADUNIT_CODE1,
+        });
 
         makeRequestsStub.returns(bidRequests);
 
@@ -899,16 +905,16 @@ describe('auctionmanager.js', function () {
     describe('when auction timeout is 20', function () {
       let eventsEmitSpy;
 
-      before(function () {
+      function setupBids(auctionId) {
         bids = [mockBid(), mockBid({ bidderCode: BIDDER_CODE1 })];
-        let bidRequests = bids.map(bid => mockBidRequest(bid));
-
+        let bidRequests = bids.map(bid => mockBidRequest(bid, {auctionId}));
         makeRequestsStub.returns(bidRequests);
-      });
+      }
 
       beforeEach(function () {
         adUnits = [{
           code: ADUNIT_CODE,
+          transactionId: ADUNIT_CODE,
           bids: [
             {bidder: BIDDER_CODE, params: {placementId: 'id'}},
           ]
@@ -944,6 +950,7 @@ describe('auctionmanager.js', function () {
           done();
         }
         auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: auctionCallback, cbTimeout: 20});
+        setupBids(auction.getAuctionId());
 
         auction.callBids();
         respondToRequest(0);
@@ -962,7 +969,7 @@ describe('auctionmanager.js', function () {
           done();
         }
         auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: auctionCallback, cbTimeout: 20});
-
+        setupBids(auction.getAuctionId());
         auction.callBids();
         respondToRequest(0);
         respondToRequest(1);
@@ -984,14 +991,14 @@ describe('auctionmanager.js', function () {
           done();
         }
         auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: auctionCallback, cbTimeout: 20});
-
+        setupBids(auction.getAuctionId());
         auction.callBids();
         respondToRequest(0);
       });
     });
   });
 
-  describe('addBidResponse', function () {
+  describe('addBidResponse #2', function () {
     let createAuctionStub;
     let adUnits;
     let adUnitCodes;
@@ -1003,38 +1010,32 @@ describe('auctionmanager.js', function () {
     let bids = TEST_BIDS;
     let bids1 = [mockBid({ bidderCode: BIDDER_CODE1 })];
 
-    before(function () {
-      let bidRequests = [
-        mockBidRequest(bids[0]),
-        mockBidRequest(bids1[0], { adUnitCode: ADUNIT_CODE1 })
-      ];
-      let makeRequestsStub = sinon.stub(adapterManager, 'makeBidRequests');
-      makeRequestsStub.returns(bidRequests);
-
-      ajaxStub = sinon.stub(ajaxLib, 'ajaxBuilder').callsFake(mockAjaxBuilder);
-    });
-
-    after(function () {
-      ajaxStub.restore();
-      adapterManager.makeBidRequests.restore();
-    });
-
     beforeEach(function () {
       adUnits = [{
         code: ADUNIT_CODE,
+        transactionId: ADUNIT_CODE,
         bids: [
           {bidder: BIDDER_CODE, params: {placementId: 'id'}},
         ]
       }, {
         code: ADUNIT_CODE1,
+        transactionId: ADUNIT_CODE1,
         bids: [
           {bidder: BIDDER_CODE1, params: {placementId: 'id'}},
         ]
       }];
       adUnitCodes = adUnits.map(({ code }) => code);
       auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: function() {}, cbTimeout: 3000});
+      let bidRequests = [
+        mockBidRequest(bids[0], { auctionId: auction.getAuctionId() }),
+        mockBidRequest(bids1[0], { auctionId: auction.getAuctionId(), adUnitCode: ADUNIT_CODE1 })
+      ];
+      let makeRequestsStub = sinon.stub(adapterManager, 'makeBidRequests');
+      makeRequestsStub.returns(bidRequests);
+      ajaxStub = sinon.stub(ajaxLib, 'ajaxBuilder').callsFake(mockAjaxBuilder);
       createAuctionStub = sinon.stub(auctionModule, 'newAuction');
       createAuctionStub.returns(auction);
+      indexAuctions = [auction];
 
       spec = mockBidder(BIDDER_CODE, bids);
       spec1 = mockBidder(BIDDER_CODE1, bids1);
@@ -1045,6 +1046,8 @@ describe('auctionmanager.js', function () {
 
     afterEach(function () {
       auctionModule.newAuction.restore();
+      ajaxStub.restore();
+      adapterManager.makeBidRequests.restore();
     });
 
     it('should not alter bid requestID', function () {
@@ -1134,14 +1137,6 @@ describe('auctionmanager.js', function () {
       logInfoStub = sinon.stub(utils, 'logInfo');
       logWarnStub = sinon.stub(utils, 'logWarn');
       logErrorStub = sinon.stub(utils, 'logError');
-      let bidRequests = [
-        mockBidRequest(bids[0]),
-        mockBidRequest(bids1[0], { adUnitCode: ADUNIT_CODE1 })
-      ];
-      let makeRequestsStub = sinon.stub(adapterManager, 'makeBidRequests');
-      makeRequestsStub.returns(bidRequests);
-
-      ajaxStub = sinon.stub(ajaxLib, 'ajaxBuilder').callsFake(mockAjaxBuilder);
     });
 
     after(function () {
@@ -1149,8 +1144,6 @@ describe('auctionmanager.js', function () {
       logInfoStub.restore();
       logWarnStub.restore();
       logErrorStub.restore();
-      ajaxStub.restore();
-      adapterManager.makeBidRequests.restore();
     });
 
     beforeEach(function () {
@@ -1167,11 +1160,13 @@ describe('auctionmanager.js', function () {
 
       adUnits = [{
         code: ADUNIT_CODE,
+        transactionId: ADUNIT_CODE,
         bids: [
           {bidder: BIDDER_CODE, params: {placementId: 'id'}},
         ]
       }, {
         code: ADUNIT_CODE1,
+        transactionId: ADUNIT_CODE1,
         bids: [
           {bidder: BIDDER_CODE1, params: {placementId: 'id'}},
         ]
@@ -1180,6 +1175,15 @@ describe('auctionmanager.js', function () {
       auction = auctionModule.newAuction({adUnits, adUnitCodes, callback: function() {}, cbTimeout: 3000});
       createAuctionStub = sinon.stub(auctionModule, 'newAuction');
       createAuctionStub.returns(auction);
+      indexAuctions = [auction];
+      let bidRequests = [
+        mockBidRequest(bids[0], { auctionId: auction.getAuctionId() }),
+        mockBidRequest(bids1[0], { auctionId: auction.getAuctionId(), adUnitCode: ADUNIT_CODE1 })
+      ];
+      let makeRequestsStub = sinon.stub(adapterManager, 'makeBidRequests');
+      makeRequestsStub.returns(bidRequests);
+
+      ajaxStub = sinon.stub(ajaxLib, 'ajaxBuilder').callsFake(mockAjaxBuilder);
 
       spec = mockBidder(BIDDER_CODE, bids);
       spec1 = mockBidder(BIDDER_CODE1, bids1);
@@ -1194,6 +1198,8 @@ describe('auctionmanager.js', function () {
       logWarnStub.resetHistory();
       logErrorStub.resetHistory();
       auctionModule.newAuction.restore();
+      ajaxStub.restore();
+      adapterManager.makeBidRequests.restore();
       config.resetConfig();
     });
 
@@ -1212,12 +1218,10 @@ describe('auctionmanager.js', function () {
 
   describe('getMediaTypeGranularity', function () {
     it('video', function () {
-      let bidReq = {
-        'mediaTypes': { video: {id: '1'} }
-      };
+      let mediaTypes = { video: {id: '1'} };
 
       // mediaType is video and video.context is undefined
-      expect(getMediaTypeGranularity('video', bidReq, {
+      expect(getMediaTypeGranularity('video', mediaTypes, {
         banner: 'low',
         video: 'medium'
       })).to.equal('medium');
@@ -1233,10 +1237,8 @@ describe('auctionmanager.js', function () {
       })).to.equal('medium');
 
       // also when mediaTypes.video is undefined
-      bidReq = {
-        'mediaTypes': { banner: {} }
-      };
-      expect(getMediaTypeGranularity('video', bidReq, {
+      mediaTypes = { banner: {} };
+      expect(getMediaTypeGranularity('video', mediaTypes, {
         banner: 'low',
         video: 'medium'
       })).to.equal('medium');
@@ -1249,22 +1251,22 @@ describe('auctionmanager.js', function () {
     });
 
     it('video-outstream', function () {
-      let bidReq = { 'mediaTypes': { video: { context: 'outstream' } } };
+      let mediaTypes = { video: { context: 'outstream' } };
 
-      expect(getMediaTypeGranularity('video', bidReq, {
+      expect(getMediaTypeGranularity('video', mediaTypes, {
         'banner': 'low', 'video': 'medium', 'video-outstream': 'high'
       })).to.equal('high');
     });
 
     it('video-instream', function () {
-      let bidReq = { 'mediaTypes': { video: { context: 'instream' } } };
+      let mediaTypes = { video: { context: 'instream' } };
 
-      expect(getMediaTypeGranularity('video', bidReq, {
+      expect(getMediaTypeGranularity('video', mediaTypes, {
         banner: 'low', video: 'medium', 'video-instream': 'high'
       })).to.equal('high');
 
       // fall back to video if video-instream not found
-      expect(getMediaTypeGranularity('video', bidReq, {
+      expect(getMediaTypeGranularity('video', mediaTypes, {
         banner: 'low', video: 'medium'
       })).to.equal('medium');
 
@@ -1274,12 +1276,53 @@ describe('auctionmanager.js', function () {
     });
 
     it('native', function () {
-      expect(getMediaTypeGranularity('native', {mediaTypes: {native: {}}}, {
+      expect(getMediaTypeGranularity('native', {native: {}}, {
         banner: 'low', video: 'medium', native: 'high'
       })).to.equal('high');
     });
   });
 
+  function mockAuction(getBidRequests, start = 1) {
+    return {
+      getBidRequests: getBidRequests,
+      getAdUnits: () => getBidRequests().flatMap(br => br.bids).map(br => ({ code: br.adUnitCode, transactionId: br.transactionId, mediaTypes: br.mediaTypes })),
+      getAuctionId: () => '1',
+      addBidReceived: () => true,
+      getTimeout: () => 1000,
+      getAuctionStart: () => start,
+    }
+  }
+
+  describe('getPriceByGranularity', () => {
+    beforeEach(() => {
+      config.setConfig({
+        mediaTypePriceGranularity: {
+          video: 'medium',
+          banner: 'low'
+        }
+      });
+    })
+
+    afterEach(() => {
+      config.resetConfig();
+    })
+
+    it('evaluates undef granularity on each call', () => {
+      const gpbg = getPriceByGranularity();
+      expect(gpbg({
+        mediaType: 'video', pbMg: 'medium'
+      }, {
+        'mediaTypes': {video: {id: '1'}}
+      })).to.equal('medium');
+      expect(gpbg({
+        mediaType: 'banner',
+        pbLg: 'low'
+      }, {
+        'mediaTypes': {banner: {}}
+      })).to.equal('low');
+    });
+  })
+
   describe('auctionCallbacks', function() {
     let bids = TEST_BIDS;
     let bidRequests;
@@ -1287,20 +1330,15 @@ describe('auctionmanager.js', function () {
     let auction;
 
     beforeEach(() => {
+      const start = Date.now();
+      auction = mockAuction(() => bidRequests, start);
+      indexAuctions = [auction];
       doneSpy = sinon.spy();
       config.setConfig({
         cache: {
           url: 'https://prebid.adnxs.com/pbc/v1/cache'
         }
       });
-      const start = Date.now();
-      auction = {
-        getBidRequests: () => bidRequests,
-        getAuctionId: () => '1',
-        addBidReceived: () => true,
-        getTimeout: () => 1000,
-        getAuctionStart: () => start,
-      }
     });
 
     afterEach(() => {
@@ -1313,8 +1351,8 @@ describe('auctionmanager.js', function () {
       let ADUNIT_CODE2 = 'adUnitCode2';
       let BIDDER_CODE2 = 'sampleBidder2';
 
-      let bids1 = [mockBid({ bidderCode: BIDDER_CODE1 })];
-      let bids2 = [mockBid({ bidderCode: BIDDER_CODE2 })];
+      let bids1 = [mockBid({ bidderCode: BIDDER_CODE1, transactionId: ADUNIT_CODE1 })];
+      let bids2 = [mockBid({ bidderCode: BIDDER_CODE2, transactionId: ADUNIT_CODE2 })];
       bidRequests = [
         mockBidRequest(bids[0]),
         mockBidRequest(bids1[0], { adUnitCode: ADUNIT_CODE1 }),
@@ -1370,7 +1408,7 @@ describe('auctionmanager.js', function () {
       }
 
       function invokeCallbacks() {
-        bids.forEach((bid, i) => callbacks.addBidResponse.call(bidRequests[i], ADUNIT_CODE, bid));
+        bids.forEach((bid) => callbacks.addBidResponse(ADUNIT_CODE, bid));
         bidRequests.forEach(bidRequest => callbacks.adapterDone.call(bidRequest));
       }
 
@@ -1399,6 +1437,19 @@ describe('auctionmanager.js', function () {
         addBidResponse.getHooks({hook: hook}).remove();
       });
 
+      it('should wait for bids without a request bids before calling auctionDone', () => {
+        callbacks.addBidResponse(ADUNIT_CODE, Object.assign(mockBid(), {requestId: null}));
+        invokeCallbacks();
+        resolvers.resolve.slice(1, 3).forEach((fn) => fn());
+        return delay().then(() => {
+          expect(doneSpy.called).to.be.false;
+          resolvers.resolve[0]();
+          return delay();
+        }).then(() => {
+          expect(doneSpy.called).to.be.true;
+        });
+      });
+
       Object.entries({
         'all succeed': ['resolve', 'resolve'],
         'some fail': ['resolve', 'reject'],
@@ -1464,10 +1515,10 @@ describe('auctionmanager.js', function () {
     let bidRequests;
     let doneSpy;
     let clock;
-    let auction;
     let requiredBidder = BIDDER_CODE;
     let requiredBidder1 = BIDDER_CODE1;
     let secondaryBidder = 'doNotWaitForMe';
+    let auction;
 
     beforeEach(() => {
       clock = sinon.useFakeTimers();
@@ -1477,14 +1528,10 @@ describe('auctionmanager.js', function () {
           secondaryBidders: [ secondaryBidder ]
         }
       });
+
       const start = Date.now();
-      auction = {
-        getBidRequests: () => bidRequests,
-        getAuctionId: () => '1',
-        addBidReceived: () => true,
-        getTimeout: () => 1000,
-        getAuctionStart: () => start,
-      }
+      auction = mockAuction(() => bidRequests);
+      indexAuctions = [auction];
     });
 
     afterEach(() => {
@@ -1494,9 +1541,9 @@ describe('auctionmanager.js', function () {
     });
 
     it('should not wait to call auction done for secondary bidders', function () {
-      let bids1 = [mockBid({ bidderCode: requiredBidder })];
-      let bids2 = [mockBid({ bidderCode: requiredBidder1 })];
-      let bids3 = [mockBid({ bidderCode: secondaryBidder })];
+      let bids1 = [mockBid({ bidderCode: requiredBidder, transactionId: ADUNIT_CODE1 })];
+      let bids2 = [mockBid({ bidderCode: requiredBidder1, transactionId: ADUNIT_CODE1 })];
+      let bids3 = [mockBid({ bidderCode: secondaryBidder, transactionId: ADUNIT_CODE1 })];
       bidRequests = [
         mockBidRequest(bids1[0], { adUnitCode: ADUNIT_CODE1 }),
         mockBidRequest(bids2[0], { adUnitCode: ADUNIT_CODE1 }),

package/test/spec/config_spec.js

@@ -16,8 +16,10 @@ let setDefaults;
 describe('config API', function () {
   let logErrorSpy;
   let logWarnSpy;
+  let config;
+
   beforeEach(function () {
-    const config = newConfig();
+    config = newConfig();
     getConfig = config.getConfig;
     setConfig = config.setConfig;
     readConfig = config.readConfig;
@@ -624,4 +626,25 @@ describe('config API', function () {
     expect(ortb2Config.user.data).to.have.lengthOf(2);
     expect(ortb2Config.site.content.data).to.have.lengthOf(1);
   });
+
+  it('should not corrupt global configuration with bidder configuration', () => {
+    // https://github.com/prebid/Prebid.js/issues/7956
+    config.setConfig({
+      outer: {
+        inner: ['global']
+      }
+    });
+    config.setBidderConfig({
+      bidders: ['bidder'],
+      config: {
+        outer: {
+          inner: ['bidder']
+        }
+      }
+    });
+    config.runWithBidder('bidder', () => config.getConfig())
+    expect(config.getConfig('outer')).to.eql({
+      inner: ['global']
+    });
+  });
 });

package/test/spec/debugging_spec.js

@@ -3,10 +3,15 @@ import { expect } from 'chai';
 import { sessionLoader, addBidResponseHook, addBidderRequestsHook, getConfig, disableOverrides, addBidResponseBound, addBidderRequestsBound } from 'src/debugging.js';
 import { addBidResponse, addBidderRequests } from 'src/auction.js';
 import { config } from 'src/config.js';
+import {hook} from '../../src/hook.js';
 
 describe('bid overrides', function () {
   let sandbox;
 
+  before(() => {
+    hook.ready();
+  });
+
   beforeEach(function () {
     sandbox = sinon.sandbox.create();
   });
@@ -109,8 +114,14 @@ describe('bid overrides', function () {
       });
 
       expect(bids.length).to.equal(2);
-      expect(bids[0].cpm).to.equal(2);
-      expect(bids[1].cpm).to.equal(2);
+      sinon.assert.match(bids[0], {
+        cpm: 2,
+        isDebug: true,
+      })
+      sinon.assert.match(bids[1], {
+        cpm: 2,
+        isDebug: true,
+      });
     });
 
     it('should allow us to override bids by bidder', function () {
@@ -123,8 +134,14 @@ describe('bid overrides', function () {
       });
 
       expect(bids.length).to.equal(2);
-      expect(bids[0].cpm).to.equal(2);
-      expect(bids[1].cpm).to.equal(0.5);
+      sinon.assert.match(bids[0], {
+        cpm: 2,
+        isDebug: true
+      });
+      sinon.assert.match(bids[1], {
+        cpm: 0.5,
+        isDebug: sinon.match.falsy
+      })
     });
 
     it('should allow us to override bids by adUnitCode', function () {
@@ -139,8 +156,14 @@ describe('bid overrides', function () {
       });
 
       expect(bids.length).to.equal(2);
-      expect(bids[0].cpm).to.equal(0.5);
-      expect(bids[1].cpm).to.equal(2);
+      sinon.assert.match(bids[0], {
+        cpm: 0.5,
+        isDebug: sinon.match.falsy,
+      });
+      sinon.assert.match(bids[1], {
+        cpm: 2,
+        isDebug: true,
+      });
     });
   });