prebid.js 6.6.0 → 6.10.0

package/test/spec/modules/pilotxBidAdapter_spec.js

@@ -0,0 +1,244 @@
+// import or require modules necessary for the test, e.g.:
+import { expect } from 'chai'; // may prefer 'assert' in place of 'expect'
+import { spec } from '../../../modules/pilotxBidAdapter.js';
+
+describe('pilotxAdapter', function () {
+  describe('isBidRequestValid', function () {
+    let banner;
+    beforeEach(function () {
+      banner = {
+        bidder: 'pilotx',
+        adUnitCode: 'adunit-test',
+        mediaTypes: { banner: {} },
+        sizes: [[300, 250], [468, 60]],
+        bidId: '2de8c82e30665a',
+        params: {
+          placementId: '1'
+        }
+      };
+    });
+
+    it('should return false if sizes is empty', function () {
+      banner.sizes = []
+      expect(spec.isBidRequestValid(banner)).to.equal(false);
+    });
+    it('should return true if all is valid/ is not empty', function () {
+      expect(spec.isBidRequestValid(banner)).to.equal(true);
+    });
+    it('should return false if there is no placement id found', function () {
+      banner.params = {}
+      expect(spec.isBidRequestValid(banner)).to.equal(false);
+    });
+    it('should return false if sizes is empty', function () {
+      banner.sizes = []
+      expect(spec.isBidRequestValid(banner)).to.equal(false);
+    });
+    it('should return false for no size and empty params', function() {
+      const emptySizes = {
+        bidder: 'pilotx',
+        adUnitCode: 'adunit-test',
+        mediaTypes: { banner: {} },
+        bidId: '2de8c82e30665a',
+        params: {
+          placementId: '1',
+          sizes: []
+        }
+      };
+      expect(spec.isBidRequestValid(emptySizes)).to.equal(false);
+    })
+    it('should return true for no size and valid size params', function() {
+      const emptySizes = {
+        bidder: 'pilotx',
+        adUnitCode: 'adunit-test',
+        mediaTypes: { banner: {} },
+        bidId: '2de8c82e30665a',
+        params: {
+          placementId: '1',
+          sizes: [[300, 250], [468, 60]]
+        }
+      };
+      expect(spec.isBidRequestValid(emptySizes)).to.equal(true);
+    })
+    it('should return false for no size items', function() {
+      const emptySizes = {
+        bidder: 'pilotx',
+        adUnitCode: 'adunit-test',
+        mediaTypes: { banner: {} },
+        bidId: '2de8c82e30665a',
+        params: {
+          placementId: '1'
+        }
+      };
+      expect(spec.isBidRequestValid(emptySizes)).to.equal(false);
+    })
+  });
+
+  describe('buildRequests', function () {
+    const mockRequest = { refererInfo: {} };
+    const mockRequestGDPR = {
+      refererInfo: {},
+      gdprConsent: {
+        consentString: 'BOJ/P2HOJ/P2HABABMAAAAAZ+A==',
+        gdprApplies: true
+      }
+
+    }
+    const mockVideo1 = [{
+      adUnitCode: 'video1',
+      auctionId: '01618029-7ae9-4e98-a73a-1ed0c817f414',
+      bidId: '2a59588c0114fa',
+      bidRequestsCount: 1,
+      bidder: 'pilotx',
+      bidderRequestId: '1f6b4ba2039726',
+      bidderRequestsCount: 1,
+      bidderWinsCount: 0,
+      crumbs: { pubcid: 'de5240ef-ff80-4b55-8837-26a11cfbf64c' },
+      mediaTypes: {
+        video: {
+          context: 'instream',
+          mimes: ['video/mp4'],
+          playbackmethod: [2],
+          playerSize: [[640, 480]],
+          protocols: [1, 2, 3, 4, 5, 6, 7, 8],
+          skip: 1
+        }
+      },
+      ortb2Imp: {
+        ext: {
+          data: {
+            pbadslot: 'video1'
+          }
+        }
+      },
+      params: { placementId: '379' },
+      sizes: [[640, 480]],
+      src: 'client',
+      transactionId: 'fec9f2ff-da13-4921-8437-8d679c2be7fe',
+    }];
+    const mockVideo2 = [{
+      adUnitCode: 'video1',
+      auctionId: '01618029-7ae9-4e98-a73a-1ed0c817f414',
+      bidId: '2a59588c0114fa',
+      bidRequestsCount: 1,
+      bidder: 'pilotx',
+      bidderRequestId: '1f6b4ba2039726',
+      bidderRequestsCount: 1,
+      bidderWinsCount: 0,
+      crumbs: { pubcid: 'de5240ef-ff80-4b55-8837-26a11cfbf64c' },
+      mediaTypes: {
+        video: {
+          context: 'instream',
+          mimes: ['video/mp4'],
+          playbackmethod: [2],
+          playerSize: [[640, 480]],
+          protocols: [1, 2, 3, 4, 5, 6, 7, 8],
+          skip: 1
+        }
+      },
+      ortb2Imp: {
+        ext: {
+          data: {
+            pbadslot: 'video1'
+          }
+        }
+      },
+      params: { placementId: '379' },
+      sizes: [640, 480],
+      src: 'client',
+      transactionId: 'fec9f2ff-da13-4921-8437-8d679c2be7fe',
+    }];
+    it('should return correct response', function () {
+      const builtRequest = spec.buildRequests(mockVideo1, mockRequest)
+      let builtRequestData = builtRequest.data
+      let data = JSON.parse(builtRequestData)
+      expect(data['379'].bidId).to.equal(mockVideo1[0].bidId)
+    });
+    it('should return correct response for only array of size', function () {
+      const builtRequest = spec.buildRequests(mockVideo2, mockRequest)
+      let builtRequestData = builtRequest.data
+      let data = JSON.parse(builtRequestData)
+      expect(data['379'].sizes[0][0]).to.equal(mockVideo2[0].sizes[0])
+      expect(data['379'].sizes[0][1]).to.equal(mockVideo2[0].sizes[1])
+    });
+    it('should be valid and pass gdpr items correctly', function () {
+      const builtRequest = spec.buildRequests(mockVideo2, mockRequestGDPR)
+      let builtRequestData = builtRequest.data
+      let data = JSON.parse(builtRequestData)
+      expect(data['379'].gdprConsentString).to.equal(mockRequestGDPR.gdprConsent.consentString)
+      expect(data['379'].gdprConsentRequired).to.equal(mockRequestGDPR.gdprConsent.gdprApplies)
+    });
+  });
+  describe('interpretResponse', function () {
+    const bidRequest = {}
+    const serverResponse = {
+      cpm: 2.5,
+      creativeId: 'V9060',
+      currency: 'US',
+      height: 480,
+      mediaType: 'video',
+      netRevenue: false,
+      requestId: '273b39c74069cb',
+      ttl: 3000,
+      vastUrl: 'http://testadserver.com/ads?&k=60cd901ad8ab70c9cedf373cb17b93b8&pid=379&tid=91342717',
+      width: 640
+    }
+    const serverResponseVideo = {
+      body: serverResponse
+    }
+    const serverResponse2 = {
+      cpm: 2.5,
+      creativeId: 'V9060',
+      currency: 'US',
+      height: 480,
+      mediaType: 'banner',
+      netRevenue: false,
+      requestId: '273b39c74069cb',
+      ttl: 3000,
+      vastUrl: 'http://testadserver.com/ads?&k=60cd901ad8ab70c9cedf373cb17b93b8&pid=379&tid=91342717',
+      width: 640
+    }
+    const serverResponseBanner = {
+      body: serverResponse2
+    }
+    it('should be valid from bidRequest for video', function () {
+      const bidResponses = spec.interpretResponse(serverResponseVideo, bidRequest)
+      expect(bidResponses[0].requestId).to.equal(serverResponse.requestId)
+      expect(bidResponses[0].cpm).to.equal(serverResponse.cpm)
+      expect(bidResponses[0].width).to.equal(serverResponse.width)
+      expect(bidResponses[0].height).to.equal(serverResponse.height)
+      expect(bidResponses[0].creativeId).to.equal(serverResponse.creativeId)
+      expect(bidResponses[0].currency).to.equal(serverResponse.currency)
+      expect(bidResponses[0].netRevenue).to.equal(serverResponse.netRevenue)
+      expect(bidResponses[0].ttl).to.equal(serverResponse.ttl)
+      expect(bidResponses[0].vastUrl).to.equal(serverResponse.vastUrl)
+      expect(bidResponses[0].mediaType).to.equal(serverResponse.mediaType)
+      expect(bidResponses[0].meta.mediaType).to.equal(serverResponse.mediaType)
+    });
+    it('should be valid from bidRequest for banner', function () {
+      const bidResponses = spec.interpretResponse(serverResponseBanner, bidRequest)
+      expect(bidResponses[0].requestId).to.equal(serverResponse2.requestId)
+      expect(bidResponses[0].cpm).to.equal(serverResponse2.cpm)
+      expect(bidResponses[0].width).to.equal(serverResponse2.width)
+      expect(bidResponses[0].height).to.equal(serverResponse2.height)
+      expect(bidResponses[0].creativeId).to.equal(serverResponse2.creativeId)
+      expect(bidResponses[0].currency).to.equal(serverResponse2.currency)
+      expect(bidResponses[0].netRevenue).to.equal(serverResponse2.netRevenue)
+      expect(bidResponses[0].ttl).to.equal(serverResponse2.ttl)
+      expect(bidResponses[0].ad).to.equal(serverResponse2.ad)
+      expect(bidResponses[0].mediaType).to.equal(serverResponse2.mediaType)
+      expect(bidResponses[0].meta.mediaType).to.equal(serverResponse2.mediaType)
+    });
+  });
+  describe('setPlacementID', function () {
+    const multiplePlacementIds = ['380', '381']
+    it('should be valid with an array of placement ids passed', function () {
+      const placementID = spec.setPlacementID(multiplePlacementIds)
+      expect(placementID).to.equal('380#381')
+    });
+    it('should be valid with single placement ID passed', function () {
+      const placementID = spec.setPlacementID('381')
+      expect(placementID).to.equal('381')
+    });
+  });
+  // Add other `describe` or `it` blocks as necessary
+});

package/test/spec/modules/prebidServerBidAdapter_spec.js

@@ -9,6 +9,14 @@ import CONSTANTS from 'src/constants.json';
 import { server } from 'test/mocks/xhr.js';
 import { createEidsArray } from 'modules/userId/eids.js';
 import {deepAccess, deepClone} from 'src/utils.js';
+import 'modules/appnexusBidAdapter.js' // appnexus alias test
+import 'modules/rubiconBidAdapter.js' // rubicon alias test
+import 'src/prebid.js' // $$PREBID_GLOBAL$$.aliasBidder test
+import 'modules/currency.js' // adServerCurrency test
+import {hook} from '../../../src/hook.js';
+import {decorateAdUnitsWithNativeParams} from '../../../src/native.js';
+import {auctionManager} from '../../../src/auctionManager.js';
+import {stubAuctionIndex} from '../../helpers/indexStub.js';
 
 let CONFIG = {
   accountId: '1',
@@ -448,6 +456,16 @@ describe('S2S Adapter', function () {
     addBidResponse = sinon.spy(),
     done = sinon.spy();
 
+  function prepRequest(req) {
+    req.ad_units.forEach((adUnit) => { delete adUnit.nativeParams });
+    decorateAdUnitsWithNativeParams(req.ad_units);
+  }
+
+  before(() => {
+    hook.ready();
+    prepRequest(REQUEST);
+  });
+
   beforeEach(function () {
     config.resetConfig();
     adapter = new Adapter();
@@ -1096,6 +1114,7 @@ describe('S2S Adapter', function () {
     it('should not include ext.aspectratios if adunit\'s aspect_ratios do not define radio_width and ratio_height', () => {
       const req = deepClone(REQUEST);
       req.ad_units[0].mediaTypes.native.icon.aspect_ratios[0] = {'min_width': 1, 'min_height': 2};
+      prepRequest(req);
       adapter.callBids(req, BID_REQUESTS, addBidResponse, done, ajax);
       const nativeReq = JSON.parse(JSON.parse(server.requests[0].requestBody).imp[0].native.request);
       const icons = nativeReq.assets.map((a) => a.img).filter((img) => img && img.type === 1);
@@ -2404,11 +2423,8 @@ describe('S2S Adapter', function () {
     });
 
     it('handles OpenRTB native responses', function () {
-      sinon.stub(utils, 'getBidRequest').returns({
-        adUnitCode: 'div-gpt-ad-1460505748561-0',
-        bidder: 'appnexus',
-        bidId: '123'
-      });
+      const stub = sinon.stub(auctionManager, 'index');
+      stub.get(() => stubAuctionIndex({adUnits: REQUEST.ad_units}));
       const s2sConfig = Object.assign({}, CONFIG, {
         endpoint: {
           p1Consent: 'https://prebidserverurl/openrtb2/auction?querystring=param'
@@ -2431,7 +2447,28 @@ describe('S2S Adapter', function () {
       expect(response).to.have.property('requestId', '123');
       expect(response).to.have.property('cpm', 10);
 
-      utils.getBidRequest.restore();
+      stub.restore();
+    });
+
+    it('does not (by default) allow bids that were not requested', function () {
+      config.setConfig({ s2sConfig: CONFIG });
+      adapter.callBids(REQUEST, BID_REQUESTS, addBidResponse, done, ajax);
+      const response = deepClone(RESPONSE_OPENRTB);
+      response.seatbid[0].seat = 'unknown';
+      server.requests[0].respond(200, {}, JSON.stringify(response));
+
+      expect(addBidResponse.called).to.be.false;
+    });
+
+    it('allows unrequested bids if config.allowUnknownBidderCodes', function () {
+      const cfg = {...CONFIG, allowUnknownBidderCodes: true};
+      config.setConfig({s2sConfig: cfg});
+      adapter.callBids({...REQUEST, s2sConfig: cfg}, BID_REQUESTS, addBidResponse, done, ajax);
+      const response = deepClone(RESPONSE_OPENRTB);
+      response.seatbid[0].seat = 'unknown';
+      server.requests[0].respond(200, {}, JSON.stringify(response));
+
+      expect(addBidResponse.calledWith(sinon.match.any, sinon.match({bidderCode: 'unknown'}))).to.be.true;
     });
 
     describe('on sync requested with no cookie', () => {

package/test/spec/modules/priceFloors_spec.js

@@ -16,6 +16,10 @@ import {
 } from 'modules/priceFloors.js';
 import events from 'src/events.js';
 import * as mockGpt from '../integration/faker/googletag.js';
+import 'src/prebid.js';
+import {createBid} from '../../../src/bidfactory.js';
+import {auctionManager} from '../../../src/auctionManager.js';
+import {stubAuctionIndex} from '../../helpers/indexStub.js';
 
 describe('the price floors module', function () {
   let logErrorSpy;
@@ -401,6 +405,7 @@ describe('the price floors module', function () {
     });
     describe('with gpt enabled', function () {
       let gptFloorData;
+      let indexStub, adUnits;
       beforeEach(function () {
         gptFloorData = {
           currency: 'USD',
@@ -426,10 +431,13 @@ describe('the price floors module', function () {
           code: '/12345/sports/basketball',
           divId: 'test_div_2'
         });
+        indexStub = sinon.stub(auctionManager, 'index');
+        indexStub.get(() => stubAuctionIndex({adUnits}))
       });
       afterEach(function () {
         // reset it so no lingering stuff from other test specs
         mockGpt.reset();
+        indexStub.restore();
       });
       it('picks the right rule when looking for gptSlot', function () {
         expect(getFirstMatchingFloor(gptFloorData, basicBidRequest)).to.deep.equal({
@@ -449,9 +457,10 @@ describe('the price floors module', function () {
           matchingRule: '/12345/sports/basketball'
         });
       });
-      it('picks the gptSlot from the bidRequest and does not call the slotMatching', function () {
-        const newBidRequest1 = { ...basicBidRequest };
-        utils.deepSetValue(newBidRequest1, 'ortb2Imp.ext.data.adserver', {
+      it('picks the gptSlot from the adUnit and does not call the slotMatching', function () {
+        const newBidRequest1 = { ...basicBidRequest, transactionId: 'au1' };
+        adUnits = [{code: newBidRequest1.code, transactionId: 'au1'}];
+        utils.deepSetValue(adUnits[0], 'ortb2Imp.ext.data.adserver', {
           name: 'gam',
           adslot: '/12345/news/politics'
         })
@@ -463,8 +472,9 @@ describe('the price floors module', function () {
           matchingRule: '/12345/news/politics'
         });
 
-        const newBidRequest2 = { ...basicBidRequest, adUnitCode: 'test_div_2' };
-        utils.deepSetValue(newBidRequest2, 'ortb2Imp.ext.data.adserver', {
+        const newBidRequest2 = { ...basicBidRequest, adUnitCode: 'test_div_2', transactionId: 'au2' };
+        adUnits = [{code: newBidRequest2.adUnitCode, transactionId: newBidRequest2.transactionId}];
+        utils.deepSetValue(adUnits[0], 'ortb2Imp.ext.data.adserver', {
           name: 'gam',
           adslot: '/12345/news/weather'
         })
@@ -1565,17 +1575,12 @@ describe('the price floors module', function () {
     });
   });
   describe('bidResponseHook tests', function () {
-    let returnedBidResponse;
-    let bidderRequest = {
-      bidderCode: 'appnexus',
-      auctionId: '123456',
-      bids: [{
-        bidder: 'appnexus',
-        adUnitCode: 'test_div_1',
-        auctionId: '123456',
-        bidId: '1111'
-      }]
-    };
+    const AUCTION_ID = '123456';
+    let returnedBidResponse, indexStub;
+    let adUnit = {
+      transactionId: 'au',
+      code: 'test_div_1'
+    }
     let basicBidResponse = {
       bidderCode: 'appnexus',
       width: 300,
@@ -1583,38 +1588,46 @@ describe('the price floors module', function () {
       cpm: 0.5,
       mediaType: 'banner',
       requestId: '1111',
+      transactionId: 'au',
     };
     beforeEach(function () {
       returnedBidResponse = {};
+      indexStub = sinon.stub(auctionManager, 'index');
+      indexStub.get(() => stubAuctionIndex({adUnits: [adUnit]}));
     });
+
+    afterEach(() => {
+      indexStub.restore();
+    });
+
     function runBidResponse(bidResp = basicBidResponse) {
       let next = (adUnitCode, bid) => {
         returnedBidResponse = bid;
       };
-      addBidResponseHook.bind({ bidderRequest })(next, bidResp.adUnitCode, bidResp);
+      addBidResponseHook(next, bidResp.adUnitCode, Object.assign(createBid(CONSTANTS.STATUS.GOOD, {auctionId: AUCTION_ID}), bidResp));
     };
     it('continues with the auction if not floors data is present without any flooring', function () {
       runBidResponse();
       expect(returnedBidResponse).to.not.haveOwnProperty('floorData');
     });
     it('if no matching rule it should not floor and should call log warn', function () {
-      _floorDataForAuction[bidderRequest.auctionId] = utils.deepClone(basicFloorConfig);
-      _floorDataForAuction[bidderRequest.auctionId].data.values = { 'video': 1.0 };
+      _floorDataForAuction[AUCTION_ID] = utils.deepClone(basicFloorConfig);
+      _floorDataForAuction[AUCTION_ID].data.values = { 'video': 1.0 };
       runBidResponse();
       expect(returnedBidResponse).to.not.haveOwnProperty('floorData');
       expect(logWarnSpy.calledOnce).to.equal(true);
     });
     it('if it finds a rule and floors should update the bid accordingly', function () {
-      _floorDataForAuction[bidderRequest.auctionId] = utils.deepClone(basicFloorConfig);
-      _floorDataForAuction[bidderRequest.auctionId].data.values = { 'banner': 1.0 };
+      _floorDataForAuction[AUCTION_ID] = utils.deepClone(basicFloorConfig);
+      _floorDataForAuction[AUCTION_ID].data.values = { 'banner': 1.0 };
       runBidResponse();
       expect(returnedBidResponse).to.haveOwnProperty('floorData');
       expect(returnedBidResponse.status).to.equal(CONSTANTS.BID_STATUS.BID_REJECTED);
       expect(returnedBidResponse.cpm).to.equal(0);
     });
     it('if it finds a rule and does not floor should update the bid accordingly', function () {
-      _floorDataForAuction[bidderRequest.auctionId] = utils.deepClone(basicFloorConfig);
-      _floorDataForAuction[bidderRequest.auctionId].data.values = { 'banner': 0.3 };
+      _floorDataForAuction[AUCTION_ID] = utils.deepClone(basicFloorConfig);
+      _floorDataForAuction[AUCTION_ID].data.values = { 'banner': 0.3 };
       runBidResponse();
       expect(returnedBidResponse).to.haveOwnProperty('floorData');
       expect(returnedBidResponse.floorData).to.deep.equal({
@@ -1636,7 +1649,7 @@ describe('the price floors module', function () {
       expect(returnedBidResponse.cpm).to.equal(0.5);
     });
     it('if should work with more complex rules and update accordingly', function () {
-      _floorDataForAuction[bidderRequest.auctionId] = {
+      _floorDataForAuction[AUCTION_ID] = {
         ...basicFloorConfig,
         data: {
           currency: 'USD',

package/test/spec/modules/pubmaticBidAdapter_spec.js

@@ -3861,4 +3861,44 @@ describe('PubMatic adapter', function () {
       })
     });
   });
+
+  describe('Video request params', function() {
+    let sandbox, utilsMock, newVideoRequest;
+    beforeEach(() => {
+      utilsMock = sinon.mock(utils);
+      sandbox = sinon.sandbox.create();
+      sandbox.spy(utils, 'logWarn');
+      newVideoRequest = utils.deepClone(videoBidRequests)
+    });
+
+    afterEach(() => {
+      utilsMock.restore();
+      sandbox.restore();
+    })
+
+    it('Should log warning if video params from mediaTypes and params obj of bid are not present', function () {
+      delete newVideoRequest[0].mediaTypes.video;
+      delete newVideoRequest[0].params.video;
+
+      let request = spec.buildRequests(newVideoRequest, {
+        auctionId: 'new-auction-id'
+      });
+
+      sinon.assert.calledOnce(utils.logWarn);
+      expect(request).to.equal(undefined);
+    });
+
+    it('Should consider video params from mediaType object of bid', function () {
+      delete newVideoRequest[0].params.video;
+
+      let request = spec.buildRequests(newVideoRequest, {
+        auctionId: 'new-auction-id'
+      });
+      let data = JSON.parse(request.data);
+      expect(data.imp[0].video).to.exist;
+      expect(data.imp[0]['video']['w']).to.equal(videoBidRequests[0].mediaTypes.video.playerSize[0]);
+      expect(data.imp[0]['video']['h']).to.equal(videoBidRequests[0].mediaTypes.video.playerSize[1]);
+      expect(data.imp[0]['video']['battr']).to.equal(undefined);
+    });
+  });
 });

package/test/spec/modules/realTimeDataModule_spec.js

@@ -141,7 +141,56 @@ describe('Real time module', function () {
       const adUnits = rtdModule.getAdUnitTargeting(auction);
       assert.deepEqual(expectedAdUnits, adUnits)
       done();
-    })
+    });
+
+    describe('setBidRequestData', () => {
+      let withWait, withoutWait;
+
+      function runSetBidRequestData() {
+        return new Promise((resolve) => {
+          rtdModule.setBidRequestsData(resolve, {bidRequest: {}});
+        });
+      }
+
+      beforeEach(() => {
+        withWait = {
+          submod: validSMWait,
+          cbTime: 0,
+          cbRan: false
+        };
+        withoutWait = {
+          submod: validSM,
+          cbTime: 0,
+          cbRan: false
+        };
+
+        [withWait, withoutWait].forEach((c) => {
+          c.submod.getBidRequestData = sinon.stub().callsFake((_, cb) => {
+            setTimeout(() => {
+              c.cbRan = true;
+              cb();
+            }, c.cbTime);
+          });
+        });
+      });
+
+      it('should allow non-priority submodules to run synchronously', () => {
+        withWait.cbTime = withoutWait.cbTime = 0;
+        return runSetBidRequestData().then(() => {
+          expect(withWait.cbRan).to.be.true;
+          expect(withoutWait.cbRan).to.be.true;
+        })
+      });
+
+      it('should not wait for non-priority submodules if priority ones complete first', () => {
+        withWait.cbTime = 10;
+        withoutWait.cbTime = 100;
+        return runSetBidRequestData().then(() => {
+          expect(withWait.cbRan).to.be.true;
+          expect(withoutWait.cbRan).to.be.false;
+        });
+      });
+    });
   });
 
   it('deep merge object', function () {
@@ -255,5 +304,5 @@ describe('Real time module', function () {
         expect(providers[1][hook].called).to.be.true;
       });
     });
-  })
+  });
 });

package/test/spec/modules/riseBidAdapter_spec.js

@@ -3,7 +3,7 @@ import { spec } from 'modules/riseBidAdapter.js';
 import { newBidder } from 'src/adapters/bidderFactory.js';
 import { config } from 'src/config.js';
 import { VIDEO } from '../../../src/mediaTypes.js';
-import { deepClone } from 'src/utils.js';
+import * as utils from 'src/utils.js';
 
 const ENDPOINT = 'https://hb.yellowblue.io/hb';
 const TEST_ENDPOINT = 'https://hb.yellowblue.io/hb-test';
@@ -262,7 +262,7 @@ describe('riseAdapter', function () {
     });
 
     it('should set floor_price to getFloor.floor value if it is greater than params.floorPrice', function() {
-      const bid = deepClone(bidRequests[0]);
+      const bid = utils.deepClone(bidRequests[0]);
       bid.getFloor = () => {
         return {
           currency: 'USD',
@@ -276,7 +276,7 @@ describe('riseAdapter', function () {
     });
 
     it('should set floor_price to params.floorPrice value if it is greater than getFloor.floor', function() {
-      const bid = deepClone(bidRequests[0]);
+      const bid = utils.deepClone(bidRequests[0]);
       bid.getFloor = () => {
         return {
           currency: 'USD',
@@ -299,7 +299,8 @@ describe('riseAdapter', function () {
       requestId: '21e12606d47ba7',
       netRevenue: true,
       currency: 'USD',
-      adomain: ['abc.com']
+      adomain: ['abc.com'],
+      nurl: 'http://example.com/win/1234',
     };
 
     it('should get correct bid response', function () {
@@ -315,6 +316,7 @@ describe('riseAdapter', function () {
           ttl: TTL,
           vastXml: '<VAST version="3.0"></VAST>',
           mediaType: VIDEO,
+          nurl: 'http://example.com/win/1234',
           meta: {
             advertiserDomains: ['abc.com']
           }
@@ -402,4 +404,28 @@ describe('riseAdapter', function () {
       expect(syncs).to.deep.equal([]);
     });
   })
+
+  describe('onBidWon', function() {
+    beforeEach(function() {
+      sinon.stub(utils, 'triggerPixel');
+    });
+    afterEach(function() {
+      utils.triggerPixel.restore();
+    });
+
+    it('Should trigger pixel if bid nurl', function() {
+      const bid = {
+        'bidder': spec.code,
+        'adUnitCode': 'adunit-code',
+        'sizes': [['640', '480']],
+        'nurl': 'http://example.com/win/1234',
+        'params': {
+          'org': 'jdye8weeyirk00000001'
+        }
+      };
+
+      spec.onBidWon(bid);
+      expect(utils.triggerPixel.callCount).to.equal(1)
+    })
+  })
 });