prebid.js 6.22.0 → 6.23.0

package/test/spec/modules/improvedigitalBidAdapter_spec.js

@@ -1,7 +1,7 @@
 import { expect } from 'chai';
 import { spec } from 'modules/improvedigitalBidAdapter.js';
 import { config } from 'src/config.js';
-import * as utils from 'src/utils.js';
+import { deepClone } from 'src/utils.js';
 import {BANNER, VIDEO} from '../../../src/mediaTypes';
 
 describe('Improve Digital Adapter Tests', function () {
@@ -34,7 +34,7 @@ describe('Improve Digital Adapter Tests', function () {
     skipafter: 30
   }
 
-  const instreamBidRequest = utils.deepClone(simpleBidRequest);
+  const instreamBidRequest = deepClone(simpleBidRequest);
   instreamBidRequest.mediaTypes = {
     video: {
       context: 'instream',
@@ -42,7 +42,7 @@ describe('Improve Digital Adapter Tests', function () {
     }
   };
 
-  const outstreamBidRequest = utils.deepClone(simpleBidRequest);
+  const outstreamBidRequest = deepClone(simpleBidRequest);
   outstreamBidRequest.mediaTypes = {
     video: {
       context: 'outstream',
@@ -50,7 +50,7 @@ describe('Improve Digital Adapter Tests', function () {
     }
   };
 
-  const multiFormatBidRequest = utils.deepClone(simpleBidRequest);
+  const multiFormatBidRequest = deepClone(simpleBidRequest);
   multiFormatBidRequest.mediaTypes = {
     banner: {
       sizes: [[300, 250], [160, 600]]
@@ -294,6 +294,14 @@ describe('Improve Digital Adapter Tests', function () {
       expect(payload.user.ext.consented_providers_settings.consented_providers).to.exist.and.to.deep.equal([1, 35, 41, 101]);
     });
 
+    it('should not add consented providers when empty', function () {
+      const bidderRequestGdprEmptyAddtl = deepClone(bidderRequestGdpr);
+      bidderRequestGdprEmptyAddtl.gdprConsent.addtlConsent = '1~';
+      const bidRequest = Object.assign({}, simpleBidRequest);
+      const payload = JSON.parse(spec.buildRequests([bidRequest], bidderRequestGdprEmptyAddtl)[0].data);
+      expect(payload.user.ext.consented_providers_settings).to.not.exist;
+    });
+
     it('should add CCPA consent string', function () {
       const bidRequest = Object.assign({}, simpleBidRequest);
       const request = spec.buildRequests([bidRequest], {...bidderRequest, ...{ uspConsent: '1YYY' }});
@@ -308,6 +316,20 @@ describe('Improve Digital Adapter Tests', function () {
       expect(payload.site.page).to.equal('https://blah.com/test.html');
     });
 
+    it('should add timeout', function () {
+      const bidderRequestTimeout = deepClone(bidderRequest);
+      // Int
+      bidderRequestTimeout.timeout = 300;
+      const bidRequest = Object.assign({}, simpleBidRequest);
+      let request = spec.buildRequests([bidRequest], bidderRequestTimeout)[0];
+      expect(JSON.parse(request.data).tmax).to.equal(300);
+
+      // String
+      bidderRequestTimeout.timeout = '500';
+      request = spec.buildRequests([bidRequest], bidderRequestTimeout)[0];
+      expect(JSON.parse(request.data).tmax).to.equal(500);
+    });
+
     it('should not add video params for banner', function () {
       const bidRequest = JSON.parse(JSON.stringify(simpleBidRequest));
       bidRequest.params.video = videoParams;
@@ -916,7 +938,7 @@ describe('Improve Digital Adapter Tests', function () {
       }
     ];
 
-    const expectedBidOutstreamVideo = utils.deepClone(expectedBidInstreamVideo);
+    const expectedBidOutstreamVideo = deepClone(expectedBidInstreamVideo);
     expectedBidOutstreamVideo[0].adResponse = {
       content: expectedBidOutstreamVideo[0].vastXml
     };

package/test/spec/modules/insticatorBidAdapter_spec.js

@@ -1,7 +1,6 @@
 import { expect } from 'chai';
 import { spec, storage } from '../../../modules/insticatorBidAdapter.js';
 import { newBidder } from 'src/adapters/bidderFactory.js'
-import { userSync } from '../../../src/userSync.js';
 
 const USER_ID_KEY = 'hb_insticator_uid';
 const USER_ID_DUMMY_VALUE = '74f78609-a92d-4cf1-869f-1b244bbfb5d2';
@@ -18,15 +17,21 @@ describe('InsticatorBidAdapter', function () {
     adUnitCode: 'adunit-code',
     params: {
       adUnitId: '1a2b3c4d5e6f1a2b3c4d',
+      user: {
+        yob: 1984,
+        gender: 'M'
+      },
     },
     sizes: [[300, 250], [300, 600]],
     mediaTypes: {
       banner: {
-        sizes: [[300, 250], [300, 600]]
+        sizes: [[300, 250], [300, 600]],
+        pos: 4,
       }
     },
     bidId: '30b31c1838de1e',
     ortb2Imp: {
+      instl: 1,
       ext: {
         gpid: '1111/homepage'
       }
@@ -91,16 +96,16 @@ describe('InsticatorBidAdapter', function () {
     });
 
     it('should return false if there is no adUnitId param', () => {
-      expect(spec.isBidRequestValid({...bidRequest, ...{params: {}}})).to.be.false;
+      expect(spec.isBidRequestValid({ ...bidRequest, ...{ params: {} } })).to.be.false;
     });
 
     it('should return false if there is no mediaTypes', () => {
-      expect(spec.isBidRequestValid({...bidRequest, ...{mediaTypes: {}}})).to.be.false;
+      expect(spec.isBidRequestValid({ ...bidRequest, ...{ mediaTypes: {} } })).to.be.false;
     });
 
     it('should return false if there are no banner sizes and no sizes', () => {
       bidRequest.mediaTypes.banner = {};
-      expect(spec.isBidRequestValid({...bidRequest, ...{sizes: {}}})).to.be.false;
+      expect(spec.isBidRequestValid({ ...bidRequest, ...{ sizes: {} } })).to.be.false;
     });
 
     it('should return true if there is sizes and no banner sizes', () => {
@@ -109,7 +114,7 @@ describe('InsticatorBidAdapter', function () {
 
     it('should return true if there is banner sizes and no sizes', () => {
       bidRequest.mediaTypes.banner.sizes = [[300, 250], [300, 600]];
-      expect(spec.isBidRequestValid({...bidRequest, ...{sizes: {}}})).to.be.true;
+      expect(spec.isBidRequestValid({ ...bidRequest, ...{ sizes: {} } })).to.be.true;
     });
   });
 
@@ -207,6 +212,10 @@ describe('InsticatorBidAdapter', function () {
       expect(data.regs.ext.gdprConsentString).to.equal(bidderRequest.gdprConsent.consentString);
       expect(data.user).to.be.an('object');
       expect(data.user.id).to.equal(USER_ID_DUMMY_VALUE);
+      expect(data.user).to.have.property('yob');
+      expect(data.user.yob).to.equal(1984);
+      expect(data.user).to.have.property('gender');
+      expect(data.user.gender).to.equal('M');
       expect(data.user.ext).to.have.property('eids');
       expect(data.user.ext.eids).to.deep.equal([
         {
@@ -223,10 +232,12 @@ describe('InsticatorBidAdapter', function () {
       expect(data.imp).to.deep.equal([{
         id: bidRequest.bidId,
         tagid: bidRequest.adUnitCode,
+        instl: 1,
+        secure: 0,
         banner: {
           format: [
-            {w: 300, h: 250},
-            {w: 300, h: 600},
+            { w: 300, h: 250 },
+            { w: 300, h: 600 },
           ]
         },
         ext: {
@@ -256,7 +267,7 @@ describe('InsticatorBidAdapter', function () {
       expect(data.user.id).to.equal(USER_ID_STUBBED);
     });
     it('should return empty regs object if no gdprConsent is passed', function () {
-      const requests = spec.buildRequests([bidRequest], {...bidderRequest, ...{gdprConsent: false}});
+      const requests = spec.buildRequests([bidRequest], { ...bidderRequest, ...{ gdprConsent: false } });
       const data = JSON.parse(requests[0].data);
       expect(data.regs).to.be.an('object').that.is.empty;
     });
@@ -384,14 +395,12 @@ describe('InsticatorBidAdapter', function () {
         width: 300,
         height: 200,
         mediaType: 'banner',
-        meta: {
-          advertiserDomains: [
-            'test1.com'
-          ],
-          test: 1
-        },
         ad: 'adm1',
         adUnitCode: 'adunit-code-1',
+        meta: {
+          advertiserDomains: ['test1.com'],
+          test: 1
+        }
       },
       {
         requestId: 'bid2',

package/test/spec/modules/jixieBidAdapter_spec.js

@@ -240,6 +240,102 @@ describe('jixie Adapter', function () {
       getLocalStorageStub.restore();
       miscDimsStub.restore();
     });// it
+
+    it('it should popular the pricegranularity when info is available', function () {
+      let content = {
+        'ranges': [{
+          'max': 12,
+          'increment': 0.5
+        },
+        {
+          'max': 5,
+          'increment': 0.1
+        }],
+        precision: 1
+      };
+      let getConfigStub = sinon.stub(config, 'getConfig');
+      getConfigStub.callsFake(function fakeFn(prop) {
+        if (prop == 'priceGranularity') {
+          return content;
+        }
+        return null;
+      });
+
+      const oneSpecialBidReq = Object.assign({}, bidRequests_[0]);
+      const request = spec.buildRequests([oneSpecialBidReq], bidderRequest_);
+      const payload = JSON.parse(request.data);
+      getConfigStub.restore();
+      expect(payload.pricegranularity).to.deep.include(content);
+    });
+
+    it('should populate eids when supported userIds are available', function () {
+      const oneSpecialBidReq = Object.assign({}, bidRequests_[0], {
+        userId: {
+          tdid: '11111111-2222-3333-4444-555555555555',
+          uid2: { id: 'AbCdEfGhIjKlMnO9qdQBW7qtMw8f1WTUvtkHe6u+fqLfhbtsqrJ697Z6YoI3IB9klGUv1wvlFIbwH7ELDlqQBGtj8AC1v7fMJ/Q45E7W90dts7UQLTDMLNmtHBRDXVb0Fpas4Vh3yN1jGVQNhzXC/RpGIVtZE8dCxcjfa7VfcTNcvxxxxx==' },
+          pubProvidedId: [{
+            source: 'puburl1.com',
+            uids: [{
+              id: 'pubid1',
+              atype: 1,
+              ext: {
+                stype: 'ppuid'
+              }
+            }]
+          }, {
+            source: 'puburl2.com',
+            uids: [{
+              id: 'pubid2'
+            }]
+          }]
+        }
+      });
+      const request = spec.buildRequests([oneSpecialBidReq], bidderRequest_);
+      const payload = JSON.parse(request.data);
+      expect(payload.eids).to.deep.include({
+        'source': 'adserver.org',
+        'uids': [
+          {
+            'id': '11111111-2222-3333-4444-555555555555',
+            'atype': 1,
+            'ext': {
+              'rtiPartner': 'TDID'
+            }
+          }
+        ]
+      });
+      expect(payload.eids).to.deep.include({
+        'source': 'uidapi.com',
+        'uids': [
+          {
+            'id': 'AbCdEfGhIjKlMnO9qdQBW7qtMw8f1WTUvtkHe6u+fqLfhbtsqrJ697Z6YoI3IB9klGUv1wvlFIbwH7ELDlqQBGtj8AC1v7fMJ/Q45E7W90dts7UQLTDMLNmtHBRDXVb0Fpas4Vh3yN1jGVQNhzXC/RpGIVtZE8dCxcjfa7VfcTNcvxxxxx==',
+            'atype': 3
+          }
+        ]
+      });
+
+      expect(payload.eids).to.deep.include({
+        'source': 'puburl1.com',
+        'uids': [
+          {
+            'id': 'pubid1',
+            'atype': 1,
+            'ext': {
+              'stype': 'ppuid'
+            }
+          }
+        ]
+      });
+
+      expect(payload.eids).to.deep.include({
+        'source': 'puburl2.com',
+        'uids': [
+          {
+            'id': 'pubid2'
+          }
+        ]
+      });
+    });
   });// describe
 
   /**

package/test/spec/modules/jwplayerRtdProvider_spec.js

@@ -1,6 +1,6 @@
 import { fetchTargetingForMediaId, getVatFromCache, extractPublisherParams,
   formatTargetingResponse, getVatFromPlayer, enrichAdUnits, addTargetingToBid,
-  fetchTargetingInformation, jwplayerSubmodule, getContentId, getContentData } from 'modules/jwplayerRtdProvider.js';
+  fetchTargetingInformation, jwplayerSubmodule, getContentId, getContentSegments, getContentData } from 'modules/jwplayerRtdProvider.js';
 import { server } from 'test/mocks/xhr.js';
 import {addOrtbSiteContent} from '../../../modules/jwplayerRtdProvider';
 
@@ -498,26 +498,62 @@ describe('jwplayerRtdProvider', function() {
     });
   });
 
-  describe('Get Content Data', function () {
+  describe('Get Content Segments', function () {
     it('returns undefined when segments are empty', function () {
-      let data = getContentData(null);
-      expect(data).to.be.undefined;
-      data = getContentData(undefined);
-      expect(data).to.be.undefined;
-      data = getContentData([]);
-      expect(data).to.be.undefined;
+      let contentSegments = getContentSegments(null);
+      expect(contentSegments).to.be.undefined;
+      contentSegments = getContentSegments(undefined);
+      expect(contentSegments).to.be.undefined;
+      contentSegments = getContentSegments([]);
+      expect(contentSegments).to.be.undefined;
     });
 
     it('returns proper format', function () {
       const segment1 = 'segment1';
       const segment2 = 'segment2';
       const segment3 = 'segment3';
-      const data = getContentData([segment1, segment2, segment3]);
-      expect(data).to.have.property('name', 'jwplayer');
-      expect(data.ext).to.have.property('segtax', 502);
-      expect(data.segment[0]).to.deep.equal({ id: segment1, value: segment1 });
-      expect(data.segment[1]).to.deep.equal({ id: segment2, value: segment2 });
-      expect(data.segment[2]).to.deep.equal({ id: segment3, value: segment3 });
+      const contentSegments = getContentSegments([segment1, segment2, segment3]);
+      expect(contentSegments[0]).to.deep.equal({ id: segment1, value: segment1 });
+      expect(contentSegments[1]).to.deep.equal({ id: segment2, value: segment2 });
+      expect(contentSegments[2]).to.deep.equal({ id: segment3, value: segment3 });
+    });
+  });
+
+  describe('Get Content Data', function () {
+    it('should return proper format', function () {
+      const testMediaId = 'test_media_id';
+      const testSegments = [{ id: 1 }, { id: 2 }];
+      const contentData = getContentData(testMediaId, testSegments);
+      expect(contentData).to.have.property('name', 'jwplayer.com');
+      expect(contentData.ext).to.have.property('segtax', 502);
+      expect(contentData.ext).to.have.property('cids');
+      expect(contentData.ext.cids).to.have.length(1);
+      expect(contentData.ext.cids[0]).to.equal(testMediaId);
+      expect(contentData.segment).to.deep.equal(testSegments);
+    });
+
+    it('should only set segtax and segment when segments are provided', function () {
+      const testMediaId = 'test_media_id';
+      const contentData = getContentData(testMediaId);
+      expect(contentData).to.have.property('name', 'jwplayer.com');
+      expect(contentData.ext.segtax).to.be.undefined;
+      expect(contentData.ext).to.have.property('cids');
+      expect(contentData.ext.cids).to.have.length(1);
+      expect(contentData.ext.cids[0]).to.equal(testMediaId);
+      expect(contentData.segment).to.be.undefined;
+    });
+
+    it('should only set cids when a media id is provided', function () {
+      const testSegments = [{ id: 1 }, { id: 2 }];
+      const contentData = getContentData(null, testSegments);
+      expect(contentData).to.have.property('name', 'jwplayer.com');
+      expect(contentData.ext).to.have.property('segtax', 502);
+      expect(contentData.ext).to.not.have.property('cids');
+      expect(contentData.segment).to.deep.equal(testSegments);
+    });
+
+    it('should return undefined when no params are provided', function () {
+      expect(getContentData()).to.be.undefined;
     });
   });
 

package/test/spec/modules/livewrappedBidAdapter_spec.js

@@ -890,9 +890,10 @@ describe('Livewrapped adapter tests', function () {
     sandbox.stub(storage, 'cookiesAreEnabled').callsFake(() => true);
 
     let origGetConfig = config.getConfig;
+    let orgOrtb2 = {user: {ext: {prop: 'value'}}};
     sandbox.stub(config, 'getConfig').callsFake(function (key) {
       if (key === 'ortb2') {
-        return {user: {ext: {prop: 'value'}}};
+        return orgOrtb2;
       }
       return origGetConfig.apply(config, arguments);
     });
@@ -914,6 +915,7 @@ describe('Livewrapped adapter tests', function () {
     var expected = {user: {ext: {prop: 'value', eids: testbidRequest.bids[0].userIdAsEids}}}
 
     expect(data.rtbData).to.deep.equal(expected);
+    expect(orgOrtb2).to.deep.equal({user: {ext: {prop: 'value'}}});
   });
 
   it('should send schain object if available', function() {