prebid.js 6.0.0 → 6.1.0

package/test/spec/modules/sspBCBidAdapter_spec.js

@@ -518,6 +518,33 @@ describe('SSPBC adapter', function () {
       expect(payload.user).to.be.an('object').and.to.have.property('[ortb_extensions.consent]', bidRequest.gdprConsent.consentString);
     });
 
+    it('should send net info and pvid', function () {
+      expect(payload.user).to.be.an('object').and.to.have.property('data').that.is.an('array');
+
+      const userData = payload.user.data;
+      expect(userData.length).to.equal(2);
+
+      const netInfo = userData[0];
+      expect(netInfo.id).to.equal('12');
+      expect(netInfo.name).to.equal('NetInfo');
+      expect(netInfo).to.have.property('segment').that.is.an('array');
+
+      const pvid = userData[1];
+      expect(pvid.id).to.equal('7');
+      expect(pvid.name).to.equal('pvid');
+      expect(pvid).to.have.property('segment').that.is.an('array');
+      expect(pvid.segment[0]).to.have.property('value');
+    });
+
+    it('pvid should be constant on a single page view', function () {
+      const userData1 = payload.user.data;
+      const userData2 = payloadNative.user.data;
+      const pvid1 = userData1[1];
+      const pvid2 = userData2[1];
+
+      expect(pvid1.segment[0].value).to.equal(pvid2.segment[0].value);
+    });
+
     it('should build correct native payload', function () {
       const nativeAssets = payloadNative.imp && payloadNative.imp[0].native.request;
 
@@ -543,13 +570,16 @@ describe('SSPBC adapter', function () {
       expect(videoAssets).to.have.property('api').that.is.an('array');
     });
 
-    it('should create auxilary placement identifier (size_numUsed)', function () {
+    it('should create auxilary placement identifier (size_numUsed), that is constant for a given adUnit', function () {
       const extAssets1 = payload.imp && payload.imp[0].ext.data;
       const extAssets2 = payloadSingle.imp && payloadSingle.imp[0].ext.data;
 
-      // note that payload comes from first, and payloadSingle from second auction in the test run
+      /*
+        note that payload comes from first, and payloadSingle from second auction in the test run
+        also, since both have same adUnitName, value of pbsize property should be the same
+      */
       expect(extAssets1).to.have.property('pbsize').that.equals('750x200_1')
-      expect(extAssets2).to.have.property('pbsize').that.equals('750x200_2')
+      expect(extAssets2).to.have.property('pbsize').that.equals('750x200_1')
     });
   });
 

package/test/spec/modules/trustxBidAdapter_spec.js

@@ -519,6 +519,48 @@ describe('TrustXAdapter', function () {
       expect(payload.tmax).to.equal(3000);
       getConfigStub.restore();
     });
+    it('should contain imp[].ext.data.adserver if available', function() {
+      const ortb2Imp = [{
+        ext: {
+          data: {
+            adserver: {
+              name: 'ad_server_name',
+              adslot: '/111111/slot'
+            },
+            pbadslot: '/111111/slot'
+          }
+        }
+      }, {
+        ext: {
+          data: {
+            adserver: {
+              name: 'ad_server_name',
+              adslot: '/222222/slot'
+            },
+            pbadslot: '/222222/slot'
+          }
+        }
+      }];
+      const bidRequestsWithOrtb2Imp = bidRequests.slice(0, 3).map((bid, ind) => {
+        return Object.assign(ortb2Imp[ind] ? { ortb2Imp: ortb2Imp[ind] } : {}, bid);
+      });
+      const request = spec.buildRequests(bidRequestsWithOrtb2Imp, bidderRequest);
+      expect(request.data).to.be.an('string');
+      const payload = parseRequest(request.data);
+      expect(payload.imp[0].ext).to.deep.equal({
+        divid: bidRequests[0].adUnitCode,
+        data: ortb2Imp[0].ext.data,
+        gpid: ortb2Imp[0].ext.data.adserver.adslot
+      });
+      expect(payload.imp[1].ext).to.deep.equal({
+        divid: bidRequests[1].adUnitCode,
+        data: ortb2Imp[1].ext.data,
+        gpid: ortb2Imp[1].ext.data.adserver.adslot
+      });
+      expect(payload.imp[2].ext).to.deep.equal({
+        divid: bidRequests[2].adUnitCode
+      });
+    });
     it('all id like request fields must be a string', function () {
       const bidderRequestWithNumId = Object.assign({}, bidderRequest, { bidderRequestId: 123123, auctionId: 345345543 });
 

package/test/spec/modules/vidoomyBidAdapter_spec.js

@@ -4,6 +4,7 @@ import { newBidder } from 'src/adapters/bidderFactory.js';
 import { INSTREAM } from '../../../src/video';
 
 const ENDPOINT = `https://d.vidoomy.com/api/rtbserver/prebid/`;
+const PIXELS = ['/test.png', '/test2.png?gdpr={{GDPR}}&gdpr_consent={{GDPR_CONSENT}}']
 
 describe('vidoomyBidAdapter', function() {
   const adapter = newBidder(spec);
@@ -101,24 +102,24 @@ describe('vidoomyBidAdapter', function() {
     });
 
     it('attaches source and version to endpoint URL as query params', function () {
-      expect(request[0].url).to.include(ENDPOINT);
-      expect(request[1].url).to.include(ENDPOINT);
+      expect(request[0].url).to.equal(ENDPOINT);
+      expect(request[1].url).to.equal(ENDPOINT);
     });
 
     it('only accepts first width and height sizes', function () {
-      expect(request[0].url).to.include('w=300');
-      expect(request[0].url).to.include('h=250');
-      expect(request[0].url).to.not.include('w=200');
-      expect(request[0].url).to.not.include('h=100');
-      expect(request[1].url).to.include('w=400');
-      expect(request[1].url).to.include('h=225');
+      expect('' + request[0].data.w).to.equal('300');
+      expect('' + request[0].data.h).to.equal('250');
+      expect('' + request[0].data.w).to.not.equal('200');
+      expect('' + request[0].data.h).to.not.equal('100');
+      expect('' + request[1].data.w).to.equal('400');
+      expect('' + request[1].data.h).to.equal('225');
     });
 
     it('should send id and pid parameters', function () {
-      expect(request[0].url).to.include('id=123123');
-      expect(request[0].url).to.include('pid=123123');
-      expect(request[1].url).to.include('id=456456');
-      expect(request[1].url).to.include('pid=456456');
+      expect('' + request[0].data.id).to.equal('123123');
+      expect('' + request[0].data.pid).to.equal('123123');
+      expect('' + request[1].data.id).to.equal('456456');
+      expect('' + request[1].data.pid).to.equal('456456');
     });
   });
 
@@ -182,7 +183,8 @@ describe('vidoomyBidAdapter', function() {
           'networkName': null,
           'primaryCatId': 'IAB3-1',
           'secondaryCatIds': null
-        }
+        },
+        'pixels': PIXELS
       }
     }
 
@@ -206,5 +208,22 @@ describe('vidoomyBidAdapter', function() {
 
       expect(result[0].requestId).to.equal(serverResponseBanner.body.requestId);
     });
+
+    it('should sync user cookies', function () {
+      const GDPR_CONSENT = 'GDPR_TEST'
+      const result = spec.getUserSyncs({
+        pixelEnabled: true
+      }, [serverResponseBanner], { consentString: GDPR_CONSENT, gdprApplies: 1 }, null)
+      expect(result).to.eql([
+        {
+          type: 'image',
+          url: PIXELS[0]
+        },
+        {
+          type: 'image',
+          url: `/test2.png?gdpr=1&gdpr_consent=${GDPR_CONSENT}`
+        }
+      ])
+    });
   });
 });

package/test/spec/modules/visxBidAdapter_spec.js

@@ -1149,7 +1149,7 @@ describe('VisxAdapter', function () {
     it('onTimeout', function () {
       const data = { timeout: 3000, bidId: '23423', params: { uid: 1 } };
       spec.onTimeout(data);
-      expect(utils.triggerPixel.calledOnceWith('https://t.visx.net/track/bid_timeout?data=' + JSON.stringify(data))).to.equal(true);
+      expect(utils.triggerPixel.calledOnceWith('https://t.visx.net/track/bid_timeout//' + JSON.stringify(data))).to.equal(true);
     });
   });
 

package/test/spec/modules/yieldlabBidAdapter_spec.js

@@ -73,6 +73,12 @@ const VIDEO_REQUEST = Object.assign({}, REQUEST, {
   }
 })
 
+const NATIVE_REQUEST = Object.assign({}, REQUEST, {
+  'mediaTypes': {
+    'native': { }
+  }
+})
+
 const RESPONSE = {
   advertiser: 'yieldlab',
   curl: 'https://www.yieldlab.de',
@@ -84,6 +90,42 @@ const RESPONSE = {
   adtype: 'BANNER'
 }
 
+const NATIVE_RESPONSE = Object.assign({}, RESPONSE, {
+  'adtype': 'NATIVE',
+  'native': {
+    'link': {
+      'url': 'https://www.yieldlab.de'
+    },
+    'assets': [
+      {
+        'id': 1,
+        'title': {
+          'text': 'This is a great headline'
+        }
+      },
+      {
+        'id': 2,
+        'img': {
+          'url': 'https://localhost:8080/yl-logo100x100.jpg',
+          'w': 100,
+          'h': 100
+        }
+      },
+      {
+        'id': 3,
+        'data': {
+          'value': 'Native body value'
+        }
+      }
+    ],
+    'imptrackers': [
+      'http://localhost:8080/ve?d=ODE9ZSY2MTI1MjAzNjMzMzYxPXN0JjA0NWUwZDk0NTY5Yi05M2FiLWUwZTQtOWFjNy1hYWY0MzFiZj1kaXQmMj12',
+      'http://localhost:8080/md/1111/9efa4e76-2030-4f04-bb9f-322541f8d611?mdata=false&pvid=false&ids=x:1',
+      'http://localhost:8080/imp?s=13216&d=2171514&a=12548955&ts=1633363025216&tid=fb134faa-7ca9-4e0e-ba39-b96549d0e540&l=0'
+    ]
+  }
+})
+
 const VIDEO_RESPONSE = Object.assign({}, RESPONSE, {
   'adtype': 'VIDEO'
 })
@@ -297,6 +339,45 @@ describe('yieldlabBidAdapter', function () {
       expect(result[0].vastUrl).to.include('&id=abc')
     })
 
+    it('should add adUrl and native assets when type is Native', function () {
+      const result = spec.interpretResponse({body: [NATIVE_RESPONSE]}, {validBidRequests: [NATIVE_REQUEST], queryParams: REQPARAMS})
+
+      expect(result[0].requestId).to.equal('2d925f27f5079f')
+      expect(result[0].cpm).to.equal(0.01)
+      expect(result[0].mediaType).to.equal('native')
+      expect(result[0].adUrl).to.include('https://ad.yieldlab.net/d/1111/2222/?ts=')
+      expect(result[0].native.title).to.equal('This is a great headline')
+      expect(result[0].native.body).to.equal('Native body value')
+      expect(result[0].native.image.url).to.equal('https://localhost:8080/yl-logo100x100.jpg')
+      expect(result[0].native.image.width).to.equal(100)
+      expect(result[0].native.image.height).to.equal(100)
+      expect(result[0].native.clickUrl).to.equal('https://www.yieldlab.de')
+      expect(result[0].native.impressionTrackers.length).to.equal(3)
+    })
+
+    it('should add adUrl and default native assets when type is Native', function () {
+      const NATIVE_RESPONSE_2 = Object.assign({}, NATIVE_RESPONSE, {
+        'native': {
+          'link': {
+            'url': 'https://www.yieldlab.de'
+          },
+          'assets': [],
+          'imptrackers': []
+        }
+      })
+      const result = spec.interpretResponse({body: [NATIVE_RESPONSE_2]}, {validBidRequests: [NATIVE_REQUEST], queryParams: REQPARAMS})
+
+      expect(result[0].requestId).to.equal('2d925f27f5079f')
+      expect(result[0].cpm).to.equal(0.01)
+      expect(result[0].mediaType).to.equal('native')
+      expect(result[0].adUrl).to.include('https://ad.yieldlab.net/d/1111/2222/?ts=')
+      expect(result[0].native.title).to.equal('')
+      expect(result[0].native.body).to.equal('')
+      expect(result[0].native.image.url).to.equal('')
+      expect(result[0].native.image.width).to.equal(0)
+      expect(result[0].native.image.height).to.equal(0)
+    })
+
     it('should append gdpr parameters to vastUrl', function () {
       const result = spec.interpretResponse({body: [VIDEO_RESPONSE]}, {validBidRequests: [VIDEO_REQUEST], queryParams: REQPARAMS_GDPR})
 

package/test/spec/unit/core/adapterManager_spec.js

@@ -162,7 +162,7 @@ describe('adapterManager tests', function () {
         'bidderCode': 'appnexus',
         'auctionId': '1863e370099523',
         'bidderRequestId': '2946b569352ef2',
-        'tid': '34566b569352ef2',
+        'uniquePbsTid': '34566b569352ef2',
         'bids': [
           {
             'bidder': 'appnexus',
@@ -479,7 +479,7 @@ describe('adapterManager tests', function () {
       'bidderCode': 'appnexus',
       'auctionId': '1863e370099523',
       'bidderRequestId': '2946b569352ef2',
-      'tid': '34566b569352ef2',
+      'uniquePbsTid': '34566b569352ef2',
       'timeout': 1000,
       'src': 's2s',
       'adUnitsS2SCopy': [
@@ -708,7 +708,7 @@ describe('adapterManager tests', function () {
       'bidderCode': 'appnexus',
       'auctionId': '1863e370099523',
       'bidderRequestId': '2946b569352ef2',
-      'tid': '34566b569352ef2',
+      'uniquePbsTid': '34566b569352ef2',
       'timeout': 1000,
       'src': 's2s',
       'adUnitsS2SCopy': [
@@ -844,7 +844,7 @@ describe('adapterManager tests', function () {
       'bidderCode': 'pubmatic',
       'auctionId': '1863e370099523',
       'bidderRequestId': '2946b569352ef2',
-      'tid': '2342342342lfi23',
+      'uniquePbsTid': '2342342342lfi23',
       'timeout': 1000,
       'src': 's2s',
       'adUnitsS2SCopy': [
@@ -1041,6 +1041,21 @@ describe('adapterManager tests', function () {
         sinon.assert.calledTwice(prebidServerAdapterMock.callBids);
       });
 
+      it('should have one tid for ALL s2s bidRequests', function () {
+        let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
+          adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus', 'pubmatic'], bid.bidder));
+          return adUnit;
+        })
+        let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
+        adapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
+        sinon.assert.calledTwice(prebidServerAdapterMock.callBids);
+        const firstBid = prebidServerAdapterMock.callBids.firstCall.args[0];
+        const secondBid = prebidServerAdapterMock.callBids.secondCall.args[0];
+
+        // TIDS should be the same
+        expect(firstBid.tid).to.equal(secondBid.tid);
+      });
+
       it('should fire for simultaneous s2s and client requests', function () {
         adapterManager.bidderRegistry['adequant'] = adequantAdapterMock;
         let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
@@ -1697,14 +1712,17 @@ describe('adapterManager tests', function () {
     });
 
     describe('sizeMapping', function () {
+      let sandbox;
       beforeEach(function () {
+        sandbox = sinon.sandbox.create();
         allS2SBidders.length = 0;
         clientTestAdapters.length = 0;
-        sinon.stub(window, 'matchMedia').callsFake(() => ({matches: true}));
+        // always have matchMedia return true for us
+        sandbox.stub(utils.getWindowTop(), 'matchMedia').callsFake(() => ({matches: true}));
       });
 
       afterEach(function () {
-        matchMedia.restore();
+        sandbox.restore();
         config.resetConfig();
         setSizeConfig([]);
       });