prebid.js 5.19.0 → 6.2.0

package/test/spec/modules/yieldoneBidAdapter_spec.js

@@ -7,6 +7,8 @@ const ENDPOINT = 'https://y.one.impact-ad.jp/h_bid';
 const USER_SYNC_URL = 'https://y.one.impact-ad.jp/push_sync';
 const VIDEO_PLAYER_URL = 'https://img.ak.impact-ad.jp/ic/pone/ivt/firstview/js/dac-video-prebid.min.js';
 
+const DEFAULT_VIDEO_SIZE = {w: 640, h: 360};
+
 describe('yieldoneBidAdapter', function() {
   const adapter = newBidder(spec);
 
@@ -40,32 +42,7 @@ describe('yieldoneBidAdapter', function() {
   });
 
   describe('buildRequests', function () {
-    let bidRequests = [
-      {
-        'bidder': 'yieldone',
-        'params': {
-          placementId: '36891'
-        },
-        'adUnitCode': 'adunit-code1',
-        'sizes': [[300, 250], [336, 280]],
-        'bidId': '23beaa6af6cdde',
-        'bidderRequestId': '19c0c1efdf37e7',
-        'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1',
-      },
-      {
-        'bidder': 'yieldone',
-        'params': {
-          placementId: '47919'
-        },
-        'adUnitCode': 'adunit-code2',
-        'sizes': [[300, 250]],
-        'bidId': '382091349b149f"',
-        'bidderRequestId': '"1f9c98192de251"',
-        'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1',
-      }
-    ];
-
-    let bidderRequest = {
+    const bidderRequest = {
       refererInfo: {
         numIframes: 0,
         reachedTop: true,
@@ -74,49 +51,318 @@ describe('yieldoneBidAdapter', function() {
       }
     };
 
-    const request = spec.buildRequests(bidRequests, bidderRequest);
+    describe('Basic', function () {
+      const bidRequests = [
+        {
+          'bidder': 'yieldone',
+          'params': {placementId: '36891'},
+          'adUnitCode': 'adunit-code1',
+          'bidId': '23beaa6af6cdde',
+          'bidderRequestId': '19c0c1efdf37e7',
+          'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1',
+        },
+        {
+          'bidder': 'yieldone',
+          'params': {placementId: '47919'},
+          'adUnitCode': 'adunit-code2',
+          'bidId': '382091349b149f"',
+          'bidderRequestId': '"1f9c98192de251"',
+          'auctionId': '61466567-d482-4a16-96f0-fe5f25ffbdf1',
+        }
+      ];
+      const request = spec.buildRequests(bidRequests, bidderRequest);
 
-    it('sends bid request to our endpoint via GET', function () {
-      expect(request[0].method).to.equal('GET');
-      expect(request[1].method).to.equal('GET');
+      it('sends bid request to our endpoint via GET', function () {
+        expect(request[0].method).to.equal('GET');
+        expect(request[1].method).to.equal('GET');
+      });
+      it('attaches source and version to endpoint URL as query params', function () {
+        expect(request[0].url).to.equal(ENDPOINT);
+        expect(request[1].url).to.equal(ENDPOINT);
+      });
+      it('adUnitCode should be sent as uc parameters on any requests', function () {
+        expect(request[0].data.uc).to.equal('adunit-code1');
+        expect(request[1].data.uc).to.equal('adunit-code2');
+      });
     });
 
-    it('attaches source and version to endpoint URL as query params', function () {
-      expect(request[0].url).to.equal(ENDPOINT);
-      expect(request[1].url).to.equal(ENDPOINT);
-    });
+    describe('Old Format', function () {
+      const bidRequests = [
+        {
+          params: {placementId: '0'},
+          mediaType: 'banner',
+          sizes: [[300, 250], [336, 280]],
+        },
+        {
+          params: {placementId: '1'},
+          mediaType: 'banner',
+          sizes: [[336, 280]],
+        },
+        {
+          // It doesn't actually exist.
+          params: {placementId: '2'},
+        },
+        {
+          params: {placementId: '3'},
+          mediaType: 'video',
+          sizes: [[1280, 720], [1920, 1080]],
+        },
+        {
+          params: {placementId: '4'},
+          mediaType: 'video',
+          sizes: [[1920, 1080]],
+        },
+        {
+          params: {placementId: '5'},
+          mediaType: 'video',
+        },
+      ];
+      const request = spec.buildRequests(bidRequests, bidderRequest);
 
-    it('parameter sz has more than one size on banner requests', function () {
-      expect(request[0].data.sz).to.equal('300x250,336x280');
-      expect(request[1].data.sz).to.equal('300x250');
+      it('parameter sz has more than one size on banner requests', function () {
+        expect(request[0].data.sz).to.equal('300x250,336x280');
+        expect(request[1].data.sz).to.equal('336x280');
+        expect(request[2].data.sz).to.equal('');
+        expect(request[3].data).to.not.have.property('sz');
+        expect(request[4].data).to.not.have.property('sz');
+        expect(request[5].data).to.not.have.property('sz');
+      });
+
+      it('width and height should be set as separate parameters on outstream requests', function () {
+        expect(request[0].data).to.not.have.property('w');
+        expect(request[1].data).to.not.have.property('w');
+        expect(request[2].data).to.not.have.property('w');
+        expect(request[3].data.w).to.equal(1280);
+        expect(request[3].data.h).to.equal(720);
+        expect(request[4].data.w).to.equal(1920);
+        expect(request[4].data.h).to.equal(1080);
+        expect(request[5].data.w).to.equal(DEFAULT_VIDEO_SIZE.w);
+        expect(request[5].data.h).to.equal(DEFAULT_VIDEO_SIZE.h);
+      });
     });
 
-    it('width and height should be set as separate parameters on outstream requests', function () {
-      const bidRequest = Object.assign({}, bidRequests[0]);
-      bidRequest.mediaTypes = {};
-      bidRequest.mediaTypes.video = {context: 'outstream'};
-      const request = spec.buildRequests([bidRequest], bidderRequest);
-      expect(request[0].data.w).to.equal('300');
-      expect(request[0].data.h).to.equal('250');
+    describe('New Format', function () {
+      const bidRequests = [
+        {
+          params: {placementId: '0'},
+          mediaTypes: {
+            banner: {
+              sizes: [[300, 250], [336, 280]],
+            },
+          },
+        },
+        {
+          params: {placementId: '1'},
+          mediaTypes: {
+            banner: {
+              sizes: [[336, 280]],
+            },
+          },
+        },
+        {
+          // It doesn't actually exist.
+          params: {placementId: '2'},
+          mediaTypes: {
+            banner: {
+            },
+          },
+        },
+        {
+          params: {placementId: '3'},
+          mediaTypes: {
+            video: {
+              context: 'outstream',
+              playerSize: [[1280, 720], [1920, 1080]],
+            },
+          },
+        },
+        {
+          params: {placementId: '4'},
+          mediaTypes: {
+            video: {
+              context: 'outstream',
+              playerSize: [1920, 1080],
+            },
+          },
+        },
+        {
+          params: {placementId: '5'},
+          mediaTypes: {
+            video: {
+              context: 'outstream',
+            },
+          },
+        },
+      ];
+      const request = spec.buildRequests(bidRequests, bidderRequest);
+
+      it('parameter sz has more than one size on banner requests', function () {
+        expect(request[0].data.sz).to.equal('300x250,336x280');
+        expect(request[1].data.sz).to.equal('336x280');
+        expect(request[2].data.sz).to.equal('');
+        expect(request[3].data).to.not.have.property('sz');
+        expect(request[4].data).to.not.have.property('sz');
+        expect(request[5].data).to.not.have.property('sz');
+      });
+
+      it('width and height should be set as separate parameters on outstream requests', function () {
+        expect(request[0].data).to.not.have.property('w');
+        expect(request[1].data).to.not.have.property('w');
+        expect(request[2].data).to.not.have.property('w');
+        expect(request[3].data.w).to.equal(1280);
+        expect(request[3].data.h).to.equal(720);
+        expect(request[4].data.w).to.equal(1920);
+        expect(request[4].data.h).to.equal(1080);
+        expect(request[5].data.w).to.equal(DEFAULT_VIDEO_SIZE.w);
+        expect(request[5].data.h).to.equal(DEFAULT_VIDEO_SIZE.h);
+      });
     });
 
-    it('adUnitCode should be sent as uc parameters on any requests', function () {
-      expect(request[0].data.uc).to.equal('adunit-code1');
-      expect(request[1].data.uc).to.equal('adunit-code2');
+    describe('Multiple Format', function () {
+      const bidRequests = [
+        {
+          // It will be treated as a banner.
+          params: {
+            placementId: '0',
+          },
+          mediaTypes: {
+            banner: {
+              sizes: [[300, 250], [336, 280]],
+            },
+            video: {
+              context: 'outstream',
+              playerSize: [1920, 1080],
+            },
+          },
+        },
+        {
+          // It will be treated as a video.
+          params: {
+            placementId: '1',
+            playerParams: {},
+          },
+          mediaTypes: {
+            banner: {
+              sizes: [[300, 250], [336, 280]],
+            },
+            video: {
+              context: 'outstream',
+              playerSize: [1920, 1080],
+            },
+          },
+        },
+      ];
+      const request = spec.buildRequests(bidRequests, bidderRequest);
+
+      it('parameter sz has more than one size on banner requests', function () {
+        expect(request[0].data.sz).to.equal('300x250,336x280');
+        expect(request[1].data).to.not.have.property('sz');
+      });
+
+      it('width and height should be set as separate parameters on outstream requests', function () {
+        expect(request[0].data).to.not.have.property('w');
+        expect(request[1].data.w).to.equal(1920);
+        expect(request[1].data.h).to.equal(1080);
+      });
     });
 
-    describe('userid idl_env should be passed to querystring', function () {
-      const bid = deepClone([bidRequests[0]]);
+    describe('FLUX Format', function () {
+      const bidRequests = [
+        {
+          // It will be treated as a banner.
+          params: {
+            placementId: '0',
+          },
+          mediaTypes: {
+            banner: {
+              sizes: [[300, 250], [336, 280]],
+            },
+            video: {
+              context: 'outstream',
+              playerSize: [[1, 1]],
+            },
+          },
+        },
+        {
+          // It will be treated as a video.
+          params: {
+            placementId: '1',
+            playerParams: {},
+            playerSize: [1920, 1080],
+          },
+          mediaTypes: {
+            banner: {
+              sizes: [[300, 250], [336, 280]],
+            },
+            video: {
+              context: 'outstream',
+              playerSize: [[1, 1]],
+            },
+          },
+        },
+        {
+          // It will be treated as a video.
+          params: {
+            placementId: '2',
+            playerParams: {},
+          },
+          mediaTypes: {
+            banner: {
+              sizes: [[300, 250], [336, 280]],
+            },
+            video: {
+              context: 'outstream',
+              playerSize: [[1, 1]],
+            },
+          },
+        },
+      ];
+      const request = spec.buildRequests(bidRequests, bidderRequest);
+
+      it('parameter sz has more than one size on banner requests', function () {
+        expect(request[0].data.sz).to.equal('300x250,336x280');
+        expect(request[1].data).to.not.have.property('sz');
+        expect(request[2].data).to.not.have.property('sz');
+      });
+
+      it('width and height should be set as separate parameters on outstream requests', function () {
+        expect(request[0].data).to.not.have.property('w');
+        expect(request[1].data.w).to.equal(1920);
+        expect(request[1].data.h).to.equal(1080);
+        expect(request[2].data.w).to.equal(DEFAULT_VIDEO_SIZE.w);
+        expect(request[2].data.h).to.equal(DEFAULT_VIDEO_SIZE.h);
+      });
+    });
 
+    describe('LiveRampID', function () {
       it('dont send LiveRampID if undefined', function () {
-        bid[0].userId = {};
-        const request = spec.buildRequests(bid, bidderRequest);
+        const bidRequests = [
+          {
+            params: {placementId: '0'},
+          },
+          {
+            params: {placementId: '1'},
+            userId: {},
+          },
+          {
+            params: {placementId: '2'},
+            userId: undefined,
+          },
+        ];
+        const request = spec.buildRequests(bidRequests, bidderRequest);
         expect(request[0].data).to.not.have.property('lr_env');
+        expect(request[1].data).to.not.have.property('lr_env');
+        expect(request[2].data).to.not.have.property('lr_env');
       });
 
       it('should send LiveRampID if available', function () {
-        bid[0].userId = {idl_env: 'idl_env_sample'};
-        const request = spec.buildRequests(bid, bidderRequest);
+        const bidRequests = [
+          {
+            params: {placementId: '0'},
+            userId: {idl_env: 'idl_env_sample'},
+          },
+        ];
+        const request = spec.buildRequests(bidRequests, bidderRequest);
         expect(request[0].data.lr_env).to.equal('idl_env_sample');
       });
     });

package/test/spec/unit/core/adapterManager_spec.js

@@ -162,7 +162,7 @@ describe('adapterManager tests', function () {
         'bidderCode': 'appnexus',
         'auctionId': '1863e370099523',
         'bidderRequestId': '2946b569352ef2',
-        'tid': '34566b569352ef2',
+        'uniquePbsTid': '34566b569352ef2',
         'bids': [
           {
             'bidder': 'appnexus',
@@ -456,7 +456,8 @@ describe('adapterManager tests', function () {
     });
 
     it('should call spec\'s onBidderError callback when callBidderError is called', function () {
-      const bidderRequest = getBidRequests().find(bidRequest => bidRequest.bidderCode === bidder);
+      const bidRequests = getBidRequests();
+      const bidderRequest = find(bidRequests, bidRequest => bidRequest.bidderCode === bidder);
       const xhrErrorMock = {
         status: 500,
         statusText: 'Internal Server Error'
@@ -478,7 +479,7 @@ describe('adapterManager tests', function () {
       'bidderCode': 'appnexus',
       'auctionId': '1863e370099523',
       'bidderRequestId': '2946b569352ef2',
-      'tid': '34566b569352ef2',
+      'uniquePbsTid': '34566b569352ef2',
       'timeout': 1000,
       'src': 's2s',
       'adUnitsS2SCopy': [
@@ -707,7 +708,7 @@ describe('adapterManager tests', function () {
       'bidderCode': 'appnexus',
       'auctionId': '1863e370099523',
       'bidderRequestId': '2946b569352ef2',
-      'tid': '34566b569352ef2',
+      'uniquePbsTid': '34566b569352ef2',
       'timeout': 1000,
       'src': 's2s',
       'adUnitsS2SCopy': [
@@ -843,7 +844,7 @@ describe('adapterManager tests', function () {
       'bidderCode': 'pubmatic',
       'auctionId': '1863e370099523',
       'bidderRequestId': '2946b569352ef2',
-      'tid': '2342342342lfi23',
+      'uniquePbsTid': '2342342342lfi23',
       'timeout': 1000,
       'src': 's2s',
       'adUnitsS2SCopy': [
@@ -1040,6 +1041,21 @@ describe('adapterManager tests', function () {
         sinon.assert.calledTwice(prebidServerAdapterMock.callBids);
       });
 
+      it('should have one tid for ALL s2s bidRequests', function () {
+        let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
+          adUnit.bids = adUnit.bids.filter(bid => includes(['appnexus', 'pubmatic'], bid.bidder));
+          return adUnit;
+        })
+        let bidRequests = adapterManager.makeBidRequests(adUnits, 1111, 2222, 1000);
+        adapterManager.callBids(adUnits, bidRequests, () => {}, () => {});
+        sinon.assert.calledTwice(prebidServerAdapterMock.callBids);
+        const firstBid = prebidServerAdapterMock.callBids.firstCall.args[0];
+        const secondBid = prebidServerAdapterMock.callBids.secondCall.args[0];
+
+        // TIDS should be the same
+        expect(firstBid.tid).to.equal(secondBid.tid);
+      });
+
       it('should fire for simultaneous s2s and client requests', function () {
         adapterManager.bidderRegistry['adequant'] = adequantAdapterMock;
         let adUnits = utils.deepClone(getAdUnits()).map(adUnit => {
@@ -1696,14 +1712,17 @@ describe('adapterManager tests', function () {
     });
 
     describe('sizeMapping', function () {
+      let sandbox;
       beforeEach(function () {
+        sandbox = sinon.sandbox.create();
         allS2SBidders.length = 0;
         clientTestAdapters.length = 0;
-        sinon.stub(window, 'matchMedia').callsFake(() => ({matches: true}));
+        // always have matchMedia return true for us
+        sandbox.stub(utils.getWindowTop(), 'matchMedia').callsFake(() => ({matches: true}));
       });
 
       afterEach(function () {
-        matchMedia.restore();
+        sandbox.restore();
         config.resetConfig();
         setSizeConfig([]);
       });

package/test/spec/unit/core/targeting_spec.js

@@ -461,6 +461,50 @@ describe('targeting tests', function () {
       });
     });
 
+    describe('targetingControls.allowZeroCpmBids', function () {
+      let bid4;
+      let bidderSettingsStorage;
+
+      before(function() {
+        bidderSettingsStorage = $$PREBID_GLOBAL$$.bidderSettings;
+      });
+
+      beforeEach(function () {
+        bid4 = utils.deepClone(bid1);
+        bid4.adserverTargeting = {
+          hb_pb: '0.0',
+          hb_adid: '567891011',
+          hb_bidder: 'appnexus',
+        };
+        bid4.bidder = bid4.bidderCode = 'appnexus';
+        bid4.cpm = 0;
+        bidsReceived = [bid4];
+      });
+
+      after(function() {
+        bidsReceived = [bid1, bid2, bid3];
+        $$PREBID_GLOBAL$$.bidderSettings = bidderSettingsStorage;
+      })
+
+      it('targeting should not include a 0 cpm by default', function() {
+        bid4.adserverTargeting = {};
+        const targeting = targetingInstance.getAllTargeting(['/123456/header-bid-tag-0']);
+        expect(targeting['/123456/header-bid-tag-0']).to.deep.equal({});
+      });
+
+      it('targeting should allow a 0 cpm with targetingControls.allowZeroCpmBids set to true', function () {
+        $$PREBID_GLOBAL$$.bidderSettings = {
+          standard: {
+            allowZeroCpmBids: true
+          }
+        };
+
+        const targeting = targetingInstance.getAllTargeting(['/123456/header-bid-tag-0']);
+        expect(targeting['/123456/header-bid-tag-0']).to.include.all.keys('hb_pb', 'hb_bidder', 'hb_adid', 'hb_bidder_appnexus', 'hb_adid_appnexus', 'hb_pb_appnexus');
+        expect(targeting['/123456/header-bid-tag-0']['hb_pb']).to.equal('0.0')
+      });
+    });
+
     describe('targetingControls.allowTargetingKeys', function () {
       let bid4;
 

package/wdio.conf.js

@@ -9,7 +9,7 @@ function getCapabilities() {
     return platformMap[os];
   }
 
-  // only IE 11, Chrome 80 & Firefox 73 run as part of functional tests
+  // only Chrome 80 & Firefox 73 run as part of functional tests
   // rest of the browsers are discarded.
   delete browsers['bs_chrome_79_windows_10'];
   delete browsers['bs_firefox_72_windows_10'];