prebid.js 5.19.0 → 5.20.0

package/test/spec/modules/multibid_spec.js

@@ -82,7 +82,7 @@ describe('multibid adapter', function () {
           'sizes': [[300, 250]]
         }
       },
-      'adUnitCode': 'test-div',
+      'adUnitCode': 'test.div',
       'transactionId': 'c153f3da-84f0-4be8-95cb-0647c458bc60',
       'sizes': [[300, 250]],
       'bidId': '2408ef83b84c9d',
@@ -106,7 +106,7 @@ describe('multibid adapter', function () {
           'sizes': [[300, 250]]
         }
       },
-      'adUnitCode': 'test-div',
+      'adUnitCode': 'test.div',
       'transactionId': 'c153f3da-84f0-4be8-95cb-0647c458bc60',
       'sizes': [[300, 250]],
       'bidId': '2408ef83b84c9d',
@@ -197,14 +197,14 @@ describe('multibid adapter', function () {
     });
 
     it('adds original bids and does not modify', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       addBidResponseHook(callbackFn, adUnitCode, {...bids[0]});
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -214,13 +214,13 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
     });
 
     it('modifies and adds both bids based on multibid configuration', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 2, targetBiddercodePrefix: 'bidA'}]});
@@ -232,7 +232,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -250,13 +250,13 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
     });
 
     it('only modifies bids defined in the multibid configuration', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       bids.push({
@@ -276,7 +276,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -292,7 +292,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
 
@@ -302,13 +302,13 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[2]);
     });
 
     it('only modifies and returns bids under limit for a specifc bidder in the multibid configuration', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       bids.push({
@@ -328,7 +328,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -344,7 +344,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
 
@@ -356,7 +356,7 @@ describe('multibid adapter', function () {
     });
 
     it('if no prefix in multibid configuration, modifies and returns bids under limit without preifx property', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       bids.push({
@@ -375,7 +375,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -389,7 +389,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
 
@@ -401,7 +401,7 @@ describe('multibid adapter', function () {
     });
 
     it('does not include extra bids if cpm is less than floor value', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArrayAlt[1]}, {...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}];
 
       bids.map(bid => {
@@ -418,7 +418,7 @@ describe('multibid adapter', function () {
           floorRuleValue: 65,
           floorValue: 65,
           matchedFields: {
-            gptSlot: 'test-div',
+            gptSlot: 'test.div',
             mediaType: 'banner'
           }
         }
@@ -435,7 +435,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderA');
       expect(result.bid.targetingBidder).to.equal(undefined);
@@ -452,7 +452,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderB');
       expect(result.bid.targetingBidder).to.equal(undefined);
@@ -463,14 +463,14 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderC');
       expect(result.bid.targetingBidder).to.equal(undefined);
     });
 
     it('does  include extra bids if cpm is not less than floor value', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArrayAlt[1]}, {...bidArrayAlt[0]}];
 
       bids.map(bid => {
@@ -487,7 +487,7 @@ describe('multibid adapter', function () {
           floorRuleValue: 25,
           floorValue: 25,
           matchedFields: {
-            gptSlot: 'test-div',
+            gptSlot: 'test.div',
             mediaType: 'banner'
           }
         }
@@ -504,7 +504,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderA');
       expect(result.bid.targetingBidder).to.equal(undefined);
@@ -518,7 +518,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderA');
       expect(result.bid.targetingBidder).to.equal('bidA2');
@@ -578,7 +578,7 @@ describe('multibid adapter', function () {
 
     it('it sorts and creates dynamic alias on bidsReceived if multibid configuration found with prefix', function () {
       let modifiedBids = [{...bidArray[1]}, {...bidArray[0]}].map(bid => {
-        addBidResponseHook(bidResponseCallback, 'test-div', {...bid});
+        addBidResponseHook(bidResponseCallback, 'test.div', {...bid});
 
         return bidResult;
       });
@@ -603,7 +603,7 @@ describe('multibid adapter', function () {
 
     it('it sorts by cpm treating dynamic alias as unique bid when no bid limit defined', function () {
       let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => {
-        addBidResponseHook(bidResponseCallback, 'test-div', {...bid});
+        addBidResponseHook(bidResponseCallback, 'test.div', {...bid});
 
         return bidResult;
       });
@@ -636,7 +636,7 @@ describe('multibid adapter', function () {
 
     it('it should filter out dynamic bid when bid limit is less than unique bid pool', function () {
       let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => {
-        addBidResponseHook(bidResponseCallback, 'test-div', {...bid});
+        addBidResponseHook(bidResponseCallback, 'test.div', {...bid});
 
         return bidResult;
       });
@@ -662,7 +662,7 @@ describe('multibid adapter', function () {
       config.setConfig({ multibid: [{bidder: 'bidderA', maxBids: 2, targetBiddercodePrefix: 'bidA'}] });
 
       let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => {
-        addBidResponseHook(bidResponseCallback, 'test-div', {...bid});
+        addBidResponseHook(bidResponseCallback, 'test.div', {...bid});
 
         return bidResult;
       });

package/test/spec/modules/openxBidAdapter_spec.js

@@ -1602,32 +1602,6 @@ describe('OpenxAdapter', function () {
               scsm: 'dmp3/5:foo2|bar2,dmp4:baz2'
             },
           },
-          {
-            name: 'should not send duplicate proprietary segment data from first party config ',
-            config: {
-              ortb2: {
-                user: {
-                  data: [
-                    {name: 'dmp1', ext: {segtax: 4}, segment: [{id: 'foo'}, {id: 'bar'}, {id: 'foo'}]},
-                    {name: 'dmp1', ext: {segtax: 4}, segment: [{id: 'foo'}, {id: 'bar'}]},
-                  ]
-                },
-                site: {
-                  content: {
-                    data: [
-                      {name: 'dmp1', ext: {segtax: 4}, segment: [{id: 'foo'}, {id: 'bar'}]},
-                      {name: 'dmp3', ext: {segtax: 5}, segment: [{id: 'foo2'}, {id: 'foo2'}, {id: 'bar2'}]},
-                      {name: 'dmp3', ext: {segtax: 5}, segment: [{id: 'foo2'}, {id: 'bar2'}]},
-                    ]
-                  }
-                }
-              }
-            },
-            expect: {
-              sm: 'dmp1/4:foo|bar',
-              scsm: 'dmp1/4:foo|bar,dmp3/5:foo2|bar2'
-            },
-          },
           {
             name: 'should combine same provider segment data from ortb2.user.data',
             config: {

package/test/spec/modules/operaadsBidAdapter_spec.js

@@ -369,7 +369,7 @@ describe('Opera Ads Bid Adapter', function () {
         requestData = JSON.parse(reqs[0].data);
       }).to.not.throw();
 
-      expect(requestData.user.id).to.equal(bidRequests[0].userId.sharedid.id);
+      expect(requestData.user.buyeruid).to.equal(bidRequests[0].userId.sharedid.id);
     });
 
     it('pubcid should be used when sharedid is empty', function () {
@@ -406,7 +406,7 @@ describe('Opera Ads Bid Adapter', function () {
         requestData = JSON.parse(reqs[0].data);
       }).to.not.throw();
 
-      expect(requestData.user.id).to.equal(bidRequests[0].userId.pubcid);
+      expect(requestData.user.buyeruid).to.equal(bidRequests[0].userId.pubcid);
     });
 
     it('random uid will be generate when userId is empty', function () {
@@ -433,7 +433,7 @@ describe('Opera Ads Bid Adapter', function () {
         requestData = JSON.parse(reqs[0].data);
       }).to.not.throw();
 
-      expect(requestData.user.id).to.not.be.empty;
+      expect(requestData.user.buyeruid).to.not.be.empty;
     })
   });
 
@@ -679,9 +679,41 @@ describe('Opera Ads Bid Adapter', function () {
     });
   });
 
-  describe('Test getUserSyncs', function () {
-    it('getUserSyncs should return empty array', function () {
-      expect(spec.getUserSyncs()).to.be.an('array').that.is.empty;
+  describe('Test getUserSyncs with both iframe and pixel disabled', function () {
+    it('getUserSyncs should return an empty array', function () {
+      const syncOptions = {};
+      expect(spec.getUserSyncs(syncOptions)).to.be.an('array').that.is.empty;
+    });
+  });
+
+  describe('Test getUserSyncs with iframe enabled', function () {
+    it('getUserSyncs should return array', function () {
+      const syncOptions = {
+        iframeEnabled: true
+      }
+      const userSyncPixels = spec.getUserSyncs(syncOptions)
+      expect(userSyncPixels).to.have.lengthOf(1);
+      expect(userSyncPixels[0].url).to.equal('https://s.adx.opera.com/usersync/page')
+    });
+  });
+
+  describe('Test getUserSyncs with pixel enabled', function () {
+    it('getUserSyncs should return array', function () {
+      const serverResponse = {
+        body: {
+          'pixels': [
+            'https://b1.com/usersync',
+            'https://b2.com/usersync'
+          ]
+        }
+      };
+      const syncOptions = {
+        pixelEnabled: true
+      }
+      const userSyncPixels = spec.getUserSyncs(syncOptions, [serverResponse])
+      expect(userSyncPixels).to.have.lengthOf(2);
+      expect(userSyncPixels[0].url).to.equal('https://b1.com/usersync')
+      expect(userSyncPixels[1].url).to.equal('https://b2.com/usersync')
     });
   });
 

package/test/spec/modules/otmBidAdapter_spec.js

@@ -0,0 +1,67 @@
+import {expect} from 'chai';
+import {spec} from 'modules/otmBidAdapter';
+
+describe('otmBidAdapter', function () {
+  it('validate_pub_params', function () {
+    expect(spec.isBidRequestValid({
+      bidder: 'otm',
+      params: {
+        tid: '123',
+        bidfloor: 20
+      }
+    })).to.equal(true);
+  });
+
+  it('validate_generated_params', function () {
+    let bidRequestData = [{
+      bidId: 'bid1234',
+      bidder: 'otm',
+      params: {
+        tid: '123',
+        bidfloor: 20
+      },
+      sizes: [[240, 400]]
+    }];
+
+    let request = spec.buildRequests(bidRequestData);
+    let req_data = request[0].data;
+
+    expect(req_data.bidid).to.equal('bid1234');
+  });
+
+  it('validate_response_params', function () {
+    let bidRequestData = {
+      data: {
+        bidId: 'bid1234'
+      }
+    };
+
+    let serverResponse = {
+      body: [
+        {
+          'auctionid': '3c6f8e22-541b-485c-9214-e974d9fb1b6f',
+          'cpm': 847.097,
+          'ad': '<html><body>test html</body></html>',
+          'w': 240,
+          'h': 400,
+          'currency': 'RUB',
+          'ttl': 300,
+          'creativeid': '1_7869053',
+          'bidid': '101f211def7c99',
+          'transactionid': 'transaction_id_1'
+        }
+      ]
+    };
+
+    let bids = spec.interpretResponse(serverResponse, bidRequestData);
+    expect(bids).to.have.lengthOf(1);
+    let bid = bids[0];
+    expect(bid.cpm).to.equal(847.097);
+    expect(bid.currency).to.equal('RUB');
+    expect(bid.width).to.equal(240);
+    expect(bid.height).to.equal(400);
+    expect(bid.netRevenue).to.equal(true);
+    expect(bid.requestId).to.equal('101f211def7c99');
+    expect(bid.ad).to.equal('<html><body>test html</body></html>');
+  });
+});

package/test/spec/modules/outbrainBidAdapter_spec.js

@@ -2,6 +2,7 @@ import {expect} from 'chai';
 import {spec} from 'modules/outbrainBidAdapter.js';
 import {config} from 'src/config.js';
 import {server} from 'test/mocks/xhr';
+import { createEidsArray } from 'modules/userId/eids.js';
 
 describe('Outbrain Adapter', function () {
   describe('Bid request and response', function () {
@@ -344,6 +345,23 @@ describe('Outbrain Adapter', function () {
 
         config.resetConfig()
       });
+
+      it('should pass extended ids', function () {
+        let bidRequest = {
+          bidId: 'bidId',
+          params: {},
+          userIdAsEids: createEidsArray({
+            idl_env: 'id-value',
+          }),
+          ...commonBidRequest,
+        };
+
+        let res = spec.buildRequests([bidRequest], commonBidderRequest);
+        const resData = JSON.parse(res.data)
+        expect(resData.user.ext.eids).to.deep.equal([
+          {source: 'liveramp.com', uids: [{id: 'id-value', atype: 3}]}
+        ]);
+      });
     })
 
     describe('interpretResponse', function () {

package/test/spec/modules/sonobiBidAdapter_spec.js

@@ -238,14 +238,17 @@ describe('SonobiBidAdapter', function () {
   });
 
   describe('.buildRequests', function () {
+    let sandbox;
     beforeEach(function() {
       sinon.stub(userSync, 'canBidderRegisterSync');
       sinon.stub(utils, 'getGptSlotInfoForAdUnitCode')
-        .onFirstCall().returns({gptSlot: '/123123/gpt_publisher/adunit-code-3', divId: 'adunit-code-3-div-id'})
+        .onFirstCall().returns({gptSlot: '/123123/gpt_publisher/adunit-code-3', divId: 'adunit-code-3-div-id'});
+      sandbox = sinon.createSandbox();
     });
     afterEach(function() {
       userSync.canBidderRegisterSync.restore();
       utils.getGptSlotInfoForAdUnitCode.restore();
+      sandbox.restore();
     });
     let bidRequest = [{
       'schain': {
@@ -333,6 +336,36 @@ describe('SonobiBidAdapter', function () {
       uspConsent: 'someCCPAString'
     };
 
+    it('should set fpd if there is any data in ortb2', function() {
+      const ortb2 = {
+        site: {
+          ext: {
+            data: {
+              pageType: 'article',
+              category: 'tools'
+            }
+          }
+        },
+        user: {
+          ext: {
+            data: {
+              registered: true,
+              interests: ['cars']
+            }
+          }
+        }
+      };
+
+      sandbox.stub(config, 'getConfig').callsFake(key => {
+        const config = {
+          ortb2: ortb2
+        };
+        return utils.deepAccess(config, key);
+      });
+      const bidRequests = spec.buildRequests(bidRequest, bidderRequests);
+      expect(bidRequests.data.fpd).to.equal(JSON.stringify(ortb2));
+    });
+
     it('should populate coppa as 1 if set in config', function () {
       config.setConfig({coppa: true});
       const bidRequests = spec.buildRequests(bidRequest, bidderRequests);

package/test/spec/modules/sortableBidAdapter_spec.js

@@ -112,6 +112,13 @@ describe('sortableBidAdapter', function() {
           'key2': 'val2'
         }
       },
+      'ortb2Imp': {
+        'ext': {
+          'data': {
+            'pbadslot': 'abc/123'
+          }
+        }
+      },
       'sizes': [
         [300, 250]
       ],
@@ -176,6 +183,10 @@ describe('sortableBidAdapter', function() {
       expect(requestBody.imp[0].floor).to.equal(0.21);
     });
 
+    it('includes pbadslot in the bid request', function () {
+      expect(requestBody.imp[0].ext.gpid).to.equal('abc/123');
+    });
+
     it('sets domain and href correctly', function () {
       expect(requestBody.site.domain).to.equal('example.com');
       expect(requestBody.site.page).to.equal('http://example.com/page?param=val');