prebid.js 5.18.0 → 5.20.2

package/test/spec/modules/adfBidAdapter_spec.js

@@ -29,11 +29,34 @@ describe('Adf adapter', function () {
 
     it('should return true when required params found', function () {
       assert(spec.isBidRequestValid(bid));
+
+      bid.params = {
+        inv: 1234,
+        mname: 'some-placement'
+      };
+      assert(spec.isBidRequestValid(bid));
+
+      bid.params = {
+        mid: 4332,
+        inv: 1234,
+        mname: 'some-placement'
+      };
+      assert(spec.isBidRequestValid(bid));
     });
 
     it('should return false when required params are missing', function () {
       bid.params = { adxDomain: 'adx.adform.net' };
       assert.isFalse(spec.isBidRequestValid(bid));
+
+      bid.params = {
+        mname: 'some-placement'
+      };
+      assert.isFalse(spec.isBidRequestValid(bid));
+
+      bid.params = {
+        inv: 1234
+      };
+      assert.isFalse(spec.isBidRequestValid(bid));
     });
   });
 
@@ -331,6 +354,30 @@ describe('Adf adapter', function () {
         }
       });
 
+      describe('dynamic placement tag', function () {
+        it('should add imp parameters correctly', function () {
+          const validBidRequests = [
+            { bidId: 'bidId', params: { inv: 1000, mname: 'placement' }, mediaTypes: {video: {}} },
+            { bidId: 'bidId', params: { mid: 1234, inv: 1002, mname: 'placement2' }, mediaTypes: {video: {}} },
+            { bidId: 'bidId', params: { mid: 1234 }, mediaTypes: {video: {}} }
+          ];
+          const [ imp1, imp2, imp3 ] = getRequestImps(validBidRequests);
+
+          assert.equal(imp1.ext.bidder.inv, 1000);
+          assert.equal(imp1.ext.bidder.mname, 'placement');
+          assert.equal('tagid' in imp1, false);
+
+          assert.equal(imp2.ext.bidder.inv, 1002);
+          assert.equal(imp2.ext.bidder.mname, 'placement2');
+          assert.equal(imp2.tagid, 1234);
+
+          assert.ok(imp3.ext.bidder);
+          assert.equal('inv' in imp3.ext.bidder, false);
+          assert.equal('mname' in imp3.ext.bidder, false);
+          assert.equal(imp3.tagid, 1234);
+        });
+      });
+
       describe('price floors', function () {
         it('should not add if floors module not configured', function () {
           const validBidRequests = [{ bidId: 'bidId', params: {mid: 1000}, mediaTypes: {video: {}} }];
@@ -376,18 +423,14 @@ describe('Adf adapter', function () {
               return {
                 currency: currency,
                 floor
-              }
+              };
             }
           };
         }
-
-        function getRequestImps(validBidRequests) {
-          return JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data).imp;
-        }
       });
 
       describe('multiple media types', function () {
-        it('should use single media type for bidding', function () {
+        it('should use all configured media types for bidding', function () {
           let validBidRequests = [{
             bidId: 'bidId',
             params: { mid: 1000 },
@@ -414,20 +457,23 @@ describe('Adf adapter', function () {
               banner: {
                 sizes: [[100, 100], [200, 300]]
               },
-              native: {}
+              native: {},
+              video: {}
             }
           }];
-          let [ banner, video, native ] = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data).imp;
-
-          assert.ok(banner.banner);
-          assert.equal(banner.video, undefined);
-          assert.equal(banner.native, undefined);
-          assert.ok(video.video);
-          assert.equal(video.banner, undefined);
-          assert.equal(video.native, undefined);
-          assert.ok(native.native);
-          assert.equal(native.video, undefined);
-          assert.equal(native.banner, undefined);
+          let [ first, second, third ] = JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data).imp;
+
+          assert.ok(first.banner);
+          assert.ok(first.video);
+          assert.equal(first.native, undefined);
+
+          assert.ok(second.video);
+          assert.equal(second.banner, undefined);
+          assert.equal(second.native, undefined);
+
+          assert.ok(third.native);
+          assert.ok(third.video);
+          assert.ok(third.banner);
         });
       });
 
@@ -626,6 +672,10 @@ describe('Adf adapter', function () {
         });
       });
     });
+
+    function getRequestImps(validBidRequests) {
+      return JSON.parse(spec.buildRequests(validBidRequests, { refererInfo: { referer: 'page' } }).data).imp;
+    }
   });
 
   describe('interpretResponse', function () {
@@ -754,7 +804,12 @@ describe('Adf adapter', function () {
                   imptrackers: ['imptrackers url1', 'imptrackers url2']
                 },
                 dealid: 'deal-id',
-                adomain: [ 'demo.com' ]
+                adomain: [ 'demo.com' ],
+                ext: {
+                  prebid: {
+                    type: 'native'
+                  }
+                }
               }
             ]
           }],
@@ -767,7 +822,6 @@ describe('Adf adapter', function () {
           {
             bidId: 'bidId1',
             params: { mid: 1000 },
-            mediaType: 'native',
             nativeParams: {
               title: { required: true, len: 140 },
               image: { required: false, wmin: 836, hmin: 627, w: 325, h: 300, mimes: ['image/jpg', 'image/gif'] },
@@ -899,7 +953,7 @@ describe('Adf adapter', function () {
         let serverResponse = {
           body: {
             seatbid: [{
-              bid: [{ impid: '1', adm: '<banner>' }]
+              bid: [{ impid: '1', adm: '<banner>', ext: { prebid: { type: 'banner' } } }]
             }]
           }
         };
@@ -908,8 +962,7 @@ describe('Adf adapter', function () {
           bids: [
             {
               bidId: 'bidId1',
-              params: { mid: 1000 },
-              mediaType: 'banner'
+              params: { mid: 1000 }
             }
           ]
         };
@@ -917,6 +970,8 @@ describe('Adf adapter', function () {
         bids = spec.interpretResponse(serverResponse, bidRequest);
         assert.equal(bids.length, 1);
         assert.equal(bids[0].ad, '<banner>');
+        assert.equal(bids[0].mediaType, 'banner');
+        assert.equal(bids[0].meta.mediaType, 'banner');
       });
     });
 
@@ -925,7 +980,7 @@ describe('Adf adapter', function () {
         let serverResponse = {
           body: {
             seatbid: [{
-              bid: [{ impid: '1', adm: '<vast>' }]
+              bid: [{ impid: '1', adm: '<vast>', ext: { prebid: { type: 'video' } } }]
             }]
           }
         };
@@ -934,8 +989,7 @@ describe('Adf adapter', function () {
           bids: [
             {
               bidId: 'bidId1',
-              params: { mid: 1000 },
-              mediaType: 'video'
+              params: { mid: 1000 }
             }
           ]
         };
@@ -943,13 +997,15 @@ describe('Adf adapter', function () {
         bids = spec.interpretResponse(serverResponse, bidRequest);
         assert.equal(bids.length, 1);
         assert.equal(bids[0].vastXml, '<vast>');
+        assert.equal(bids[0].mediaType, 'video');
+        assert.equal(bids[0].meta.mediaType, 'video');
       });
 
       it('should add renderer for outstream bids', function () {
         let serverResponse = {
           body: {
             seatbid: [{
-              bid: [{ impid: '1', adm: '<vast>' }, { impid: '2', adm: '<vast>' }]
+              bid: [{ impid: '1', adm: '<vast>', ext: { prebid: { type: 'video' } } }, { impid: '2', adm: '<vast>', ext: { prebid: { type: 'video' } } }]
             }]
           }
         };
@@ -959,7 +1015,6 @@ describe('Adf adapter', function () {
             {
               bidId: 'bidId1',
               params: { mid: 1000 },
-              mediaType: 'video',
               mediaTypes: {
                 video: {
                   context: 'outstream'
@@ -969,7 +1024,6 @@ describe('Adf adapter', function () {
             {
               bidId: 'bidId2',
               params: { mid: 1000 },
-              mediaType: 'video',
               mediaTypes: {
                 video: {
                   constext: 'instream'

package/test/spec/modules/adtelligentBidAdapter_spec.js

@@ -17,6 +17,7 @@ const aliasEP = {
   mediafuse: 'https://ghb.hbmp.mediafuse.com/v2/auction/',
   navelix: 'https://ghb.hb.navelix.com/v2/auction/',
   bidsxchange: 'https://ghb.hbd.bidsxchange.com/v2/auction/',
+  streamkey: 'https://ghb.hb.streamkey.net/v2/auction/',
 };
 
 const DEFAULT_ADATPER_REQ = { bidderCode: 'adtelligent' };