prebid.js 5.16.0 → 5.20.0

package/test/spec/modules/multibid_spec.js

@@ -82,7 +82,7 @@ describe('multibid adapter', function () {
           'sizes': [[300, 250]]
         }
       },
-      'adUnitCode': 'test-div',
+      'adUnitCode': 'test.div',
       'transactionId': 'c153f3da-84f0-4be8-95cb-0647c458bc60',
       'sizes': [[300, 250]],
       'bidId': '2408ef83b84c9d',
@@ -106,7 +106,7 @@ describe('multibid adapter', function () {
           'sizes': [[300, 250]]
         }
       },
-      'adUnitCode': 'test-div',
+      'adUnitCode': 'test.div',
       'transactionId': 'c153f3da-84f0-4be8-95cb-0647c458bc60',
       'sizes': [[300, 250]],
       'bidId': '2408ef83b84c9d',
@@ -197,14 +197,14 @@ describe('multibid adapter', function () {
     });
 
     it('adds original bids and does not modify', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       addBidResponseHook(callbackFn, adUnitCode, {...bids[0]});
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -214,13 +214,13 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
     });
 
     it('modifies and adds both bids based on multibid configuration', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       config.setConfig({multibid: [{bidder: 'bidderA', maxBids: 2, targetBiddercodePrefix: 'bidA'}]});
@@ -232,7 +232,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -250,13 +250,13 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
     });
 
     it('only modifies bids defined in the multibid configuration', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       bids.push({
@@ -276,7 +276,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -292,7 +292,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
 
@@ -302,13 +302,13 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[2]);
     });
 
     it('only modifies and returns bids under limit for a specifc bidder in the multibid configuration', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       bids.push({
@@ -328,7 +328,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -344,7 +344,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
 
@@ -356,7 +356,7 @@ describe('multibid adapter', function () {
     });
 
     it('if no prefix in multibid configuration, modifies and returns bids under limit without preifx property', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArray[0]}, {...bidArray[1]}];
 
       bids.push({
@@ -375,7 +375,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[0]);
 
@@ -389,7 +389,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid).to.deep.equal(bids[1]);
 
@@ -401,7 +401,7 @@ describe('multibid adapter', function () {
     });
 
     it('does not include extra bids if cpm is less than floor value', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArrayAlt[1]}, {...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}];
 
       bids.map(bid => {
@@ -418,7 +418,7 @@ describe('multibid adapter', function () {
           floorRuleValue: 65,
           floorValue: 65,
           matchedFields: {
-            gptSlot: 'test-div',
+            gptSlot: 'test.div',
             mediaType: 'banner'
           }
         }
@@ -435,7 +435,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderA');
       expect(result.bid.targetingBidder).to.equal(undefined);
@@ -452,7 +452,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderB');
       expect(result.bid.targetingBidder).to.equal(undefined);
@@ -463,14 +463,14 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderC');
       expect(result.bid.targetingBidder).to.equal(undefined);
     });
 
     it('does  include extra bids if cpm is not less than floor value', function () {
-      let adUnitCode = 'test-div';
+      let adUnitCode = 'test.div';
       let bids = [{...bidArrayAlt[1]}, {...bidArrayAlt[0]}];
 
       bids.map(bid => {
@@ -487,7 +487,7 @@ describe('multibid adapter', function () {
           floorRuleValue: 25,
           floorValue: 25,
           matchedFields: {
-            gptSlot: 'test-div',
+            gptSlot: 'test.div',
             mediaType: 'banner'
           }
         }
@@ -504,7 +504,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderA');
       expect(result.bid.targetingBidder).to.equal(undefined);
@@ -518,7 +518,7 @@ describe('multibid adapter', function () {
 
       expect(result).to.not.equal(null);
       expect(result.adUnitCode).to.not.equal(null);
-      expect(result.adUnitCode).to.equal('test-div');
+      expect(result.adUnitCode).to.equal('test.div');
       expect(result.bid).to.not.equal(null);
       expect(result.bid.bidder).to.equal('bidderA');
       expect(result.bid.targetingBidder).to.equal('bidA2');
@@ -578,7 +578,7 @@ describe('multibid adapter', function () {
 
     it('it sorts and creates dynamic alias on bidsReceived if multibid configuration found with prefix', function () {
       let modifiedBids = [{...bidArray[1]}, {...bidArray[0]}].map(bid => {
-        addBidResponseHook(bidResponseCallback, 'test-div', {...bid});
+        addBidResponseHook(bidResponseCallback, 'test.div', {...bid});
 
         return bidResult;
       });
@@ -603,7 +603,7 @@ describe('multibid adapter', function () {
 
     it('it sorts by cpm treating dynamic alias as unique bid when no bid limit defined', function () {
       let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => {
-        addBidResponseHook(bidResponseCallback, 'test-div', {...bid});
+        addBidResponseHook(bidResponseCallback, 'test.div', {...bid});
 
         return bidResult;
       });
@@ -636,7 +636,7 @@ describe('multibid adapter', function () {
 
     it('it should filter out dynamic bid when bid limit is less than unique bid pool', function () {
       let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => {
-        addBidResponseHook(bidResponseCallback, 'test-div', {...bid});
+        addBidResponseHook(bidResponseCallback, 'test.div', {...bid});
 
         return bidResult;
       });
@@ -662,7 +662,7 @@ describe('multibid adapter', function () {
       config.setConfig({ multibid: [{bidder: 'bidderA', maxBids: 2, targetBiddercodePrefix: 'bidA'}] });
 
       let modifiedBids = [{...bidArrayAlt[0]}, {...bidArrayAlt[2]}, {...bidArrayAlt[3]}, {...bidArrayAlt[1]}].map(bid => {
-        addBidResponseHook(bidResponseCallback, 'test-div', {...bid});
+        addBidResponseHook(bidResponseCallback, 'test.div', {...bid});
 
         return bidResult;
       });

package/test/spec/modules/mytargetBidAdapter_spec.js

@@ -0,0 +1,199 @@
+import { expect } from 'chai';
+import { spec } from 'modules/mytargetBidAdapter';
+
+describe('MyTarget Adapter', function() {
+  describe('isBidRequestValid', function () {
+    it('should return true when required params found', function () {
+      let validBid = {
+        bidder: 'mytarget',
+        params: {
+          placementId: '1'
+        }
+      };
+
+      expect(spec.isBidRequestValid(validBid)).to.equal(true);
+    });
+
+    it('should return false for when required params are not passed', function () {
+      let invalidBid = {
+        bidder: 'mytarget',
+        params: {}
+      };
+
+      expect(spec.isBidRequestValid(invalidBid)).to.equal(false);
+    });
+  });
+
+  describe('buildRequests', function () {
+    let bidRequests = [
+      {
+        bidId: 'bid1',
+        bidder: 'mytarget',
+        params: {
+          placementId: '1'
+        }
+      },
+      {
+        bidId: 'bid2',
+        bidder: 'mytarget',
+        params: {
+          placementId: '2',
+          position: 1,
+          response: 1,
+          bidfloor: 10000
+        }
+      }
+    ];
+    let bidderRequest = {
+      refererInfo: {
+        referer: 'https://example.com?param=value'
+      }
+    };
+
+    let bidRequest = spec.buildRequests(bidRequests, bidderRequest);
+
+    it('should build single POST request for multiple bids', function() {
+      expect(bidRequest.method).to.equal('POST');
+      expect(bidRequest.url).to.equal('//ad.mail.ru/hbid_prebid/');
+      expect(bidRequest.data).to.be.an('object');
+      expect(bidRequest.data.places).to.be.an('array');
+      expect(bidRequest.data.places).to.have.lengthOf(2);
+    });
+
+    it('should pass bid parameters', function() {
+      let place1 = bidRequest.data.places[0];
+      let place2 = bidRequest.data.places[1];
+
+      expect(place1.placementId).to.equal('1');
+      expect(place2.placementId).to.equal('2');
+      expect(place1.id).to.equal('bid1');
+      expect(place2.id).to.equal('bid2');
+    });
+
+    it('should pass default position and response type', function() {
+      let place = bidRequest.data.places[0];
+
+      expect(place.position).to.equal(0);
+      expect(place.response).to.equal(0);
+    });
+
+    it('should pass provided position and response type', function() {
+      let place = bidRequest.data.places[1];
+
+      expect(place.position).to.equal(1);
+      expect(place.response).to.equal(1);
+    });
+
+    it('should not pass default bidfloor', function() {
+      let place = bidRequest.data.places[0];
+
+      expect(place.bidfloor).not.to.exist;
+    });
+
+    it('should not pass provided bidfloor', function() {
+      let place = bidRequest.data.places[1];
+
+      expect(place.bidfloor).to.exist;
+      expect(place.bidfloor).to.equal(10000);
+    });
+
+    it('should pass site parameters', function() {
+      let site = bidRequest.data.site;
+
+      expect(site).to.be.an('object');
+      expect(site.sitename).to.equal('example.com');
+      expect(site.page).to.equal('https://example.com?param=value');
+    });
+
+    it('should pass settings', function() {
+      let settings = bidRequest.data.settings;
+
+      expect(settings).to.be.an('object');
+      expect(settings.currency).to.equal('RUB');
+      expect(settings.windowSize).to.be.an('object');
+      expect(settings.windowSize.width).to.equal(window.screen.width);
+      expect(settings.windowSize.height).to.equal(window.screen.height);
+    });
+  });
+
+  describe('interpretResponse', function () {
+    let serverResponse = {
+      body: {
+        'bidder_status':
+          [
+            {
+              'bidder': 'mail.ru',
+              'response_time_ms': 100,
+              'num_bids': 2
+            }
+          ],
+        'bids':
+          [
+            {
+              'displayUrl': 'https://ad.mail.ru/hbid_imp/12345',
+              'size':
+                {
+                  'height': '400',
+                  'width': '240'
+                },
+              'id': '1',
+              'currency': 'RUB',
+              'price': 100,
+              'ttl': 360,
+              'creativeId': '123456'
+            },
+            {
+              'adm': '<p>Ad</p>',
+              'size':
+                {
+                  'height': '250',
+                  'width': '300'
+                },
+              'id': '2',
+              'price': 200
+            }
+          ]
+      }
+    };
+
+    let bids = spec.interpretResponse(serverResponse);
+
+    it('should return empty array for response with no bids', function() {
+      let emptyBids = spec.interpretResponse({ body: {} });
+
+      expect(emptyBids).to.have.lengthOf(0);
+    });
+
+    it('should parse all bids from response', function() {
+      expect(bids).to.have.lengthOf(2);
+    });
+
+    it('should parse bid with ad url', function() {
+      expect(bids[0].requestId).to.equal('1');
+      expect(bids[0].cpm).to.equal(100);
+      expect(bids[0].width).to.equal('240');
+      expect(bids[0].height).to.equal('400');
+      expect(bids[0].ttl).to.equal(360);
+      expect(bids[0].currency).to.equal('RUB');
+      expect(bids[0]).to.have.property('creativeId');
+      expect(bids[0].creativeId).to.equal('123456');
+      expect(bids[0].netRevenue).to.equal(true);
+      expect(bids[0].adUrl).to.equal('https://ad.mail.ru/hbid_imp/12345');
+      expect(bids[0]).to.not.have.property('ad');
+    });
+
+    it('should parse bid with ad markup', function() {
+      expect(bids[1].requestId).to.equal('2');
+      expect(bids[1].cpm).to.equal(200);
+      expect(bids[1].width).to.equal('300');
+      expect(bids[1].height).to.equal('250');
+      expect(bids[1].ttl).to.equal(180);
+      expect(bids[1].currency).to.equal('RUB');
+      expect(bids[1]).to.have.property('creativeId');
+      expect(bids[1].creativeId).not.to.equal('123456');
+      expect(bids[1].netRevenue).to.equal(true);
+      expect(bids[1].ad).to.equal('<p>Ad</p>');
+      expect(bids[1]).to.not.have.property('adUrl');
+    });
+  });
+});

package/test/spec/modules/nativoBidAdapter_spec.js

@@ -26,11 +26,11 @@ describe('nativoBidAdapterTests', function () {
       expect(spec.isBidRequestValid(bid)).to.equal(true)
     })
 
-    it('should return false when required params are not passed', function () {
+    it('should return true when params are not passed', function () {
       let bid2 = Object.assign({}, bid)
       delete bid2.params
       bid2.params = {}
-      expect(spec.isBidRequestValid(bid2)).to.equal(false)
+      expect(spec.isBidRequestValid(bid2)).to.equal(true)
     })
   })
 
@@ -129,7 +129,12 @@ describe('interpretResponse', function () {
     }
 
     // mock
-    spec.getRequestId = () => 123456
+    spec.getAdUnitData = () => {
+      return {
+        bidId: 123456,
+        sizes: [300, 250],
+      }
+    }
 
     let result = spec.interpretResponse({ body: response }, { bidderRequest })
     expect(Object.keys(result[0])).to.have.deep.members(
@@ -232,3 +237,45 @@ describe('getUserSyncs', function () {
     )
   })
 })
+
+describe('getAdUnitData', () => {
+  afterEach(() => {
+    if (window.bidRequestMap) delete window.bidRequestMap
+  })
+
+  it('Matches placementId value', () => {
+    const adUnitData = {
+      bidId: 123456,
+      sizes: [300, 250],
+    }
+
+    window.bidRequestMap = {
+      9876543: {
+        12345: adUnitData,
+      },
+    }
+
+    const data = spec.getAdUnitData(9876543, { impid: 12345 })
+    expect(Object.keys(data)).to.have.deep.members(
+      Object.keys(adUnitData)
+    )
+  })
+
+  it('Falls back to ad unit code value', () => {
+    const adUnitData = {
+      bidId: 123456,
+      sizes: [300, 250],
+    }
+
+    window.bidRequestMap = {
+      9876543: {
+        '#test-code': adUnitData,
+      },
+    }
+
+    const data = spec.getAdUnitData(9876543, { impid: 12345, ext: { ad_unit_code: '#test-code' } })
+    expect(Object.keys(data)).to.have.deep.members(
+      Object.keys(adUnitData)
+    )
+  })
+})

package/test/spec/modules/nextMillenniumBidAdapter_spec.js

@@ -8,10 +8,22 @@ describe('nextMillenniumBidAdapterTests', function() {
       auctionId: 'b06c5141-fe8f-4cdf-9d7d-54415490a917',
       bidder: 'nextMillennium',
       params: { placement_id: '-1' },
-      sizes: [[300, 250]]
+      sizes: [[300, 250]],
+      uspConsent: '1---',
+      gdprConsent: {
+        consentString: 'kjfdniwjnifwenrif3',
+        gdprApplies: true
+      }
     }
   ];
 
+  it('Request params check with GDPR Consent', function () {
+    const request = spec.buildRequests(bidRequestData, bidRequestData[0]);
+    expect(JSON.parse(request[0].data).user.ext.consent).to.equal('kjfdniwjnifwenrif3');
+    expect(JSON.parse(request[0].data).regs.ext.us_privacy).to.equal('1---');
+    expect(JSON.parse(request[0].data).regs.ext.gdpr).to.equal(1);
+  });
+
   it('validate_generated_params', function() {
     const request = spec.buildRequests(bidRequestData);
     expect(request[0].bidId).to.equal('bid1234');