prebid.js 10.3.0 → 10.5.0

package/modules/tadvertisingBidAdapter.js

@@ -0,0 +1,279 @@
+import {
+  deepAccess,
+  isEmpty,
+  deepSetValue,
+  logWarn,
+  replaceAuctionPrice,
+  triggerPixel,
+  logError,
+  isFn,
+  isPlainObject,
+  isInteger
+} from '../src/utils.js';
+import {registerBidder} from '../src/adapters/bidderFactory.js';
+import {BANNER, VIDEO} from "../src/mediaTypes.js";
+import {ortbConverter} from '../libraries/ortbConverter/converter.js';
+import {hasPurpose1Consent} from '../src/utils/gdpr.js';
+import {ajax, sendBeacon} from "../src/ajax.js";
+
+const BIDDER_CODE = 'tadvertising';
+const GVL_ID = 213;
+const ENDPOINT_URL = 'https://prebid.tads.xplosion.de/bid';
+const NOTIFICATION_URL = 'https://prebid.tads.xplosion.de/notify';
+const USER_SYNC_URL = 'https://match.adsrvr.org/track/cmf/generic?ttd_pid=pxpinp0&ttd_tpi=1';
+const BID_TTL = 360;
+
+const MEDIA_TYPES = {
+  [BANNER]: 1,
+  [VIDEO]: 2,
+};
+
+const pageCache = {};
+
+const converter = ortbConverter({
+  bidResponse: (buildBidResponse, bid, context) => {
+    let mediaType = BANNER;
+    if (bid.adm && bid.adm.startsWith('<VAST')) {
+      mediaType = VIDEO;
+    }
+    bid.mtype = MEDIA_TYPES[mediaType];
+
+    return buildBidResponse(bid, context);
+  },
+});
+
+export function buildSuccessNotification(bidEvent) {
+  return Object.fromEntries(
+    Object.entries({
+      publisherId: deepAccess(bidEvent, 'params.0.publisherId'),
+      placementId: deepAccess(bidEvent, 'params.0.placementId'),
+      bidId: bidEvent.adId,
+      auctionId: bidEvent.auctionId,
+      adUnitCode: bidEvent.adUnitCode,
+      page: pageCache[bidEvent.requestId],
+      cpm: bidEvent.cpm,
+      currency: bidEvent.currency,
+      adId: bidEvent.adId,
+      creativeId: bidEvent.creativeId,
+      size: bidEvent.size,
+      dealId: bidEvent.dealId,
+      mediaType: bidEvent.mediaType,
+      status: bidEvent.status,
+      ttr: bidEvent.timeToRespond
+    }).filter(([_, value]) => value != null)
+  );
+}
+
+export function buildErrorNotification(bidEvent, error = null) {
+  return Object.fromEntries(
+    Object.entries({
+      publisherId: deepAccess(bidEvent, 'bids.0.params.publisherId') || deepAccess(bidEvent, 'bids.0.params.0.publisherId'),
+      placementId: deepAccess(bidEvent, 'bids.0.params.placementId') || deepAccess(bidEvent, 'bids.0.params.0.placementId'),
+      bidId: deepAccess(bidEvent, 'bids.0.bidId'),
+      auctionId: deepAccess(bidEvent, 'auctionId'),
+      adUnitCode: deepAccess(bidEvent, 'bids.0.adUnitCode'),
+      page: deepAccess(bidEvent, 'refererInfo.page'),
+      timeout: bidEvent.timeout,
+      timedOut: error?.timedOut,
+      statusCode: error?.status,
+      response: error?.responseText
+    }).filter(([_, value]) => value != null)
+  );
+}
+
+export function buildTimeoutNotification(bidEvent) {
+  return Object.fromEntries(
+    Object.entries({
+      publisherId: deepAccess(bidEvent, 'params.0.publisherId'),
+      placementId: deepAccess(bidEvent, 'params.0.placementId'),
+      bidId: deepAccess(bidEvent, 'bidId'),
+      auctionId: deepAccess(bidEvent, 'auctionId'),
+      adUnitCode: deepAccess(bidEvent, 'adUnitCode'),
+      page: deepAccess(bidEvent, 'ortb2.site.page'),
+      timeout: deepAccess(bidEvent, 'timeout'),
+    }).filter(([_, value]) => value != null)
+  );
+}
+
+export function getBidFloor (bid) {
+  // value from params takes precedance over value set by Floor Module
+  if (bid.params.bidfloor) {
+    return bid.params.bidfloor;
+  }
+
+  if (!isFn(bid.getFloor)) {
+    return null;
+  }
+
+  let floor = bid.getFloor({
+    currency: 'USD',
+    mediaType: '*',
+    size: '*'
+  });
+  if (isPlainObject(floor) && !isNaN(floor.floor) && floor.currency === 'USD') {
+    return floor.floor;
+  }
+  return null;
+}
+
+export const sendNotification = (notifyUrl, eventType, data) => {
+  try {
+    const notificationUrl = `${notifyUrl}/${eventType}`;
+    const payload = JSON.stringify(data)
+
+    if (!sendBeacon(notificationUrl, payload)) {
+      // Fallback to using AJAX if Beacon API is not supported
+      ajax(notificationUrl, null, payload, {
+        method: 'POST',
+        contentType: 'text/plain',
+        keepalive: true,
+      });
+    }
+  } catch (error) {
+    logError(BIDDER_CODE, `Failed to notify event: ${eventType}`, error);
+  }
+}
+
+export const spec = {
+  code: BIDDER_CODE,
+  gvlid: GVL_ID,
+  supportedMediaTypes: [BANNER, VIDEO],
+  sync_url: USER_SYNC_URL,
+  notify_url: NOTIFICATION_URL,
+
+  isBidRequestValid: function (bid) {
+    if (!bid.params.publisherId) {
+      logWarn(BIDDER_CODE + ': Missing required parameter params.publisherId');
+      return false;
+    }
+    if (bid.params.publisherId.length > 32) {
+      logWarn(BIDDER_CODE + ': params.publisherId must be 32 characters or less');
+      return false;
+    }
+    if (!bid.params.placementId) {
+      logWarn(BIDDER_CODE + ': Missing required parameter params.placementId');
+      return false;
+    }
+
+    const mediaTypesBanner = deepAccess(bid, 'mediaTypes.banner');
+    const mediaTypesVideo = deepAccess(bid, 'mediaTypes.video');
+
+    if (!mediaTypesBanner && !mediaTypesVideo) {
+      logWarn(BIDDER_CODE + ': one of mediaTypes.banner or mediaTypes.video must be passed');
+      return false;
+    }
+
+    if (FEATURES.VIDEO && mediaTypesVideo) {
+      if (!mediaTypesVideo.maxduration || !isInteger(mediaTypesVideo.maxduration)) {
+        logWarn(BIDDER_CODE + ': mediaTypes.video.maxduration must be set to the maximum video ad duration in seconds');
+        return false;
+      }
+      if (!mediaTypesVideo.api || mediaTypesVideo.api.length === 0) {
+        logWarn(BIDDER_CODE + ': mediaTypes.video.api should be an array of supported api frameworks. See the Open RTB v2.5 spec for valid values');
+        return false;
+      }
+      if (!mediaTypesVideo.mimes || mediaTypesVideo.mimes.length === 0) {
+        logWarn(BIDDER_CODE + ': mediaTypes.video.mimes should be an array of supported mime types');
+        return false;
+      }
+      if (!mediaTypesVideo.protocols) {
+        logWarn(BIDDER_CODE + ': mediaTypes.video.protocols should be an array of supported protocols. See the Open RTB v2.5 spec for valid values');
+        return false;
+      }
+    }
+    return true;
+  },
+
+  buildRequests: function (validBidRequests, bidderRequest) {
+    let data = converter.toORTB({validBidRequests, bidderRequest})
+    deepSetValue(data, 'site.publisher.id', bidderRequest.bids[0].params.publisherId)
+
+    const bidFloor = getBidFloor(bidderRequest.bids[0])
+    if (bidFloor) {
+      deepSetValue(data, 'imp.0.bidfloor', bidFloor)
+      deepSetValue(data, 'imp.0.bidfloorcur', 'USD')
+    }
+
+    if (deepAccess(validBidRequests[0], 'userIdAsEids')) {
+      deepSetValue(data, 'user.ext.eids', validBidRequests[0].userIdAsEids);
+    }
+
+    bidderRequest.bids.forEach((bid, index) => {
+      pageCache[bid.bidId] = deepAccess(bid, 'ortb2.site.page');
+      deepSetValue(data, `imp.${index}.ext.gpid`, bid.params.placementId);
+    })
+    return {
+      method: 'POST',
+      url: ENDPOINT_URL,
+      data: data,
+    };
+  },
+
+  interpretResponse: function (response, serverRequest) {
+    if (isEmpty(response.body)) {
+      return [];
+    }
+    deepSetValue(response, 'body.seatbid.0.bid.0.impid', deepAccess(serverRequest, 'data.imp.0.id'))
+
+    const bids = converter.fromORTB({response: response.body, request: serverRequest.data}).bids;
+
+    bids.forEach(bid => {
+      bid.ttl = BID_TTL;
+      bid.netRevenue = true;
+      bid.currency = bid.currency || 'USD';
+      bid.dealId = bid.dealId || null;
+      if (bid.vastXml) {
+        bid.vastXml = replaceAuctionPrice(bid.vastXml, bid.cpm);
+      } else {
+        bid.ad = replaceAuctionPrice(bid.ad, bid.cpm);
+      }
+    })
+
+    return bids;
+  },
+
+  getUserSyncs: function (syncOptions, serverResponses, gdprConsent) {
+    const syncs = []
+    if (serverResponses[0]?.body?.ext?.uss === 1 && gdprConsent && hasPurpose1Consent(gdprConsent)) {
+      let gdprParams;
+      if (typeof gdprConsent.gdprApplies === 'boolean') {
+        gdprParams = `&gdpr=${Number(gdprConsent.gdprApplies)}&gdpr_consent=${gdprConsent.consentString}`;
+      } else {
+        gdprParams = `&gdpr_consent=${gdprConsent.consentString}`;
+      }
+
+      if (syncOptions.pixelEnabled) {
+        syncs.push({
+          type: 'image',
+          url: USER_SYNC_URL + gdprParams
+        });
+      }
+    }
+    return syncs;
+  },
+
+  onBidWon: function (bid) {
+    const payload = buildSuccessNotification(bid)
+    sendNotification(spec.notify_url, "won", payload)
+  },
+
+  onBidBillable: function (bid) {
+    if (bid.burl) {
+      triggerPixel(replaceAuctionPrice(bid.burl, bid.cpm));
+    }
+    const payload = buildSuccessNotification(bid)
+    sendNotification(spec.notify_url, "billable", payload)
+  },
+
+  onTimeout: function (timeoutData) {
+    const payload = timeoutData.map(data => buildTimeoutNotification(data))
+    sendNotification(spec.notify_url, 'timeout', payload)
+  },
+
+  onBidderError: function ({error, bidderRequest}) {
+    const payload = buildErrorNotification(bidderRequest, error)
+    sendNotification(spec.notify_url, 'error', payload)
+  }
+}
+
+registerBidder(spec);

package/modules/tadvertisingBidAdapter.md

@@ -0,0 +1,74 @@
+# Overview
+
+```markdown
+Module Name: T-Advertising Solutions Bid Adapter
+Module Type: Bidder Adapter
+Maintainer: dev@emetriq.com
+```
+
+# Description
+The T-Advertising Solutions Bid Adapter is a module that connects to T-Advertising Solutions demand sources, enabling 
+publishers to access advertising demand. This adapter facilitates real-time bidding integration between Prebid.js and 
+T-Advertising Solutions' platform.
+
+This adapter supports both Banner and Video ad formats
+
+# Test Parameters
+The following ad units demonstrate how to configure the adapter for different ad formats:
+
+## Banner Ad Unit Example
+```javascript
+var bannerAdUnit = {
+    code: 'myBannerAdUnit',
+    mediaTypes: {
+        banner: {
+            sizes: [400, 600],
+        }
+    },
+    bids: [
+        {
+            bidder: 'tadvertising',
+            params: {
+                publisherId: '1427ab10f2e448057ed3b422',
+                placementId: 'sidebar_1',
+                bidfloor: 0.95 // Optional - default is 0
+            }
+        }
+    ]
+};
+```
+
+The banner ad unit configuration above demonstrates how to set up a basic banner implementation.
+
+## Video Ad Unit Example
+```javascript
+var videoAdUnit = {
+    code: 'myVideoAdUnit',
+    mediaTypes: {
+        video: {
+            mimes: ['video/mp4'],
+            minduration: 1,
+            maxduration: 60,
+            api: [1, 3],
+            placement: 3,
+            protocols: [2,3,5,6]
+        }
+    },
+    bids: [
+        {
+            bidder: "tadvertising",
+            params: {
+                publisherId: '1427ab10f2e448057ed3b422',
+                placementId: 'sidebar_1',
+                bidfloor: 0.95 // Optional - default is 0
+            }
+        }
+    ]
+}
+```
+The video ad unit configuration demonstrates how to set up a basic video implementation.
+
+# GDPR Compliance
+
+The T-Advertising Solutions adapter supports the IAB Europe Transparency & Consent Framework (TCF) for GDPR compliance. 
+When properly configured, the adapter will pass consent information to T-Advertising Solutions' servers.

package/modules/talkadsBidAdapter.js

@@ -6,11 +6,9 @@ import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
 
 const CURRENCY = 'EUR';
 const BIDDER_CODE = 'talkads';
-const GVLID = 1074;
 
 export const spec = {
   code: BIDDER_CODE,
-  gvlid: GVLID,
   supportedMediaTypes: [ NATIVE, BANNER ],
 
   /**

package/modules/tappxBidAdapter.js

@@ -15,7 +15,7 @@ const BIDDER_CODE = 'tappx';
 const GVLID_CODE = 628;
 const TTL = 360;
 const CUR = 'USD';
-const TAPPX_BIDDER_VERSION = '0.1.3';
+const TAPPX_BIDDER_VERSION = '0.1.4';
 const TYPE_CNN = 'prebidjs';
 const LOG_PREFIX = '[TAPPX]: ';
 const VIDEO_SUPPORT = ['instream', 'outstream'];
@@ -398,6 +398,22 @@ function buildOneRequest(validBidRequests, bidderRequest) {
 
   imp.ext = {};
   imp.ext.bidder = bidder;
+
+  const pbadslot = validBidRequests.ortb2Imp?.ext?.data?.pbadslot;
+  const adslot = validBidRequests.ortb2Imp?.ext?.data?.adserver?.adslot;
+  const adserverName = validBidRequests.ortb2Imp?.ext?.data?.adserver?.name;
+  const gpid = validBidRequests.ortb2Imp?.ext?.gpid;
+  const divid = validBidRequests.ortb2Imp?.ext?.divid;
+
+  if (pbadslot || adslot || adserverName) imp.ext.data = {};
+  if (adslot || adserverName) imp.ext.data.adserver = {};
+
+  if (gpid) imp.ext.gpid = gpid;
+  if (pbadslot) imp.ext.data.pbadslot = pbadslot;
+  if (adslot) imp.ext.data.adserver.adslot = adslot;
+  if (adserverName) imp.ext.data.adserver.name = adserverName;
+  if (divid) imp.ext.divid = divid;
+
   // < Imp object
 
   // > Device object

package/modules/ucfunnelBidAdapter.js

@@ -14,7 +14,6 @@ import { convertOrtbRequestToProprietaryNative } from '../src/native.js';
 const COOKIE_NAME = 'ucf_uid';
 const VER = 'ADGENT_PREBID-2018011501';
 const BIDDER_CODE = 'ucfunnel';
-const GVLID = 607;
 const CURRENCY = 'USD';
 const VIDEO_CONTEXT = {
   INSTREAM: 0,
@@ -24,7 +23,6 @@ const storage = getStorageManager({bidderCode: BIDDER_CODE});
 
 export const spec = {
   code: BIDDER_CODE,
-  gvlid: GVLID,
   ENDPOINT: 'https://hb.aralego.com/header',
   supportedMediaTypes: [BANNER, VIDEO, NATIVE],
   /**

package/modules/userId/eids.js

@@ -72,7 +72,9 @@ export function createEidsArray(bidRequestUserId, eidConfigs = EID_CONFIG) {
         if (!Array.isArray(eids)) {
           eids = [eids];
         }
-        eids.forEach(eid => eid.uids = eid.uids.filter(({id}) => isStr(id)))
+        eids.forEach(eid => {
+          eid.uids = eid.uids.filter(({id}) => isStr(id))
+        })
         eids = eids.filter(({uids}) => uids?.length > 0);
       } catch (e) {
         logError(`Could not generate EID for "${name}"`, e);

package/modules/vdoaiBidAdapter.md

@@ -64,7 +64,7 @@ The VDO.AI Bidder Adapter expects Prebid Cache(for video) to be enabled so that
 pbjs.setConfig({
     usePrebidCache: true,
     cache: {
-        url: 'https://prebid.adnxs.com/pbc/v1/cache'
+        url: 'https://prebid.example.com/pbc/v1/cache'
     }
 });
 ```

package/modules/ventesBidAdapter.js

@@ -130,7 +130,9 @@ function generateBidRequestsFromAdUnits(bidRequests, bidRequestId, adUnitContext
   if (deviceObjBid && deviceObjBid.params && deviceObjBid.params.device) {
     deviceObj = {};
     Object.keys(deviceObjBid.params.device)
-      .forEach(param => deviceObj[param] = deviceObjBid.params.device[param]);
+      .forEach(param => {
+        deviceObj[param] = deviceObjBid.params.device[param];
+      });
     if (!deviceObjBid.hasOwnProperty('ua')) {
       deviceObj.ua = navigator.userAgent;
     }
@@ -156,7 +158,9 @@ function generateBidRequestsFromAdUnits(bidRequests, bidRequestId, adUnitContext
     if (appDeviceObjBid && appDeviceObjBid.params && appDeviceObjBid.params.app && appDeviceObjBid.params.app.id) {
       appIdObj = {};
       Object.keys(appDeviceObjBid.params.app)
-        .forEach(param => appIdObj[param] = appDeviceObjBid.params.app[param]);
+        .forEach(param => {
+          appIdObj[param] = appDeviceObjBid.params.app[param];
+        });
     }
     payload.app = appIdObj;
   }

package/modules/videoreachBidAdapter.js

@@ -2,11 +2,9 @@ import {getBidIdParameter, getValue} from '../src/utils.js';
 import {registerBidder} from '../src/adapters/bidderFactory.js';
 const BIDDER_CODE = 'videoreach';
 const ENDPOINT_URL = 'https://a.videoreach.com/hb/';
-const GVLID = 547;
 
 export const spec = {
   code: BIDDER_CODE,
-  gvlid: GVLID,
   supportedMediaTypes: ['banner'],
 
   isBidRequestValid: function(bid) {

package/modules/viewdeosDXBidAdapter.js

@@ -23,7 +23,6 @@ const syncsCache = {};
 export const spec = {
   code: BIDDER_CODE,
   aliases: ['viewdeos'],
-  gvlid: 924,
   supportedMediaTypes,
   isBidRequestValid,
   getUserSyncs: function (syncOptions, serverResponses) {

package/modules/winrBidAdapter.js

@@ -180,7 +180,9 @@ export const spec = {
       appDeviceObj = {};
       Object.keys(appDeviceObjBid.params.app)
         .filter(param => APP_DEVICE_PARAMS.includes(param))
-        .forEach(param => appDeviceObj[param] = appDeviceObjBid.params.app[param]);
+        .forEach(param => {
+          appDeviceObj[param] = appDeviceObjBid.params.app[param];
+        });
     }
 
     const appIdObjBid = ((bidRequests) || []).find(hasAppId);

package/modules/yieldlabBidAdapter.js

@@ -421,7 +421,8 @@ function createSchainString(schain) {
   const complete = (schain.complete === 1 || schain.complete === 0) ? schain.complete : '';
   const keys = ['asi', 'sid', 'hp', 'rid', 'name', 'domain', 'ext'];
   const nodesString = schain.nodes.reduce((acc, node) => {
-    return acc += `!${keys.map(key => node[key] ? encodeURIComponentWithBangIncluded(node[key]) : '').join(',')}`;
+    acc += `!${keys.map(key => node[key] ? encodeURIComponentWithBangIncluded(node[key]) : '').join(',')}`;
+    return acc;
   }, '');
   return `${ver},${complete}${nodesString}`;
 }

package/modules/yieldliftBidAdapter.js

@@ -3,7 +3,6 @@ import {registerBidder} from '../src/adapters/bidderFactory.js';
 import {BANNER} from '../src/mediaTypes.js';
 
 const ENDPOINT_URL = 'https://x.yieldlift.com/pbjs';
-const GVLID = 866;
 
 const DEFAULT_BID_TTL = 300;
 const DEFAULT_CURRENCY = 'USD';
@@ -11,7 +10,6 @@ const DEFAULT_NET_REVENUE = true;
 
 export const spec = {
   code: 'yieldlift',
-  gvlid: GVLID,
   aliases: ['yl'],
   supportedMediaTypes: [BANNER],
 

package/modules/yieldmoBidAdapter.js

@@ -500,12 +500,16 @@ function openRtbImpression(bidRequest) {
   const mediaTypesParams = deepAccess(bidRequest, 'mediaTypes.video', {});
   Object.keys(mediaTypesParams)
     .filter(param => OPENRTB_VIDEO_BIDPARAMS.includes(param))
-    .forEach(param => imp.video[param] = mediaTypesParams[param]);
+    .forEach(param => {
+      imp.video[param] = mediaTypesParams[param];
+    });
 
   const videoParams = deepAccess(bidRequest, 'params.video', {});
   Object.keys(videoParams)
     .filter(param => OPENRTB_VIDEO_BIDPARAMS.includes(param))
-    .forEach(param => imp.video[param] = videoParams[param]);
+    .forEach(param => {
+      imp.video[param] = videoParams[param];
+    });
 
   if (imp.video.skippable) {
     imp.video.skip = 1;
@@ -577,7 +581,9 @@ function openRtbSite(bidRequest, bidderRequest) {
   if (siteParams) {
     Object.keys(siteParams)
       .filter(param => OPENRTB_VIDEO_SITEPARAMS.includes(param))
-      .forEach(param => result[param] = siteParams[param]);
+      .forEach(param => {
+        result[param] = siteParams[param];
+      });
   }
   return result;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prebid.js",
-  "version": "10.3.0",
+  "version": "10.5.0",
   "description": "Header Bidding Management Library",
   "main": "dist/src/prebid.public.ts",
   "exports": {
@@ -65,9 +65,8 @@
     "babel-plugin-istanbul": "^6.1.1",
     "body-parser": "^1.19.0",
     "chai": "^4.2.0",
-    "coveralls-next": "^4.2.1",
     "deep-equal": "^2.0.3",
-    "eslint": "^9.22.0",
+    "eslint": "^9.31.0",
     "eslint-plugin-import": "^2.31.0",
     "eslint-plugin-jsdoc": "^50.6.6",
     "execa": "^1.0.0",

package/plugins/pbjsGlobals.js

@@ -43,6 +43,12 @@ module.exports = function(api, options) {
     return null;
   }
 
+  function translateToJs(path, state) {
+    if (path.node.source?.value?.endsWith('.ts')) {
+      path.node.source.value = path.node.source.value.replace(/\.ts$/, '.js');
+    }
+  }
+
   return {
     visitor: {
       Program(path, state) {
@@ -58,11 +64,8 @@ module.exports = function(api, options) {
           path.node.body.push(...api.parse(`${registerName}('${modName}');`, {filename: state.filename}).program.body);
         }
       },
-      ImportDeclaration(path, state) {
-        if (path.node.source.value.endsWith('.ts')) {
-          path.node.source.value = path.node.source.value.replace(/\.ts$/, '.js');
-        }
-      },
+      ImportDeclaration: translateToJs,
+      ExportDeclaration: translateToJs,
       StringLiteral(path) {
         Object.keys(replace).forEach(name => {
           if (path.node.value.includes(name)) {

package/src/activities/rules.js

@@ -9,7 +9,8 @@ export function ruleRegistry(logger = prefixLog('Activity control:')) {
   const registry = {};
 
   function getRules(activity) {
-    return registry[activity] = registry[activity] || [];
+    registry[activity] = registry[activity] || [];
+    return registry[activity];
   }
 
   function runRule(activity, name, rule, params) {

package/src/adUnits.ts

@@ -145,7 +145,8 @@ export function reset() {
 function ensureAdUnit(adunit, bidderCode?) {
   const adUnit = adUnits[adunit] = adUnits[adunit] || { bidders: {} };
   if (bidderCode) {
-    return adUnit.bidders[bidderCode] = adUnit.bidders[bidderCode] || {}
+    adUnit.bidders[bidderCode] = adUnit.bidders[bidderCode] || {}
+    return adUnit.bidders[bidderCode]
   }
   return adUnit;
 }

package/src/adapterManager.ts

@@ -669,7 +669,6 @@ const adapterManager = {
     // handle client adapter requests
     clientBidderRequests.forEach(bidderRequest => {
       bidderRequest.start = timestamp();
-      // TODO : Do we check for bid in pool from here and skip calling adapter again ?
       const adapter = _bidderRegistry[bidderRequest.bidderCode];
       config.runWithBidder(bidderRequest.bidderCode, () => {
         logMessage(`CALLING BIDDER`);

package/src/adapters/bidderFactory.ts

@@ -204,7 +204,9 @@ export const guardTids: any = memoize(({bidderCode}) => {
     // always allow methods (such as getFloor) private access to TIDs
     Object.entries(target)
       .filter(([_, v]) => typeof v === 'function')
-      .forEach(([prop, fn]: [string, AnyFunction]) => proxy[prop] = fn.bind(target));
+      .forEach(([prop, fn]: [string, AnyFunction]) => {
+        proxy[prop] = fn.bind(target);
+      });
     return proxy;
   }
   const bidRequest = memoize((br) => privateAccessProxy(br, {get}), (arg) => arg.bidId);

package/src/secureCreatives.js

@@ -162,12 +162,18 @@ export function resizeRemoteCreative({instl, adId, adUnitCode, width, height}) {
 
   function getElementIdBasedOnAdServer(adId, adUnitCode) {
     if (isGptPubadsDefined()) {
-      return getDfpElementId(adId);
-    } else if (isApnGetTagDefined()) {
-      return getAstElementId(adUnitCode);
-    } else {
-      return adUnitCode;
+      const dfpId = getDfpElementId(adId);
+      if (dfpId) {
+        return dfpId;
+      }
+    }
+    if (isApnGetTagDefined()) {
+      const apnId = getAstElementId(adUnitCode);
+      if (apnId) {
+        return apnId;
+      }
     }
+    return adUnitCode;
   }
 
   function getDfpElementId(adId) {