prebid-universal-creative 1.15.0 → 1.17.0

package/test/spec/nativeORTBTrackerManager_spec.js

@@ -37,40 +37,24 @@ describe('test firing native trackers', function () {
 
 
   it('should fire impression trackers', function () {
-    let imgUrl = 'foo.bar/event?type=img';
-    let jsUrl = 'foo.bar/event?type=js';
-    
-
     fireNativeImpressionTrackers("abc123", sendMessage);
 
     expect(sendMessage.getCall(0).args[0]).to.deep.equal({
-      message: 'Prebid Native', 
+      message: 'Prebid Native',
       action: 'fireNativeImpressionTrackers',
       adId: 'abc123'
     })
   });
 
   it('should fire asset clicktrackers', function () {
-    let assetTrackers = ['foo.bar/click?id=1', 'foo.bar/click?id=2'];
-    let mainTrackers = ['foo.bar/click?id=3'];
     let adId = "abc123";
-    let nativeOrtb = {
-      assets: [{
-        id: 1,
-        link: { clicktrackers: assetTrackers }
-      }],
-      link: {
-        clicktrackers: mainTrackers
-      }
-    }
-
-    addNativeClickTrackers(adId, nativeOrtb, sendMessage);
+    addNativeClickTrackers(adId, sendMessage);
     expect(sendMessage.getCall(0).args[0]).to.deep.equal({
       message: "Prebid Native",
       action: 'click',
       adId: 'abc123',
       assetId: 1
     });
-    
+
   });
 });

package/test/spec/nativeRenderManager_spec.js

@@ -1,8 +1,7 @@
-import { newNativeRenderManager } from 'src/nativeRenderManager';
-import * as nam  from 'src/nativeAssetManager';
-import { expect } from 'chai';
-import { mocks } from 'test/helpers/mocks';
-import { merge } from 'lodash';
+import {newNativeRenderManager} from 'src/nativeRenderManager';
+import * as nam from 'src/nativeAssetManager';
+import {mocks} from 'test/helpers/mocks';
+import {merge} from 'lodash';
 
 const renderingMocks = {
   getWindowObject: function() {
@@ -15,10 +14,6 @@ const renderingMocks = {
   }
 };
 
-function trimPort(url) {
-  return ((/:\d+/).test(url)) ? url.substring(0, url.lastIndexOf(':')) : url;
-}
-
 describe('nativeRenderManager', function () {
   describe('load renderNativeAd', function () {
     let mockWin;
@@ -55,57 +50,83 @@ describe('nativeRenderManager', function () {
       assetManagerStub.restore();
     });
 
-    it("should verify the postMessage for impression trackers was executed", function () {
-      mockWin.document.getElementsByClassName = () => [
-        {
-          attributes: {
-            pbAdId: {
-              value: "ad123",
-            },
-          },
-          addEventListener: (type, listener, capture) => {},
-        },
-      ];
-      let nativeTracker = new newNativeRenderManager(mockWin);
-      nativeTracker.renderNativeAd(mockWin.document, tagData);
-
-      expect(mockWin.parent.postMessage.callCount).to.equal(1);
-      let postMessageTargetDomain = mockWin.parent.postMessage.args[0][1];
-      let postMessageContents = mockWin.parent.postMessage.args[0][0];
-      let rawPostMessage = JSON.parse(postMessageContents);
-
-      expect(rawPostMessage.message).to.exist.and.to.equal("Prebid Native");
-      expect(rawPostMessage.adId).to.exist.and.to.equal("ad123");
-      expect(rawPostMessage.action).to.not.exist;
-      expect(trimPort(postMessageTargetDomain)).to.equal(tagData.pubUrl);
-    });
+    describe('should fire event', () => {
+      let recvMessages;
+      function mockMessenger() {
+        return recvMessages.push.bind(recvMessages);
+      }
 
-    it('should verify the postMessages for the impression and click trackers were executed', function() {
-      mockWin.document.getElementsByClassName = () => [{
-        attributes: {
-          pbAdId: {
-            value: 'ad123'
+      beforeEach(() => {
+        recvMessages = [];
+      });
+      it('AD_RENDER_SUCCEEDED', () => {
+        const mockAssetMgr = function () {
+          return {
+            loadAssets(_, fn) {
+              fn();
+            }
+          }
+        }
+        const rdr = newNativeRenderManager(mockWin, mockMessenger, mockAssetMgr);
+        rdr.renderNativeAd(mockWin.document, tagData);
+        sinon.assert.match(recvMessages[0], {
+          message: 'Prebid Event',
+          adId: 'ad123',
+          event: 'adRenderSucceeded',
+        })
+      })
+      describe('AD_RENDER_FAILED', () => {
+        it('on exceptions', () => {
+          const rdr = newNativeRenderManager(mockWin, mockMessenger);
+          rdr.renderNativeAd(mockWin.document, Object.defineProperties({...tagData}, {
+            rendererUrl: {
+              get() {
+                throw new Error('err');
+              }
+            }
+          }));
+          sinon.assert.match(recvMessages[0], {
+            message: 'Prebid Event',
+            adId: 'ad123',
+            event: 'adRenderFailed',
+            info: {
+              reason: 'exception',
+              message: 'err'
+            }
+          })
+        });
+        it('on missing adId',() => {
+          const rdr = newNativeRenderManager(mockWin, mockMessenger);
+          rdr.renderNativeAd(mockWin.document, {...tagData, adId: undefined});
+          sinon.assert.match(recvMessages[0], {
+            message: 'Prebid Event',
+            event: 'adRenderFailed',
+            info: {
+              reason: 'missingDocOrAdid',
+            }
+          })
+        });
+        it('on rendering errors', () => {
+          const mockAssetMgr = function () {
+            return {
+              loadAssets(_1, _2, err) {
+                err(new Error('err'))
+              }
+            }
           }
-        },
-        addEventListener: ((type, listener, capture) => {
-          listener({
+          const rdr = newNativeRenderManager(mockWin, mockMessenger, mockAssetMgr);
+          rdr.renderNativeAd(mockWin.document, tagData);
+          sinon.assert.match(recvMessages[0], {
+            message: 'Prebid Event',
+            event: 'adRenderFailed',
+            info: {
+              reason: 'exception',
+              message: 'err'
+            }
           })
         })
-      }];
-
-      let nativeTracker = new newNativeRenderManager(mockWin);
-      nativeTracker.renderNativeAd(mockWin.document, tagData);
-
-      expect(mockWin.parent.postMessage.callCount).to.equal(2);
-
-      let postMessageTargetDomain = mockWin.parent.postMessage.args[0][1];
-      let postMessageContents = mockWin.parent.postMessage.args[1][0];
-      let rawPostMessage = JSON.parse(postMessageContents);
-
-      expect(rawPostMessage.message).to.exist.and.to.equal("Prebid Native");
-      expect(rawPostMessage.adId).to.exist.and.to.equal("ad123");
-      expect(rawPostMessage.action).to.exist.and.to.equal('click');
-      expect(trimPort(postMessageTargetDomain)).to.equal(tagData.pubUrl);
+      })
     });
   });
+
 });

package/test/spec/renderingManager_spec.js

@@ -1,9 +1,11 @@
 import { renderCrossDomain, renderLegacy } from 'src/renderingManager';
 import * as utils from 'src/utils';
 import * as domHelper from 'src/domHelper';
+import * as dynamic from 'src/dynamicRenderer.js';
 import { expect } from 'chai';
 import { mocks } from 'test/helpers/mocks';
 import { merge } from 'lodash';
+import {MIN_RENDERER_VERSION} from "src/dynamicRenderer.js";
 
 function renderingMocks() {
   return {
@@ -72,6 +74,7 @@ describe('renderingManager', function() {
 
   describe('cross domain creative', function() {
     const ORIGIN = 'http://example.com';
+    let sandbox;
     let parseStub;
     let iframeStub;
     let triggerPixelSpy;
@@ -81,10 +84,11 @@ describe('renderingManager', function() {
     let eventSource;
 
     beforeEach(function(){
+      sandbox = sinon.createSandbox();
       mockIframe = createMockIframe();
-      parseStub = sinon.stub(utils, 'parseUrl');
-      iframeStub = sinon.stub(domHelper, 'getEmptyIframe').returns(mockIframe);
-      triggerPixelSpy = sinon.stub(utils, 'triggerPixel');
+      parseStub = sandbox.stub(utils, 'parseUrl');
+      iframeStub = sandbox.stub(domHelper, 'getEmptyIframe').returns(mockIframe);
+      triggerPixelSpy = sandbox.stub(utils, 'triggerPixel');
       parseStub.returns({
         protocol: 'http',
         host: 'example.com'
@@ -102,9 +106,7 @@ describe('renderingManager', function() {
     });
 
     afterEach(function () {
-      parseStub.restore();
-      iframeStub.restore();
-      triggerPixelSpy.restore();
+      sandbox.restore();
     });
 
     function mockPrebidResponse(msg)  {
@@ -114,6 +116,18 @@ describe('renderingManager', function() {
       });
     }
 
+    it('should run renderer if present', () => {
+      sandbox.stub(dynamic, 'runDynamicRenderer');
+      const data = {
+        adId: '123',
+        renderer: 'mock-renderer',
+        rendererVersion: MIN_RENDERER_VERSION,
+        ad: 'markup'
+      };
+      mockPrebidResponse(data);
+      sinon.assert.calledWith(dynamic.runDynamicRenderer, data.adId, sinon.match(data))
+    })
+
     it("should render cross domain creative", function () {
       mockPrebidResponse({
         ad: "ad",

package/webpack.conf.js

@@ -12,7 +12,6 @@ module.exports = {
     ],
   },
   output: {
-    filename: 'creative.js',
   },
   module: {
     rules: [

package/.nvmrc

@@ -1 +0,0 @@
-8.7.0