pr-shepherd 0.16.3 → 0.16.4

package/.claude-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "pr-shepherd",
   "description": "Autonomous PR CI monitor and review-comment resolver for agentic coding tools",
-  "version": "0.16.3",
+  "version": "0.16.4",
   "author": {
     "name": "Jonathan Ong",
     "email": "jonathanrichardong@gmail.com"

package/bin/checks/triage.test-support.mjs

@@ -0,0 +1,61 @@
+// @ts-nocheck
+import { describe, it, expect, vi, beforeEach } from "vitest";
+// ---------------------------------------------------------------------------
+// Stub fetch globally so http.mts uses our mock.
+// ---------------------------------------------------------------------------
+const mockFetch = vi.fn();
+vi.stubGlobal("fetch", mockFetch);
+import { fetchStartupFailureChecks, triageFailingChecks } from "./triage.mjs";
+import { mergeStartupFailureChecks } from "./startup-failures.mjs";
+const REPO = { owner: "owner", name: "repo" };
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+function makeCheck(overrides = {}) {
+    return {
+        name: "tests",
+        status: "COMPLETED",
+        conclusion: "FAILURE",
+        detailsUrl: "https://github.com/owner/repo/actions/runs/99/jobs/1",
+        event: "pull_request",
+        runId: "run-99",
+        category: "failing",
+        ...overrides,
+    };
+}
+function makeJobsResponse(jobs) {
+    return {
+        ok: true,
+        status: 200,
+        headers: new Headers({ "content-type": "application/json" }),
+        json: () => Promise.resolve({ jobs }),
+        text: () => Promise.resolve(JSON.stringify({ jobs })),
+    };
+}
+function makeErrorResponse(status) {
+    return {
+        ok: false,
+        status,
+        headers: new Headers(),
+        text: () => Promise.resolve("error"),
+    };
+}
+function makeWorkflowRunsResponse(runs) {
+    return {
+        ok: true,
+        status: 200,
+        headers: new Headers({ "content-type": "application/json" }),
+        json: () => Promise.resolve({ workflow_runs: runs }),
+        text: () => Promise.resolve(JSON.stringify({ workflow_runs: runs })),
+    };
+}
+// ---------------------------------------------------------------------------
+// Tests
+// ---------------------------------------------------------------------------
+export function registerHooks() {
+    beforeEach(() => {
+        mockFetch.mockReset();
+        process.env["GH_TOKEN"] = "test-token";
+    });
+}
+export { REPO, fetchStartupFailureChecks, makeCheck, makeErrorResponse, makeJobsResponse, makeWorkflowRunsResponse, mergeStartupFailureChecks, mockFetch, triageFailingChecks, };

package/bin/cli/iterate-lean.test-support.mjs

@@ -0,0 +1,5 @@
+// @ts-nocheck
+import { describe, it, expect } from "vitest";
+import { projectIterateLean, projectIterateVerbose } from "./iterate-lean.mjs";
+import { makeIterateResult } from "../cli-parser.iterate-fixtures.mjs";
+export { makeIterateResult, projectIterateLean, projectIterateVerbose };

package/bin/cli-parser.commit-suggestion.test-support.mjs

@@ -0,0 +1,66 @@
+// @ts-nocheck
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+vi.mock("./commands/check.mts", () => ({ runCheck: vi.fn() }));
+vi.mock("./commands/resolve.mts", () => ({
+    runResolveFetch: vi.fn(),
+    runResolveMutate: vi.fn(),
+}));
+vi.mock("./commands/commit-suggestion.mts", () => ({
+    runCommitSuggestion: vi.fn(),
+}));
+vi.mock("./commands/iterate/index.mts", async (importOriginal) => {
+    const actual = await importOriginal();
+    return { ...actual, runIterate: vi.fn() };
+});
+vi.mock("./github/client.mts", () => ({
+    getRepoInfo: vi.fn().mockResolvedValue({ owner: "owner", name: "repo" }),
+}));
+import { main } from "./cli-parser.mjs";
+import { runCommitSuggestion } from "./commands/commit-suggestion.mjs";
+const mockRunCommitSuggestion = vi.mocked(runCommitSuggestion);
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+let stdoutSpy;
+let stderrSpy;
+function getStdout() {
+    return stdoutSpy.mock.calls.map((c) => c[0]).join("");
+}
+// ---------------------------------------------------------------------------
+// Fixtures
+// ---------------------------------------------------------------------------
+const SUGGESTION_RESULT = {
+    pr: 42,
+    repo: "owner/repo",
+    threadId: "t1",
+    path: "a.ts",
+    startLine: 5,
+    endLine: 5,
+    author: "alice",
+    patch: "--- a/a.ts\n+++ b/a.ts\n@@ -5,1 +5,1 @@\n-old\n+new\n",
+    commitMessage: "apply fix",
+    commitBody: "Co-authored-by: alice <alice@users.noreply.github.com>",
+    filesToStage: ["a.ts"],
+    postActionInstructions: [
+        "Apply the patch to `a.ts`: run `git apply` with the diff shown above.",
+        "Stage the file: `git add -- a.ts`",
+        'Commit: `git commit -m "apply fix" -m "Co-authored-by: alice <alice@users.noreply.github.com>"`',
+        "Resolve the thread on GitHub: `npx pr-shepherd resolve 42 --resolve-thread-ids t1`",
+        "Push when ready: `git push` (or `git push --force-with-lease` after rebasing).",
+    ],
+};
+// ---------------------------------------------------------------------------
+// commit-suggestion dispatch
+// ---------------------------------------------------------------------------
+export function registerHooks() {
+    beforeEach(() => {
+        vi.clearAllMocks();
+        process.exitCode = undefined;
+        stdoutSpy = vi.spyOn(process.stdout, "write").mockImplementation(() => true);
+        stderrSpy = vi.spyOn(process.stderr, "write").mockImplementation(() => true);
+    });
+    afterEach(() => {
+        process.exitCode = undefined;
+        stdoutSpy.mockRestore();
+        stderrSpy.mockRestore();
+    });
+}
+export { SUGGESTION_RESULT, getStdout, main, mockRunCommitSuggestion, runCommitSuggestion, stderrSpy, stdoutSpy, };

package/bin/cli-parser.iterate-fix.test-support.mjs

@@ -0,0 +1,48 @@
+// @ts-nocheck
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+vi.mock("./commands/check.mts", () => ({ runCheck: vi.fn() }));
+vi.mock("./commands/resolve.mts", () => ({
+    runResolveFetch: vi.fn(),
+    runResolveMutate: vi.fn(),
+}));
+vi.mock("./commands/commit-suggestion.mts", () => ({
+    runCommitSuggestion: vi.fn(),
+}));
+vi.mock("./commands/iterate/index.mts", async (importOriginal) => {
+    const actual = await importOriginal();
+    return { ...actual, runIterate: vi.fn() };
+});
+vi.mock("./github/client.mts", () => ({
+    getRepoInfo: vi.fn().mockResolvedValue({ owner: "owner", name: "repo" }),
+}));
+import { main } from "./cli-parser.mjs";
+import { runIterate } from "./commands/iterate/index.mjs";
+import { makeIterateResult } from "./cli-parser.iterate-fixtures.mjs";
+const mockRunIterate = vi.mocked(runIterate);
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+let stdoutSpy;
+let stderrSpy;
+function getStdout() {
+    return stdoutSpy.mock.calls.map((c) => c[0]).join("");
+}
+// ---------------------------------------------------------------------------
+// formatIterateResult — fix_code actions and ## Checks section
+// ---------------------------------------------------------------------------
+export function registerHooks() {
+    beforeEach(() => {
+        vi.clearAllMocks();
+        process.exitCode = undefined;
+        delete process.env.AGENT;
+        delete process.env.CODEX_CI;
+        stdoutSpy = vi.spyOn(process.stdout, "write").mockImplementation(() => true);
+        stderrSpy = vi.spyOn(process.stderr, "write").mockImplementation(() => true);
+    });
+    afterEach(() => {
+        process.exitCode = undefined;
+        delete process.env.AGENT;
+        delete process.env.CODEX_CI;
+        stdoutSpy.mockRestore();
+        stderrSpy.mockRestore();
+    });
+}
+export { getStdout, main, makeIterateResult, mockRunIterate, runIterate, stderrSpy, stdoutSpy };

package/bin/cli-parser.iterate.test-support.mjs

@@ -0,0 +1,49 @@
+// @ts-nocheck
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+vi.mock("./commands/check.mts", () => ({ runCheck: vi.fn() }));
+vi.mock("./commands/resolve.mts", () => ({
+    runResolveFetch: vi.fn(),
+    runResolveMutate: vi.fn(),
+}));
+vi.mock("./commands/commit-suggestion.mts", () => ({
+    runCommitSuggestion: vi.fn(),
+}));
+vi.mock("./commands/iterate/index.mts", async (importOriginal) => {
+    const actual = await importOriginal();
+    return { ...actual, runIterate: vi.fn() };
+});
+import { main } from "./cli-parser.mjs";
+import { runIterate } from "./commands/iterate/index.mjs";
+import { formatIterateResult } from "./cli/iterate-formatter.mjs";
+import { makeIterateResult } from "./cli-parser.iterate-fixtures.mjs";
+const mockRunIterate = vi.mocked(runIterate);
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+let stdoutSpy;
+let stderrSpy;
+function getStdout() {
+    return stdoutSpy.mock.calls.map((c) => c[0]).join("");
+}
+function getStderr() {
+    return stderrSpy.mock.calls.map((c) => c[0]).join("");
+}
+// ---------------------------------------------------------------------------
+// iterate dispatch
+// ---------------------------------------------------------------------------
+export function registerHooks() {
+    beforeEach(() => {
+        vi.clearAllMocks();
+        process.exitCode = undefined;
+        delete process.env.AGENT;
+        delete process.env.CODEX_CI;
+        stdoutSpy = vi.spyOn(process.stdout, "write").mockImplementation(() => true);
+        stderrSpy = vi.spyOn(process.stderr, "write").mockImplementation(() => true);
+    });
+    afterEach(() => {
+        process.exitCode = undefined;
+        delete process.env.AGENT;
+        delete process.env.CODEX_CI;
+        stdoutSpy.mockRestore();
+        stderrSpy.mockRestore();
+    });
+}
+export { formatIterateResult, getStderr, getStdout, main, makeIterateResult, mockRunIterate, runIterate, stderrSpy, stdoutSpy, };

package/bin/cli-parser.test-support.mjs

@@ -0,0 +1,43 @@
+// @ts-nocheck
+import { readFileSync } from "node:fs";
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
+vi.mock("./commands/resolve.mts", () => ({
+    runResolveFetch: vi.fn(),
+    runResolveMutate: vi.fn(),
+}));
+vi.mock("./commands/log-file.mts", () => ({
+    runLogFile: vi.fn(),
+}));
+vi.mock("./commands/commit-suggestion.mts", () => ({
+    runCommitSuggestion: vi.fn(),
+}));
+vi.mock("./commands/iterate/index.mts", async (importOriginal) => {
+    const actual = await importOriginal();
+    return { ...actual, runIterate: vi.fn() };
+});
+import { main } from "./cli-parser.mjs";
+import { runLogFile } from "./commands/log-file.mjs";
+import { runResolveFetch, runResolveMutate } from "./commands/resolve.mjs";
+const mockRunResolveFetch = vi.mocked(runResolveFetch);
+const mockRunResolveMutate = vi.mocked(runResolveMutate);
+const mockRunLogFile = vi.mocked(runLogFile);
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+let stdoutSpy;
+let stderrSpy;
+function getStdout() {
+    return stdoutSpy.mock.calls.map((c) => c[0]).join("");
+}
+export function registerHooks() {
+    beforeEach(() => {
+        vi.clearAllMocks();
+        process.exitCode = undefined;
+        stdoutSpy = vi.spyOn(process.stdout, "write").mockImplementation(() => true);
+        stderrSpy = vi.spyOn(process.stderr, "write").mockImplementation(() => true);
+    });
+    afterEach(() => {
+        process.exitCode = undefined;
+        stdoutSpy.mockRestore();
+        stderrSpy.mockRestore();
+    });
+}
+export { getStdout, main, mockRunLogFile, mockRunResolveFetch, mockRunResolveMutate, readFileSync, runLogFile, runResolveFetch, runResolveMutate, stderrSpy, stdoutSpy, };

package/bin/commands/check.test-support.mjs

@@ -0,0 +1,140 @@
+// @ts-nocheck
+import { describe, it, expect, vi, beforeEach } from "vitest";
+vi.mock("../github/batch.mts", () => ({ fetchPrBatch: vi.fn() }));
+vi.mock("../github/client.mts", () => ({
+    getRepoInfo: vi.fn().mockResolvedValue({ owner: "owner", name: "repo" }),
+    getCurrentPrNumber: vi.fn().mockResolvedValue(42),
+    getMergeableState: vi.fn(),
+}));
+vi.mock("../checks/triage.mts", () => ({
+    triageFailingChecks: vi.fn((checks) => Promise.resolve(checks)),
+    fetchStartupFailureChecks: vi.fn().mockResolvedValue([]),
+}));
+vi.mock("../comments/resolve.mts", () => ({
+    autoResolveOutdated: vi.fn().mockResolvedValue({ resolved: [], errors: [] }),
+}));
+vi.mock("../state/seen-comments.mts", async (importOriginal) => {
+    const actual = await importOriginal();
+    return {
+        ...actual,
+        loadSeenMap: vi.fn().mockResolvedValue(new Map()),
+        markSeen: vi.fn().mockResolvedValue(undefined),
+    };
+});
+const { mockLoadConfig } = vi.hoisted(() => ({ mockLoadConfig: vi.fn() }));
+vi.mock("../config/load.mts", () => ({ loadConfig: mockLoadConfig }));
+import { runCheck } from "./check.mjs";
+import { fetchPrBatch } from "../github/batch.mjs";
+import { getCurrentPrNumber, getMergeableState } from "../github/client.mjs";
+import { fetchStartupFailureChecks, triageFailingChecks } from "../checks/triage.mjs";
+import { loadSeenMap, markSeen, hashBody } from "../state/seen-comments.mjs";
+import { autoResolveOutdated } from "../comments/resolve.mjs";
+const mockFetchPrBatch = vi.mocked(fetchPrBatch);
+const mockGetCurrentPrNumber = vi.mocked(getCurrentPrNumber);
+const mockGetMergeableState = vi.mocked(getMergeableState);
+const mockTriageFailingChecks = vi.mocked(triageFailingChecks);
+const mockFetchStartupFailureChecks = vi.mocked(fetchStartupFailureChecks);
+const mockLoadSeenMap = vi.mocked(loadSeenMap);
+const mockMarkSeen = vi.mocked(markSeen);
+const mockAutoResolveOutdated = vi.mocked(autoResolveOutdated);
+const BASE_OPTS = { format: "text" };
+function defaultConfig() {
+    return {
+        iterate: {
+            fixAttemptsPerThread: 3,
+            stallTimeoutMinutes: 30,
+            minimizeApprovals: false,
+            minimizeComments: "all",
+        },
+        watch: { readyDelayMinutes: 10 },
+        resolve: {
+            shaPoll: { intervalMs: 2000, maxAttempts: 10 },
+            fetchReviewSummaries: true,
+        },
+        checks: {
+            ciTriggerEvents: ["pull_request", "pull_request_target"],
+        },
+        mergeStatus: { blockingReviewerLogins: ["copilot"] },
+        actions: {
+            autoResolveOutdated: true,
+            autoMarkReady: true,
+            commitSuggestions: true,
+        },
+    };
+}
+function makeCheck(overrides = {}) {
+    return {
+        name: "tests",
+        status: "COMPLETED",
+        conclusion: "SUCCESS",
+        detailsUrl: "",
+        event: "pull_request",
+        runId: null,
+        category: "passed",
+        ...overrides,
+    };
+}
+function makeBatchData(overrides = {}) {
+    return {
+        nodeId: "PR_kgDOAAA",
+        number: 42,
+        state: "OPEN",
+        isDraft: false,
+        mergeable: "MERGEABLE",
+        mergeStateStatus: "CLEAN",
+        reviewDecision: "APPROVED",
+        headRefOid: "abc123",
+        headRefName: "feature",
+        headRepoWithOwner: "owner/repo",
+        baseRefName: "main",
+        reviewRequests: [],
+        latestReviews: [],
+        reviewThreads: [],
+        comments: [],
+        changesRequestedReviews: [],
+        reviewSummaries: [],
+        approvedReviews: [],
+        checks: [makeCheck()],
+        ...overrides,
+    };
+}
+function makeThread(overrides = {}) {
+    return {
+        id: "t1",
+        isResolved: false,
+        isOutdated: false,
+        isMinimized: false,
+        path: "src/foo.mts",
+        line: 10,
+        startLine: null,
+        author: "reviewer",
+        authorType: "Unknown",
+        body: "fix this",
+        url: "",
+        createdAtUnix: 0,
+        ...overrides,
+    };
+}
+function makeComment(overrides = {}) {
+    return {
+        id: "c1",
+        author: "commenter",
+        authorType: "Unknown",
+        body: "comment body",
+        url: "",
+        createdAtUnix: 0,
+        isMinimized: false,
+        ...overrides,
+    };
+}
+// No PR found
+export function registerHooks() {
+    beforeEach(() => {
+        vi.clearAllMocks();
+        mockLoadConfig.mockReturnValue(defaultConfig());
+        mockFetchPrBatch.mockResolvedValue({ data: makeBatchData() });
+        mockGetMergeableState.mockResolvedValue({ mergeable: "MERGEABLE", mergeStateStatus: "CLEAN" });
+        mockFetchStartupFailureChecks.mockResolvedValue([]);
+    });
+}
+export { BASE_OPTS, autoResolveOutdated, defaultConfig, fetchPrBatch, fetchStartupFailureChecks, getCurrentPrNumber, getMergeableState, hashBody, loadSeenMap, makeBatchData, makeCheck, makeComment, makeThread, markSeen, mockAutoResolveOutdated, mockFetchPrBatch, mockFetchStartupFailureChecks, mockGetCurrentPrNumber, mockGetMergeableState, mockLoadConfig, mockLoadSeenMap, mockMarkSeen, mockTriageFailingChecks, runCheck, triageFailingChecks, };

package/bin/commands/commit-suggestion.apply.test-support.mjs

@@ -0,0 +1,87 @@
+// @ts-nocheck
+import { describe, it, expect, vi, beforeEach } from "vitest";
+// ---------------------------------------------------------------------------
+// Hoisted mocks
+// ---------------------------------------------------------------------------
+const { mockExecFile } = vi.hoisted(() => ({ mockExecFile: vi.fn() }));
+vi.mock("node:child_process", () => ({
+    execFile: (cmd, args, optsOrCb, maybeCb) => {
+        const cb = typeof optsOrCb === "function" ? optsOrCb : maybeCb;
+        mockExecFile(cmd, args)
+            .then((result) => cb(null, result))
+            .catch((err) => cb(err, { stdout: "", stderr: err.stderr ?? "" }));
+    },
+}));
+vi.mock("node:fs/promises", () => ({
+    readFile: vi.fn(),
+}));
+vi.mock("../github/client.mts", () => ({
+    getRepoInfo: vi.fn().mockResolvedValue({ owner: "owner", name: "repo" }),
+    getCurrentPrNumber: vi.fn().mockResolvedValue(42),
+    getCurrentBranch: vi.fn().mockResolvedValue("feature/foo"),
+}));
+vi.mock("../github/batch.mts", () => ({
+    fetchPrBatch: vi.fn(),
+}));
+import { runCommitSuggestion } from "./commit-suggestion.mjs";
+import { getCurrentBranch } from "../github/client.mjs";
+import { fetchPrBatch } from "../github/batch.mjs";
+import { readFile } from "node:fs/promises";
+const mockGetCurrentBranch = vi.mocked(getCurrentBranch);
+const mockFetchBatch = vi.mocked(fetchPrBatch);
+const mockReadFile = vi.mocked(readFile);
+function makeThread(overrides = {}) {
+    return {
+        id: "PRRT_x",
+        isResolved: false,
+        isOutdated: false,
+        isMinimized: false,
+        path: "src/foo.ts",
+        line: 5,
+        startLine: null,
+        author: "alice",
+        authorType: "Unknown",
+        body: "Use a const here.\n\n```suggestion\nconst x = 10;\n```",
+        url: "",
+        createdAtUnix: 0,
+        ...overrides,
+    };
+}
+function makeBatch(threads) {
+    return {
+        nodeId: "PR_kgDOAAA",
+        number: 42,
+        state: "OPEN",
+        isDraft: false,
+        mergeable: "MERGEABLE",
+        mergeStateStatus: "CLEAN",
+        reviewDecision: "APPROVED",
+        headRefOid: "headsha",
+        headRefName: "feature/foo",
+        headRepoWithOwner: "owner/repo",
+        baseRefName: "main",
+        reviewRequests: [],
+        latestReviews: [],
+        reviewThreads: threads,
+        checks: [],
+        comments: [],
+        changesRequestedReviews: [],
+        reviewSummaries: [],
+        approvedReviews: [],
+    };
+}
+const FILE_CONTENT = "line1\n" +
+    "line2\n" +
+    "line3\n" +
+    "line4\n" +
+    "const x = 1;\n" + // line 5 — matches the suggestion anchor
+    "line6\n" +
+    "line7\n";
+const GLOBAL_OPTS = { format: "text" };
+function makeGitSuccess(stdout = "") {
+    return Promise.resolve({ stdout, stderr: "" });
+}
+// ---------------------------------------------------------------------------
+// Output shape and instruction content
+// ---------------------------------------------------------------------------
+export { FILE_CONTENT, GLOBAL_OPTS, fetchPrBatch, getCurrentBranch, makeBatch, makeGitSuccess, makeThread, mockExecFile, mockFetchBatch, mockGetCurrentBranch, mockReadFile, readFile, runCommitSuggestion, };

package/bin/commands/commit-suggestion.test-support.mjs

@@ -0,0 +1,112 @@
+// @ts-nocheck
+import { describe, it, expect, vi, beforeEach } from "vitest";
+// ---------------------------------------------------------------------------
+// Hoisted mocks
+// ---------------------------------------------------------------------------
+const { mockExecFile } = vi.hoisted(() => ({ mockExecFile: vi.fn() }));
+vi.mock("node:child_process", () => ({
+    execFile: (cmd, args, optsOrCb, maybeCb) => {
+        const cb = typeof optsOrCb === "function" ? optsOrCb : maybeCb;
+        mockExecFile(cmd, args)
+            .then((result) => cb(null, result))
+            .catch((err) => cb(err, { stdout: "", stderr: err.stderr ?? "" }));
+    },
+}));
+vi.mock("node:fs/promises", () => ({
+    readFile: vi.fn(),
+}));
+vi.mock("../github/client.mts", () => ({
+    getRepoInfo: vi.fn().mockResolvedValue({ owner: "owner", name: "repo" }),
+    getCurrentPrNumber: vi.fn().mockResolvedValue(42),
+    getCurrentBranch: vi.fn().mockResolvedValue("feature/foo"),
+}));
+vi.mock("../github/batch.mts", () => ({
+    fetchPrBatch: vi.fn(),
+}));
+const { mockLoadConfig } = vi.hoisted(() => ({ mockLoadConfig: vi.fn() }));
+vi.mock("../config/load.mts", () => ({
+    loadConfig: mockLoadConfig,
+}));
+import { runCommitSuggestion } from "./commit-suggestion.mjs";
+import { getCurrentBranch, getCurrentPrNumber } from "../github/client.mjs";
+import { fetchPrBatch } from "../github/batch.mjs";
+import { readFile } from "node:fs/promises";
+const mockGetCurrentBranch = vi.mocked(getCurrentBranch);
+const mockGetCurrentPrNumber = vi.mocked(getCurrentPrNumber);
+const mockFetchBatch = vi.mocked(fetchPrBatch);
+const mockReadFile = vi.mocked(readFile);
+// ---------------------------------------------------------------------------
+// Fixtures
+// ---------------------------------------------------------------------------
+function makeThread(overrides = {}) {
+    return {
+        id: "PRRT_x",
+        isResolved: false,
+        isOutdated: false,
+        isMinimized: false,
+        path: "src/foo.ts",
+        line: 5,
+        startLine: null,
+        author: "alice",
+        authorType: "Unknown",
+        body: "Use a const here.\n\n```suggestion\nconst x = 10;\n```",
+        url: "",
+        createdAtUnix: 0,
+        ...overrides,
+    };
+}
+function makeBatch(threads, headRepoWithOwner = "owner/repo") {
+    return {
+        nodeId: "PR_kgDOAAA",
+        number: 42,
+        state: "OPEN",
+        isDraft: false,
+        mergeable: "MERGEABLE",
+        mergeStateStatus: "CLEAN",
+        reviewDecision: "APPROVED",
+        headRefOid: "headsha",
+        headRefName: "feature/foo",
+        headRepoWithOwner,
+        baseRefName: "main",
+        reviewRequests: [],
+        latestReviews: [],
+        reviewThreads: threads,
+        checks: [],
+        comments: [],
+        changesRequestedReviews: [],
+        reviewSummaries: [],
+        approvedReviews: [],
+    };
+}
+const FILE_CONTENT = "line1\n" +
+    "line2\n" +
+    "line3\n" +
+    "line4\n" +
+    "const x = 1;\n" + // line 5 — matches the suggestion anchor
+    "line6\n" +
+    "line7\n";
+const GLOBAL_OPTS = { format: "text" };
+function makeGitSuccess(stdout = "") {
+    return Promise.resolve({ stdout, stderr: "" });
+}
+function setupHappyPath() {
+    mockFetchBatch.mockResolvedValue({ data: makeBatch([makeThread()]) });
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    mockReadFile.mockResolvedValue(FILE_CONTENT);
+    mockExecFile.mockImplementation((cmd, args) => {
+        if (cmd === "git" && args[0] === "rev-parse")
+            return makeGitSuccess("headsha\n");
+        if (cmd === "git" && args[0] === "status")
+            return makeGitSuccess(""); // file is clean
+        throw new Error(`Unexpected execFile call: ${cmd} ${args.join(" ")}`);
+    });
+}
+// ---------------------------------------------------------------------------
+// Validation
+// ---------------------------------------------------------------------------
+export function registerHooks() {
+    beforeEach(() => {
+        mockLoadConfig.mockReturnValue({ cli: { runner: "auto" } });
+    });
+}
+export { FILE_CONTENT, GLOBAL_OPTS, fetchPrBatch, getCurrentBranch, getCurrentPrNumber, makeBatch, makeGitSuccess, makeThread, mockExecFile, mockFetchBatch, mockGetCurrentBranch, mockGetCurrentPrNumber, mockLoadConfig, mockReadFile, readFile, runCommitSuggestion, setupHappyPath, };

package/bin/commands/iterate/index.mjs

@@ -51,8 +51,25 @@ export async function runIterate(opts) {
             log: `CANCEL: PR #${report.pr} is ${state} — stopping`,
         };
     }
-    const isReady = report.status === "READY";
-    const readyState = await updateReadyDelay(report.pr, isReady, readyDelaySeconds, repoOwner, repoName);
+    const { minimizeIds: reviewSummaryIds, firstLookSummaries, editedSummaries, surfacedApprovals, } = classifyReviewSummaries({
+        firstLook: report.firstLookSummaries,
+        seen: report.reviewSummaries,
+        edited: report.editedSummaries,
+    }, report.approvedReviews, config.iterate.minimizeApprovals, config.iterate.minimizeComments);
+    const hasActionableWork = report.threads.actionable.length > 0 ||
+        report.threads.resolutionOnly.length > 0 ||
+        report.threads.firstLook.length > 0 ||
+        report.comments.actionable.length > 0 ||
+        (report.comments.minimizeIds?.length ?? 0) > 0 ||
+        report.comments.firstLook.length > 0 ||
+        report.changesRequestedReviews.length > 0 ||
+        report.checks.failing.length > 0 ||
+        report.mergeStatus.status === "CONFLICTS" ||
+        reviewSummaryIds.length > 0 ||
+        firstLookSummaries.length > 0 ||
+        editedSummaries.length > 0;
+    const isCleanReadyHandoff = report.status === "READY" && !hasActionableWork;
+    const readyState = await updateReadyDelay(report.pr, isCleanReadyHandoff, readyDelaySeconds, repoOwner, repoName);
     const base = {
         pr: report.pr,
         repo: report.repo,
@@ -88,20 +105,6 @@ export async function runIterate(opts) {
         };
     }
     const headSha = (await getCurrentHeadSha()) ?? "unknown";
-    const { minimizeIds: reviewSummaryIds, firstLookSummaries, editedSummaries, surfacedApprovals, } = classifyReviewSummaries({
-        firstLook: report.firstLookSummaries,
-        seen: report.reviewSummaries,
-        edited: report.editedSummaries,
-    }, report.approvedReviews, config.iterate.minimizeApprovals, config.iterate.minimizeComments);
-    const hasActionableWork = report.threads.actionable.length > 0 ||
-        report.threads.resolutionOnly.length > 0 ||
-        report.comments.actionable.length > 0 ||
-        report.changesRequestedReviews.length > 0 ||
-        report.checks.failing.length > 0 ||
-        report.mergeStatus.status === "CONFLICTS" ||
-        reviewSummaryIds.length > 0 ||
-        firstLookSummaries.length > 0 ||
-        editedSummaries.length > 0;
     if (hasActionableWork) {
         return handleFixCode({
             base,