pr-checkmate 3.3.0 → 4.0.0

package/dist/cjs/cli.js

@@ -1,13 +1,25 @@
 #!/usr/bin/env node
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
+const node_fs_1 = __importDefault(require("node:fs"));
+const node_path_1 = __importDefault(require("node:path"));
+const hook_js_1 = require("./agent/hook.js");
+const setup_js_1 = require("./agent/setup.js");
 const loader_js_1 = require("./config/loader.js");
 const commands_js_1 = require("./core/commands.js");
 const index_js_1 = require("./core/index.js");
 const doctor_js_1 = require("./core/install/doctor.js");
 const grype_db_js_1 = require("./core/install/grype-db.js");
+const sarif_js_1 = require("./core/sarif.js");
 const init_js_1 = require("./init.js");
+const serve_js_1 = require("./mcp/serve.js");
+const tools_js_1 = require("./mcp/tools.js");
+const execa_js_1 = require("./utils/execa.js");
 const index_js_2 = require("./utils/index.js");
+const package_version_js_1 = require("./utils/package-version.js");
 const argv = process.argv.slice(2);
 /**
  * Flags are separated from positional arguments so they compose with every command
@@ -54,6 +66,28 @@ function rejectConflictingScope() {
         index_js_2.logger.error('[cli]: "--all" applies only to "install". Did you mean "--full"?');
         process.exit(1);
     }
+    // `mcp` speaks a protocol on stdout and `hook` is invoked by a harness with a
+    // fixed payload: neither has anything to configure from the command line, and a
+    // flag that quietly did nothing would look like it had.
+    if ((cmd === 'mcp' || cmd === 'hook') && flags.length > 0) {
+        index_js_2.logger.error(`[cli]: "${cmd}" takes no flags, got: ${flags.join(', ')}.`);
+        process.exit(1);
+    }
+    // Only a command that runs checks has findings to export; `all`, `precommit` and a
+    // named check do, every other standalone command does not.
+    const runsChecks = !cmd || cmd === 'all' || cmd === 'precommit' || !commands_js_1.STANDALONE_COMMANDS.includes(cmd);
+    if (flags.includes('--sarif') && !runsChecks) {
+        index_js_2.logger.error('[cli]: "--sarif" applies only to commands that run checks.');
+        process.exit(1);
+    }
+    if (flags.includes('--no-hook') && cmd !== 'agent-setup') {
+        index_js_2.logger.error('[cli]: "--no-hook" applies only to "agent-setup".');
+        process.exit(1);
+    }
+    if (flags.includes('--full') && commands_js_1.AGENT_COMMANDS.includes(cmd ?? '')) {
+        index_js_2.logger.error(`[cli]: "${cmd}" reviews nothing on its own, so "--full" has no meaning.`);
+        process.exit(1);
+    }
     if (flags.includes('--full') && commands_js_1.TOOLING_COMMANDS.includes(cmd ?? '')) {
         index_js_2.logger.error(`[cli]: "${cmd}" manages tooling and reviews nothing, so "--full" has no meaning.`);
         process.exit(1);
@@ -75,6 +109,55 @@ function rejectExtraArgs() {
     index_js_2.logger.error(`[cli]: "${cmd}" takes no other arguments, got: ${args.slice(1).join(', ')}. Run them as a separate command.`);
     process.exit(1);
 }
+/**
+ * Write the report as SARIF when `--sarif` was passed. Written before the exit code
+ * is decided, so a failing run still leaves the file a dashboard needs to show why.
+ */
+function writeSarifIfRequested(report) {
+    if (!flags.includes('--sarif'))
+        return;
+    const file = node_path_1.default.resolve(process.cwd(), 'pr-checkmate.sarif');
+    node_fs_1.default.writeFileSync(file, `${JSON.stringify((0, sarif_js_1.toSarif)(report, (0, package_version_js_1.packageVersion)()), null, 2)}\n`);
+    index_js_2.logger.info(`[sarif]: wrote ${file}`);
+}
+/** Everything the harness wrote to stdin, as text; empty when stdin is closed or a terminal. */
+async function readStdin() {
+    if (process.stdin.isTTY)
+        return '';
+    const chunks = [];
+    for await (const chunk of process.stdin)
+        chunks.push(Buffer.from(chunk));
+    return Buffer.concat(chunks).toString('utf-8');
+}
+/**
+ * The commands that serve AI agents. Returns whether `cmd` was one of them (and has
+ * therefore already exited); kept out of the main dispatcher so that one stays
+ * readable as the list of commands grows.
+ *
+ * `mcp` must stay ahead of anything that could print: from here until stdin closes,
+ * stdout carries protocol messages and nothing else.
+ */
+async function runAgentCommand() {
+    if (cmd === 'mcp') {
+        await (0, serve_js_1.serve)((0, tools_js_1.createServerDefinition)());
+        process.exit(0);
+    }
+    if (cmd === 'hook') {
+        // Discarded rather than shown: the harness reads stdout and stderr of a hook
+        // as instructions to the model, so only the verdict may reach either.
+        (0, execa_js_1.isolateInheritedStdio)('discard');
+        index_js_2.logger.setSink({ out: () => undefined, err: () => undefined });
+        const verdict = await (0, hook_js_1.evaluateHook)(await readStdin(), process.cwd());
+        if (verdict.stderr)
+            process.stderr.write(`${verdict.stderr}\n`);
+        process.exit(verdict.exitCode);
+    }
+    if (cmd === 'agent-setup') {
+        (0, setup_js_1.reportSetup)((0, setup_js_1.setupAgent)(process.cwd(), { hook: !flags.includes('--no-hook') }));
+        process.exit(0);
+    }
+    return false;
+}
 void (async () => {
     try {
         rejectUnknownFlags();
@@ -84,6 +167,8 @@ void (async () => {
             await (0, init_js_1.init)();
             process.exit(0);
         }
+        if (await runAgentCommand())
+            return;
         // Tooling management. These run no checks — they prepare, inspect or clean
         // up what the checks need, so they never touch the diff or the reporter.
         if (cmd === 'install') {
@@ -125,12 +210,14 @@ void (async () => {
                 index_js_2.logger.info('');
                 notice.forEach(line => index_js_2.logger.info(line));
             }
+            writeSarifIfRequested(report);
             process.exit(report.ok ? 0 : 1);
         }
         // Local pre-commit: check the staged changes (index vs HEAD), print to
         // stdout, never modify files. Exits non-zero on failure to block the commit.
         if (cmd === 'precommit') {
             const report = await (0, index_js_1.runChecks)({ staged: true, reporter: 'stdout', write: false });
+            writeSarifIfRequested(report);
             process.exit(report.ok ? 0 : 1);
         }
         // Every remaining argument is a check name, so `pr-checkmate lint spellcheck`
@@ -143,6 +230,7 @@ void (async () => {
         }
         const checkNames = [...new Set(args.map(arg => commands_js_1.COMMAND_TO_CHECK[arg]))];
         const report = await (0, index_js_1.runChecks)({ only: checkNames, reporter: 'stdout', write: true, full });
+        writeSarifIfRequested(report);
         process.exit(report.ok ? 0 : 1);
     }
     catch (err) {

package/dist/cjs/config/constants.d.ts

@@ -95,6 +95,7 @@ export declare const SOURCE_EXTENSIONS: {
     json: string[];
     all: string[];
 };
+export declare const AGENT_SETUP_COMMAND = "npx pr-checkmate agent-setup";
 export declare const DEFAULT_COMMANDS: {
     'npx pr-checkmate init': string;
     'npx pr-checkmate all': string;
@@ -109,6 +110,7 @@ export declare const DEFAULT_COMMANDS: {
     'npx pr-checkmate diff-smell': string;
     'npx pr-checkmate pr-body': string;
     'npx pr-checkmate duplicate': string;
+    "npx pr-checkmate agent-setup": string;
 };
 /**
  * Packages allow-listed for the license check by default.

package/dist/cjs/config/constants.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.KNOWN_CONFIG_KEYS = exports.documentation = exports.FULL_CONFIG_URL = exports.DOCS_URL = exports.DEFAULT_ALLOW_PACKAGES = exports.DEFAULT_COMMANDS = exports.SOURCE_EXTENSIONS = exports.DUPLICATE_CODE_FORMATS = exports.CONFIG_FILE_PATTERNS = exports.DEAD_CODE_IGNORE_DEFAULTS = exports.GENERATED_DOC_FILES = exports.DIFF_SECURITY_IGNORE_DEFAULTS = exports.DUPLICATE_IGNORE_DEFAULTS = exports.TEST_PATH_GLOBS = exports.IGNORE_PATTERNS = exports.IGNORED_DIRS = void 0;
+exports.KNOWN_CONFIG_KEYS = exports.documentation = exports.FULL_CONFIG_URL = exports.DOCS_URL = exports.DEFAULT_ALLOW_PACKAGES = exports.DEFAULT_COMMANDS = exports.AGENT_SETUP_COMMAND = exports.SOURCE_EXTENSIONS = exports.DUPLICATE_CODE_FORMATS = exports.CONFIG_FILE_PATTERNS = exports.DEAD_CODE_IGNORE_DEFAULTS = exports.GENERATED_DOC_FILES = exports.DIFF_SECURITY_IGNORE_DEFAULTS = exports.DUPLICATE_IGNORE_DEFAULTS = exports.TEST_PATH_GLOBS = exports.IGNORE_PATTERNS = exports.IGNORED_DIRS = void 0;
 /**
  * Build output, dependency, tooling, and report directories that are never
  * product code. Every check excludes them by directory-name segment match (see
@@ -228,6 +228,7 @@ exports.SOURCE_EXTENSIONS = {
     json: ['.json'],
     all: ['.ts', '.tsx', '.js', '.jsx', '.json', '.md', '.mdx'],
 };
+exports.AGENT_SETUP_COMMAND = 'npx pr-checkmate agent-setup';
 exports.DEFAULT_COMMANDS = {
     'npx pr-checkmate init': 'Create pr-checkmate.json and the CI workflow (first-run setup)',
     'npx pr-checkmate all': 'Run all checks over the changes — the PR diff in CI, your branch changes locally',
@@ -242,6 +243,7 @@ exports.DEFAULT_COMMANDS = {
     'npx pr-checkmate diff-smell': 'Scan git diff for code smells',
     'npx pr-checkmate pr-body': 'Validate PR description',
     'npx pr-checkmate duplicate': 'Detect duplicate code blocks (jscpd)',
+    [exports.AGENT_SETUP_COMMAND]: 'Connect your AI agent: MCP server, rules for it and edit hooks (writes .mcp.json)',
 };
 /**
  * Packages allow-listed for the license check by default.
@@ -323,6 +325,8 @@ exports.KNOWN_CONFIG_KEYS = new Set([
     'diffSecurity',
     'workflowSecurity',
     'dockerfileSecurity',
+    'agentInstructions',
+    'mcp',
     'sensitiveFileGuard',
     'migrationSafety',
     // dependencies

package/dist/cjs/config/pr-checkmate.template.json

@@ -97,6 +97,16 @@
     "enabled": true,
     "ignore": []
   },
+  "agentInstructions": {
+    "enabled": true,
+    "ignore": []
+  },
+  "//mcp": "What the MCP server offers an AI agent here. 'enabled': false turns it off; 'disabledTools' hides tools by name; 'readOnly' hides the ones that write files. Applies from the agent's next request.",
+  "mcp": {
+    "enabled": true,
+    "disabledTools": [],
+    "readOnly": false
+  },
   "//sensitiveFileGuard": "Flags .env files, private keys, CI config and lockfiles. 'ignorePaths' excuses ONE file by glob (a .pem test fixture); 'ignore' silences a whole CATEGORY and would excuse the next real key too — reach for ignorePaths first.",
   "sensitiveFileGuard": {
     "enabled": true,

package/dist/cjs/core/checks/findings.js

@@ -23,6 +23,7 @@ const node_fs_1 = __importDefault(require("node:fs"));
 const node_path_1 = __importDefault(require("node:path"));
 const execa_js_1 = require("../../utils/execa.js");
 const index_js_1 = require("../../utils/index.js");
+const finding_store_js_1 = require("../finding-store.js");
 const targets_js_1 = require("../targets.js");
 const types_js_1 = require("../types.js");
 /**
@@ -391,6 +392,8 @@ exports.DEFAULT_DATAFLOW_WINDOW = 10;
 const CROSS_LINE_SQL_LABEL = 'Interpolated value reaches a query (SQL injection risk, cross-line)';
 /** `@@ ... @@` — a new hunk, and the boundary taint never crosses. */
 const DIFF_HUNK_HEADER = /^@@ /;
+/** The first line of the new side of a hunk: `@@ -3,2 +10,4 @@` → 10. */
+const HUNK_NEW_START = /^@@ -\d+(?:,\d+)? \+(\d+)/;
 /**
  * Whether this line hands `name` to a query sink.
  *
@@ -464,6 +467,9 @@ function scanDiffPatterns(stdout, patterns, opts = {}) {
     const mode = opts.comments ?? 'language';
     const ignorePaths = opts.ignorePaths ?? [];
     let syntax = 'both';
+    // Where the walk is, for findings that need to say so.
+    let file = '';
+    let newLine = 0;
     // Block comments span lines, so the state belongs to the walk, not to one line.
     let inBlockComment = false;
     // Whole files can be excluded by glob; the flag persists until the next header.
@@ -474,6 +480,7 @@ function scanDiffPatterns(stdout, patterns, opts = {}) {
     for (const line of stdout.split('\n')) {
         const header = DIFF_FILE_HEADER.exec(line);
         if (header) {
+            file = header[1];
             syntax = mode === 'language' ? commentSyntaxFor(header[1]) : 'both';
             inBlockComment = false;
             skippingFile = ignorePaths.length > 0 && (0, index_js_1.matchesAnyGlob)(header[1], ignorePaths);
@@ -482,9 +489,15 @@ function scanDiffPatterns(stdout, patterns, opts = {}) {
         }
         // Checked before the `+` filter below, which a hunk header does not satisfy.
         if (DIFF_HUNK_HEADER.test(line)) {
+            newLine = Number(HUNK_NEW_START.exec(line)?.[1] ?? 0);
             taint.reset();
             continue;
         }
+        // Counted before any skip: an ignored or excluded line still occupies a line
+        // number in the file, and the ones after it must not shift.
+        const lineNo = newLine;
+        if (line.startsWith('+'))
+            newLine++;
         if (skippingFile)
             continue;
         // Only added lines carry block-comment state: a `-` line is code being
@@ -496,18 +509,28 @@ function scanDiffPatterns(stdout, patterns, opts = {}) {
         const prepared = uncomment(line, { mode, syntax, inBlockComment });
         inBlockComment = prepared.inBlockComment;
         const asCode = stripStringLiterals(prepared.text);
-        for (const { pattern, label, severity, view } of patterns) {
-            if (pattern.test(view === 'code' ? asCode : prepared.text)) {
-                const bucket = severity === 'error' ? errors : warnings;
-                (bucket[label] ?? (bucket[label] = [])).push(line.slice(1).trim().substring(0, SAMPLE_MAX_LENGTH));
-            }
-        }
+        const where = { file, line: lineNo };
+        recordMatches(patterns, { text: prepared.text, asCode }, line, where, { errors, warnings });
         if (taint.inspect(prepared.text, asCode)) {
-            (warnings[CROSS_LINE_SQL_LABEL] ?? (warnings[CROSS_LINE_SQL_LABEL] = [])).push(line.slice(1).trim().substring(0, SAMPLE_MAX_LENGTH));
+            record(warnings, CROSS_LINE_SQL_LABEL, line, where);
         }
     }
     return { errors, warnings };
 }
+/** File one added line under `label` and remember where it was, for findings that say so. */
+function record(bucket, label, line, where) {
+    const sample = line.slice(1).trim().substring(0, SAMPLE_MAX_LENGTH);
+    (bucket[label] ?? (bucket[label] = [])).push(sample);
+    (0, finding_store_js_1.noteLocation)(label, sample, where.file, where.line);
+}
+/** File every pattern that matches one prepared line under its own label and severity. */
+function recordMatches(patterns, view, line, where, into) {
+    for (const { pattern, label, severity, view: wants } of patterns) {
+        if (pattern.test(wants === 'code' ? view.asCode : view.text)) {
+            record(severity === 'error' ? into.errors : into.warnings, label, line, where);
+        }
+    }
+}
 /**
  * Reduce one added line to what should be matched against: block comments
  * blanked (carrying the open state on), then the trailing line comment removed.
@@ -598,6 +621,7 @@ function bucketTotal(bucket) {
  */
 function reportCountedFindings(findings, ctx, opts) {
     const sev = severityEmitter(opts.severity, opts.fallback ?? 'warn');
+    (0, finding_store_js_1.fileFindings)(findings, sev.icon === '❌' ? 'error' : 'warn');
     logFindings(findings, {
         prefix: opts.prefix,
         sampleLimit: opts.sampleLimit ?? ctx.config.log?.sampleLimit ?? 3,
@@ -702,6 +726,8 @@ function reportSeverityBuckets(errorsIn, warningsIn, opts) {
     const ignore = opts.ignore ?? [];
     const filed = applyOverrides(dropIgnored(errorsIn, ignore), dropIgnored(warningsIn, ignore), opts.severityOverrides ?? {});
     const { errors, warnings } = filed;
+    (0, finding_store_js_1.fileFindings)(errors, 'error');
+    (0, finding_store_js_1.fileFindings)(warnings, 'warn');
     const totalErrors = bucketTotal(errors);
     const totalWarnings = bucketTotal(warnings);
     if (totalErrors === 0 && totalWarnings === 0)

package/dist/cjs/core/checks/git/large-files.d.ts

@@ -1,2 +1,3 @@
 import { Check } from '../../types.js';
+export declare const DEFAULT_MAX_KB = 500;
 export declare const largeFilesCheck: Check;

package/dist/cjs/core/checks/git/large-files.js

@@ -3,7 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.largeFilesCheck = void 0;
+exports.largeFilesCheck = exports.DEFAULT_MAX_KB = void 0;
 const node_fs_1 = __importDefault(require("node:fs"));
 const node_path_1 = __importDefault(require("node:path"));
 const execa_js_1 = require("../../../utils/execa.js");
@@ -11,7 +11,7 @@ const index_js_1 = require("../../../utils/index.js");
 const targets_js_1 = require("../../targets.js");
 const types_js_1 = require("../../types.js");
 const findings_js_1 = require("../findings.js");
-const DEFAULT_MAX_KB = 500;
+exports.DEFAULT_MAX_KB = 500;
 /**
  * Lockfiles are legitimately large and always generated, never accidental — so
  * they're exempt from the size/binary guard by default (a 600 KB
@@ -70,7 +70,7 @@ exports.largeFilesCheck = {
             return (0, types_js_1.skip)('git unavailable');
         if (files.length === 0)
             return (0, types_js_1.pass)();
-        const maxKb = ctx.config.largeFiles?.maxSizeKb ?? DEFAULT_MAX_KB;
+        const maxKb = ctx.config.largeFiles?.maxSizeKb ?? exports.DEFAULT_MAX_KB;
         const maxBytes = maxKb * 1024;
         const allow = [...LOCKFILE_ALLOW, ...(ctx.config.largeFiles?.allow ?? [])];
         if (!ctx.baseSha && ctx.config.run?.fullScanBehaviour === 'skip')

package/dist/cjs/core/checks/pr/pr-size-check.d.ts

@@ -1,2 +1,4 @@
 import { Check } from '../../types.js';
+export declare const DEFAULT_MAX_FILES = 50;
+export declare const DEFAULT_MAX_LINES = 1000;
 export declare const prSizeCheck: Check;

package/dist/cjs/core/checks/pr/pr-size-check.js

@@ -1,11 +1,11 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.prSizeCheck = void 0;
+exports.prSizeCheck = exports.DEFAULT_MAX_LINES = exports.DEFAULT_MAX_FILES = void 0;
 const execa_js_1 = require("../../../utils/execa.js");
 const index_js_1 = require("../../../utils/index.js");
 const types_js_1 = require("../../types.js");
-const DEFAULT_MAX_FILES = 50;
-const DEFAULT_MAX_LINES = 1000;
+exports.DEFAULT_MAX_FILES = 50;
+exports.DEFAULT_MAX_LINES = 1000;
 exports.prSizeCheck = {
     name: 'PR Size',
     phase: 'informational',
@@ -14,8 +14,8 @@ exports.prSizeCheck = {
         return ctx.config.prSize?.enabled !== false;
     },
     async run(ctx) {
-        const maxFiles = ctx.config.prSize?.maxFiles ?? DEFAULT_MAX_FILES;
-        const maxLines = ctx.config.prSize?.maxLines ?? DEFAULT_MAX_LINES;
+        const maxFiles = ctx.config.prSize?.maxFiles ?? exports.DEFAULT_MAX_FILES;
+        const maxLines = ctx.config.prSize?.maxLines ?? exports.DEFAULT_MAX_LINES;
         try {
             const { stdout } = await (0, execa_js_1.execa)('git', ['diff', '--shortstat', ctx.baseSha, ctx.headSha ?? 'HEAD'], {
                 cwd: ctx.cwd,

package/dist/cjs/core/checks/security/agent-instructions.d.ts

@@ -0,0 +1,4 @@
+import { Check } from '../../types.js';
+import { DiffPattern } from '../findings.js';
+export declare const AGENT_PATTERNS: DiffPattern[];
+export declare const agentInstructionsCheck: Check;

package/dist/cjs/core/checks/security/agent-instructions.js

@@ -0,0 +1,149 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.agentInstructionsCheck = exports.AGENT_PATTERNS = void 0;
+// cspell:ignore windsurfrules
+const index_js_1 = require("../../../utils/index.js");
+const targets_js_1 = require("../../targets.js");
+const types_js_1 = require("../../types.js");
+const findings_js_1 = require("../findings.js");
+/**
+ * Files that tell an AI agent what to do, or what it may do.
+ *
+ * They are code in every sense that matters: an agent reads them and acts, with
+ * the developer's shell and the developer's credentials. A pull request that edits
+ * one changes what every contributor's agent will do on its next run, and the diff
+ * is prose — which review tends to skim. That makes this the cheapest place in a
+ * repository to plant an instruction, and the least reviewed.
+ */
+const INSTRUCTION_GLOBS = [
+    'AGENTS.md',
+    '**/AGENTS.md',
+    'CLAUDE.md',
+    '**/CLAUDE.md',
+    'GEMINI.md',
+    '.cursorrules',
+    '.windsurfrules',
+    '.cursor/rules/**',
+    '.github/copilot-instructions.md',
+    '.claude/commands/**',
+    '.claude/agents/**',
+    '.claude/skills/**',
+    '.claude/settings.json',
+    '.mcp.json',
+];
+/** Dot-directories the file walk drops by default and this check lives in. */
+const KEEP_DIRS = ['.claude', '.cursor', '.github'];
+/**
+ * Characters a person cannot see and a model reads anyway: zero-width characters,
+ * bidirectional overrides and the Unicode "tag" block. Each has been used to hide
+ * an instruction inside text that looks harmless on screen. A byte-order mark is
+ * left out on purpose — editors put one at the top of ordinary files.
+ */
+const INVISIBLE = '[\\u200B-\\u200F\\u202A-\\u202E\\u2060-\\u2064\\u2066-\\u2069]|[\\u{E0000}-\\u{E007F}]';
+exports.AGENT_PATTERNS = [
+    {
+        pattern: new RegExp(`^\\+(?!\\+).*(?:${INVISIBLE})`, 'u'),
+        label: 'invisible Unicode characters (can hide instructions from a human reviewer)',
+        severity: 'error',
+    },
+    {
+        pattern: 
+        // "Do not add X without telling the user" asks the agent to check in, so a
+        // `without` that follows a negation in the same sentence is not a match.
+        /^\+(?!\+)(?![^\n]*\b(?:do not|don't|never)\b[^.\n]*\bwithout\b).*\b(?:do not|don't|never|without)\b[^.\n]{0,30}\b(?:tell|telling|inform|informing|mention|show|reveal|notify)\b[^.\n]{0,20}\b(?:the )?(?:user|developer|human)\b/i,
+        label: 'tells the agent to hide something from the user',
+        severity: 'error',
+    },
+    {
+        pattern: /^\+(?!\+).*\b(?:send|post|upload|curl|wget|fetch|exfiltrate|email)\b[^\n]{0,80}(?:\.env\b|credentials?|secrets?|api[_ -]?keys?|\btokens?\b|\bssh\b|id_rsa)[^\n]{0,80}https?:\/\//i,
+        label: 'sends credentials or secrets to a URL',
+        severity: 'error',
+    },
+    {
+        pattern: /^\+(?!\+).*\b(?:ignore|disregard|forget|override)\b[^.\n]{0,40}\b(?:previous|prior|above|earlier|all|any)\b[^.\n]{0,30}\b(?:instructions?|rules|prompts?|guidelines)\b/i,
+        label: 'prompt-injection phrasing ("ignore previous instructions")',
+        severity: 'warn',
+    },
+    {
+        pattern: /^\+(?!\+).*\b(?:curl|wget)\b[^|\n]*\|\s*(?:sudo\s+)?(?:sh|bash|zsh)\b/i,
+        label: 'pipes a download straight into a shell (an agent will run what it is told to run)',
+        severity: 'warn',
+    },
+    {
+        pattern: /^\+(?!\+).*(?:--no-verify|--dangerously-skip-permissions|--no-gpg-sign)\b/,
+        label: 'instructs the agent to skip a safety check',
+        severity: 'warn',
+    },
+    {
+        pattern: /^\+(?!\+)\s*"defaultMode"\s*:\s*"bypassPermissions"/,
+        label: 'bypassPermissions as the project default (every contributor’s agent runs without asking)',
+        severity: 'error',
+    },
+    {
+        pattern: /^\+(?!\+)\s*"enableAllProjectMcpServers"\s*:\s*true/,
+        label: 'auto-approves every MCP server this repository declares',
+        severity: 'warn',
+    },
+    {
+        pattern: /^\+(?!\+)\s*"(?:Bash|Write|Edit)(?:\((?:\*|:\*)\))?"\s*,?\s*$/,
+        label: 'permission granted for every shell command or file write',
+        severity: 'warn',
+    },
+    {
+        pattern: /^\+(?!\+).*"url"\s*:\s*"http:\/\/(?!localhost|127\.0\.0\.1|\[::1\])/,
+        label: 'MCP server reached over plain HTTP',
+        severity: 'warn',
+    },
+    {
+        // `"args": ["-y", "pkg"]` with no @version: whatever is published next runs on
+        // the machine of everyone who opens the repository.
+        pattern: /^\+(?!\+).*"args"\s*:\s*\[\s*"-y"\s*,\s*"(?:@[^/"@]+\/)?[^"@]+"/,
+        label: 'MCP server fetched with npx and no pinned version (the next publish runs on every contributor’s machine)',
+        severity: 'warn',
+    },
+];
+exports.agentInstructionsCheck = {
+    name: 'Agent Instructions',
+    phase: 'informational',
+    // No `requiresDiff`: a hidden instruction is as live in a file that arrived last
+    // year as in one added today, so a whole-repository run reads them too.
+    applies(ctx) {
+        return ctx.config.agentInstructions?.enabled !== false;
+    },
+    async run(ctx) {
+        try {
+            const cfg = ctx.config.agentInstructions ?? {};
+            const found = (0, findings_js_1.emptyBuckets)();
+            const scanInto = (stdout) => {
+                // `comments: 'off'`: these are Markdown and JSON, where a leading `#` is a
+                // heading and `//` is part of a URL — stripping them as comments would
+                // blank exactly the lines worth reading.
+                (0, findings_js_1.mergeSeverityBuckets)(found, (0, findings_js_1.scanDiffPatterns)(stdout, exports.AGENT_PATTERNS, {
+                    comments: 'off',
+                    ignorePaths: cfg.ignorePaths,
+                }));
+            };
+            if (ctx.baseSha) {
+                scanInto(await (0, findings_js_1.diffAddedLines)(ctx, INSTRUCTION_GLOBS));
+            }
+            else if (ctx.config.run?.fullScanBehaviour !== 'skip') {
+                const files = await (0, targets_js_1.listTrackedFiles)(ctx, INSTRUCTION_GLOBS, ['.'], {
+                    keepDirs: KEEP_DIRS,
+                });
+                if (files === null)
+                    return (0, types_js_1.skip)('git unavailable');
+                await (0, findings_js_1.scanTrackedFiles)(ctx, files, scanInto);
+            }
+            return (0, findings_js_1.reportSeverityBuckets)(found.errors, found.warnings, {
+                prefix: 'Agent Instructions',
+                errorSummary: n => `${n} issue(s)`,
+                warningSummary: n => `${n} warning(s)`,
+                ...(0, findings_js_1.clientFindingOptions)(ctx, cfg),
+            });
+        }
+        catch (err) {
+            index_js_1.logger.warn(`[Agent Instructions]: ⚠️ Could not analyze agent files\n${err}`);
+            return (0, types_js_1.skip)('agent files unavailable');
+        }
+    },
+};

package/dist/cjs/core/checks/security/diff-security.d.ts

@@ -1,2 +1,9 @@
 import { Check } from '../../types.js';
+import { DiffPattern } from '../findings.js';
+/**
+ * npm supply-chain entry points, matched in `package.json`. Both are how a
+ * compromised package reaches a developer machine or CI runner, so they are
+ * worth a human look whenever one is added — neither is wrong by itself.
+ */
+export declare const PACKAGE_JSON_PATTERNS: DiffPattern[];
 export declare const diffSecurityCheck: Check;

package/dist/cjs/core/checks/security/diff-security.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.diffSecurityCheck = void 0;
+exports.diffSecurityCheck = exports.PACKAGE_JSON_PATTERNS = void 0;
 const index_js_1 = require("../../../config/index.js");
 const index_js_2 = require("../../../utils/index.js");
 const types_js_1 = require("../../types.js");
@@ -235,6 +235,25 @@ const KOTLIN_SECURITY_PATTERNS = [
     },
 ];
 const JS_GLOBS = ['*.ts', '*.tsx', '*.js', '*.jsx', '*.mjs', '*.cjs'];
+const PACKAGE_JSON_GLOBS = ['package.json', '*/package.json'];
+/**
+ * npm supply-chain entry points, matched in `package.json`. Both are how a
+ * compromised package reaches a developer machine or CI runner, so they are
+ * worth a human look whenever one is added — neither is wrong by itself.
+ */
+exports.PACKAGE_JSON_PATTERNS = [
+    {
+        pattern: /^\+(?!\+)\s*"(?:preinstall|install|postinstall)"\s*:/,
+        label: 'npm install lifecycle script (runs on every consumer install)',
+        severity: 'warn',
+    },
+    {
+        // `repository.url` is the one key that legitimately holds a `git+https:` value.
+        pattern: /^\+(?!\+)\s*"(?!url")[^"]+"\s*:\s*"(?:git\+[a-z]+:|git:\/\/|git@|github:|https?:\/\/[^"]+\.(?:tgz|tar\.gz)")/,
+        label: 'dependency from a git or tarball URL (bypasses registry integrity and audit)',
+        severity: 'warn',
+    },
+];
 /**
  * Compile the client's `extraPatterns` into the same shape as the built-ins, so
  * a project rule gets identical treatment: comment stripping, the code/raw view,
@@ -323,6 +342,7 @@ exports.diffSecurityCheck = {
             // Client `extraPatterns` run against every scanned language, since a
             // project rule is not tied to the built-in language split.
             const sets = [[JS_GLOBS, [...SECURITY_PATTERNS, ...extra]]];
+            sets.push([PACKAGE_JSON_GLOBS, exports.PACKAGE_JSON_PATTERNS]);
             if (ctx.languages.includes('python')) {
                 sets.push([['*.py'], [...PYTHON_SECURITY_PATTERNS, ...extra]]);
             }

package/dist/cjs/core/checks/security/security.d.ts

@@ -30,19 +30,6 @@ import { Check } from '../../types.js';
  *   the caller keeps its old wording rather than claiming a number it does not have.
  */
 export declare function countFindings(reportPath: string): number | null;
-/**
- * How the outcome names what was found.
- *
- * Its own function so both halves are reachable without running the scanner. The
- * corpus for this check deliberately does not: the wrapper downloads a gitleaks
- * binary on first use, and a unit suite that reaches the network is the thing the
- * `installer` seam in `ensure.ts` exists to avoid. What broke here was the wording
- * — a row that read the same for one secret and for thirty-nine — and the wording
- * is testable on its own.
- *
- * `null` keeps the old sentence rather than inventing a number: a report we could
- * not read is not a reason to claim a count.
- */
 export declare function secretsSummary(found: number | null): string;
 /**
  * Whether the wrapper died instead of reporting, judged from its stderr.

package/dist/cjs/core/checks/security/security.js

@@ -13,6 +13,7 @@ const node_path_1 = __importDefault(require("node:path"));
 const index_js_1 = require("../../../config/index.js");
 const execa_js_1 = require("../../../utils/execa.js");
 const index_js_2 = require("../../../utils/index.js");
+const finding_store_js_1 = require("../../finding-store.js");
 const types_js_1 = require("../../types.js");
 /**
  * A HOME the scanner can actually write to.
@@ -66,6 +67,31 @@ function countFindings(reportPath) {
  * `null` keeps the old sentence rather than inventing a number: a report we could
  * not read is not a reason to claim a count.
  */
+/**
+ * Tell the report where each leak is. The secret itself is never copied: the
+ * finding carries a file, a line and the rule that matched, which is all anyone
+ * needs to go and remove it — and all that is safe to hand to an agent's context.
+ */
+function recordLeaks(reportPath, cwd) {
+    try {
+        const report = JSON.parse(node_fs_1.default.readFileSync(reportPath, 'utf-8'));
+        if (!Array.isArray(report))
+            return;
+        for (const leak of report) {
+            if (typeof leak?.File !== 'string')
+                continue;
+            (0, finding_store_js_1.addFinding)({
+                file: node_path_1.default.isAbsolute(leak.File) ? node_path_1.default.relative(cwd, leak.File) : leak.File,
+                line: typeof leak.StartLine === 'number' ? leak.StartLine : undefined,
+                rule: typeof leak.RuleID === 'string' ? leak.RuleID : 'secret',
+                severity: 'error',
+            });
+        }
+    }
+    catch {
+        // An unreadable report already shows up as an uncounted summary; no locations to add.
+    }
+}
 function secretsSummary(found) {
     return found === null ? 'potential secrets detected' : `${found} potential secret(s)`;
 }
@@ -186,6 +212,7 @@ exports.securityCheck = {
         if (stderr.trim())
             index_js_2.logger.warn(stderr.trimEnd());
         const found = countFindings(reportPath);
+        recordLeaks(reportPath, ctx.cwd);
         node_fs_1.default.rmSync(reportDir, { recursive: true, force: true });
         if (result.exitCode === 0)
             return (0, types_js_1.pass)();