pr-checkmate 2.1.2 → 3.0.1

package/dist/core/checks/quality/package-size.d.ts

@@ -0,0 +1,15 @@
+import { Check } from '../../types';
+/**
+ * Reports how much the published package grew since the last release.
+ *
+ * The question this answers is "is it growing without anyone noticing", not "has
+ * it crossed a line" — so the comparison is against the previously published
+ * version rather than a threshold somebody had to invent. A number a client never
+ * configured is a number they will not trust, and a check that fires on every
+ * release teaches people to skim the whole report.
+ *
+ * Advisory by design. Growth is usually earned — a language profile was added, a
+ * WASM binary landed — and a red build for it would be wrong. `severity:
+ * { "Package Size": "error" }` makes it a gate for a repository that wants one.
+ */
+export declare const packageSizeCheck: Check;

package/dist/core/checks/quality/package-size.js

@@ -0,0 +1,130 @@
+"use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.packageSizeCheck = void 0;
+const node_fs_1 = __importDefault(require("node:fs"));
+const node_path_1 = __importDefault(require("node:path"));
+const utils_1 = require("../../../utils");
+const execa_1 = require("../../../utils/execa");
+const types_1 = require("../../types");
+const findings_1 = require("../findings");
+/** Growth that is worth a row in the report, unless the client says otherwise. */
+const DEFAULT_MAX_GROWTH = 20;
+/** How many of the files behind the growth are named. */
+const NAMED_FILES = 5;
+/**
+ * Ask npm what a tarball would contain, without producing one.
+ *
+ * `--dry-run` writes nothing to the working tree — which matters, because a check
+ * whose side effect is a `.tgz` beside the source shows up in the client's next
+ * commit. Given a package spec instead of nothing, npm answers for the PUBLISHED
+ * version, with the same shape and the same per-file detail; that is what makes a
+ * real comparison possible rather than a bare number.
+ *
+ * `--ignore-scripts` is not negotiable. `npm pack` runs `prepare` and `prepack`,
+ * and in a client's repository those are arbitrary commands — frequently a full
+ * build. A quality check that executes them has stopped being a check and started
+ * being a build step with side effects nobody asked for. We are a supply-chain
+ * tool; the same rule already governs the install path and the Docker build.
+ *
+ * @param cwd Repository to run in.
+ * @param spec `undefined` for the working tree, or `name@tag` for a release.
+ */
+async function packManifest(cwd, spec) {
+    const args = ['pack', ...(spec ? [spec] : []), '--dry-run', '--json', '--ignore-scripts'];
+    const result = await (0, execa_1.execa)('npm', args, { cwd, reject: false });
+    if (result.exitCode !== 0)
+        return null;
+    try {
+        const parsed = JSON.parse(result.stdout);
+        return Array.isArray(parsed) && parsed.length > 0 ? parsed[0] : null;
+    }
+    catch {
+        return null;
+    }
+}
+/** `1.15 MB`, at the precision a human compares two of these at. */
+function mb(bytes) {
+    return `${(bytes / 1024 / 1024).toFixed(2)} MB`;
+}
+/**
+ * Which files account for the growth, biggest first.
+ *
+ * A percentage alone is a finding nobody can act on — the same defect as a
+ * duplicate-code report with no file names (ticket 078). The published manifest
+ * carries per-file sizes, so the answer is a plain diff of the two lists: files
+ * that appeared, and files that grew.
+ */
+function growthByFile(before, after) {
+    const old = new Map(before.map(f => [f.path, f.size]));
+    return after
+        .map(f => ({ path: f.path, delta: f.size - (old.get(f.path) ?? 0), isNew: !old.has(f.path) }))
+        .filter(f => f.delta > 0)
+        .sort((a, b) => b.delta - a.delta)
+        .slice(0, NAMED_FILES)
+        .map(f => `${f.path} +${mb(f.delta)}${f.isNew ? ' (new)' : ''}`);
+}
+/** Whether this repository publishes anything to compare. */
+function publishedName(cwd) {
+    try {
+        const pkg = JSON.parse(node_fs_1.default.readFileSync(node_path_1.default.join(cwd, 'package.json'), 'utf-8'));
+        return pkg.private || !pkg.name ? null : pkg.name;
+    }
+    catch {
+        return null;
+    }
+}
+/**
+ * Reports how much the published package grew since the last release.
+ *
+ * The question this answers is "is it growing without anyone noticing", not "has
+ * it crossed a line" — so the comparison is against the previously published
+ * version rather than a threshold somebody had to invent. A number a client never
+ * configured is a number they will not trust, and a check that fires on every
+ * release teaches people to skim the whole report.
+ *
+ * Advisory by design. Growth is usually earned — a language profile was added, a
+ * WASM binary landed — and a red build for it would be wrong. `severity:
+ * { "Package Size": "error" }` makes it a gate for a repository that wants one.
+ */
+exports.packageSizeCheck = {
+    name: 'Package Size',
+    phase: 'informational',
+    weight: 'heavy',
+    applies(ctx) {
+        if (ctx.config.packageSize?.enabled === false)
+            return false;
+        // A private package is never published, so there is nothing to compare with
+        // and no consumer to pay for the growth.
+        return publishedName(ctx.cwd) !== null;
+    },
+    async run(ctx) {
+        const name = publishedName(ctx.cwd);
+        if (!name)
+            return (0, types_1.skip)('no publishable package.json');
+        const tag = ctx.config.packageSize?.compareWith ?? 'latest';
+        const maxGrowth = ctx.config.packageSize?.maxGrowthPercent ?? DEFAULT_MAX_GROWTH;
+        const current = await packManifest(ctx.cwd);
+        if (!current)
+            return (0, types_1.skip)('npm could not describe this package');
+        // Registry unreachable, or nothing published yet. Both are "we could not
+        // look", never "nothing changed" — a pass here would be a green row over a
+        // comparison that never happened (ticket 072).
+        const published = await packManifest(ctx.cwd, `${name}@${tag}`);
+        if (!published) {
+            return (0, types_1.skip)(`no published ${name}@${tag} to compare with (or registry unreachable)`);
+        }
+        const delta = current.unpackedSize - published.unpackedSize;
+        const growth = published.unpackedSize > 0 ? (delta / published.unpackedSize) * 100 : 0;
+        const summary = `${mb(published.unpackedSize)} → ${mb(current.unpackedSize)} ` +
+            `(${growth >= 0 ? '+' : ''}${growth.toFixed(1)}%) vs ${published.version}`;
+        if (growth <= maxGrowth) {
+            utils_1.logger.info(`[Package Size]: ✅ ${summary}`);
+            return (0, types_1.pass)(summary);
+        }
+        (0, findings_1.logSample)('Package Size', `${summary}:`, growthByFile(published.files, current.files));
+        return (0, types_1.warn)(summary);
+    },
+};

package/dist/core/checks/quality/spellcheck.js

@@ -188,19 +188,48 @@ function dropMissingLanguages(language, missing) {
     // to its own default, which is not necessarily what was configured here.
     return kept.length > 0 ? kept.join(',') : 'en';
 }
+/**
+ * Resolve a package id from the repository under review first, then from our own
+ * tree.
+ *
+ * The default `require.resolve` searches from THIS module, which is only the
+ * client's tree by accident. Installed as a dependency we sit in their
+ * `node_modules` and npm hoists `@cspell/dict-*` above us, so walking up finds
+ * it. Run through `npx` we sit in the npx cache and their `node_modules` is not
+ * on the path at all — so `npm i -D @cspell/dict-ru_ru`, which this file's own
+ * docstring promises is all it takes, did nothing and said nothing (ticket 081).
+ *
+ * Same policy as tool resolution for binaries: the client's copy first, ours as
+ * the fallback.
+ */
+function resolveFrom(cwd) {
+    return id => {
+        try {
+            return require.resolve(id, { paths: [cwd] });
+        }
+        catch {
+            return require.resolve(id);
+        }
+    };
+}
 function createTempCspellConfig(cwd) {
     const packageConfigPath = (0, config_1.getPackageConfigPath)('cspell.json');
     const packageConfigDir = node_path_1.default.dirname(packageConfigPath);
     const defaultConfig = JSON.parse(node_fs_1.default.readFileSync(packageConfigPath, 'utf-8'));
     const userConfig = loadUserCspellConfig(cwd);
     const merged = mergeCspellConfig(defaultConfig, userConfig);
-    const { resolved, missing } = resolveImports(merged.import ?? [], packageConfigDir);
-    const available = availableDictionaries();
+    const resolve = resolveFrom(cwd);
+    const { resolved, missing } = resolveImports(merged.import ?? [], packageConfigDir, resolve);
+    const available = availableDictionaries(resolve);
     for (const { pkg } of missing) {
         utils_1.logger.info(`[Spellcheck]: dictionary ${pkg} is not installed and was skipped. Add it with \`npm i -D ${pkg}\`.`);
     }
     if (available.absent.length > 0) {
-        utils_1.logger.debug(`[Spellcheck]: optional dictionaries not installed: ${available.absent.join(', ')}. ` +
+        // `info`, not `debug`. A client who installed a dictionary and saw no change
+        // had nothing to read: the one line that would have explained it was behind a
+        // flag. Which dictionaries are in play decides which findings appear, so it
+        // belongs in the ordinary log (ticket 081).
+        utils_1.logger.info(`[Spellcheck]: optional dictionaries not installed: ${available.absent.join(', ')}. ` +
             `Install any of them to spellcheck that language (\`npm i -D ${available.absent[0]}\`).`);
     }
     // A language the client asked for whose dictionary is absent is dropped rather
@@ -230,7 +259,7 @@ exports.spellcheckCheck = {
         return ctx.config.cspell?.enabled !== false && ctx.config.spellcheck?.enabled !== false;
     },
     async run(ctx) {
-        const targets = await (0, targets_1.resolveScopedTargetFiles)(ctx, ['*.ts', '*.tsx', '*.js', '*.jsx', '*.md', '*.mdx', '*.json'], (0, config_1.getSourcePaths)());
+        const targets = await (0, targets_1.resolveScopedTargetFiles)(ctx, ['*.ts', '*.tsx', '*.js', '*.jsx', '*.md', '*.mdx', '*.json'], (0, config_1.getSourcePaths)(ctx.cwd));
         if (targets === null)
             return (0, types_1.skip)('git unavailable');
         // Committed build output and test reports are dropped here, in JS, against
@@ -246,7 +275,7 @@ exports.spellcheckCheck = {
         const files = targets.filter(f => !(0, utils_1.matchesAnyGlob)(f, config_1.IGNORE_PATTERNS));
         if (files.length === 0)
             return (0, types_1.pass)('no files to spellcheck');
-        const hasLocal = (0, config_1.hasLocalConfig)(['cspell.json', '.cspell.json', 'cspell.config.json']);
+        const hasLocal = (0, config_1.hasLocalConfig)(['cspell.json', '.cspell.json', 'cspell.config.json'], ctx.cwd);
         let tempConfigPath = null;
         const cspellBin = (0, utils_1.resolvePackageBin)('cspell', 'bin.mjs');
         // `--no-must-find-files`: cspell exits 1 when it checked nothing, which the

package/dist/core/checks/quality/symlinks.js

@@ -7,7 +7,6 @@ exports.symlinksCheck = void 0;
 exports.isBrokenSymlink = isBrokenSymlink;
 const node_fs_1 = __importDefault(require("node:fs"));
 const node_path_1 = __importDefault(require("node:path"));
-const config_1 = require("../../../config");
 const utils_1 = require("../../../utils");
 const targets_1 = require("../../targets");
 const types_1 = require("../../types");
@@ -42,9 +41,12 @@ exports.symlinksCheck = {
         return ctx.config.symlinks?.enabled !== false;
     },
     async run(ctx) {
-        const files = await (0, targets_1.listTrackedFiles)(ctx, ['*'], (0, config_1.getSourcePaths)());
-        if (files.length === 0)
-            return (0, types_1.skip)('no tracked files');
+        const files = await (0, targets_1.resolveTargets)(ctx, ['*'], {
+            wholeTree: true,
+            onEmpty: { skip: 'no tracked files' },
+        });
+        if (!Array.isArray(files))
+            return files;
         const ignore = ctx.config.symlinks?.ignore ?? [];
         const broken = [];
         for (const file of files) {

package/dist/core/checks/security/diff-security.js

@@ -3,7 +3,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.diffSecurityCheck = void 0;
 const config_1 = require("../../../config");
 const utils_1 = require("../../../utils");
-const targets_1 = require("../../targets");
 const types_1 = require("../../types");
 const findings_1 = require("../findings");
 const MD5_LABEL = 'MD5 (weak hash — use sha256 or stronger)';
@@ -298,6 +297,9 @@ exports.diffSecurityCheck = {
                 // to them, matching `duplicate.ignore` and `deadCode.ignoreFiles`. A client
                 // who wants their tests scanned says so by listing something else here.
                 ignorePaths: cfg.ignorePaths ?? config_1.DIFF_SECURITY_IGNORE_DEFAULTS,
+                // This check owns the cross-line heuristic, so it is the one that turns it
+                // on. `0` from the client switches it off.
+                dataflowWindow: cfg.dataflowWindow ?? findings_1.DEFAULT_DATAFLOW_WINDOW,
             };
             const extra = compileExtraPatterns(ctx);
             const disabled = cfg.disablePatterns ?? [];
@@ -306,33 +308,39 @@ exports.diffSecurityCheck = {
             };
             /**
              * Feed one language's sources through the patterns, from the diff when
-             * there is one and from the files themselves otherwise. Both paths reach
-             * `scanDiffPatterns` in the same shape, so the two modes cannot disagree
-             * about what counts as a finding.
+             * there is one and from the files themselves otherwise.
+             *
+             * Through {@link reviewLines}, like the four other checks that need both
+             * modes. This used to be its body copied inline, on the assumption that a
+             * closure was needed to carry `patterns` — it is not, that is what `onChunk`
+             * is for, and the copy meant `fullScanBehaviour` and the `null`/`[]`
+             * distinction lived in two places, one of them a blocking security check
+             * (ticket 079).
              */
-            const review = async (globs, patterns) => {
-                if (ctx.baseSha) {
-                    scanInto(await (0, findings_1.diffAddedLines)(ctx, globs), patterns);
-                    return;
-                }
-                if (ctx.config.run?.fullScanBehaviour === 'skip')
-                    return;
-                const files = await (0, targets_1.listTrackedFiles)(ctx, globs, ['.']);
-                await (0, findings_1.scanTrackedFiles)(ctx, files, asDiff => scanInto(asDiff, patterns));
-            };
+            const review = (globs, patterns) => (0, findings_1.reviewLines)(ctx, globs, stdout => scanInto(stdout, patterns));
             // JS/TS patterns always run; language-specific sets scan their own globs
             // only when that language is present, so a Python repo gets Python rules.
             // Client `extraPatterns` run against every scanned language, since a
             // project rule is not tied to the built-in language split.
-            await review(JS_GLOBS, [...SECURITY_PATTERNS, ...extra]);
+            const sets = [[JS_GLOBS, [...SECURITY_PATTERNS, ...extra]]];
             if (ctx.languages.includes('python')) {
-                await review(['*.py'], [...PYTHON_SECURITY_PATTERNS, ...extra]);
+                sets.push([['*.py'], [...PYTHON_SECURITY_PATTERNS, ...extra]]);
             }
             if (ctx.languages.includes('go')) {
-                await review(['*.go'], [...GO_SECURITY_PATTERNS, ...extra]);
+                sets.push([['*.go'], [...GO_SECURITY_PATTERNS, ...extra]]);
             }
             if (ctx.languages.includes('kotlin')) {
-                await review(['*.kt', '*.kts', '*.java'], [...KOTLIN_SECURITY_PATTERNS, ...extra]);
+                sets.push([
+                    ['*.kt', '*.kts', '*.java'],
+                    [...KOTLIN_SECURITY_PATTERNS, ...extra],
+                ]);
+            }
+            for (const [globs, patterns] of sets) {
+                // One failed set fails the check. A partial answer is worse than none
+                // here: three of five language sets scanned, reported as a pass, reads
+                // as a clean repository (ticket 072).
+                if (!(await review(globs, patterns)))
+                    return (0, types_1.skip)('git unavailable');
             }
             return (0, findings_1.reportSeverityBuckets)(found.errors, found.warnings, {
                 prefix: 'Diff Security',

package/dist/core/checks/security/dockerfile-security.js

@@ -30,7 +30,13 @@ const DOCKER_PATTERNS = [
         severity: 'warn',
     },
     {
-        pattern: /^\+(?!\+)\s*(?:ENV|ARG)\s+\w*(?:PASSWORD|SECRET|TOKEN|API_?KEY|ACCESS_KEY)\w*\s*[=\s]/i,
+        // The `_FILE`/`_PATH` exclusion is not a loophole, it is the thing this rule
+        // is trying to steer people towards: `ENV DB_PASSWORD_FILE=/run/secrets/db`
+        // names a location, holds no secret, and is how Docker and Kubernetes tell
+        // you to do it. Flagging the correct practice alongside the wrong one is how
+        // a rule gets switched off — and it teaches obscuring the variable name,
+        // which makes the next real secret harder to spot, not easier.
+        pattern: /^\+(?!\+)\s*(?:ENV|ARG)\s+\w*(?:PASSWORD|SECRET|TOKEN|API_?KEY|ACCESS_KEY)\w*(?<!_FILE)(?<!_PATH)(?<!_FILEPATH)\s*[=\s]/i,
         label: 'secret baked into ENV/ARG (use build secrets / runtime injection)',
         severity: 'warn',
     },

package/dist/core/checks/security/migration-safety.js

@@ -48,17 +48,45 @@ function isAddNotNullNoDefault(line) {
         /\bNOT\s+NULL\b/i.test(line) &&
         !/\bDEFAULT\b/i.test(line));
 }
+/**
+ * Drop the comment from an added migration line, keeping the leading `+` so the
+ * patterns stay anchored on it.
+ *
+ * This check does its own matching rather than going through `scanDiffPatterns`,
+ * and it inherited none of the comment handling — so a commented-out statement
+ * was reported as destructive. `-- DROP TABLE users;` does nothing, and calling
+ * it "irreversible data loss" is noise on the most alarming label the product
+ * prints. Found by ticket 062's corpus.
+ *
+ * Only the two markers that are unambiguous in the files this check looks at:
+ * `--` in SQL and `#` in Python/Ruby migrations. `--` is required to be preceded
+ * by whitespace or the line start, which keeps it away from an identifier like
+ * `a--b` and from most string contents; `stripInlineComment` handles `#` with the
+ * string awareness it already has.
+ */
+function withoutComment(line) {
+    // The diff marker is split off first: `+-- DROP TABLE` puts `--` immediately
+    // after the `+`, where a boundary rule looking for whitespace or line-start
+    // does not see it — which is exactly the shape a commented-out statement takes.
+    const marker = line.startsWith('+') ? '+' : '';
+    const body = (0, findings_1.stripInlineComment)(line.slice(marker.length), 'hash').replace(/(^|\s)--.*$/, '$1');
+    return marker + body;
+}
 /** Bucket dangerous added lines by risk label, honouring the opt-out directive. */
 function scan(stdout, findings) {
     for (const line of stdout.split('\n')) {
         if (line.includes('pr-checkmate-ignore'))
             continue;
+        // The sample keeps the ORIGINAL line: the reader needs to see what was
+        // written, comment and all, even though the match ran on the code.
+        const code = withoutComment(line);
+        const sample = () => line.slice(1).trim().substring(0, 120);
         for (const { pattern, label } of DDL_PATTERNS) {
-            if (pattern.test(line))
-                (findings[label] ?? (findings[label] = [])).push(line.slice(1).trim().substring(0, 120));
+            if (pattern.test(code))
+                (findings[label] ?? (findings[label] = [])).push(sample());
         }
-        if (isAddNotNullNoDefault(line)) {
-            (findings[NOT_NULL_NO_DEFAULT] ?? (findings[NOT_NULL_NO_DEFAULT] = [])).push(line.slice(1).trim().substring(0, 120));
+        if (isAddNotNullNoDefault(code)) {
+            (findings[NOT_NULL_NO_DEFAULT] ?? (findings[NOT_NULL_NO_DEFAULT] = [])).push(sample());
         }
     }
 }

package/dist/core/checks/security/security.d.ts

@@ -1,4 +1,60 @@
 import { Check } from '../../types';
+/**
+ * A HOME the scanner can actually write to.
+ *
+ * The bundled wrapper caches the gitleaks binary in `os.homedir()/.gitleaks-cache`
+ * and offers no way to move it — the path is hardcoded. So in any environment
+ * where HOME is not writable it crashes before scanning a single commit. That is
+ * not exotic: it is what the container does under `--user "$(id -u):$(id -g)"`,
+ * the invocation our own entrypoint and docs recommend, where HOME is `/`.
+ *
+ * Redirecting to the temp directory costs nothing that was available anyway — if
+ * HOME cannot be written to, there was no `~/.gitconfig` of ours to lose either.
+ */
+/**
+ * How many secrets the scan actually found.
+ *
+ * The row used to read `❌ Security Scan: potential secrets detected` whether the
+ * number was one or thirty-nine, and that is not a cosmetic gap. It is the reason
+ * a real regression nearly shipped: an allowlist entry removed six genuine
+ * `Generic API Key` findings from a client repository, 39 → 33, and the A/B sweep
+ * that compares report rows across 28 repositories saw two identical lines
+ * (ticket 085). A check that finds things has to say how many, or nothing can
+ * tell whether it started finding fewer.
+ *
+ * Read from gitleaks' JSON report rather than counted out of its console output —
+ * the same lesson as ticket 078, where the clone count was parsed from an English
+ * sentence and would have reported zero on a repository full of duplication.
+ *
+ * @returns The count, or `null` when the report could not be read — in which case
+ *   the caller keeps its old wording rather than claiming a number it does not have.
+ */
+export declare function countFindings(reportPath: string): number | null;
+/**
+ * How the outcome names what was found.
+ *
+ * Its own function so both halves are reachable without running the scanner. The
+ * corpus for this check deliberately does not: the wrapper downloads a gitleaks
+ * binary on first use, and a unit suite that reaches the network is the thing the
+ * `installer` seam in `ensure.ts` exists to avoid. What broke here was the wording
+ * — a row that read the same for one secret and for thirty-nine — and the wording
+ * is testable on its own.
+ *
+ * `null` keeps the old sentence rather than inventing a number: a report we could
+ * not read is not a reason to claim a count.
+ */
+export declare function secretsSummary(found: number | null): string;
+/**
+ * Whether the wrapper died instead of reporting, judged from its stderr.
+ *
+ * The wrapper is a Node script, and Node exits **1** on an unhandled exception —
+ * the same code gitleaks itself uses for "secrets found". Left undistinguished,
+ * a scanner that never ran is reported as `potential secrets detected`, pointing
+ * at a report file that was never written. A gate accusing a clean repository is
+ * the same class of failure as one that stays quiet about a real leak, and this
+ * is the only signal available to tell them apart.
+ */
+export declare function looksLikeCrash(stderr: string): boolean;
 /**
  * Secret scanning via the bundled gitleaks package. Language-agnostic — runs on
  * every repo (Node, Python, C++, mobile). Secrets found → fail (blocking).

package/dist/core/checks/security/security.js

@@ -1,10 +1,107 @@
 "use strict";
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.securityCheck = void 0;
+exports.countFindings = countFindings;
+exports.secretsSummary = secretsSummary;
+exports.looksLikeCrash = looksLikeCrash;
+const node_fs_1 = __importDefault(require("node:fs"));
+const node_os_1 = __importDefault(require("node:os"));
+const node_path_1 = __importDefault(require("node:path"));
 const config_1 = require("../../../config");
 const utils_1 = require("../../../utils");
 const execa_1 = require("../../../utils/execa");
 const types_1 = require("../../types");
+/**
+ * A HOME the scanner can actually write to.
+ *
+ * The bundled wrapper caches the gitleaks binary in `os.homedir()/.gitleaks-cache`
+ * and offers no way to move it — the path is hardcoded. So in any environment
+ * where HOME is not writable it crashes before scanning a single commit. That is
+ * not exotic: it is what the container does under `--user "$(id -u):$(id -g)"`,
+ * the invocation our own entrypoint and docs recommend, where HOME is `/`.
+ *
+ * Redirecting to the temp directory costs nothing that was available anyway — if
+ * HOME cannot be written to, there was no `~/.gitconfig` of ours to lose either.
+ */
+/**
+ * How many secrets the scan actually found.
+ *
+ * The row used to read `❌ Security Scan: potential secrets detected` whether the
+ * number was one or thirty-nine, and that is not a cosmetic gap. It is the reason
+ * a real regression nearly shipped: an allowlist entry removed six genuine
+ * `Generic API Key` findings from a client repository, 39 → 33, and the A/B sweep
+ * that compares report rows across 28 repositories saw two identical lines
+ * (ticket 085). A check that finds things has to say how many, or nothing can
+ * tell whether it started finding fewer.
+ *
+ * Read from gitleaks' JSON report rather than counted out of its console output —
+ * the same lesson as ticket 078, where the clone count was parsed from an English
+ * sentence and would have reported zero on a repository full of duplication.
+ *
+ * @returns The count, or `null` when the report could not be read — in which case
+ *   the caller keeps its old wording rather than claiming a number it does not have.
+ */
+function countFindings(reportPath) {
+    try {
+        const report = JSON.parse(node_fs_1.default.readFileSync(reportPath, 'utf-8'));
+        return Array.isArray(report) ? report.length : null;
+    }
+    catch {
+        return null;
+    }
+}
+/**
+ * How the outcome names what was found.
+ *
+ * Its own function so both halves are reachable without running the scanner. The
+ * corpus for this check deliberately does not: the wrapper downloads a gitleaks
+ * binary on first use, and a unit suite that reaches the network is the thing the
+ * `installer` seam in `ensure.ts` exists to avoid. What broke here was the wording
+ * — a row that read the same for one secret and for thirty-nine — and the wording
+ * is testable on its own.
+ *
+ * `null` keeps the old sentence rather than inventing a number: a report we could
+ * not read is not a reason to claim a count.
+ */
+function secretsSummary(found) {
+    return found === null ? 'potential secrets detected' : `${found} potential secret(s)`;
+}
+function writableHome() {
+    const home = node_os_1.default.homedir();
+    try {
+        node_fs_1.default.accessSync(home, node_fs_1.default.constants.W_OK);
+        return home;
+    }
+    catch { }
+    const fallback = node_os_1.default.tmpdir();
+    try {
+        node_fs_1.default.accessSync(fallback, node_fs_1.default.constants.W_OK);
+        utils_1.logger.info(`[Security Scan]: HOME (${home}) is not writable — caching the scanner in ${fallback}`);
+        return fallback;
+    }
+    catch {
+        return null;
+    }
+}
+/**
+ * Whether the wrapper died instead of reporting, judged from its stderr.
+ *
+ * The wrapper is a Node script, and Node exits **1** on an unhandled exception —
+ * the same code gitleaks itself uses for "secrets found". Left undistinguished,
+ * a scanner that never ran is reported as `potential secrets detected`, pointing
+ * at a report file that was never written. A gate accusing a clean repository is
+ * the same class of failure as one that stays quiet about a real leak, and this
+ * is the only signal available to tell them apart.
+ */
+function looksLikeCrash(stderr) {
+    // The errno names are written out rather than factored to a shared `E` prefix:
+    // `E(?:ACCES|PERM|…)` saves four characters and costs the reader the ability to
+    // grep for the thing they are debugging.
+    return /^\s*(?:[A-Za-z]*Error|Uncaught|node:internal)|\b(?:EACCES|EPERM|ENOENT|EROFS)\b/m.test(stderr);
+}
 /**
  * Secret scanning via the bundled gitleaks package. Language-agnostic — runs on
  * every repo (Node, Python, C++, mobile). Secrets found → fail (blocking).
@@ -29,11 +126,7 @@ exports.securityCheck = {
             utils_1.logger.warn('[Security Scan]: ⚠️ bundled gitleaks scanner could not be resolved — skipping');
             return (0, types_1.skip)('gitleaks unavailable');
         }
-        const hasClientConfig = (0, config_1.hasLocalConfig)([
-            '.gitleaks.toml',
-            'gitleaks.toml',
-            '.gitleaks/config.toml',
-        ]);
+        const hasClientConfig = (0, config_1.hasLocalConfig)(['.gitleaks.toml', 'gitleaks.toml', '.gitleaks/config.toml'], ctx.cwd);
         // Pin the gitleaks binary version so the scanner never reaches out to the
         // GitHub API for the "latest" version — that network call adds latency and
         // times out in locked-down/offline CI (the scanner already falls back to
@@ -62,25 +155,56 @@ exports.securityCheck = {
         if (!hasClientConfig) {
             args.push('--config', (0, config_1.getPackageConfigPath)('gitleaks.toml'));
         }
+        // A machine-readable copy of the findings, purely so the outcome can carry a
+        // number. Written to a temp directory, never into the repository under review:
+        // a check whose side effect is a new untracked file shows up in the client's
+        // next commit. The console output is untouched — `stdio: inherit` below still
+        // streams the scanner's own report, which is what a reader actually looks at.
+        const reportDir = node_fs_1.default.mkdtempSync(node_path_1.default.join(node_os_1.default.tmpdir(), 'pr-checkmate-gitleaks-'));
+        const reportPath = node_path_1.default.join(reportDir, 'findings.json');
+        args.push('--report-format', 'json', '--report-path', reportPath);
         utils_1.logger.info(`[Security Scan]: scanning ${isDelta ? 'the diff range' : `full history${depth ? ` (last ${depth} commits)` : ''}`}`);
+        const home = writableHome();
+        if (!home)
+            return (0, types_1.skip)('no writable directory for the scanner cache');
         const env = {
             ...process.env,
+            HOME: home,
             ...(ctx.headSha ? { HEAD_SHA: ctx.headSha } : {}),
             ...(ctx.baseSha ? { BASE_SHA: ctx.baseSha } : {}),
         };
+        // stdout stays inherited so the scanner's own report streams to the log as it
+        // always has; stderr is captured because it is the only thing that separates
+        // a crash from a finding — see `crashed`.
         const result = await (0, execa_1.execa)(process.execPath, [gitleaksBin, ...args], {
             cwd: ctx.cwd,
             env,
-            stdio: 'inherit',
+            stdio: ['ignore', 'inherit', 'pipe'],
             reject: false,
         });
+        const stderr = String(result.stderr ?? '');
+        if (stderr.trim())
+            utils_1.logger.warn(stderr.trimEnd());
+        const found = countFindings(reportPath);
+        node_fs_1.default.rmSync(reportDir, { recursive: true, force: true });
         if (result.exitCode === 0)
             return (0, types_1.pass)();
-        // gitleaks exits 1 specifically when it finds secrets — that is a real violation.
-        if (result.exitCode === 1) {
-            utils_1.logger.warn('⚠️ gitleaks found potential secrets — review gitleaks-report.html');
-            return (0, types_1.fail)('potential secrets detected');
+        // gitleaks exits 1 specifically when it finds secrets — but so does Node when
+        // the wrapper around it throws. Only the second one leaves a stack trace.
+        if (result.exitCode === 1 && !looksLikeCrash(stderr)) {
+            // The findings themselves are already above, streamed from the scanner. This
+            // used to say "review gitleaks-report.html" — a file the check never wrote:
+            // `--html-report` is passed by our own `scan:secrets` npm script and by
+            // nothing else, so a blocking check told the client to open something that
+            // does not exist (ticket 085).
+            const summary = secretsSummary(found);
+            utils_1.logger.warn(`⚠️ gitleaks found ${summary} — see the findings above`);
+            return (0, types_1.fail)(summary);
         }
-        return (0, types_1.warn)(`scanner error (exit ${result.exitCode})`);
+        const detail = looksLikeCrash(stderr)
+            ? 'scanner failed to start — nothing was scanned'
+            : `scanner error (exit ${result.exitCode})`;
+        utils_1.logger.warn(`[Security Scan]: ⚠️ ${detail}`);
+        return (0, types_1.warn)(detail);
     },
 };