ppcos 1.0.6 → 1.0.8

package/lib/utils/migrations.js

@@ -0,0 +1,204 @@
+/**
+ * One-time client manifest migrations.
+ *
+ * Each migration is idempotent — safe to run on every update.
+ * Add new migrations here and call them from runAllMigrations().
+ */
+
+import { readFileSync, writeFileSync, existsSync, unlinkSync } from 'node:fs';
+import { join } from 'node:path';
+import { isConfigFile } from './manifest.js';
+import { ensureDir } from './fs-helpers.js';
+import logger from './logger.js';
+
+/**
+ * Ensure memory folder exists in client workspace.
+ * Creates context/memory/ if it doesn't exist (for existing clients).
+ * @param {string} clientDir - Path to client directory
+ */
+export async function ensureMemoryFolder(clientDir) {
+  const memoryDir = join(clientDir, 'context', 'memory');
+  if (!existsSync(memoryDir)) {
+    await ensureDir(memoryDir);
+    logger.info('  Created context/memory/ folder');
+  }
+}
+
+/**
+ * One-time migration: merge deny rules into settings.local.json.
+ * Adds missing deny entries without touching existing config.
+ */
+export function migrateSettingsDenyRules(clientDir) {
+  const settingsPath = join(clientDir, '.claude', 'settings.local.json');
+  if (!existsSync(settingsPath)) return;
+
+  const requiredDeny = [
+    'Read(./.env)',
+    'Read(./.env.*)',
+    'Read(./secrets/**)'
+  ];
+
+  try {
+    const settings = JSON.parse(readFileSync(settingsPath, 'utf8'));
+    if (!settings.permissions) settings.permissions = {};
+    const existing = settings.permissions.deny || [];
+    const toAdd = requiredDeny.filter(rule => !existing.includes(rule));
+
+    if (toAdd.length === 0) return;
+
+    settings.permissions.deny = [...existing, ...toAdd];
+    writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
+    logger.info(`  Added ${toAdd.length} deny rule${toAdd.length !== 1 ? 's' : ''} to settings.local.json`);
+  } catch {
+    // Don't fail update over migration
+  }
+}
+
+/**
+ * One-time migration: merge hooks config into settings.local.json.
+ * Adds missing hook events without touching existing ones.
+ */
+export function migrateSettingsHooks(clientDir) {
+  const settingsPath = join(clientDir, '.claude', 'settings.local.json');
+  if (!existsSync(settingsPath)) return;
+
+  const requiredHooks = {
+    SessionStart: [
+      {
+        matcher: 'startup|resume|clear',
+        hooks: [
+          {
+            type: 'command',
+            command: '.claude/hooks/session-context-check.sh',
+            timeout: 30,
+            statusMessage: 'Checking context freshness...'
+          }
+        ]
+      }
+    ],
+    Stop: [
+      {
+        hooks: [
+          {
+            type: 'command',
+            command: '.claude/hooks/stop-memory-check.sh',
+            timeout: 10,
+            statusMessage: 'Checking memory log...'
+          }
+        ]
+      }
+    ],
+    PostCompact: [
+      {
+        hooks: [
+          {
+            type: 'command',
+            command: '.claude/hooks/post-compact-reminder.sh',
+            timeout: 30,
+            statusMessage: 'Restoring context after compaction...'
+          }
+        ]
+      }
+    ]
+  };
+
+  try {
+    const settings = JSON.parse(readFileSync(settingsPath, 'utf8'));
+    if (!settings.hooks) settings.hooks = {};
+
+    const added = [];
+    for (const [event, config] of Object.entries(requiredHooks)) {
+      if (!settings.hooks[event]) {
+        settings.hooks[event] = config;
+        added.push(event);
+      }
+    }
+
+    if (added.length === 0) return;
+
+    writeFileSync(settingsPath, JSON.stringify(settings, null, 2) + '\n');
+    logger.info(`  Added ${added.length} hook${added.length !== 1 ? 's' : ''} to settings.local.json (${added.join(', ')})`);
+  } catch {
+    // Don't fail update over migration
+  }
+}
+
+/**
+ * One-time migration: normalize backslash manifest keys to forward slashes.
+ * On Windows, getAllFiles() returned backslash paths which were stored as manifest keys.
+ * This normalizes them so lookups work cross-platform.
+ */
+export function migrateManifestKeys(manifest) {
+  let fixed = 0;
+  for (const [key, value] of Object.entries(manifest.managedFiles)) {
+    const normalized = key.replace(/\\/g, '/');
+    if (normalized !== key) {
+      delete manifest.managedFiles[key];
+      manifest.managedFiles[normalized] = value;
+      fixed++;
+    }
+  }
+  for (const conflict of (manifest.conflicts || [])) {
+    if (conflict.file) {
+      conflict.file = conflict.file.replace(/\\/g, '/');
+    }
+  }
+  if (fixed > 0) {
+    logger.info(`  Normalized ${fixed} manifest key${fixed !== 1 ? 's' : ''}`);
+  }
+}
+
+/**
+ * One-time migration: fix managedType for config files.
+ * On Windows, isConfigFile() failed due to backslash paths, so config files
+ * got stored with managedType 'update' instead of 'config'.
+ * This corrects existing manifests in-place (before detectModifications runs).
+ */
+export function migrateConfigManagedTypes(manifest) {
+  let fixed = 0;
+  for (const [path, info] of Object.entries(manifest.managedFiles)) {
+    if (isConfigFile(path) && info.managedType !== 'config') {
+      info.managedType = 'config';
+      fixed++;
+    }
+  }
+  if (fixed > 0) {
+    logger.info(`  Fixed managedType for ${fixed} config file${fixed !== 1 ? 's' : ''}`);
+  }
+}
+
+/**
+ * One-time migration: remove leaked data files from skill tmp/ directories.
+ * Data files were accidentally included in .claude-base.zip and distributed
+ * to clients. This removes them and cleans up the manifest.
+ */
+export function migrateTmpDataFiles(clientDir, manifest) {
+  const keepFiles = new Set(['.gitkeep', '.gitignore']);
+  let removed = 0;
+  for (const [path] of Object.entries(manifest.managedFiles)) {
+    if (!/\/tmp\//.test(path)) continue;
+    const filename = path.split('/').pop();
+    if (keepFiles.has(filename)) continue;
+    const fullPath = join(clientDir, path);
+    if (existsSync(fullPath)) unlinkSync(fullPath);
+    delete manifest.managedFiles[path];
+    removed++;
+  }
+  if (removed > 0) {
+    logger.info(`  Removed ${removed} tmp data file${removed !== 1 ? 's' : ''} from tmp/`);
+  }
+}
+
+/**
+ * Run all client migrations in order.
+ * @param {string} clientDir - Path to client directory
+ * @param {object} manifest - The manifest object (mutated in place)
+ */
+export async function runAllMigrations(clientDir, manifest) {
+  await ensureMemoryFolder(clientDir);
+  migrateSettingsDenyRules(clientDir);
+  migrateSettingsHooks(clientDir);
+  migrateManifestKeys(manifest);
+  migrateConfigManagedTypes(manifest);
+  migrateTmpDataFiles(clientDir, manifest);
+}

package/lib/utils/paths.js

@@ -0,0 +1,88 @@
+/**
+ * Shared path, version, and client discovery helpers.
+ *
+ * Single source of truth — command files import from here
+ * instead of duplicating these functions.
+ */
+
+import { readFileSync, existsSync, readdirSync } from 'node:fs';
+import { join, dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { manifestExists } from './manifest.js';
+
+// Package root: two levels up from lib/utils/
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+const PACKAGE_ROOT = join(__dirname, '..', '..');
+
+/**
+ * Get package version from package.json
+ * @returns {string}
+ */
+export function getPackageVersion() {
+  const pkgPath = join(PACKAGE_ROOT, 'package.json');
+  const pkg = JSON.parse(readFileSync(pkgPath, 'utf8'));
+  return pkg.version;
+}
+
+/**
+ * Get the package root directory
+ * @returns {string}
+ */
+export function getPackageRoot() {
+  return PACKAGE_ROOT;
+}
+
+/**
+ * Get path to .claude-base template directory
+ * @returns {string}
+ */
+export function getBaseTemplatePath() {
+  return join(PACKAGE_ROOT, '.claude-base');
+}
+
+/**
+ * Get path to hub-base template directory
+ * @returns {string}
+ */
+export function getHubBasePath() {
+  return join(PACKAGE_ROOT, 'hub-base');
+}
+
+/**
+ * Get clients directory path
+ * @param {object} [config] - Optional config with settings.clientsDirectory
+ * @returns {string}
+ */
+export function getClientsDir(config) {
+  if (config?.settings?.clientsDirectory) {
+    return join(process.cwd(), config.settings.clientsDirectory);
+  }
+  return join(process.cwd(), 'clients');
+}
+
+/**
+ * Find all client directories with .managed.json
+ * @returns {string[]} Array of client names
+ */
+export function discoverClients() {
+  const clientsDir = getClientsDir();
+
+  if (!existsSync(clientsDir)) {
+    return [];
+  }
+
+  const entries = readdirSync(clientsDir, { withFileTypes: true });
+  const clients = [];
+
+  for (const entry of entries) {
+    if (entry.isDirectory()) {
+      const clientDir = join(clientsDir, entry.name);
+      if (manifestExists(clientDir)) {
+        clients.push(entry.name);
+      }
+    }
+  }
+
+  return clients;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ppcos",
-  "version": "1.0.6",
+  "version": "1.0.8",
   "description": "CLI tool to manage Google Ads AI workflow skills and agents for Claude Code",
   "type": "module",
   "bin": {