powerbi-visuals-tools 7.0.2 → 7.0.3

package/Changelog.md

@@ -2,6 +2,10 @@
 
 This page contains information about changes to the PowerBI Visual Tools (pbiviz).
 
+## 7.0.3
+* Fixed missing validation for `author` object in pbiviz.json. The `author` object with `name` and `email` fields is now required.
+* Updated packages.
+
 ## 7.0.2
 * Changed source map generation to `eval-source-map`.
 * Fixed load source map error.

package/eslint.config.mjs

@@ -2,18 +2,21 @@ import typescriptEslint from "@typescript-eslint/eslint-plugin";
 import globals from "globals";
 import tsParser from "@typescript-eslint/parser";
 
+const __dirname = import.meta.dirname; // built-in, no imports needed
+
 export default [ 
     {
-        files: ["*.ts", "*tsx"],
         ignores: [
-            "node_modules/",
-            "dist/",
-            "templates/",
-            "spec/*/**",
-            "**/lib/",
-            "bin/",
-            "eslint.config.mjs",
+            "node_modules/**",
+            "dist/**",
+            "templates/**",
+            "spec/**",
+            "lib/**",
+            "bin/**",
         ],
+    },
+    {
+        files: ["**/*.ts", "**/*.tsx"],
         plugins: {
             "@typescript-eslint": typescriptEslint,
         },
@@ -26,7 +29,7 @@ export default [
             sourceType: "module",
             parserOptions: {
                 project: "tsconfig.json",
-                tsconfigRootDir: ".",
+                tsconfigRootDir: __dirname,
             },
         },
         rules: {

package/lib/CertificateTools.js

@@ -179,7 +179,7 @@ async function openCertFile() {
         }
         await exec(`${startCmd} "${certPath}"`);
     }
-    catch (e) {
+    catch {
         ConsoleWriter.info(['Certificate path:', certPath]);
     }
 }

package/lib/Visual.js

@@ -17,6 +17,12 @@ export class Visual {
     isVisualVersionValid(length) {
         return this.visualVersion.split(".").length === length;
     }
+    isAuthorDefined() {
+        const author = this.config?.author;
+        const emailRegex = /^[a-zA-Z0-9._%+\-]+@[a-zA-Z0-9.\-]+\.[a-zA-Z]{2,}$/;
+        return typeof author?.name === "string" && author.name.length > 0 &&
+            typeof author?.email === "string" && emailRegex.test(author.email);
+    }
     getVisualFeatureType() {
         const isMatrixSupported = this.capabilities?.dataViewMappings?.some(dataView => dataView.matrix);
         const isSlicer = Boolean(this.capabilities?.objects?.general?.properties?.filter?.type?.filter);

package/lib/VisualGenerator.js

@@ -96,7 +96,7 @@ function fileExists(file) {
     try {
         fs.accessSync(file);
     }
-    catch (e) {
+    catch {
         return false;
     }
     return true;
@@ -120,7 +120,7 @@ function validTemplate(templateName) {
     try {
         fs.accessSync(path.join(VISUAL_TEMPLATES_PATH, templateName));
     }
-    catch (e) {
+    catch {
         return false;
     }
     return true;

package/lib/WebPackWrap.js

@@ -6,7 +6,6 @@ import util from 'util';
 const exec = util.promisify(processExec);
 import { exec as processExec } from 'child_process';
 import lodashCloneDeep from 'lodash.clonedeep';
-import ExtraWatchWebpackPlugin from 'extra-watch-webpack-plugin';
 import { BundleAnalyzerPlugin } from 'webpack-bundle-analyzer';
 import { PowerBICustomVisualsWebpackPlugin, LocalizationLoader } from 'powerbi-visuals-webpack-plugin';
 import ConsoleWriter from './ConsoleWriter.js';
@@ -180,9 +179,14 @@ export default class WebPackWrap {
                 analyzerMode: `static`
             }));
         }
-        this.webpackConfig.plugins.push(new PowerBICustomVisualsWebpackPlugin(pluginConfiguration), new ExtraWatchWebpackPlugin({
-            files: this.pbiviz.capabilities
-        }));
+        this.webpackConfig.plugins.push(new PowerBICustomVisualsWebpackPlugin(pluginConfiguration), {
+            apply: (compiler) => {
+                compiler.hooks.afterCompile.tap('AddCapabilitiesWatch', (compilation) => {
+                    const capabilitiesPath = path.resolve(process.cwd(), this.pbiviz.capabilities);
+                    compilation.fileDependencies.add(capabilitiesPath);
+                });
+            }
+        });
     }
     async configureLoaders({ fast = false, includeAllLocales = false }) {
         this.webpackConfig.module.rules.push({

package/lib/features/AuthorInfo.js

@@ -0,0 +1,14 @@
+import { Severity, Stage, VisualFeatureType } from "./FeatureTypes.js";
+export default class AuthorInfo {
+    static featureName = "Author information";
+    static documentationLink = "https://learn.microsoft.com/en-us/power-bi/developer/visuals/visual-project-structure#metadata-entries";
+    static errorMessage = `${this.featureName} - ${this.documentationLink}`;
+    static severity = Severity.Error;
+    static stage = Stage.PreBuild;
+    static visualFeatureType = VisualFeatureType.All;
+    static isSupported(visual) {
+        return visual.isAuthorDefined();
+    }
+}
+// The pbiviz.json schema validates author.name and author.email when present,
+// but doesn't require the author object itself. This check fills that gap.

package/lib/features/index.js

@@ -1,6 +1,7 @@
 import AdvancedEditMode from './AdvancedEditMode.js';
 import AllowInteractions from './AllowInteractions.js';
 import AnalyticsPane from './AnalyticsPane.js';
+import AuthorInfo from './AuthorInfo.js';
 import Bookmarks from './Bookmarks.js';
 import ColorPalette from './ColorPalette.js';
 import ConditionalFormatting from './ConditionalFormatting.js';
@@ -25,4 +26,4 @@ import TotalSubTotal from './TotalSubTotal.js';
 import WarningIcon from './WarningIcon.js';
 import APIVersion from './APIVersion.js';
 import VisualVersion from './VisualVersion.js';
-export { AdvancedEditMode, AllowInteractions, AnalyticsPane, Bookmarks, ColorPalette, ConditionalFormatting, ContextMenu, DrillDown, FetchMoreData, FileDownload, FormatPane, HighContrast, HighlightData, KeyboardNavigation, LandingPage, LaunchURL, Localizations, LocalStorage, ModalDialog, RenderingEvents, SelectionAcrossVisuals, SyncSlicer, Tooltips, TotalSubTotal, WarningIcon, APIVersion, VisualVersion };
+export { AdvancedEditMode, AllowInteractions, AnalyticsPane, Bookmarks, ColorPalette, ConditionalFormatting, ContextMenu, DrillDown, FetchMoreData, FileDownload, FormatPane, HighContrast, HighlightData, KeyboardNavigation, LandingPage, LaunchURL, Localizations, LocalStorage, ModalDialog, RenderingEvents, SelectionAcrossVisuals, SyncSlicer, Tooltips, TotalSubTotal, WarningIcon, APIVersion, VisualVersion, AuthorInfo };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "powerbi-visuals-tools",
-  "version": "7.0.2",
+  "version": "7.0.3",
   "description": "Command line tool for creating and publishing visuals for Power BI",
   "main": "./bin/pbiviz.js",
   "type": "module",
@@ -12,6 +12,7 @@
     "jasmine": "node spec/jasmine-runner.js",
     "jasmine-inspect": "node --inspect spec/jasmine-runner.js",
     "lint": "npx eslint .",
+    "lint:fix": "npx eslint . --fix",
     "debug-tests": "npm run lint && npm run jasmine-inspect"
   },
   "bin": {
@@ -33,32 +34,32 @@
     "chalk": "^5.4.1",
     "commander": "^13.1.0",
     "compare-versions": "^6.1.1",
-    "css-loader": "^7.1.2",
+    "css-loader": "^7.1.4",
     "eslint-plugin-powerbi-visuals": "1.1.0",
-    "extra-watch-webpack-plugin": "^1.0.3",
     "fs-extra": "^11.3.3",
     "inline-source-map": "^0.6.3",
     "json-loader": "0.5.7",
     "jszip": "^3.10.1",
     "less": "^4.5.1",
-    "less-loader": "^12.3.0",
+    "less-loader": "^12.3.1",
     "lodash.clonedeep": "4.5.0",
     "lodash.defaults": "4.2.0",
     "lodash.isequal": "4.5.0",
     "lodash.ismatch": "^4.4.0",
-    "mini-css-extract-plugin": "^2.9.4",
-    "powerbi-visuals-webpack-plugin": "^4.3.1",
+    "mini-css-extract-plugin": "^2.10.0",
+    "powerbi-visuals-webpack-plugin": "^5.0.0",
     "terser-webpack-plugin": "^5.3.16",
     "ts-loader": "^9.5.4",
     "typescript": "^5.9.3",
-    "webpack": "^5.104.1",
+    "webpack": "^5.105.3",
     "webpack-bundle-analyzer": "4.10.2",
-    "webpack-dev-server": "^5.2.2"
+    "webpack-dev-server": "^5.2.3"
   },
   "devDependencies": {
     "@typescript-eslint/eslint-plugin": "^8.50.0",
-    "eslint": "^9.39.2",
-    "jasmine": "5.3.1",
+    "eslint": "^10.0.2",
+    "globals": "^17.3.0",
+    "jasmine": "^6.1.0",
     "jasmine-spec-reporter": "7.0.0",
     "semver": "7.7.3",
     "tree-kill": "1.2.2",
@@ -68,6 +69,6 @@
     "fsevents": "*"
   },
   "engines": {
-    "node": ">=18.0.0"
+    "node": ">=20.19.0"
   }
 }

package/tsconfig.json

@@ -14,7 +14,8 @@
         "ES2022",
         "dom"
       ],
-      "outDir": "lib"
+      "outDir": "lib",
+      "skipLibCheck": true
     },
     "include": [
       "src/**/*.ts"